Uh oh!
There was an error while loading. Please reload this page.
[wasm][globalization] HybridGlobalization fix bug in change case - #86799
Merged
Conversation
ghost
commented
May 26, 2023
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsFixes #86794. We should not allow the codepoints to expand because hybrid should work as much similar to ICU as possible.
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced May 26, 2023
Uh oh!
There was an error while loading. Please reload this page.
pavelsavara
approved these changes
May 29, 2023
ilonatommy
commented
May 30, 2023
MemberAuthor
ios failures not connected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#86794.
We should not allow the codepoints to expand because hybrid should work as much similar to ICU as possible.
ICU4C ignores "final sigma rule" (see documentation in the changes). We could support the inccorect ICU behavior but it's costly - e.g. by calling replace("\u03A3", "\u03C3") on each input string.