Emit armv8.4 ldapur* for volatile loads with contained offsets by EgorBo · Pull Request #89681 · dotnet/runtime

EgorBo · 2023-07-29T20:47:39Z

Contributes to #64457

volatileinta;volatileintb;volatileintc;volatileintd;[Benchmark]publicintTest(){returna+b+c+d;}

Current codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1)  stp fp, lr,[sp, #-0x10]! mov fp,spadd x1, x0, #8 ldapr w1,[x1]add x2, x0, #12 ldapr w2,[x2]add w1, w1, w2 add x2, x0, #16 ldapr w2,[x2]add w1, w1, w2 add x0, x0, #20 ldapr w0,[x0]add w0, w1, w0  ldp fp, lr,[sp], #0x10ret lr ; Total bytes of code 60

New codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1) stp fp, lr,[sp, #-0x10]!mov fp,sp ldapur w1,[x0, #0x08] ldapur w2,[x0, #0x0C]add w1, w1, w2 ldapur w2,[x0, #0x10]add w1, w1, w2 ldapur w0,[x0, #0x14]add w0, w1, w0 ldp fp, lr,[sp], #0x10ret lr; Total bytes of code 44

Apple M2 Max:

Method	Job	Toolchain	Mean	Error	StdDev	Ratio
Test	Job-LOXHRO	/Core_Root_PR/corerun	0.4724 ns	0.0050 ns	0.0045 ns	0.89
Test	Job-MPJUHL	/Core_Root_main/corerun	0.5327 ns	0.0063 ns	0.0059 ns	1.00

Perf difference is not super exciting but it is what it is 🙂

…ldar

…ldar # Conflicts: # src/coreclr/scripts/superpmi_diffs.py

ghost · 2023-07-29T20:47:49Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

volatileinta;volatileintb;volatileintc;volatileintd;[Benchmark]publicintTest(){returna+b+c+d;}

Current codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1)  stp fp, lr,[sp, #-0x10]! mov fp,spadd x1, x0, #8 ldapr w1,[x1]add x2, x0, #12 ldapr w2,[x2]add w1, w1, w2 add x2, x0, #16 ldapr w2,[x2]add w1, w1, w2 add x0, x0, #20 ldapr w0,[x0]add w0, w1, w0  ldp fp, lr,[sp], #0x10ret lr ; Total bytes of code 60

New codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1) stp fp, lr,[sp, #-0x10]!mov fp,sp ldapur w1,[x0, #0x08] ldapur w2,[x0, #0x0C]add w1, w1, w2 ldapur w2,[x0, #0x10]add w1, w1, w2 ldapur w0,[x0, #0x14]add w0, w1, w0 ldp fp, lr,[sp], #0x10ret lr; Total bytes of code 44

Method	Job	Toolchain	Mean	Error	StdDev	Ratio
Test	Job-LOXHRO	/Core_Root_PR/corerun	0.4724 ns	0.0050 ns	0.0045 ns	0.89
Test	Job-MPJUHL	/Core_Root_main/corerun	0.5327 ns	0.0063 ns	0.0059 ns	1.00

Perf difference is not super exciting but it is what it is 🙂

Author:	EgorBo
Assignees:	-
Labels:	`area-CodeGen-coreclr`
Milestone:	-

EgorBo · 2023-07-29T20:49:25Z

- static_assert_no_msg(INS_count <= 512);
- instruction _idIns : 9;
+ static_assert_no_msg(INS_count <= 1024);
+ instruction _idIns : 10;


I added a bit here since we now have more than 512 instructions (and that for sure will be increasing in future) but I also removed an used (on arm) _idCallRegPtr bit so the total size of the struct remains the same - 16b

EgorBo · 2023-08-27T12:55:00Z

@TIHan @dotnet/jit-contrib PTAL, simple change, emits ldapur where we previously emitted ldapr+add because ldapr doesn't support IMM offsets

TIHan · 2023-08-31T00:07:59Z

 {
 /* This is an indirect call (either a virtual call or func ptr call) */

- id->idSetIsCallRegPtr();


Why was this removed for arm32?

I mentioned it in https://github.com/dotnet/runtime/pull/89681/files#r1278410873 comment, basically, it sets a bit that is unused for arm, so I removed that bit because I needed to extend _idIns's width

TIHan

LGTM, only one comment on the idSetIsCallingRegPtr.

EgorBo · 2023-07-29T20:47:39Z

Contributes to #64457

volatileinta;volatileintb;volatileintc;volatileintd;[Benchmark]publicintTest(){returna+b+c+d;}

Current codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1)  stp fp, lr,[sp, #-0x10]! mov fp,spadd x1, x0, #8 ldapr w1,[x1]add x2, x0, #12 ldapr w2,[x2]add w1, w1, w2 add x2, x0, #16 ldapr w2,[x2]add w1, w1, w2 add x0, x0, #20 ldapr w0,[x0]add w0, w1, w0  ldp fp, lr,[sp], #0x10ret lr ; Total bytes of code 60

New codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1) stp fp, lr,[sp, #-0x10]!mov fp,sp ldapur w1,[x0, #0x08] ldapur w2,[x0, #0x0C]add w1, w1, w2 ldapur w2,[x0, #0x10]add w1, w1, w2 ldapur w0,[x0, #0x14]add w0, w1, w0 ldp fp, lr,[sp], #0x10ret lr; Total bytes of code 44

Apple M2 Max:

Method	Job	Toolchain	Mean	Error	StdDev	Ratio
Test	Job-LOXHRO	/Core_Root_PR/corerun	0.4724 ns	0.0050 ns	0.0045 ns	0.89
Test	Job-MPJUHL	/Core_Root_main/corerun	0.5327 ns	0.0063 ns	0.0059 ns	1.00

Perf difference is not super exciting but it is what it is 🙂

…ldar

…ldar # Conflicts: # src/coreclr/scripts/superpmi_diffs.py

ghost · 2023-07-29T20:47:49Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

volatileinta;volatileintb;volatileintc;volatileintd;[Benchmark]publicintTest(){returna+b+c+d;}

Current codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1)  stp fp, lr,[sp, #-0x10]! mov fp,spadd x1, x0, #8 ldapr w1,[x1]add x2, x0, #12 ldapr w2,[x2]add w1, w1, w2 add x2, x0, #16 ldapr w2,[x2]add w1, w1, w2 add x0, x0, #20 ldapr w0,[x0]add w0, w1, w0  ldp fp, lr,[sp], #0x10ret lr ; Total bytes of code 60

New codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1) stp fp, lr,[sp, #-0x10]!mov fp,sp ldapur w1,[x0, #0x08] ldapur w2,[x0, #0x0C]add w1, w1, w2 ldapur w2,[x0, #0x10]add w1, w1, w2 ldapur w0,[x0, #0x14]add w0, w1, w0 ldp fp, lr,[sp], #0x10ret lr; Total bytes of code 44

Method	Job	Toolchain	Mean	Error	StdDev	Ratio
Test	Job-LOXHRO	/Core_Root_PR/corerun	0.4724 ns	0.0050 ns	0.0045 ns	0.89
Test	Job-MPJUHL	/Core_Root_main/corerun	0.5327 ns	0.0063 ns	0.0059 ns	1.00

Perf difference is not super exciting but it is what it is 🙂

Author:	EgorBo
Assignees:	-
Labels:	`area-CodeGen-coreclr`
Milestone:	-

EgorBo · 2023-07-29T20:49:25Z

- static_assert_no_msg(INS_count <= 512);
- instruction _idIns : 9;
+ static_assert_no_msg(INS_count <= 1024);
+ instruction _idIns : 10;


I added a bit here since we now have more than 512 instructions (and that for sure will be increasing in future) but I also removed an used (on arm) _idCallRegPtr bit so the total size of the struct remains the same - 16b

EgorBo · 2023-08-27T12:55:00Z

@TIHan @dotnet/jit-contrib PTAL, simple change, emits ldapur where we previously emitted ldapr+add because ldapr doesn't support IMM offsets

TIHan · 2023-08-31T00:07:59Z

 {
 /* This is an indirect call (either a virtual call or func ptr call) */

- id->idSetIsCallRegPtr();


Why was this removed for arm32?

I mentioned it in https://github.com/dotnet/runtime/pull/89681/files#r1278410873 comment, basically, it sets a bit that is unused for arm, so I removed that bit because I needed to extend _idIns's width

TIHan

LGTM, only one comment on the idSetIsCallingRegPtr.

EgorBo · 2023-07-29T20:47:39Z

Contributes to #64457

volatileinta;volatileintb;volatileintc;volatileintd;[Benchmark]publicintTest(){returna+b+c+d;}

Current codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1)  stp fp, lr,[sp, #-0x10]! mov fp,spadd x1, x0, #8 ldapr w1,[x1]add x2, x0, #12 ldapr w2,[x2]add w1, w1, w2 add x2, x0, #16 ldapr w2,[x2]add w1, w1, w2 add x0, x0, #20 ldapr w0,[x0]add w0, w1, w0  ldp fp, lr,[sp], #0x10ret lr ; Total bytes of code 60

New codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1) stp fp, lr,[sp, #-0x10]!mov fp,sp ldapur w1,[x0, #0x08] ldapur w2,[x0, #0x0C]add w1, w1, w2 ldapur w2,[x0, #0x10]add w1, w1, w2 ldapur w0,[x0, #0x14]add w0, w1, w0 ldp fp, lr,[sp], #0x10ret lr; Total bytes of code 44

Apple M2 Max:

Method	Job	Toolchain	Mean	Error	StdDev	Ratio
Test	Job-LOXHRO	/Core_Root_PR/corerun	0.4724 ns	0.0050 ns	0.0045 ns	0.89
Test	Job-MPJUHL	/Core_Root_main/corerun	0.5327 ns	0.0063 ns	0.0059 ns	1.00

Perf difference is not super exciting but it is what it is 🙂

…ldar

…ldar # Conflicts: # src/coreclr/scripts/superpmi_diffs.py

ghost · 2023-07-29T20:47:49Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

volatileinta;volatileintb;volatileintc;volatileintd;[Benchmark]publicintTest(){returna+b+c+d;}

Current codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1)  stp fp, lr,[sp, #-0x10]! mov fp,spadd x1, x0, #8 ldapr w1,[x1]add x2, x0, #12 ldapr w2,[x2]add w1, w1, w2 add x2, x0, #16 ldapr w2,[x2]add w1, w1, w2 add x0, x0, #20 ldapr w0,[x0]add w0, w1, w0  ldp fp, lr,[sp], #0x10ret lr ; Total bytes of code 60

New codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1) stp fp, lr,[sp, #-0x10]!mov fp,sp ldapur w1,[x0, #0x08] ldapur w2,[x0, #0x0C]add w1, w1, w2 ldapur w2,[x0, #0x10]add w1, w1, w2 ldapur w0,[x0, #0x14]add w0, w1, w0 ldp fp, lr,[sp], #0x10ret lr; Total bytes of code 44

Method	Job	Toolchain	Mean	Error	StdDev	Ratio
Test	Job-LOXHRO	/Core_Root_PR/corerun	0.4724 ns	0.0050 ns	0.0045 ns	0.89
Test	Job-MPJUHL	/Core_Root_main/corerun	0.5327 ns	0.0063 ns	0.0059 ns	1.00

Perf difference is not super exciting but it is what it is 🙂

Author:	EgorBo
Assignees:	-
Labels:	`area-CodeGen-coreclr`
Milestone:	-

EgorBo · 2023-07-29T20:49:25Z

- static_assert_no_msg(INS_count <= 512);
- instruction _idIns : 9;
+ static_assert_no_msg(INS_count <= 1024);
+ instruction _idIns : 10;


I added a bit here since we now have more than 512 instructions (and that for sure will be increasing in future) but I also removed an used (on arm) _idCallRegPtr bit so the total size of the struct remains the same - 16b

EgorBo · 2023-08-27T12:55:00Z

@TIHan @dotnet/jit-contrib PTAL, simple change, emits ldapur where we previously emitted ldapr+add because ldapr doesn't support IMM offsets

TIHan · 2023-08-31T00:07:59Z

 {
 /* This is an indirect call (either a virtual call or func ptr call) */

- id->idSetIsCallRegPtr();


Why was this removed for arm32?

I mentioned it in https://github.com/dotnet/runtime/pull/89681/files#r1278410873 comment, basically, it sets a bit that is unused for arm, so I removed that bit because I needed to extend _idIns's width

TIHan

LGTM, only one comment on the idSetIsCallingRegPtr.

EgorBo · 2023-07-29T20:47:39Z

Contributes to #64457

volatileinta;volatileintb;volatileintc;volatileintd;[Benchmark]publicintTest(){returna+b+c+d;}

Current codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1)  stp fp, lr,[sp, #-0x10]! mov fp,spadd x1, x0, #8 ldapr w1,[x1]add x2, x0, #12 ldapr w2,[x2]add w1, w1, w2 add x2, x0, #16 ldapr w2,[x2]add w1, w1, w2 add x0, x0, #20 ldapr w0,[x0]add w0, w1, w0  ldp fp, lr,[sp], #0x10ret lr ; Total bytes of code 60

New codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1) stp fp, lr,[sp, #-0x10]!mov fp,sp ldapur w1,[x0, #0x08] ldapur w2,[x0, #0x0C]add w1, w1, w2 ldapur w2,[x0, #0x10]add w1, w1, w2 ldapur w0,[x0, #0x14]add w0, w1, w0 ldp fp, lr,[sp], #0x10ret lr; Total bytes of code 44

Apple M2 Max:

Method	Job	Toolchain	Mean	Error	StdDev	Ratio
Test	Job-LOXHRO	/Core_Root_PR/corerun	0.4724 ns	0.0050 ns	0.0045 ns	0.89
Test	Job-MPJUHL	/Core_Root_main/corerun	0.5327 ns	0.0063 ns	0.0059 ns	1.00

Perf difference is not super exciting but it is what it is 🙂

…ldar

…ldar # Conflicts: # src/coreclr/scripts/superpmi_diffs.py

ghost · 2023-07-29T20:47:49Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

volatileinta;volatileintb;volatileintc;volatileintd;[Benchmark]publicintTest(){returna+b+c+d;}

Current codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1)  stp fp, lr,[sp, #-0x10]! mov fp,spadd x1, x0, #8 ldapr w1,[x1]add x2, x0, #12 ldapr w2,[x2]add w1, w1, w2 add x2, x0, #16 ldapr w2,[x2]add w1, w1, w2 add x0, x0, #20 ldapr w0,[x0]add w0, w1, w0  ldp fp, lr,[sp], #0x10ret lr ; Total bytes of code 60

New codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1) stp fp, lr,[sp, #-0x10]!mov fp,sp ldapur w1,[x0, #0x08] ldapur w2,[x0, #0x0C]add w1, w1, w2 ldapur w2,[x0, #0x10]add w1, w1, w2 ldapur w0,[x0, #0x14]add w0, w1, w0 ldp fp, lr,[sp], #0x10ret lr; Total bytes of code 44

Method	Job	Toolchain	Mean	Error	StdDev	Ratio
Test	Job-LOXHRO	/Core_Root_PR/corerun	0.4724 ns	0.0050 ns	0.0045 ns	0.89
Test	Job-MPJUHL	/Core_Root_main/corerun	0.5327 ns	0.0063 ns	0.0059 ns	1.00

Perf difference is not super exciting but it is what it is 🙂

Author:	EgorBo
Assignees:	-
Labels:	`area-CodeGen-coreclr`
Milestone:	-

EgorBo · 2023-07-29T20:49:25Z

- static_assert_no_msg(INS_count <= 512);
- instruction _idIns : 9;
+ static_assert_no_msg(INS_count <= 1024);
+ instruction _idIns : 10;


I added a bit here since we now have more than 512 instructions (and that for sure will be increasing in future) but I also removed an used (on arm) _idCallRegPtr bit so the total size of the struct remains the same - 16b

EgorBo · 2023-08-27T12:55:00Z

@TIHan @dotnet/jit-contrib PTAL, simple change, emits ldapur where we previously emitted ldapr+add because ldapr doesn't support IMM offsets

TIHan · 2023-08-31T00:07:59Z

 {
 /* This is an indirect call (either a virtual call or func ptr call) */

- id->idSetIsCallRegPtr();


Why was this removed for arm32?

I mentioned it in https://github.com/dotnet/runtime/pull/89681/files#r1278410873 comment, basically, it sets a bit that is unused for arm, so I removed that bit because I needed to extend _idIns's width

TIHan

LGTM, only one comment on the idSetIsCallingRegPtr.

EgorBo · 2023-07-29T20:47:39Z

Contributes to #64457

volatileinta;volatileintb;volatileintc;volatileintd;[Benchmark]publicintTest(){returna+b+c+d;}

Current codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1)  stp fp, lr,[sp, #-0x10]! mov fp,spadd x1, x0, #8 ldapr w1,[x1]add x2, x0, #12 ldapr w2,[x2]add w1, w1, w2 add x2, x0, #16 ldapr w2,[x2]add w1, w1, w2 add x0, x0, #20 ldapr w0,[x0]add w0, w1, w0  ldp fp, lr,[sp], #0x10ret lr ; Total bytes of code 60

New codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1) stp fp, lr,[sp, #-0x10]!mov fp,sp ldapur w1,[x0, #0x08] ldapur w2,[x0, #0x0C]add w1, w1, w2 ldapur w2,[x0, #0x10]add w1, w1, w2 ldapur w0,[x0, #0x14]add w0, w1, w0 ldp fp, lr,[sp], #0x10ret lr; Total bytes of code 44

Apple M2 Max:

Method	Job	Toolchain	Mean	Error	StdDev	Ratio
Test	Job-LOXHRO	/Core_Root_PR/corerun	0.4724 ns	0.0050 ns	0.0045 ns	0.89
Test	Job-MPJUHL	/Core_Root_main/corerun	0.5327 ns	0.0063 ns	0.0059 ns	1.00

Perf difference is not super exciting but it is what it is 🙂

…ldar

…ldar # Conflicts: # src/coreclr/scripts/superpmi_diffs.py

ghost · 2023-07-29T20:47:49Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

volatileinta;volatileintb;volatileintc;volatileintd;[Benchmark]publicintTest(){returna+b+c+d;}

Current codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1)  stp fp, lr,[sp, #-0x10]! mov fp,spadd x1, x0, #8 ldapr w1,[x1]add x2, x0, #12 ldapr w2,[x2]add w1, w1, w2 add x2, x0, #16 ldapr w2,[x2]add w1, w1, w2 add x0, x0, #20 ldapr w0,[x0]add w0, w1, w0  ldp fp, lr,[sp], #0x10ret lr ; Total bytes of code 60

New codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1) stp fp, lr,[sp, #-0x10]!mov fp,sp ldapur w1,[x0, #0x08] ldapur w2,[x0, #0x0C]add w1, w1, w2 ldapur w2,[x0, #0x10]add w1, w1, w2 ldapur w0,[x0, #0x14]add w0, w1, w0 ldp fp, lr,[sp], #0x10ret lr; Total bytes of code 44

Method	Job	Toolchain	Mean	Error	StdDev	Ratio
Test	Job-LOXHRO	/Core_Root_PR/corerun	0.4724 ns	0.0050 ns	0.0045 ns	0.89
Test	Job-MPJUHL	/Core_Root_main/corerun	0.5327 ns	0.0063 ns	0.0059 ns	1.00

Perf difference is not super exciting but it is what it is 🙂

Author:	EgorBo
Assignees:	-
Labels:	`area-CodeGen-coreclr`
Milestone:	-

EgorBo · 2023-07-29T20:49:25Z

- static_assert_no_msg(INS_count <= 512);
- instruction _idIns : 9;
+ static_assert_no_msg(INS_count <= 1024);
+ instruction _idIns : 10;


I added a bit here since we now have more than 512 instructions (and that for sure will be increasing in future) but I also removed an used (on arm) _idCallRegPtr bit so the total size of the struct remains the same - 16b

EgorBo · 2023-08-27T12:55:00Z

@TIHan @dotnet/jit-contrib PTAL, simple change, emits ldapur where we previously emitted ldapr+add because ldapr doesn't support IMM offsets

TIHan · 2023-08-31T00:07:59Z

 {
 /* This is an indirect call (either a virtual call or func ptr call) */

- id->idSetIsCallRegPtr();


Why was this removed for arm32?

I mentioned it in https://github.com/dotnet/runtime/pull/89681/files#r1278410873 comment, basically, it sets a bit that is unused for arm, so I removed that bit because I needed to extend _idIns's width

TIHan

LGTM, only one comment on the idSetIsCallingRegPtr.

EgorBo · 2023-07-29T20:47:39Z

Contributes to #64457

volatileinta;volatileintb;volatileintc;volatileintd;[Benchmark]publicintTest(){returna+b+c+d;}

Current codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1)  stp fp, lr,[sp, #-0x10]! mov fp,spadd x1, x0, #8 ldapr w1,[x1]add x2, x0, #12 ldapr w2,[x2]add w1, w1, w2 add x2, x0, #16 ldapr w2,[x2]add w1, w1, w2 add x0, x0, #20 ldapr w0,[x0]add w0, w1, w0  ldp fp, lr,[sp], #0x10ret lr ; Total bytes of code 60

New codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1) stp fp, lr,[sp, #-0x10]!mov fp,sp ldapur w1,[x0, #0x08] ldapur w2,[x0, #0x0C]add w1, w1, w2 ldapur w2,[x0, #0x10]add w1, w1, w2 ldapur w0,[x0, #0x14]add w0, w1, w0 ldp fp, lr,[sp], #0x10ret lr; Total bytes of code 44

Apple M2 Max:

Method	Job	Toolchain	Mean	Error	StdDev	Ratio
Test	Job-LOXHRO	/Core_Root_PR/corerun	0.4724 ns	0.0050 ns	0.0045 ns	0.89
Test	Job-MPJUHL	/Core_Root_main/corerun	0.5327 ns	0.0063 ns	0.0059 ns	1.00

Perf difference is not super exciting but it is what it is 🙂

…ldar

…ldar # Conflicts: # src/coreclr/scripts/superpmi_diffs.py

ghost · 2023-07-29T20:47:49Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

volatileinta;volatileintb;volatileintc;volatileintd;[Benchmark]publicintTest(){returna+b+c+d;}

Current codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1)  stp fp, lr,[sp, #-0x10]! mov fp,spadd x1, x0, #8 ldapr w1,[x1]add x2, x0, #12 ldapr w2,[x2]add w1, w1, w2 add x2, x0, #16 ldapr w2,[x2]add w1, w1, w2 add x0, x0, #20 ldapr w0,[x0]add w0, w1, w0  ldp fp, lr,[sp], #0x10ret lr ; Total bytes of code 60

New codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1) stp fp, lr,[sp, #-0x10]!mov fp,sp ldapur w1,[x0, #0x08] ldapur w2,[x0, #0x0C]add w1, w1, w2 ldapur w2,[x0, #0x10]add w1, w1, w2 ldapur w0,[x0, #0x14]add w0, w1, w0 ldp fp, lr,[sp], #0x10ret lr; Total bytes of code 44

Method	Job	Toolchain	Mean	Error	StdDev	Ratio
Test	Job-LOXHRO	/Core_Root_PR/corerun	0.4724 ns	0.0050 ns	0.0045 ns	0.89
Test	Job-MPJUHL	/Core_Root_main/corerun	0.5327 ns	0.0063 ns	0.0059 ns	1.00

Perf difference is not super exciting but it is what it is 🙂

Author:	EgorBo
Assignees:	-
Labels:	`area-CodeGen-coreclr`
Milestone:	-

EgorBo · 2023-07-29T20:49:25Z

- static_assert_no_msg(INS_count <= 512);
- instruction _idIns : 9;
+ static_assert_no_msg(INS_count <= 1024);
+ instruction _idIns : 10;


I added a bit here since we now have more than 512 instructions (and that for sure will be increasing in future) but I also removed an used (on arm) _idCallRegPtr bit so the total size of the struct remains the same - 16b

EgorBo · 2023-08-27T12:55:00Z

@TIHan @dotnet/jit-contrib PTAL, simple change, emits ldapur where we previously emitted ldapr+add because ldapr doesn't support IMM offsets

TIHan · 2023-08-31T00:07:59Z

 {
 /* This is an indirect call (either a virtual call or func ptr call) */

- id->idSetIsCallRegPtr();


Why was this removed for arm32?

I mentioned it in https://github.com/dotnet/runtime/pull/89681/files#r1278410873 comment, basically, it sets a bit that is unused for arm, so I removed that bit because I needed to extend _idIns's width

TIHan

LGTM, only one comment on the idSetIsCallingRegPtr.

EgorBo · 2023-07-29T20:47:39Z

Contributes to #64457

volatileinta;volatileintb;volatileintc;volatileintd;[Benchmark]publicintTest(){returna+b+c+d;}

Current codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1)  stp fp, lr,[sp, #-0x10]! mov fp,spadd x1, x0, #8 ldapr w1,[x1]add x2, x0, #12 ldapr w2,[x2]add w1, w1, w2 add x2, x0, #16 ldapr w2,[x2]add w1, w1, w2 add x0, x0, #20 ldapr w0,[x0]add w0, w1, w0  ldp fp, lr,[sp], #0x10ret lr ; Total bytes of code 60

New codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1) stp fp, lr,[sp, #-0x10]!mov fp,sp ldapur w1,[x0, #0x08] ldapur w2,[x0, #0x0C]add w1, w1, w2 ldapur w2,[x0, #0x10]add w1, w1, w2 ldapur w0,[x0, #0x14]add w0, w1, w0 ldp fp, lr,[sp], #0x10ret lr; Total bytes of code 44

Apple M2 Max:

Method	Job	Toolchain	Mean	Error	StdDev	Ratio
Test	Job-LOXHRO	/Core_Root_PR/corerun	0.4724 ns	0.0050 ns	0.0045 ns	0.89
Test	Job-MPJUHL	/Core_Root_main/corerun	0.5327 ns	0.0063 ns	0.0059 ns	1.00

Perf difference is not super exciting but it is what it is 🙂

…ldar

…ldar # Conflicts: # src/coreclr/scripts/superpmi_diffs.py

ghost · 2023-07-29T20:47:49Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

volatileinta;volatileintb;volatileintc;volatileintd;[Benchmark]publicintTest(){returna+b+c+d;}

Current codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1)  stp fp, lr,[sp, #-0x10]! mov fp,spadd x1, x0, #8 ldapr w1,[x1]add x2, x0, #12 ldapr w2,[x2]add w1, w1, w2 add x2, x0, #16 ldapr w2,[x2]add w1, w1, w2 add x0, x0, #20 ldapr w0,[x0]add w0, w1, w0  ldp fp, lr,[sp], #0x10ret lr ; Total bytes of code 60

New codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1) stp fp, lr,[sp, #-0x10]!mov fp,sp ldapur w1,[x0, #0x08] ldapur w2,[x0, #0x0C]add w1, w1, w2 ldapur w2,[x0, #0x10]add w1, w1, w2 ldapur w0,[x0, #0x14]add w0, w1, w0 ldp fp, lr,[sp], #0x10ret lr; Total bytes of code 44

Method	Job	Toolchain	Mean	Error	StdDev	Ratio
Test	Job-LOXHRO	/Core_Root_PR/corerun	0.4724 ns	0.0050 ns	0.0045 ns	0.89
Test	Job-MPJUHL	/Core_Root_main/corerun	0.5327 ns	0.0063 ns	0.0059 ns	1.00

Perf difference is not super exciting but it is what it is 🙂

Author:	EgorBo
Assignees:	-
Labels:	`area-CodeGen-coreclr`
Milestone:	-

EgorBo · 2023-07-29T20:49:25Z

- static_assert_no_msg(INS_count <= 512);
- instruction _idIns : 9;
+ static_assert_no_msg(INS_count <= 1024);
+ instruction _idIns : 10;


I added a bit here since we now have more than 512 instructions (and that for sure will be increasing in future) but I also removed an used (on arm) _idCallRegPtr bit so the total size of the struct remains the same - 16b

EgorBo · 2023-08-27T12:55:00Z

@TIHan @dotnet/jit-contrib PTAL, simple change, emits ldapur where we previously emitted ldapr+add because ldapr doesn't support IMM offsets

TIHan · 2023-08-31T00:07:59Z

 {
 /* This is an indirect call (either a virtual call or func ptr call) */

- id->idSetIsCallRegPtr();


Why was this removed for arm32?

I mentioned it in https://github.com/dotnet/runtime/pull/89681/files#r1278410873 comment, basically, it sets a bit that is unused for arm, so I removed that bit because I needed to extend _idIns's width

TIHan

LGTM, only one comment on the idSetIsCallingRegPtr.

EgorBo · 2023-07-29T20:47:39Z

Contributes to #64457

volatileinta;volatileintb;volatileintc;volatileintd;[Benchmark]publicintTest(){returna+b+c+d;}

Current codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1)  stp fp, lr,[sp, #-0x10]! mov fp,spadd x1, x0, #8 ldapr w1,[x1]add x2, x0, #12 ldapr w2,[x2]add w1, w1, w2 add x2, x0, #16 ldapr w2,[x2]add w1, w1, w2 add x0, x0, #20 ldapr w0,[x0]add w0, w1, w0  ldp fp, lr,[sp], #0x10ret lr ; Total bytes of code 60

New codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1) stp fp, lr,[sp, #-0x10]!mov fp,sp ldapur w1,[x0, #0x08] ldapur w2,[x0, #0x0C]add w1, w1, w2 ldapur w2,[x0, #0x10]add w1, w1, w2 ldapur w0,[x0, #0x14]add w0, w1, w0 ldp fp, lr,[sp], #0x10ret lr; Total bytes of code 44

Apple M2 Max:

Method	Job	Toolchain	Mean	Error	StdDev	Ratio
Test	Job-LOXHRO	/Core_Root_PR/corerun	0.4724 ns	0.0050 ns	0.0045 ns	0.89
Test	Job-MPJUHL	/Core_Root_main/corerun	0.5327 ns	0.0063 ns	0.0059 ns	1.00

Perf difference is not super exciting but it is what it is 🙂

…ldar

…ldar # Conflicts: # src/coreclr/scripts/superpmi_diffs.py

ghost · 2023-07-29T20:47:49Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

volatileinta;volatileintb;volatileintc;volatileintd;[Benchmark]publicintTest(){returna+b+c+d;}

Current codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1)  stp fp, lr,[sp, #-0x10]! mov fp,spadd x1, x0, #8 ldapr w1,[x1]add x2, x0, #12 ldapr w2,[x2]add w1, w1, w2 add x2, x0, #16 ldapr w2,[x2]add w1, w1, w2 add x0, x0, #20 ldapr w0,[x0]add w0, w1, w0  ldp fp, lr,[sp], #0x10ret lr ; Total bytes of code 60

New codegen for Test:

; Assembly listing for method P:Test():int:this (Tier1) stp fp, lr,[sp, #-0x10]!mov fp,sp ldapur w1,[x0, #0x08] ldapur w2,[x0, #0x0C]add w1, w1, w2 ldapur w2,[x0, #0x10]add w1, w1, w2 ldapur w0,[x0, #0x14]add w0, w1, w0 ldp fp, lr,[sp], #0x10ret lr; Total bytes of code 44

Method	Job	Toolchain	Mean	Error	StdDev	Ratio
Test	Job-LOXHRO	/Core_Root_PR/corerun	0.4724 ns	0.0050 ns	0.0045 ns	0.89
Test	Job-MPJUHL	/Core_Root_main/corerun	0.5327 ns	0.0063 ns	0.0059 ns	1.00

Perf difference is not super exciting but it is what it is 🙂

Author:	EgorBo
Assignees:	-
Labels:	`area-CodeGen-coreclr`
Milestone:	-

EgorBo · 2023-07-29T20:49:25Z

- static_assert_no_msg(INS_count <= 512);
- instruction _idIns : 9;
+ static_assert_no_msg(INS_count <= 1024);
+ instruction _idIns : 10;


I added a bit here since we now have more than 512 instructions (and that for sure will be increasing in future) but I also removed an used (on arm) _idCallRegPtr bit so the total size of the struct remains the same - 16b

EgorBo · 2023-08-27T12:55:00Z

@TIHan @dotnet/jit-contrib PTAL, simple change, emits ldapur where we previously emitted ldapr+add because ldapr doesn't support IMM offsets

TIHan · 2023-08-31T00:07:59Z

 {
 /* This is an indirect call (either a virtual call or func ptr call) */

- id->idSetIsCallRegPtr();


Why was this removed for arm32?

I mentioned it in https://github.com/dotnet/runtime/pull/89681/files#r1278410873 comment, basically, it sets a bit that is unused for arm, so I removed that bit because I needed to extend _idIns's width

TIHan

LGTM, only one comment on the idSetIsCallingRegPtr.

EgorBo added 11 commits June 15, 2022 21:26

Don't use addressing modes for volatile loads for gc types
90cb0d0

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
5444ac2
…ldar

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
c0b688e
…ldar

print perfscore
08a61db

fix assert
1f76c43

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
8600b4e
…ldar # Conflicts: # src/coreclr/scripts/superpmi_diffs.py

stlur/ldupr
b0e0f8b

fix compilation
51c2902

Merge branch 'main' of github.com:dotnet/runtime into stlur
502f33a

use ldapur
bce421c

Fix build
60d8902

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 29, 2023

ghost assigned EgorBo Jul 29, 2023

EgorBo commented Jul 29, 2023
View reviewed changes

EgorBo added 2 commits July 29, 2023 22:57

Update codegenarm64.cpp
f743875

Update codegenarmarch.cpp
9f3039b

neon-sunset reviewed Jul 29, 2023
View reviewed changes

Comment threadsrc/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txt

EgorBo added 2 commits July 29, 2023 23:16

Address feedback
cd9f9a5

formatting
261cbf3

This was referenced Jul 30, 2023
Tracking issue for CI build timeouts #76454
Closed
JIT/jit64/opt/rngchk/RngchkStress2.cs failing to build with error CS8078: An expression is too long or complex to compile#87879
Closed

EgorBo added 4 commits July 30, 2023 16:33

Fix assert
675a36a

Fix assert
064ec92

Update lower.cpp
68c2e0d

Update emit.h
411699f

EgorBo marked this pull request as ready for review July 30, 2023 17:46

EgorBo requested a review from MichalStrehovsky as a code owner July 30, 2023 17:46

EgorBo added this to the 9.0.0 milestone Aug 5, 2023

EgorBo marked this pull request as draft August 21, 2023 11:44

EgorBo added 3 commits August 26, 2023 20:09

Merge branch 'main' into stlur
82ba714

Fix conflicts
33bc747

Merge branch 'main' into stlur
f1bb94c

This was referenced Aug 26, 2023
Test_EventSource_EtwManifestGeneration* tests failing in CI #48798
Closed
System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783
Closed

EgorBo marked this pull request as ready for review August 27, 2023 12:51

EgorBo requested a review from TIHan August 27, 2023 12:55

TIHan reviewed Aug 31, 2023
View reviewed changes

TIHan approved these changes Aug 31, 2023
View reviewed changes

EgorBo merged commit f0463a9 into dotnet:mainAug 31, 2023

EgorBo deleted the stlur branch August 31, 2023 13:23

jakobbotsch mentioned this pull request Sep 5, 2023
Update coredistools dotnet/jitutils#372
Closed

EgorBo mentioned this pull request Sep 5, 2023
ARM64: Use stlur for volatile stores #91553
Merged

BruceForstall mentioned this pull request Sep 5, 2023
Test failure: JIT/Directed/coverage/oldtests/stfldstatic2_r/stfldstatic2_r.dll #91647
Closed

ghost locked as resolved and limited conversation to collaborators Sep 30, 2023

EgorBo added 11 commits June 15, 2022 21:26

Don't use addressing modes for volatile loads for gc types
90cb0d0

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
5444ac2
…ldar

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
c0b688e
…ldar

print perfscore
08a61db

fix assert
1f76c43

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
8600b4e
…ldar # Conflicts: # src/coreclr/scripts/superpmi_diffs.py

stlur/ldupr
b0e0f8b

fix compilation
51c2902

Merge branch 'main' of github.com:dotnet/runtime into stlur
502f33a

use ldapur
bce421c

Fix build
60d8902

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 29, 2023

ghost assigned EgorBo Jul 29, 2023

EgorBo commented Jul 29, 2023
View reviewed changes

EgorBo added 2 commits July 29, 2023 22:57

Update codegenarm64.cpp
f743875

Update codegenarmarch.cpp
9f3039b

neon-sunset reviewed Jul 29, 2023
View reviewed changes

Comment threadsrc/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txt

EgorBo added 2 commits July 29, 2023 23:16

Address feedback
cd9f9a5

formatting
261cbf3

This was referenced Jul 30, 2023
Tracking issue for CI build timeouts #76454
Closed
JIT/jit64/opt/rngchk/RngchkStress2.cs failing to build with error CS8078: An expression is too long or complex to compile#87879
Closed

EgorBo added 4 commits July 30, 2023 16:33

Fix assert
675a36a

Fix assert
064ec92

Update lower.cpp
68c2e0d

Update emit.h
411699f

EgorBo marked this pull request as ready for review July 30, 2023 17:46

EgorBo requested a review from MichalStrehovsky as a code owner July 30, 2023 17:46

EgorBo added this to the 9.0.0 milestone Aug 5, 2023

EgorBo marked this pull request as draft August 21, 2023 11:44

EgorBo added 3 commits August 26, 2023 20:09

Merge branch 'main' into stlur
82ba714

Fix conflicts
33bc747

Merge branch 'main' into stlur
f1bb94c

This was referenced Aug 26, 2023
Test_EventSource_EtwManifestGeneration* tests failing in CI #48798
Closed
System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783
Closed

EgorBo marked this pull request as ready for review August 27, 2023 12:51

EgorBo requested a review from TIHan August 27, 2023 12:55

TIHan reviewed Aug 31, 2023
View reviewed changes

TIHan approved these changes Aug 31, 2023
View reviewed changes

EgorBo merged commit f0463a9 into dotnet:mainAug 31, 2023

EgorBo deleted the stlur branch August 31, 2023 13:23

jakobbotsch mentioned this pull request Sep 5, 2023
Update coredistools dotnet/jitutils#372
Closed

EgorBo mentioned this pull request Sep 5, 2023
ARM64: Use stlur for volatile stores #91553
Merged

BruceForstall mentioned this pull request Sep 5, 2023
Test failure: JIT/Directed/coverage/oldtests/stfldstatic2_r/stfldstatic2_r.dll #91647
Closed

ghost locked as resolved and limited conversation to collaborators Sep 30, 2023

EgorBo added 11 commits June 15, 2022 21:26

Don't use addressing modes for volatile loads for gc types
90cb0d0

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
5444ac2
…ldar

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
c0b688e
…ldar

print perfscore
08a61db

fix assert
1f76c43

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
8600b4e
…ldar # Conflicts: # src/coreclr/scripts/superpmi_diffs.py

stlur/ldupr
b0e0f8b

fix compilation
51c2902

Merge branch 'main' of github.com:dotnet/runtime into stlur
502f33a

use ldapur
bce421c

Fix build
60d8902

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 29, 2023

ghost assigned EgorBo Jul 29, 2023

EgorBo commented Jul 29, 2023
View reviewed changes

EgorBo added 2 commits July 29, 2023 22:57

Update codegenarm64.cpp
f743875

Update codegenarmarch.cpp
9f3039b

neon-sunset reviewed Jul 29, 2023
View reviewed changes

Comment threadsrc/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txt

EgorBo added 2 commits July 29, 2023 23:16

Address feedback
cd9f9a5

formatting
261cbf3

This was referenced Jul 30, 2023
Tracking issue for CI build timeouts #76454
Closed
JIT/jit64/opt/rngchk/RngchkStress2.cs failing to build with error CS8078: An expression is too long or complex to compile#87879
Closed

EgorBo added 4 commits July 30, 2023 16:33

Fix assert
675a36a

Fix assert
064ec92

Update lower.cpp
68c2e0d

Update emit.h
411699f

EgorBo marked this pull request as ready for review July 30, 2023 17:46

EgorBo requested a review from MichalStrehovsky as a code owner July 30, 2023 17:46

EgorBo added this to the 9.0.0 milestone Aug 5, 2023

EgorBo marked this pull request as draft August 21, 2023 11:44

EgorBo added 3 commits August 26, 2023 20:09

Merge branch 'main' into stlur
82ba714

Fix conflicts
33bc747

Merge branch 'main' into stlur
f1bb94c

This was referenced Aug 26, 2023
Test_EventSource_EtwManifestGeneration* tests failing in CI #48798
Closed
System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783
Closed

EgorBo marked this pull request as ready for review August 27, 2023 12:51

EgorBo requested a review from TIHan August 27, 2023 12:55

TIHan reviewed Aug 31, 2023
View reviewed changes

TIHan approved these changes Aug 31, 2023
View reviewed changes

EgorBo merged commit f0463a9 into dotnet:mainAug 31, 2023

EgorBo deleted the stlur branch August 31, 2023 13:23

jakobbotsch mentioned this pull request Sep 5, 2023
Update coredistools dotnet/jitutils#372
Closed

EgorBo mentioned this pull request Sep 5, 2023
ARM64: Use stlur for volatile stores #91553
Merged

BruceForstall mentioned this pull request Sep 5, 2023
Test failure: JIT/Directed/coverage/oldtests/stfldstatic2_r/stfldstatic2_r.dll #91647
Closed

ghost locked as resolved and limited conversation to collaborators Sep 30, 2023

EgorBo added 11 commits June 15, 2022 21:26

Don't use addressing modes for volatile loads for gc types
90cb0d0

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
5444ac2
…ldar

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
c0b688e
…ldar

print perfscore
08a61db

fix assert
1f76c43

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
8600b4e
…ldar # Conflicts: # src/coreclr/scripts/superpmi_diffs.py

stlur/ldupr
b0e0f8b

fix compilation
51c2902

Merge branch 'main' of github.com:dotnet/runtime into stlur
502f33a

use ldapur
bce421c

Fix build
60d8902

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 29, 2023

ghost assigned EgorBo Jul 29, 2023

EgorBo commented Jul 29, 2023
View reviewed changes

EgorBo added 2 commits July 29, 2023 22:57

Update codegenarm64.cpp
f743875

Update codegenarmarch.cpp
9f3039b

neon-sunset reviewed Jul 29, 2023
View reviewed changes

Comment threadsrc/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txt

EgorBo added 2 commits July 29, 2023 23:16

Address feedback
cd9f9a5

formatting
261cbf3

This was referenced Jul 30, 2023
Tracking issue for CI build timeouts #76454
Closed
JIT/jit64/opt/rngchk/RngchkStress2.cs failing to build with error CS8078: An expression is too long or complex to compile#87879
Closed

EgorBo added 4 commits July 30, 2023 16:33

Fix assert
675a36a

Fix assert
064ec92

Update lower.cpp
68c2e0d

Update emit.h
411699f

EgorBo marked this pull request as ready for review July 30, 2023 17:46

EgorBo requested a review from MichalStrehovsky as a code owner July 30, 2023 17:46

EgorBo added this to the 9.0.0 milestone Aug 5, 2023

EgorBo marked this pull request as draft August 21, 2023 11:44

EgorBo added 3 commits August 26, 2023 20:09

Merge branch 'main' into stlur
82ba714

Fix conflicts
33bc747

Merge branch 'main' into stlur
f1bb94c

This was referenced Aug 26, 2023
Test_EventSource_EtwManifestGeneration* tests failing in CI #48798
Closed
System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783
Closed

EgorBo marked this pull request as ready for review August 27, 2023 12:51

EgorBo requested a review from TIHan August 27, 2023 12:55

TIHan reviewed Aug 31, 2023
View reviewed changes

TIHan approved these changes Aug 31, 2023
View reviewed changes

EgorBo merged commit f0463a9 into dotnet:mainAug 31, 2023

EgorBo deleted the stlur branch August 31, 2023 13:23

jakobbotsch mentioned this pull request Sep 5, 2023
Update coredistools dotnet/jitutils#372
Closed

EgorBo mentioned this pull request Sep 5, 2023
ARM64: Use stlur for volatile stores #91553
Merged

BruceForstall mentioned this pull request Sep 5, 2023
Test failure: JIT/Directed/coverage/oldtests/stfldstatic2_r/stfldstatic2_r.dll #91647
Closed

ghost locked as resolved and limited conversation to collaborators Sep 30, 2023

EgorBo added 11 commits June 15, 2022 21:26

Don't use addressing modes for volatile loads for gc types
90cb0d0

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
5444ac2
…ldar

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
c0b688e
…ldar

print perfscore
08a61db

fix assert
1f76c43

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
8600b4e
…ldar # Conflicts: # src/coreclr/scripts/superpmi_diffs.py

stlur/ldupr
b0e0f8b

fix compilation
51c2902

Merge branch 'main' of github.com:dotnet/runtime into stlur
502f33a

use ldapur
bce421c

Fix build
60d8902

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 29, 2023

ghost assigned EgorBo Jul 29, 2023

EgorBo commented Jul 29, 2023
View reviewed changes

EgorBo added 2 commits July 29, 2023 22:57

Update codegenarm64.cpp
f743875

Update codegenarmarch.cpp
9f3039b

neon-sunset reviewed Jul 29, 2023
View reviewed changes

Comment threadsrc/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txt

EgorBo added 2 commits July 29, 2023 23:16

Address feedback
cd9f9a5

formatting
261cbf3

This was referenced Jul 30, 2023
Tracking issue for CI build timeouts #76454
Closed
JIT/jit64/opt/rngchk/RngchkStress2.cs failing to build with error CS8078: An expression is too long or complex to compile#87879
Closed

EgorBo added 4 commits July 30, 2023 16:33

Fix assert
675a36a

Fix assert
064ec92

Update lower.cpp
68c2e0d

Update emit.h
411699f

EgorBo marked this pull request as ready for review July 30, 2023 17:46

EgorBo requested a review from MichalStrehovsky as a code owner July 30, 2023 17:46

EgorBo added this to the 9.0.0 milestone Aug 5, 2023

EgorBo marked this pull request as draft August 21, 2023 11:44

EgorBo added 3 commits August 26, 2023 20:09

Merge branch 'main' into stlur
82ba714

Fix conflicts
33bc747

Merge branch 'main' into stlur
f1bb94c

This was referenced Aug 26, 2023
Test_EventSource_EtwManifestGeneration* tests failing in CI #48798
Closed
System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783
Closed

EgorBo marked this pull request as ready for review August 27, 2023 12:51

EgorBo requested a review from TIHan August 27, 2023 12:55

TIHan reviewed Aug 31, 2023
View reviewed changes

TIHan approved these changes Aug 31, 2023
View reviewed changes

EgorBo merged commit f0463a9 into dotnet:mainAug 31, 2023

EgorBo deleted the stlur branch August 31, 2023 13:23

jakobbotsch mentioned this pull request Sep 5, 2023
Update coredistools dotnet/jitutils#372
Closed

EgorBo mentioned this pull request Sep 5, 2023
ARM64: Use stlur for volatile stores #91553
Merged

BruceForstall mentioned this pull request Sep 5, 2023
Test failure: JIT/Directed/coverage/oldtests/stfldstatic2_r/stfldstatic2_r.dll #91647
Closed

ghost locked as resolved and limited conversation to collaborators Sep 30, 2023

EgorBo added 11 commits June 15, 2022 21:26

Don't use addressing modes for volatile loads for gc types
90cb0d0

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
5444ac2
…ldar

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
c0b688e
…ldar

print perfscore
08a61db

fix assert
1f76c43

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
8600b4e
…ldar # Conflicts: # src/coreclr/scripts/superpmi_diffs.py

stlur/ldupr
b0e0f8b

fix compilation
51c2902

Merge branch 'main' of github.com:dotnet/runtime into stlur
502f33a

use ldapur
bce421c

Fix build
60d8902

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 29, 2023

ghost assigned EgorBo Jul 29, 2023

EgorBo commented Jul 29, 2023
View reviewed changes

EgorBo added 2 commits July 29, 2023 22:57

Update codegenarm64.cpp
f743875

Update codegenarmarch.cpp
9f3039b

neon-sunset reviewed Jul 29, 2023
View reviewed changes

Comment threadsrc/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txt

EgorBo added 2 commits July 29, 2023 23:16

Address feedback
cd9f9a5

formatting
261cbf3

This was referenced Jul 30, 2023
Tracking issue for CI build timeouts #76454
Closed
JIT/jit64/opt/rngchk/RngchkStress2.cs failing to build with error CS8078: An expression is too long or complex to compile#87879
Closed

EgorBo added 4 commits July 30, 2023 16:33

Fix assert
675a36a

Fix assert
064ec92

Update lower.cpp
68c2e0d

Update emit.h
411699f

EgorBo marked this pull request as ready for review July 30, 2023 17:46

EgorBo requested a review from MichalStrehovsky as a code owner July 30, 2023 17:46

EgorBo added this to the 9.0.0 milestone Aug 5, 2023

EgorBo marked this pull request as draft August 21, 2023 11:44

EgorBo added 3 commits August 26, 2023 20:09

Merge branch 'main' into stlur
82ba714

Fix conflicts
33bc747

Merge branch 'main' into stlur
f1bb94c

This was referenced Aug 26, 2023
Test_EventSource_EtwManifestGeneration* tests failing in CI #48798
Closed
System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783
Closed

EgorBo marked this pull request as ready for review August 27, 2023 12:51

EgorBo requested a review from TIHan August 27, 2023 12:55

TIHan reviewed Aug 31, 2023
View reviewed changes

TIHan approved these changes Aug 31, 2023
View reviewed changes

EgorBo merged commit f0463a9 into dotnet:mainAug 31, 2023

EgorBo deleted the stlur branch August 31, 2023 13:23

jakobbotsch mentioned this pull request Sep 5, 2023
Update coredistools dotnet/jitutils#372
Closed

EgorBo mentioned this pull request Sep 5, 2023
ARM64: Use stlur for volatile stores #91553
Merged

BruceForstall mentioned this pull request Sep 5, 2023
Test failure: JIT/Directed/coverage/oldtests/stfldstatic2_r/stfldstatic2_r.dll #91647
Closed

ghost locked as resolved and limited conversation to collaborators Sep 30, 2023

EgorBo added 11 commits June 15, 2022 21:26

Don't use addressing modes for volatile loads for gc types
90cb0d0

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
5444ac2
…ldar

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
c0b688e
…ldar

print perfscore
08a61db

fix assert
1f76c43

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
8600b4e
…ldar # Conflicts: # src/coreclr/scripts/superpmi_diffs.py

stlur/ldupr
b0e0f8b

fix compilation
51c2902

Merge branch 'main' of github.com:dotnet/runtime into stlur
502f33a

use ldapur
bce421c

Fix build
60d8902

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 29, 2023

ghost assigned EgorBo Jul 29, 2023

EgorBo commented Jul 29, 2023
View reviewed changes

EgorBo added 2 commits July 29, 2023 22:57

Update codegenarm64.cpp
f743875

Update codegenarmarch.cpp
9f3039b

neon-sunset reviewed Jul 29, 2023
View reviewed changes

Comment threadsrc/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txt

EgorBo added 2 commits July 29, 2023 23:16

Address feedback
cd9f9a5

formatting
261cbf3

This was referenced Jul 30, 2023
Tracking issue for CI build timeouts #76454
Closed
JIT/jit64/opt/rngchk/RngchkStress2.cs failing to build with error CS8078: An expression is too long or complex to compile#87879
Closed

EgorBo added 4 commits July 30, 2023 16:33

Fix assert
675a36a

Fix assert
064ec92

Update lower.cpp
68c2e0d

Update emit.h
411699f

EgorBo marked this pull request as ready for review July 30, 2023 17:46

EgorBo requested a review from MichalStrehovsky as a code owner July 30, 2023 17:46

EgorBo added this to the 9.0.0 milestone Aug 5, 2023

EgorBo marked this pull request as draft August 21, 2023 11:44

EgorBo added 3 commits August 26, 2023 20:09

Merge branch 'main' into stlur
82ba714

Fix conflicts
33bc747

Merge branch 'main' into stlur
f1bb94c

This was referenced Aug 26, 2023
Test_EventSource_EtwManifestGeneration* tests failing in CI #48798
Closed
System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783
Closed

EgorBo marked this pull request as ready for review August 27, 2023 12:51

EgorBo requested a review from TIHan August 27, 2023 12:55

TIHan reviewed Aug 31, 2023
View reviewed changes

TIHan approved these changes Aug 31, 2023
View reviewed changes

EgorBo merged commit f0463a9 into dotnet:mainAug 31, 2023

EgorBo deleted the stlur branch August 31, 2023 13:23

jakobbotsch mentioned this pull request Sep 5, 2023
Update coredistools dotnet/jitutils#372
Closed

EgorBo mentioned this pull request Sep 5, 2023
ARM64: Use stlur for volatile stores #91553
Merged

BruceForstall mentioned this pull request Sep 5, 2023
Test failure: JIT/Directed/coverage/oldtests/stfldstatic2_r/stfldstatic2_r.dll #91647
Closed

ghost locked as resolved and limited conversation to collaborators Sep 30, 2023

EgorBo added 11 commits June 15, 2022 21:26

Don't use addressing modes for volatile loads for gc types
90cb0d0

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
5444ac2
…ldar

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
c0b688e
…ldar

print perfscore
08a61db

fix assert
1f76c43

Merge branch 'main' of github.com:dotnet/runtime into enable-gctypes-…
8600b4e
…ldar # Conflicts: # src/coreclr/scripts/superpmi_diffs.py

stlur/ldupr
b0e0f8b

fix compilation
51c2902

Merge branch 'main' of github.com:dotnet/runtime into stlur
502f33a

use ldapur
bce421c

Fix build
60d8902

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 29, 2023

ghost assigned EgorBo Jul 29, 2023

EgorBo commented Jul 29, 2023
View reviewed changes

EgorBo added 2 commits July 29, 2023 22:57

Update codegenarm64.cpp
f743875

Update codegenarmarch.cpp
9f3039b

neon-sunset reviewed Jul 29, 2023
View reviewed changes

Comment threadsrc/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txt

EgorBo added 2 commits July 29, 2023 23:16

Address feedback
cd9f9a5

formatting
261cbf3

This was referenced Jul 30, 2023
Tracking issue for CI build timeouts #76454
Closed
JIT/jit64/opt/rngchk/RngchkStress2.cs failing to build with error CS8078: An expression is too long or complex to compile#87879
Closed

EgorBo added 4 commits July 30, 2023 16:33

Fix assert
675a36a

Fix assert
064ec92

Update lower.cpp
68c2e0d

Update emit.h
411699f

EgorBo marked this pull request as ready for review July 30, 2023 17:46

EgorBo requested a review from MichalStrehovsky as a code owner July 30, 2023 17:46

EgorBo added this to the 9.0.0 milestone Aug 5, 2023

EgorBo marked this pull request as draft August 21, 2023 11:44

EgorBo added 3 commits August 26, 2023 20:09

Merge branch 'main' into stlur
82ba714

Fix conflicts
33bc747

Merge branch 'main' into stlur
f1bb94c

This was referenced Aug 26, 2023
Test_EventSource_EtwManifestGeneration* tests failing in CI #48798
Closed
System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783
Closed

EgorBo marked this pull request as ready for review August 27, 2023 12:51

EgorBo requested a review from TIHan August 27, 2023 12:55

TIHan reviewed Aug 31, 2023
View reviewed changes

TIHan approved these changes Aug 31, 2023
View reviewed changes

EgorBo merged commit f0463a9 into dotnet:mainAug 31, 2023

EgorBo deleted the stlur branch August 31, 2023 13:23

jakobbotsch mentioned this pull request Sep 5, 2023
Update coredistools dotnet/jitutils#372
Closed

EgorBo mentioned this pull request Sep 5, 2023
ARM64: Use stlur for volatile stores #91553
Merged

BruceForstall mentioned this pull request Sep 5, 2023
Test failure: JIT/Directed/coverage/oldtests/stfldstatic2_r/stfldstatic2_r.dll #91647
Closed

ghost locked as resolved and limited conversation to collaborators Sep 30, 2023

Uh oh!

Conversation

EgorBo commented Jul 29, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jul 29, 2023

Uh oh!

EgorBoJul 29, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

EgorBo commented Aug 27, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TIHan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

EgorBo commented Jul 29, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jul 29, 2023

Uh oh!

EgorBoJul 29, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

EgorBo commented Aug 27, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TIHan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

EgorBo commented Jul 29, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jul 29, 2023

Uh oh!

EgorBoJul 29, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

EgorBo commented Aug 27, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TIHan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

EgorBo commented Jul 29, 2023•
edited
Loading

EgorBoJul 29, 2023•
edited
Loading

EgorBo commented Jul 29, 2023•
edited
Loading

EgorBoJul 29, 2023•
edited
Loading

EgorBo commented Jul 29, 2023•
edited
Loading

EgorBoJul 29, 2023•
edited
Loading

EgorBo commented Jul 29, 2023•
edited
Loading

EgorBoJul 29, 2023•
edited
Loading

EgorBo commented Jul 29, 2023•
edited
Loading