Uh oh!
There was an error while loading. Please reload this page.
ARM64: Use stlur for volatile stores - #91553
Merged
Merged
Conversation
ghost
commented
Sep 4, 2023
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Detailsvolatileintx;voidTest()=>x=42;Was: ; Assembly listing for method Program:Test()
stp fp, lr, [sp, #-0x10]!
mov fp, sp
mov w1, #42
- dmb ish- str w1, [x0, #0x08]+ stlur w1, [x0, #0x08]
ldp fp, lr, [sp], #0x10
ret lr
|
EgorBo
marked this pull request as ready for review
September 5, 2023 10:27
EgorBo
commented
Sep 5, 2023
MemberAuthor
EgorBo
commented
Sep 5, 2023
MemberAuthor
also, cc @VSadov |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Bruce Forstall <brucefo@microsoft.com>
jakobbotsch
commented
Sep 7, 2023
Member
Will this need a fix similar to #91668? |
EgorBo
commented
Sep 7, 2023
MemberAuthor
I'd guess - yes? since it's the same ISA. can you add them as well? |
jakobbotsch
commented
Sep 7, 2023
Member
Done (but untested) |
EgorBo
commented
Sep 7, 2023
MemberAuthor
@BruceForstall PTAL refactored changes |
This was referenced Sep 7, 2023
BruceForstall
approved these changes
Sep 7, 2023
BruceForstall
left a comment
Contributor
There was a problem hiding this comment.
LGTM. One question/suggestion.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codegen diff on arm64 v8.4+ (e.g. Apple M2):