Skip to content

[wasm] Incremental build improvements - #90194

Merged
radical merged 10 commits into
dotnet:mainfrom
radical:wasm-incremental-build
Aug 14, 2023
Merged

[wasm] Incremental build improvements#90194
radical merged 10 commits into
dotnet:mainfrom
radical:wasm-incremental-build

Conversation

@radical

@radicalradical commented Aug 8, 2023•
edited
Loading

Copy link
Copy Markdown
Member
  • [wasm] Sanity check emcc versions only when using a custom EMSDK_PATH
  • [wasm] Emit a message about compiling native assets only when actually doing so
  • [wasm] ConvertDllsToWebcil: avoid doing unncessary conversion, and other work
  • [wasm] ManagedToNativeGenerator: add support for incremental runs (time goes from 1.6s to <900ms)

This improves build times ~30% for no-op rebuilds.

With native referenceOldNewDifference%
First build8.01s8.13s+0.12s
4th rebuild1.91s1.35s-0.56s29%
rebuild with only cs change2.90s2.48s-0.42s14%
Without native referenceOldNewDifference%
First build5.34s5.29-0.05s
4th rebuild1.78s1.20s-0.58s32%
rebuild with only cs change1.96s1.45s-0.51s26%

Fixes#60245 .

@radicalradical added the arch-wasm WebAssembly architecture label Aug 8, 2023
@ghostghost assigned radicalAug 8, 2023
@ghostghost added the area-Build-mono label Aug 8, 2023
@ghost

ghost commented Aug 8, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • [wasm] Sanity check emcc versions only when using a custom EMSDK_PATH
  • [wasm] Emit a message about compiling native assets only when actually doing so
  • [wasm] ConvertDllsToWebcil: avoid doing unncessary conversion, and other work
Author:radical
Assignees:-
Labels:

arch-wasm

Milestone:-

@radical
radicalforce-pushed the wasm-incremental-build branch from 0eee015 to 22f2daaCompareAugust 8, 2023 23:43
@radicalradical changed the title wasm incremental build[wasm] Incremental build improvementsAug 8, 2023
@radical

radical commented Aug 11, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Aug 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Aug 11, 2023
Closed
Closed
@radical
[wasm] Makefile: update helper targets
b3566f5
@radical
[wasm] Run emcc --version when necessary
3468aa2
- Check emcc versions *if* `EMSDK_PATH` was explicitly set, IOW,
workloads are not in use
@radical
[wasm] ConvertDllsToWebCil: Avoid unncessary conversion
5374ff4
Convert the assemblies only if needed.
@radical
[wasm] ManagedToNativeGenerator: avoid unncessary work
bc986f2
- If the inputs are older than the outputs, then no work needs to be
done
- The inputs consist of the assemblies to scan, and a list of pinvoke
modules.
- Timestamps are used for the assemblies
- And for the pinvoke modules list, we save that in a cache file, and
use that to determine if any work needs to be done.
@radical
[wasm] Remove misleading message
c044c20
`EmccCompile` task build compiles some `.c` files, but skips them if the
output files are already up-to-date. But the build always emits a
`Compiling native assets with emcc with ..` message, which suggests that
there is some native build being run. Instead, emit this message only if
`EmccCompile` actually did any work.
@radical
minor - add paths for wasm vscode workspace
dda5b20
@radical
radicalforce-pushed the wasm-incremental-build branch from 34390f4 to dda5b20CompareAugust 11, 2023 06:05
@radical
radical marked this pull request as ready for review August 11, 2023 06:37
@radical
radical requested a review from marafAugust 11, 2023 06:38
@radical

radical commented Aug 11, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Aug 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara
pavelsavara reviewed Aug 11, 2023
View reviewed changes
Comment threadsrc/mono/wasm/build/WasmApp.Native.targets
This was referenced Aug 11, 2023
Closed
Closed
@radical

radical commented Aug 11, 2023

Copy link
Copy Markdown
MemberAuthor

Failures are unrelated.

kg
kg reviewed Aug 13, 2023
View reviewed changes
Comment threadsrc/mono/wasm/Makefile Outdated
kg
kg approved these changes Aug 14, 2023
View reviewed changes

@kgkg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong in here, though I'm not an expert on the table generators or msbuild

maraf
maraf approved these changes Aug 14, 2023
View reviewed changes

@marafmaraf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@radical
radical merged commit 711447a into dotnet:mainAug 14, 2023
@radical
radical deleted the wasm-incremental-build branch August 14, 2023 15:49
@ghostghost locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pavelsavarapavelsavarapavelsavara left review comments
@marafmarafmaraf approved these changes
@SteveSandersonMSSteveSandersonMSAwaiting requested review from SteveSandersonMS
@lewinglewingAwaiting requested review from lewinglewing is a code owner
+1 more reviewer
@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WebAssembly native dependency builds incrementalism is still slow

4 participants

@radical@kg@pavelsavara@maraf
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[wasm] Incremental build improvements by radical · Pull Request #90194 · dotnet/runtime · GitHub
Skip to content
[wasm] Incremental build improvements - #90194
Merged
radical merged 10 commits into
dotnet:mainfrom 
radical:wasm-incremental-build
Aug 14, 2023
Merged
[wasm] Incremental build improvements#90194
radical merged 10 commits into
dotnet:mainfrom 
radical:wasm-incremental-build
Conversation
@radical
@radicalradical
commented
Aug 8, 2023•

edited

Loading

Copy link


Copy Markdown

Member
  • [wasm] Sanity check emcc versions only when using a custom EMSDK_PATH
  • [wasm] Emit a message about compiling native assets only when actually doing so
  • [wasm] ConvertDllsToWebcil: avoid doing unncessary conversion, and other work
  • [wasm] ManagedToNativeGenerator: add support for incremental runs (time goes from 1.6s to <900ms)
This improves build times ~30% for no-op rebuilds.
With native referenceOldNewDifference%
First build8.01s8.13s+0.12s
4th rebuild1.91s1.35s-0.56s29%
rebuild with only cs change2.90s2.48s-0.42s14%
Without native referenceOldNewDifference%
First build5.34s5.29-0.05s
4th rebuild1.78s1.20s-0.58s32%
rebuild with only cs change1.96s1.45s-0.51s26%
Fixes#60245 .
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Aug 8, 2023
@ghostghost
assigned radicalAug 8, 2023
@ghostghost
added
the 
area-Build-mono

label
Aug 8, 2023
@ghost
ghost
commented
Aug 8, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • [wasm] Sanity check emcc versions only when using a custom EMSDK_PATH
  • [wasm] Emit a message about compiling native assets only when actually doing so
  • [wasm] ConvertDllsToWebcil: avoid doing unncessary conversion, and other work
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radical
radicalforce-pushed
the
wasm-incremental-build
branch
from
0eee015 to
22f2daaCompareAugust 8, 2023 23:43
@radicalradical
changed the title
wasm incremental build[wasm] Incremental build improvementsAug 8, 2023
@radical
radical
commented
Aug 11, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 11, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Aug 11, 2023

Closed


Closed

@radical
[wasm] Makefile: update helper targets
b3566f5
@radical
[wasm] Run emcc --version when necessary
3468aa2
- Check emcc versions *if* `EMSDK_PATH` was explicitly set, IOW,
workloads are not in use
@radical
[wasm] ConvertDllsToWebCil: Avoid unncessary conversion
5374ff4
Convert the assemblies only if needed.
@radical
[wasm] ManagedToNativeGenerator: avoid unncessary work
bc986f2
- If the inputs are older than the outputs, then no work needs to be
done
- The inputs consist of the assemblies to scan, and a list of pinvoke
modules.
- Timestamps are used for the assemblies
- And for the pinvoke modules list, we save that in a cache file, and
use that to determine if any work needs to be done.
@radical
[wasm] Remove misleading message
c044c20
`EmccCompile` task build compiles some `.c` files, but skips them if the
output files are already up-to-date. But the build always emits a
`Compiling native assets with emcc with ..` message, which suggests that
there is some native build being run. Instead, emit this message only if
`EmccCompile` actually did any work.
@radical
minor - add paths for wasm vscode workspace
dda5b20
@radical
radicalforce-pushed
the
wasm-incremental-build
branch
from
34390f4 to
dda5b20CompareAugust 11, 2023 06:05
@radical
radical
marked this pull request as ready for review
August 11, 2023 06:37
@radical
radical
requested a review
from marafAugust 11, 2023 06:38
@radical
radical
commented
Aug 11, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 11, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
pavelsavara
pavelsavara
reviewed
Aug 11, 2023
View reviewed changes
Comment threadsrc/mono/wasm/build/WasmApp.Native.targets

This was referenced Aug 11, 2023

Closed


Closed

@radical
radical
commented
Aug 11, 2023

Copy link


Copy Markdown

MemberAuthor
Failures are unrelated.
kg
kg
reviewed
Aug 13, 2023
View reviewed changes
Comment threadsrc/mono/wasm/Makefile
Outdated

kg
kg
approved these changes
Aug 14, 2023
View reviewed changes
@kgkg
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong in here, though I'm not an expert on the table generators or msbuild
maraf
maraf
approved these changes
Aug 14, 2023
View reviewed changes
@marafmaraf
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
@radical
radical
merged commit 711447a
into
dotnet:mainAug 14, 2023
@radical
radical
deleted the

wasm-incremental-build

branch
August 14, 2023 15:49
@ghostghost
locked as resolved and limited conversation to collaborators
Sep 13, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@pavelsavarapavelsavarapavelsavara left review comments
@marafmarafmaraf approved these changes
@SteveSandersonMSSteveSandersonMSAwaiting requested review from SteveSandersonMS
@lewinglewingAwaiting requested review from lewinglewing is a code owner

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

WebAssembly native dependency builds incrementalism is still slow


4 participants

@radical@kg@pavelsavara@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[wasm] Incremental build improvements by radical · Pull Request #90194 · dotnet/runtime · GitHub
Skip to content
[wasm] Incremental build improvements - #90194
Merged
radical merged 10 commits into
dotnet:mainfrom 
radical:wasm-incremental-build
Aug 14, 2023
Merged
[wasm] Incremental build improvements#90194
radical merged 10 commits into
dotnet:mainfrom 
radical:wasm-incremental-build
Conversation
@radical
@radicalradical
commented
Aug 8, 2023•

edited

Loading

Copy link


Copy Markdown

Member
  • [wasm] Sanity check emcc versions only when using a custom EMSDK_PATH
  • [wasm] Emit a message about compiling native assets only when actually doing so
  • [wasm] ConvertDllsToWebcil: avoid doing unncessary conversion, and other work
  • [wasm] ManagedToNativeGenerator: add support for incremental runs (time goes from 1.6s to <900ms)
This improves build times ~30% for no-op rebuilds.
With native referenceOldNewDifference%
First build8.01s8.13s+0.12s
4th rebuild1.91s1.35s-0.56s29%
rebuild with only cs change2.90s2.48s-0.42s14%
Without native referenceOldNewDifference%
First build5.34s5.29-0.05s
4th rebuild1.78s1.20s-0.58s32%
rebuild with only cs change1.96s1.45s-0.51s26%
Fixes#60245 .
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Aug 8, 2023
@ghostghost
assigned radicalAug 8, 2023
@ghostghost
added
the 
area-Build-mono

label
Aug 8, 2023
@ghost
ghost
commented
Aug 8, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • [wasm] Sanity check emcc versions only when using a custom EMSDK_PATH
  • [wasm] Emit a message about compiling native assets only when actually doing so
  • [wasm] ConvertDllsToWebcil: avoid doing unncessary conversion, and other work
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radical
radicalforce-pushed
the
wasm-incremental-build
branch
from
0eee015 to
22f2daaCompareAugust 8, 2023 23:43
@radicalradical
changed the title
wasm incremental build[wasm] Incremental build improvementsAug 8, 2023
@radical
radical
commented
Aug 11, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 11, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Aug 11, 2023

Closed


Closed

@radical
[wasm] Makefile: update helper targets
b3566f5
@radical
[wasm] Run emcc --version when necessary
3468aa2
- Check emcc versions *if* `EMSDK_PATH` was explicitly set, IOW,
workloads are not in use
@radical
[wasm] ConvertDllsToWebCil: Avoid unncessary conversion
5374ff4
Convert the assemblies only if needed.
@radical
[wasm] ManagedToNativeGenerator: avoid unncessary work
bc986f2
- If the inputs are older than the outputs, then no work needs to be
done
- The inputs consist of the assemblies to scan, and a list of pinvoke
modules.
- Timestamps are used for the assemblies
- And for the pinvoke modules list, we save that in a cache file, and
use that to determine if any work needs to be done.
@radical
[wasm] Remove misleading message
c044c20
`EmccCompile` task build compiles some `.c` files, but skips them if the
output files are already up-to-date. But the build always emits a
`Compiling native assets with emcc with ..` message, which suggests that
there is some native build being run. Instead, emit this message only if
`EmccCompile` actually did any work.
@radical
minor - add paths for wasm vscode workspace
dda5b20
@radical
radicalforce-pushed
the
wasm-incremental-build
branch
from
34390f4 to
dda5b20CompareAugust 11, 2023 06:05
@radical
radical
marked this pull request as ready for review
August 11, 2023 06:37
@radical
radical
requested a review
from marafAugust 11, 2023 06:38
@radical
radical
commented
Aug 11, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 11, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
pavelsavara
pavelsavara
reviewed
Aug 11, 2023
View reviewed changes
Comment threadsrc/mono/wasm/build/WasmApp.Native.targets

This was referenced Aug 11, 2023

Closed


Closed

@radical
radical
commented
Aug 11, 2023

Copy link


Copy Markdown

MemberAuthor
Failures are unrelated.
kg
kg
reviewed
Aug 13, 2023
View reviewed changes
Comment threadsrc/mono/wasm/Makefile
Outdated

kg
kg
approved these changes
Aug 14, 2023
View reviewed changes
@kgkg
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong in here, though I'm not an expert on the table generators or msbuild
maraf
maraf
approved these changes
Aug 14, 2023
View reviewed changes
@marafmaraf
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
@radical
radical
merged commit 711447a
into
dotnet:mainAug 14, 2023
@radical
radical
deleted the

wasm-incremental-build

branch
August 14, 2023 15:49
@ghostghost
locked as resolved and limited conversation to collaborators
Sep 13, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@pavelsavarapavelsavarapavelsavara left review comments
@marafmarafmaraf approved these changes
@SteveSandersonMSSteveSandersonMSAwaiting requested review from SteveSandersonMS
@lewinglewingAwaiting requested review from lewinglewing is a code owner

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

WebAssembly native dependency builds incrementalism is still slow


4 participants

@radical@kg@pavelsavara@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[wasm] Incremental build improvements by radical · Pull Request #90194 · dotnet/runtime · GitHub
Skip to content
[wasm] Incremental build improvements - #90194
Merged
radical merged 10 commits into
dotnet:mainfrom 
radical:wasm-incremental-build
Aug 14, 2023
Merged
[wasm] Incremental build improvements#90194
radical merged 10 commits into
dotnet:mainfrom 
radical:wasm-incremental-build
Conversation
@radical
@radicalradical
commented
Aug 8, 2023•

edited

Loading

Copy link


Copy Markdown

Member
  • [wasm] Sanity check emcc versions only when using a custom EMSDK_PATH
  • [wasm] Emit a message about compiling native assets only when actually doing so
  • [wasm] ConvertDllsToWebcil: avoid doing unncessary conversion, and other work
  • [wasm] ManagedToNativeGenerator: add support for incremental runs (time goes from 1.6s to <900ms)
This improves build times ~30% for no-op rebuilds.
With native referenceOldNewDifference%
First build8.01s8.13s+0.12s
4th rebuild1.91s1.35s-0.56s29%
rebuild with only cs change2.90s2.48s-0.42s14%
Without native referenceOldNewDifference%
First build5.34s5.29-0.05s
4th rebuild1.78s1.20s-0.58s32%
rebuild with only cs change1.96s1.45s-0.51s26%
Fixes#60245 .
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Aug 8, 2023
@ghostghost
assigned radicalAug 8, 2023
@ghostghost
added
the 
area-Build-mono

label
Aug 8, 2023
@ghost
ghost
commented
Aug 8, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • [wasm] Sanity check emcc versions only when using a custom EMSDK_PATH
  • [wasm] Emit a message about compiling native assets only when actually doing so
  • [wasm] ConvertDllsToWebcil: avoid doing unncessary conversion, and other work
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radical
radicalforce-pushed
the
wasm-incremental-build
branch
from
0eee015 to
22f2daaCompareAugust 8, 2023 23:43
@radicalradical
changed the title
wasm incremental build[wasm] Incremental build improvementsAug 8, 2023
@radical
radical
commented
Aug 11, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 11, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Aug 11, 2023

Closed


Closed

@radical
[wasm] Makefile: update helper targets
b3566f5
@radical
[wasm] Run emcc --version when necessary
3468aa2
- Check emcc versions *if* `EMSDK_PATH` was explicitly set, IOW,
workloads are not in use
@radical
[wasm] ConvertDllsToWebCil: Avoid unncessary conversion
5374ff4
Convert the assemblies only if needed.
@radical
[wasm] ManagedToNativeGenerator: avoid unncessary work
bc986f2
- If the inputs are older than the outputs, then no work needs to be
done
- The inputs consist of the assemblies to scan, and a list of pinvoke
modules.
- Timestamps are used for the assemblies
- And for the pinvoke modules list, we save that in a cache file, and
use that to determine if any work needs to be done.
@radical
[wasm] Remove misleading message
c044c20
`EmccCompile` task build compiles some `.c` files, but skips them if the
output files are already up-to-date. But the build always emits a
`Compiling native assets with emcc with ..` message, which suggests that
there is some native build being run. Instead, emit this message only if
`EmccCompile` actually did any work.
@radical
minor - add paths for wasm vscode workspace
dda5b20
@radical
radicalforce-pushed
the
wasm-incremental-build
branch
from
34390f4 to
dda5b20CompareAugust 11, 2023 06:05
@radical
radical
marked this pull request as ready for review
August 11, 2023 06:37
@radical
radical
requested a review
from marafAugust 11, 2023 06:38
@radical
radical
commented
Aug 11, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 11, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
pavelsavara
pavelsavara
reviewed
Aug 11, 2023
View reviewed changes
Comment threadsrc/mono/wasm/build/WasmApp.Native.targets

This was referenced Aug 11, 2023

Closed


Closed

@radical
radical
commented
Aug 11, 2023

Copy link


Copy Markdown

MemberAuthor
Failures are unrelated.
kg
kg
reviewed
Aug 13, 2023
View reviewed changes
Comment threadsrc/mono/wasm/Makefile
Outdated

kg
kg
approved these changes
Aug 14, 2023
View reviewed changes
@kgkg
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong in here, though I'm not an expert on the table generators or msbuild
maraf
maraf
approved these changes
Aug 14, 2023
View reviewed changes
@marafmaraf
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
@radical
radical
merged commit 711447a
into
dotnet:mainAug 14, 2023
@radical
radical
deleted the

wasm-incremental-build

branch
August 14, 2023 15:49
@ghostghost
locked as resolved and limited conversation to collaborators
Sep 13, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@pavelsavarapavelsavarapavelsavara left review comments
@marafmarafmaraf approved these changes
@SteveSandersonMSSteveSandersonMSAwaiting requested review from SteveSandersonMS
@lewinglewingAwaiting requested review from lewinglewing is a code owner

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

WebAssembly native dependency builds incrementalism is still slow


4 participants

@radical@kg@pavelsavara@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[wasm] Incremental build improvements by radical · Pull Request #90194 · dotnet/runtime · GitHub
Skip to content
[wasm] Incremental build improvements - #90194
Merged
radical merged 10 commits into
dotnet:mainfrom 
radical:wasm-incremental-build
Aug 14, 2023
Merged
[wasm] Incremental build improvements#90194
radical merged 10 commits into
dotnet:mainfrom 
radical:wasm-incremental-build
Conversation
@radical
@radicalradical
commented
Aug 8, 2023•

edited

Loading

Copy link


Copy Markdown

Member
  • [wasm] Sanity check emcc versions only when using a custom EMSDK_PATH
  • [wasm] Emit a message about compiling native assets only when actually doing so
  • [wasm] ConvertDllsToWebcil: avoid doing unncessary conversion, and other work
  • [wasm] ManagedToNativeGenerator: add support for incremental runs (time goes from 1.6s to <900ms)
This improves build times ~30% for no-op rebuilds.
With native referenceOldNewDifference%
First build8.01s8.13s+0.12s
4th rebuild1.91s1.35s-0.56s29%
rebuild with only cs change2.90s2.48s-0.42s14%
Without native referenceOldNewDifference%
First build5.34s5.29-0.05s
4th rebuild1.78s1.20s-0.58s32%
rebuild with only cs change1.96s1.45s-0.51s26%
Fixes#60245 .
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Aug 8, 2023
@ghostghost
assigned radicalAug 8, 2023
@ghostghost
added
the 
area-Build-mono

label
Aug 8, 2023
@ghost
ghost
commented
Aug 8, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • [wasm] Sanity check emcc versions only when using a custom EMSDK_PATH
  • [wasm] Emit a message about compiling native assets only when actually doing so
  • [wasm] ConvertDllsToWebcil: avoid doing unncessary conversion, and other work
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radical
radicalforce-pushed
the
wasm-incremental-build
branch
from
0eee015 to
22f2daaCompareAugust 8, 2023 23:43
@radicalradical
changed the title
wasm incremental build[wasm] Incremental build improvementsAug 8, 2023
@radical
radical
commented
Aug 11, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 11, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Aug 11, 2023

Closed


Closed

@radical
[wasm] Makefile: update helper targets
b3566f5
@radical
[wasm] Run emcc --version when necessary
3468aa2
- Check emcc versions *if* `EMSDK_PATH` was explicitly set, IOW,
workloads are not in use
@radical
[wasm] ConvertDllsToWebCil: Avoid unncessary conversion
5374ff4
Convert the assemblies only if needed.
@radical
[wasm] ManagedToNativeGenerator: avoid unncessary work
bc986f2
- If the inputs are older than the outputs, then no work needs to be
done
- The inputs consist of the assemblies to scan, and a list of pinvoke
modules.
- Timestamps are used for the assemblies
- And for the pinvoke modules list, we save that in a cache file, and
use that to determine if any work needs to be done.
@radical
[wasm] Remove misleading message
c044c20
`EmccCompile` task build compiles some `.c` files, but skips them if the
output files are already up-to-date. But the build always emits a
`Compiling native assets with emcc with ..` message, which suggests that
there is some native build being run. Instead, emit this message only if
`EmccCompile` actually did any work.
@radical
minor - add paths for wasm vscode workspace
dda5b20
@radical
radicalforce-pushed
the
wasm-incremental-build
branch
from
34390f4 to
dda5b20CompareAugust 11, 2023 06:05
@radical
radical
marked this pull request as ready for review
August 11, 2023 06:37
@radical
radical
requested a review
from marafAugust 11, 2023 06:38
@radical
radical
commented
Aug 11, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 11, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
pavelsavara
pavelsavara
reviewed
Aug 11, 2023
View reviewed changes
Comment threadsrc/mono/wasm/build/WasmApp.Native.targets

This was referenced Aug 11, 2023

Closed


Closed

@radical
radical
commented
Aug 11, 2023

Copy link


Copy Markdown

MemberAuthor
Failures are unrelated.
kg
kg
reviewed
Aug 13, 2023
View reviewed changes
Comment threadsrc/mono/wasm/Makefile
Outdated

kg
kg
approved these changes
Aug 14, 2023
View reviewed changes
@kgkg
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong in here, though I'm not an expert on the table generators or msbuild
maraf
maraf
approved these changes
Aug 14, 2023
View reviewed changes
@marafmaraf
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
@radical
radical
merged commit 711447a
into
dotnet:mainAug 14, 2023
@radical
radical
deleted the

wasm-incremental-build

branch
August 14, 2023 15:49
@ghostghost
locked as resolved and limited conversation to collaborators
Sep 13, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@pavelsavarapavelsavarapavelsavara left review comments
@marafmarafmaraf approved these changes
@SteveSandersonMSSteveSandersonMSAwaiting requested review from SteveSandersonMS
@lewinglewingAwaiting requested review from lewinglewing is a code owner

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

WebAssembly native dependency builds incrementalism is still slow


4 participants

@radical@kg@pavelsavara@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[wasm] Incremental build improvements by radical · Pull Request #90194 · dotnet/runtime · GitHub
Skip to content
[wasm] Incremental build improvements - #90194
Merged
radical merged 10 commits into
dotnet:mainfrom 
radical:wasm-incremental-build
Aug 14, 2023
Merged
[wasm] Incremental build improvements#90194
radical merged 10 commits into
dotnet:mainfrom 
radical:wasm-incremental-build
Conversation
@radical
@radicalradical
commented
Aug 8, 2023•

edited

Loading

Copy link


Copy Markdown

Member
  • [wasm] Sanity check emcc versions only when using a custom EMSDK_PATH
  • [wasm] Emit a message about compiling native assets only when actually doing so
  • [wasm] ConvertDllsToWebcil: avoid doing unncessary conversion, and other work
  • [wasm] ManagedToNativeGenerator: add support for incremental runs (time goes from 1.6s to <900ms)
This improves build times ~30% for no-op rebuilds.
With native referenceOldNewDifference%
First build8.01s8.13s+0.12s
4th rebuild1.91s1.35s-0.56s29%
rebuild with only cs change2.90s2.48s-0.42s14%
Without native referenceOldNewDifference%
First build5.34s5.29-0.05s
4th rebuild1.78s1.20s-0.58s32%
rebuild with only cs change1.96s1.45s-0.51s26%
Fixes#60245 .
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Aug 8, 2023
@ghostghost
assigned radicalAug 8, 2023
@ghostghost
added
the 
area-Build-mono

label
Aug 8, 2023
@ghost
ghost
commented
Aug 8, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • [wasm] Sanity check emcc versions only when using a custom EMSDK_PATH
  • [wasm] Emit a message about compiling native assets only when actually doing so
  • [wasm] ConvertDllsToWebcil: avoid doing unncessary conversion, and other work
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radical
radicalforce-pushed
the
wasm-incremental-build
branch
from
0eee015 to
22f2daaCompareAugust 8, 2023 23:43
@radicalradical
changed the title
wasm incremental build[wasm] Incremental build improvementsAug 8, 2023
@radical
radical
commented
Aug 11, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 11, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Aug 11, 2023

Closed


Closed

@radical
[wasm] Makefile: update helper targets
b3566f5
@radical
[wasm] Run emcc --version when necessary
3468aa2
- Check emcc versions *if* `EMSDK_PATH` was explicitly set, IOW,
workloads are not in use
@radical
[wasm] ConvertDllsToWebCil: Avoid unncessary conversion
5374ff4
Convert the assemblies only if needed.
@radical
[wasm] ManagedToNativeGenerator: avoid unncessary work
bc986f2
- If the inputs are older than the outputs, then no work needs to be
done
- The inputs consist of the assemblies to scan, and a list of pinvoke
modules.
- Timestamps are used for the assemblies
- And for the pinvoke modules list, we save that in a cache file, and
use that to determine if any work needs to be done.
@radical
[wasm] Remove misleading message
c044c20
`EmccCompile` task build compiles some `.c` files, but skips them if the
output files are already up-to-date. But the build always emits a
`Compiling native assets with emcc with ..` message, which suggests that
there is some native build being run. Instead, emit this message only if
`EmccCompile` actually did any work.
@radical
minor - add paths for wasm vscode workspace
dda5b20
@radical
radicalforce-pushed
the
wasm-incremental-build
branch
from
34390f4 to
dda5b20CompareAugust 11, 2023 06:05
@radical
radical
marked this pull request as ready for review
August 11, 2023 06:37
@radical
radical
requested a review
from marafAugust 11, 2023 06:38
@radical
radical
commented
Aug 11, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 11, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
pavelsavara
pavelsavara
reviewed
Aug 11, 2023
View reviewed changes
Comment threadsrc/mono/wasm/build/WasmApp.Native.targets

This was referenced Aug 11, 2023

Closed


Closed

@radical
radical
commented
Aug 11, 2023

Copy link


Copy Markdown

MemberAuthor
Failures are unrelated.
kg
kg
reviewed
Aug 13, 2023
View reviewed changes
Comment threadsrc/mono/wasm/Makefile
Outdated

kg
kg
approved these changes
Aug 14, 2023
View reviewed changes
@kgkg
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong in here, though I'm not an expert on the table generators or msbuild
maraf
maraf
approved these changes
Aug 14, 2023
View reviewed changes
@marafmaraf
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
@radical
radical
merged commit 711447a
into
dotnet:mainAug 14, 2023
@radical
radical
deleted the

wasm-incremental-build

branch
August 14, 2023 15:49
@ghostghost
locked as resolved and limited conversation to collaborators
Sep 13, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@pavelsavarapavelsavarapavelsavara left review comments
@marafmarafmaraf approved these changes
@SteveSandersonMSSteveSandersonMSAwaiting requested review from SteveSandersonMS
@lewinglewingAwaiting requested review from lewinglewing is a code owner

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

WebAssembly native dependency builds incrementalism is still slow


4 participants

@radical@kg@pavelsavara@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[wasm] Incremental build improvements by radical · Pull Request #90194 · dotnet/runtime · GitHub
Skip to content
[wasm] Incremental build improvements - #90194
Merged
radical merged 10 commits into
dotnet:mainfrom 
radical:wasm-incremental-build
Aug 14, 2023
Merged
[wasm] Incremental build improvements#90194
radical merged 10 commits into
dotnet:mainfrom 
radical:wasm-incremental-build
Conversation
@radical
@radicalradical
commented
Aug 8, 2023•

edited

Loading

Copy link


Copy Markdown

Member
  • [wasm] Sanity check emcc versions only when using a custom EMSDK_PATH
  • [wasm] Emit a message about compiling native assets only when actually doing so
  • [wasm] ConvertDllsToWebcil: avoid doing unncessary conversion, and other work
  • [wasm] ManagedToNativeGenerator: add support for incremental runs (time goes from 1.6s to <900ms)
This improves build times ~30% for no-op rebuilds.
With native referenceOldNewDifference%
First build8.01s8.13s+0.12s
4th rebuild1.91s1.35s-0.56s29%
rebuild with only cs change2.90s2.48s-0.42s14%
Without native referenceOldNewDifference%
First build5.34s5.29-0.05s
4th rebuild1.78s1.20s-0.58s32%
rebuild with only cs change1.96s1.45s-0.51s26%
Fixes#60245 .
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Aug 8, 2023
@ghostghost
assigned radicalAug 8, 2023
@ghostghost
added
the 
area-Build-mono

label
Aug 8, 2023
@ghost
ghost
commented
Aug 8, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • [wasm] Sanity check emcc versions only when using a custom EMSDK_PATH
  • [wasm] Emit a message about compiling native assets only when actually doing so
  • [wasm] ConvertDllsToWebcil: avoid doing unncessary conversion, and other work
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radical
radicalforce-pushed
the
wasm-incremental-build
branch
from
0eee015 to
22f2daaCompareAugust 8, 2023 23:43
@radicalradical
changed the title
wasm incremental build[wasm] Incremental build improvementsAug 8, 2023
@radical
radical
commented
Aug 11, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 11, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Aug 11, 2023

Closed


Closed

@radical
[wasm] Makefile: update helper targets
b3566f5
@radical
[wasm] Run emcc --version when necessary
3468aa2
- Check emcc versions *if* `EMSDK_PATH` was explicitly set, IOW,
workloads are not in use
@radical
[wasm] ConvertDllsToWebCil: Avoid unncessary conversion
5374ff4
Convert the assemblies only if needed.
@radical
[wasm] ManagedToNativeGenerator: avoid unncessary work
bc986f2
- If the inputs are older than the outputs, then no work needs to be
done
- The inputs consist of the assemblies to scan, and a list of pinvoke
modules.
- Timestamps are used for the assemblies
- And for the pinvoke modules list, we save that in a cache file, and
use that to determine if any work needs to be done.
@radical
[wasm] Remove misleading message
c044c20
`EmccCompile` task build compiles some `.c` files, but skips them if the
output files are already up-to-date. But the build always emits a
`Compiling native assets with emcc with ..` message, which suggests that
there is some native build being run. Instead, emit this message only if
`EmccCompile` actually did any work.
@radical
minor - add paths for wasm vscode workspace
dda5b20
@radical
radicalforce-pushed
the
wasm-incremental-build
branch
from
34390f4 to
dda5b20CompareAugust 11, 2023 06:05
@radical
radical
marked this pull request as ready for review
August 11, 2023 06:37
@radical
radical
requested a review
from marafAugust 11, 2023 06:38
@radical
radical
commented
Aug 11, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 11, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
pavelsavara
pavelsavara
reviewed
Aug 11, 2023
View reviewed changes
Comment threadsrc/mono/wasm/build/WasmApp.Native.targets

This was referenced Aug 11, 2023

Closed


Closed

@radical
radical
commented
Aug 11, 2023

Copy link


Copy Markdown

MemberAuthor
Failures are unrelated.
kg
kg
reviewed
Aug 13, 2023
View reviewed changes
Comment threadsrc/mono/wasm/Makefile
Outdated

kg
kg
approved these changes
Aug 14, 2023
View reviewed changes
@kgkg
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong in here, though I'm not an expert on the table generators or msbuild
maraf
maraf
approved these changes
Aug 14, 2023
View reviewed changes
@marafmaraf
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
@radical
radical
merged commit 711447a
into
dotnet:mainAug 14, 2023
@radical
radical
deleted the

wasm-incremental-build

branch
August 14, 2023 15:49
@ghostghost
locked as resolved and limited conversation to collaborators
Sep 13, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@pavelsavarapavelsavarapavelsavara left review comments
@marafmarafmaraf approved these changes
@SteveSandersonMSSteveSandersonMSAwaiting requested review from SteveSandersonMS
@lewinglewingAwaiting requested review from lewinglewing is a code owner

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

WebAssembly native dependency builds incrementalism is still slow


4 participants

@radical@kg@pavelsavara@maraf