') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [mono] Enabled tests failing previously on fullaot by LeVladIonescu · Pull Request #90280 · dotnet/runtime · GitHub
Skip to content

[mono] Enabled tests failing previously on fullaot - #90280

Merged
kotlarmilos merged 6 commits into
dotnet:mainfrom
LeVladIonescu:enableTests
Aug 11, 2023
Merged

[mono] Enabled tests failing previously on fullaot#90280
kotlarmilos merged 6 commits into
dotnet:mainfrom
LeVladIonescu:enableTests

Conversation

@LeVladIonescu

@LeVladIonescuLeVladIonescu commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

Related to #57350 and #70492.

Vlad - Alexandru Ionescuand others added 5 commits July 26, 2023 15:08
Vlad - Alexandru IonescuVlad - Alexandru Ionescu
Enabled rest of V4 intrinsics
95600f3
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>
@LeVladIonescu
Added support for non-constant index
ec41d45
Signed-off-by: Vlad <vladionescu1399@gmail.com>
@LeVladIonescu
Merge branch 'dotnet:main' into main
f9e847e
@LeVladIonescu
Merge branch 'dotnet:main' into main
bb0d8cc
@LeVladIonescu
Enabled tests
d42c4b1
Signed-off-by: Vlad <vladionescu1399@gmail.com>
@LeVladIonescuLeVladIonescu self-assigned this Aug 9, 2023
@build-analysisbuild-analysisBot mentioned this pull request Aug 10, 2023
Closed
3 tasks
@LeVladIonescu

LeVladIonescu commented Aug 10, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Aug 10, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

kotlarmilos
kotlarmilos reviewed Aug 10, 2023
View reviewed changes

@kotlarmiloskotlarmilos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let us know when you get the green CI. Also, make sure to close related issues when this PR is merged, if they are fully resolved.

@SamMonoRT

SamMonoRT commented Aug 10, 2023

Copy link
Copy Markdown
Member

We should verify the passing tests in the log files before merging.

This was referenced Aug 10, 2023
Closed
Closed
Open
Closed
Closed
Closed
@LeVladIonescu

LeVladIonescu commented Aug 10, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp list

@azure-pipelines

azure-pipelinesBot commented Aug 10, 2023

Copy link
Copy Markdown
CI/CD Pipelines for this repository:

@LeVladIonescu

LeVladIonescu commented Aug 10, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime

@azure-pipelines

azure-pipelinesBot commented Aug 10, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Aug 10, 2023
Closed
Closed
Closed
@kotlarmilos

kotlarmilos commented Aug 11, 2023

Copy link
Copy Markdown
Member

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Aug 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos

kotlarmilos commented Aug 11, 2023

Copy link
Copy Markdown
Member

The enabled tests have passed on apple mobile platforms according to the CI status and logs. There are failed library tests which shouldn't be related.

@SamMonoRT

SamMonoRT commented Aug 11, 2023

Copy link
Copy Markdown
Member

Should close #70492 and #57350 when this PR is merged. Want to make sure fullaot passes too once #86324 is fixed. Likely we will not backport a fix to that failing lane in RC1, so should be good to go ahead.

@build-analysisbuild-analysisBot mentioned this pull request Aug 11, 2023
Closed
@kotlarmilos
kotlarmilos self-requested a review August 11, 2023 17:09
@kotlarmilos
kotlarmilos merged commit 4c2f1b6 into dotnet:mainAug 11, 2023
@ivanpovazan

ivanpovazan commented Aug 11, 2023•
edited
Loading

Copy link
Copy Markdown
Member

@LeVladIonescu@kotlarmilos could you please double check if the tests reported in #70492 have been enabled?

As I noted in the description of the issue, to enabling building the tests it was also required to adapt the: src/tests/JIT/Directed/callconv/Directory.Build.props file in order to enable building the tests for Mono.

I am asking this as this PR does not seem to include such change: https://github.com/LeVladIonescu/runtime_fork/blob/7cd6d011ac679dbdec44268a5571ecbfd7f864b2/src/tests/JIT/Directed/callconv/Directory.Build.props#L5

@kotlarmilos

kotlarmilos commented Aug 11, 2023•
edited
Loading

Copy link
Copy Markdown
Member

That is right. These tests haven't been executed on a device, so I will try to enable them in #90421.

@kotlarmiloskotlarmilos mentioned this pull request Aug 11, 2023
Merged
@ghostghost locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kotlarmiloskotlarmiloskotlarmilos approved these changes
@vargazvargazAwaiting requested review from vargaz
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT

Assignees

@LeVladIonescuLeVladIonescu

Labels

area-Codegen-AOT-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LeVladIonescu@SamMonoRT@kotlarmilos@ivanpovazan