') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [mono] Enable callconv and classloader runtime tests by kotlarmilos · Pull Request #90421 · dotnet/runtime · GitHub
Skip to content

[mono] Enable callconv and classloader runtime tests - #90421

Merged
kotlarmilos merged 4 commits into
dotnet:mainfrom
kotlarmilos:improvement/enable-runtime-tests-AOT
Aug 14, 2023
Merged

[mono] Enable callconv and classloader runtime tests#90421
kotlarmilos merged 4 commits into
dotnet:mainfrom
kotlarmilos:improvement/enable-runtime-tests-AOT

Conversation

@kotlarmilos

@kotlarmiloskotlarmilos commented Aug 11, 2023

Copy link
Copy Markdown
Member

This PR enables callconv and classloader runtime tests in AOT mode.

Fixes#90280 (comment)

@kotlarmiloskotlarmilos added this to the 8.0.0 milestone Aug 11, 2023
@ghost

ghost commented Aug 11, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR enables callconv and classloader runtime tests in AOT mode.

Fixes #90280 (comment)

Author:kotlarmilos
Assignees:kotlarmilos, LeVladIonescu
Labels:

area-Infrastructure-mono

Milestone:8.0.0

@kotlarmilos

kotlarmilos commented Aug 11, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Aug 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmiloskotlarmilos mentioned this pull request Aug 11, 2023
Merged
This was referenced Aug 11, 2023
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
@kotlarmilos

kotlarmilos commented Aug 12, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-ioslike

@azure-pipelines

azure-pipelinesBot commented Aug 12, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Aug 12, 2023
Open
@SamMonoRT

SamMonoRT commented Aug 12, 2023

Copy link
Copy Markdown
Member

Please verify the logs to ensure enabled tests are running/passing without known failures.

LeVladIonescu
LeVladIonescu approved these changes Aug 14, 2023
View reviewed changes

@LeVladIonescuLeVladIonescu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests successfully ran, failures look unrelated.

@kotlarmilos

kotlarmilos commented Aug 14, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-ioslike

@azure-pipelines

azure-pipelinesBot commented Aug 14, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos

kotlarmilos commented Aug 14, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

The JIT/Directed testing group is a merged testing group which is optimized for Helix execution but isn't compatible with apple mobile targets. I've attempted to enable merged testing groups in this PR, and currently waiting for the CI.

@kotlarmilos

kotlarmilos commented Aug 14, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-ioslike

@azure-pipelines

azure-pipelinesBot commented Aug 14, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos

kotlarmilos commented Aug 14, 2023

Copy link
Copy Markdown
MemberAuthor

@LeVladIonescu The runtime tests are using interpreter, so we can't confirm if the tests were executed successfully. I reopened the issue, which should be confirmed using apple mobile pipeline (once switched to full AOT mode) or full AOT linux pipeline.

This PR improves test coverage for apple mobile platforms and will be merged.

@kotlarmilos
kotlarmilos merged commit 4e31eab into dotnet:mainAug 14, 2023
@build-analysisbuild-analysisBot mentioned this pull request Aug 14, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SamMonoRTSamMonoRTSamMonoRT approved these changes
@ivanpovazanivanpovazanivanpovazan approved these changes
+1 more reviewer
@LeVladIonescuLeVladIonescuLeVladIonescu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kotlarmiloskotlarmilos

@LeVladIonescuLeVladIonescu

Labels

area-Infrastructure-mono

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@kotlarmilos@SamMonoRT@ivanpovazan@LeVladIonescu