Skip to content

Use Roslyn interceptors feature in binder gen - #90340

Merged
layomia merged 5 commits into
dotnet:mainfrom
layomia:binder-gen-interceptors
Aug 19, 2023
Merged

Use Roslyn interceptors feature in binder gen#90340
layomia merged 5 commits into
dotnet:mainfrom
layomia:binder-gen-interceptors

Conversation

@layomia

@layomialayomia commented Aug 10, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#89322.

@layomialayomia added this to the 8.0.0 milestone Aug 10, 2023
@layomialayomia self-assigned this Aug 10, 2023
@ghost

ghost commented Aug 10, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #89322.

Work left

Author:layomia
Assignees:layomia
Labels:

area-Extensions-Configuration

Milestone:8.0.0

@layomia
layomiaforce-pushed the binder-gen-interceptors branch from d1d8513 to 1327ed9CompareAugust 10, 2023 21:34
@build-analysisbuild-analysisBot mentioned this pull request Aug 11, 2023
Closed
@layomia
layomiaforce-pushed the binder-gen-interceptors branch 2 times, most recently from 7e0ce7c to 4c4022cCompareAugust 15, 2023 22:06
This was referenced Aug 16, 2023
Closed
Closed
Closed
@layomia
layomiaforce-pushed the binder-gen-interceptors branch 2 times, most recently from 88cb774 to d205853CompareAugust 17, 2023 15:41
layomia
layomia commented Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/gen/Model/SourceGenerationSpec.cs Outdated
layomia
layomia commented Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingGenerator.cs Outdated
@layomia
layomiaforce-pushed the binder-gen-interceptors branch from d205853 to f5d0e0eCompareAugust 17, 2023 16:29
@layomia
layomia marked this pull request as ready for review August 17, 2023 16:30
@layomia
layomia requested review from captainsafia, eerhardt, eiriktsarpalis and tarekgh and removed request for jeffhandleyAugust 17, 2023 16:30
@ericstj

ericstj commented Aug 17, 2023

Copy link
Copy Markdown
Member
image

🎉 🎉 🎉 Reviewers - let's have a look at this and try to get feedback in and addressed ASAP to make it for RC1.

ericstj
ericstj reviewed Aug 17, 2023
View reviewed changes
Comment thread...aries/Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingGenerator.Emitter.cs Outdated

@ericstjericstjAug 17, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we want to add something like https://github.com/dotnet/sdk/blob/4249701de6f005c670c7f371141e772d02f89156/src/WebSdk/ProjectSystem/Targets/Microsoft.NET.Sdk.Web.ProjectSystem.targets#L64 to our NuGet package targets, or will we ask users to set this? @eerhardt@tarekgh@captainsafia

@tarekghtarekghAug 17, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we decided to mimic whatever the aspnet is doing in the web project.

@ericstjericstjAug 17, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASP.NET doesn't ship a nuget package so we're special here. There's an ongoing discussion around this to decide what we want to do.

eiriktsarpalis
eiriktsarpalis reviewed Aug 17, 2023
View reviewed changes
Comment threaddocs/project/list-of-diagnostics.md Outdated
eiriktsarpalis
eiriktsarpalis reviewed Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/SourceGenerators/GeneratorHelpers.cs Outdated
@layomia
layomiaforce-pushed the binder-gen-interceptors branch 4 times, most recently from 80df566 to 743f89aCompareAugust 18, 2023 19:34
@layomialayomia closed this Aug 18, 2023
@layomia
layomiaforce-pushed the binder-gen-interceptors branch from 743f89a to f3fe768CompareAugust 18, 2023 20:02
@layomialayomia reopened this Aug 18, 2023
@layomia
layomiaforce-pushed the binder-gen-interceptors branch 2 times, most recently from 4303ea5 to d8aa6d9CompareAugust 18, 2023 21:01
@layomialayomia mentioned this pull request Aug 18, 2023
Closed
@layomia

layomia commented Aug 18, 2023

Copy link
Copy Markdown
ContributorAuthor

Closing notes

Name clashes

Not needed for this feature to work & there's no new risk added here. I'll address in #86363. I've reverted the changes to the options generator and left out unique name generation in this generator.

Testing

There's always room to improve coverage, but I believe these suffice for merging this PR.

  • Interceptors handling multiple calls, including across different files.
    • Emitted source for the binder test project shows this is well covered.
  • Diagnostic suppressions where applicable
    • numerous binding calls in extensions assemblies which are linker trimmed show that this handled correctly
  • Not suppressing diagnostics for calls we didn't intercept:
    • tested with simple console application
  • Polymorphic type handling: Microsoft.Extensions.Logging.Console assembly exercises/validates the updated logic.

@layomia

layomia commented Aug 18, 2023

Copy link
Copy Markdown
ContributorAuthor

/backport to release/8.0-rc1

@github-actions

github-actionsBot commented Aug 18, 2023

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5907490321

@github-actionsgithub-actionsBot mentioned this pull request Aug 18, 2023
Merged
@layomia

layomia commented Aug 18, 2023

Copy link
Copy Markdown
ContributorAuthor

Test failures seem to be caused by applying the code analysis version update across all projects. Will fix.

@layomia
layomiaforce-pushed the binder-gen-interceptors branch from b267af5 to 5210070CompareAugust 18, 2023 23:42
@layomia
layomiaforce-pushed the binder-gen-interceptors branch from 5210070 to d9504fdCompareAugust 18, 2023 23:58
@layomia
layomiaforce-pushed the binder-gen-interceptors branch from d9504fd to 6fff866CompareAugust 19, 2023 00:28
@layomia
layomia merged commit a5ff66c into dotnet:mainAug 19, 2023
@jaredparjaredpar mentioned this pull request Aug 21, 2023
Merged
This was referenced Aug 22, 2023
Merged
Merged
@MichaelSimonsMichaelSimons mentioned this pull request Aug 24, 2023
Merged
@ghostghost locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tmattmattmat left review comments
@stephentoubstephentoubstephentoub left review comments
@eiriktsarpaliseiriktsarpaliseiriktsarpalis approved these changes
@RikkiGibsonRikkiGibsonRikkiGibson left review comments
@eerhardteerhardteerhardt left review comments
@ericstjericstjericstj left review comments
@tarekghtarekghtarekgh approved these changes
@captainsafiacaptainsafiaAwaiting requested review from captainsafia

Assignees

@layomialayomia

Labels

area-Extensions-Configuration

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Use Roslyn interceptors feature in config binder generator

9 participants

@layomia@ericstj@tmat@captainsafia@stephentoub@eiriktsarpalis@RikkiGibson@eerhardt@tarekgh
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Use Roslyn interceptors feature in binder gen by layomia · Pull Request #90340 · dotnet/runtime · GitHub
Skip to content
Use Roslyn interceptors feature in binder gen - #90340
Merged
layomia merged 5 commits into
dotnet:mainfrom 
layomia:binder-gen-interceptors
Aug 19, 2023
Merged
Use Roslyn interceptors feature in binder gen#90340
layomia merged 5 commits into
dotnet:mainfrom 
layomia:binder-gen-interceptors
Conversation
@layomia
@layomialayomia
commented
Aug 10, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#89322.
@layomialayomia
added this to the 8.0.0 milestone
Aug 10, 2023
@layomialayomia
self-assigned this
Aug 10, 2023
@ghost
ghost
commented
Aug 10, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-extensions-configuration

See info in area-owners.md if you want to be subscribed.
Issue Details
Fixes #89322.
Work left
Author:layomia
Assignees:layomia
Labels:
area-Extensions-Configuration
Milestone:8.0.0
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
d1d8513 to
1327ed9CompareAugust 10, 2023 21:34
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 11, 2023

Closed

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
2 times, most recently
from
7e0ce7c to
4c4022cCompareAugust 15, 2023 22:06

This was referenced Aug 16, 2023

Closed


Closed


Closed

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
2 times, most recently
from
88cb774 to
d205853CompareAugust 17, 2023 15:41
layomia
layomia
commented
Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/gen/Model/SourceGenerationSpec.cs
Outdated

layomia
layomia
commented
Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingGenerator.cs
Outdated

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
d205853 to
f5d0e0eCompareAugust 17, 2023 16:29
@layomia
layomia
marked this pull request as ready for review
August 17, 2023 16:30
@layomia
layomia
requested review from
captainsafia, eerhardt, eiriktsarpalis and tarekgh
and removed request for
jeffhandleyAugust 17, 2023 16:30
@ericstj
ericstj
commented
Aug 17, 2023

Copy link


Copy Markdown

Member
image
🎉 🎉 🎉 Reviewers - let's have a look at this and try to get feedback in and addressed ASAP to make it for RC1.
ericstj
ericstj
reviewed
Aug 17, 2023
View reviewed changes
Comment thread...aries/Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingGenerator.Emitter.cs
Outdated

@ericstjericstjAug 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we want to add something like https://github.com/dotnet/sdk/blob/4249701de6f005c670c7f371141e772d02f89156/src/WebSdk/ProjectSystem/Targets/Microsoft.NET.Sdk.Web.ProjectSystem.targets#L64 to our NuGet package targets, or will we ask users to set this? @eerhardt@tarekgh@captainsafia
@tarekghtarekghAug 17, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we decided to mimic whatever the aspnet is doing in the web project.
@ericstjericstjAug 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASP.NET doesn't ship a nuget package so we're special here. There's an ongoing discussion around this to decide what we want to do.
eiriktsarpalis
eiriktsarpalis
reviewed
Aug 17, 2023
View reviewed changes
Comment threaddocs/project/list-of-diagnostics.md
Outdated

eiriktsarpalis
eiriktsarpalis
reviewed
Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/SourceGenerators/GeneratorHelpers.cs
Outdated

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
4 times, most recently
from
80df566 to
743f89aCompareAugust 18, 2023 19:34
@layomialayomia
closed this
Aug 18, 2023
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
743f89a to
f3fe768CompareAugust 18, 2023 20:02
@layomialayomia
reopened this
Aug 18, 2023
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
2 times, most recently
from
4303ea5 to
d8aa6d9CompareAugust 18, 2023 21:01
@layomialayomia
mentioned this pull request
Aug 18, 2023

Closed

@layomia
layomia
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
Closing notes
Name clashes
Not needed for this feature to work & there's no new risk added here. I'll address in #86363. I've reverted the changes to the options generator and left out unique name generation in this generator.
Testing
There's always room to improve coverage, but I believe these suffice for merging this PR.
  • Interceptors handling multiple calls, including across different files.

    • Emitted source for the binder test project shows this is well covered.
  • Diagnostic suppressions where applicable

    • numerous binding calls in extensions assemblies which are linker trimmed show that this handled correctly
  • Not suppressing diagnostics for calls we didn't intercept:

    • tested with simple console application
  • Polymorphic type handling: Microsoft.Extensions.Logging.Console assembly exercises/validates the updated logic.
@layomia
layomia
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0-rc1
@github-actions
github-actionsBot
commented
Aug 18, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5907490321
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2023
 Merged

@layomia
layomia
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
Test failures seem to be caused by applying the code analysis version update across all projects. Will fix.
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
b267af5 to
5210070CompareAugust 18, 2023 23:42
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
5210070 to
d9504fdCompareAugust 18, 2023 23:58
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
d9504fd to
6fff866CompareAugust 19, 2023 00:28
@layomia
layomia
merged commit a5ff66c
into
dotnet:mainAug 19, 2023
@jaredparjaredpar
mentioned this pull request
Aug 21, 2023
 Merged


This was referenced Aug 22, 2023
 Merged

 Merged

@MichaelSimonsMichaelSimons
mentioned this pull request
Aug 24, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 18, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tmattmattmat left review comments
@stephentoubstephentoubstephentoub left review comments
@eiriktsarpaliseiriktsarpaliseiriktsarpalis approved these changes
@RikkiGibsonRikkiGibsonRikkiGibson left review comments
@eerhardteerhardteerhardt left review comments
@ericstjericstjericstj left review comments
@tarekghtarekghtarekgh approved these changes
@captainsafiacaptainsafiaAwaiting requested review from captainsafia

Assignees

@layomialayomia

Labels

area-Extensions-Configuration

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Use Roslyn interceptors feature in config binder generator


9 participants

@layomia@ericstj@tmat@captainsafia@stephentoub@eiriktsarpalis@RikkiGibson@eerhardt@tarekgh

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Use Roslyn interceptors feature in binder gen by layomia · Pull Request #90340 · dotnet/runtime · GitHub
Skip to content
Use Roslyn interceptors feature in binder gen - #90340
Merged
layomia merged 5 commits into
dotnet:mainfrom 
layomia:binder-gen-interceptors
Aug 19, 2023
Merged
Use Roslyn interceptors feature in binder gen#90340
layomia merged 5 commits into
dotnet:mainfrom 
layomia:binder-gen-interceptors
Conversation
@layomia
@layomialayomia
commented
Aug 10, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#89322.
@layomialayomia
added this to the 8.0.0 milestone
Aug 10, 2023
@layomialayomia
self-assigned this
Aug 10, 2023
@ghost
ghost
commented
Aug 10, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-extensions-configuration

See info in area-owners.md if you want to be subscribed.
Issue Details
Fixes #89322.
Work left
Author:layomia
Assignees:layomia
Labels:
area-Extensions-Configuration
Milestone:8.0.0
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
d1d8513 to
1327ed9CompareAugust 10, 2023 21:34
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 11, 2023

Closed

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
2 times, most recently
from
7e0ce7c to
4c4022cCompareAugust 15, 2023 22:06

This was referenced Aug 16, 2023

Closed


Closed


Closed

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
2 times, most recently
from
88cb774 to
d205853CompareAugust 17, 2023 15:41
layomia
layomia
commented
Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/gen/Model/SourceGenerationSpec.cs
Outdated

layomia
layomia
commented
Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingGenerator.cs
Outdated

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
d205853 to
f5d0e0eCompareAugust 17, 2023 16:29
@layomia
layomia
marked this pull request as ready for review
August 17, 2023 16:30
@layomia
layomia
requested review from
captainsafia, eerhardt, eiriktsarpalis and tarekgh
and removed request for
jeffhandleyAugust 17, 2023 16:30
@ericstj
ericstj
commented
Aug 17, 2023

Copy link


Copy Markdown

Member
image
🎉 🎉 🎉 Reviewers - let's have a look at this and try to get feedback in and addressed ASAP to make it for RC1.
ericstj
ericstj
reviewed
Aug 17, 2023
View reviewed changes
Comment thread...aries/Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingGenerator.Emitter.cs
Outdated

@ericstjericstjAug 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we want to add something like https://github.com/dotnet/sdk/blob/4249701de6f005c670c7f371141e772d02f89156/src/WebSdk/ProjectSystem/Targets/Microsoft.NET.Sdk.Web.ProjectSystem.targets#L64 to our NuGet package targets, or will we ask users to set this? @eerhardt@tarekgh@captainsafia
@tarekghtarekghAug 17, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we decided to mimic whatever the aspnet is doing in the web project.
@ericstjericstjAug 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASP.NET doesn't ship a nuget package so we're special here. There's an ongoing discussion around this to decide what we want to do.
eiriktsarpalis
eiriktsarpalis
reviewed
Aug 17, 2023
View reviewed changes
Comment threaddocs/project/list-of-diagnostics.md
Outdated

eiriktsarpalis
eiriktsarpalis
reviewed
Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/SourceGenerators/GeneratorHelpers.cs
Outdated

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
4 times, most recently
from
80df566 to
743f89aCompareAugust 18, 2023 19:34
@layomialayomia
closed this
Aug 18, 2023
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
743f89a to
f3fe768CompareAugust 18, 2023 20:02
@layomialayomia
reopened this
Aug 18, 2023
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
2 times, most recently
from
4303ea5 to
d8aa6d9CompareAugust 18, 2023 21:01
@layomialayomia
mentioned this pull request
Aug 18, 2023

Closed

@layomia
layomia
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
Closing notes
Name clashes
Not needed for this feature to work & there's no new risk added here. I'll address in #86363. I've reverted the changes to the options generator and left out unique name generation in this generator.
Testing
There's always room to improve coverage, but I believe these suffice for merging this PR.
  • Interceptors handling multiple calls, including across different files.

    • Emitted source for the binder test project shows this is well covered.
  • Diagnostic suppressions where applicable

    • numerous binding calls in extensions assemblies which are linker trimmed show that this handled correctly
  • Not suppressing diagnostics for calls we didn't intercept:

    • tested with simple console application
  • Polymorphic type handling: Microsoft.Extensions.Logging.Console assembly exercises/validates the updated logic.
@layomia
layomia
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0-rc1
@github-actions
github-actionsBot
commented
Aug 18, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5907490321
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2023
 Merged

@layomia
layomia
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
Test failures seem to be caused by applying the code analysis version update across all projects. Will fix.
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
b267af5 to
5210070CompareAugust 18, 2023 23:42
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
5210070 to
d9504fdCompareAugust 18, 2023 23:58
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
d9504fd to
6fff866CompareAugust 19, 2023 00:28
@layomia
layomia
merged commit a5ff66c
into
dotnet:mainAug 19, 2023
@jaredparjaredpar
mentioned this pull request
Aug 21, 2023
 Merged


This was referenced Aug 22, 2023
 Merged

 Merged

@MichaelSimonsMichaelSimons
mentioned this pull request
Aug 24, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 18, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tmattmattmat left review comments
@stephentoubstephentoubstephentoub left review comments
@eiriktsarpaliseiriktsarpaliseiriktsarpalis approved these changes
@RikkiGibsonRikkiGibsonRikkiGibson left review comments
@eerhardteerhardteerhardt left review comments
@ericstjericstjericstj left review comments
@tarekghtarekghtarekgh approved these changes
@captainsafiacaptainsafiaAwaiting requested review from captainsafia

Assignees

@layomialayomia

Labels

area-Extensions-Configuration

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Use Roslyn interceptors feature in config binder generator


9 participants

@layomia@ericstj@tmat@captainsafia@stephentoub@eiriktsarpalis@RikkiGibson@eerhardt@tarekgh

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Use Roslyn interceptors feature in binder gen by layomia · Pull Request #90340 · dotnet/runtime · GitHub
Skip to content
Use Roslyn interceptors feature in binder gen - #90340
Merged
layomia merged 5 commits into
dotnet:mainfrom 
layomia:binder-gen-interceptors
Aug 19, 2023
Merged
Use Roslyn interceptors feature in binder gen#90340
layomia merged 5 commits into
dotnet:mainfrom 
layomia:binder-gen-interceptors
Conversation
@layomia
@layomialayomia
commented
Aug 10, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#89322.
@layomialayomia
added this to the 8.0.0 milestone
Aug 10, 2023
@layomialayomia
self-assigned this
Aug 10, 2023
@ghost
ghost
commented
Aug 10, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-extensions-configuration

See info in area-owners.md if you want to be subscribed.
Issue Details
Fixes #89322.
Work left
Author:layomia
Assignees:layomia
Labels:
area-Extensions-Configuration
Milestone:8.0.0
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
d1d8513 to
1327ed9CompareAugust 10, 2023 21:34
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 11, 2023

Closed

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
2 times, most recently
from
7e0ce7c to
4c4022cCompareAugust 15, 2023 22:06

This was referenced Aug 16, 2023

Closed


Closed


Closed

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
2 times, most recently
from
88cb774 to
d205853CompareAugust 17, 2023 15:41
layomia
layomia
commented
Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/gen/Model/SourceGenerationSpec.cs
Outdated

layomia
layomia
commented
Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingGenerator.cs
Outdated

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
d205853 to
f5d0e0eCompareAugust 17, 2023 16:29
@layomia
layomia
marked this pull request as ready for review
August 17, 2023 16:30
@layomia
layomia
requested review from
captainsafia, eerhardt, eiriktsarpalis and tarekgh
and removed request for
jeffhandleyAugust 17, 2023 16:30
@ericstj
ericstj
commented
Aug 17, 2023

Copy link


Copy Markdown

Member
image
🎉 🎉 🎉 Reviewers - let's have a look at this and try to get feedback in and addressed ASAP to make it for RC1.
ericstj
ericstj
reviewed
Aug 17, 2023
View reviewed changes
Comment thread...aries/Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingGenerator.Emitter.cs
Outdated

@ericstjericstjAug 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we want to add something like https://github.com/dotnet/sdk/blob/4249701de6f005c670c7f371141e772d02f89156/src/WebSdk/ProjectSystem/Targets/Microsoft.NET.Sdk.Web.ProjectSystem.targets#L64 to our NuGet package targets, or will we ask users to set this? @eerhardt@tarekgh@captainsafia
@tarekghtarekghAug 17, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we decided to mimic whatever the aspnet is doing in the web project.
@ericstjericstjAug 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASP.NET doesn't ship a nuget package so we're special here. There's an ongoing discussion around this to decide what we want to do.
eiriktsarpalis
eiriktsarpalis
reviewed
Aug 17, 2023
View reviewed changes
Comment threaddocs/project/list-of-diagnostics.md
Outdated

eiriktsarpalis
eiriktsarpalis
reviewed
Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/SourceGenerators/GeneratorHelpers.cs
Outdated

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
4 times, most recently
from
80df566 to
743f89aCompareAugust 18, 2023 19:34
@layomialayomia
closed this
Aug 18, 2023
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
743f89a to
f3fe768CompareAugust 18, 2023 20:02
@layomialayomia
reopened this
Aug 18, 2023
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
2 times, most recently
from
4303ea5 to
d8aa6d9CompareAugust 18, 2023 21:01
@layomialayomia
mentioned this pull request
Aug 18, 2023

Closed

@layomia
layomia
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
Closing notes
Name clashes
Not needed for this feature to work & there's no new risk added here. I'll address in #86363. I've reverted the changes to the options generator and left out unique name generation in this generator.
Testing
There's always room to improve coverage, but I believe these suffice for merging this PR.
  • Interceptors handling multiple calls, including across different files.

    • Emitted source for the binder test project shows this is well covered.
  • Diagnostic suppressions where applicable

    • numerous binding calls in extensions assemblies which are linker trimmed show that this handled correctly
  • Not suppressing diagnostics for calls we didn't intercept:

    • tested with simple console application
  • Polymorphic type handling: Microsoft.Extensions.Logging.Console assembly exercises/validates the updated logic.
@layomia
layomia
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0-rc1
@github-actions
github-actionsBot
commented
Aug 18, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5907490321
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2023
 Merged

@layomia
layomia
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
Test failures seem to be caused by applying the code analysis version update across all projects. Will fix.
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
b267af5 to
5210070CompareAugust 18, 2023 23:42
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
5210070 to
d9504fdCompareAugust 18, 2023 23:58
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
d9504fd to
6fff866CompareAugust 19, 2023 00:28
@layomia
layomia
merged commit a5ff66c
into
dotnet:mainAug 19, 2023
@jaredparjaredpar
mentioned this pull request
Aug 21, 2023
 Merged


This was referenced Aug 22, 2023
 Merged

 Merged

@MichaelSimonsMichaelSimons
mentioned this pull request
Aug 24, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 18, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tmattmattmat left review comments
@stephentoubstephentoubstephentoub left review comments
@eiriktsarpaliseiriktsarpaliseiriktsarpalis approved these changes
@RikkiGibsonRikkiGibsonRikkiGibson left review comments
@eerhardteerhardteerhardt left review comments
@ericstjericstjericstj left review comments
@tarekghtarekghtarekgh approved these changes
@captainsafiacaptainsafiaAwaiting requested review from captainsafia

Assignees

@layomialayomia

Labels

area-Extensions-Configuration

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Use Roslyn interceptors feature in config binder generator


9 participants

@layomia@ericstj@tmat@captainsafia@stephentoub@eiriktsarpalis@RikkiGibson@eerhardt@tarekgh

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Use Roslyn interceptors feature in binder gen by layomia · Pull Request #90340 · dotnet/runtime · GitHub
Skip to content
Use Roslyn interceptors feature in binder gen - #90340
Merged
layomia merged 5 commits into
dotnet:mainfrom 
layomia:binder-gen-interceptors
Aug 19, 2023
Merged
Use Roslyn interceptors feature in binder gen#90340
layomia merged 5 commits into
dotnet:mainfrom 
layomia:binder-gen-interceptors
Conversation
@layomia
@layomialayomia
commented
Aug 10, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#89322.
@layomialayomia
added this to the 8.0.0 milestone
Aug 10, 2023
@layomialayomia
self-assigned this
Aug 10, 2023
@ghost
ghost
commented
Aug 10, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-extensions-configuration

See info in area-owners.md if you want to be subscribed.
Issue Details
Fixes #89322.
Work left
Author:layomia
Assignees:layomia
Labels:
area-Extensions-Configuration
Milestone:8.0.0
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
d1d8513 to
1327ed9CompareAugust 10, 2023 21:34
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 11, 2023

Closed

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
2 times, most recently
from
7e0ce7c to
4c4022cCompareAugust 15, 2023 22:06

This was referenced Aug 16, 2023

Closed


Closed


Closed

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
2 times, most recently
from
88cb774 to
d205853CompareAugust 17, 2023 15:41
layomia
layomia
commented
Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/gen/Model/SourceGenerationSpec.cs
Outdated

layomia
layomia
commented
Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingGenerator.cs
Outdated

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
d205853 to
f5d0e0eCompareAugust 17, 2023 16:29
@layomia
layomia
marked this pull request as ready for review
August 17, 2023 16:30
@layomia
layomia
requested review from
captainsafia, eerhardt, eiriktsarpalis and tarekgh
and removed request for
jeffhandleyAugust 17, 2023 16:30
@ericstj
ericstj
commented
Aug 17, 2023

Copy link


Copy Markdown

Member
image
🎉 🎉 🎉 Reviewers - let's have a look at this and try to get feedback in and addressed ASAP to make it for RC1.
ericstj
ericstj
reviewed
Aug 17, 2023
View reviewed changes
Comment thread...aries/Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingGenerator.Emitter.cs
Outdated

@ericstjericstjAug 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we want to add something like https://github.com/dotnet/sdk/blob/4249701de6f005c670c7f371141e772d02f89156/src/WebSdk/ProjectSystem/Targets/Microsoft.NET.Sdk.Web.ProjectSystem.targets#L64 to our NuGet package targets, or will we ask users to set this? @eerhardt@tarekgh@captainsafia
@tarekghtarekghAug 17, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we decided to mimic whatever the aspnet is doing in the web project.
@ericstjericstjAug 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASP.NET doesn't ship a nuget package so we're special here. There's an ongoing discussion around this to decide what we want to do.
eiriktsarpalis
eiriktsarpalis
reviewed
Aug 17, 2023
View reviewed changes
Comment threaddocs/project/list-of-diagnostics.md
Outdated

eiriktsarpalis
eiriktsarpalis
reviewed
Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/SourceGenerators/GeneratorHelpers.cs
Outdated

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
4 times, most recently
from
80df566 to
743f89aCompareAugust 18, 2023 19:34
@layomialayomia
closed this
Aug 18, 2023
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
743f89a to
f3fe768CompareAugust 18, 2023 20:02
@layomialayomia
reopened this
Aug 18, 2023
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
2 times, most recently
from
4303ea5 to
d8aa6d9CompareAugust 18, 2023 21:01
@layomialayomia
mentioned this pull request
Aug 18, 2023

Closed

@layomia
layomia
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
Closing notes
Name clashes
Not needed for this feature to work & there's no new risk added here. I'll address in #86363. I've reverted the changes to the options generator and left out unique name generation in this generator.
Testing
There's always room to improve coverage, but I believe these suffice for merging this PR.
  • Interceptors handling multiple calls, including across different files.

    • Emitted source for the binder test project shows this is well covered.
  • Diagnostic suppressions where applicable

    • numerous binding calls in extensions assemblies which are linker trimmed show that this handled correctly
  • Not suppressing diagnostics for calls we didn't intercept:

    • tested with simple console application
  • Polymorphic type handling: Microsoft.Extensions.Logging.Console assembly exercises/validates the updated logic.
@layomia
layomia
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0-rc1
@github-actions
github-actionsBot
commented
Aug 18, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5907490321
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2023
 Merged

@layomia
layomia
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
Test failures seem to be caused by applying the code analysis version update across all projects. Will fix.
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
b267af5 to
5210070CompareAugust 18, 2023 23:42
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
5210070 to
d9504fdCompareAugust 18, 2023 23:58
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
d9504fd to
6fff866CompareAugust 19, 2023 00:28
@layomia
layomia
merged commit a5ff66c
into
dotnet:mainAug 19, 2023
@jaredparjaredpar
mentioned this pull request
Aug 21, 2023
 Merged


This was referenced Aug 22, 2023
 Merged

 Merged

@MichaelSimonsMichaelSimons
mentioned this pull request
Aug 24, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 18, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tmattmattmat left review comments
@stephentoubstephentoubstephentoub left review comments
@eiriktsarpaliseiriktsarpaliseiriktsarpalis approved these changes
@RikkiGibsonRikkiGibsonRikkiGibson left review comments
@eerhardteerhardteerhardt left review comments
@ericstjericstjericstj left review comments
@tarekghtarekghtarekgh approved these changes
@captainsafiacaptainsafiaAwaiting requested review from captainsafia

Assignees

@layomialayomia

Labels

area-Extensions-Configuration

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Use Roslyn interceptors feature in config binder generator


9 participants

@layomia@ericstj@tmat@captainsafia@stephentoub@eiriktsarpalis@RikkiGibson@eerhardt@tarekgh

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Use Roslyn interceptors feature in binder gen by layomia · Pull Request #90340 · dotnet/runtime · GitHub
Skip to content
Use Roslyn interceptors feature in binder gen - #90340
Merged
layomia merged 5 commits into
dotnet:mainfrom 
layomia:binder-gen-interceptors
Aug 19, 2023
Merged
Use Roslyn interceptors feature in binder gen#90340
layomia merged 5 commits into
dotnet:mainfrom 
layomia:binder-gen-interceptors
Conversation
@layomia
@layomialayomia
commented
Aug 10, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#89322.
@layomialayomia
added this to the 8.0.0 milestone
Aug 10, 2023
@layomialayomia
self-assigned this
Aug 10, 2023
@ghost
ghost
commented
Aug 10, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-extensions-configuration

See info in area-owners.md if you want to be subscribed.
Issue Details
Fixes #89322.
Work left
Author:layomia
Assignees:layomia
Labels:
area-Extensions-Configuration
Milestone:8.0.0
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
d1d8513 to
1327ed9CompareAugust 10, 2023 21:34
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 11, 2023

Closed

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
2 times, most recently
from
7e0ce7c to
4c4022cCompareAugust 15, 2023 22:06

This was referenced Aug 16, 2023

Closed


Closed


Closed

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
2 times, most recently
from
88cb774 to
d205853CompareAugust 17, 2023 15:41
layomia
layomia
commented
Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/gen/Model/SourceGenerationSpec.cs
Outdated

layomia
layomia
commented
Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingGenerator.cs
Outdated

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
d205853 to
f5d0e0eCompareAugust 17, 2023 16:29
@layomia
layomia
marked this pull request as ready for review
August 17, 2023 16:30
@layomia
layomia
requested review from
captainsafia, eerhardt, eiriktsarpalis and tarekgh
and removed request for
jeffhandleyAugust 17, 2023 16:30
@ericstj
ericstj
commented
Aug 17, 2023

Copy link


Copy Markdown

Member
image
🎉 🎉 🎉 Reviewers - let's have a look at this and try to get feedback in and addressed ASAP to make it for RC1.
ericstj
ericstj
reviewed
Aug 17, 2023
View reviewed changes
Comment thread...aries/Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingGenerator.Emitter.cs
Outdated

@ericstjericstjAug 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we want to add something like https://github.com/dotnet/sdk/blob/4249701de6f005c670c7f371141e772d02f89156/src/WebSdk/ProjectSystem/Targets/Microsoft.NET.Sdk.Web.ProjectSystem.targets#L64 to our NuGet package targets, or will we ask users to set this? @eerhardt@tarekgh@captainsafia
@tarekghtarekghAug 17, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we decided to mimic whatever the aspnet is doing in the web project.
@ericstjericstjAug 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASP.NET doesn't ship a nuget package so we're special here. There's an ongoing discussion around this to decide what we want to do.
eiriktsarpalis
eiriktsarpalis
reviewed
Aug 17, 2023
View reviewed changes
Comment threaddocs/project/list-of-diagnostics.md
Outdated

eiriktsarpalis
eiriktsarpalis
reviewed
Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/SourceGenerators/GeneratorHelpers.cs
Outdated

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
4 times, most recently
from
80df566 to
743f89aCompareAugust 18, 2023 19:34
@layomialayomia
closed this
Aug 18, 2023
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
743f89a to
f3fe768CompareAugust 18, 2023 20:02
@layomialayomia
reopened this
Aug 18, 2023
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
2 times, most recently
from
4303ea5 to
d8aa6d9CompareAugust 18, 2023 21:01
@layomialayomia
mentioned this pull request
Aug 18, 2023

Closed

@layomia
layomia
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
Closing notes
Name clashes
Not needed for this feature to work & there's no new risk added here. I'll address in #86363. I've reverted the changes to the options generator and left out unique name generation in this generator.
Testing
There's always room to improve coverage, but I believe these suffice for merging this PR.
  • Interceptors handling multiple calls, including across different files.

    • Emitted source for the binder test project shows this is well covered.
  • Diagnostic suppressions where applicable

    • numerous binding calls in extensions assemblies which are linker trimmed show that this handled correctly
  • Not suppressing diagnostics for calls we didn't intercept:

    • tested with simple console application
  • Polymorphic type handling: Microsoft.Extensions.Logging.Console assembly exercises/validates the updated logic.
@layomia
layomia
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0-rc1
@github-actions
github-actionsBot
commented
Aug 18, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5907490321
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2023
 Merged

@layomia
layomia
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
Test failures seem to be caused by applying the code analysis version update across all projects. Will fix.
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
b267af5 to
5210070CompareAugust 18, 2023 23:42
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
5210070 to
d9504fdCompareAugust 18, 2023 23:58
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
d9504fd to
6fff866CompareAugust 19, 2023 00:28
@layomia
layomia
merged commit a5ff66c
into
dotnet:mainAug 19, 2023
@jaredparjaredpar
mentioned this pull request
Aug 21, 2023
 Merged


This was referenced Aug 22, 2023
 Merged

 Merged

@MichaelSimonsMichaelSimons
mentioned this pull request
Aug 24, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 18, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tmattmattmat left review comments
@stephentoubstephentoubstephentoub left review comments
@eiriktsarpaliseiriktsarpaliseiriktsarpalis approved these changes
@RikkiGibsonRikkiGibsonRikkiGibson left review comments
@eerhardteerhardteerhardt left review comments
@ericstjericstjericstj left review comments
@tarekghtarekghtarekgh approved these changes
@captainsafiacaptainsafiaAwaiting requested review from captainsafia

Assignees

@layomialayomia

Labels

area-Extensions-Configuration

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Use Roslyn interceptors feature in config binder generator


9 participants

@layomia@ericstj@tmat@captainsafia@stephentoub@eiriktsarpalis@RikkiGibson@eerhardt@tarekgh

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Use Roslyn interceptors feature in binder gen by layomia · Pull Request #90340 · dotnet/runtime · GitHub
Skip to content
Use Roslyn interceptors feature in binder gen - #90340
Merged
layomia merged 5 commits into
dotnet:mainfrom 
layomia:binder-gen-interceptors
Aug 19, 2023
Merged
Use Roslyn interceptors feature in binder gen#90340
layomia merged 5 commits into
dotnet:mainfrom 
layomia:binder-gen-interceptors
Conversation
@layomia
@layomialayomia
commented
Aug 10, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#89322.
@layomialayomia
added this to the 8.0.0 milestone
Aug 10, 2023
@layomialayomia
self-assigned this
Aug 10, 2023
@ghost
ghost
commented
Aug 10, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-extensions-configuration

See info in area-owners.md if you want to be subscribed.
Issue Details
Fixes #89322.
Work left
Author:layomia
Assignees:layomia
Labels:
area-Extensions-Configuration
Milestone:8.0.0
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
d1d8513 to
1327ed9CompareAugust 10, 2023 21:34
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 11, 2023

Closed

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
2 times, most recently
from
7e0ce7c to
4c4022cCompareAugust 15, 2023 22:06

This was referenced Aug 16, 2023

Closed


Closed


Closed

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
2 times, most recently
from
88cb774 to
d205853CompareAugust 17, 2023 15:41
layomia
layomia
commented
Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/gen/Model/SourceGenerationSpec.cs
Outdated

layomia
layomia
commented
Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingGenerator.cs
Outdated

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
d205853 to
f5d0e0eCompareAugust 17, 2023 16:29
@layomia
layomia
marked this pull request as ready for review
August 17, 2023 16:30
@layomia
layomia
requested review from
captainsafia, eerhardt, eiriktsarpalis and tarekgh
and removed request for
jeffhandleyAugust 17, 2023 16:30
@ericstj
ericstj
commented
Aug 17, 2023

Copy link


Copy Markdown

Member
image
🎉 🎉 🎉 Reviewers - let's have a look at this and try to get feedback in and addressed ASAP to make it for RC1.
ericstj
ericstj
reviewed
Aug 17, 2023
View reviewed changes
Comment thread...aries/Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingGenerator.Emitter.cs
Outdated

@ericstjericstjAug 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we want to add something like https://github.com/dotnet/sdk/blob/4249701de6f005c670c7f371141e772d02f89156/src/WebSdk/ProjectSystem/Targets/Microsoft.NET.Sdk.Web.ProjectSystem.targets#L64 to our NuGet package targets, or will we ask users to set this? @eerhardt@tarekgh@captainsafia
@tarekghtarekghAug 17, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we decided to mimic whatever the aspnet is doing in the web project.
@ericstjericstjAug 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASP.NET doesn't ship a nuget package so we're special here. There's an ongoing discussion around this to decide what we want to do.
eiriktsarpalis
eiriktsarpalis
reviewed
Aug 17, 2023
View reviewed changes
Comment threaddocs/project/list-of-diagnostics.md
Outdated

eiriktsarpalis
eiriktsarpalis
reviewed
Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/SourceGenerators/GeneratorHelpers.cs
Outdated

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
4 times, most recently
from
80df566 to
743f89aCompareAugust 18, 2023 19:34
@layomialayomia
closed this
Aug 18, 2023
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
743f89a to
f3fe768CompareAugust 18, 2023 20:02
@layomialayomia
reopened this
Aug 18, 2023
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
2 times, most recently
from
4303ea5 to
d8aa6d9CompareAugust 18, 2023 21:01
@layomialayomia
mentioned this pull request
Aug 18, 2023

Closed

@layomia
layomia
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
Closing notes
Name clashes
Not needed for this feature to work & there's no new risk added here. I'll address in #86363. I've reverted the changes to the options generator and left out unique name generation in this generator.
Testing
There's always room to improve coverage, but I believe these suffice for merging this PR.
  • Interceptors handling multiple calls, including across different files.

    • Emitted source for the binder test project shows this is well covered.
  • Diagnostic suppressions where applicable

    • numerous binding calls in extensions assemblies which are linker trimmed show that this handled correctly
  • Not suppressing diagnostics for calls we didn't intercept:

    • tested with simple console application
  • Polymorphic type handling: Microsoft.Extensions.Logging.Console assembly exercises/validates the updated logic.
@layomia
layomia
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0-rc1
@github-actions
github-actionsBot
commented
Aug 18, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5907490321
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2023
 Merged

@layomia
layomia
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
Test failures seem to be caused by applying the code analysis version update across all projects. Will fix.
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
b267af5 to
5210070CompareAugust 18, 2023 23:42
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
5210070 to
d9504fdCompareAugust 18, 2023 23:58
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
d9504fd to
6fff866CompareAugust 19, 2023 00:28
@layomia
layomia
merged commit a5ff66c
into
dotnet:mainAug 19, 2023
@jaredparjaredpar
mentioned this pull request
Aug 21, 2023
 Merged


This was referenced Aug 22, 2023
 Merged

 Merged

@MichaelSimonsMichaelSimons
mentioned this pull request
Aug 24, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 18, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tmattmattmat left review comments
@stephentoubstephentoubstephentoub left review comments
@eiriktsarpaliseiriktsarpaliseiriktsarpalis approved these changes
@RikkiGibsonRikkiGibsonRikkiGibson left review comments
@eerhardteerhardteerhardt left review comments
@ericstjericstjericstj left review comments
@tarekghtarekghtarekgh approved these changes
@captainsafiacaptainsafiaAwaiting requested review from captainsafia

Assignees

@layomialayomia

Labels

area-Extensions-Configuration

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Use Roslyn interceptors feature in config binder generator


9 participants

@layomia@ericstj@tmat@captainsafia@stephentoub@eiriktsarpalis@RikkiGibson@eerhardt@tarekgh

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Use Roslyn interceptors feature in binder gen by layomia · Pull Request #90340 · dotnet/runtime · GitHub
Skip to content
Use Roslyn interceptors feature in binder gen - #90340
Merged
layomia merged 5 commits into
dotnet:mainfrom 
layomia:binder-gen-interceptors
Aug 19, 2023
Merged
Use Roslyn interceptors feature in binder gen#90340
layomia merged 5 commits into
dotnet:mainfrom 
layomia:binder-gen-interceptors
Conversation
@layomia
@layomialayomia
commented
Aug 10, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#89322.
@layomialayomia
added this to the 8.0.0 milestone
Aug 10, 2023
@layomialayomia
self-assigned this
Aug 10, 2023
@ghost
ghost
commented
Aug 10, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-extensions-configuration

See info in area-owners.md if you want to be subscribed.
Issue Details
Fixes #89322.
Work left
Author:layomia
Assignees:layomia
Labels:
area-Extensions-Configuration
Milestone:8.0.0
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
d1d8513 to
1327ed9CompareAugust 10, 2023 21:34
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 11, 2023

Closed

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
2 times, most recently
from
7e0ce7c to
4c4022cCompareAugust 15, 2023 22:06

This was referenced Aug 16, 2023

Closed


Closed


Closed

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
2 times, most recently
from
88cb774 to
d205853CompareAugust 17, 2023 15:41
layomia
layomia
commented
Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/gen/Model/SourceGenerationSpec.cs
Outdated

layomia
layomia
commented
Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingGenerator.cs
Outdated

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
d205853 to
f5d0e0eCompareAugust 17, 2023 16:29
@layomia
layomia
marked this pull request as ready for review
August 17, 2023 16:30
@layomia
layomia
requested review from
captainsafia, eerhardt, eiriktsarpalis and tarekgh
and removed request for
jeffhandleyAugust 17, 2023 16:30
@ericstj
ericstj
commented
Aug 17, 2023

Copy link


Copy Markdown

Member
image
🎉 🎉 🎉 Reviewers - let's have a look at this and try to get feedback in and addressed ASAP to make it for RC1.
ericstj
ericstj
reviewed
Aug 17, 2023
View reviewed changes
Comment thread...aries/Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingGenerator.Emitter.cs
Outdated

@ericstjericstjAug 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we want to add something like https://github.com/dotnet/sdk/blob/4249701de6f005c670c7f371141e772d02f89156/src/WebSdk/ProjectSystem/Targets/Microsoft.NET.Sdk.Web.ProjectSystem.targets#L64 to our NuGet package targets, or will we ask users to set this? @eerhardt@tarekgh@captainsafia
@tarekghtarekghAug 17, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we decided to mimic whatever the aspnet is doing in the web project.
@ericstjericstjAug 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASP.NET doesn't ship a nuget package so we're special here. There's an ongoing discussion around this to decide what we want to do.
eiriktsarpalis
eiriktsarpalis
reviewed
Aug 17, 2023
View reviewed changes
Comment threaddocs/project/list-of-diagnostics.md
Outdated

eiriktsarpalis
eiriktsarpalis
reviewed
Aug 17, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/SourceGenerators/GeneratorHelpers.cs
Outdated

@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
4 times, most recently
from
80df566 to
743f89aCompareAugust 18, 2023 19:34
@layomialayomia
closed this
Aug 18, 2023
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
743f89a to
f3fe768CompareAugust 18, 2023 20:02
@layomialayomia
reopened this
Aug 18, 2023
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
2 times, most recently
from
4303ea5 to
d8aa6d9CompareAugust 18, 2023 21:01
@layomialayomia
mentioned this pull request
Aug 18, 2023

Closed

@layomia
layomia
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
Closing notes
Name clashes
Not needed for this feature to work & there's no new risk added here. I'll address in #86363. I've reverted the changes to the options generator and left out unique name generation in this generator.
Testing
There's always room to improve coverage, but I believe these suffice for merging this PR.
  • Interceptors handling multiple calls, including across different files.

    • Emitted source for the binder test project shows this is well covered.
  • Diagnostic suppressions where applicable

    • numerous binding calls in extensions assemblies which are linker trimmed show that this handled correctly
  • Not suppressing diagnostics for calls we didn't intercept:

    • tested with simple console application
  • Polymorphic type handling: Microsoft.Extensions.Logging.Console assembly exercises/validates the updated logic.
@layomia
layomia
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0-rc1
@github-actions
github-actionsBot
commented
Aug 18, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5907490321
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2023
 Merged

@layomia
layomia
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
Test failures seem to be caused by applying the code analysis version update across all projects. Will fix.
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
b267af5 to
5210070CompareAugust 18, 2023 23:42
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
5210070 to
d9504fdCompareAugust 18, 2023 23:58
@layomia
layomiaforce-pushed
the
binder-gen-interceptors
branch
from
d9504fd to
6fff866CompareAugust 19, 2023 00:28
@layomia
layomia
merged commit a5ff66c
into
dotnet:mainAug 19, 2023
@jaredparjaredpar
mentioned this pull request
Aug 21, 2023
 Merged


This was referenced Aug 22, 2023
 Merged

 Merged

@MichaelSimonsMichaelSimons
mentioned this pull request
Aug 24, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 18, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tmattmattmat left review comments
@stephentoubstephentoubstephentoub left review comments
@eiriktsarpaliseiriktsarpaliseiriktsarpalis approved these changes
@RikkiGibsonRikkiGibsonRikkiGibson left review comments
@eerhardteerhardteerhardt left review comments
@ericstjericstjericstj left review comments
@tarekghtarekghtarekgh approved these changes
@captainsafiacaptainsafiaAwaiting requested review from captainsafia

Assignees

@layomialayomia

Labels

area-Extensions-Configuration

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Use Roslyn interceptors feature in config binder generator


9 participants

@layomia@ericstj@tmat@captainsafia@stephentoub@eiriktsarpalis@RikkiGibson@eerhardt@tarekgh