[main] Update dependencies from 10 repositories - #90517

Merged
ViktorHofer merged 43 commits into
mainfrom
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
Aug 25, 2023
Merged

[main] Update dependencies from 10 repositories#90517
ViktorHofer merged 43 commits into
mainfrom
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented Aug 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20230821.1
  • Date Produced: August 21, 2023 9:46:31 AM UTC
  • Commit: 8b274d3
  • Branch: refs/heads/main

From https://github.com/dotnet/source-build-reference-packages

  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20230814.1
  • Date Produced: August 14, 2023 1:05:16 PM UTC
  • Commit: 45f5554ac6813e1e155c47fd80ec146c684f65e8
  • Branch: refs/heads/main

From https://github.com/dotnet/sdk

  • Subscription: 736b3d22-d45c-4c36-de26-08db63374d9b
  • Build: 20230824.6
  • Date Produced: August 24, 2023 10:41:18 AM UTC
  • Commit: 0a8f9006fa76ee546ca68362b38fe2c70ef7b7f9
  • Branch: refs/heads/main

From https://github.com/dotnet/emsdk

  • Subscription: c22d5069-447c-4252-29fd-08d90a7bb4bc
  • Build: 20230822.1
  • Date Produced: August 22, 2023 7:53:47 PM UTC
  • Commit: 028de23143a75e43951be6275278d4dbc8520258
  • Branch: refs/heads/main

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20230822.1
  • Date Produced: August 22, 2023 8:50:38 PM UTC
  • Commit: 4d9945d230fdd8324ce16a31c7dbd74e27a0fc9b
  • Branch: refs/heads/main

From https://github.com/dotnet/icu

  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20230821.1
  • Date Produced: August 21, 2023 2:30:01 PM UTC
  • Commit: cec51e5eba13df460746046a2aca07bcf6bb2f8e
  • Branch: refs/heads/dotnet/main

From https://github.com/dotnet/cecil

  • Subscription: bb5d2106-9fd3-425f-0abc-08daad65778c
  • Build: 20230821.1
  • Date Produced: August 21, 2023 1:12:18 PM UTC
  • Commit: d412306c1514a26737574838900052d8758da5be
  • Branch: refs/heads/main

From https://github.com/dotnet/xharness

  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20230821.1
  • Date Produced: August 21, 2023 12:57:41 PM UTC
  • Commit: 1c09ef5b669c11e1aeca92089d0c1e4408169582
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime-assets

  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20230823.1
  • Date Produced: August 23, 2023 9:28:54 AM UTC
  • Commit: b901ed157568022c7b531d65b2bd28333621a6df
  • Branch: refs/heads/main

From https://github.com/dotnet/hotreload-utils

  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20230821.1
  • Date Produced: August 22, 2023 1:49:27 AM UTC
  • Commit: e02247b9b7ec1d9e407312342147d8587a8ca20e
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2023…
2b860da
…0814.1
Microsoft.DotNet.ILCompiler , Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
From Version 8.0.0-rc.1.23406.6 -> To Version 8.0.0-rc.1.23414.1
@ghostghost added the area-codeflow for labeling automated codeflow label Aug 14, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/source-build-refer…
f55dffe
…ence-packages build 20230808.2
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23381.3 -> To Version 8.0.0-alpha.1.23408.2
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packagesAug 14, 2023
@lewinglewing added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Aug 14, 2023
@ghost

ghost commented Aug 14, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20230814.1
  • Date Produced: August 14, 2023 10:35:21 AM UTC
  • Commit: 8986374
  • Branch: refs/heads/main

From https://github.com/dotnet/source-build-reference-packages

  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20230808.2
  • Date Produced: August 8, 2023 7:05:41 PM UTC
  • Commit: 41f1a158d460e11ded6cffd6340f9e671e2b0a5c
  • Branch: refs/heads/main
Author:dotnet-maestro[bot]
Assignees:-
Labels:

area-codeflow, area-Tools-ILLink

Milestone:-

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230814.3
54f661f
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-rc.1.23414.3
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdkAug 14, 2023
@ViktorHofer

ViktorHofer commented Aug 14, 2023•
edited
Loading

Copy link
Copy Markdown
Member

@sbomer looks like the illink task invocation in illink.targets now complains about the SDK not being recent enough:

App: D:\a_work\1\s.packages\microsoft.net.illink.tasks\8.0.0-rc.1.23414.1\tools\net8.0\illink.dll
Framework: 'Microsoft.NETCore.App', version '8.0.0-rc.1.23414.1' (x64)

Probably because of c13739b

@sbomer

sbomer commented Aug 14, 2023

Copy link
Copy Markdown
Member

Looks like we're still using the latest ILLink package for the framework linking step. We can do one of:

  1. Use the SDK version here (unset UsingToolMicrosoftNetILLinkTasks)
  2. Use live illink (means we need to build ILLink before building the framework)
  3. Implement a workaround to use latest ILLink package with a custom runtimeconfig

I think 2. would be ideal, but might be better to do as a separate change. I suggest 1. as a short-term fix (I think this is fine for .NET 8 assuming we'll be using an RC version to build the final product). @vitek-karas@ViktorHofer@agocke any thoughts?

@agocke

agocke commented Aug 14, 2023

Copy link
Copy Markdown
Member

(1) sounds fine as a quick fix, and I agree (2) is ideal. I would even say, if we have time, I would consider taking (2) as an infra-only change for .NET 8. But unblocking dependency flow is even more important.

@sbomersbomer mentioned this pull request Aug 14, 2023
Closed
@sbomer
sbomerforce-pushed the darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c branch from 02dd28c to 8c0dbf1CompareAugust 14, 2023 23:41
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202308…
2de3e36
…14.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.1.23411.2 -> To Version 8.0.0-rc.1.23414.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdkAug 15, 2023
@build-analysisbuild-analysisBot mentioned this pull request Aug 15, 2023
Closed
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
2be781b
…814.5
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23411.1 -> To Version 8.0.0-beta.23414.5
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23408.1 -> To Version 1.0.0-beta.23412.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcadeAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/icubuild 20230814.4
b736874
Microsoft.NETCore.Runtime.ICU.Transport
From Version 8.0.0-rc.1.23407.2 -> To Version 9.0.0-alpha.1.23414.4
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icuAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/cecilbuild 202308…
67ff521
…14.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23407.2 -> To Version 0.11.4-alpha.23414.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecilAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230815.5
bd9bd3a
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-rc.1.23415.5
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecil[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecil dotnet/sdkAug 15, 2023
@build-analysisbuild-analysisBot mentioned this pull request Aug 15, 2023
Closed
@akoeplingerakoeplinger mentioned this pull request Aug 23, 2023
Closed
akoeplingerand others added 8 commits August 23, 2023 11:25
@akoeplinger
Remove unused parameter (dotnet/arcade#13961)
6c498c6
@akoeplinger
Try to fix NativeAOT helix correlation payload issue
726b12f
@akoeplinger
Revert a change
53d3799
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
734595b
…822.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23411.1 -> To Version 8.0.0-beta.23422.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23408.1 -> To Version 1.0.0-beta.23418.1 (parent: Microsoft.DotNet.Helix.Sdk
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
949836f
…ld 20230823.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23408.1 -> To Version 8.0.0-beta.23423.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202308…
e5e460b
…22.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
From Version 9.0.0-alpha.1.23415.2 -> To Version 9.0.0-alpha.1.23422.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230823.2
4c1900f
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 9.0.100-alpha.1.23423.2
@dotnet-maestro
Dependency coherency updates
2be61d1
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 16.0.5-alpha.1.23408.1 -> To Version 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
@akoeplinger

akoeplinger commented Aug 23, 2023

Copy link
Copy Markdown
Member

Looks like the only real failure left is from the source build leg:

.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.

@mmitche

mmitche commented Aug 23, 2023

Copy link
Copy Markdown
Member

Looks like the only real failure left is from the source build leg:

.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.

@MichaelSimons

@build-analysisbuild-analysisBot mentioned this pull request Aug 23, 2023
Closed
@MichaelSimons

MichaelSimons commented Aug 23, 2023

Copy link
Copy Markdown
Member

Looks like the only real failure left is from the source build leg:

.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.

@NikolaMilosavljevic - Can you help investigate/provide guidance? TIA

@NikolaMilosavljevic

NikolaMilosavljevic commented Aug 23, 2023

Copy link
Copy Markdown
Contributor

Looks like the only real failure left is from the source build leg:

.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.

@NikolaMilosavljevic - Can you help investigate/provide guidance? TIA

I've reproed this locally - investigating...

NikolaMilosavljevic
NikolaMilosavljevic reviewed Aug 23, 2023
View reviewed changes
Comment threadsrc/tools/illink/Directory.Build.props
Comment on lines -2 to -5
<PropertyGroup>
<!-- Don't use the prebuilt illink that is referenced by Arcade. -->
<UsingToolMicrosoftNetILLinkTasks>false</UsingToolMicrosoftNetILLinkTasks>
</PropertyGroup>

@NikolaMilosavljevicNikolaMilosavljevicAug 23, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the root cause of source-build failure. It is causing the usage of prebuilt version of Microsoft.Net.ILLink.Tasks package. Is this accidental? @akoeplinger @vikoeplinger

@sbomersbomerAug 24, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes intentionally use the version of ILLink.Tasks that is referenced by the SDK in global.json (BundledNETCoreAppPackageVersion in https://github.com/dotnet/runtime/pull/90517/files#diff-361b24a1b39d592c236441b48457113d003aeb3bc03df5bbc0318fd0b2e05cd2R50-R53).

This packagereference is effectively equivalent to building with the SDK, with <UsingToolMicrosoftNetILLinkTasks>false</UsingToolMicrosoftNetILLinkTasks>. The packagereference was required as a workaround (see these comments), but I'd expect that for the purpose of source-build it is no different.

@MichaelSimonsMichaelSimonsAug 24, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.

@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.

I'll validate full product build locally.

@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.

I'll validate full product build locally.

Full source-build is showing 20 prebuilts but not the one for Microsoft.Net.ILLink.Tasks. I'm unsure about this - @MichaelSimons

Here's the full list of prebuilts:

 <Usage Id="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.Common" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.CSharp" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.Extensions.DependencyInjection" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.Logging" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.Extensions.Options" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.Primitives" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.Current.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.net6.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.net7.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="System.Composition" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.AttributedModel" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Convention" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Hosting" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Runtime" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.TypedParts" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />

@MichaelSimonsMichaelSimonsAug 24, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one direct dependency coming from runtime

<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />

This is a result of #90340 which was addressed in #91006. I suspect the commit tested didn't have the fix. I think the test has proven this will not introduce a prebuilt in the product level source-build.

@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one direct dependency coming from runtime

<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />

This is a result of #90340 which was addressed in #91006. I suspect the commit tested didn't have the fix. I think the test has proven this will not introduce a prebuilt in the product level source-build.

Thanks - I'll work on a fix to add exclusion for ILLink.Tasks.

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230824.6
e7fd0ef
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 9.0.100-alpha.1.23424.6
@NikolaMilosavljevic

NikolaMilosavljevic commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

I've pulled the latest changes and now I'm seeing two prebuilts:

Microsoft.DotNet.ApiCompat.Task.9.0.100-alpha.1.23423.2
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

@MichaelSimons

MichaelSimons commented Aug 24, 2023

Copy link
Copy Markdown
Member

Microsoft.DotNet.ApiCompat.Task.9.0.100-alpha.1.23423.2

Something odd about this one because the version.details.xml is referencing a newer version - 9.0.100-alpha.1.23424.6

@NikolaMilosavljevic

NikolaMilosavljevic commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

Microsoft.DotNet.ApiCompat.Task

Doing another build - this might have been an issue with stale cache.

@NikolaMilosavljevic

NikolaMilosavljevic commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

Microsoft.DotNet.ApiCompat.Task

Doing another build - this might have been an issue with stale cache.

I plan to try this for ILLink.Tasks:

 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/$(BundledNETCoreAppPackageVersion)" />

@NikolaMilosavljevic

NikolaMilosavljevic commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

Microsoft.DotNet.ApiCompat.Task

Doing another build - this might have been an issue with stale cache.

I plan to try this for ILLink.Tasks:

 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/$(BundledNETCoreAppPackageVersion)" />

OK - that didn't work - how about?

 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/*8.*" />

@MichaelSimons

MichaelSimons commented Aug 24, 2023

Copy link
Copy Markdown
Member

Your only option is wild cards - you can't reference msbuild props. I think 8.* is acceptable.

@NikolaMilosavljevic

NikolaMilosavljevic commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

Pushed the fix for source-build leg.

@build-analysisbuild-analysisBot mentioned this pull request Aug 25, 2023
Closed
@ViktorHofer
ViktorHofer merged commit 699ffbe into mainAug 25, 2023
@ViktorHofer
ViktorHofer deleted the darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c branch August 25, 2023 08:22
@sbomersbomer mentioned this pull request Aug 30, 2023
Merged
@ghostghost locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sbomersbomersbomer left review comments
@MichaelSimonsMichaelSimonsMichaelSimons left review comments
@lewinglewinglewing approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar
@carlossanlopcarlossanlopAwaiting requested review from carlossanlop
@radicalradicalAwaiting requested review from radical
+1 more reviewer
@NikolaMilosavljevicNikolaMilosavljevicNikolaMilosavljevic left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

arch-arm64area-codeflowfor labeling automated codeflowarea-Tools-ILLink.NET linker development as well as trimming analyzers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@ViktorHofer@sbomer@agocke@vitek-karas@lewing@akoeplinger@mmitche@MichaelSimons@NikolaMilosavljevic@radical
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[main] Update dependencies from 10 repositories - #90517
Merged
ViktorHofer merged 43 commits into
mainfrom 
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
Aug 25, 2023
Merged
[main] Update dependencies from 10 repositories#90517
ViktorHofer merged 43 commits into
mainfrom 
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Aug 14, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20230821.1
  • Date Produced: August 21, 2023 9:46:31 AM UTC
  • Commit: 8b274d3
  • Branch: refs/heads/main
From https://github.com/dotnet/source-build-reference-packages
  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20230814.1
  • Date Produced: August 14, 2023 1:05:16 PM UTC
  • Commit: 45f5554ac6813e1e155c47fd80ec146c684f65e8
  • Branch: refs/heads/main
From https://github.com/dotnet/sdk
  • Subscription: 736b3d22-d45c-4c36-de26-08db63374d9b
  • Build: 20230824.6
  • Date Produced: August 24, 2023 10:41:18 AM UTC
  • Commit: 0a8f9006fa76ee546ca68362b38fe2c70ef7b7f9
  • Branch: refs/heads/main
From https://github.com/dotnet/emsdk
  • Subscription: c22d5069-447c-4252-29fd-08d90a7bb4bc
  • Build: 20230822.1
  • Date Produced: August 22, 2023 7:53:47 PM UTC
  • Commit: 028de23143a75e43951be6275278d4dbc8520258
  • Branch: refs/heads/main
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency

attribute were produced in a build used as input to the parent dependency's build.

See Dependency Description Format
  • Coherency Updates:

    • runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
From https://github.com/dotnet/arcade
  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20230822.1
  • Date Produced: August 22, 2023 8:50:38 PM UTC
  • Commit: 4d9945d230fdd8324ce16a31c7dbd74e27a0fc9b
  • Branch: refs/heads/main
From https://github.com/dotnet/icu
  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20230821.1
  • Date Produced: August 21, 2023 2:30:01 PM UTC
  • Commit: cec51e5eba13df460746046a2aca07bcf6bb2f8e
  • Branch: refs/heads/dotnet/main
From https://github.com/dotnet/cecil
  • Subscription: bb5d2106-9fd3-425f-0abc-08daad65778c
  • Build: 20230821.1
  • Date Produced: August 21, 2023 1:12:18 PM UTC
  • Commit: d412306c1514a26737574838900052d8758da5be
  • Branch: refs/heads/main
From https://github.com/dotnet/xharness
  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20230821.1
  • Date Produced: August 21, 2023 12:57:41 PM UTC
  • Commit: 1c09ef5b669c11e1aeca92089d0c1e4408169582
  • Branch: refs/heads/main
From https://github.com/dotnet/runtime-assets
  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20230823.1
  • Date Produced: August 23, 2023 9:28:54 AM UTC
  • Commit: b901ed157568022c7b531d65b2bd28333621a6df
  • Branch: refs/heads/main
From https://github.com/dotnet/hotreload-utils
  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20230821.1
  • Date Produced: August 22, 2023 1:49:27 AM UTC
  • Commit: e02247b9b7ec1d9e407312342147d8587a8ca20e
  • Branch: refs/heads/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2023…
2b860da
…0814.1
Microsoft.DotNet.ILCompiler , Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
From Version 8.0.0-rc.1.23406.6 -> To Version 8.0.0-rc.1.23414.1
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
Aug 14, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/source-build-refer…
f55dffe
…ence-packages build 20230808.2
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23381.3 -> To Version 8.0.0-alpha.1.23408.2
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packagesAug 14, 2023
@lewinglewing
added
the 
area-Tools-ILLink
.NET linker development as well as trimming analyzers
label
Aug 14, 2023
@ghost
ghost
commented
Aug 14, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas

See info in area-owners.md if you want to be subscribed.
Issue Details
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20230814.1
  • Date Produced: August 14, 2023 10:35:21 AM UTC
  • Commit: 8986374
  • Branch: refs/heads/main
From https://github.com/dotnet/source-build-reference-packages
  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20230808.2
  • Date Produced: August 8, 2023 7:05:41 PM UTC
  • Commit: 41f1a158d460e11ded6cffd6340f9e671e2b0a5c
  • Branch: refs/heads/main
Author:dotnet-maestro[bot]
Assignees:-
Labels:
area-codeflow, area-Tools-ILLink
Milestone:-
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230814.3
54f661f
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-rc.1.23414.3
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdkAug 14, 2023
@ViktorHofer
ViktorHofer
commented
Aug 14, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@sbomer looks like the illink task invocation in illink.targets now complains about the SDK not being recent enough:
App: D:\a_work\1\s.packages\microsoft.net.illink.tasks\8.0.0-rc.1.23414.1\tools\net8.0\illink.dll

Framework: 'Microsoft.NETCore.App', version '8.0.0-rc.1.23414.1' (x64)
Probably because of c13739b
@sbomer
sbomer
commented
Aug 14, 2023

Copy link


Copy Markdown

Member
Looks like we're still using the latest ILLink package for the framework linking step. We can do one of:
  1. Use the SDK version here (unset UsingToolMicrosoftNetILLinkTasks)
  2. Use live illink (means we need to build ILLink before building the framework)
  3. Implement a workaround to use latest ILLink package with a custom runtimeconfig
I think 2. would be ideal, but might be better to do as a separate change. I suggest 1. as a short-term fix (I think this is fine for .NET 8 assuming we'll be using an RC version to build the final product). @vitek-karas@ViktorHofer@agocke any thoughts?
@agocke
agocke
commented
Aug 14, 2023

Copy link


Copy Markdown

Member
(1) sounds fine as a quick fix, and I agree (2) is ideal. I would even say, if we have time, I would consider taking (2) as an infra-only change for .NET 8. But unblocking dependency flow is even more important.
@sbomersbomer
mentioned this pull request
Aug 14, 2023

Closed

@sbomer
sbomerforce-pushed
the
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
branch
from
02dd28c to
8c0dbf1CompareAugust 14, 2023 23:41
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202308…
2de3e36
…14.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.1.23411.2 -> To Version 8.0.0-rc.1.23414.1
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdkAug 15, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 15, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
2be781b
…814.5
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23411.1 -> To Version 8.0.0-beta.23414.5
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23408.1 -> To Version 1.0.0-beta.23412.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcadeAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/icubuild 20230814.4
b736874
Microsoft.NETCore.Runtime.ICU.Transport
From Version 8.0.0-rc.1.23407.2 -> To Version 9.0.0-alpha.1.23414.4
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icuAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/cecilbuild 202308…
67ff521
…14.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23407.2 -> To Version 0.11.4-alpha.23414.1
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecilAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230815.5
bd9bd3a
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-rc.1.23415.5
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecil[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecil dotnet/sdkAug 15, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 15, 2023

Closed

@akoeplingerakoeplinger
mentioned this pull request
Aug 23, 2023
 Closed

akoeplingerand others
added 8 commits
August 23, 2023 11:25
@akoeplinger
Remove unused parameter (dotnet/arcade#13961)
6c498c6
@akoeplinger
Try to fix NativeAOT helix correlation payload issue
726b12f
@akoeplinger
Revert a change
53d3799
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
734595b
…822.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23411.1 -> To Version 8.0.0-beta.23422.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23408.1 -> To Version 1.0.0-beta.23418.1 (parent: Microsoft.DotNet.Helix.Sdk
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
949836f
…ld 20230823.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23408.1 -> To Version 8.0.0-beta.23423.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202308…
e5e460b
…22.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
From Version 9.0.0-alpha.1.23415.2 -> To Version 9.0.0-alpha.1.23422.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230823.2
4c1900f
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 9.0.100-alpha.1.23423.2
@dotnet-maestro
Dependency coherency updates
2be61d1
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 16.0.5-alpha.1.23408.1 -> To Version 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
@akoeplinger
akoeplinger
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@mmitche
mmitche
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@MichaelSimons
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 23, 2023

Closed

@MichaelSimons
MichaelSimons
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@NikolaMilosavljevic - Can you help investigate/provide guidance? TIA
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 23, 2023

Copy link


Copy Markdown

Contributor
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@NikolaMilosavljevic - Can you help investigate/provide guidance? TIA
I've reproed this locally - investigating...
NikolaMilosavljevic
NikolaMilosavljevic
reviewed
Aug 23, 2023
View reviewed changes
Comment threadsrc/tools/illink/Directory.Build.props

Comment on lines

-2
 to 
-5

 <PropertyGroup>
 <!-- Don't use the prebuilt illink that is referenced by Arcade. -->
 <UsingToolMicrosoftNetILLinkTasks>false</UsingToolMicrosoftNetILLinkTasks>
 </PropertyGroup>
@NikolaMilosavljevicNikolaMilosavljevicAug 23, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the root cause of source-build failure. It is causing the usage of prebuilt version of Microsoft.Net.ILLink.Tasks package. Is this accidental? @akoeplinger @vikoeplinger
@sbomersbomerAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes intentionally use the version of ILLink.Tasks that is referenced by the SDK in global.json (BundledNETCoreAppPackageVersion in https://github.com/dotnet/runtime/pull/90517/files#diff-361b24a1b39d592c236441b48457113d003aeb3bc03df5bbc0318fd0b2e05cd2R50-R53).
This packagereference is effectively equivalent to building with the SDK, with <UsingToolMicrosoftNetILLinkTasks>false</UsingToolMicrosoftNetILLinkTasks>. The packagereference was required as a workaround (see these comments), but I'd expect that for the purpose of source-build it is no different.
@MichaelSimonsMichaelSimonsAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
I'll validate full product build locally.
@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
I'll validate full product build locally.
Full source-build is showing 20 prebuilts but not the one for Microsoft.Net.ILLink.Tasks. I'm unsure about this - @MichaelSimons
Here's the full list of prebuilts:
 <Usage Id="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.Common" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.CSharp" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.Extensions.DependencyInjection" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.Logging" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.Extensions.Options" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.Primitives" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.Current.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.net6.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.net7.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="System.Composition" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.AttributedModel" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Convention" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Hosting" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Runtime" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.TypedParts" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />

@MichaelSimonsMichaelSimonsAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one direct dependency coming from runtime
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />

This is a result of #90340 which was addressed in #91006. I suspect the commit tested didn't have the fix. I think the test has proven this will not introduce a prebuilt in the product level source-build.
@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one direct dependency coming from runtime
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />

This is a result of #90340 which was addressed in #91006. I suspect the commit tested didn't have the fix. I think the test has proven this will not introduce a prebuilt in the product level source-build.
Thanks - I'll work on a fix to add exclusion for ILLink.Tasks.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230824.6
e7fd0ef
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 9.0.100-alpha.1.23424.6
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
I've pulled the latest changes and now I'm seeing two prebuilts:
Microsoft.DotNet.ApiCompat.Task.9.0.100-alpha.1.23423.2
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

@MichaelSimons
MichaelSimons
commented
Aug 24, 2023

Copy link


Copy Markdown

Member
Microsoft.DotNet.ApiCompat.Task.9.0.100-alpha.1.23423.2
Something odd about this one because the version.details.xml is referencing a newer version - 9.0.100-alpha.1.23424.6
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Microsoft.DotNet.ApiCompat.Task
Doing another build - this might have been an issue with stale cache.
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Microsoft.DotNet.ApiCompat.Task
Doing another build - this might have been an issue with stale cache.
I plan to try this for ILLink.Tasks:
 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/$(BundledNETCoreAppPackageVersion)" />

@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Microsoft.DotNet.ApiCompat.Task
Doing another build - this might have been an issue with stale cache.
I plan to try this for ILLink.Tasks:
 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/$(BundledNETCoreAppPackageVersion)" />

OK - that didn't work - how about?
 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/*8.*" />

@MichaelSimons
MichaelSimons
commented
Aug 24, 2023

Copy link


Copy Markdown

Member
Your only option is wild cards - you can't reference msbuild props. I think 8.* is acceptable.
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Pushed the fix for source-build leg.
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 25, 2023

Closed

@ViktorHofer
ViktorHofer
merged commit 699ffbe
into
mainAug 25, 2023
@ViktorHofer
ViktorHofer
deleted the

darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c

branch
August 25, 2023 08:22
@sbomersbomer
mentioned this pull request
Aug 30, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 24, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@sbomersbomersbomer left review comments
@MichaelSimonsMichaelSimonsMichaelSimons left review comments
@lewinglewinglewing approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar
@carlossanlopcarlossanlopAwaiting requested review from carlossanlop
@radicalradicalAwaiting requested review from radical

+1 more reviewer

@NikolaMilosavljevicNikolaMilosavljevicNikolaMilosavljevic left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

arch-arm64area-codeflowfor labeling automated codeflowarea-Tools-ILLink.NET linker development as well as trimming analyzers

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

10 participants

@ViktorHofer@sbomer@agocke@vitek-karas@lewing@akoeplinger@mmitche@MichaelSimons@NikolaMilosavljevic@radical

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[main] Update dependencies from 10 repositories - #90517
Merged
ViktorHofer merged 43 commits into
mainfrom 
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
Aug 25, 2023
Merged
[main] Update dependencies from 10 repositories#90517
ViktorHofer merged 43 commits into
mainfrom 
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Aug 14, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20230821.1
  • Date Produced: August 21, 2023 9:46:31 AM UTC
  • Commit: 8b274d3
  • Branch: refs/heads/main
From https://github.com/dotnet/source-build-reference-packages
  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20230814.1
  • Date Produced: August 14, 2023 1:05:16 PM UTC
  • Commit: 45f5554ac6813e1e155c47fd80ec146c684f65e8
  • Branch: refs/heads/main
From https://github.com/dotnet/sdk
  • Subscription: 736b3d22-d45c-4c36-de26-08db63374d9b
  • Build: 20230824.6
  • Date Produced: August 24, 2023 10:41:18 AM UTC
  • Commit: 0a8f9006fa76ee546ca68362b38fe2c70ef7b7f9
  • Branch: refs/heads/main
From https://github.com/dotnet/emsdk
  • Subscription: c22d5069-447c-4252-29fd-08d90a7bb4bc
  • Build: 20230822.1
  • Date Produced: August 22, 2023 7:53:47 PM UTC
  • Commit: 028de23143a75e43951be6275278d4dbc8520258
  • Branch: refs/heads/main
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency

attribute were produced in a build used as input to the parent dependency's build.

See Dependency Description Format
  • Coherency Updates:

    • runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
From https://github.com/dotnet/arcade
  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20230822.1
  • Date Produced: August 22, 2023 8:50:38 PM UTC
  • Commit: 4d9945d230fdd8324ce16a31c7dbd74e27a0fc9b
  • Branch: refs/heads/main
From https://github.com/dotnet/icu
  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20230821.1
  • Date Produced: August 21, 2023 2:30:01 PM UTC
  • Commit: cec51e5eba13df460746046a2aca07bcf6bb2f8e
  • Branch: refs/heads/dotnet/main
From https://github.com/dotnet/cecil
  • Subscription: bb5d2106-9fd3-425f-0abc-08daad65778c
  • Build: 20230821.1
  • Date Produced: August 21, 2023 1:12:18 PM UTC
  • Commit: d412306c1514a26737574838900052d8758da5be
  • Branch: refs/heads/main
From https://github.com/dotnet/xharness
  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20230821.1
  • Date Produced: August 21, 2023 12:57:41 PM UTC
  • Commit: 1c09ef5b669c11e1aeca92089d0c1e4408169582
  • Branch: refs/heads/main
From https://github.com/dotnet/runtime-assets
  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20230823.1
  • Date Produced: August 23, 2023 9:28:54 AM UTC
  • Commit: b901ed157568022c7b531d65b2bd28333621a6df
  • Branch: refs/heads/main
From https://github.com/dotnet/hotreload-utils
  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20230821.1
  • Date Produced: August 22, 2023 1:49:27 AM UTC
  • Commit: e02247b9b7ec1d9e407312342147d8587a8ca20e
  • Branch: refs/heads/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2023…
2b860da
…0814.1
Microsoft.DotNet.ILCompiler , Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
From Version 8.0.0-rc.1.23406.6 -> To Version 8.0.0-rc.1.23414.1
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
Aug 14, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/source-build-refer…
f55dffe
…ence-packages build 20230808.2
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23381.3 -> To Version 8.0.0-alpha.1.23408.2
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packagesAug 14, 2023
@lewinglewing
added
the 
area-Tools-ILLink
.NET linker development as well as trimming analyzers
label
Aug 14, 2023
@ghost
ghost
commented
Aug 14, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas

See info in area-owners.md if you want to be subscribed.
Issue Details
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20230814.1
  • Date Produced: August 14, 2023 10:35:21 AM UTC
  • Commit: 8986374
  • Branch: refs/heads/main
From https://github.com/dotnet/source-build-reference-packages
  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20230808.2
  • Date Produced: August 8, 2023 7:05:41 PM UTC
  • Commit: 41f1a158d460e11ded6cffd6340f9e671e2b0a5c
  • Branch: refs/heads/main
Author:dotnet-maestro[bot]
Assignees:-
Labels:
area-codeflow, area-Tools-ILLink
Milestone:-
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230814.3
54f661f
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-rc.1.23414.3
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdkAug 14, 2023
@ViktorHofer
ViktorHofer
commented
Aug 14, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@sbomer looks like the illink task invocation in illink.targets now complains about the SDK not being recent enough:
App: D:\a_work\1\s.packages\microsoft.net.illink.tasks\8.0.0-rc.1.23414.1\tools\net8.0\illink.dll

Framework: 'Microsoft.NETCore.App', version '8.0.0-rc.1.23414.1' (x64)
Probably because of c13739b
@sbomer
sbomer
commented
Aug 14, 2023

Copy link


Copy Markdown

Member
Looks like we're still using the latest ILLink package for the framework linking step. We can do one of:
  1. Use the SDK version here (unset UsingToolMicrosoftNetILLinkTasks)
  2. Use live illink (means we need to build ILLink before building the framework)
  3. Implement a workaround to use latest ILLink package with a custom runtimeconfig
I think 2. would be ideal, but might be better to do as a separate change. I suggest 1. as a short-term fix (I think this is fine for .NET 8 assuming we'll be using an RC version to build the final product). @vitek-karas@ViktorHofer@agocke any thoughts?
@agocke
agocke
commented
Aug 14, 2023

Copy link


Copy Markdown

Member
(1) sounds fine as a quick fix, and I agree (2) is ideal. I would even say, if we have time, I would consider taking (2) as an infra-only change for .NET 8. But unblocking dependency flow is even more important.
@sbomersbomer
mentioned this pull request
Aug 14, 2023

Closed

@sbomer
sbomerforce-pushed
the
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
branch
from
02dd28c to
8c0dbf1CompareAugust 14, 2023 23:41
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202308…
2de3e36
…14.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.1.23411.2 -> To Version 8.0.0-rc.1.23414.1
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdkAug 15, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 15, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
2be781b
…814.5
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23411.1 -> To Version 8.0.0-beta.23414.5
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23408.1 -> To Version 1.0.0-beta.23412.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcadeAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/icubuild 20230814.4
b736874
Microsoft.NETCore.Runtime.ICU.Transport
From Version 8.0.0-rc.1.23407.2 -> To Version 9.0.0-alpha.1.23414.4
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icuAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/cecilbuild 202308…
67ff521
…14.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23407.2 -> To Version 0.11.4-alpha.23414.1
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecilAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230815.5
bd9bd3a
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-rc.1.23415.5
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecil[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecil dotnet/sdkAug 15, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 15, 2023

Closed

@akoeplingerakoeplinger
mentioned this pull request
Aug 23, 2023
 Closed

akoeplingerand others
added 8 commits
August 23, 2023 11:25
@akoeplinger
Remove unused parameter (dotnet/arcade#13961)
6c498c6
@akoeplinger
Try to fix NativeAOT helix correlation payload issue
726b12f
@akoeplinger
Revert a change
53d3799
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
734595b
…822.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23411.1 -> To Version 8.0.0-beta.23422.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23408.1 -> To Version 1.0.0-beta.23418.1 (parent: Microsoft.DotNet.Helix.Sdk
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
949836f
…ld 20230823.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23408.1 -> To Version 8.0.0-beta.23423.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202308…
e5e460b
…22.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
From Version 9.0.0-alpha.1.23415.2 -> To Version 9.0.0-alpha.1.23422.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230823.2
4c1900f
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 9.0.100-alpha.1.23423.2
@dotnet-maestro
Dependency coherency updates
2be61d1
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 16.0.5-alpha.1.23408.1 -> To Version 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
@akoeplinger
akoeplinger
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@mmitche
mmitche
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@MichaelSimons
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 23, 2023

Closed

@MichaelSimons
MichaelSimons
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@NikolaMilosavljevic - Can you help investigate/provide guidance? TIA
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 23, 2023

Copy link


Copy Markdown

Contributor
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@NikolaMilosavljevic - Can you help investigate/provide guidance? TIA
I've reproed this locally - investigating...
NikolaMilosavljevic
NikolaMilosavljevic
reviewed
Aug 23, 2023
View reviewed changes
Comment threadsrc/tools/illink/Directory.Build.props

Comment on lines

-2
 to 
-5

 <PropertyGroup>
 <!-- Don't use the prebuilt illink that is referenced by Arcade. -->
 <UsingToolMicrosoftNetILLinkTasks>false</UsingToolMicrosoftNetILLinkTasks>
 </PropertyGroup>
@NikolaMilosavljevicNikolaMilosavljevicAug 23, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the root cause of source-build failure. It is causing the usage of prebuilt version of Microsoft.Net.ILLink.Tasks package. Is this accidental? @akoeplinger @vikoeplinger
@sbomersbomerAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes intentionally use the version of ILLink.Tasks that is referenced by the SDK in global.json (BundledNETCoreAppPackageVersion in https://github.com/dotnet/runtime/pull/90517/files#diff-361b24a1b39d592c236441b48457113d003aeb3bc03df5bbc0318fd0b2e05cd2R50-R53).
This packagereference is effectively equivalent to building with the SDK, with <UsingToolMicrosoftNetILLinkTasks>false</UsingToolMicrosoftNetILLinkTasks>. The packagereference was required as a workaround (see these comments), but I'd expect that for the purpose of source-build it is no different.
@MichaelSimonsMichaelSimonsAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
I'll validate full product build locally.
@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
I'll validate full product build locally.
Full source-build is showing 20 prebuilts but not the one for Microsoft.Net.ILLink.Tasks. I'm unsure about this - @MichaelSimons
Here's the full list of prebuilts:
 <Usage Id="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.Common" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.CSharp" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.Extensions.DependencyInjection" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.Logging" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.Extensions.Options" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.Primitives" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.Current.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.net6.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.net7.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="System.Composition" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.AttributedModel" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Convention" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Hosting" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Runtime" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.TypedParts" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />

@MichaelSimonsMichaelSimonsAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one direct dependency coming from runtime
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />

This is a result of #90340 which was addressed in #91006. I suspect the commit tested didn't have the fix. I think the test has proven this will not introduce a prebuilt in the product level source-build.
@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one direct dependency coming from runtime
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />

This is a result of #90340 which was addressed in #91006. I suspect the commit tested didn't have the fix. I think the test has proven this will not introduce a prebuilt in the product level source-build.
Thanks - I'll work on a fix to add exclusion for ILLink.Tasks.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230824.6
e7fd0ef
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 9.0.100-alpha.1.23424.6
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
I've pulled the latest changes and now I'm seeing two prebuilts:
Microsoft.DotNet.ApiCompat.Task.9.0.100-alpha.1.23423.2
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

@MichaelSimons
MichaelSimons
commented
Aug 24, 2023

Copy link


Copy Markdown

Member
Microsoft.DotNet.ApiCompat.Task.9.0.100-alpha.1.23423.2
Something odd about this one because the version.details.xml is referencing a newer version - 9.0.100-alpha.1.23424.6
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Microsoft.DotNet.ApiCompat.Task
Doing another build - this might have been an issue with stale cache.
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Microsoft.DotNet.ApiCompat.Task
Doing another build - this might have been an issue with stale cache.
I plan to try this for ILLink.Tasks:
 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/$(BundledNETCoreAppPackageVersion)" />

@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Microsoft.DotNet.ApiCompat.Task
Doing another build - this might have been an issue with stale cache.
I plan to try this for ILLink.Tasks:
 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/$(BundledNETCoreAppPackageVersion)" />

OK - that didn't work - how about?
 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/*8.*" />

@MichaelSimons
MichaelSimons
commented
Aug 24, 2023

Copy link


Copy Markdown

Member
Your only option is wild cards - you can't reference msbuild props. I think 8.* is acceptable.
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Pushed the fix for source-build leg.
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 25, 2023

Closed

@ViktorHofer
ViktorHofer
merged commit 699ffbe
into
mainAug 25, 2023
@ViktorHofer
ViktorHofer
deleted the

darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c

branch
August 25, 2023 08:22
@sbomersbomer
mentioned this pull request
Aug 30, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 24, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@sbomersbomersbomer left review comments
@MichaelSimonsMichaelSimonsMichaelSimons left review comments
@lewinglewinglewing approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar
@carlossanlopcarlossanlopAwaiting requested review from carlossanlop
@radicalradicalAwaiting requested review from radical

+1 more reviewer

@NikolaMilosavljevicNikolaMilosavljevicNikolaMilosavljevic left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

arch-arm64area-codeflowfor labeling automated codeflowarea-Tools-ILLink.NET linker development as well as trimming analyzers

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

10 participants

@ViktorHofer@sbomer@agocke@vitek-karas@lewing@akoeplinger@mmitche@MichaelSimons@NikolaMilosavljevic@radical

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[main] Update dependencies from 10 repositories - #90517
Merged
ViktorHofer merged 43 commits into
mainfrom 
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
Aug 25, 2023
Merged
[main] Update dependencies from 10 repositories#90517
ViktorHofer merged 43 commits into
mainfrom 
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Aug 14, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20230821.1
  • Date Produced: August 21, 2023 9:46:31 AM UTC
  • Commit: 8b274d3
  • Branch: refs/heads/main
From https://github.com/dotnet/source-build-reference-packages
  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20230814.1
  • Date Produced: August 14, 2023 1:05:16 PM UTC
  • Commit: 45f5554ac6813e1e155c47fd80ec146c684f65e8
  • Branch: refs/heads/main
From https://github.com/dotnet/sdk
  • Subscription: 736b3d22-d45c-4c36-de26-08db63374d9b
  • Build: 20230824.6
  • Date Produced: August 24, 2023 10:41:18 AM UTC
  • Commit: 0a8f9006fa76ee546ca68362b38fe2c70ef7b7f9
  • Branch: refs/heads/main
From https://github.com/dotnet/emsdk
  • Subscription: c22d5069-447c-4252-29fd-08d90a7bb4bc
  • Build: 20230822.1
  • Date Produced: August 22, 2023 7:53:47 PM UTC
  • Commit: 028de23143a75e43951be6275278d4dbc8520258
  • Branch: refs/heads/main
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency

attribute were produced in a build used as input to the parent dependency's build.

See Dependency Description Format
  • Coherency Updates:

    • runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
From https://github.com/dotnet/arcade
  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20230822.1
  • Date Produced: August 22, 2023 8:50:38 PM UTC
  • Commit: 4d9945d230fdd8324ce16a31c7dbd74e27a0fc9b
  • Branch: refs/heads/main
From https://github.com/dotnet/icu
  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20230821.1
  • Date Produced: August 21, 2023 2:30:01 PM UTC
  • Commit: cec51e5eba13df460746046a2aca07bcf6bb2f8e
  • Branch: refs/heads/dotnet/main
From https://github.com/dotnet/cecil
  • Subscription: bb5d2106-9fd3-425f-0abc-08daad65778c
  • Build: 20230821.1
  • Date Produced: August 21, 2023 1:12:18 PM UTC
  • Commit: d412306c1514a26737574838900052d8758da5be
  • Branch: refs/heads/main
From https://github.com/dotnet/xharness
  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20230821.1
  • Date Produced: August 21, 2023 12:57:41 PM UTC
  • Commit: 1c09ef5b669c11e1aeca92089d0c1e4408169582
  • Branch: refs/heads/main
From https://github.com/dotnet/runtime-assets
  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20230823.1
  • Date Produced: August 23, 2023 9:28:54 AM UTC
  • Commit: b901ed157568022c7b531d65b2bd28333621a6df
  • Branch: refs/heads/main
From https://github.com/dotnet/hotreload-utils
  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20230821.1
  • Date Produced: August 22, 2023 1:49:27 AM UTC
  • Commit: e02247b9b7ec1d9e407312342147d8587a8ca20e
  • Branch: refs/heads/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2023…
2b860da
…0814.1
Microsoft.DotNet.ILCompiler , Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
From Version 8.0.0-rc.1.23406.6 -> To Version 8.0.0-rc.1.23414.1
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
Aug 14, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/source-build-refer…
f55dffe
…ence-packages build 20230808.2
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23381.3 -> To Version 8.0.0-alpha.1.23408.2
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packagesAug 14, 2023
@lewinglewing
added
the 
area-Tools-ILLink
.NET linker development as well as trimming analyzers
label
Aug 14, 2023
@ghost
ghost
commented
Aug 14, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas

See info in area-owners.md if you want to be subscribed.
Issue Details
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20230814.1
  • Date Produced: August 14, 2023 10:35:21 AM UTC
  • Commit: 8986374
  • Branch: refs/heads/main
From https://github.com/dotnet/source-build-reference-packages
  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20230808.2
  • Date Produced: August 8, 2023 7:05:41 PM UTC
  • Commit: 41f1a158d460e11ded6cffd6340f9e671e2b0a5c
  • Branch: refs/heads/main
Author:dotnet-maestro[bot]
Assignees:-
Labels:
area-codeflow, area-Tools-ILLink
Milestone:-
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230814.3
54f661f
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-rc.1.23414.3
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdkAug 14, 2023
@ViktorHofer
ViktorHofer
commented
Aug 14, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@sbomer looks like the illink task invocation in illink.targets now complains about the SDK not being recent enough:
App: D:\a_work\1\s.packages\microsoft.net.illink.tasks\8.0.0-rc.1.23414.1\tools\net8.0\illink.dll

Framework: 'Microsoft.NETCore.App', version '8.0.0-rc.1.23414.1' (x64)
Probably because of c13739b
@sbomer
sbomer
commented
Aug 14, 2023

Copy link


Copy Markdown

Member
Looks like we're still using the latest ILLink package for the framework linking step. We can do one of:
  1. Use the SDK version here (unset UsingToolMicrosoftNetILLinkTasks)
  2. Use live illink (means we need to build ILLink before building the framework)
  3. Implement a workaround to use latest ILLink package with a custom runtimeconfig
I think 2. would be ideal, but might be better to do as a separate change. I suggest 1. as a short-term fix (I think this is fine for .NET 8 assuming we'll be using an RC version to build the final product). @vitek-karas@ViktorHofer@agocke any thoughts?
@agocke
agocke
commented
Aug 14, 2023

Copy link


Copy Markdown

Member
(1) sounds fine as a quick fix, and I agree (2) is ideal. I would even say, if we have time, I would consider taking (2) as an infra-only change for .NET 8. But unblocking dependency flow is even more important.
@sbomersbomer
mentioned this pull request
Aug 14, 2023

Closed

@sbomer
sbomerforce-pushed
the
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
branch
from
02dd28c to
8c0dbf1CompareAugust 14, 2023 23:41
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202308…
2de3e36
…14.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.1.23411.2 -> To Version 8.0.0-rc.1.23414.1
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdkAug 15, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 15, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
2be781b
…814.5
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23411.1 -> To Version 8.0.0-beta.23414.5
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23408.1 -> To Version 1.0.0-beta.23412.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcadeAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/icubuild 20230814.4
b736874
Microsoft.NETCore.Runtime.ICU.Transport
From Version 8.0.0-rc.1.23407.2 -> To Version 9.0.0-alpha.1.23414.4
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icuAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/cecilbuild 202308…
67ff521
…14.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23407.2 -> To Version 0.11.4-alpha.23414.1
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecilAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230815.5
bd9bd3a
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-rc.1.23415.5
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecil[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecil dotnet/sdkAug 15, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 15, 2023

Closed

@akoeplingerakoeplinger
mentioned this pull request
Aug 23, 2023
 Closed

akoeplingerand others
added 8 commits
August 23, 2023 11:25
@akoeplinger
Remove unused parameter (dotnet/arcade#13961)
6c498c6
@akoeplinger
Try to fix NativeAOT helix correlation payload issue
726b12f
@akoeplinger
Revert a change
53d3799
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
734595b
…822.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23411.1 -> To Version 8.0.0-beta.23422.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23408.1 -> To Version 1.0.0-beta.23418.1 (parent: Microsoft.DotNet.Helix.Sdk
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
949836f
…ld 20230823.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23408.1 -> To Version 8.0.0-beta.23423.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202308…
e5e460b
…22.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
From Version 9.0.0-alpha.1.23415.2 -> To Version 9.0.0-alpha.1.23422.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230823.2
4c1900f
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 9.0.100-alpha.1.23423.2
@dotnet-maestro
Dependency coherency updates
2be61d1
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 16.0.5-alpha.1.23408.1 -> To Version 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
@akoeplinger
akoeplinger
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@mmitche
mmitche
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@MichaelSimons
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 23, 2023

Closed

@MichaelSimons
MichaelSimons
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@NikolaMilosavljevic - Can you help investigate/provide guidance? TIA
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 23, 2023

Copy link


Copy Markdown

Contributor
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@NikolaMilosavljevic - Can you help investigate/provide guidance? TIA
I've reproed this locally - investigating...
NikolaMilosavljevic
NikolaMilosavljevic
reviewed
Aug 23, 2023
View reviewed changes
Comment threadsrc/tools/illink/Directory.Build.props

Comment on lines

-2
 to 
-5

 <PropertyGroup>
 <!-- Don't use the prebuilt illink that is referenced by Arcade. -->
 <UsingToolMicrosoftNetILLinkTasks>false</UsingToolMicrosoftNetILLinkTasks>
 </PropertyGroup>
@NikolaMilosavljevicNikolaMilosavljevicAug 23, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the root cause of source-build failure. It is causing the usage of prebuilt version of Microsoft.Net.ILLink.Tasks package. Is this accidental? @akoeplinger @vikoeplinger
@sbomersbomerAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes intentionally use the version of ILLink.Tasks that is referenced by the SDK in global.json (BundledNETCoreAppPackageVersion in https://github.com/dotnet/runtime/pull/90517/files#diff-361b24a1b39d592c236441b48457113d003aeb3bc03df5bbc0318fd0b2e05cd2R50-R53).
This packagereference is effectively equivalent to building with the SDK, with <UsingToolMicrosoftNetILLinkTasks>false</UsingToolMicrosoftNetILLinkTasks>. The packagereference was required as a workaround (see these comments), but I'd expect that for the purpose of source-build it is no different.
@MichaelSimonsMichaelSimonsAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
I'll validate full product build locally.
@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
I'll validate full product build locally.
Full source-build is showing 20 prebuilts but not the one for Microsoft.Net.ILLink.Tasks. I'm unsure about this - @MichaelSimons
Here's the full list of prebuilts:
 <Usage Id="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.Common" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.CSharp" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.Extensions.DependencyInjection" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.Logging" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.Extensions.Options" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.Primitives" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.Current.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.net6.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.net7.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="System.Composition" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.AttributedModel" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Convention" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Hosting" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Runtime" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.TypedParts" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />

@MichaelSimonsMichaelSimonsAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one direct dependency coming from runtime
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />

This is a result of #90340 which was addressed in #91006. I suspect the commit tested didn't have the fix. I think the test has proven this will not introduce a prebuilt in the product level source-build.
@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one direct dependency coming from runtime
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />

This is a result of #90340 which was addressed in #91006. I suspect the commit tested didn't have the fix. I think the test has proven this will not introduce a prebuilt in the product level source-build.
Thanks - I'll work on a fix to add exclusion for ILLink.Tasks.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230824.6
e7fd0ef
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 9.0.100-alpha.1.23424.6
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
I've pulled the latest changes and now I'm seeing two prebuilts:
Microsoft.DotNet.ApiCompat.Task.9.0.100-alpha.1.23423.2
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

@MichaelSimons
MichaelSimons
commented
Aug 24, 2023

Copy link


Copy Markdown

Member
Microsoft.DotNet.ApiCompat.Task.9.0.100-alpha.1.23423.2
Something odd about this one because the version.details.xml is referencing a newer version - 9.0.100-alpha.1.23424.6
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Microsoft.DotNet.ApiCompat.Task
Doing another build - this might have been an issue with stale cache.
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Microsoft.DotNet.ApiCompat.Task
Doing another build - this might have been an issue with stale cache.
I plan to try this for ILLink.Tasks:
 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/$(BundledNETCoreAppPackageVersion)" />

@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Microsoft.DotNet.ApiCompat.Task
Doing another build - this might have been an issue with stale cache.
I plan to try this for ILLink.Tasks:
 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/$(BundledNETCoreAppPackageVersion)" />

OK - that didn't work - how about?
 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/*8.*" />

@MichaelSimons
MichaelSimons
commented
Aug 24, 2023

Copy link


Copy Markdown

Member
Your only option is wild cards - you can't reference msbuild props. I think 8.* is acceptable.
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Pushed the fix for source-build leg.
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 25, 2023

Closed

@ViktorHofer
ViktorHofer
merged commit 699ffbe
into
mainAug 25, 2023
@ViktorHofer
ViktorHofer
deleted the

darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c

branch
August 25, 2023 08:22
@sbomersbomer
mentioned this pull request
Aug 30, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 24, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@sbomersbomersbomer left review comments
@MichaelSimonsMichaelSimonsMichaelSimons left review comments
@lewinglewinglewing approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar
@carlossanlopcarlossanlopAwaiting requested review from carlossanlop
@radicalradicalAwaiting requested review from radical

+1 more reviewer

@NikolaMilosavljevicNikolaMilosavljevicNikolaMilosavljevic left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

arch-arm64area-codeflowfor labeling automated codeflowarea-Tools-ILLink.NET linker development as well as trimming analyzers

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

10 participants

@ViktorHofer@sbomer@agocke@vitek-karas@lewing@akoeplinger@mmitche@MichaelSimons@NikolaMilosavljevic@radical

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[main] Update dependencies from 10 repositories - #90517
Merged
ViktorHofer merged 43 commits into
mainfrom 
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
Aug 25, 2023
Merged
[main] Update dependencies from 10 repositories#90517
ViktorHofer merged 43 commits into
mainfrom 
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Aug 14, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20230821.1
  • Date Produced: August 21, 2023 9:46:31 AM UTC
  • Commit: 8b274d3
  • Branch: refs/heads/main
From https://github.com/dotnet/source-build-reference-packages
  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20230814.1
  • Date Produced: August 14, 2023 1:05:16 PM UTC
  • Commit: 45f5554ac6813e1e155c47fd80ec146c684f65e8
  • Branch: refs/heads/main
From https://github.com/dotnet/sdk
  • Subscription: 736b3d22-d45c-4c36-de26-08db63374d9b
  • Build: 20230824.6
  • Date Produced: August 24, 2023 10:41:18 AM UTC
  • Commit: 0a8f9006fa76ee546ca68362b38fe2c70ef7b7f9
  • Branch: refs/heads/main
From https://github.com/dotnet/emsdk
  • Subscription: c22d5069-447c-4252-29fd-08d90a7bb4bc
  • Build: 20230822.1
  • Date Produced: August 22, 2023 7:53:47 PM UTC
  • Commit: 028de23143a75e43951be6275278d4dbc8520258
  • Branch: refs/heads/main
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency

attribute were produced in a build used as input to the parent dependency's build.

See Dependency Description Format
  • Coherency Updates:

    • runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
From https://github.com/dotnet/arcade
  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20230822.1
  • Date Produced: August 22, 2023 8:50:38 PM UTC
  • Commit: 4d9945d230fdd8324ce16a31c7dbd74e27a0fc9b
  • Branch: refs/heads/main
From https://github.com/dotnet/icu
  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20230821.1
  • Date Produced: August 21, 2023 2:30:01 PM UTC
  • Commit: cec51e5eba13df460746046a2aca07bcf6bb2f8e
  • Branch: refs/heads/dotnet/main
From https://github.com/dotnet/cecil
  • Subscription: bb5d2106-9fd3-425f-0abc-08daad65778c
  • Build: 20230821.1
  • Date Produced: August 21, 2023 1:12:18 PM UTC
  • Commit: d412306c1514a26737574838900052d8758da5be
  • Branch: refs/heads/main
From https://github.com/dotnet/xharness
  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20230821.1
  • Date Produced: August 21, 2023 12:57:41 PM UTC
  • Commit: 1c09ef5b669c11e1aeca92089d0c1e4408169582
  • Branch: refs/heads/main
From https://github.com/dotnet/runtime-assets
  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20230823.1
  • Date Produced: August 23, 2023 9:28:54 AM UTC
  • Commit: b901ed157568022c7b531d65b2bd28333621a6df
  • Branch: refs/heads/main
From https://github.com/dotnet/hotreload-utils
  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20230821.1
  • Date Produced: August 22, 2023 1:49:27 AM UTC
  • Commit: e02247b9b7ec1d9e407312342147d8587a8ca20e
  • Branch: refs/heads/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2023…
2b860da
…0814.1
Microsoft.DotNet.ILCompiler , Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
From Version 8.0.0-rc.1.23406.6 -> To Version 8.0.0-rc.1.23414.1
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
Aug 14, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/source-build-refer…
f55dffe
…ence-packages build 20230808.2
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23381.3 -> To Version 8.0.0-alpha.1.23408.2
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packagesAug 14, 2023
@lewinglewing
added
the 
area-Tools-ILLink
.NET linker development as well as trimming analyzers
label
Aug 14, 2023
@ghost
ghost
commented
Aug 14, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas

See info in area-owners.md if you want to be subscribed.
Issue Details
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20230814.1
  • Date Produced: August 14, 2023 10:35:21 AM UTC
  • Commit: 8986374
  • Branch: refs/heads/main
From https://github.com/dotnet/source-build-reference-packages
  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20230808.2
  • Date Produced: August 8, 2023 7:05:41 PM UTC
  • Commit: 41f1a158d460e11ded6cffd6340f9e671e2b0a5c
  • Branch: refs/heads/main
Author:dotnet-maestro[bot]
Assignees:-
Labels:
area-codeflow, area-Tools-ILLink
Milestone:-
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230814.3
54f661f
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-rc.1.23414.3
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdkAug 14, 2023
@ViktorHofer
ViktorHofer
commented
Aug 14, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@sbomer looks like the illink task invocation in illink.targets now complains about the SDK not being recent enough:
App: D:\a_work\1\s.packages\microsoft.net.illink.tasks\8.0.0-rc.1.23414.1\tools\net8.0\illink.dll

Framework: 'Microsoft.NETCore.App', version '8.0.0-rc.1.23414.1' (x64)
Probably because of c13739b
@sbomer
sbomer
commented
Aug 14, 2023

Copy link


Copy Markdown

Member
Looks like we're still using the latest ILLink package for the framework linking step. We can do one of:
  1. Use the SDK version here (unset UsingToolMicrosoftNetILLinkTasks)
  2. Use live illink (means we need to build ILLink before building the framework)
  3. Implement a workaround to use latest ILLink package with a custom runtimeconfig
I think 2. would be ideal, but might be better to do as a separate change. I suggest 1. as a short-term fix (I think this is fine for .NET 8 assuming we'll be using an RC version to build the final product). @vitek-karas@ViktorHofer@agocke any thoughts?
@agocke
agocke
commented
Aug 14, 2023

Copy link


Copy Markdown

Member
(1) sounds fine as a quick fix, and I agree (2) is ideal. I would even say, if we have time, I would consider taking (2) as an infra-only change for .NET 8. But unblocking dependency flow is even more important.
@sbomersbomer
mentioned this pull request
Aug 14, 2023

Closed

@sbomer
sbomerforce-pushed
the
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
branch
from
02dd28c to
8c0dbf1CompareAugust 14, 2023 23:41
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202308…
2de3e36
…14.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.1.23411.2 -> To Version 8.0.0-rc.1.23414.1
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdkAug 15, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 15, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
2be781b
…814.5
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23411.1 -> To Version 8.0.0-beta.23414.5
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23408.1 -> To Version 1.0.0-beta.23412.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcadeAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/icubuild 20230814.4
b736874
Microsoft.NETCore.Runtime.ICU.Transport
From Version 8.0.0-rc.1.23407.2 -> To Version 9.0.0-alpha.1.23414.4
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icuAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/cecilbuild 202308…
67ff521
…14.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23407.2 -> To Version 0.11.4-alpha.23414.1
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecilAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230815.5
bd9bd3a
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-rc.1.23415.5
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecil[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecil dotnet/sdkAug 15, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 15, 2023

Closed

@akoeplingerakoeplinger
mentioned this pull request
Aug 23, 2023
 Closed

akoeplingerand others
added 8 commits
August 23, 2023 11:25
@akoeplinger
Remove unused parameter (dotnet/arcade#13961)
6c498c6
@akoeplinger
Try to fix NativeAOT helix correlation payload issue
726b12f
@akoeplinger
Revert a change
53d3799
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
734595b
…822.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23411.1 -> To Version 8.0.0-beta.23422.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23408.1 -> To Version 1.0.0-beta.23418.1 (parent: Microsoft.DotNet.Helix.Sdk
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
949836f
…ld 20230823.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23408.1 -> To Version 8.0.0-beta.23423.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202308…
e5e460b
…22.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
From Version 9.0.0-alpha.1.23415.2 -> To Version 9.0.0-alpha.1.23422.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230823.2
4c1900f
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 9.0.100-alpha.1.23423.2
@dotnet-maestro
Dependency coherency updates
2be61d1
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 16.0.5-alpha.1.23408.1 -> To Version 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
@akoeplinger
akoeplinger
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@mmitche
mmitche
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@MichaelSimons
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 23, 2023

Closed

@MichaelSimons
MichaelSimons
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@NikolaMilosavljevic - Can you help investigate/provide guidance? TIA
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 23, 2023

Copy link


Copy Markdown

Contributor
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@NikolaMilosavljevic - Can you help investigate/provide guidance? TIA
I've reproed this locally - investigating...
NikolaMilosavljevic
NikolaMilosavljevic
reviewed
Aug 23, 2023
View reviewed changes
Comment threadsrc/tools/illink/Directory.Build.props

Comment on lines

-2
 to 
-5

 <PropertyGroup>
 <!-- Don't use the prebuilt illink that is referenced by Arcade. -->
 <UsingToolMicrosoftNetILLinkTasks>false</UsingToolMicrosoftNetILLinkTasks>
 </PropertyGroup>
@NikolaMilosavljevicNikolaMilosavljevicAug 23, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the root cause of source-build failure. It is causing the usage of prebuilt version of Microsoft.Net.ILLink.Tasks package. Is this accidental? @akoeplinger @vikoeplinger
@sbomersbomerAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes intentionally use the version of ILLink.Tasks that is referenced by the SDK in global.json (BundledNETCoreAppPackageVersion in https://github.com/dotnet/runtime/pull/90517/files#diff-361b24a1b39d592c236441b48457113d003aeb3bc03df5bbc0318fd0b2e05cd2R50-R53).
This packagereference is effectively equivalent to building with the SDK, with <UsingToolMicrosoftNetILLinkTasks>false</UsingToolMicrosoftNetILLinkTasks>. The packagereference was required as a workaround (see these comments), but I'd expect that for the purpose of source-build it is no different.
@MichaelSimonsMichaelSimonsAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
I'll validate full product build locally.
@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
I'll validate full product build locally.
Full source-build is showing 20 prebuilts but not the one for Microsoft.Net.ILLink.Tasks. I'm unsure about this - @MichaelSimons
Here's the full list of prebuilts:
 <Usage Id="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.Common" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.CSharp" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.Extensions.DependencyInjection" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.Logging" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.Extensions.Options" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.Primitives" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.Current.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.net6.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.net7.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="System.Composition" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.AttributedModel" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Convention" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Hosting" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Runtime" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.TypedParts" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />

@MichaelSimonsMichaelSimonsAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one direct dependency coming from runtime
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />

This is a result of #90340 which was addressed in #91006. I suspect the commit tested didn't have the fix. I think the test has proven this will not introduce a prebuilt in the product level source-build.
@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one direct dependency coming from runtime
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />

This is a result of #90340 which was addressed in #91006. I suspect the commit tested didn't have the fix. I think the test has proven this will not introduce a prebuilt in the product level source-build.
Thanks - I'll work on a fix to add exclusion for ILLink.Tasks.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230824.6
e7fd0ef
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 9.0.100-alpha.1.23424.6
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
I've pulled the latest changes and now I'm seeing two prebuilts:
Microsoft.DotNet.ApiCompat.Task.9.0.100-alpha.1.23423.2
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

@MichaelSimons
MichaelSimons
commented
Aug 24, 2023

Copy link


Copy Markdown

Member
Microsoft.DotNet.ApiCompat.Task.9.0.100-alpha.1.23423.2
Something odd about this one because the version.details.xml is referencing a newer version - 9.0.100-alpha.1.23424.6
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Microsoft.DotNet.ApiCompat.Task
Doing another build - this might have been an issue with stale cache.
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Microsoft.DotNet.ApiCompat.Task
Doing another build - this might have been an issue with stale cache.
I plan to try this for ILLink.Tasks:
 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/$(BundledNETCoreAppPackageVersion)" />

@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Microsoft.DotNet.ApiCompat.Task
Doing another build - this might have been an issue with stale cache.
I plan to try this for ILLink.Tasks:
 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/$(BundledNETCoreAppPackageVersion)" />

OK - that didn't work - how about?
 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/*8.*" />

@MichaelSimons
MichaelSimons
commented
Aug 24, 2023

Copy link


Copy Markdown

Member
Your only option is wild cards - you can't reference msbuild props. I think 8.* is acceptable.
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Pushed the fix for source-build leg.
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 25, 2023

Closed

@ViktorHofer
ViktorHofer
merged commit 699ffbe
into
mainAug 25, 2023
@ViktorHofer
ViktorHofer
deleted the

darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c

branch
August 25, 2023 08:22
@sbomersbomer
mentioned this pull request
Aug 30, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 24, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@sbomersbomersbomer left review comments
@MichaelSimonsMichaelSimonsMichaelSimons left review comments
@lewinglewinglewing approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar
@carlossanlopcarlossanlopAwaiting requested review from carlossanlop
@radicalradicalAwaiting requested review from radical

+1 more reviewer

@NikolaMilosavljevicNikolaMilosavljevicNikolaMilosavljevic left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

arch-arm64area-codeflowfor labeling automated codeflowarea-Tools-ILLink.NET linker development as well as trimming analyzers

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

10 participants

@ViktorHofer@sbomer@agocke@vitek-karas@lewing@akoeplinger@mmitche@MichaelSimons@NikolaMilosavljevic@radical

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[main] Update dependencies from 10 repositories - #90517
Merged
ViktorHofer merged 43 commits into
mainfrom 
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
Aug 25, 2023
Merged
[main] Update dependencies from 10 repositories#90517
ViktorHofer merged 43 commits into
mainfrom 
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Aug 14, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20230821.1
  • Date Produced: August 21, 2023 9:46:31 AM UTC
  • Commit: 8b274d3
  • Branch: refs/heads/main
From https://github.com/dotnet/source-build-reference-packages
  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20230814.1
  • Date Produced: August 14, 2023 1:05:16 PM UTC
  • Commit: 45f5554ac6813e1e155c47fd80ec146c684f65e8
  • Branch: refs/heads/main
From https://github.com/dotnet/sdk
  • Subscription: 736b3d22-d45c-4c36-de26-08db63374d9b
  • Build: 20230824.6
  • Date Produced: August 24, 2023 10:41:18 AM UTC
  • Commit: 0a8f9006fa76ee546ca68362b38fe2c70ef7b7f9
  • Branch: refs/heads/main
From https://github.com/dotnet/emsdk
  • Subscription: c22d5069-447c-4252-29fd-08d90a7bb4bc
  • Build: 20230822.1
  • Date Produced: August 22, 2023 7:53:47 PM UTC
  • Commit: 028de23143a75e43951be6275278d4dbc8520258
  • Branch: refs/heads/main
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency

attribute were produced in a build used as input to the parent dependency's build.

See Dependency Description Format
  • Coherency Updates:

    • runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
From https://github.com/dotnet/arcade
  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20230822.1
  • Date Produced: August 22, 2023 8:50:38 PM UTC
  • Commit: 4d9945d230fdd8324ce16a31c7dbd74e27a0fc9b
  • Branch: refs/heads/main
From https://github.com/dotnet/icu
  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20230821.1
  • Date Produced: August 21, 2023 2:30:01 PM UTC
  • Commit: cec51e5eba13df460746046a2aca07bcf6bb2f8e
  • Branch: refs/heads/dotnet/main
From https://github.com/dotnet/cecil
  • Subscription: bb5d2106-9fd3-425f-0abc-08daad65778c
  • Build: 20230821.1
  • Date Produced: August 21, 2023 1:12:18 PM UTC
  • Commit: d412306c1514a26737574838900052d8758da5be
  • Branch: refs/heads/main
From https://github.com/dotnet/xharness
  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20230821.1
  • Date Produced: August 21, 2023 12:57:41 PM UTC
  • Commit: 1c09ef5b669c11e1aeca92089d0c1e4408169582
  • Branch: refs/heads/main
From https://github.com/dotnet/runtime-assets
  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20230823.1
  • Date Produced: August 23, 2023 9:28:54 AM UTC
  • Commit: b901ed157568022c7b531d65b2bd28333621a6df
  • Branch: refs/heads/main
From https://github.com/dotnet/hotreload-utils
  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20230821.1
  • Date Produced: August 22, 2023 1:49:27 AM UTC
  • Commit: e02247b9b7ec1d9e407312342147d8587a8ca20e
  • Branch: refs/heads/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2023…
2b860da
…0814.1
Microsoft.DotNet.ILCompiler , Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
From Version 8.0.0-rc.1.23406.6 -> To Version 8.0.0-rc.1.23414.1
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
Aug 14, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/source-build-refer…
f55dffe
…ence-packages build 20230808.2
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23381.3 -> To Version 8.0.0-alpha.1.23408.2
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packagesAug 14, 2023
@lewinglewing
added
the 
area-Tools-ILLink
.NET linker development as well as trimming analyzers
label
Aug 14, 2023
@ghost
ghost
commented
Aug 14, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas

See info in area-owners.md if you want to be subscribed.
Issue Details
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20230814.1
  • Date Produced: August 14, 2023 10:35:21 AM UTC
  • Commit: 8986374
  • Branch: refs/heads/main
From https://github.com/dotnet/source-build-reference-packages
  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20230808.2
  • Date Produced: August 8, 2023 7:05:41 PM UTC
  • Commit: 41f1a158d460e11ded6cffd6340f9e671e2b0a5c
  • Branch: refs/heads/main
Author:dotnet-maestro[bot]
Assignees:-
Labels:
area-codeflow, area-Tools-ILLink
Milestone:-
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230814.3
54f661f
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-rc.1.23414.3
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdkAug 14, 2023
@ViktorHofer
ViktorHofer
commented
Aug 14, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@sbomer looks like the illink task invocation in illink.targets now complains about the SDK not being recent enough:
App: D:\a_work\1\s.packages\microsoft.net.illink.tasks\8.0.0-rc.1.23414.1\tools\net8.0\illink.dll

Framework: 'Microsoft.NETCore.App', version '8.0.0-rc.1.23414.1' (x64)
Probably because of c13739b
@sbomer
sbomer
commented
Aug 14, 2023

Copy link


Copy Markdown

Member
Looks like we're still using the latest ILLink package for the framework linking step. We can do one of:
  1. Use the SDK version here (unset UsingToolMicrosoftNetILLinkTasks)
  2. Use live illink (means we need to build ILLink before building the framework)
  3. Implement a workaround to use latest ILLink package with a custom runtimeconfig
I think 2. would be ideal, but might be better to do as a separate change. I suggest 1. as a short-term fix (I think this is fine for .NET 8 assuming we'll be using an RC version to build the final product). @vitek-karas@ViktorHofer@agocke any thoughts?
@agocke
agocke
commented
Aug 14, 2023

Copy link


Copy Markdown

Member
(1) sounds fine as a quick fix, and I agree (2) is ideal. I would even say, if we have time, I would consider taking (2) as an infra-only change for .NET 8. But unblocking dependency flow is even more important.
@sbomersbomer
mentioned this pull request
Aug 14, 2023

Closed

@sbomer
sbomerforce-pushed
the
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
branch
from
02dd28c to
8c0dbf1CompareAugust 14, 2023 23:41
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202308…
2de3e36
…14.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.1.23411.2 -> To Version 8.0.0-rc.1.23414.1
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdkAug 15, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 15, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
2be781b
…814.5
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23411.1 -> To Version 8.0.0-beta.23414.5
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23408.1 -> To Version 1.0.0-beta.23412.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcadeAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/icubuild 20230814.4
b736874
Microsoft.NETCore.Runtime.ICU.Transport
From Version 8.0.0-rc.1.23407.2 -> To Version 9.0.0-alpha.1.23414.4
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icuAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/cecilbuild 202308…
67ff521
…14.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23407.2 -> To Version 0.11.4-alpha.23414.1
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecilAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230815.5
bd9bd3a
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-rc.1.23415.5
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecil[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecil dotnet/sdkAug 15, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 15, 2023

Closed

@akoeplingerakoeplinger
mentioned this pull request
Aug 23, 2023
 Closed

akoeplingerand others
added 8 commits
August 23, 2023 11:25
@akoeplinger
Remove unused parameter (dotnet/arcade#13961)
6c498c6
@akoeplinger
Try to fix NativeAOT helix correlation payload issue
726b12f
@akoeplinger
Revert a change
53d3799
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
734595b
…822.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23411.1 -> To Version 8.0.0-beta.23422.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23408.1 -> To Version 1.0.0-beta.23418.1 (parent: Microsoft.DotNet.Helix.Sdk
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
949836f
…ld 20230823.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23408.1 -> To Version 8.0.0-beta.23423.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202308…
e5e460b
…22.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
From Version 9.0.0-alpha.1.23415.2 -> To Version 9.0.0-alpha.1.23422.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230823.2
4c1900f
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 9.0.100-alpha.1.23423.2
@dotnet-maestro
Dependency coherency updates
2be61d1
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 16.0.5-alpha.1.23408.1 -> To Version 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
@akoeplinger
akoeplinger
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@mmitche
mmitche
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@MichaelSimons
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 23, 2023

Closed

@MichaelSimons
MichaelSimons
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@NikolaMilosavljevic - Can you help investigate/provide guidance? TIA
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 23, 2023

Copy link


Copy Markdown

Contributor
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@NikolaMilosavljevic - Can you help investigate/provide guidance? TIA
I've reproed this locally - investigating...
NikolaMilosavljevic
NikolaMilosavljevic
reviewed
Aug 23, 2023
View reviewed changes
Comment threadsrc/tools/illink/Directory.Build.props

Comment on lines

-2
 to 
-5

 <PropertyGroup>
 <!-- Don't use the prebuilt illink that is referenced by Arcade. -->
 <UsingToolMicrosoftNetILLinkTasks>false</UsingToolMicrosoftNetILLinkTasks>
 </PropertyGroup>
@NikolaMilosavljevicNikolaMilosavljevicAug 23, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the root cause of source-build failure. It is causing the usage of prebuilt version of Microsoft.Net.ILLink.Tasks package. Is this accidental? @akoeplinger @vikoeplinger
@sbomersbomerAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes intentionally use the version of ILLink.Tasks that is referenced by the SDK in global.json (BundledNETCoreAppPackageVersion in https://github.com/dotnet/runtime/pull/90517/files#diff-361b24a1b39d592c236441b48457113d003aeb3bc03df5bbc0318fd0b2e05cd2R50-R53).
This packagereference is effectively equivalent to building with the SDK, with <UsingToolMicrosoftNetILLinkTasks>false</UsingToolMicrosoftNetILLinkTasks>. The packagereference was required as a workaround (see these comments), but I'd expect that for the purpose of source-build it is no different.
@MichaelSimonsMichaelSimonsAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
I'll validate full product build locally.
@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
I'll validate full product build locally.
Full source-build is showing 20 prebuilts but not the one for Microsoft.Net.ILLink.Tasks. I'm unsure about this - @MichaelSimons
Here's the full list of prebuilts:
 <Usage Id="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.Common" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.CSharp" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.Extensions.DependencyInjection" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.Logging" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.Extensions.Options" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.Primitives" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.Current.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.net6.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.net7.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="System.Composition" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.AttributedModel" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Convention" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Hosting" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Runtime" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.TypedParts" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />

@MichaelSimonsMichaelSimonsAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one direct dependency coming from runtime
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />

This is a result of #90340 which was addressed in #91006. I suspect the commit tested didn't have the fix. I think the test has proven this will not introduce a prebuilt in the product level source-build.
@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one direct dependency coming from runtime
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />

This is a result of #90340 which was addressed in #91006. I suspect the commit tested didn't have the fix. I think the test has proven this will not introduce a prebuilt in the product level source-build.
Thanks - I'll work on a fix to add exclusion for ILLink.Tasks.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230824.6
e7fd0ef
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 9.0.100-alpha.1.23424.6
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
I've pulled the latest changes and now I'm seeing two prebuilts:
Microsoft.DotNet.ApiCompat.Task.9.0.100-alpha.1.23423.2
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

@MichaelSimons
MichaelSimons
commented
Aug 24, 2023

Copy link


Copy Markdown

Member
Microsoft.DotNet.ApiCompat.Task.9.0.100-alpha.1.23423.2
Something odd about this one because the version.details.xml is referencing a newer version - 9.0.100-alpha.1.23424.6
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Microsoft.DotNet.ApiCompat.Task
Doing another build - this might have been an issue with stale cache.
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Microsoft.DotNet.ApiCompat.Task
Doing another build - this might have been an issue with stale cache.
I plan to try this for ILLink.Tasks:
 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/$(BundledNETCoreAppPackageVersion)" />

@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Microsoft.DotNet.ApiCompat.Task
Doing another build - this might have been an issue with stale cache.
I plan to try this for ILLink.Tasks:
 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/$(BundledNETCoreAppPackageVersion)" />

OK - that didn't work - how about?
 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/*8.*" />

@MichaelSimons
MichaelSimons
commented
Aug 24, 2023

Copy link


Copy Markdown

Member
Your only option is wild cards - you can't reference msbuild props. I think 8.* is acceptable.
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Pushed the fix for source-build leg.
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 25, 2023

Closed

@ViktorHofer
ViktorHofer
merged commit 699ffbe
into
mainAug 25, 2023
@ViktorHofer
ViktorHofer
deleted the

darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c

branch
August 25, 2023 08:22
@sbomersbomer
mentioned this pull request
Aug 30, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 24, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@sbomersbomersbomer left review comments
@MichaelSimonsMichaelSimonsMichaelSimons left review comments
@lewinglewinglewing approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar
@carlossanlopcarlossanlopAwaiting requested review from carlossanlop
@radicalradicalAwaiting requested review from radical

+1 more reviewer

@NikolaMilosavljevicNikolaMilosavljevicNikolaMilosavljevic left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

arch-arm64area-codeflowfor labeling automated codeflowarea-Tools-ILLink.NET linker development as well as trimming analyzers

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

10 participants

@ViktorHofer@sbomer@agocke@vitek-karas@lewing@akoeplinger@mmitche@MichaelSimons@NikolaMilosavljevic@radical

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[main] Update dependencies from 10 repositories - #90517
Merged
ViktorHofer merged 43 commits into
mainfrom 
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
Aug 25, 2023
Merged
[main] Update dependencies from 10 repositories#90517
ViktorHofer merged 43 commits into
mainfrom 
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Aug 14, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20230821.1
  • Date Produced: August 21, 2023 9:46:31 AM UTC
  • Commit: 8b274d3
  • Branch: refs/heads/main
From https://github.com/dotnet/source-build-reference-packages
  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20230814.1
  • Date Produced: August 14, 2023 1:05:16 PM UTC
  • Commit: 45f5554ac6813e1e155c47fd80ec146c684f65e8
  • Branch: refs/heads/main
From https://github.com/dotnet/sdk
  • Subscription: 736b3d22-d45c-4c36-de26-08db63374d9b
  • Build: 20230824.6
  • Date Produced: August 24, 2023 10:41:18 AM UTC
  • Commit: 0a8f9006fa76ee546ca68362b38fe2c70ef7b7f9
  • Branch: refs/heads/main
From https://github.com/dotnet/emsdk
  • Subscription: c22d5069-447c-4252-29fd-08d90a7bb4bc
  • Build: 20230822.1
  • Date Produced: August 22, 2023 7:53:47 PM UTC
  • Commit: 028de23143a75e43951be6275278d4dbc8520258
  • Branch: refs/heads/main
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency

attribute were produced in a build used as input to the parent dependency's build.

See Dependency Description Format
  • Coherency Updates:

    • runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
From https://github.com/dotnet/arcade
  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20230822.1
  • Date Produced: August 22, 2023 8:50:38 PM UTC
  • Commit: 4d9945d230fdd8324ce16a31c7dbd74e27a0fc9b
  • Branch: refs/heads/main
From https://github.com/dotnet/icu
  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20230821.1
  • Date Produced: August 21, 2023 2:30:01 PM UTC
  • Commit: cec51e5eba13df460746046a2aca07bcf6bb2f8e
  • Branch: refs/heads/dotnet/main
From https://github.com/dotnet/cecil
  • Subscription: bb5d2106-9fd3-425f-0abc-08daad65778c
  • Build: 20230821.1
  • Date Produced: August 21, 2023 1:12:18 PM UTC
  • Commit: d412306c1514a26737574838900052d8758da5be
  • Branch: refs/heads/main
From https://github.com/dotnet/xharness
  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20230821.1
  • Date Produced: August 21, 2023 12:57:41 PM UTC
  • Commit: 1c09ef5b669c11e1aeca92089d0c1e4408169582
  • Branch: refs/heads/main
From https://github.com/dotnet/runtime-assets
  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20230823.1
  • Date Produced: August 23, 2023 9:28:54 AM UTC
  • Commit: b901ed157568022c7b531d65b2bd28333621a6df
  • Branch: refs/heads/main
From https://github.com/dotnet/hotreload-utils
  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20230821.1
  • Date Produced: August 22, 2023 1:49:27 AM UTC
  • Commit: e02247b9b7ec1d9e407312342147d8587a8ca20e
  • Branch: refs/heads/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2023…
2b860da
…0814.1
Microsoft.DotNet.ILCompiler , Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
From Version 8.0.0-rc.1.23406.6 -> To Version 8.0.0-rc.1.23414.1
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
Aug 14, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/source-build-refer…
f55dffe
…ence-packages build 20230808.2
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23381.3 -> To Version 8.0.0-alpha.1.23408.2
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packagesAug 14, 2023
@lewinglewing
added
the 
area-Tools-ILLink
.NET linker development as well as trimming analyzers
label
Aug 14, 2023
@ghost
ghost
commented
Aug 14, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas

See info in area-owners.md if you want to be subscribed.
Issue Details
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20230814.1
  • Date Produced: August 14, 2023 10:35:21 AM UTC
  • Commit: 8986374
  • Branch: refs/heads/main
From https://github.com/dotnet/source-build-reference-packages
  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20230808.2
  • Date Produced: August 8, 2023 7:05:41 PM UTC
  • Commit: 41f1a158d460e11ded6cffd6340f9e671e2b0a5c
  • Branch: refs/heads/main
Author:dotnet-maestro[bot]
Assignees:-
Labels:
area-codeflow, area-Tools-ILLink
Milestone:-
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230814.3
54f661f
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-rc.1.23414.3
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdkAug 14, 2023
@ViktorHofer
ViktorHofer
commented
Aug 14, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@sbomer looks like the illink task invocation in illink.targets now complains about the SDK not being recent enough:
App: D:\a_work\1\s.packages\microsoft.net.illink.tasks\8.0.0-rc.1.23414.1\tools\net8.0\illink.dll

Framework: 'Microsoft.NETCore.App', version '8.0.0-rc.1.23414.1' (x64)
Probably because of c13739b
@sbomer
sbomer
commented
Aug 14, 2023

Copy link


Copy Markdown

Member
Looks like we're still using the latest ILLink package for the framework linking step. We can do one of:
  1. Use the SDK version here (unset UsingToolMicrosoftNetILLinkTasks)
  2. Use live illink (means we need to build ILLink before building the framework)
  3. Implement a workaround to use latest ILLink package with a custom runtimeconfig
I think 2. would be ideal, but might be better to do as a separate change. I suggest 1. as a short-term fix (I think this is fine for .NET 8 assuming we'll be using an RC version to build the final product). @vitek-karas@ViktorHofer@agocke any thoughts?
@agocke
agocke
commented
Aug 14, 2023

Copy link


Copy Markdown

Member
(1) sounds fine as a quick fix, and I agree (2) is ideal. I would even say, if we have time, I would consider taking (2) as an infra-only change for .NET 8. But unblocking dependency flow is even more important.
@sbomersbomer
mentioned this pull request
Aug 14, 2023

Closed

@sbomer
sbomerforce-pushed
the
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
branch
from
02dd28c to
8c0dbf1CompareAugust 14, 2023 23:41
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202308…
2de3e36
…14.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.1.23411.2 -> To Version 8.0.0-rc.1.23414.1
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdkAug 15, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 15, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
2be781b
…814.5
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23411.1 -> To Version 8.0.0-beta.23414.5
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23408.1 -> To Version 1.0.0-beta.23412.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcadeAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/icubuild 20230814.4
b736874
Microsoft.NETCore.Runtime.ICU.Transport
From Version 8.0.0-rc.1.23407.2 -> To Version 9.0.0-alpha.1.23414.4
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icuAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/cecilbuild 202308…
67ff521
…14.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23407.2 -> To Version 0.11.4-alpha.23414.1
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecilAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230815.5
bd9bd3a
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-rc.1.23415.5
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecil[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecil dotnet/sdkAug 15, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 15, 2023

Closed

@akoeplingerakoeplinger
mentioned this pull request
Aug 23, 2023
 Closed

akoeplingerand others
added 8 commits
August 23, 2023 11:25
@akoeplinger
Remove unused parameter (dotnet/arcade#13961)
6c498c6
@akoeplinger
Try to fix NativeAOT helix correlation payload issue
726b12f
@akoeplinger
Revert a change
53d3799
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
734595b
…822.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23411.1 -> To Version 8.0.0-beta.23422.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23408.1 -> To Version 1.0.0-beta.23418.1 (parent: Microsoft.DotNet.Helix.Sdk
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
949836f
…ld 20230823.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23408.1 -> To Version 8.0.0-beta.23423.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202308…
e5e460b
…22.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
From Version 9.0.0-alpha.1.23415.2 -> To Version 9.0.0-alpha.1.23422.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230823.2
4c1900f
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 9.0.100-alpha.1.23423.2
@dotnet-maestro
Dependency coherency updates
2be61d1
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 16.0.5-alpha.1.23408.1 -> To Version 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
@akoeplinger
akoeplinger
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@mmitche
mmitche
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@MichaelSimons
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 23, 2023

Closed

@MichaelSimons
MichaelSimons
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@NikolaMilosavljevic - Can you help investigate/provide guidance? TIA
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 23, 2023

Copy link


Copy Markdown

Contributor
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@NikolaMilosavljevic - Can you help investigate/provide guidance? TIA
I've reproed this locally - investigating...
NikolaMilosavljevic
NikolaMilosavljevic
reviewed
Aug 23, 2023
View reviewed changes
Comment threadsrc/tools/illink/Directory.Build.props

Comment on lines

-2
 to 
-5

 <PropertyGroup>
 <!-- Don't use the prebuilt illink that is referenced by Arcade. -->
 <UsingToolMicrosoftNetILLinkTasks>false</UsingToolMicrosoftNetILLinkTasks>
 </PropertyGroup>
@NikolaMilosavljevicNikolaMilosavljevicAug 23, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the root cause of source-build failure. It is causing the usage of prebuilt version of Microsoft.Net.ILLink.Tasks package. Is this accidental? @akoeplinger @vikoeplinger
@sbomersbomerAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes intentionally use the version of ILLink.Tasks that is referenced by the SDK in global.json (BundledNETCoreAppPackageVersion in https://github.com/dotnet/runtime/pull/90517/files#diff-361b24a1b39d592c236441b48457113d003aeb3bc03df5bbc0318fd0b2e05cd2R50-R53).
This packagereference is effectively equivalent to building with the SDK, with <UsingToolMicrosoftNetILLinkTasks>false</UsingToolMicrosoftNetILLinkTasks>. The packagereference was required as a workaround (see these comments), but I'd expect that for the purpose of source-build it is no different.
@MichaelSimonsMichaelSimonsAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
I'll validate full product build locally.
@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
I'll validate full product build locally.
Full source-build is showing 20 prebuilts but not the one for Microsoft.Net.ILLink.Tasks. I'm unsure about this - @MichaelSimons
Here's the full list of prebuilts:
 <Usage Id="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.Common" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.CSharp" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.Extensions.DependencyInjection" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.Logging" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.Extensions.Options" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.Primitives" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.Current.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.net6.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.net7.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="System.Composition" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.AttributedModel" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Convention" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Hosting" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Runtime" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.TypedParts" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />

@MichaelSimonsMichaelSimonsAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one direct dependency coming from runtime
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />

This is a result of #90340 which was addressed in #91006. I suspect the commit tested didn't have the fix. I think the test has proven this will not introduce a prebuilt in the product level source-build.
@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one direct dependency coming from runtime
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />

This is a result of #90340 which was addressed in #91006. I suspect the commit tested didn't have the fix. I think the test has proven this will not introduce a prebuilt in the product level source-build.
Thanks - I'll work on a fix to add exclusion for ILLink.Tasks.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230824.6
e7fd0ef
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 9.0.100-alpha.1.23424.6
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
I've pulled the latest changes and now I'm seeing two prebuilts:
Microsoft.DotNet.ApiCompat.Task.9.0.100-alpha.1.23423.2
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

@MichaelSimons
MichaelSimons
commented
Aug 24, 2023

Copy link


Copy Markdown

Member
Microsoft.DotNet.ApiCompat.Task.9.0.100-alpha.1.23423.2
Something odd about this one because the version.details.xml is referencing a newer version - 9.0.100-alpha.1.23424.6
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Microsoft.DotNet.ApiCompat.Task
Doing another build - this might have been an issue with stale cache.
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Microsoft.DotNet.ApiCompat.Task
Doing another build - this might have been an issue with stale cache.
I plan to try this for ILLink.Tasks:
 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/$(BundledNETCoreAppPackageVersion)" />

@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Microsoft.DotNet.ApiCompat.Task
Doing another build - this might have been an issue with stale cache.
I plan to try this for ILLink.Tasks:
 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/$(BundledNETCoreAppPackageVersion)" />

OK - that didn't work - how about?
 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/*8.*" />

@MichaelSimons
MichaelSimons
commented
Aug 24, 2023

Copy link


Copy Markdown

Member
Your only option is wild cards - you can't reference msbuild props. I think 8.* is acceptable.
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Pushed the fix for source-build leg.
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 25, 2023

Closed

@ViktorHofer
ViktorHofer
merged commit 699ffbe
into
mainAug 25, 2023
@ViktorHofer
ViktorHofer
deleted the

darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c

branch
August 25, 2023 08:22
@sbomersbomer
mentioned this pull request
Aug 30, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 24, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@sbomersbomersbomer left review comments
@MichaelSimonsMichaelSimonsMichaelSimons left review comments
@lewinglewinglewing approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar
@carlossanlopcarlossanlopAwaiting requested review from carlossanlop
@radicalradicalAwaiting requested review from radical

+1 more reviewer

@NikolaMilosavljevicNikolaMilosavljevicNikolaMilosavljevic left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

arch-arm64area-codeflowfor labeling automated codeflowarea-Tools-ILLink.NET linker development as well as trimming analyzers

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

10 participants

@ViktorHofer@sbomer@agocke@vitek-karas@lewing@akoeplinger@mmitche@MichaelSimons@NikolaMilosavljevic@radical

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[main] Update dependencies from 10 repositories - #90517
Merged
ViktorHofer merged 43 commits into
mainfrom 
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
Aug 25, 2023
Merged
[main] Update dependencies from 10 repositories#90517
ViktorHofer merged 43 commits into
mainfrom 
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Aug 14, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20230821.1
  • Date Produced: August 21, 2023 9:46:31 AM UTC
  • Commit: 8b274d3
  • Branch: refs/heads/main
From https://github.com/dotnet/source-build-reference-packages
  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20230814.1
  • Date Produced: August 14, 2023 1:05:16 PM UTC
  • Commit: 45f5554ac6813e1e155c47fd80ec146c684f65e8
  • Branch: refs/heads/main
From https://github.com/dotnet/sdk
  • Subscription: 736b3d22-d45c-4c36-de26-08db63374d9b
  • Build: 20230824.6
  • Date Produced: August 24, 2023 10:41:18 AM UTC
  • Commit: 0a8f9006fa76ee546ca68362b38fe2c70ef7b7f9
  • Branch: refs/heads/main
From https://github.com/dotnet/emsdk
  • Subscription: c22d5069-447c-4252-29fd-08d90a7bb4bc
  • Build: 20230822.1
  • Date Produced: August 22, 2023 7:53:47 PM UTC
  • Commit: 028de23143a75e43951be6275278d4dbc8520258
  • Branch: refs/heads/main
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency

attribute were produced in a build used as input to the parent dependency's build.

See Dependency Description Format
  • Coherency Updates:

    • runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 16.0.5-alpha.1.23408.1 to 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport)
From https://github.com/dotnet/arcade
  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20230822.1
  • Date Produced: August 22, 2023 8:50:38 PM UTC
  • Commit: 4d9945d230fdd8324ce16a31c7dbd74e27a0fc9b
  • Branch: refs/heads/main
From https://github.com/dotnet/icu
  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20230821.1
  • Date Produced: August 21, 2023 2:30:01 PM UTC
  • Commit: cec51e5eba13df460746046a2aca07bcf6bb2f8e
  • Branch: refs/heads/dotnet/main
From https://github.com/dotnet/cecil
  • Subscription: bb5d2106-9fd3-425f-0abc-08daad65778c
  • Build: 20230821.1
  • Date Produced: August 21, 2023 1:12:18 PM UTC
  • Commit: d412306c1514a26737574838900052d8758da5be
  • Branch: refs/heads/main
From https://github.com/dotnet/xharness
  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20230821.1
  • Date Produced: August 21, 2023 12:57:41 PM UTC
  • Commit: 1c09ef5b669c11e1aeca92089d0c1e4408169582
  • Branch: refs/heads/main
From https://github.com/dotnet/runtime-assets
  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20230823.1
  • Date Produced: August 23, 2023 9:28:54 AM UTC
  • Commit: b901ed157568022c7b531d65b2bd28333621a6df
  • Branch: refs/heads/main
From https://github.com/dotnet/hotreload-utils
  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20230821.1
  • Date Produced: August 22, 2023 1:49:27 AM UTC
  • Commit: e02247b9b7ec1d9e407312342147d8587a8ca20e
  • Branch: refs/heads/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2023…
2b860da
…0814.1
Microsoft.DotNet.ILCompiler , Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
From Version 8.0.0-rc.1.23406.6 -> To Version 8.0.0-rc.1.23414.1
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
Aug 14, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/source-build-refer…
f55dffe
…ence-packages build 20230808.2
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23381.3 -> To Version 8.0.0-alpha.1.23408.2
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packagesAug 14, 2023
@lewinglewing
added
the 
area-Tools-ILLink
.NET linker development as well as trimming analyzers
label
Aug 14, 2023
@ghost
ghost
commented
Aug 14, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas

See info in area-owners.md if you want to be subscribed.
Issue Details
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20230814.1
  • Date Produced: August 14, 2023 10:35:21 AM UTC
  • Commit: 8986374
  • Branch: refs/heads/main
From https://github.com/dotnet/source-build-reference-packages
  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20230808.2
  • Date Produced: August 8, 2023 7:05:41 PM UTC
  • Commit: 41f1a158d460e11ded6cffd6340f9e671e2b0a5c
  • Branch: refs/heads/main
Author:dotnet-maestro[bot]
Assignees:-
Labels:
area-codeflow, area-Tools-ILLink
Milestone:-
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230814.3
54f661f
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-rc.1.23414.3
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdkAug 14, 2023
@ViktorHofer
ViktorHofer
commented
Aug 14, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@sbomer looks like the illink task invocation in illink.targets now complains about the SDK not being recent enough:
App: D:\a_work\1\s.packages\microsoft.net.illink.tasks\8.0.0-rc.1.23414.1\tools\net8.0\illink.dll

Framework: 'Microsoft.NETCore.App', version '8.0.0-rc.1.23414.1' (x64)
Probably because of c13739b
@sbomer
sbomer
commented
Aug 14, 2023

Copy link


Copy Markdown

Member
Looks like we're still using the latest ILLink package for the framework linking step. We can do one of:
  1. Use the SDK version here (unset UsingToolMicrosoftNetILLinkTasks)
  2. Use live illink (means we need to build ILLink before building the framework)
  3. Implement a workaround to use latest ILLink package with a custom runtimeconfig
I think 2. would be ideal, but might be better to do as a separate change. I suggest 1. as a short-term fix (I think this is fine for .NET 8 assuming we'll be using an RC version to build the final product). @vitek-karas@ViktorHofer@agocke any thoughts?
@agocke
agocke
commented
Aug 14, 2023

Copy link


Copy Markdown

Member
(1) sounds fine as a quick fix, and I agree (2) is ideal. I would even say, if we have time, I would consider taking (2) as an infra-only change for .NET 8. But unblocking dependency flow is even more important.
@sbomersbomer
mentioned this pull request
Aug 14, 2023

Closed

@sbomer
sbomerforce-pushed
the
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
branch
from
02dd28c to
8c0dbf1CompareAugust 14, 2023 23:41
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202308…
2de3e36
…14.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.1.23411.2 -> To Version 8.0.0-rc.1.23414.1
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdkAug 15, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 15, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
2be781b
…814.5
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23411.1 -> To Version 8.0.0-beta.23414.5
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23408.1 -> To Version 1.0.0-beta.23412.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcadeAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/icubuild 20230814.4
b736874
Microsoft.NETCore.Runtime.ICU.Transport
From Version 8.0.0-rc.1.23407.2 -> To Version 9.0.0-alpha.1.23414.4
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icuAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/cecilbuild 202308…
67ff521
…14.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23407.2 -> To Version 0.11.4-alpha.23414.1
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecilAug 15, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230815.5
bd9bd3a
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-rc.1.23415.5
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/sdk dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecil[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/emsdk dotnet/arcade dotnet/icu dotnet/cecil dotnet/sdkAug 15, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 15, 2023

Closed

@akoeplingerakoeplinger
mentioned this pull request
Aug 23, 2023
 Closed

akoeplingerand others
added 8 commits
August 23, 2023 11:25
@akoeplinger
Remove unused parameter (dotnet/arcade#13961)
6c498c6
@akoeplinger
Try to fix NativeAOT helix correlation payload issue
726b12f
@akoeplinger
Revert a change
53d3799
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
734595b
…822.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23411.1 -> To Version 8.0.0-beta.23422.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23408.1 -> To Version 1.0.0-beta.23418.1 (parent: Microsoft.DotNet.Helix.Sdk
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
949836f
…ld 20230823.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23408.1 -> To Version 8.0.0-beta.23423.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202308…
e5e460b
…22.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
From Version 9.0.0-alpha.1.23415.2 -> To Version 9.0.0-alpha.1.23422.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230823.2
4c1900f
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 9.0.100-alpha.1.23423.2
@dotnet-maestro
Dependency coherency updates
2be61d1
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 16.0.5-alpha.1.23408.1 -> To Version 16.0.5-alpha.1.23414.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
@akoeplinger
akoeplinger
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@mmitche
mmitche
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@MichaelSimons
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 23, 2023

Closed

@MichaelSimons
MichaelSimons
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@NikolaMilosavljevic - Can you help investigate/provide guidance? TIA
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 23, 2023

Copy link


Copy Markdown

Contributor
Looks like the only real failure left is from the source build leg:
.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23422.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

This kind of makes sense since we have a PackageReference to that package now, but we're using the same version that ships inside of the SDK. Not sure what to do about that one.
@NikolaMilosavljevic - Can you help investigate/provide guidance? TIA
I've reproed this locally - investigating...
NikolaMilosavljevic
NikolaMilosavljevic
reviewed
Aug 23, 2023
View reviewed changes
Comment threadsrc/tools/illink/Directory.Build.props

Comment on lines

-2
 to 
-5

 <PropertyGroup>
 <!-- Don't use the prebuilt illink that is referenced by Arcade. -->
 <UsingToolMicrosoftNetILLinkTasks>false</UsingToolMicrosoftNetILLinkTasks>
 </PropertyGroup>
@NikolaMilosavljevicNikolaMilosavljevicAug 23, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the root cause of source-build failure. It is causing the usage of prebuilt version of Microsoft.Net.ILLink.Tasks package. Is this accidental? @akoeplinger @vikoeplinger
@sbomersbomerAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes intentionally use the version of ILLink.Tasks that is referenced by the SDK in global.json (BundledNETCoreAppPackageVersion in https://github.com/dotnet/runtime/pull/90517/files#diff-361b24a1b39d592c236441b48457113d003aeb3bc03df5bbc0318fd0b2e05cd2R50-R53).
This packagereference is effectively equivalent to building with the SDK, with <UsingToolMicrosoftNetILLinkTasks>false</UsingToolMicrosoftNetILLinkTasks>. The packagereference was required as a workaround (see these comments), but I'd expect that for the purpose of source-build it is no different.
@MichaelSimonsMichaelSimonsAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
I'll validate full product build locally.
@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
I'll validate full product build locally.
Full source-build is showing 20 prebuilts but not the one for Microsoft.Net.ILLink.Tasks. I'm unsure about this - @MichaelSimons
Here's the full list of prebuilts:
 <Usage Id="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.Common" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.CSharp" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="Microsoft.Extensions.DependencyInjection" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.Logging" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" IsDirectDependency="true" />
<Usage Id="Microsoft.Extensions.Options" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.Extensions.Primitives" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.Current.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.net6.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="Microsoft.NET.Workload.Mono.ToolChain.net7.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
<Usage Id="System.Composition" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.AttributedModel" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Convention" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Hosting" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.Runtime" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
<Usage Id="System.Composition.TypedParts" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />

@MichaelSimonsMichaelSimonsAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one direct dependency coming from runtime
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />

This is a result of #90340 which was addressed in #91006. I suspect the commit tested didn't have the fix. I think the test has proven this will not introduce a prebuilt in the product level source-build.
@NikolaMilosavljevicNikolaMilosavljevicAug 24, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one direct dependency coming from runtime
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />

This is a result of #90340 which was addressed in #91006. I suspect the commit tested didn't have the fix. I think the test has proven this will not introduce a prebuilt in the product level source-build.
Thanks - I'll work on a fix to add exclusion for ILLink.Tasks.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/sdkbuild 20230824.6
e7fd0ef
Microsoft.DotNet.ApiCompat.Task
From Version 8.0.100-preview.7.23329.3 -> To Version 9.0.100-alpha.1.23424.6
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
I've pulled the latest changes and now I'm seeing two prebuilts:
Microsoft.DotNet.ApiCompat.Task.9.0.100-alpha.1.23423.2
Microsoft.NET.ILLink.Tasks.8.0.0-preview.7.23375.6

@MichaelSimons
MichaelSimons
commented
Aug 24, 2023

Copy link


Copy Markdown

Member
Microsoft.DotNet.ApiCompat.Task.9.0.100-alpha.1.23423.2
Something odd about this one because the version.details.xml is referencing a newer version - 9.0.100-alpha.1.23424.6
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Microsoft.DotNet.ApiCompat.Task
Doing another build - this might have been an issue with stale cache.
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Microsoft.DotNet.ApiCompat.Task
Doing another build - this might have been an issue with stale cache.
I plan to try this for ILLink.Tasks:
 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/$(BundledNETCoreAppPackageVersion)" />

@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Microsoft.DotNet.ApiCompat.Task
Doing another build - this might have been an issue with stale cache.
I plan to try this for ILLink.Tasks:
 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/$(BundledNETCoreAppPackageVersion)" />

OK - that didn't work - how about?
 <!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/*8.*" />

@MichaelSimons
MichaelSimons
commented
Aug 24, 2023

Copy link


Copy Markdown

Member
Your only option is wild cards - you can't reference msbuild props. I think 8.* is acceptable.
@NikolaMilosavljevic
NikolaMilosavljevic
commented
Aug 24, 2023

Copy link


Copy Markdown

Contributor
Pushed the fix for source-build leg.
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 25, 2023

Closed

@ViktorHofer
ViktorHofer
merged commit 699ffbe
into
mainAug 25, 2023
@ViktorHofer
ViktorHofer
deleted the

darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c

branch
August 25, 2023 08:22
@sbomersbomer
mentioned this pull request
Aug 30, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 24, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@sbomersbomersbomer left review comments
@MichaelSimonsMichaelSimonsMichaelSimons left review comments
@lewinglewinglewing approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar
@carlossanlopcarlossanlopAwaiting requested review from carlossanlop
@radicalradicalAwaiting requested review from radical

+1 more reviewer

@NikolaMilosavljevicNikolaMilosavljevicNikolaMilosavljevic left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

arch-arm64area-codeflowfor labeling automated codeflowarea-Tools-ILLink.NET linker development as well as trimming analyzers

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

10 participants

@ViktorHofer@sbomer@agocke@vitek-karas@lewing@akoeplinger@mmitche@MichaelSimons@NikolaMilosavljevic@radical