') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [release/8.0] Update Get/SetFieldValue to Account for EnC by github-actions[bot] · Pull Request #90623 · dotnet/runtime · GitHub
Skip to content

[release/8.0] Update Get/SetFieldValue to Account for EnC - #90623

Merged
carlossanlop merged 3 commits into
release/8.0from
backport/pr-90446-to-release/8.0-rc1
Aug 17, 2023
Merged

[release/8.0] Update Get/SetFieldValue to Account for EnC#90623
carlossanlop merged 3 commits into
release/8.0from
backport/pr-90446-to-release/8.0-rc1

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Aug 15, 2023

Copy link
Copy Markdown
Contributor

Backport of #90446 to release/8.0-rc1

/cc @mikelle-rogers

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghostghost added the area-VM-coreclr label Aug 15, 2023
@AaronRobinsonMSFT

AaronRobinsonMSFT commented Aug 15, 2023

Copy link
Copy Markdown
Member

Do you also want to address #90446 (comment) in this backport?

jeffschwMSFT
jeffschwMSFT approved these changes Aug 15, 2023
View reviewed changes

@jeffschwMSFTjeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in RC1

@build-analysisbuild-analysisBot mentioned this pull request Aug 15, 2023
Closed
@carlossanlop

carlossanlop commented Aug 16, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

approved. we will take for consideration in RC1

With the recent RC guidance change, we need the template filled out and an email to Tactics requesting approval. @mikelle-rogers can you please do that?

Note: Please don't click on "Update branch". The CI will restart. I can bypass it and merge the PR for you.

@mikelle-rogers

mikelle-rogers commented Aug 17, 2023

Copy link
Copy Markdown
Member

We are putting this into RC2

@mikelle-rogersmikelle-rogers changed the title [release/8.0-rc1] Update Get/SetFieldValue to Account for EnC[release/8.0] Update Get/SetFieldValue to Account for EnCAug 17, 2023
@mikelle-rogersmikelle-rogers changed the title [release/8.0] Update Get/SetFieldValue to Account for EnC[release/8.0-rc1] Update Get/SetFieldValue to Account for EnCAug 17, 2023
@mikelle-rogers
mikelle-rogers changed the base branch from release/8.0-rc1 to release/8.0August 17, 2023 17:30
@mikelle-rogersmikelle-rogers changed the title [release/8.0-rc1] Update Get/SetFieldValue to Account for EnC[release/8.0] Update Get/SetFieldValue to Account for EnCAug 17, 2023
@carlossanlopcarlossanlop added the Servicing-approved Approved for servicing release label Aug 17, 2023
@carlossanlop

carlossanlop commented Aug 17, 2023

Copy link
Copy Markdown
Contributor

Failure is known and unrelated: #90593

Since this is now targeting RC2, the current approvals are sufficient to merge.

@carlossanlop
carlossanlop merged commit 515e5d1 into release/8.0Aug 17, 2023
@carlossanlop
carlossanlop deleted the backport/pr-90446-to-release/8.0-rc1 branch August 17, 2023 21:38
@ghostghost locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes
@jeffschwMSFTjeffschwMSFTjeffschwMSFT approved these changes

Assignees

No one assigned

Labels

area-VM-coreclrServicing-approvedApproved for servicing release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AaronRobinsonMSFT@carlossanlop@mikelle-rogers@jkotas@jeffschwMSFT