Skip to content

Update Get/SetFieldValue to Account for EnC - #90446

Merged
mikelle-rogers merged 3 commits into
dotnet:mainfrom
mikelle-rogers:dev/mirogers/enc_getValue
Aug 15, 2023
Merged

Update Get/SetFieldValue to Account for EnC#90446
mikelle-rogers merged 3 commits into
dotnet:mainfrom
mikelle-rogers:dev/mirogers/enc_getValue

Conversation

@mikelle-rogers

@mikelle-rogersmikelle-rogers commented Aug 12, 2023

Copy link
Copy Markdown
Member

Fixes#76702

@mikelle-rogersmikelle-rogers self-assigned this Aug 12, 2023
@ghost

ghost commented Aug 12, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #76702

Author:mikelle-rogers
Assignees:mikelle-rogers
Labels:

area-Diagnostics-coreclr

Milestone:-

AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Aug 12, 2023
View reviewed changes
Comment threadsrc/coreclr/vm/invokeutil.cpp
Comment threadsrc/coreclr/vm/invokeutil.cpp Outdated
Comment threadsrc/coreclr/vm/invokeutil.cpp Outdated
Comment threadsrc/coreclr/vm/invokeutil.cpp Outdated
jkotas
jkotas reviewed Aug 12, 2023
View reviewed changes
Comment threadsrc/coreclr/vm/invokeutil.cpp Outdated
jkotas
jkotas reviewed Aug 12, 2023
View reviewed changes
Comment threadsrc/coreclr/vm/invokeutil.cpp Outdated
jkotas
jkotas reviewed Aug 14, 2023
View reviewed changes
Comment threadsrc/coreclr/vm/invokeutil.cpp Outdated
jkotas
jkotas approved these changes Aug 14, 2023
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Aug 14, 2023
View reviewed changes

@AaronRobinsonMSFTAaronRobinsonMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mikelle-rogers
mikelle-rogers merged commit 337e95e into dotnet:mainAug 15, 2023
@lambdageek

lambdageek commented Aug 15, 2023

Copy link
Copy Markdown
Member

@mikelle-rogers sorry I didn't see this PR earlier. You should also remove the ActiveIssue here:

runtime/src/libraries/System.Runtime.Loader/tests/ApplyUpdateTest.cs

Line 326 in 337e95e

[ActiveIssue("https://github.com/dotnet/runtime/issues/76702",TestRuntimes.CoreCLR)]

@mikelle-rogers

mikelle-rogers commented Aug 15, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to release/8.0-rc1

@github-actions

github-actionsBot commented Aug 15, 2023

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5870163775

@github-actions

github-actionsBot commented Aug 15, 2023

Copy link
Copy Markdown
Contributor

@mikelle-rogers an error occurred while backporting to release/8.0-rc1, please check the run log for details!

Error: @mikelle-rogers is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=mikelle-rogers

@mikelle-rogers

mikelle-rogers commented Aug 15, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to release/8.0-rc1

@github-actions

github-actionsBot commented Aug 15, 2023

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5870369270

@github-actionsgithub-actionsBot mentioned this pull request Aug 15, 2023
Merged
@mikelle-rogersmikelle-rogers added this to the 8.0.0 milestone Aug 15, 2023
@ghostghost locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes

Assignees

@mikelle-rogersmikelle-rogers

Labels

area-Diagnostics-coreclr

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR

4 participants

@mikelle-rogers@lambdageek@jkotas@AaronRobinsonMSFT