[mono] Reenable C4244 MSVC warning and fix occurrences - #91395

Merged
akoeplinger merged 8 commits into
dotnet:mainfrom
akoeplinger:fix-warning
Sep 5, 2023
Merged

[mono] Reenable C4244 MSVC warning and fix occurrences#91395
akoeplinger merged 8 commits into
dotnet:mainfrom
akoeplinger:fix-warning

Conversation

@akoeplinger

@akoeplingerakoeplinger commented Aug 31, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#91249

We originally fixed the warnings with #69236 but due to add_compile_options() calls in zlib.cmake all of the mono native libs - not just the zlib components - were being built with C4244 disabled and a few couple more leaked in.

This fixes the occurrences and reworks the .cmake files a bit to hopefully prevent this in the future.

@ghostghost added the area-Build-mono label Aug 31, 2023
@build-analysisbuild-analysisBot mentioned this pull request Aug 31, 2023
Closed
@akoeplinger
akoeplinger marked this pull request as ready for review August 31, 2023 22:31
akoeplinger
akoeplinger commented Aug 31, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-runtime.c Outdated
This was referenced Sep 1, 2023
Closed
Closed
lateralusX
lateralusX reviewed Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-runtime.c Outdated
Comment threadsrc/mono/mono/eventpipe/ep-rt-mono-runtime-provider.c Outdated
Comment threadsrc/mono/mono/eventpipe/ep-rt-mono-runtime-provider.c Outdated
Comment threadsrc/mono/mono/metadata/icall.c Outdated
Comment threadsrc/mono/mono/mini/graph.c Outdated
Comment threadsrc/mono/mono/mini/helpers.c Outdated
Comment threadsrc/mono/mono/mini/interp/transform.c Outdated
Comment threadsrc/mono/mono/mini/interp/transform.c Outdated
Comment threadsrc/mono/mono/mini/interp/transform.c Outdated
Comment threadsrc/mono/mono/mini/interp/transform.c Outdated
fanyang-mono
fanyang-mono reviewed Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/graph.c
fanyang-mono
fanyang-mono reviewed Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/helpers.c
fanyang-mono
fanyang-mono reviewed Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/mini-llvm-cpp.cpp Outdated
fanyang-mono
fanyang-mono approved these changes Sep 1, 2023
View reviewed changes

@fanyang-monofanyang-mono left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the change looks good to me.

@build-analysisbuild-analysisBot mentioned this pull request Sep 4, 2023
Closed
lateralusX
lateralusX reviewed Sep 5, 2023
View reviewed changes

@lateralusXlateralusX left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, great work. Mainly a couple of additional places to use different conversion macros or opportunity to add a new more precise conversion macro.

The only thing to look out for is the mword SGenDescriptor related changes, mword is based on host size while SGenDescriptor is based on target size, so changing the type we will need to make sure that it doesn't introduce changed behavior or potentially loss of precision in case you have different host/target pointer sizes.

Comment threadsrc/mono/mono/metadata/sgen-client-mono.h
Comment threadsrc/mono/mono/metadata/sgen-mono.c
Comment threadsrc/mono/mono/mini/aot-compiler.c Outdated
Comment threadsrc/mono/mono/mini/aot-compiler.c Outdated
Comment threadsrc/mono/mono/mini/aot-compiler.c Outdated
Comment threadsrc/mono/mono/mini/method-to-ir.c Outdated
Comment threadsrc/mono/mono/mini/mini-llvm.c Outdated
Comment threadsrc/mono/mono/mini/mini-x86.c Outdated
Comment threadsrc/mono/mono/sgen/sgen-scan-object.h
* object contained references. If not, the value of "start" should
* be considered undefined after executing this code. The object's
* GC descriptor must be in the variable "mword desc".
* GC descriptor must be in the variable "SgenDescriptor desc".

@lateralusXlateralusXSep 5, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are different type depending on host/target, mword is host machine word while SgenDescriptor is target machine word, have you validated that calls only uses SgenDescriptor and we don't end up casting mword to SgenDescriptor or SgenDescriptor to mword since that can lead to data loss depending on host/target combinations or depend on size of desc in logic etc.

@akoeplingerakoeplingerSep 5, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I checked all the callsites and they are all called with SgenDescriptor type without casting.

Comment threadsrc/mono/mono/metadata/sgen-mono.c
@akoeplingerakoeplinger mentioned this pull request Sep 5, 2023
Merged
This was referenced Sep 5, 2023
Open
Closed
@akoeplinger
akoeplinger merged commit 4c0a7c4 into dotnet:mainSep 5, 2023
@akoeplinger
akoeplinger deleted the fix-warning branch September 5, 2023 22:24
@ghostghost locked as resolved and limited conversation to collaborators Oct 6, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lateralusXlateralusXlateralusX approved these changes
@fanyang-monofanyang-monofanyang-mono approved these changes
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@lambdageeklambdageekAwaiting requested review from lambdageek
@vargazvargazAwaiting requested review from vargaz
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmiloskotlarmilos is a code owner
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

@akoeplingerakoeplinger

Labels

area-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mono build disables required warning C4244 under MSVC

3 participants

@akoeplinger@lateralusX@fanyang-mono
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[mono] Reenable C4244 MSVC warning and fix occurrences - #91395
Merged
akoeplinger merged 8 commits into
dotnet:mainfrom 
akoeplinger:fix-warning
Sep 5, 2023
Merged
[mono] Reenable C4244 MSVC warning and fix occurrences#91395
akoeplinger merged 8 commits into
dotnet:mainfrom 
akoeplinger:fix-warning
Conversation
@akoeplinger
@akoeplingerakoeplinger
commented
Aug 31, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Fixes#91249
We originally fixed the warnings with #69236 but due to add_compile_options() calls in zlib.cmake all of the mono native libs - not just the zlib components - were being built with C4244 disabled and a few couple more leaked in.
This fixes the occurrences and reworks the .cmake files a bit to hopefully prevent this in the future.
@ghostghost
added
the 
area-Build-mono

label
Aug 31, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 31, 2023

Closed

@akoeplinger
akoeplinger
marked this pull request as ready for review
August 31, 2023 22:31
akoeplinger
akoeplinger
commented
Aug 31, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-runtime.c
Outdated


This was referenced Sep 1, 2023

Closed


Closed

lateralusX
lateralusX
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-runtime.c
Outdated

Comment threadsrc/mono/mono/eventpipe/ep-rt-mono-runtime-provider.c
Outdated

Comment threadsrc/mono/mono/eventpipe/ep-rt-mono-runtime-provider.c
Outdated

Comment threadsrc/mono/mono/metadata/icall.c
Outdated

Comment threadsrc/mono/mono/mini/graph.c
Outdated

Comment threadsrc/mono/mono/mini/helpers.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

fanyang-mono
fanyang-mono
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/graph.c
fanyang-mono
fanyang-mono
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/helpers.c
fanyang-mono
fanyang-mono
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/mini-llvm-cpp.cpp
Outdated

fanyang-mono
fanyang-mono
approved these changes
Sep 1, 2023
View reviewed changes
@fanyang-monofanyang-mono
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the change looks good to me.
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 4, 2023

Closed

lateralusX
lateralusX
reviewed
Sep 5, 2023
View reviewed changes
@lateralusXlateralusX
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, great work. Mainly a couple of additional places to use different conversion macros or opportunity to add a new more precise conversion macro.
The only thing to look out for is the mword SGenDescriptor related changes, mword is based on host size while SGenDescriptor is based on target size, so changing the type we will need to make sure that it doesn't introduce changed behavior or potentially loss of precision in case you have different host/target pointer sizes.
Comment threadsrc/mono/mono/metadata/sgen-client-mono.h
Comment threadsrc/mono/mono/metadata/sgen-mono.c
Comment threadsrc/mono/mono/mini/aot-compiler.c
Outdated

Comment threadsrc/mono/mono/mini/aot-compiler.c
Outdated

Comment threadsrc/mono/mono/mini/aot-compiler.c
Outdated

Comment threadsrc/mono/mono/mini/method-to-ir.c
Outdated

Comment threadsrc/mono/mono/mini/mini-llvm.c
Outdated

Comment threadsrc/mono/mono/mini/mini-x86.c
Outdated

Comment threadsrc/mono/mono/sgen/sgen-scan-object.h
 * object contained references. If not, the value of "start" should
 * be considered undefined after executing this code. The object's
 * GC descriptor must be in the variable "mword desc".
 * GC descriptor must be in the variable "SgenDescriptor desc".
@lateralusXlateralusXSep 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are different type depending on host/target, mword is host machine word while SgenDescriptor is target machine word, have you validated that calls only uses SgenDescriptor and we don't end up casting mword to SgenDescriptor or SgenDescriptor to mword since that can lead to data loss depending on host/target combinations or depend on size of desc in logic etc.
@akoeplingerakoeplingerSep 5, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I checked all the callsites and they are all called with SgenDescriptor type without casting.
Comment threadsrc/mono/mono/metadata/sgen-mono.c
@akoeplingerakoeplinger
mentioned this pull request
Sep 5, 2023
 Merged


This was referenced Sep 5, 2023

Open


Closed

@akoeplinger
akoeplinger
merged commit 4c0a7c4
into
dotnet:mainSep 5, 2023
@akoeplinger
akoeplinger
deleted the

fix-warning

branch
September 5, 2023 22:24
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 6, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lateralusXlateralusXlateralusX approved these changes
@fanyang-monofanyang-monofanyang-mono approved these changes
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@lambdageeklambdageekAwaiting requested review from lambdageek
@vargazvargazAwaiting requested review from vargaz
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmiloskotlarmilos is a code owner
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

@akoeplingerakoeplinger

Labels

area-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Mono build disables required warning C4244 under MSVC


3 participants

@akoeplinger@lateralusX@fanyang-mono

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[mono] Reenable C4244 MSVC warning and fix occurrences - #91395
Merged
akoeplinger merged 8 commits into
dotnet:mainfrom 
akoeplinger:fix-warning
Sep 5, 2023
Merged
[mono] Reenable C4244 MSVC warning and fix occurrences#91395
akoeplinger merged 8 commits into
dotnet:mainfrom 
akoeplinger:fix-warning
Conversation
@akoeplinger
@akoeplingerakoeplinger
commented
Aug 31, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Fixes#91249
We originally fixed the warnings with #69236 but due to add_compile_options() calls in zlib.cmake all of the mono native libs - not just the zlib components - were being built with C4244 disabled and a few couple more leaked in.
This fixes the occurrences and reworks the .cmake files a bit to hopefully prevent this in the future.
@ghostghost
added
the 
area-Build-mono

label
Aug 31, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 31, 2023

Closed

@akoeplinger
akoeplinger
marked this pull request as ready for review
August 31, 2023 22:31
akoeplinger
akoeplinger
commented
Aug 31, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-runtime.c
Outdated


This was referenced Sep 1, 2023

Closed


Closed

lateralusX
lateralusX
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-runtime.c
Outdated

Comment threadsrc/mono/mono/eventpipe/ep-rt-mono-runtime-provider.c
Outdated

Comment threadsrc/mono/mono/eventpipe/ep-rt-mono-runtime-provider.c
Outdated

Comment threadsrc/mono/mono/metadata/icall.c
Outdated

Comment threadsrc/mono/mono/mini/graph.c
Outdated

Comment threadsrc/mono/mono/mini/helpers.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

fanyang-mono
fanyang-mono
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/graph.c
fanyang-mono
fanyang-mono
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/helpers.c
fanyang-mono
fanyang-mono
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/mini-llvm-cpp.cpp
Outdated

fanyang-mono
fanyang-mono
approved these changes
Sep 1, 2023
View reviewed changes
@fanyang-monofanyang-mono
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the change looks good to me.
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 4, 2023

Closed

lateralusX
lateralusX
reviewed
Sep 5, 2023
View reviewed changes
@lateralusXlateralusX
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, great work. Mainly a couple of additional places to use different conversion macros or opportunity to add a new more precise conversion macro.
The only thing to look out for is the mword SGenDescriptor related changes, mword is based on host size while SGenDescriptor is based on target size, so changing the type we will need to make sure that it doesn't introduce changed behavior or potentially loss of precision in case you have different host/target pointer sizes.
Comment threadsrc/mono/mono/metadata/sgen-client-mono.h
Comment threadsrc/mono/mono/metadata/sgen-mono.c
Comment threadsrc/mono/mono/mini/aot-compiler.c
Outdated

Comment threadsrc/mono/mono/mini/aot-compiler.c
Outdated

Comment threadsrc/mono/mono/mini/aot-compiler.c
Outdated

Comment threadsrc/mono/mono/mini/method-to-ir.c
Outdated

Comment threadsrc/mono/mono/mini/mini-llvm.c
Outdated

Comment threadsrc/mono/mono/mini/mini-x86.c
Outdated

Comment threadsrc/mono/mono/sgen/sgen-scan-object.h
 * object contained references. If not, the value of "start" should
 * be considered undefined after executing this code. The object's
 * GC descriptor must be in the variable "mword desc".
 * GC descriptor must be in the variable "SgenDescriptor desc".
@lateralusXlateralusXSep 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are different type depending on host/target, mword is host machine word while SgenDescriptor is target machine word, have you validated that calls only uses SgenDescriptor and we don't end up casting mword to SgenDescriptor or SgenDescriptor to mword since that can lead to data loss depending on host/target combinations or depend on size of desc in logic etc.
@akoeplingerakoeplingerSep 5, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I checked all the callsites and they are all called with SgenDescriptor type without casting.
Comment threadsrc/mono/mono/metadata/sgen-mono.c
@akoeplingerakoeplinger
mentioned this pull request
Sep 5, 2023
 Merged


This was referenced Sep 5, 2023

Open


Closed

@akoeplinger
akoeplinger
merged commit 4c0a7c4
into
dotnet:mainSep 5, 2023
@akoeplinger
akoeplinger
deleted the

fix-warning

branch
September 5, 2023 22:24
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 6, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lateralusXlateralusXlateralusX approved these changes
@fanyang-monofanyang-monofanyang-mono approved these changes
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@lambdageeklambdageekAwaiting requested review from lambdageek
@vargazvargazAwaiting requested review from vargaz
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmiloskotlarmilos is a code owner
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

@akoeplingerakoeplinger

Labels

area-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Mono build disables required warning C4244 under MSVC


3 participants

@akoeplinger@lateralusX@fanyang-mono

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[mono] Reenable C4244 MSVC warning and fix occurrences - #91395
Merged
akoeplinger merged 8 commits into
dotnet:mainfrom 
akoeplinger:fix-warning
Sep 5, 2023
Merged
[mono] Reenable C4244 MSVC warning and fix occurrences#91395
akoeplinger merged 8 commits into
dotnet:mainfrom 
akoeplinger:fix-warning
Conversation
@akoeplinger
@akoeplingerakoeplinger
commented
Aug 31, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Fixes#91249
We originally fixed the warnings with #69236 but due to add_compile_options() calls in zlib.cmake all of the mono native libs - not just the zlib components - were being built with C4244 disabled and a few couple more leaked in.
This fixes the occurrences and reworks the .cmake files a bit to hopefully prevent this in the future.
@ghostghost
added
the 
area-Build-mono

label
Aug 31, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 31, 2023

Closed

@akoeplinger
akoeplinger
marked this pull request as ready for review
August 31, 2023 22:31
akoeplinger
akoeplinger
commented
Aug 31, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-runtime.c
Outdated


This was referenced Sep 1, 2023

Closed


Closed

lateralusX
lateralusX
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-runtime.c
Outdated

Comment threadsrc/mono/mono/eventpipe/ep-rt-mono-runtime-provider.c
Outdated

Comment threadsrc/mono/mono/eventpipe/ep-rt-mono-runtime-provider.c
Outdated

Comment threadsrc/mono/mono/metadata/icall.c
Outdated

Comment threadsrc/mono/mono/mini/graph.c
Outdated

Comment threadsrc/mono/mono/mini/helpers.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

fanyang-mono
fanyang-mono
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/graph.c
fanyang-mono
fanyang-mono
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/helpers.c
fanyang-mono
fanyang-mono
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/mini-llvm-cpp.cpp
Outdated

fanyang-mono
fanyang-mono
approved these changes
Sep 1, 2023
View reviewed changes
@fanyang-monofanyang-mono
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the change looks good to me.
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 4, 2023

Closed

lateralusX
lateralusX
reviewed
Sep 5, 2023
View reviewed changes
@lateralusXlateralusX
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, great work. Mainly a couple of additional places to use different conversion macros or opportunity to add a new more precise conversion macro.
The only thing to look out for is the mword SGenDescriptor related changes, mword is based on host size while SGenDescriptor is based on target size, so changing the type we will need to make sure that it doesn't introduce changed behavior or potentially loss of precision in case you have different host/target pointer sizes.
Comment threadsrc/mono/mono/metadata/sgen-client-mono.h
Comment threadsrc/mono/mono/metadata/sgen-mono.c
Comment threadsrc/mono/mono/mini/aot-compiler.c
Outdated

Comment threadsrc/mono/mono/mini/aot-compiler.c
Outdated

Comment threadsrc/mono/mono/mini/aot-compiler.c
Outdated

Comment threadsrc/mono/mono/mini/method-to-ir.c
Outdated

Comment threadsrc/mono/mono/mini/mini-llvm.c
Outdated

Comment threadsrc/mono/mono/mini/mini-x86.c
Outdated

Comment threadsrc/mono/mono/sgen/sgen-scan-object.h
 * object contained references. If not, the value of "start" should
 * be considered undefined after executing this code. The object's
 * GC descriptor must be in the variable "mword desc".
 * GC descriptor must be in the variable "SgenDescriptor desc".
@lateralusXlateralusXSep 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are different type depending on host/target, mword is host machine word while SgenDescriptor is target machine word, have you validated that calls only uses SgenDescriptor and we don't end up casting mword to SgenDescriptor or SgenDescriptor to mword since that can lead to data loss depending on host/target combinations or depend on size of desc in logic etc.
@akoeplingerakoeplingerSep 5, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I checked all the callsites and they are all called with SgenDescriptor type without casting.
Comment threadsrc/mono/mono/metadata/sgen-mono.c
@akoeplingerakoeplinger
mentioned this pull request
Sep 5, 2023
 Merged


This was referenced Sep 5, 2023

Open


Closed

@akoeplinger
akoeplinger
merged commit 4c0a7c4
into
dotnet:mainSep 5, 2023
@akoeplinger
akoeplinger
deleted the

fix-warning

branch
September 5, 2023 22:24
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 6, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lateralusXlateralusXlateralusX approved these changes
@fanyang-monofanyang-monofanyang-mono approved these changes
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@lambdageeklambdageekAwaiting requested review from lambdageek
@vargazvargazAwaiting requested review from vargaz
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmiloskotlarmilos is a code owner
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

@akoeplingerakoeplinger

Labels

area-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Mono build disables required warning C4244 under MSVC


3 participants

@akoeplinger@lateralusX@fanyang-mono

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[mono] Reenable C4244 MSVC warning and fix occurrences - #91395
Merged
akoeplinger merged 8 commits into
dotnet:mainfrom 
akoeplinger:fix-warning
Sep 5, 2023
Merged
[mono] Reenable C4244 MSVC warning and fix occurrences#91395
akoeplinger merged 8 commits into
dotnet:mainfrom 
akoeplinger:fix-warning
Conversation
@akoeplinger
@akoeplingerakoeplinger
commented
Aug 31, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Fixes#91249
We originally fixed the warnings with #69236 but due to add_compile_options() calls in zlib.cmake all of the mono native libs - not just the zlib components - were being built with C4244 disabled and a few couple more leaked in.
This fixes the occurrences and reworks the .cmake files a bit to hopefully prevent this in the future.
@ghostghost
added
the 
area-Build-mono

label
Aug 31, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 31, 2023

Closed

@akoeplinger
akoeplinger
marked this pull request as ready for review
August 31, 2023 22:31
akoeplinger
akoeplinger
commented
Aug 31, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-runtime.c
Outdated


This was referenced Sep 1, 2023

Closed


Closed

lateralusX
lateralusX
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-runtime.c
Outdated

Comment threadsrc/mono/mono/eventpipe/ep-rt-mono-runtime-provider.c
Outdated

Comment threadsrc/mono/mono/eventpipe/ep-rt-mono-runtime-provider.c
Outdated

Comment threadsrc/mono/mono/metadata/icall.c
Outdated

Comment threadsrc/mono/mono/mini/graph.c
Outdated

Comment threadsrc/mono/mono/mini/helpers.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

fanyang-mono
fanyang-mono
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/graph.c
fanyang-mono
fanyang-mono
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/helpers.c
fanyang-mono
fanyang-mono
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/mini-llvm-cpp.cpp
Outdated

fanyang-mono
fanyang-mono
approved these changes
Sep 1, 2023
View reviewed changes
@fanyang-monofanyang-mono
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the change looks good to me.
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 4, 2023

Closed

lateralusX
lateralusX
reviewed
Sep 5, 2023
View reviewed changes
@lateralusXlateralusX
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, great work. Mainly a couple of additional places to use different conversion macros or opportunity to add a new more precise conversion macro.
The only thing to look out for is the mword SGenDescriptor related changes, mword is based on host size while SGenDescriptor is based on target size, so changing the type we will need to make sure that it doesn't introduce changed behavior or potentially loss of precision in case you have different host/target pointer sizes.
Comment threadsrc/mono/mono/metadata/sgen-client-mono.h
Comment threadsrc/mono/mono/metadata/sgen-mono.c
Comment threadsrc/mono/mono/mini/aot-compiler.c
Outdated

Comment threadsrc/mono/mono/mini/aot-compiler.c
Outdated

Comment threadsrc/mono/mono/mini/aot-compiler.c
Outdated

Comment threadsrc/mono/mono/mini/method-to-ir.c
Outdated

Comment threadsrc/mono/mono/mini/mini-llvm.c
Outdated

Comment threadsrc/mono/mono/mini/mini-x86.c
Outdated

Comment threadsrc/mono/mono/sgen/sgen-scan-object.h
 * object contained references. If not, the value of "start" should
 * be considered undefined after executing this code. The object's
 * GC descriptor must be in the variable "mword desc".
 * GC descriptor must be in the variable "SgenDescriptor desc".
@lateralusXlateralusXSep 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are different type depending on host/target, mword is host machine word while SgenDescriptor is target machine word, have you validated that calls only uses SgenDescriptor and we don't end up casting mword to SgenDescriptor or SgenDescriptor to mword since that can lead to data loss depending on host/target combinations or depend on size of desc in logic etc.
@akoeplingerakoeplingerSep 5, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I checked all the callsites and they are all called with SgenDescriptor type without casting.
Comment threadsrc/mono/mono/metadata/sgen-mono.c
@akoeplingerakoeplinger
mentioned this pull request
Sep 5, 2023
 Merged


This was referenced Sep 5, 2023

Open


Closed

@akoeplinger
akoeplinger
merged commit 4c0a7c4
into
dotnet:mainSep 5, 2023
@akoeplinger
akoeplinger
deleted the

fix-warning

branch
September 5, 2023 22:24
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 6, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lateralusXlateralusXlateralusX approved these changes
@fanyang-monofanyang-monofanyang-mono approved these changes
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@lambdageeklambdageekAwaiting requested review from lambdageek
@vargazvargazAwaiting requested review from vargaz
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmiloskotlarmilos is a code owner
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

@akoeplingerakoeplinger

Labels

area-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Mono build disables required warning C4244 under MSVC


3 participants

@akoeplinger@lateralusX@fanyang-mono

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[mono] Reenable C4244 MSVC warning and fix occurrences - #91395
Merged
akoeplinger merged 8 commits into
dotnet:mainfrom 
akoeplinger:fix-warning
Sep 5, 2023
Merged
[mono] Reenable C4244 MSVC warning and fix occurrences#91395
akoeplinger merged 8 commits into
dotnet:mainfrom 
akoeplinger:fix-warning
Conversation
@akoeplinger
@akoeplingerakoeplinger
commented
Aug 31, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Fixes#91249
We originally fixed the warnings with #69236 but due to add_compile_options() calls in zlib.cmake all of the mono native libs - not just the zlib components - were being built with C4244 disabled and a few couple more leaked in.
This fixes the occurrences and reworks the .cmake files a bit to hopefully prevent this in the future.
@ghostghost
added
the 
area-Build-mono

label
Aug 31, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 31, 2023

Closed

@akoeplinger
akoeplinger
marked this pull request as ready for review
August 31, 2023 22:31
akoeplinger
akoeplinger
commented
Aug 31, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-runtime.c
Outdated


This was referenced Sep 1, 2023

Closed


Closed

lateralusX
lateralusX
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-runtime.c
Outdated

Comment threadsrc/mono/mono/eventpipe/ep-rt-mono-runtime-provider.c
Outdated

Comment threadsrc/mono/mono/eventpipe/ep-rt-mono-runtime-provider.c
Outdated

Comment threadsrc/mono/mono/metadata/icall.c
Outdated

Comment threadsrc/mono/mono/mini/graph.c
Outdated

Comment threadsrc/mono/mono/mini/helpers.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

fanyang-mono
fanyang-mono
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/graph.c
fanyang-mono
fanyang-mono
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/helpers.c
fanyang-mono
fanyang-mono
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/mini-llvm-cpp.cpp
Outdated

fanyang-mono
fanyang-mono
approved these changes
Sep 1, 2023
View reviewed changes
@fanyang-monofanyang-mono
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the change looks good to me.
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 4, 2023

Closed

lateralusX
lateralusX
reviewed
Sep 5, 2023
View reviewed changes
@lateralusXlateralusX
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, great work. Mainly a couple of additional places to use different conversion macros or opportunity to add a new more precise conversion macro.
The only thing to look out for is the mword SGenDescriptor related changes, mword is based on host size while SGenDescriptor is based on target size, so changing the type we will need to make sure that it doesn't introduce changed behavior or potentially loss of precision in case you have different host/target pointer sizes.
Comment threadsrc/mono/mono/metadata/sgen-client-mono.h
Comment threadsrc/mono/mono/metadata/sgen-mono.c
Comment threadsrc/mono/mono/mini/aot-compiler.c
Outdated

Comment threadsrc/mono/mono/mini/aot-compiler.c
Outdated

Comment threadsrc/mono/mono/mini/aot-compiler.c
Outdated

Comment threadsrc/mono/mono/mini/method-to-ir.c
Outdated

Comment threadsrc/mono/mono/mini/mini-llvm.c
Outdated

Comment threadsrc/mono/mono/mini/mini-x86.c
Outdated

Comment threadsrc/mono/mono/sgen/sgen-scan-object.h
 * object contained references. If not, the value of "start" should
 * be considered undefined after executing this code. The object's
 * GC descriptor must be in the variable "mword desc".
 * GC descriptor must be in the variable "SgenDescriptor desc".
@lateralusXlateralusXSep 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are different type depending on host/target, mword is host machine word while SgenDescriptor is target machine word, have you validated that calls only uses SgenDescriptor and we don't end up casting mword to SgenDescriptor or SgenDescriptor to mword since that can lead to data loss depending on host/target combinations or depend on size of desc in logic etc.
@akoeplingerakoeplingerSep 5, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I checked all the callsites and they are all called with SgenDescriptor type without casting.
Comment threadsrc/mono/mono/metadata/sgen-mono.c
@akoeplingerakoeplinger
mentioned this pull request
Sep 5, 2023
 Merged


This was referenced Sep 5, 2023

Open


Closed

@akoeplinger
akoeplinger
merged commit 4c0a7c4
into
dotnet:mainSep 5, 2023
@akoeplinger
akoeplinger
deleted the

fix-warning

branch
September 5, 2023 22:24
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 6, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lateralusXlateralusXlateralusX approved these changes
@fanyang-monofanyang-monofanyang-mono approved these changes
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@lambdageeklambdageekAwaiting requested review from lambdageek
@vargazvargazAwaiting requested review from vargaz
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmiloskotlarmilos is a code owner
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

@akoeplingerakoeplinger

Labels

area-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Mono build disables required warning C4244 under MSVC


3 participants

@akoeplinger@lateralusX@fanyang-mono

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[mono] Reenable C4244 MSVC warning and fix occurrences - #91395
Merged
akoeplinger merged 8 commits into
dotnet:mainfrom 
akoeplinger:fix-warning
Sep 5, 2023
Merged
[mono] Reenable C4244 MSVC warning and fix occurrences#91395
akoeplinger merged 8 commits into
dotnet:mainfrom 
akoeplinger:fix-warning
Conversation
@akoeplinger
@akoeplingerakoeplinger
commented
Aug 31, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Fixes#91249
We originally fixed the warnings with #69236 but due to add_compile_options() calls in zlib.cmake all of the mono native libs - not just the zlib components - were being built with C4244 disabled and a few couple more leaked in.
This fixes the occurrences and reworks the .cmake files a bit to hopefully prevent this in the future.
@ghostghost
added
the 
area-Build-mono

label
Aug 31, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 31, 2023

Closed

@akoeplinger
akoeplinger
marked this pull request as ready for review
August 31, 2023 22:31
akoeplinger
akoeplinger
commented
Aug 31, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-runtime.c
Outdated


This was referenced Sep 1, 2023

Closed


Closed

lateralusX
lateralusX
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-runtime.c
Outdated

Comment threadsrc/mono/mono/eventpipe/ep-rt-mono-runtime-provider.c
Outdated

Comment threadsrc/mono/mono/eventpipe/ep-rt-mono-runtime-provider.c
Outdated

Comment threadsrc/mono/mono/metadata/icall.c
Outdated

Comment threadsrc/mono/mono/mini/graph.c
Outdated

Comment threadsrc/mono/mono/mini/helpers.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

fanyang-mono
fanyang-mono
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/graph.c
fanyang-mono
fanyang-mono
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/helpers.c
fanyang-mono
fanyang-mono
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/mini-llvm-cpp.cpp
Outdated

fanyang-mono
fanyang-mono
approved these changes
Sep 1, 2023
View reviewed changes
@fanyang-monofanyang-mono
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the change looks good to me.
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 4, 2023

Closed

lateralusX
lateralusX
reviewed
Sep 5, 2023
View reviewed changes
@lateralusXlateralusX
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, great work. Mainly a couple of additional places to use different conversion macros or opportunity to add a new more precise conversion macro.
The only thing to look out for is the mword SGenDescriptor related changes, mword is based on host size while SGenDescriptor is based on target size, so changing the type we will need to make sure that it doesn't introduce changed behavior or potentially loss of precision in case you have different host/target pointer sizes.
Comment threadsrc/mono/mono/metadata/sgen-client-mono.h
Comment threadsrc/mono/mono/metadata/sgen-mono.c
Comment threadsrc/mono/mono/mini/aot-compiler.c
Outdated

Comment threadsrc/mono/mono/mini/aot-compiler.c
Outdated

Comment threadsrc/mono/mono/mini/aot-compiler.c
Outdated

Comment threadsrc/mono/mono/mini/method-to-ir.c
Outdated

Comment threadsrc/mono/mono/mini/mini-llvm.c
Outdated

Comment threadsrc/mono/mono/mini/mini-x86.c
Outdated

Comment threadsrc/mono/mono/sgen/sgen-scan-object.h
 * object contained references. If not, the value of "start" should
 * be considered undefined after executing this code. The object's
 * GC descriptor must be in the variable "mword desc".
 * GC descriptor must be in the variable "SgenDescriptor desc".
@lateralusXlateralusXSep 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are different type depending on host/target, mword is host machine word while SgenDescriptor is target machine word, have you validated that calls only uses SgenDescriptor and we don't end up casting mword to SgenDescriptor or SgenDescriptor to mword since that can lead to data loss depending on host/target combinations or depend on size of desc in logic etc.
@akoeplingerakoeplingerSep 5, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I checked all the callsites and they are all called with SgenDescriptor type without casting.
Comment threadsrc/mono/mono/metadata/sgen-mono.c
@akoeplingerakoeplinger
mentioned this pull request
Sep 5, 2023
 Merged


This was referenced Sep 5, 2023

Open


Closed

@akoeplinger
akoeplinger
merged commit 4c0a7c4
into
dotnet:mainSep 5, 2023
@akoeplinger
akoeplinger
deleted the

fix-warning

branch
September 5, 2023 22:24
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 6, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lateralusXlateralusXlateralusX approved these changes
@fanyang-monofanyang-monofanyang-mono approved these changes
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@lambdageeklambdageekAwaiting requested review from lambdageek
@vargazvargazAwaiting requested review from vargaz
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmiloskotlarmilos is a code owner
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

@akoeplingerakoeplinger

Labels

area-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Mono build disables required warning C4244 under MSVC


3 participants

@akoeplinger@lateralusX@fanyang-mono

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[mono] Reenable C4244 MSVC warning and fix occurrences - #91395
Merged
akoeplinger merged 8 commits into
dotnet:mainfrom 
akoeplinger:fix-warning
Sep 5, 2023
Merged
[mono] Reenable C4244 MSVC warning and fix occurrences#91395
akoeplinger merged 8 commits into
dotnet:mainfrom 
akoeplinger:fix-warning
Conversation
@akoeplinger
@akoeplingerakoeplinger
commented
Aug 31, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Fixes#91249
We originally fixed the warnings with #69236 but due to add_compile_options() calls in zlib.cmake all of the mono native libs - not just the zlib components - were being built with C4244 disabled and a few couple more leaked in.
This fixes the occurrences and reworks the .cmake files a bit to hopefully prevent this in the future.
@ghostghost
added
the 
area-Build-mono

label
Aug 31, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 31, 2023

Closed

@akoeplinger
akoeplinger
marked this pull request as ready for review
August 31, 2023 22:31
akoeplinger
akoeplinger
commented
Aug 31, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-runtime.c
Outdated


This was referenced Sep 1, 2023

Closed


Closed

lateralusX
lateralusX
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-runtime.c
Outdated

Comment threadsrc/mono/mono/eventpipe/ep-rt-mono-runtime-provider.c
Outdated

Comment threadsrc/mono/mono/eventpipe/ep-rt-mono-runtime-provider.c
Outdated

Comment threadsrc/mono/mono/metadata/icall.c
Outdated

Comment threadsrc/mono/mono/mini/graph.c
Outdated

Comment threadsrc/mono/mono/mini/helpers.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

Comment threadsrc/mono/mono/mini/interp/transform.c
Outdated

fanyang-mono
fanyang-mono
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/graph.c
fanyang-mono
fanyang-mono
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/helpers.c
fanyang-mono
fanyang-mono
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/mini-llvm-cpp.cpp
Outdated

fanyang-mono
fanyang-mono
approved these changes
Sep 1, 2023
View reviewed changes
@fanyang-monofanyang-mono
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the change looks good to me.
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 4, 2023

Closed

lateralusX
lateralusX
reviewed
Sep 5, 2023
View reviewed changes
@lateralusXlateralusX
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, great work. Mainly a couple of additional places to use different conversion macros or opportunity to add a new more precise conversion macro.
The only thing to look out for is the mword SGenDescriptor related changes, mword is based on host size while SGenDescriptor is based on target size, so changing the type we will need to make sure that it doesn't introduce changed behavior or potentially loss of precision in case you have different host/target pointer sizes.
Comment threadsrc/mono/mono/metadata/sgen-client-mono.h
Comment threadsrc/mono/mono/metadata/sgen-mono.c
Comment threadsrc/mono/mono/mini/aot-compiler.c
Outdated

Comment threadsrc/mono/mono/mini/aot-compiler.c
Outdated

Comment threadsrc/mono/mono/mini/aot-compiler.c
Outdated

Comment threadsrc/mono/mono/mini/method-to-ir.c
Outdated

Comment threadsrc/mono/mono/mini/mini-llvm.c
Outdated

Comment threadsrc/mono/mono/mini/mini-x86.c
Outdated

Comment threadsrc/mono/mono/sgen/sgen-scan-object.h
 * object contained references. If not, the value of "start" should
 * be considered undefined after executing this code. The object's
 * GC descriptor must be in the variable "mword desc".
 * GC descriptor must be in the variable "SgenDescriptor desc".
@lateralusXlateralusXSep 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are different type depending on host/target, mword is host machine word while SgenDescriptor is target machine word, have you validated that calls only uses SgenDescriptor and we don't end up casting mword to SgenDescriptor or SgenDescriptor to mword since that can lead to data loss depending on host/target combinations or depend on size of desc in logic etc.
@akoeplingerakoeplingerSep 5, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I checked all the callsites and they are all called with SgenDescriptor type without casting.
Comment threadsrc/mono/mono/metadata/sgen-mono.c
@akoeplingerakoeplinger
mentioned this pull request
Sep 5, 2023
 Merged


This was referenced Sep 5, 2023

Open


Closed

@akoeplinger
akoeplinger
merged commit 4c0a7c4
into
dotnet:mainSep 5, 2023
@akoeplinger
akoeplinger
deleted the

fix-warning

branch
September 5, 2023 22:24
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 6, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lateralusXlateralusXlateralusX approved these changes
@fanyang-monofanyang-monofanyang-mono approved these changes
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@lambdageeklambdageekAwaiting requested review from lambdageek
@vargazvargazAwaiting requested review from vargaz
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmiloskotlarmilos is a code owner
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

@akoeplingerakoeplinger

Labels

area-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Mono build disables required warning C4244 under MSVC


3 participants

@akoeplinger@lateralusX@fanyang-mono