Fix ENABLE_CHECKED_CASTS build and transform it into ENABLE_CHECKED_BUILDS_ option

[akoeplinger]

Companion to #91395. Removes some duplicate defines and allows CHECKED_BUILD to be turned on in Release config.

[BrzVlad]

What exactly is this checked option doing ? The defines below seem to not do anything in case of overflow.

[lateralusX]

There are no actions hooked up to these checks at the moment, so we would need to implement valid actions in case of underflow/owerflow when we would start to use them. When I prepared for them a year ago I know we have some casts that will trigger the checks so we probably need to start logging or similar to get a better understanding where we do potential dangerous casts and where the underflow/overflow might be excepted.

[BrzVlad]

overflowing here is expected

[akoeplinger]

yeah I suspect we'd need to audit every usage if/when we turn on validation, but right now this at least gives us all the places where conversions are happening.

[akoeplinger]

Companion to #91395. Removes some duplicate defines and allows CHECKED_BUILD to be turned on in Release config.

[BrzVlad]

What exactly is this checked option doing ? The defines below seem to not do anything in case of overflow.

[lateralusX]

There are no actions hooked up to these checks at the moment, so we would need to implement valid actions in case of underflow/owerflow when we would start to use them. When I prepared for them a year ago I know we have some casts that will trigger the checks so we probably need to start logging or similar to get a better understanding where we do potential dangerous casts and where the underflow/overflow might be excepted.

[BrzVlad]

overflowing here is expected

[akoeplinger]

yeah I suspect we'd need to audit every usage if/when we turn on validation, but right now this at least gives us all the places where conversions are happening.

[akoeplinger]

Companion to #91395. Removes some duplicate defines and allows CHECKED_BUILD to be turned on in Release config.

[BrzVlad]

What exactly is this checked option doing ? The defines below seem to not do anything in case of overflow.

[lateralusX]

There are no actions hooked up to these checks at the moment, so we would need to implement valid actions in case of underflow/owerflow when we would start to use them. When I prepared for them a year ago I know we have some casts that will trigger the checks so we probably need to start logging or similar to get a better understanding where we do potential dangerous casts and where the underflow/overflow might be excepted.

[BrzVlad]

overflowing here is expected

[akoeplinger]

yeah I suspect we'd need to audit every usage if/when we turn on validation, but right now this at least gives us all the places where conversions are happening.

[akoeplinger]

Companion to #91395. Removes some duplicate defines and allows CHECKED_BUILD to be turned on in Release config.

[BrzVlad]

What exactly is this checked option doing ? The defines below seem to not do anything in case of overflow.

[lateralusX]

There are no actions hooked up to these checks at the moment, so we would need to implement valid actions in case of underflow/owerflow when we would start to use them. When I prepared for them a year ago I know we have some casts that will trigger the checks so we probably need to start logging or similar to get a better understanding where we do potential dangerous casts and where the underflow/overflow might be excepted.

[BrzVlad]

overflowing here is expected

[akoeplinger]

yeah I suspect we'd need to audit every usage if/when we turn on validation, but right now this at least gives us all the places where conversions are happening.

[akoeplinger]

Companion to #91395. Removes some duplicate defines and allows CHECKED_BUILD to be turned on in Release config.

[BrzVlad]

What exactly is this checked option doing ? The defines below seem to not do anything in case of overflow.

[lateralusX]

There are no actions hooked up to these checks at the moment, so we would need to implement valid actions in case of underflow/owerflow when we would start to use them. When I prepared for them a year ago I know we have some casts that will trigger the checks so we probably need to start logging or similar to get a better understanding where we do potential dangerous casts and where the underflow/overflow might be excepted.

[BrzVlad]

overflowing here is expected

[akoeplinger]

yeah I suspect we'd need to audit every usage if/when we turn on validation, but right now this at least gives us all the places where conversions are happening.

[akoeplinger]

Companion to #91395. Removes some duplicate defines and allows CHECKED_BUILD to be turned on in Release config.

[BrzVlad]

What exactly is this checked option doing ? The defines below seem to not do anything in case of overflow.

[lateralusX]

There are no actions hooked up to these checks at the moment, so we would need to implement valid actions in case of underflow/owerflow when we would start to use them. When I prepared for them a year ago I know we have some casts that will trigger the checks so we probably need to start logging or similar to get a better understanding where we do potential dangerous casts and where the underflow/overflow might be excepted.

[BrzVlad]

overflowing here is expected

[akoeplinger]

yeah I suspect we'd need to audit every usage if/when we turn on validation, but right now this at least gives us all the places where conversions are happening.

[akoeplinger]

Companion to #91395. Removes some duplicate defines and allows CHECKED_BUILD to be turned on in Release config.

[BrzVlad]

What exactly is this checked option doing ? The defines below seem to not do anything in case of overflow.

[lateralusX]

There are no actions hooked up to these checks at the moment, so we would need to implement valid actions in case of underflow/owerflow when we would start to use them. When I prepared for them a year ago I know we have some casts that will trigger the checks so we probably need to start logging or similar to get a better understanding where we do potential dangerous casts and where the underflow/overflow might be excepted.

[BrzVlad]

overflowing here is expected

[akoeplinger]

yeah I suspect we'd need to audit every usage if/when we turn on validation, but right now this at least gives us all the places where conversions are happening.

[akoeplinger]

Companion to #91395. Removes some duplicate defines and allows CHECKED_BUILD to be turned on in Release config.

[BrzVlad]

What exactly is this checked option doing ? The defines below seem to not do anything in case of overflow.

[lateralusX]

There are no actions hooked up to these checks at the moment, so we would need to implement valid actions in case of underflow/owerflow when we would start to use them. When I prepared for them a year ago I know we have some casts that will trigger the checks so we probably need to start logging or similar to get a better understanding where we do potential dangerous casts and where the underflow/overflow might be excepted.

[BrzVlad]

overflowing here is expected

[akoeplinger]

yeah I suspect we'd need to audit every usage if/when we turn on validation, but right now this at least gives us all the places where conversions are happening.