Uh oh!
There was an error while loading. Please reload this page.
[release/8.0] Fix usage of load library - #91490
Merged
Merged
Conversation
ghost
commented
Sep 2, 2023
Tagging subscribers to this area: @tommcdon Issue DetailsBackport of #91483 to release/8.0 Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
jeffschwMSFT
approved these changes
Sep 2, 2023
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
approved. please get a code review. once ready this can be merged
mikem8361
approved these changes
Sep 2, 2023
Member
@jeffschwMSFT or @jkotas or @carlossanlop CI is green and has been signed off. Please merge when convenient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #91483 to release/8.0
/cc @AaronRobinsonMSFT
Customer Impact
This usage violates API tenets for dotnet.
Testing
Validated with diagnostics tests.
Risk
Low. This use of
LoadLibraryW()is only passed a full path anyways so the update toLoadLibraryExW()passedLOAD_WITH_ALTERED_SEARCH_PATH.IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.