') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); runtime wasm perf triggers 8 by radical · Pull Request #92976 · dotnet/runtime · GitHub
Skip to content

runtime wasm perf triggers 8 - #92976

Closed
radical wants to merge 389 commits into
dotnet:mainfrom
radical:runtime-wasm-perf-triggers-8
Closed

runtime wasm perf triggers 8#92976
radical wants to merge 389 commits into
dotnet:mainfrom
radical:runtime-wasm-perf-triggers-8

Conversation

@radical

@radicalradical commented Oct 3, 2023

Copy link
Copy Markdown
Member

github-actionsBotand others added 30 commits August 30, 2023 12:40
@github-actions@MihaZupan
Fix Http2 MultiConnection test race conditions (dotnet#91343)
e018fb7
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@github-actions@maraf@radical
[release/8.0] [browser] Update browser template to use Wasm SDK (dotn…
028b380
…et#91046)
* Use WasmSdk in browser template
* Remove default html-path
* Use wwwroot when looking for main.js in template for replacement
* Temporarily remove WasmRuntimeAssetsLocation from WBT because WasmSDK doesn't support it yet
* Integrate console log forward into DevServer
* Replace UseRouter
* Use next middleware only if it's not console
* CancellationTokenSource on CancelKeyPress
* Address feedback from initial DevServer integration
* Update src/mono/wasm/host/BrowserHost.cs
Co-authored-by: Ankit Jain <radical@gmail.com>
* Remove debugging code
* Fix WBT
* Fix starting outside of project directory
* Support WasmRuntimeAssetsLocation in Wasm SDK
* Revert "Support WasmRuntimeAssetsLocation in Wasm SDK"
* Active issue for WasmRuntimeAssetsLocation
* Feedback
---------
Co-authored-by: Marek Fišera <mara@neptuo.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
f841e21
…829.1 (dotnet#91329)
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23428.2 -> To Version 8.0.0-beta.23429.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23423.1 -> To Version 1.0.0-beta.23426.1 (parent: Microsoft.DotNet.Arcade.Sdk
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@dotnet-maestro
Update dependencies fromhttps://dev.azure.com/dnceng/internal/_git/d…
a02c660
…otnet-optimization build 20230829.4 (dotnet#91330)
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.23427.2 -> To Version 1.0.0-prerelease.23429.4
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@github-actions@tannergooding
Ensure the relevant containable nodes are handled (dotnet#91334)
592e01f
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
@github-actions@layomia@jeffhandley
[release/8.0] Emit interceptor info correctly when invocation expr is…
8ec6101
… on separate line (dotnet#91218)
* Emit interceptor info correctly when invocation expr is on separate line
* Add more tests and add helper to udpate baselines
* Add comments to binding gen tests for invocations on new lines (dotnet#91237)
* Add comments to binding gen tests for invocations on new lines
* Address feedback & test static method call syntax
* Reorganize and comment the newline/whitespace scenarios
* Reorganize and comment the newline/whitespace scenarios for ConfigurationExtensions
---------
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
* Update baselines
---------
Co-authored-by: Layomi Akinrinade <laakinri@microsoft.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
@github-actions@janvorli
[release/8.0] Fix crash when calling AssemblyLoadContext.Unload twice (…
7174092
…dotnet#91346)
* Fix crash when calling AssemblyLoadContext.Unload twice
The AssemblyLoadContext.InitiateUnload method was not handling multiple
calls correctly. Instead of making the extra calls dummy, it was
calling the native runtime helper again.
This change fixes it by simply ensuring that the runtime helper is
called just once.
* Add regression test
---------
Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
@dotnet-bot
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
41b2c8f
… Build ID 2256251 (dotnet#91347)
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2256251
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2256251
@dotnet-bot
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
c09812f
… Build ID 2256435 (dotnet#91360)
@dotnet-maestro
[release/8.0] Update dependencies from dotnet/roslyn (dotnet#91239)
903c3a5
* Update dependencies from https://github.com/dotnet/roslyn build 20230828.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23428.1
* Update dependencies from https://github.com/dotnet/roslyn build 20230828.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23428.2
* Update dependencies from https://github.com/dotnet/roslyn build 20230828.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23428.3
* Update dependencies from https://github.com/dotnet/roslyn build 20230828.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23428.4
* Update dependencies from https://github.com/dotnet/roslyn build 20230828.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23428.6
* Update dependencies from https://github.com/dotnet/roslyn build 20230828.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23428.5
* Update dependencies from https://github.com/dotnet/roslyn build 20230828.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23428.7
* Update dependencies from https://github.com/dotnet/roslyn build 20230829.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.1
* Update dependencies from https://github.com/dotnet/roslyn build 20230829.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.3
* Update dependencies from https://github.com/dotnet/roslyn build 20230829.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.4
* Update dependencies from https://github.com/dotnet/roslyn build 20230829.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.6
* Update dependencies from https://github.com/dotnet/roslyn build 20230829.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23429.7
* Update dependencies from https://github.com/dotnet/roslyn build 20230829.9
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.9
* Update dependencies from https://github.com/dotnet/roslyn build 20230829.10
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.10
* Update dependencies from https://github.com/dotnet/roslyn build 20230829.12
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.12
* Update dependencies from https://github.com/dotnet/roslyn build 20230829.13
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.13
* Update dependencies from https://github.com/dotnet/roslyn build 20230829.14
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.14
* Update dependencies from https://github.com/dotnet/roslyn build 20230830.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23430.1
* Update dependencies from https://github.com/dotnet/roslyn build 20230830.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23430.2
* Update dependencies from https://github.com/dotnet/roslyn build 20230830.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23430.3
* Update dependencies from https://github.com/dotnet/roslyn build 20230830.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23430.4
* Update dependencies from https://github.com/dotnet/roslyn build 20230830.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23430.5
* Update dependencies from https://github.com/dotnet/roslyn build 20230830.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23430.6
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@github-actions@jborean93
Support Windows based ECDSA SignedCms (dotnet#91247)
a4c96df
Supports SignedCms signatured with an ECDSA key created by the Windows
API or .NET Framework. These signatures store an EC public key OID
rather than a hash specific ECDSA OID used in newer versions of dotnet.
Fixesdotnet#77377
Co-authored-by: Jordan Borean <jborean93@gmail.com>
@dotnet-maestro
Update dependencies fromhttps://dev.azure.com/dnceng/internal/_git/d…
3c48925
…otnet-optimization build 20230830.6 (dotnet#91390)
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.23429.4 -> To Version 1.0.0-prerelease.23430.6
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@layomia
Update binder gen emitted-interceptor nullability to match framework …
35f043f
…impl (dotnet#91180) (dotnet#91359)
@github-actions@jeffhandley
[release/8.0] Fix nullable annotation for Validator.TryValidateValue …
9c422ed
…and ValidateValue (dotnet#91293)
* Fix nullable annotation for Validator.TryValidateValue and ValidateValue
* Revert Options source generator nullable annotation changes for Validator.TryValidateValue (dotnet#91305)
* Fix nullable annotation for Validator.ValidateValue ref source (dotnet#91351)
---------
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
@github-actions@jonathanpeppers@eerhardt
[release/8.0] [DependencyInjection] introduce feature switch to disab…
399f37c
…le S.R.E (dotnet#91352)
* [DependencyInjection] introduce feature switch to disable S.R.E
When recording a new AOT profile for .NET MAUI apps running on Android,
we noticed that System.Reflection.Emit work was being done on a
background thread. The call seen in `dotnet-trace` output:
11.32ms microsoft.extensions.dependencyinjection!Microsoft.Extensions.DependencyInjection.ServiceLookup.ILEmitResolverBuilder.GenerateMethodBody(Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceCallSite,System.Reflection.Emit.ILGenerator)
.NET Android apps are unique in that there is a JIT,
`RuntimeFeature.IsDynamicCodeCompiled` is true, System.Reflection.Emit
is possible -- S.R.E is however, not great for startup performance.
Starting threads on Android during startup can also be slow, as Android
will commonly put all but a single core to sleep for battery saving
purposes. We try to avoid starting threads on startup for "hello world"
applications on Android.
To solve this for now, introduce a new feature flag:
Microsoft.Extensions.DependencyInjection.DisableDynamicEngine
Which, we will provide a value in either the Android or .NET MAUI
optional workload via an MSBuild property. To test, I put this in my
app's `.csproj` file:
<RuntimeHostConfigurationOption Include="Microsoft.Extensions.DependencyInjection.DisableDynamicEngine"
Condition="'$(DisableDynamicEngine)' != ''"
Value="$(DisableDynamicEngine)"
Trim="true" />
Customers *could* opt to change this flag, but we don't think it will
particularly useful. An example of services realized by .NET MAUI at
startup, via some logging added:
08-25 13:21:55.647 16530 16530 I DOTNET : RealizeService called: System.Collections.Generic.IEnumerable`1[Microsoft.Maui.Hosting.IMauiInitializeService]
08-25 13:21:55.664 16530 16530 I DOTNET : RealizeService called: System.Collections.Generic.IEnumerable`1[Microsoft.Maui.Hosting.IMauiInitializeScopedService]
08-25 13:21:55.665 16530 16530 I DOTNET : RealizeService called: Microsoft.Maui.Dispatching.IDispatcher
08-25 13:21:55.668 16530 16530 I DOTNET : RealizeService called: System.Collections.Generic.IEnumerable`1[Microsoft.Maui.LifecycleEvents.LifecycleEventRegistration]
08-25 13:21:56.057 16530 16530 I DOTNET : RealizeService called: System.Collections.Generic.IEnumerable`1[Microsoft.Maui.Hosting.HandlerMauiAppBuilderExtensions+HandlerRegistration]
08-25 13:21:56.115 16530 16530 I DOTNET : RealizeService called: Microsoft.Extensions.DependencyInjection.IServiceScopeFactory
08-25 13:21:56.670 16530 16530 I DOTNET : RealizeService called: Microsoft.Maui.Controls.HideSoftInputOnTappedChangedManager
08-25 13:21:56.712 16530 16530 I DOTNET : RealizeService called: System.Collections.Generic.IEnumerable`1[Microsoft.Maui.Hosting.ImageSourcesMauiAppBuilderExtensions+ImageSourceRegistration]
08-25 13:21:57.700 16530 16530 I DOTNET : RealizeService using S.R.E: Microsoft.Maui.Controls.HideSoftInputOnTappedChangedManager
`HideSoftInputOnTappedChangedManager` would be realized once per page,
which would not be a huge payoff to use S.R.E for. So the only way the
S.R.E codepath could be useful on Android would be if the customer is
registering lots of services themselves. They might be better off just
using `new()` in that case?
An example of the startup time Android reports with the new flag on/off:
DisableDynamicEngine=false
08-25 14:31:37.462 2090 2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +733ms
08-25 14:31:39.394 2090 2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +737ms
08-25 14:31:41.326 2090 2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +730ms
DisableDynamicEngine=true
08-25 14:32:20.233 2090 2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +724ms
08-25 14:32:22.137 2090 2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +727ms
08-25 14:32:24.042 2090 2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +716ms
This was a `dotnet new maui` project, using dotnet/maui/main on a Pixel
5 device.
* Update docs/workflow/trimming/feature-switches.md
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
---------
Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
Co-authored-by: Jonathan Peppers <jonathan.peppers@gmail.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
@github-actions@fanyang-mono
[release/8.0] [Mono] Fix offset calculation for nested struct, when p…
cd8b2cb
…invoke is enabled (dotnet#91417)
* Fix offset calculation for nested struct
* Add a test for nested struct with pinvoke
* Move and update test with real c++ implementation
* Exclude newly added test from wasm
* Disable interop tests on android and apple devices
---------
Co-authored-by: Fan Yang <yangfan@microsoft.com>
@github-actions@tarekgh
[release/8.0] Options Source Gen Fixes (dotnet#91432)
ee24056
* Options Source Gen Fixes
* Remove unnecessary interpolated string usage
* Address the feedback
* Remove repeated word in the comment
---------
Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>
@github-actions@maraf@marek-safar
[release/8.0] [nodejs] Remove experimental wasm arguments from templa…
dc652c1
…te (dotnet#91401)
* Remove experimental wasm arguments from template and add them to features.md
* Fix WBT
* Use lowercase host in runtimeconfig.template.json
* Override runtimeconfig only for wasmconsole
---------
Co-authored-by: Marek Fišera <mara@neptuo.com>
Co-authored-by: Marek Safar <marek.safar@gmail.com>
@github-actionsMike McLaughlin
Fix arm64/arm32 cross-DAC (dotnet#91438)
4d6f6bc
The precode code was incorrectly using the HOST_ARM64, HOST_ARM, etc. defines instead
of the TARGET_ ones. This means the cross-DAC was using the wrong architectures
*Precode::Type codes.
Co-authored-by: Mike McLaughlin <mikem@microsoft.com>
@github-actions@MichalStrehovsky
Fix runtime dispatch to static virtuals on interface types (dotnet#91440
2134e62
)
We were not generating information about static virtuals on interface types. Information about default interface methods normally goes to the class, but if the T we're dispatching on is an interface, this information wasn't generated. The fix is to put this information into dispatch maps and sealed vtables, same way we do for classes.
The test shows what the problem is - if we change `IBar` to be a class, things would work even before this PR.
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
@github-actions@MichalStrehovsky
Fix LDTOKEN of methods that have modifiers (dotnet#91439)
62b57fc
When we started generating custom modifiers into metadata format to support new function pointer APIs in dotnet#85504, we should have also added it to native layout format. We currently have a mismatch. This is a low risk bugfix to ignore modifiers on the metadata side. We'll want to do a full fix to actually emit and compare this. Tracked in a .NET 9 bug at dotnet#91381.
No regression test because I spent too much time being puzzled at why https://github.com/Handlebars-Net/Handlebars.Net/blob/50614fd844e5360eb10e76154aa74da4d7bf12ce/source/Handlebars/Helpers/IHelperDescriptor.cs#L13 is generated as a custom modifier (`[in] !TOptions& modreq([netstandard]System.Runtime.InteropServices.InAttribute) options`) whereas if I do it, I get `[in] !T& 'value'` with a custom attribute. We'll want to write a proper set of tests with ambiguities for the bug I opened anyway.
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
@dotnet-maestro
Update dependencies fromhttps://dev.azure.com/dnceng/internal/_git/d…
ed48635
…otnet-optimization build 20230831.4 (dotnet#91462)
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.23430.6 -> To Version 1.0.0-prerelease.23431.4
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@dotnet-maestro
[release/8.0] Update dependencies from dotnet/emsdk dotnet/arcade (do…
7c8fc57
…tnet#91423)
* Update dependencies from https://github.com/dotnet/emsdk build 20230831.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.1.23415.5 -> To Version 8.0.0-rc.2.23431.1
Dependency coherency updates
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 16.0.5-alpha.1.23408.1 -> To Version 16.0.5-alpha.1.23423.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
* Update dependencies from https://github.com/dotnet/arcade build 20230831.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23429.1 -> To Version 8.0.0-beta.23431.2
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@dotnet-maestro
[release/8.0] Update dependencies from dotnet/roslyn (dotnet#91420)
3a811f4
* Update dependencies from https://github.com/dotnet/roslyn build 20230831.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23430.6 -> To Version 4.8.0-3.23431.2
* Update dependencies from https://github.com/dotnet/roslyn build 20230831.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23430.6 -> To Version 4.8.0-3.23431.4
* Update dependencies from https://github.com/dotnet/roslyn build 20230831.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23430.6 -> To Version 4.8.0-3.23431.6
* Update dependencies from https://github.com/dotnet/roslyn build 20230831.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23430.6 -> To Version 4.8.0-3.23431.7
* Update dependencies from https://github.com/dotnet/roslyn build 20230901.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23430.6 -> To Version 4.8.0-3.23451.1
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@dotnet-bot
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
0c09b08
… Build ID 2258306 (dotnet#91485)
@github-actions@AaronRobinsonMSFT
[release/8.0] Fix usage of load library (dotnet#91490)
0cb73b1
* Use LoadLibraryExW on Windows.
* Use correct flag.
---------
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
@janvorli
[Release/8.0] Fix x64 crossbuild on macOS arm64 (dotnet#91635)
f4d24c5
cpufeatures.h/.c uses TARGET_ ifdefs, but it should use HOST_ ifdefs
@dotnet-maestro@carlossanlop
[release/8.0] Update dependencies from dotnet/cecil dotnet/arcade dot…
4e8df56
…net/icu dotnet/source-build-reference-packages dotnet/emsdk (dotnet#91500)
* Update dependencies from https://github.com/dotnet/arcade build 20230901.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23431.2 -> To Version 8.0.0-beta.23451.1
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230901.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23428.2 -> To Version 8.0.0-alpha.1.23451.1
* Update dependencies from https://github.com/dotnet/cecil build 2023090.2
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23428.2 -> To Version 0.11.4-alpha.23454.2
* Update dependencies from https://github.com/dotnet/icu build 2023090.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 8.0.0-rc.2.23421.2 -> To Version 8.0.0-rc.2.23454.2
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230905.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23428.2 -> To Version 8.0.0-alpha.1.23455.1
* Bump Microsoft.Private.Intellisense package version
(cherry picked from commit 94d7ad5)
* Update dependencies from https://github.com/dotnet/emsdk build 20230905.2
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.2.23431.1 -> To Version 8.0.0-rc.2.23455.2
* Update dependencies from https://github.com/dotnet/emsdk build 20230905.4
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.2.23431.1 -> To Version 8.0.0-rc.2.23455.4
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
@github-actions@layomia
Enable output compilation validation in binder gen unit tests (dotnet…
1222f14
…#91602)
Co-authored-by: Layomi Akinrinade <laakinri@microsoft.com>
@github-actions@layomia
[release/8.0] Enable interceptors implicitly in binder gen nupkg when…
e500806
… generator is enabled (dotnet#91559)
* Enable interceptors implicitly in binder gen nupkg when generator is enabled
* Simplify impl & remove unneeded target
---------
Co-authored-by: Layomi Akinrinade <laakinri@microsoft.com>
dotnet-maestroBotand others added 8 commits October 2, 2023 19:39
@dotnet-maestro@GrabYourPitchforks@333fred
[release/8.0] Update dependencies from dotnet/roslyn (dotnet#92503)
ef6283a
* Update dependencies from https://github.com/dotnet/roslyn build 20230922.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.3
* Update dependencies from https://github.com/dotnet/roslyn build 20230922.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.4
* Update dependencies from https://github.com/dotnet/roslyn build 20230922.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.5
* Update dependencies from https://github.com/dotnet/roslyn build 20230922.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.6
* Update dependencies from https://github.com/dotnet/roslyn build 20230922.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.7
* Update dependencies from https://github.com/dotnet/roslyn build 20230922.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.8
* Update dependencies from https://github.com/dotnet/roslyn build 20230922.9
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.9
* Update dependencies from https://github.com/dotnet/roslyn build 20230922.10
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.10
* Update dependencies from https://github.com/dotnet/roslyn build 20230923.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23473.1
* Update dependencies from https://github.com/dotnet/roslyn build 20230923.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23473.2
* Update dependencies from https://github.com/dotnet/roslyn build 20230923.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23473.3
* Update dependencies from https://github.com/dotnet/roslyn build 20230923.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23473.4
* Update dependencies from https://github.com/dotnet/roslyn build 20230924.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23474.1
* Update dependencies from https://github.com/dotnet/roslyn build 20230924.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23474.2
* Update dependencies from https://github.com/dotnet/roslyn build 20230924.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23474.3
* Update dependencies from https://github.com/dotnet/roslyn build 20230925.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.1
* Update dependencies from https://github.com/dotnet/roslyn build 20230925.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.2
* Update dependencies from https://github.com/dotnet/roslyn build 20230925.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.3
* Update dependencies from https://github.com/dotnet/roslyn build 20230925.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.4
* Update dependencies from https://github.com/dotnet/roslyn build 20230925.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.5
* Update dependencies from https://github.com/dotnet/roslyn build 20230925.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.6
* Update dependencies from https://github.com/dotnet/roslyn build 20230925.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.7
* Update dependencies from https://github.com/dotnet/roslyn build 20230925.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.8
* Update dependencies from https://github.com/dotnet/roslyn build 20230925.10
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.10
* Update dependencies from https://github.com/dotnet/roslyn build 20230926.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23476.3
* Update dependencies from https://github.com/dotnet/roslyn build 20230926.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23476.6
* Small refactor to BuildElement to address NRT changes
* Update dependencies from https://github.com/dotnet/roslyn build 20230926.13
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23476.13
* Update dependencies from https://github.com/dotnet/roslyn build 20230926.14
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23476.14
* Update dependencies from https://github.com/dotnet/roslyn build 20230926.15
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23476.15
* Update dependencies from https://github.com/dotnet/roslyn build 20230926.21
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23476.21
* Update dependencies from https://github.com/dotnet/roslyn build 20230926.22
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23476.22
* Update dependencies from https://github.com/dotnet/roslyn build 20230927.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23477.1
* Update dependencies from https://github.com/dotnet/roslyn build 20230927.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23477.4
* Update dependencies from https://github.com/dotnet/roslyn build 20230928.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23478.3
* Update dependencies from https://github.com/dotnet/roslyn build 20230928.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23478.4
* Update dependencies from https://github.com/dotnet/roslyn build 20231001.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23501.1
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Levi Broderick <levib@microsoft.com>
Co-authored-by: Fred Silberberg <frsilb@microsoft.com>
@layomia@carlossanlop
Make config binding gen incremental (dotnet#89587) (dotnet#92730)
bc0f1b0
* Make config binding gen incremental
* Iterate on implementation
* Add incremental tests & driver
* Make incremental tests pass and revert functional regression
* Address failing tests
* Make tests pass
* Suppress diagnostic
* Address feedback on diag info creation
* Refactor member access expr parsing to indicate assumptions
* Address feedback & do misc clean up
* Adjust model to minimize baseline diff / misc clean up
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
@github-actions@saitama951@lambdageek
[release/8.0] [wasm] Endian fix for Webcil (dotnet#92495)
2e50c1e
* [wasm] Endian fix for Webcil
'dotnet new blazorwasm' command failed on s390x and was throwing a not implemented exception
The issue was with with the WebCil writer and reader, specific endianness conversions relating to the webcil payload were not implemented for big endian machines.
We considered fixing the generic implementation, but there were only two structures in use: WebcilHeader and WebcilSectionHeader, so it was easier to handle them explicitly.
* Fix infinite recursion
* rename var
---------
Co-authored-by: Sanjam Panda <sanjam.panda@ibm.com>
Co-authored-by: Aleksey Kliger (λgeek) <alklig@microsoft.com>
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/source-build-exter…
dedfe8e
…nals build 20231002.1 (dotnet#92935)
Microsoft.SourceBuild.Intermediate.source-build-externals
From Version 8.0.0-alpha.1.23475.1 -> To Version 8.0.0-alpha.1.23502.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@dotnet-maestro
[release/8.0] Update dependencies from dotnet/cecil dotnet/hotreload-…
a7c9419
…utils (dotnet#92932)
* Update dependencies from https://github.com/dotnet/cecil build 20231002.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@radical
[release/8.0][wasm] Use intended ports when runningDevServer(dotn…
0eeb6b2
…et#92906)
* [wasm] Ignore empty `$ASPNETCORE_URLS`
* [wasm] DevServer: honor urls specified in the options
* [wasm] CI: Don't trigger non-wbt jobs on wasm-app-host changes
* CI: don't trigger wasm runtime tests on wasm-app-host changes
* [wasm] wasmbrowser - change the default webserver port to 0, to randomly select a port
@github-actions@davmason
Update EventPipeEventDispatcher.cs (dotnet#92912)
937cfcd
Co-authored-by: David Mason <davmason@microsoft.com>
@radical
CI: runtime-wasm-perf: disable for PRs
b6222f4
@radicalradical added the arch-wasm WebAssembly architecture label Oct 3, 2023
@radicalradical closed this Oct 3, 2023
@ghost

ghost commented Oct 3, 2023

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghostghost assigned radicalOct 3, 2023
@ghost

ghost commented Oct 3, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
Author:radical
Assignees:-
Labels:

arch-wasm

Milestone:-

@radical
radical deleted the runtime-wasm-perf-triggers-8 branch October 4, 2023 19:31
@ghostghost locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeffhandleyjeffhandleyAwaiting requested review from jeffhandleyjeffhandley is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomersbomer is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@kgkgAwaiting requested review from kg
@vargazvargazAwaiting requested review from vargaz
@lambdageeklambdageekAwaiting requested review from lambdageek
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmiloskotlarmilos is a code owner
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-System.Reflection.Metadatanew-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[wasm] Invoking async [JSExport] and [JSImport] kills the process on node, but works in browser

19 participants

@radical@dotnet-bot@layomia@janvorli@dkurepa@jakobbotsch@vseanreesermsft@carlossanlop@hoyosjs@cshung@NikolaMilosavljevic@tarekgh@filipnavara@HongGit@MSDN-WhiteKnight@ViktorHofer@ericstj@stephentoub@krwq