Skip to content

[release/8.0] [browser] ENVIRONMENT_IS_WEB is also true on WebWorker - #91627

Merged
carlossanlop merged 3 commits into
release/8.0from
backport/pr-91589-to-release/8.0
Sep 15, 2023
Merged

[release/8.0] [browser] ENVIRONMENT_IS_WEB is also true on WebWorker#91627
carlossanlop merged 3 commits into
release/8.0from
backport/pr-91589-to-release/8.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Sep 5, 2023•
edited by pavelsavara
Loading

Copy link
Copy Markdown
Contributor

Backport of #91589 to release/8.0

/cc @pavelsavara

Customer Impact

Fixes customer reported issue #91528

When dotnet is started from web worker, it will exit after first async Task/Promise or GC.

Testing

Manual testing and CI

Risk

Corner case use-case fixed.
It may impact multi-threading build which is not supported on Net8 yet.
It should have no impact for Blazor.

@ghostghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 5, 2023
@pavelsavarapavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Sep 5, 2023
@ghost

ghost commented Sep 5, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #91589 to release/8.0

/cc @pavelsavara

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, needs-area-label, os-browser

Milestone:-

@pavelsavarapavelsavara self-assigned this Sep 5, 2023
@pavelsavarapavelsavara added the Servicing-consider Issue for next servicing release review label Sep 5, 2023
@pavelsavarapavelsavara added this to the 8.0.0 milestone Sep 5, 2023
kg
kg approved these changes Sep 5, 2023
View reviewed changes
@lewinglewing removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 5, 2023
@carlossanlop

carlossanlop commented Sep 15, 2023

Copy link
Copy Markdown
Contributor

@marek-safar@lewing can we get your seal of approval here?

@carlossanlopcarlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 15, 2023
@carlossanlop
carlossanlop merged commit 28e72d2 into release/8.0Sep 15, 2023
@carlossanlop
carlossanlop deleted the backport/pr-91589-to-release/8.0 branch September 15, 2023 17:21
@radicalradical mentioned this pull request Sep 26, 2023
Closed
@radicalradical mentioned this pull request Oct 3, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marek-safarmarek-safarmarek-safar approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner
@lambdageeklambdageekAwaiting requested review from lambdageek
@marafmarafAwaiting requested review from maraf
+1 more reviewer
@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptos-browserBrowser variant of arch-wasmServicing-approvedApproved for servicing release

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@carlossanlop@kg@marek-safar@lewing@pavelsavara