Skip to content

[release/8.0] Remove implicit narrowing conversions from zlib - #91962

Merged
carlossanlop merged 3 commits into
release/8.0from
backport/pr-91245-to-release/8.0
Sep 14, 2023
Merged

[release/8.0] Remove implicit narrowing conversions from zlib#91962
carlossanlop merged 3 commits into
release/8.0from
backport/pr-91245-to-release/8.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Sep 12, 2023•
edited by GrabYourPitchforks
Loading

Copy link
Copy Markdown
Contributor

Backport of #91245 to release/8.0

/cc @GrabYourPitchforks

Customer Impact

No customer impact, in theory. The actual codegen for the targeted methods should be identical.

This allows us to resolve a binskim warning (we didn't enable warning code C4244) against our compression binary.

Testing

From #91245:

On my Windows x64 box, I validated the zlib-intel build under MSVC. Then I changed my local .cmake files to force usage of zlib instead of zlib-intel and validated that it built correctly under MSVC. On my WSL box, I modified my local .cmake files to force it to use these zlib sources instead of the OS's inbox zlib. I also injected an #error line into deflate.c just to confirm that clang was in fact using our local files.

Risk

Very low. The actual codegen should be identical. Testing across Linux (a special build which uses our copy of zlib) and Windows didn't show any regressions.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost

ghost commented Sep 12, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #91245 to release/8.0

/cc @GrabYourPitchforks

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

area-Infrastructure-libraries

Milestone:-

@ghost

ghost commented Sep 12, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #91245 to release/8.0

/cc @GrabYourPitchforks

Customer Impact

No customer impact, in theory. The actual codegen for the targeted methods should be identical.

This allows us to resolve a binskim warning (we didn't enable warning code C4244) against our compression binary.

Testing

From #91245:

On my Windows x64 box, I validated the zlib-intel build under MSVC. Then I changed my local .cmake files to force usage of zlib instead of zlib-intel and validated that it built correctly under MSVC. On my WSL box, I modified my local .cmake files to force it to use these zlib sources instead of the OS's inbox zlib. I also injected an #error line into deflate.c just to confirm that clang was in fact using our local files.

Risk

Very low. The actual codegen should be identical. Testing across Linux (a special build which uses our copy of zlib) and Windows didn't show any regressions.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

Servicing-consider, area-System.IO.Compression

Milestone:-

@GrabYourPitchforksGrabYourPitchforks added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 12, 2023
This was referenced Sep 13, 2023
Closed
Closed
Closed
carlossanlop
carlossanlop approved these changes Sep 14, 2023
View reviewed changes

@carlossanlopcarlossanlop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off on behalf of @dotnet/area-system-io-compression

@ericstj / @jeffhandley / @artl93 do you approve?

jeffhandley
jeffhandley approved these changes Sep 14, 2023
View reviewed changes

@jeffhandleyjeffhandley left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support merging this in for .NET 8 to resolve a binskim warning before release.

@ericstj

ericstj commented Sep 14, 2023

Copy link
Copy Markdown
Member

Have we proposed the same changes to upstream ZLIBs? Patches are fine to unblock us, but we should do our best to let the upstream repo know about this request.

I'm in agreement on approving for 8.0

@carlossanlop

carlossanlop commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

Have we proposed the same changes to upstream ZLIBs?

@ericstj Yes:

madler/zlib#852
intel/zlib#41

@carlossanlop

carlossanlop commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

@artl93 can we get your seal of approval?

artl93
artl93 approved these changes Sep 14, 2023
View reviewed changes

@artl93artl93 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M2 Approved.

@carlossanlop
carlossanlop merged commit dbd7885 into release/8.0Sep 14, 2023
@carlossanlop
carlossanlop deleted the backport/pr-91245-to-release/8.0 branch September 14, 2023 20:19
@radicalradical mentioned this pull request Sep 26, 2023
Closed
@radicalradical mentioned this pull request Oct 3, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeffhandleyjeffhandleyjeffhandley approved these changes
@artl93artl93artl93 approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safarmarek-safar is a code owner
+1 more reviewer
@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.IO.CompressionServicing-approvedApproved for servicing release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ericstj@carlossanlop@jeffhandley@artl93@GrabYourPitchforks
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[release/8.0] Remove implicit narrowing conversions from zlib by github-actions[bot] · Pull Request #91962 · dotnet/runtime · GitHub
Skip to content
[release/8.0] Remove implicit narrowing conversions from zlib - #91962
Merged
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-91245-to-release/8.0
Sep 14, 2023
Merged
[release/8.0] Remove implicit narrowing conversions from zlib#91962
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-91245-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 12, 2023•

edited by GrabYourPitchforks

Loading

Copy link


Copy Markdown

Contributor
Backport of #91245 to release/8.0
/cc @GrabYourPitchforks
Customer Impact
No customer impact, in theory. The actual codegen for the targeted methods should be identical.
This allows us to resolve a binskim warning (we didn't enable warning code C4244) against our compression binary.
Testing
From #91245:
On my Windows x64 box, I validated the zlib-intel build under MSVC. Then I changed my local .cmake files to force usage of zlib instead of zlib-intel and validated that it built correctly under MSVC. On my WSL box, I modified my local .cmake files to force it to use these zlib sources instead of the OS's inbox zlib. I also injected an #error line into deflate.c just to confirm that clang was in fact using our local files.
Risk
Very low. The actual codegen should be identical. Testing across Linux (a special build which uses our copy of zlib) and Windows didn't show any regressions.
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
@ghost
ghost
commented
Sep 12, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #91245 to release/8.0
/cc @GrabYourPitchforks
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-Infrastructure-libraries
Milestone:-
@ghost
ghost
commented
Sep 12, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-io-compression

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #91245 to release/8.0
/cc @GrabYourPitchforks
Customer Impact
No customer impact, in theory. The actual codegen for the targeted methods should be identical.
This allows us to resolve a binskim warning (we didn't enable warning code C4244) against our compression binary.
Testing
From #91245:
On my Windows x64 box, I validated the zlib-intel build under MSVC. Then I changed my local .cmake files to force usage of zlib instead of zlib-intel and validated that it built correctly under MSVC. On my WSL box, I modified my local .cmake files to force it to use these zlib sources instead of the OS's inbox zlib. I also injected an #error line into deflate.c just to confirm that clang was in fact using our local files.
Risk
Very low. The actual codegen should be identical. Testing across Linux (a special build which uses our copy of zlib) and Windows didn't show any regressions.
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
Servicing-consider, area-System.IO.Compression
Milestone:-
@GrabYourPitchforksGrabYourPitchforks
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 12, 2023

This was referenced Sep 13, 2023

Closed


Closed


Closed

carlossanlop
carlossanlop
approved these changes
Sep 14, 2023
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off on behalf of @dotnet/area-system-io-compression
@ericstj / @jeffhandley / @artl93 do you approve?
jeffhandley
jeffhandley
approved these changes
Sep 14, 2023
View reviewed changes
@jeffhandleyjeffhandley
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support merging this in for .NET 8 to resolve a binskim warning before release.
@ericstj
ericstj
commented
Sep 14, 2023

Copy link


Copy Markdown

Member
Have we proposed the same changes to upstream ZLIBs? Patches are fine to unblock us, but we should do our best to let the upstream repo know about this request.
I'm in agreement on approving for 8.0
@carlossanlop
carlossanlop
commented
Sep 14, 2023

Copy link


Copy Markdown

Contributor
Have we proposed the same changes to upstream ZLIBs?
@ericstj Yes:
madler/zlib#852
intel/zlib#41
@carlossanlop
carlossanlop
commented
Sep 14, 2023

Copy link


Copy Markdown

Contributor
@artl93 can we get your seal of approval?
artl93
artl93
approved these changes
Sep 14, 2023
View reviewed changes
@artl93artl93
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M2 Approved.
@carlossanlop
carlossanlop
merged commit dbd7885
into
release/8.0Sep 14, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-91245-to-release/8.0

branch
September 14, 2023 20:19
@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 15, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jeffhandleyjeffhandleyjeffhandley approved these changes
@artl93artl93artl93 approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safarmarek-safar is a code owner

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-System.IO.CompressionServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@ericstj@carlossanlop@jeffhandley@artl93@GrabYourPitchforks

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] Remove implicit narrowing conversions from zlib by github-actions[bot] · Pull Request #91962 · dotnet/runtime · GitHub
Skip to content
[release/8.0] Remove implicit narrowing conversions from zlib - #91962
Merged
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-91245-to-release/8.0
Sep 14, 2023
Merged
[release/8.0] Remove implicit narrowing conversions from zlib#91962
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-91245-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 12, 2023•

edited by GrabYourPitchforks

Loading

Copy link


Copy Markdown

Contributor
Backport of #91245 to release/8.0
/cc @GrabYourPitchforks
Customer Impact
No customer impact, in theory. The actual codegen for the targeted methods should be identical.
This allows us to resolve a binskim warning (we didn't enable warning code C4244) against our compression binary.
Testing
From #91245:
On my Windows x64 box, I validated the zlib-intel build under MSVC. Then I changed my local .cmake files to force usage of zlib instead of zlib-intel and validated that it built correctly under MSVC. On my WSL box, I modified my local .cmake files to force it to use these zlib sources instead of the OS's inbox zlib. I also injected an #error line into deflate.c just to confirm that clang was in fact using our local files.
Risk
Very low. The actual codegen should be identical. Testing across Linux (a special build which uses our copy of zlib) and Windows didn't show any regressions.
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
@ghost
ghost
commented
Sep 12, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #91245 to release/8.0
/cc @GrabYourPitchforks
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-Infrastructure-libraries
Milestone:-
@ghost
ghost
commented
Sep 12, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-io-compression

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #91245 to release/8.0
/cc @GrabYourPitchforks
Customer Impact
No customer impact, in theory. The actual codegen for the targeted methods should be identical.
This allows us to resolve a binskim warning (we didn't enable warning code C4244) against our compression binary.
Testing
From #91245:
On my Windows x64 box, I validated the zlib-intel build under MSVC. Then I changed my local .cmake files to force usage of zlib instead of zlib-intel and validated that it built correctly under MSVC. On my WSL box, I modified my local .cmake files to force it to use these zlib sources instead of the OS's inbox zlib. I also injected an #error line into deflate.c just to confirm that clang was in fact using our local files.
Risk
Very low. The actual codegen should be identical. Testing across Linux (a special build which uses our copy of zlib) and Windows didn't show any regressions.
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
Servicing-consider, area-System.IO.Compression
Milestone:-
@GrabYourPitchforksGrabYourPitchforks
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 12, 2023

This was referenced Sep 13, 2023

Closed


Closed


Closed

carlossanlop
carlossanlop
approved these changes
Sep 14, 2023
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off on behalf of @dotnet/area-system-io-compression
@ericstj / @jeffhandley / @artl93 do you approve?
jeffhandley
jeffhandley
approved these changes
Sep 14, 2023
View reviewed changes
@jeffhandleyjeffhandley
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support merging this in for .NET 8 to resolve a binskim warning before release.
@ericstj
ericstj
commented
Sep 14, 2023

Copy link


Copy Markdown

Member
Have we proposed the same changes to upstream ZLIBs? Patches are fine to unblock us, but we should do our best to let the upstream repo know about this request.
I'm in agreement on approving for 8.0
@carlossanlop
carlossanlop
commented
Sep 14, 2023

Copy link


Copy Markdown

Contributor
Have we proposed the same changes to upstream ZLIBs?
@ericstj Yes:
madler/zlib#852
intel/zlib#41
@carlossanlop
carlossanlop
commented
Sep 14, 2023

Copy link


Copy Markdown

Contributor
@artl93 can we get your seal of approval?
artl93
artl93
approved these changes
Sep 14, 2023
View reviewed changes
@artl93artl93
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M2 Approved.
@carlossanlop
carlossanlop
merged commit dbd7885
into
release/8.0Sep 14, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-91245-to-release/8.0

branch
September 14, 2023 20:19
@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 15, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jeffhandleyjeffhandleyjeffhandley approved these changes
@artl93artl93artl93 approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safarmarek-safar is a code owner

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-System.IO.CompressionServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@ericstj@carlossanlop@jeffhandley@artl93@GrabYourPitchforks

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] Remove implicit narrowing conversions from zlib by github-actions[bot] · Pull Request #91962 · dotnet/runtime · GitHub
Skip to content
[release/8.0] Remove implicit narrowing conversions from zlib - #91962
Merged
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-91245-to-release/8.0
Sep 14, 2023
Merged
[release/8.0] Remove implicit narrowing conversions from zlib#91962
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-91245-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 12, 2023•

edited by GrabYourPitchforks

Loading

Copy link


Copy Markdown

Contributor
Backport of #91245 to release/8.0
/cc @GrabYourPitchforks
Customer Impact
No customer impact, in theory. The actual codegen for the targeted methods should be identical.
This allows us to resolve a binskim warning (we didn't enable warning code C4244) against our compression binary.
Testing
From #91245:
On my Windows x64 box, I validated the zlib-intel build under MSVC. Then I changed my local .cmake files to force usage of zlib instead of zlib-intel and validated that it built correctly under MSVC. On my WSL box, I modified my local .cmake files to force it to use these zlib sources instead of the OS's inbox zlib. I also injected an #error line into deflate.c just to confirm that clang was in fact using our local files.
Risk
Very low. The actual codegen should be identical. Testing across Linux (a special build which uses our copy of zlib) and Windows didn't show any regressions.
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
@ghost
ghost
commented
Sep 12, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #91245 to release/8.0
/cc @GrabYourPitchforks
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-Infrastructure-libraries
Milestone:-
@ghost
ghost
commented
Sep 12, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-io-compression

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #91245 to release/8.0
/cc @GrabYourPitchforks
Customer Impact
No customer impact, in theory. The actual codegen for the targeted methods should be identical.
This allows us to resolve a binskim warning (we didn't enable warning code C4244) against our compression binary.
Testing
From #91245:
On my Windows x64 box, I validated the zlib-intel build under MSVC. Then I changed my local .cmake files to force usage of zlib instead of zlib-intel and validated that it built correctly under MSVC. On my WSL box, I modified my local .cmake files to force it to use these zlib sources instead of the OS's inbox zlib. I also injected an #error line into deflate.c just to confirm that clang was in fact using our local files.
Risk
Very low. The actual codegen should be identical. Testing across Linux (a special build which uses our copy of zlib) and Windows didn't show any regressions.
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
Servicing-consider, area-System.IO.Compression
Milestone:-
@GrabYourPitchforksGrabYourPitchforks
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 12, 2023

This was referenced Sep 13, 2023

Closed


Closed


Closed

carlossanlop
carlossanlop
approved these changes
Sep 14, 2023
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off on behalf of @dotnet/area-system-io-compression
@ericstj / @jeffhandley / @artl93 do you approve?
jeffhandley
jeffhandley
approved these changes
Sep 14, 2023
View reviewed changes
@jeffhandleyjeffhandley
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support merging this in for .NET 8 to resolve a binskim warning before release.
@ericstj
ericstj
commented
Sep 14, 2023

Copy link


Copy Markdown

Member
Have we proposed the same changes to upstream ZLIBs? Patches are fine to unblock us, but we should do our best to let the upstream repo know about this request.
I'm in agreement on approving for 8.0
@carlossanlop
carlossanlop
commented
Sep 14, 2023

Copy link


Copy Markdown

Contributor
Have we proposed the same changes to upstream ZLIBs?
@ericstj Yes:
madler/zlib#852
intel/zlib#41
@carlossanlop
carlossanlop
commented
Sep 14, 2023

Copy link


Copy Markdown

Contributor
@artl93 can we get your seal of approval?
artl93
artl93
approved these changes
Sep 14, 2023
View reviewed changes
@artl93artl93
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M2 Approved.
@carlossanlop
carlossanlop
merged commit dbd7885
into
release/8.0Sep 14, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-91245-to-release/8.0

branch
September 14, 2023 20:19
@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 15, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jeffhandleyjeffhandleyjeffhandley approved these changes
@artl93artl93artl93 approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safarmarek-safar is a code owner

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-System.IO.CompressionServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@ericstj@carlossanlop@jeffhandley@artl93@GrabYourPitchforks

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[release/8.0] Remove implicit narrowing conversions from zlib by github-actions[bot] · Pull Request #91962 · dotnet/runtime · GitHub
Skip to content
[release/8.0] Remove implicit narrowing conversions from zlib - #91962
Merged
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-91245-to-release/8.0
Sep 14, 2023
Merged
[release/8.0] Remove implicit narrowing conversions from zlib#91962
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-91245-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 12, 2023•

edited by GrabYourPitchforks

Loading

Copy link


Copy Markdown

Contributor
Backport of #91245 to release/8.0
/cc @GrabYourPitchforks
Customer Impact
No customer impact, in theory. The actual codegen for the targeted methods should be identical.
This allows us to resolve a binskim warning (we didn't enable warning code C4244) against our compression binary.
Testing
From #91245:
On my Windows x64 box, I validated the zlib-intel build under MSVC. Then I changed my local .cmake files to force usage of zlib instead of zlib-intel and validated that it built correctly under MSVC. On my WSL box, I modified my local .cmake files to force it to use these zlib sources instead of the OS's inbox zlib. I also injected an #error line into deflate.c just to confirm that clang was in fact using our local files.
Risk
Very low. The actual codegen should be identical. Testing across Linux (a special build which uses our copy of zlib) and Windows didn't show any regressions.
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
@ghost
ghost
commented
Sep 12, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #91245 to release/8.0
/cc @GrabYourPitchforks
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-Infrastructure-libraries
Milestone:-
@ghost
ghost
commented
Sep 12, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-io-compression

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #91245 to release/8.0
/cc @GrabYourPitchforks
Customer Impact
No customer impact, in theory. The actual codegen for the targeted methods should be identical.
This allows us to resolve a binskim warning (we didn't enable warning code C4244) against our compression binary.
Testing
From #91245:
On my Windows x64 box, I validated the zlib-intel build under MSVC. Then I changed my local .cmake files to force usage of zlib instead of zlib-intel and validated that it built correctly under MSVC. On my WSL box, I modified my local .cmake files to force it to use these zlib sources instead of the OS's inbox zlib. I also injected an #error line into deflate.c just to confirm that clang was in fact using our local files.
Risk
Very low. The actual codegen should be identical. Testing across Linux (a special build which uses our copy of zlib) and Windows didn't show any regressions.
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
Servicing-consider, area-System.IO.Compression
Milestone:-
@GrabYourPitchforksGrabYourPitchforks
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 12, 2023

This was referenced Sep 13, 2023

Closed


Closed


Closed

carlossanlop
carlossanlop
approved these changes
Sep 14, 2023
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off on behalf of @dotnet/area-system-io-compression
@ericstj / @jeffhandley / @artl93 do you approve?
jeffhandley
jeffhandley
approved these changes
Sep 14, 2023
View reviewed changes
@jeffhandleyjeffhandley
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support merging this in for .NET 8 to resolve a binskim warning before release.
@ericstj
ericstj
commented
Sep 14, 2023

Copy link


Copy Markdown

Member
Have we proposed the same changes to upstream ZLIBs? Patches are fine to unblock us, but we should do our best to let the upstream repo know about this request.
I'm in agreement on approving for 8.0
@carlossanlop
carlossanlop
commented
Sep 14, 2023

Copy link


Copy Markdown

Contributor
Have we proposed the same changes to upstream ZLIBs?
@ericstj Yes:
madler/zlib#852
intel/zlib#41
@carlossanlop
carlossanlop
commented
Sep 14, 2023

Copy link


Copy Markdown

Contributor
@artl93 can we get your seal of approval?
artl93
artl93
approved these changes
Sep 14, 2023
View reviewed changes
@artl93artl93
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M2 Approved.
@carlossanlop
carlossanlop
merged commit dbd7885
into
release/8.0Sep 14, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-91245-to-release/8.0

branch
September 14, 2023 20:19
@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 15, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jeffhandleyjeffhandleyjeffhandley approved these changes
@artl93artl93artl93 approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safarmarek-safar is a code owner

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-System.IO.CompressionServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@ericstj@carlossanlop@jeffhandley@artl93@GrabYourPitchforks

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] Remove implicit narrowing conversions from zlib by github-actions[bot] · Pull Request #91962 · dotnet/runtime · GitHub
Skip to content
[release/8.0] Remove implicit narrowing conversions from zlib - #91962
Merged
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-91245-to-release/8.0
Sep 14, 2023
Merged
[release/8.0] Remove implicit narrowing conversions from zlib#91962
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-91245-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 12, 2023•

edited by GrabYourPitchforks

Loading

Copy link


Copy Markdown

Contributor
Backport of #91245 to release/8.0
/cc @GrabYourPitchforks
Customer Impact
No customer impact, in theory. The actual codegen for the targeted methods should be identical.
This allows us to resolve a binskim warning (we didn't enable warning code C4244) against our compression binary.
Testing
From #91245:
On my Windows x64 box, I validated the zlib-intel build under MSVC. Then I changed my local .cmake files to force usage of zlib instead of zlib-intel and validated that it built correctly under MSVC. On my WSL box, I modified my local .cmake files to force it to use these zlib sources instead of the OS's inbox zlib. I also injected an #error line into deflate.c just to confirm that clang was in fact using our local files.
Risk
Very low. The actual codegen should be identical. Testing across Linux (a special build which uses our copy of zlib) and Windows didn't show any regressions.
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
@ghost
ghost
commented
Sep 12, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #91245 to release/8.0
/cc @GrabYourPitchforks
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-Infrastructure-libraries
Milestone:-
@ghost
ghost
commented
Sep 12, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-io-compression

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #91245 to release/8.0
/cc @GrabYourPitchforks
Customer Impact
No customer impact, in theory. The actual codegen for the targeted methods should be identical.
This allows us to resolve a binskim warning (we didn't enable warning code C4244) against our compression binary.
Testing
From #91245:
On my Windows x64 box, I validated the zlib-intel build under MSVC. Then I changed my local .cmake files to force usage of zlib instead of zlib-intel and validated that it built correctly under MSVC. On my WSL box, I modified my local .cmake files to force it to use these zlib sources instead of the OS's inbox zlib. I also injected an #error line into deflate.c just to confirm that clang was in fact using our local files.
Risk
Very low. The actual codegen should be identical. Testing across Linux (a special build which uses our copy of zlib) and Windows didn't show any regressions.
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
Servicing-consider, area-System.IO.Compression
Milestone:-
@GrabYourPitchforksGrabYourPitchforks
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 12, 2023

This was referenced Sep 13, 2023

Closed


Closed


Closed

carlossanlop
carlossanlop
approved these changes
Sep 14, 2023
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off on behalf of @dotnet/area-system-io-compression
@ericstj / @jeffhandley / @artl93 do you approve?
jeffhandley
jeffhandley
approved these changes
Sep 14, 2023
View reviewed changes
@jeffhandleyjeffhandley
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support merging this in for .NET 8 to resolve a binskim warning before release.
@ericstj
ericstj
commented
Sep 14, 2023

Copy link


Copy Markdown

Member
Have we proposed the same changes to upstream ZLIBs? Patches are fine to unblock us, but we should do our best to let the upstream repo know about this request.
I'm in agreement on approving for 8.0
@carlossanlop
carlossanlop
commented
Sep 14, 2023

Copy link


Copy Markdown

Contributor
Have we proposed the same changes to upstream ZLIBs?
@ericstj Yes:
madler/zlib#852
intel/zlib#41
@carlossanlop
carlossanlop
commented
Sep 14, 2023

Copy link


Copy Markdown

Contributor
@artl93 can we get your seal of approval?
artl93
artl93
approved these changes
Sep 14, 2023
View reviewed changes
@artl93artl93
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M2 Approved.
@carlossanlop
carlossanlop
merged commit dbd7885
into
release/8.0Sep 14, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-91245-to-release/8.0

branch
September 14, 2023 20:19
@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 15, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jeffhandleyjeffhandleyjeffhandley approved these changes
@artl93artl93artl93 approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safarmarek-safar is a code owner

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-System.IO.CompressionServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@ericstj@carlossanlop@jeffhandley@artl93@GrabYourPitchforks

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[release/8.0] Remove implicit narrowing conversions from zlib by github-actions[bot] · Pull Request #91962 · dotnet/runtime · GitHub
Skip to content
[release/8.0] Remove implicit narrowing conversions from zlib - #91962
Merged
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-91245-to-release/8.0
Sep 14, 2023
Merged
[release/8.0] Remove implicit narrowing conversions from zlib#91962
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-91245-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 12, 2023•

edited by GrabYourPitchforks

Loading

Copy link


Copy Markdown

Contributor
Backport of #91245 to release/8.0
/cc @GrabYourPitchforks
Customer Impact
No customer impact, in theory. The actual codegen for the targeted methods should be identical.
This allows us to resolve a binskim warning (we didn't enable warning code C4244) against our compression binary.
Testing
From #91245:
On my Windows x64 box, I validated the zlib-intel build under MSVC. Then I changed my local .cmake files to force usage of zlib instead of zlib-intel and validated that it built correctly under MSVC. On my WSL box, I modified my local .cmake files to force it to use these zlib sources instead of the OS's inbox zlib. I also injected an #error line into deflate.c just to confirm that clang was in fact using our local files.
Risk
Very low. The actual codegen should be identical. Testing across Linux (a special build which uses our copy of zlib) and Windows didn't show any regressions.
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
@ghost
ghost
commented
Sep 12, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #91245 to release/8.0
/cc @GrabYourPitchforks
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-Infrastructure-libraries
Milestone:-
@ghost
ghost
commented
Sep 12, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-io-compression

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #91245 to release/8.0
/cc @GrabYourPitchforks
Customer Impact
No customer impact, in theory. The actual codegen for the targeted methods should be identical.
This allows us to resolve a binskim warning (we didn't enable warning code C4244) against our compression binary.
Testing
From #91245:
On my Windows x64 box, I validated the zlib-intel build under MSVC. Then I changed my local .cmake files to force usage of zlib instead of zlib-intel and validated that it built correctly under MSVC. On my WSL box, I modified my local .cmake files to force it to use these zlib sources instead of the OS's inbox zlib. I also injected an #error line into deflate.c just to confirm that clang was in fact using our local files.
Risk
Very low. The actual codegen should be identical. Testing across Linux (a special build which uses our copy of zlib) and Windows didn't show any regressions.
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
Servicing-consider, area-System.IO.Compression
Milestone:-
@GrabYourPitchforksGrabYourPitchforks
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 12, 2023

This was referenced Sep 13, 2023

Closed


Closed


Closed

carlossanlop
carlossanlop
approved these changes
Sep 14, 2023
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off on behalf of @dotnet/area-system-io-compression
@ericstj / @jeffhandley / @artl93 do you approve?
jeffhandley
jeffhandley
approved these changes
Sep 14, 2023
View reviewed changes
@jeffhandleyjeffhandley
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support merging this in for .NET 8 to resolve a binskim warning before release.
@ericstj
ericstj
commented
Sep 14, 2023

Copy link


Copy Markdown

Member
Have we proposed the same changes to upstream ZLIBs? Patches are fine to unblock us, but we should do our best to let the upstream repo know about this request.
I'm in agreement on approving for 8.0
@carlossanlop
carlossanlop
commented
Sep 14, 2023

Copy link


Copy Markdown

Contributor
Have we proposed the same changes to upstream ZLIBs?
@ericstj Yes:
madler/zlib#852
intel/zlib#41
@carlossanlop
carlossanlop
commented
Sep 14, 2023

Copy link


Copy Markdown

Contributor
@artl93 can we get your seal of approval?
artl93
artl93
approved these changes
Sep 14, 2023
View reviewed changes
@artl93artl93
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M2 Approved.
@carlossanlop
carlossanlop
merged commit dbd7885
into
release/8.0Sep 14, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-91245-to-release/8.0

branch
September 14, 2023 20:19
@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 15, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jeffhandleyjeffhandleyjeffhandley approved these changes
@artl93artl93artl93 approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safarmarek-safar is a code owner

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-System.IO.CompressionServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@ericstj@carlossanlop@jeffhandley@artl93@GrabYourPitchforks