Skip to content

[release/8.0] [wasi] Work around WASI's mmap implementation not returning aligned m… - #92061

Merged
carlossanlop merged 1 commit into
release/8.0from
backport/pr-91761-to-release/8.0
Sep 14, 2023
Merged

[release/8.0] [wasi] Work around WASI's mmap implementation not returning aligned m…#92061
carlossanlop merged 1 commit into
release/8.0from
backport/pr-91761-to-release/8.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Sep 14, 2023•
edited by SamMonoRT
Loading

Copy link
Copy Markdown
Contributor

Backport of #91761 to release/8.0

/cc @vargaz

Customer Impact

Enabling green CI when experimental feature is on - Only affects experimental WASI support. Mostly useful for fixing random CI failures like:
#86860

Testing

Tested by running a randomly failing test suite in a loop.

Risk

Low, only affects experimental WASI support.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@vargaz
[wasi] Work arounbd WASI's mmap implementation not returning aligned …
d3058e9
…memory.
Some code in sgen like sgen_los_free_object () expects the return address to be aligned.
Hopefully fixes#88501 and others.
@ghostghost added the area-VM-meta-mono label Sep 14, 2023
@SamMonoRTSamMonoRT added this to the 8.0.0 milestone Sep 14, 2023
@SamMonoRTSamMonoRT added the Servicing-consider Issue for next servicing release review label Sep 14, 2023
@vargazvargaz added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 14, 2023
@vargaz

vargaz commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

@carlossanlop

@carlossanlop
carlossanlop merged commit 0189dc4 into release/8.0Sep 14, 2023
@carlossanlop
carlossanlop deleted the backport/pr-91761-to-release/8.0 branch September 14, 2023 17:49
@carlossanlop

carlossanlop commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Oh I see this got backported. Unfortunately, I'm still seeing this failure in the 8.0 branch:

Here's an example PR that hit it: #92374
Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=413445&view=logs&j=f02b8cf9-dd4d-54fc-c292-2bb1d305b019&t=fd9015e5-cd94-57d7-8286-4fe749355863&l=56
Log: https://helixre107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-runtime-refs-heads-release-80-rc1-6a14376058b74ebebf/System.Collections.Tests/1/console.90d8fea5.log?helixlogtype=result
Output:

===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e /root/helix/work/workitem/e
[8.0.0-prerelease.23407.2+480b9159eb7e69b182a87581d5a336e97e0b6dae] XHarness command issued: wasi test --app=. --output-directory=/root/helix/work/workitem/uploads/xharness-output --engine-arg=--dir=. --timeout=00:30:00 -- dotnet.wasm WasmTestRunner managed/System.Collections.Tests.dll -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
info: Using wasm engine WasmTime from path /root/helix/work/correlation/wasmtime/wasmtime
info: wasmtime-cli 5.0.0
info: info: Running /root/helix/work/correlation/wasmtime/wasmtime --dir=. dotnet.wasm WasmTestRunner managed/System.Collections.Tests.dll -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
info: Discovering: managed/System.Collections.Tests.dll (method display = ClassAndMethod, method display options = None)
info: Discovered: managed/System.Collections.Tests.dll (found 5666 of 7580 test cases)
info: Using random seed for test cases: 1986925510
info: Using random seed for collections: 1986925510
info: Starting: managed/System.Collections.Tests.dll
info: Error: failed to run main module `dotnet.wasm`
info: info: Caused by:
info: 0: failed to invoke command default
info: 1: error while executing at wasm backtrace:
info: 0: 0x4ff1e - <unknown>!sgen_gray_object_queue_trim_free_list
info: 1: 0x4ffc3 - <unknown>!sgen_gray_object_queue_dispose
info: 2: 0x4b4fd - <unknown>!collect_nursery
info: 3: 0x4ada1 - <unknown>!sgen_perform_collection
info: 4: 0x4abd4 - <unknown>!sgen_ensure_free_space
info: 5: 0x49a0a - <unknown>!sgen_alloc_obj_nolock
info: 6: 0x4a0ea - <unknown>!sgen_alloc_obj
info: 7: 0x10e041 - <unknown>!mono_gc_alloc_obj
info: 8: 0xe617 - <unknown>!mono_interp_exec_method
info: 9: 0x8040 - <unknown>!interp_runtime_invoke
info: 10: 0x11d90f - <unknown>!mono_jit_runtime_invoke
info: 11: 0xe0f20 - <unknown>!do_runtime_invoke
info: 12: 0xe18ba - <unknown>!mono_runtime_try_invoke
info: 13: 0xe6101 - <unknown>!do_try_exec_main
info: 14: 0xe5ba0 - <unknown>!mono_runtime_run_main
info: 15: 0x68ac - <unknown>!main
info: 16: 0x272da8 - <unknown>!__main_void
info: 17: 0x5911 - <unknown>!_start
info: 18: 0x285f79 - <unknown>!_start.command_export
info: note: using the `WASMTIME_BACKTRACE_DETAILS=1` environment variable may show more debugging information
info: 2: wasm trap: out of bounds memory access
info: Process wasmtime exited with 134
info: Waiting to flush log messages with a timeout of 120 secs ..
fail: Application has finished with exit code 134 but 0 was expected
XHarness exit code: 71 (GENERAL_FAILURE)
/root/helix/work/workitem/e /root/helix/work/workitem/e
----- end Wed 20 Sep 2023 09:20:08 PM UTC ----- exit code 71 ----------------------------------------------------------

@radicalradical mentioned this pull request Sep 26, 2023
Closed
@radicalradical mentioned this pull request Oct 3, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Oct 22, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marek-safarmarek-safarmarek-safar approved these changes
@lambdageeklambdageeklambdageek approved these changes
@vargazvargazAwaiting requested review from vargaz

Assignees

@vargazvargaz

Labels

area-VM-meta-monoServicing-approvedApproved for servicing release

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@vargaz@carlossanlop@marek-safar@lambdageek@SamMonoRT
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[release/8.0] [wasi] Work around WASI's mmap implementation not returning aligned m… by github-actions[bot] · Pull Request #92061 · dotnet/runtime · GitHub
Skip to content
[release/8.0] [wasi] Work around WASI's mmap implementation not returning aligned m… - #92061
Merged
carlossanlop merged 1 commit into
release/8.0from 
backport/pr-91761-to-release/8.0
Sep 14, 2023
Merged
[release/8.0] [wasi] Work around WASI's mmap implementation not returning aligned m…#92061
carlossanlop merged 1 commit into
release/8.0from 
backport/pr-91761-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 14, 2023•

edited by SamMonoRT

Loading

Copy link


Copy Markdown

Contributor
Backport of #91761 to release/8.0
/cc @vargaz
Customer Impact
Enabling green CI when experimental feature is on - Only affects experimental WASI support. Mostly useful for fixing random CI failures like:
#86860
Testing
Tested by running a randomly failing test suite in a loop.
Risk
Low, only affects experimental WASI support.
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
@vargaz
[wasi] Work arounbd WASI's mmap implementation not returning aligned …
d3058e9
…memory.
Some code in sgen like sgen_los_free_object () expects the return address to be aligned.
Hopefully fixes#88501 and others.
@ghostghost
added
the 
area-VM-meta-mono

label
Sep 14, 2023
@SamMonoRTSamMonoRT
added this to the 8.0.0 milestone
Sep 14, 2023
@SamMonoRTSamMonoRT
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 14, 2023
@vargazvargaz
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 14, 2023
@vargaz
vargaz
commented
Sep 14, 2023

Copy link


Copy Markdown

Contributor
@carlossanlop
@carlossanlop
carlossanlop
merged commit 0189dc4
into
release/8.0Sep 14, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-91761-to-release/8.0

branch
September 14, 2023 17:49
@carlossanlop
carlossanlop
commented
Sep 21, 2023

Copy link


Copy Markdown

Contributor
Oh I see this got backported. Unfortunately, I'm still seeing this failure in the 8.0 branch:
Here's an example PR that hit it: #92374

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=413445&view=logs&j=f02b8cf9-dd4d-54fc-c292-2bb1d305b019&t=fd9015e5-cd94-57d7-8286-4fe749355863&l=56

Log: https://helixre107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-runtime-refs-heads-release-80-rc1-6a14376058b74ebebf/System.Collections.Tests/1/console.90d8fea5.log?helixlogtype=result

Output:
===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e /root/helix/work/workitem/e
[8.0.0-prerelease.23407.2+480b9159eb7e69b182a87581d5a336e97e0b6dae] XHarness command issued: wasi test --app=. --output-directory=/root/helix/work/workitem/uploads/xharness-output --engine-arg=--dir=. --timeout=00:30:00 -- dotnet.wasm WasmTestRunner managed/System.Collections.Tests.dll -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
info: Using wasm engine WasmTime from path /root/helix/work/correlation/wasmtime/wasmtime
info: wasmtime-cli 5.0.0
info: info: Running /root/helix/work/correlation/wasmtime/wasmtime --dir=. dotnet.wasm WasmTestRunner managed/System.Collections.Tests.dll -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
info: Discovering: managed/System.Collections.Tests.dll (method display = ClassAndMethod, method display options = None)
info: Discovered: managed/System.Collections.Tests.dll (found 5666 of 7580 test cases)
info: Using random seed for test cases: 1986925510
info: Using random seed for collections: 1986925510
info: Starting: managed/System.Collections.Tests.dll
info: Error: failed to run main module `dotnet.wasm`
info: info: Caused by:
info: 0: failed to invoke command default
info: 1: error while executing at wasm backtrace:
info: 0: 0x4ff1e - <unknown>!sgen_gray_object_queue_trim_free_list
info: 1: 0x4ffc3 - <unknown>!sgen_gray_object_queue_dispose
info: 2: 0x4b4fd - <unknown>!collect_nursery
info: 3: 0x4ada1 - <unknown>!sgen_perform_collection
info: 4: 0x4abd4 - <unknown>!sgen_ensure_free_space
info: 5: 0x49a0a - <unknown>!sgen_alloc_obj_nolock
info: 6: 0x4a0ea - <unknown>!sgen_alloc_obj
info: 7: 0x10e041 - <unknown>!mono_gc_alloc_obj
info: 8: 0xe617 - <unknown>!mono_interp_exec_method
info: 9: 0x8040 - <unknown>!interp_runtime_invoke
info: 10: 0x11d90f - <unknown>!mono_jit_runtime_invoke
info: 11: 0xe0f20 - <unknown>!do_runtime_invoke
info: 12: 0xe18ba - <unknown>!mono_runtime_try_invoke
info: 13: 0xe6101 - <unknown>!do_try_exec_main
info: 14: 0xe5ba0 - <unknown>!mono_runtime_run_main
info: 15: 0x68ac - <unknown>!main
info: 16: 0x272da8 - <unknown>!__main_void
info: 17: 0x5911 - <unknown>!_start
info: 18: 0x285f79 - <unknown>!_start.command_export
info: note: using the `WASMTIME_BACKTRACE_DETAILS=1` environment variable may show more debugging information
info: 2: wasm trap: out of bounds memory access
info: Process wasmtime exited with 134
info: Waiting to flush log messages with a timeout of 120 secs ..
fail: Application has finished with exit code 134 but 0 was expected
XHarness exit code: 71 (GENERAL_FAILURE)
/root/helix/work/workitem/e /root/helix/work/workitem/e
----- end Wed 20 Sep 2023 09:20:08 PM UTC ----- exit code 71 ----------------------------------------------------------

@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 22, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar approved these changes
@lambdageeklambdageeklambdageek approved these changes
@vargazvargazAwaiting requested review from vargaz

Assignees

@vargazvargaz

Labels

area-VM-meta-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@vargaz@carlossanlop@marek-safar@lambdageek@SamMonoRT

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] [wasi] Work around WASI's mmap implementation not returning aligned m… by github-actions[bot] · Pull Request #92061 · dotnet/runtime · GitHub
Skip to content
[release/8.0] [wasi] Work around WASI's mmap implementation not returning aligned m… - #92061
Merged
carlossanlop merged 1 commit into
release/8.0from 
backport/pr-91761-to-release/8.0
Sep 14, 2023
Merged
[release/8.0] [wasi] Work around WASI's mmap implementation not returning aligned m…#92061
carlossanlop merged 1 commit into
release/8.0from 
backport/pr-91761-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 14, 2023•

edited by SamMonoRT

Loading

Copy link


Copy Markdown

Contributor
Backport of #91761 to release/8.0
/cc @vargaz
Customer Impact
Enabling green CI when experimental feature is on - Only affects experimental WASI support. Mostly useful for fixing random CI failures like:
#86860
Testing
Tested by running a randomly failing test suite in a loop.
Risk
Low, only affects experimental WASI support.
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
@vargaz
[wasi] Work arounbd WASI's mmap implementation not returning aligned …
d3058e9
…memory.
Some code in sgen like sgen_los_free_object () expects the return address to be aligned.
Hopefully fixes#88501 and others.
@ghostghost
added
the 
area-VM-meta-mono

label
Sep 14, 2023
@SamMonoRTSamMonoRT
added this to the 8.0.0 milestone
Sep 14, 2023
@SamMonoRTSamMonoRT
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 14, 2023
@vargazvargaz
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 14, 2023
@vargaz
vargaz
commented
Sep 14, 2023

Copy link


Copy Markdown

Contributor
@carlossanlop
@carlossanlop
carlossanlop
merged commit 0189dc4
into
release/8.0Sep 14, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-91761-to-release/8.0

branch
September 14, 2023 17:49
@carlossanlop
carlossanlop
commented
Sep 21, 2023

Copy link


Copy Markdown

Contributor
Oh I see this got backported. Unfortunately, I'm still seeing this failure in the 8.0 branch:
Here's an example PR that hit it: #92374

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=413445&view=logs&j=f02b8cf9-dd4d-54fc-c292-2bb1d305b019&t=fd9015e5-cd94-57d7-8286-4fe749355863&l=56

Log: https://helixre107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-runtime-refs-heads-release-80-rc1-6a14376058b74ebebf/System.Collections.Tests/1/console.90d8fea5.log?helixlogtype=result

Output:
===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e /root/helix/work/workitem/e
[8.0.0-prerelease.23407.2+480b9159eb7e69b182a87581d5a336e97e0b6dae] XHarness command issued: wasi test --app=. --output-directory=/root/helix/work/workitem/uploads/xharness-output --engine-arg=--dir=. --timeout=00:30:00 -- dotnet.wasm WasmTestRunner managed/System.Collections.Tests.dll -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
info: Using wasm engine WasmTime from path /root/helix/work/correlation/wasmtime/wasmtime
info: wasmtime-cli 5.0.0
info: info: Running /root/helix/work/correlation/wasmtime/wasmtime --dir=. dotnet.wasm WasmTestRunner managed/System.Collections.Tests.dll -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
info: Discovering: managed/System.Collections.Tests.dll (method display = ClassAndMethod, method display options = None)
info: Discovered: managed/System.Collections.Tests.dll (found 5666 of 7580 test cases)
info: Using random seed for test cases: 1986925510
info: Using random seed for collections: 1986925510
info: Starting: managed/System.Collections.Tests.dll
info: Error: failed to run main module `dotnet.wasm`
info: info: Caused by:
info: 0: failed to invoke command default
info: 1: error while executing at wasm backtrace:
info: 0: 0x4ff1e - <unknown>!sgen_gray_object_queue_trim_free_list
info: 1: 0x4ffc3 - <unknown>!sgen_gray_object_queue_dispose
info: 2: 0x4b4fd - <unknown>!collect_nursery
info: 3: 0x4ada1 - <unknown>!sgen_perform_collection
info: 4: 0x4abd4 - <unknown>!sgen_ensure_free_space
info: 5: 0x49a0a - <unknown>!sgen_alloc_obj_nolock
info: 6: 0x4a0ea - <unknown>!sgen_alloc_obj
info: 7: 0x10e041 - <unknown>!mono_gc_alloc_obj
info: 8: 0xe617 - <unknown>!mono_interp_exec_method
info: 9: 0x8040 - <unknown>!interp_runtime_invoke
info: 10: 0x11d90f - <unknown>!mono_jit_runtime_invoke
info: 11: 0xe0f20 - <unknown>!do_runtime_invoke
info: 12: 0xe18ba - <unknown>!mono_runtime_try_invoke
info: 13: 0xe6101 - <unknown>!do_try_exec_main
info: 14: 0xe5ba0 - <unknown>!mono_runtime_run_main
info: 15: 0x68ac - <unknown>!main
info: 16: 0x272da8 - <unknown>!__main_void
info: 17: 0x5911 - <unknown>!_start
info: 18: 0x285f79 - <unknown>!_start.command_export
info: note: using the `WASMTIME_BACKTRACE_DETAILS=1` environment variable may show more debugging information
info: 2: wasm trap: out of bounds memory access
info: Process wasmtime exited with 134
info: Waiting to flush log messages with a timeout of 120 secs ..
fail: Application has finished with exit code 134 but 0 was expected
XHarness exit code: 71 (GENERAL_FAILURE)
/root/helix/work/workitem/e /root/helix/work/workitem/e
----- end Wed 20 Sep 2023 09:20:08 PM UTC ----- exit code 71 ----------------------------------------------------------

@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 22, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar approved these changes
@lambdageeklambdageeklambdageek approved these changes
@vargazvargazAwaiting requested review from vargaz

Assignees

@vargazvargaz

Labels

area-VM-meta-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@vargaz@carlossanlop@marek-safar@lambdageek@SamMonoRT

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] [wasi] Work around WASI's mmap implementation not returning aligned m… by github-actions[bot] · Pull Request #92061 · dotnet/runtime · GitHub
Skip to content
[release/8.0] [wasi] Work around WASI's mmap implementation not returning aligned m… - #92061
Merged
carlossanlop merged 1 commit into
release/8.0from 
backport/pr-91761-to-release/8.0
Sep 14, 2023
Merged
[release/8.0] [wasi] Work around WASI's mmap implementation not returning aligned m…#92061
carlossanlop merged 1 commit into
release/8.0from 
backport/pr-91761-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 14, 2023•

edited by SamMonoRT

Loading

Copy link


Copy Markdown

Contributor
Backport of #91761 to release/8.0
/cc @vargaz
Customer Impact
Enabling green CI when experimental feature is on - Only affects experimental WASI support. Mostly useful for fixing random CI failures like:
#86860
Testing
Tested by running a randomly failing test suite in a loop.
Risk
Low, only affects experimental WASI support.
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
@vargaz
[wasi] Work arounbd WASI's mmap implementation not returning aligned …
d3058e9
…memory.
Some code in sgen like sgen_los_free_object () expects the return address to be aligned.
Hopefully fixes#88501 and others.
@ghostghost
added
the 
area-VM-meta-mono

label
Sep 14, 2023
@SamMonoRTSamMonoRT
added this to the 8.0.0 milestone
Sep 14, 2023
@SamMonoRTSamMonoRT
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 14, 2023
@vargazvargaz
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 14, 2023
@vargaz
vargaz
commented
Sep 14, 2023

Copy link


Copy Markdown

Contributor
@carlossanlop
@carlossanlop
carlossanlop
merged commit 0189dc4
into
release/8.0Sep 14, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-91761-to-release/8.0

branch
September 14, 2023 17:49
@carlossanlop
carlossanlop
commented
Sep 21, 2023

Copy link


Copy Markdown

Contributor
Oh I see this got backported. Unfortunately, I'm still seeing this failure in the 8.0 branch:
Here's an example PR that hit it: #92374

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=413445&view=logs&j=f02b8cf9-dd4d-54fc-c292-2bb1d305b019&t=fd9015e5-cd94-57d7-8286-4fe749355863&l=56

Log: https://helixre107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-runtime-refs-heads-release-80-rc1-6a14376058b74ebebf/System.Collections.Tests/1/console.90d8fea5.log?helixlogtype=result

Output:
===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e /root/helix/work/workitem/e
[8.0.0-prerelease.23407.2+480b9159eb7e69b182a87581d5a336e97e0b6dae] XHarness command issued: wasi test --app=. --output-directory=/root/helix/work/workitem/uploads/xharness-output --engine-arg=--dir=. --timeout=00:30:00 -- dotnet.wasm WasmTestRunner managed/System.Collections.Tests.dll -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
info: Using wasm engine WasmTime from path /root/helix/work/correlation/wasmtime/wasmtime
info: wasmtime-cli 5.0.0
info: info: Running /root/helix/work/correlation/wasmtime/wasmtime --dir=. dotnet.wasm WasmTestRunner managed/System.Collections.Tests.dll -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
info: Discovering: managed/System.Collections.Tests.dll (method display = ClassAndMethod, method display options = None)
info: Discovered: managed/System.Collections.Tests.dll (found 5666 of 7580 test cases)
info: Using random seed for test cases: 1986925510
info: Using random seed for collections: 1986925510
info: Starting: managed/System.Collections.Tests.dll
info: Error: failed to run main module `dotnet.wasm`
info: info: Caused by:
info: 0: failed to invoke command default
info: 1: error while executing at wasm backtrace:
info: 0: 0x4ff1e - <unknown>!sgen_gray_object_queue_trim_free_list
info: 1: 0x4ffc3 - <unknown>!sgen_gray_object_queue_dispose
info: 2: 0x4b4fd - <unknown>!collect_nursery
info: 3: 0x4ada1 - <unknown>!sgen_perform_collection
info: 4: 0x4abd4 - <unknown>!sgen_ensure_free_space
info: 5: 0x49a0a - <unknown>!sgen_alloc_obj_nolock
info: 6: 0x4a0ea - <unknown>!sgen_alloc_obj
info: 7: 0x10e041 - <unknown>!mono_gc_alloc_obj
info: 8: 0xe617 - <unknown>!mono_interp_exec_method
info: 9: 0x8040 - <unknown>!interp_runtime_invoke
info: 10: 0x11d90f - <unknown>!mono_jit_runtime_invoke
info: 11: 0xe0f20 - <unknown>!do_runtime_invoke
info: 12: 0xe18ba - <unknown>!mono_runtime_try_invoke
info: 13: 0xe6101 - <unknown>!do_try_exec_main
info: 14: 0xe5ba0 - <unknown>!mono_runtime_run_main
info: 15: 0x68ac - <unknown>!main
info: 16: 0x272da8 - <unknown>!__main_void
info: 17: 0x5911 - <unknown>!_start
info: 18: 0x285f79 - <unknown>!_start.command_export
info: note: using the `WASMTIME_BACKTRACE_DETAILS=1` environment variable may show more debugging information
info: 2: wasm trap: out of bounds memory access
info: Process wasmtime exited with 134
info: Waiting to flush log messages with a timeout of 120 secs ..
fail: Application has finished with exit code 134 but 0 was expected
XHarness exit code: 71 (GENERAL_FAILURE)
/root/helix/work/workitem/e /root/helix/work/workitem/e
----- end Wed 20 Sep 2023 09:20:08 PM UTC ----- exit code 71 ----------------------------------------------------------

@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 22, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar approved these changes
@lambdageeklambdageeklambdageek approved these changes
@vargazvargazAwaiting requested review from vargaz

Assignees

@vargazvargaz

Labels

area-VM-meta-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@vargaz@carlossanlop@marek-safar@lambdageek@SamMonoRT

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[release/8.0] [wasi] Work around WASI's mmap implementation not returning aligned m… by github-actions[bot] · Pull Request #92061 · dotnet/runtime · GitHub
Skip to content
[release/8.0] [wasi] Work around WASI's mmap implementation not returning aligned m… - #92061
Merged
carlossanlop merged 1 commit into
release/8.0from 
backport/pr-91761-to-release/8.0
Sep 14, 2023
Merged
[release/8.0] [wasi] Work around WASI's mmap implementation not returning aligned m…#92061
carlossanlop merged 1 commit into
release/8.0from 
backport/pr-91761-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 14, 2023•

edited by SamMonoRT

Loading

Copy link


Copy Markdown

Contributor
Backport of #91761 to release/8.0
/cc @vargaz
Customer Impact
Enabling green CI when experimental feature is on - Only affects experimental WASI support. Mostly useful for fixing random CI failures like:
#86860
Testing
Tested by running a randomly failing test suite in a loop.
Risk
Low, only affects experimental WASI support.
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
@vargaz
[wasi] Work arounbd WASI's mmap implementation not returning aligned …
d3058e9
…memory.
Some code in sgen like sgen_los_free_object () expects the return address to be aligned.
Hopefully fixes#88501 and others.
@ghostghost
added
the 
area-VM-meta-mono

label
Sep 14, 2023
@SamMonoRTSamMonoRT
added this to the 8.0.0 milestone
Sep 14, 2023
@SamMonoRTSamMonoRT
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 14, 2023
@vargazvargaz
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 14, 2023
@vargaz
vargaz
commented
Sep 14, 2023

Copy link


Copy Markdown

Contributor
@carlossanlop
@carlossanlop
carlossanlop
merged commit 0189dc4
into
release/8.0Sep 14, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-91761-to-release/8.0

branch
September 14, 2023 17:49
@carlossanlop
carlossanlop
commented
Sep 21, 2023

Copy link


Copy Markdown

Contributor
Oh I see this got backported. Unfortunately, I'm still seeing this failure in the 8.0 branch:
Here's an example PR that hit it: #92374

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=413445&view=logs&j=f02b8cf9-dd4d-54fc-c292-2bb1d305b019&t=fd9015e5-cd94-57d7-8286-4fe749355863&l=56

Log: https://helixre107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-runtime-refs-heads-release-80-rc1-6a14376058b74ebebf/System.Collections.Tests/1/console.90d8fea5.log?helixlogtype=result

Output:
===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e /root/helix/work/workitem/e
[8.0.0-prerelease.23407.2+480b9159eb7e69b182a87581d5a336e97e0b6dae] XHarness command issued: wasi test --app=. --output-directory=/root/helix/work/workitem/uploads/xharness-output --engine-arg=--dir=. --timeout=00:30:00 -- dotnet.wasm WasmTestRunner managed/System.Collections.Tests.dll -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
info: Using wasm engine WasmTime from path /root/helix/work/correlation/wasmtime/wasmtime
info: wasmtime-cli 5.0.0
info: info: Running /root/helix/work/correlation/wasmtime/wasmtime --dir=. dotnet.wasm WasmTestRunner managed/System.Collections.Tests.dll -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
info: Discovering: managed/System.Collections.Tests.dll (method display = ClassAndMethod, method display options = None)
info: Discovered: managed/System.Collections.Tests.dll (found 5666 of 7580 test cases)
info: Using random seed for test cases: 1986925510
info: Using random seed for collections: 1986925510
info: Starting: managed/System.Collections.Tests.dll
info: Error: failed to run main module `dotnet.wasm`
info: info: Caused by:
info: 0: failed to invoke command default
info: 1: error while executing at wasm backtrace:
info: 0: 0x4ff1e - <unknown>!sgen_gray_object_queue_trim_free_list
info: 1: 0x4ffc3 - <unknown>!sgen_gray_object_queue_dispose
info: 2: 0x4b4fd - <unknown>!collect_nursery
info: 3: 0x4ada1 - <unknown>!sgen_perform_collection
info: 4: 0x4abd4 - <unknown>!sgen_ensure_free_space
info: 5: 0x49a0a - <unknown>!sgen_alloc_obj_nolock
info: 6: 0x4a0ea - <unknown>!sgen_alloc_obj
info: 7: 0x10e041 - <unknown>!mono_gc_alloc_obj
info: 8: 0xe617 - <unknown>!mono_interp_exec_method
info: 9: 0x8040 - <unknown>!interp_runtime_invoke
info: 10: 0x11d90f - <unknown>!mono_jit_runtime_invoke
info: 11: 0xe0f20 - <unknown>!do_runtime_invoke
info: 12: 0xe18ba - <unknown>!mono_runtime_try_invoke
info: 13: 0xe6101 - <unknown>!do_try_exec_main
info: 14: 0xe5ba0 - <unknown>!mono_runtime_run_main
info: 15: 0x68ac - <unknown>!main
info: 16: 0x272da8 - <unknown>!__main_void
info: 17: 0x5911 - <unknown>!_start
info: 18: 0x285f79 - <unknown>!_start.command_export
info: note: using the `WASMTIME_BACKTRACE_DETAILS=1` environment variable may show more debugging information
info: 2: wasm trap: out of bounds memory access
info: Process wasmtime exited with 134
info: Waiting to flush log messages with a timeout of 120 secs ..
fail: Application has finished with exit code 134 but 0 was expected
XHarness exit code: 71 (GENERAL_FAILURE)
/root/helix/work/workitem/e /root/helix/work/workitem/e
----- end Wed 20 Sep 2023 09:20:08 PM UTC ----- exit code 71 ----------------------------------------------------------

@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 22, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar approved these changes
@lambdageeklambdageeklambdageek approved these changes
@vargazvargazAwaiting requested review from vargaz

Assignees

@vargazvargaz

Labels

area-VM-meta-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@vargaz@carlossanlop@marek-safar@lambdageek@SamMonoRT

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] [wasi] Work around WASI's mmap implementation not returning aligned m… by github-actions[bot] · Pull Request #92061 · dotnet/runtime · GitHub
Skip to content
[release/8.0] [wasi] Work around WASI's mmap implementation not returning aligned m… - #92061
Merged
carlossanlop merged 1 commit into
release/8.0from 
backport/pr-91761-to-release/8.0
Sep 14, 2023
Merged
[release/8.0] [wasi] Work around WASI's mmap implementation not returning aligned m…#92061
carlossanlop merged 1 commit into
release/8.0from 
backport/pr-91761-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 14, 2023•

edited by SamMonoRT

Loading

Copy link


Copy Markdown

Contributor
Backport of #91761 to release/8.0
/cc @vargaz
Customer Impact
Enabling green CI when experimental feature is on - Only affects experimental WASI support. Mostly useful for fixing random CI failures like:
#86860
Testing
Tested by running a randomly failing test suite in a loop.
Risk
Low, only affects experimental WASI support.
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
@vargaz
[wasi] Work arounbd WASI's mmap implementation not returning aligned …
d3058e9
…memory.
Some code in sgen like sgen_los_free_object () expects the return address to be aligned.
Hopefully fixes#88501 and others.
@ghostghost
added
the 
area-VM-meta-mono

label
Sep 14, 2023
@SamMonoRTSamMonoRT
added this to the 8.0.0 milestone
Sep 14, 2023
@SamMonoRTSamMonoRT
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 14, 2023
@vargazvargaz
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 14, 2023
@vargaz
vargaz
commented
Sep 14, 2023

Copy link


Copy Markdown

Contributor
@carlossanlop
@carlossanlop
carlossanlop
merged commit 0189dc4
into
release/8.0Sep 14, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-91761-to-release/8.0

branch
September 14, 2023 17:49
@carlossanlop
carlossanlop
commented
Sep 21, 2023

Copy link


Copy Markdown

Contributor
Oh I see this got backported. Unfortunately, I'm still seeing this failure in the 8.0 branch:
Here's an example PR that hit it: #92374

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=413445&view=logs&j=f02b8cf9-dd4d-54fc-c292-2bb1d305b019&t=fd9015e5-cd94-57d7-8286-4fe749355863&l=56

Log: https://helixre107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-runtime-refs-heads-release-80-rc1-6a14376058b74ebebf/System.Collections.Tests/1/console.90d8fea5.log?helixlogtype=result

Output:
===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e /root/helix/work/workitem/e
[8.0.0-prerelease.23407.2+480b9159eb7e69b182a87581d5a336e97e0b6dae] XHarness command issued: wasi test --app=. --output-directory=/root/helix/work/workitem/uploads/xharness-output --engine-arg=--dir=. --timeout=00:30:00 -- dotnet.wasm WasmTestRunner managed/System.Collections.Tests.dll -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
info: Using wasm engine WasmTime from path /root/helix/work/correlation/wasmtime/wasmtime
info: wasmtime-cli 5.0.0
info: info: Running /root/helix/work/correlation/wasmtime/wasmtime --dir=. dotnet.wasm WasmTestRunner managed/System.Collections.Tests.dll -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
info: Discovering: managed/System.Collections.Tests.dll (method display = ClassAndMethod, method display options = None)
info: Discovered: managed/System.Collections.Tests.dll (found 5666 of 7580 test cases)
info: Using random seed for test cases: 1986925510
info: Using random seed for collections: 1986925510
info: Starting: managed/System.Collections.Tests.dll
info: Error: failed to run main module `dotnet.wasm`
info: info: Caused by:
info: 0: failed to invoke command default
info: 1: error while executing at wasm backtrace:
info: 0: 0x4ff1e - <unknown>!sgen_gray_object_queue_trim_free_list
info: 1: 0x4ffc3 - <unknown>!sgen_gray_object_queue_dispose
info: 2: 0x4b4fd - <unknown>!collect_nursery
info: 3: 0x4ada1 - <unknown>!sgen_perform_collection
info: 4: 0x4abd4 - <unknown>!sgen_ensure_free_space
info: 5: 0x49a0a - <unknown>!sgen_alloc_obj_nolock
info: 6: 0x4a0ea - <unknown>!sgen_alloc_obj
info: 7: 0x10e041 - <unknown>!mono_gc_alloc_obj
info: 8: 0xe617 - <unknown>!mono_interp_exec_method
info: 9: 0x8040 - <unknown>!interp_runtime_invoke
info: 10: 0x11d90f - <unknown>!mono_jit_runtime_invoke
info: 11: 0xe0f20 - <unknown>!do_runtime_invoke
info: 12: 0xe18ba - <unknown>!mono_runtime_try_invoke
info: 13: 0xe6101 - <unknown>!do_try_exec_main
info: 14: 0xe5ba0 - <unknown>!mono_runtime_run_main
info: 15: 0x68ac - <unknown>!main
info: 16: 0x272da8 - <unknown>!__main_void
info: 17: 0x5911 - <unknown>!_start
info: 18: 0x285f79 - <unknown>!_start.command_export
info: note: using the `WASMTIME_BACKTRACE_DETAILS=1` environment variable may show more debugging information
info: 2: wasm trap: out of bounds memory access
info: Process wasmtime exited with 134
info: Waiting to flush log messages with a timeout of 120 secs ..
fail: Application has finished with exit code 134 but 0 was expected
XHarness exit code: 71 (GENERAL_FAILURE)
/root/helix/work/workitem/e /root/helix/work/workitem/e
----- end Wed 20 Sep 2023 09:20:08 PM UTC ----- exit code 71 ----------------------------------------------------------

@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 22, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar approved these changes
@lambdageeklambdageeklambdageek approved these changes
@vargazvargazAwaiting requested review from vargaz

Assignees

@vargazvargaz

Labels

area-VM-meta-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@vargaz@carlossanlop@marek-safar@lambdageek@SamMonoRT

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[release/8.0] [wasi] Work around WASI's mmap implementation not returning aligned m… by github-actions[bot] · Pull Request #92061 · dotnet/runtime · GitHub
Skip to content
[release/8.0] [wasi] Work around WASI's mmap implementation not returning aligned m… - #92061
Merged
carlossanlop merged 1 commit into
release/8.0from 
backport/pr-91761-to-release/8.0
Sep 14, 2023
Merged
[release/8.0] [wasi] Work around WASI's mmap implementation not returning aligned m…#92061
carlossanlop merged 1 commit into
release/8.0from 
backport/pr-91761-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 14, 2023•

edited by SamMonoRT

Loading

Copy link


Copy Markdown

Contributor
Backport of #91761 to release/8.0
/cc @vargaz
Customer Impact
Enabling green CI when experimental feature is on - Only affects experimental WASI support. Mostly useful for fixing random CI failures like:
#86860
Testing
Tested by running a randomly failing test suite in a loop.
Risk
Low, only affects experimental WASI support.
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
@vargaz
[wasi] Work arounbd WASI's mmap implementation not returning aligned …
d3058e9
…memory.
Some code in sgen like sgen_los_free_object () expects the return address to be aligned.
Hopefully fixes#88501 and others.
@ghostghost
added
the 
area-VM-meta-mono

label
Sep 14, 2023
@SamMonoRTSamMonoRT
added this to the 8.0.0 milestone
Sep 14, 2023
@SamMonoRTSamMonoRT
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 14, 2023
@vargazvargaz
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 14, 2023
@vargaz
vargaz
commented
Sep 14, 2023

Copy link


Copy Markdown

Contributor
@carlossanlop
@carlossanlop
carlossanlop
merged commit 0189dc4
into
release/8.0Sep 14, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-91761-to-release/8.0

branch
September 14, 2023 17:49
@carlossanlop
carlossanlop
commented
Sep 21, 2023

Copy link


Copy Markdown

Contributor
Oh I see this got backported. Unfortunately, I'm still seeing this failure in the 8.0 branch:
Here's an example PR that hit it: #92374

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=413445&view=logs&j=f02b8cf9-dd4d-54fc-c292-2bb1d305b019&t=fd9015e5-cd94-57d7-8286-4fe749355863&l=56

Log: https://helixre107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-runtime-refs-heads-release-80-rc1-6a14376058b74ebebf/System.Collections.Tests/1/console.90d8fea5.log?helixlogtype=result

Output:
===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e /root/helix/work/workitem/e
[8.0.0-prerelease.23407.2+480b9159eb7e69b182a87581d5a336e97e0b6dae] XHarness command issued: wasi test --app=. --output-directory=/root/helix/work/workitem/uploads/xharness-output --engine-arg=--dir=. --timeout=00:30:00 -- dotnet.wasm WasmTestRunner managed/System.Collections.Tests.dll -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
info: Using wasm engine WasmTime from path /root/helix/work/correlation/wasmtime/wasmtime
info: wasmtime-cli 5.0.0
info: info: Running /root/helix/work/correlation/wasmtime/wasmtime --dir=. dotnet.wasm WasmTestRunner managed/System.Collections.Tests.dll -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
info: Discovering: managed/System.Collections.Tests.dll (method display = ClassAndMethod, method display options = None)
info: Discovered: managed/System.Collections.Tests.dll (found 5666 of 7580 test cases)
info: Using random seed for test cases: 1986925510
info: Using random seed for collections: 1986925510
info: Starting: managed/System.Collections.Tests.dll
info: Error: failed to run main module `dotnet.wasm`
info: info: Caused by:
info: 0: failed to invoke command default
info: 1: error while executing at wasm backtrace:
info: 0: 0x4ff1e - <unknown>!sgen_gray_object_queue_trim_free_list
info: 1: 0x4ffc3 - <unknown>!sgen_gray_object_queue_dispose
info: 2: 0x4b4fd - <unknown>!collect_nursery
info: 3: 0x4ada1 - <unknown>!sgen_perform_collection
info: 4: 0x4abd4 - <unknown>!sgen_ensure_free_space
info: 5: 0x49a0a - <unknown>!sgen_alloc_obj_nolock
info: 6: 0x4a0ea - <unknown>!sgen_alloc_obj
info: 7: 0x10e041 - <unknown>!mono_gc_alloc_obj
info: 8: 0xe617 - <unknown>!mono_interp_exec_method
info: 9: 0x8040 - <unknown>!interp_runtime_invoke
info: 10: 0x11d90f - <unknown>!mono_jit_runtime_invoke
info: 11: 0xe0f20 - <unknown>!do_runtime_invoke
info: 12: 0xe18ba - <unknown>!mono_runtime_try_invoke
info: 13: 0xe6101 - <unknown>!do_try_exec_main
info: 14: 0xe5ba0 - <unknown>!mono_runtime_run_main
info: 15: 0x68ac - <unknown>!main
info: 16: 0x272da8 - <unknown>!__main_void
info: 17: 0x5911 - <unknown>!_start
info: 18: 0x285f79 - <unknown>!_start.command_export
info: note: using the `WASMTIME_BACKTRACE_DETAILS=1` environment variable may show more debugging information
info: 2: wasm trap: out of bounds memory access
info: Process wasmtime exited with 134
info: Waiting to flush log messages with a timeout of 120 secs ..
fail: Application has finished with exit code 134 but 0 was expected
XHarness exit code: 71 (GENERAL_FAILURE)
/root/helix/work/workitem/e /root/helix/work/workitem/e
----- end Wed 20 Sep 2023 09:20:08 PM UTC ----- exit code 71 ----------------------------------------------------------

@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 22, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar approved these changes
@lambdageeklambdageeklambdageek approved these changes
@vargazvargazAwaiting requested review from vargaz

Assignees

@vargazvargaz

Labels

area-VM-meta-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@vargaz@carlossanlop@marek-safar@lambdageek@SamMonoRT