Skip to content

[release/8.0] Fix type parameter mapping logic in ILLink/ILCompiler - #92139

Merged
carlossanlop merged 4 commits into
release/8.0from
backport/pr-92088-to-release/8.0
Sep 16, 2023
Merged

[release/8.0] Fix type parameter mapping logic in ILLink/ILCompiler#92139
carlossanlop merged 4 commits into
release/8.0from
backport/pr-92088-to-release/8.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Sep 15, 2023•
edited by sbomer
Loading

Copy link
Copy Markdown
Contributor

Backport of #92088 to release/8.0

/cc @sbomer

Customer Impact

Fixes a blocking bug that was causing ILLink to crash. The crash can be observed when using code or dependencies with a certain kind of lambda expression usage. Originally reported in #91880, where it was observed in an empty blazor app with a reference to LanguageExt.Core.

Testing

Added test coverage for this pattern, and verified that the original repro is fixed.

Risk

Low risk. This only introduces another case to the existing discovery logic.

@ghostghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 15, 2023
@marek-safarmarek-safar added this to the 8.0.0 milestone Sep 15, 2023
@marek-safarmarek-safar added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Sep 15, 2023
@ghost

ghost commented Sep 15, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92088 to release/8.0

/cc @sbomer

Customer Impact

Fixes a blocking bug that was causing ILLink to crash. The crash can be observed when using code or dependencies with a certain kind of lambda expression usage. Originally reported in #91880, where it was observed in an empty blazor app with a reference to LanguageExt.Core.

Testing

Added test coverage for this pattern, and verified that the original repro is fixed.

Risk

Low risk. This only introduces another case to the existing discovery logic.

Author:github-actions[bot]
Assignees:-
Labels:

area-Tools-ILLink, needs-area-label

Milestone:8.0.0

jeffschwMSFT
jeffschwMSFT approved these changes Sep 15, 2023
View reviewed changes

@jeffschwMSFTjeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. when ready this can be merged

@carlossanlopcarlossanlop added Servicing-approved Approved for servicing release and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 16, 2023
@carlossanlop
carlossanlop merged commit 0175113 into release/8.0Sep 16, 2023
@carlossanlop
carlossanlop deleted the backport/pr-92088-to-release/8.0 branch September 16, 2023 21:05
@radicalradical mentioned this pull request Sep 26, 2023
Closed
@radicalradical mentioned this pull request Oct 3, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Oct 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeffschwMSFTjeffschwMSFTjeffschwMSFT approved these changes
@vitek-karasvitek-karasvitek-karas approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safarmarek-safar is a code owner
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
@agockeagockeAwaiting requested review from agocke

Assignees

No one assigned

Labels

area-Tools-ILLink.NET linker development as well as trimming analyzersServicing-approvedApproved for servicing release

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jeffschwMSFT@vitek-karas@marek-safar@carlossanlop@sbomer