[release/8.0] Update dependencies from dotnet/roslyn by dotnet-maestro[bot] · Pull Request #92149 · dotnet/runtime

dotnet-maestro · 2023-09-15T18:56:05Z

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

Subscription: ac2d12d7-7c98-40fe-ec67-08db9e4ff4ff
Build: 20230918.4
Date Produced: September 19, 2023 2:57:05 AM UTC
Commit: a19fe34b7266ab7638a12c2b54748d89d35a21a7
Branch: refs/heads/main

Updates:
- Microsoft.CodeAnalysis: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4
- Microsoft.CodeAnalysis.CSharp: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4
- Microsoft.Net.Compilers.Toolset: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4

…915.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.1

…915.2 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.2

…915.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.4

…915.5 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.5

carlossanlop · 2023-09-16T21:08:51Z

@ericstj this roslyn deps update is broken. Who can take a look at source generator and interceptors-related failures?

The failure is:

/__w/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(33,10): error CS9137: The 'interceptors' experimental feature is not enabled in this namespace. Add '<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>' to your project. [/__w/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Logging.Configuration.csproj::TargetFramework=net8.0]
##[error]/mnt/vss/_work/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(33,10): error CS9137: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'interceptors' experimental feature is not enabled in this namespace. Add '<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>' to your project.

layomia · 2023-09-18T16:05:21Z

@carlossanlop I'll push a fix.

ericstj · 2023-09-18T17:58:14Z

The fix here is to find all the projects with https://github.com/search?q=repo%3Adotnet%2Fruntime%20InterceptorsPreview&type=code

And make them instead use

<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>

Probably need the same in the PR that's pulling this Roslyn version into MAIN as well.

…feature

ericstj

Looks good to me. Thank you, @carlossanlop

…918.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.1

ericstj · 2023-09-18T22:45:00Z

It looks like the test helpers also need to specify the new property:

runtime/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Helpers.cs

Line 135 in 1f9764f

CSharpParseOptionsparseOptions=newCSharpParseOptions(langVersion).WithFeatures(new[]{newKeyValuePair<string,string>("InterceptorsPreview","")});

This is why the tests are failing here. It's because they are running the new compiler which doesn't seem to like having only the Feature set.

ericstj · 2023-09-18T22:49:54Z

@RikkiGibson can you tell us how our tests should set InterceptorsPreviewNamesapaces? I couldn't find a public API for this like there was for WithFeatures

I see, I think we can use Features API.

We need

CSharpParseOptionsparseOptions=newCSharpParseOptions(langVersion).WithFeatures(new[]{newKeyValuePair<string,string>("InterceptorsPreview",""),newKeyValuePair<string,string>("InterceptorsPreviewNamespaces","Microsoft.Extensions.Configuration.Binder.SourceGeneration"),});

…torTests.Helpers.cs

…918.3 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.3

ericstj

LGTM

ericstj · 2023-09-19T02:06:20Z

This looks like it's good to go, if Roslyn would just stop building to update this PR 😆

…918.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.4

…909-5ece5fcb9d04

carlossanlop · 2023-09-19T06:41:42Z

Still seeing one failure related to the interceptors, unfortunately. I'll take a look tomorrow.

The Tensors failure is unrelated, seems it was introduced here: #92245

@mmitche I haven't snapped rc2 due to this PR and a few other PRs that came in late, but will work on it tomorrow first thing in the morning.

carlossanlop · 2023-09-19T16:08:31Z

Ok the KnownBuildError just tagged this failure as known since May: #86532

So we can merge this finally, before the but adds more commits.

And the other failure is Tensors, unrelated to this, and will be fixed with #92270

dotnet-maestro · 2023-09-15T18:56:05Z

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

Subscription: ac2d12d7-7c98-40fe-ec67-08db9e4ff4ff
Build: 20230918.4
Date Produced: September 19, 2023 2:57:05 AM UTC
Commit: a19fe34b7266ab7638a12c2b54748d89d35a21a7
Branch: refs/heads/main

Updates:
- Microsoft.CodeAnalysis: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4
- Microsoft.CodeAnalysis.CSharp: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4
- Microsoft.Net.Compilers.Toolset: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4

…915.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.1

…915.2 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.2

…915.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.4

…915.5 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.5

carlossanlop · 2023-09-16T21:08:51Z

@ericstj this roslyn deps update is broken. Who can take a look at source generator and interceptors-related failures?

The failure is:

/__w/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(33,10): error CS9137: The 'interceptors' experimental feature is not enabled in this namespace. Add '<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>' to your project. [/__w/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Logging.Configuration.csproj::TargetFramework=net8.0]
##[error]/mnt/vss/_work/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(33,10): error CS9137: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'interceptors' experimental feature is not enabled in this namespace. Add '<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>' to your project.

layomia · 2023-09-18T16:05:21Z

@carlossanlop I'll push a fix.

ericstj · 2023-09-18T17:58:14Z

The fix here is to find all the projects with https://github.com/search?q=repo%3Adotnet%2Fruntime%20InterceptorsPreview&type=code

And make them instead use

<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>

Probably need the same in the PR that's pulling this Roslyn version into MAIN as well.

…feature

ericstj

Looks good to me. Thank you, @carlossanlop

…918.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.1

ericstj · 2023-09-18T22:45:00Z

It looks like the test helpers also need to specify the new property:

runtime/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Helpers.cs

Line 135 in 1f9764f

CSharpParseOptionsparseOptions=newCSharpParseOptions(langVersion).WithFeatures(new[]{newKeyValuePair<string,string>("InterceptorsPreview","")});

This is why the tests are failing here. It's because they are running the new compiler which doesn't seem to like having only the Feature set.

ericstj · 2023-09-18T22:49:54Z

@RikkiGibson can you tell us how our tests should set InterceptorsPreviewNamesapaces? I couldn't find a public API for this like there was for WithFeatures

I see, I think we can use Features API.

We need

CSharpParseOptionsparseOptions=newCSharpParseOptions(langVersion).WithFeatures(new[]{newKeyValuePair<string,string>("InterceptorsPreview",""),newKeyValuePair<string,string>("InterceptorsPreviewNamespaces","Microsoft.Extensions.Configuration.Binder.SourceGeneration"),});

…torTests.Helpers.cs

…918.3 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.3

ericstj

LGTM

ericstj · 2023-09-19T02:06:20Z

This looks like it's good to go, if Roslyn would just stop building to update this PR 😆

…918.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.4

…909-5ece5fcb9d04

carlossanlop · 2023-09-19T06:41:42Z

Still seeing one failure related to the interceptors, unfortunately. I'll take a look tomorrow.

The Tensors failure is unrelated, seems it was introduced here: #92245

@mmitche I haven't snapped rc2 due to this PR and a few other PRs that came in late, but will work on it tomorrow first thing in the morning.

carlossanlop · 2023-09-19T16:08:31Z

Ok the KnownBuildError just tagged this failure as known since May: #86532

So we can merge this finally, before the but adds more commits.

And the other failure is Tensors, unrelated to this, and will be fixed with #92270

dotnet-maestro · 2023-09-15T18:56:05Z

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

Subscription: ac2d12d7-7c98-40fe-ec67-08db9e4ff4ff
Build: 20230918.4
Date Produced: September 19, 2023 2:57:05 AM UTC
Commit: a19fe34b7266ab7638a12c2b54748d89d35a21a7
Branch: refs/heads/main

Updates:
- Microsoft.CodeAnalysis: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4
- Microsoft.CodeAnalysis.CSharp: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4
- Microsoft.Net.Compilers.Toolset: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4

…915.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.1

…915.2 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.2

…915.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.4

…915.5 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.5

carlossanlop · 2023-09-16T21:08:51Z

@ericstj this roslyn deps update is broken. Who can take a look at source generator and interceptors-related failures?

The failure is:

/__w/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(33,10): error CS9137: The 'interceptors' experimental feature is not enabled in this namespace. Add '<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>' to your project. [/__w/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Logging.Configuration.csproj::TargetFramework=net8.0]
##[error]/mnt/vss/_work/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(33,10): error CS9137: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'interceptors' experimental feature is not enabled in this namespace. Add '<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>' to your project.

layomia · 2023-09-18T16:05:21Z

@carlossanlop I'll push a fix.

ericstj · 2023-09-18T17:58:14Z

The fix here is to find all the projects with https://github.com/search?q=repo%3Adotnet%2Fruntime%20InterceptorsPreview&type=code

And make them instead use

<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>

Probably need the same in the PR that's pulling this Roslyn version into MAIN as well.

…feature

ericstj

Looks good to me. Thank you, @carlossanlop

…918.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.1

ericstj · 2023-09-18T22:45:00Z

It looks like the test helpers also need to specify the new property:

runtime/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Helpers.cs

Line 135 in 1f9764f

CSharpParseOptionsparseOptions=newCSharpParseOptions(langVersion).WithFeatures(new[]{newKeyValuePair<string,string>("InterceptorsPreview","")});

This is why the tests are failing here. It's because they are running the new compiler which doesn't seem to like having only the Feature set.

ericstj · 2023-09-18T22:49:54Z

@RikkiGibson can you tell us how our tests should set InterceptorsPreviewNamesapaces? I couldn't find a public API for this like there was for WithFeatures

I see, I think we can use Features API.

We need

CSharpParseOptionsparseOptions=newCSharpParseOptions(langVersion).WithFeatures(new[]{newKeyValuePair<string,string>("InterceptorsPreview",""),newKeyValuePair<string,string>("InterceptorsPreviewNamespaces","Microsoft.Extensions.Configuration.Binder.SourceGeneration"),});

…torTests.Helpers.cs

…918.3 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.3

ericstj

LGTM

ericstj · 2023-09-19T02:06:20Z

This looks like it's good to go, if Roslyn would just stop building to update this PR 😆

…918.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.4

…909-5ece5fcb9d04

carlossanlop · 2023-09-19T06:41:42Z

Still seeing one failure related to the interceptors, unfortunately. I'll take a look tomorrow.

The Tensors failure is unrelated, seems it was introduced here: #92245

@mmitche I haven't snapped rc2 due to this PR and a few other PRs that came in late, but will work on it tomorrow first thing in the morning.

carlossanlop · 2023-09-19T16:08:31Z

Ok the KnownBuildError just tagged this failure as known since May: #86532

So we can merge this finally, before the but adds more commits.

And the other failure is Tensors, unrelated to this, and will be fixed with #92270

dotnet-maestro · 2023-09-15T18:56:05Z

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

Subscription: ac2d12d7-7c98-40fe-ec67-08db9e4ff4ff
Build: 20230918.4
Date Produced: September 19, 2023 2:57:05 AM UTC
Commit: a19fe34b7266ab7638a12c2b54748d89d35a21a7
Branch: refs/heads/main

Updates:
- Microsoft.CodeAnalysis: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4
- Microsoft.CodeAnalysis.CSharp: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4
- Microsoft.Net.Compilers.Toolset: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4

…915.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.1

…915.2 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.2

…915.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.4

…915.5 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.5

carlossanlop · 2023-09-16T21:08:51Z

@ericstj this roslyn deps update is broken. Who can take a look at source generator and interceptors-related failures?

The failure is:

/__w/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(33,10): error CS9137: The 'interceptors' experimental feature is not enabled in this namespace. Add '<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>' to your project. [/__w/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Logging.Configuration.csproj::TargetFramework=net8.0]
##[error]/mnt/vss/_work/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(33,10): error CS9137: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'interceptors' experimental feature is not enabled in this namespace. Add '<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>' to your project.

layomia · 2023-09-18T16:05:21Z

@carlossanlop I'll push a fix.

ericstj · 2023-09-18T17:58:14Z

The fix here is to find all the projects with https://github.com/search?q=repo%3Adotnet%2Fruntime%20InterceptorsPreview&type=code

And make them instead use

<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>

Probably need the same in the PR that's pulling this Roslyn version into MAIN as well.

…feature

ericstj

Looks good to me. Thank you, @carlossanlop

…918.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.1

ericstj · 2023-09-18T22:45:00Z

It looks like the test helpers also need to specify the new property:

runtime/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Helpers.cs

Line 135 in 1f9764f

CSharpParseOptionsparseOptions=newCSharpParseOptions(langVersion).WithFeatures(new[]{newKeyValuePair<string,string>("InterceptorsPreview","")});

This is why the tests are failing here. It's because they are running the new compiler which doesn't seem to like having only the Feature set.

ericstj · 2023-09-18T22:49:54Z

@RikkiGibson can you tell us how our tests should set InterceptorsPreviewNamesapaces? I couldn't find a public API for this like there was for WithFeatures

I see, I think we can use Features API.

We need

CSharpParseOptionsparseOptions=newCSharpParseOptions(langVersion).WithFeatures(new[]{newKeyValuePair<string,string>("InterceptorsPreview",""),newKeyValuePair<string,string>("InterceptorsPreviewNamespaces","Microsoft.Extensions.Configuration.Binder.SourceGeneration"),});

…torTests.Helpers.cs

…918.3 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.3

ericstj

LGTM

ericstj · 2023-09-19T02:06:20Z

This looks like it's good to go, if Roslyn would just stop building to update this PR 😆

…918.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.4

…909-5ece5fcb9d04

carlossanlop · 2023-09-19T06:41:42Z

Still seeing one failure related to the interceptors, unfortunately. I'll take a look tomorrow.

The Tensors failure is unrelated, seems it was introduced here: #92245

@mmitche I haven't snapped rc2 due to this PR and a few other PRs that came in late, but will work on it tomorrow first thing in the morning.

carlossanlop · 2023-09-19T16:08:31Z

Ok the KnownBuildError just tagged this failure as known since May: #86532

So we can merge this finally, before the but adds more commits.

And the other failure is Tensors, unrelated to this, and will be fixed with #92270

dotnet-maestro · 2023-09-15T18:56:05Z

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

Subscription: ac2d12d7-7c98-40fe-ec67-08db9e4ff4ff
Build: 20230918.4
Date Produced: September 19, 2023 2:57:05 AM UTC
Commit: a19fe34b7266ab7638a12c2b54748d89d35a21a7
Branch: refs/heads/main

Updates:
- Microsoft.CodeAnalysis: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4
- Microsoft.CodeAnalysis.CSharp: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4
- Microsoft.Net.Compilers.Toolset: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4

…915.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.1

…915.2 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.2

…915.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.4

…915.5 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.5

carlossanlop · 2023-09-16T21:08:51Z

@ericstj this roslyn deps update is broken. Who can take a look at source generator and interceptors-related failures?

The failure is:

/__w/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(33,10): error CS9137: The 'interceptors' experimental feature is not enabled in this namespace. Add '<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>' to your project. [/__w/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Logging.Configuration.csproj::TargetFramework=net8.0]
##[error]/mnt/vss/_work/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(33,10): error CS9137: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'interceptors' experimental feature is not enabled in this namespace. Add '<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>' to your project.

layomia · 2023-09-18T16:05:21Z

@carlossanlop I'll push a fix.

ericstj · 2023-09-18T17:58:14Z

The fix here is to find all the projects with https://github.com/search?q=repo%3Adotnet%2Fruntime%20InterceptorsPreview&type=code

And make them instead use

<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>

Probably need the same in the PR that's pulling this Roslyn version into MAIN as well.

…feature

ericstj

Looks good to me. Thank you, @carlossanlop

…918.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.1

ericstj · 2023-09-18T22:45:00Z

It looks like the test helpers also need to specify the new property:

runtime/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Helpers.cs

Line 135 in 1f9764f

CSharpParseOptionsparseOptions=newCSharpParseOptions(langVersion).WithFeatures(new[]{newKeyValuePair<string,string>("InterceptorsPreview","")});

This is why the tests are failing here. It's because they are running the new compiler which doesn't seem to like having only the Feature set.

ericstj · 2023-09-18T22:49:54Z

@RikkiGibson can you tell us how our tests should set InterceptorsPreviewNamesapaces? I couldn't find a public API for this like there was for WithFeatures

I see, I think we can use Features API.

We need

CSharpParseOptionsparseOptions=newCSharpParseOptions(langVersion).WithFeatures(new[]{newKeyValuePair<string,string>("InterceptorsPreview",""),newKeyValuePair<string,string>("InterceptorsPreviewNamespaces","Microsoft.Extensions.Configuration.Binder.SourceGeneration"),});

…torTests.Helpers.cs

…918.3 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.3

ericstj

LGTM

ericstj · 2023-09-19T02:06:20Z

This looks like it's good to go, if Roslyn would just stop building to update this PR 😆

…918.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.4

…909-5ece5fcb9d04

carlossanlop · 2023-09-19T06:41:42Z

Still seeing one failure related to the interceptors, unfortunately. I'll take a look tomorrow.

The Tensors failure is unrelated, seems it was introduced here: #92245

@mmitche I haven't snapped rc2 due to this PR and a few other PRs that came in late, but will work on it tomorrow first thing in the morning.

carlossanlop · 2023-09-19T16:08:31Z

Ok the KnownBuildError just tagged this failure as known since May: #86532

So we can merge this finally, before the but adds more commits.

And the other failure is Tensors, unrelated to this, and will be fixed with #92270

dotnet-maestro · 2023-09-15T18:56:05Z

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

Subscription: ac2d12d7-7c98-40fe-ec67-08db9e4ff4ff
Build: 20230918.4
Date Produced: September 19, 2023 2:57:05 AM UTC
Commit: a19fe34b7266ab7638a12c2b54748d89d35a21a7
Branch: refs/heads/main

Updates:
- Microsoft.CodeAnalysis: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4
- Microsoft.CodeAnalysis.CSharp: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4
- Microsoft.Net.Compilers.Toolset: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4

…915.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.1

…915.2 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.2

…915.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.4

…915.5 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.5

carlossanlop · 2023-09-16T21:08:51Z

@ericstj this roslyn deps update is broken. Who can take a look at source generator and interceptors-related failures?

The failure is:

/__w/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(33,10): error CS9137: The 'interceptors' experimental feature is not enabled in this namespace. Add '<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>' to your project. [/__w/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Logging.Configuration.csproj::TargetFramework=net8.0]
##[error]/mnt/vss/_work/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(33,10): error CS9137: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'interceptors' experimental feature is not enabled in this namespace. Add '<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>' to your project.

layomia · 2023-09-18T16:05:21Z

@carlossanlop I'll push a fix.

ericstj · 2023-09-18T17:58:14Z

The fix here is to find all the projects with https://github.com/search?q=repo%3Adotnet%2Fruntime%20InterceptorsPreview&type=code

And make them instead use

<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>

Probably need the same in the PR that's pulling this Roslyn version into MAIN as well.

…feature

ericstj

Looks good to me. Thank you, @carlossanlop

…918.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.1

ericstj · 2023-09-18T22:45:00Z

It looks like the test helpers also need to specify the new property:

runtime/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Helpers.cs

Line 135 in 1f9764f

CSharpParseOptionsparseOptions=newCSharpParseOptions(langVersion).WithFeatures(new[]{newKeyValuePair<string,string>("InterceptorsPreview","")});

This is why the tests are failing here. It's because they are running the new compiler which doesn't seem to like having only the Feature set.

ericstj · 2023-09-18T22:49:54Z

@RikkiGibson can you tell us how our tests should set InterceptorsPreviewNamesapaces? I couldn't find a public API for this like there was for WithFeatures

I see, I think we can use Features API.

We need

CSharpParseOptionsparseOptions=newCSharpParseOptions(langVersion).WithFeatures(new[]{newKeyValuePair<string,string>("InterceptorsPreview",""),newKeyValuePair<string,string>("InterceptorsPreviewNamespaces","Microsoft.Extensions.Configuration.Binder.SourceGeneration"),});

…torTests.Helpers.cs

…918.3 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.3

ericstj

LGTM

ericstj · 2023-09-19T02:06:20Z

This looks like it's good to go, if Roslyn would just stop building to update this PR 😆

…918.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.4

…909-5ece5fcb9d04

carlossanlop · 2023-09-19T06:41:42Z

Still seeing one failure related to the interceptors, unfortunately. I'll take a look tomorrow.

The Tensors failure is unrelated, seems it was introduced here: #92245

@mmitche I haven't snapped rc2 due to this PR and a few other PRs that came in late, but will work on it tomorrow first thing in the morning.

carlossanlop · 2023-09-19T16:08:31Z

Ok the KnownBuildError just tagged this failure as known since May: #86532

So we can merge this finally, before the but adds more commits.

And the other failure is Tensors, unrelated to this, and will be fixed with #92270

dotnet-maestro · 2023-09-15T18:56:05Z

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

Subscription: ac2d12d7-7c98-40fe-ec67-08db9e4ff4ff
Build: 20230918.4
Date Produced: September 19, 2023 2:57:05 AM UTC
Commit: a19fe34b7266ab7638a12c2b54748d89d35a21a7
Branch: refs/heads/main

Updates:
- Microsoft.CodeAnalysis: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4
- Microsoft.CodeAnalysis.CSharp: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4
- Microsoft.Net.Compilers.Toolset: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4

…915.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.1

…915.2 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.2

…915.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.4

…915.5 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.5

carlossanlop · 2023-09-16T21:08:51Z

@ericstj this roslyn deps update is broken. Who can take a look at source generator and interceptors-related failures?

The failure is:

/__w/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(33,10): error CS9137: The 'interceptors' experimental feature is not enabled in this namespace. Add '<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>' to your project. [/__w/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Logging.Configuration.csproj::TargetFramework=net8.0]
##[error]/mnt/vss/_work/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(33,10): error CS9137: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'interceptors' experimental feature is not enabled in this namespace. Add '<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>' to your project.

layomia · 2023-09-18T16:05:21Z

@carlossanlop I'll push a fix.

ericstj · 2023-09-18T17:58:14Z

The fix here is to find all the projects with https://github.com/search?q=repo%3Adotnet%2Fruntime%20InterceptorsPreview&type=code

And make them instead use

<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>

Probably need the same in the PR that's pulling this Roslyn version into MAIN as well.

…feature

ericstj

Looks good to me. Thank you, @carlossanlop

…918.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.1

ericstj · 2023-09-18T22:45:00Z

It looks like the test helpers also need to specify the new property:

runtime/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Helpers.cs

Line 135 in 1f9764f

CSharpParseOptionsparseOptions=newCSharpParseOptions(langVersion).WithFeatures(new[]{newKeyValuePair<string,string>("InterceptorsPreview","")});

This is why the tests are failing here. It's because they are running the new compiler which doesn't seem to like having only the Feature set.

ericstj · 2023-09-18T22:49:54Z

@RikkiGibson can you tell us how our tests should set InterceptorsPreviewNamesapaces? I couldn't find a public API for this like there was for WithFeatures

I see, I think we can use Features API.

We need

CSharpParseOptionsparseOptions=newCSharpParseOptions(langVersion).WithFeatures(new[]{newKeyValuePair<string,string>("InterceptorsPreview",""),newKeyValuePair<string,string>("InterceptorsPreviewNamespaces","Microsoft.Extensions.Configuration.Binder.SourceGeneration"),});

…torTests.Helpers.cs

…918.3 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.3

ericstj

LGTM

ericstj · 2023-09-19T02:06:20Z

This looks like it's good to go, if Roslyn would just stop building to update this PR 😆

…918.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.4

…909-5ece5fcb9d04

carlossanlop · 2023-09-19T06:41:42Z

Still seeing one failure related to the interceptors, unfortunately. I'll take a look tomorrow.

The Tensors failure is unrelated, seems it was introduced here: #92245

@mmitche I haven't snapped rc2 due to this PR and a few other PRs that came in late, but will work on it tomorrow first thing in the morning.

carlossanlop · 2023-09-19T16:08:31Z

Ok the KnownBuildError just tagged this failure as known since May: #86532

So we can merge this finally, before the but adds more commits.

And the other failure is Tensors, unrelated to this, and will be fixed with #92270

Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
64c60e1
…915.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.1

ghost added the area-codeflow for labeling automated codeflow label Sep 15, 2023

dotnet-maestroBot added 2 commits September 15, 2023 20:45

Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
08ef104
…915.2 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.2

Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
d9d50c6
…915.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.4

build-analysisBot mentioned this pull request Sep 16, 2023
Tracking issue for CI build timeouts #76454
Closed

Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
b8cb5dc
…915.5 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.5

build-analysisBot mentioned this pull request Sep 16, 2023
Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488
Closed

carlossanlop added the blocked Issue/PR is blocked on something - see comments label Sep 16, 2023

carlossanlop mentioned this pull request Sep 18, 2023
[main] Update dependencies from dotnet/roslyn #92150
Merged

Use InterceptorsPreviewNamespaces instead of the InterceptorsPreview …
de991dd
…feature

carlossanlop self-assigned this Sep 18, 2023

ericstj approved these changes Sep 18, 2023
View reviewed changes

carlossanlop added Servicing-approved Approved for servicing release and removed blocked Issue/PR is blocked on something - see comments labels Sep 18, 2023

Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
c418166
…918.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.1

carlossanlop reviewed Sep 18, 2023
View reviewed changes

Bring back removed lines
05832b1

carlossanlopand others added 3 commits September 18, 2023 16:25

Add CSharpParseOption InterceptorsPreviewNamespaces feature to Genera…
827d829
…torTests.Helpers.cs

Add TODO comment to remove feature
33971d6

Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
d359868
…918.3 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.3

ericstj approved these changes Sep 19, 2023
View reviewed changes

dotnet-maestroBotand others added 2 commits September 19, 2023 03:56

Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
891bc05
…918.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.4

Merge branch 'release/8.0' into darc-release/8.0-721ff3c5-df31-4a0e-8…
258665c
…909-5ece5fcb9d04

This was referenced Sep 19, 2023
Microsoft.Extensions.Configuration.Binder.Tests.ConfigurationBinderTests.BindCanReadStaticProperty failing intermittently #86532
Closed
System.Net.Sockets.Tests failing in CI runs #90521
Closed

carlossanlop mentioned this pull request Sep 19, 2023
Handle obsolete InterceptorsPreview with .NET 8 RC2 SDK #92247
Closed

carlossanlop merged commit 1881071 into release/8.0Sep 19, 2023

carlossanlop deleted the darc-release/8.0-721ff3c5-df31-4a0e-8909-5ece5fcb9d04 branch September 19, 2023 16:09

radical mentioned this pull request Sep 26, 2023
wasm symbols 8 #92626
Closed

radical mentioned this pull request Oct 3, 2023
runtime wasm perf triggers 8 #92976
Closed

ghost locked as resolved and limited conversation to collaborators Oct 19, 2023