Skip to content

[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs - #92199

Merged
carlossanlop merged 8 commits into
release/8.0from
backport/pr-92180-to-release/8.0
Sep 18, 2023
Merged

[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs#92199
carlossanlop merged 8 commits into
release/8.0from
backport/pr-92180-to-release/8.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Sep 17, 2023•
edited by eiriktsarpalis
Loading

Copy link
Copy Markdown
Contributor

Backport of #92180 to release/8.0

/cc @eiriktsarpalis@WeihanLi

Customer Impact

We received a customer reported issue that one of the newly added IAsyncEnumerable methods in the System.Net.Http.Json library is not using the correct default settings when deserializing values.

For instance, even though all other methods in the library use camelCase conversion, the impacted new methods do not.

Testing

Added unit testing covering the impacted scenario.

Risk

Low. Makes a minor change in product code making it consistent with other components in the same library (including other IAsyncEnumerable methods added in the same change).

@ghostghost added the area-System.Net label Sep 17, 2023
@ghost

ghost commented Sep 17, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92180 to release/8.0

/cc @eiriktsarpalis@WeihanLi

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

area-System.Net

Milestone:-

@eiriktsarpaliseiriktsarpalis self-assigned this Sep 17, 2023
@eiriktsarpaliseiriktsarpalis added this to the 8.0.0 milestone Sep 17, 2023
@eiriktsarpalis
eiriktsarpalis requested review from a team, MihaZupan and artl93September 17, 2023 23:10
@eiriktsarpaliseiriktsarpalis added the Servicing-consider Issue for next servicing release review label Sep 17, 2023
@WeihanLi

WeihanLi commented Sep 18, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Hi @eiriktsarpalis , just to mention, this also fixes the bug when trying to use a custom serializer option

sample code to reproduce

usingvarhttpClient=newHttpClient();httpClient.BaseAddress=newUri("http://localhost:5297");varstream=httpClient.GetFromJsonAsAsyncEnumerable<Job>("api/Jobs",newJsonSerializerOptions(JsonSerializerDefaults.Web));

Exception likes below:

System.InvalidOperationException: JsonSerializerOptions instance must specify a TypeInfoResolver setting before being marked as read-only.
at System.Text.Json.ThrowHelper.ThrowInvalidOperationException_JsonSerializerOptionsNoTypeInfoResolverSpecified()
at System.Text.Json.JsonSerializerOptions.MakeReadOnly()
at System.Net.Http.Json.HttpClientJsonExtensions.FromJsonStreamAsyncCore[TValue](HttpClient client, Uri requestUri, JsonSerializerOptions options, CancellationToken cancellationToken)

@build-analysisbuild-analysisBot mentioned this pull request Sep 18, 2023
Closed
@ghost

ghost commented Sep 18, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92180 to release/8.0

/cc @eiriktsarpalis@WeihanLi

Customer Impact

We received a customer reported issue that one of the newly added IAsyncEnumerable methods in the System.Net.Http.Json library is not using the correct default settings when deserializing values.

For instance, even though all other methods in the library use camelCase conversion, the impacted new methods do not.

Testing

Added unit testing covering the impacted scenario.

Risk

Low. Makes a minor change in product code making it consistent with other components in the same library (including other IAsyncEnumerable methods added in the same change).

Author:github-actions[bot]
Assignees:eiriktsarpalis
Labels:

Servicing-consider, area-System.Text.Json

Milestone:8.0.0

jeffhandley
jeffhandley approved these changes Sep 18, 2023
View reviewed changes

@jeffhandleyjeffhandley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has my support for RC2, @artl93. It's a broken/imcomplete 8.0 scenario reported by a customer.

artl93
artl93 approved these changes Sep 18, 2023
View reviewed changes

@artl93artl93 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M2 approved.

@artl93artl93 added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 18, 2023
@carlossanlop
carlossanlop merged commit e00e6aa into release/8.0Sep 18, 2023
@carlossanlop
carlossanlop deleted the backport/pr-92180-to-release/8.0 branch September 18, 2023 23:54
@build-analysisbuild-analysisBot mentioned this pull request Sep 19, 2023
Closed
@radicalradical mentioned this pull request Sep 26, 2023
Closed
@radicalradical mentioned this pull request Oct 3, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Oct 19, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeffhandleyjeffhandleyjeffhandley approved these changes
@artl93artl93artl93 approved these changes
@MihaZupanMihaZupanMihaZupan approved these changes
@ericstjericstjAwaiting requested review from ericstj

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-System.Text.JsonServicing-approvedApproved for servicing release

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@WeihanLi@jeffhandley@artl93@MihaZupan@carlossanlop@eiriktsarpalis@ericstj
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs by github-actions[bot] · Pull Request #92199 · dotnet/runtime · GitHub
Skip to content
[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs - #92199
Merged
carlossanlop merged 8 commits into
release/8.0from 
backport/pr-92180-to-release/8.0
Sep 18, 2023
Merged
[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs#92199
carlossanlop merged 8 commits into
release/8.0from 
backport/pr-92180-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 17, 2023•

edited by eiriktsarpalis

Loading

Copy link


Copy Markdown

Contributor
Backport of #92180 to release/8.0
/cc @eiriktsarpalis@WeihanLi
Customer Impact
We received a customer reported issue that one of the newly added IAsyncEnumerable methods in the System.Net.Http.Json library is not using the correct default settings when deserializing values.
For instance, even though all other methods in the library use camelCase conversion, the impacted new methods do not.
Testing
Added unit testing covering the impacted scenario.
Risk
Low. Makes a minor change in product code making it consistent with other components in the same library (including other IAsyncEnumerable methods added in the same change).
@ghostghost
added
the 
area-System.Net

label
Sep 17, 2023
@ghost
ghost
commented
Sep 17, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92180 to release/8.0
/cc @eiriktsarpalis@WeihanLi
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-System.Net
Milestone:-
@eiriktsarpaliseiriktsarpalis
self-assigned this
Sep 17, 2023
@eiriktsarpaliseiriktsarpalis
added this to the 8.0.0 milestone
Sep 17, 2023
@eiriktsarpalis
eiriktsarpalis
requested review from
a team, MihaZupan and artl93September 17, 2023 23:10
@eiriktsarpaliseiriktsarpalis
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 17, 2023
@WeihanLi
WeihanLi
commented
Sep 18, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Hi @eiriktsarpalis , just to mention, this also fixes the bug when trying to use a custom serializer option
sample code to reproduce
usingvarhttpClient=newHttpClient();httpClient.BaseAddress=newUri("http://localhost:5297");varstream=httpClient.GetFromJsonAsAsyncEnumerable<Job>("api/Jobs",newJsonSerializerOptions(JsonSerializerDefaults.Web));
Exception likes below:
System.InvalidOperationException: JsonSerializerOptions instance must specify a TypeInfoResolver setting before being marked as read-only.
at System.Text.Json.ThrowHelper.ThrowInvalidOperationException_JsonSerializerOptionsNoTypeInfoResolverSpecified()
at System.Text.Json.JsonSerializerOptions.MakeReadOnly()
at System.Net.Http.Json.HttpClientJsonExtensions.FromJsonStreamAsyncCore[TValue](HttpClient client, Uri requestUri, JsonSerializerOptions options, CancellationToken cancellationToken)

@build-analysisbuild-analysisBot
mentioned this pull request
Sep 18, 2023

Closed

@ghost
ghost
commented
Sep 18, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92180 to release/8.0
/cc @eiriktsarpalis@WeihanLi
Customer Impact
We received a customer reported issue that one of the newly added IAsyncEnumerable methods in the System.Net.Http.Json library is not using the correct default settings when deserializing values.
For instance, even though all other methods in the library use camelCase conversion, the impacted new methods do not.
Testing
Added unit testing covering the impacted scenario.
Risk
Low. Makes a minor change in product code making it consistent with other components in the same library (including other IAsyncEnumerable methods added in the same change).
Author:github-actions[bot]
Assignees:eiriktsarpalis
Labels:
Servicing-consider, area-System.Text.Json
Milestone:8.0.0
jeffhandley
jeffhandley
approved these changes
Sep 18, 2023
View reviewed changes
@jeffhandleyjeffhandley
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has my support for RC2, @artl93. It's a broken/imcomplete 8.0 scenario reported by a customer.
artl93
artl93
approved these changes
Sep 18, 2023
View reviewed changes
@artl93artl93
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M2 approved.
@artl93artl93
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 18, 2023
@carlossanlop
carlossanlop
merged commit e00e6aa
into
release/8.0Sep 18, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-92180-to-release/8.0

branch
September 18, 2023 23:54
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 19, 2023

Closed

@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 19, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jeffhandleyjeffhandleyjeffhandley approved these changes
@artl93artl93artl93 approved these changes
@MihaZupanMihaZupanMihaZupan approved these changes
@ericstjericstjAwaiting requested review from ericstj

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-System.Text.JsonServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@WeihanLi@jeffhandley@artl93@MihaZupan@carlossanlop@eiriktsarpalis@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs by github-actions[bot] · Pull Request #92199 · dotnet/runtime · GitHub
Skip to content
[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs - #92199
Merged
carlossanlop merged 8 commits into
release/8.0from 
backport/pr-92180-to-release/8.0
Sep 18, 2023
Merged
[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs#92199
carlossanlop merged 8 commits into
release/8.0from 
backport/pr-92180-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 17, 2023•

edited by eiriktsarpalis

Loading

Copy link


Copy Markdown

Contributor
Backport of #92180 to release/8.0
/cc @eiriktsarpalis@WeihanLi
Customer Impact
We received a customer reported issue that one of the newly added IAsyncEnumerable methods in the System.Net.Http.Json library is not using the correct default settings when deserializing values.
For instance, even though all other methods in the library use camelCase conversion, the impacted new methods do not.
Testing
Added unit testing covering the impacted scenario.
Risk
Low. Makes a minor change in product code making it consistent with other components in the same library (including other IAsyncEnumerable methods added in the same change).
@ghostghost
added
the 
area-System.Net

label
Sep 17, 2023
@ghost
ghost
commented
Sep 17, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92180 to release/8.0
/cc @eiriktsarpalis@WeihanLi
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-System.Net
Milestone:-
@eiriktsarpaliseiriktsarpalis
self-assigned this
Sep 17, 2023
@eiriktsarpaliseiriktsarpalis
added this to the 8.0.0 milestone
Sep 17, 2023
@eiriktsarpalis
eiriktsarpalis
requested review from
a team, MihaZupan and artl93September 17, 2023 23:10
@eiriktsarpaliseiriktsarpalis
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 17, 2023
@WeihanLi
WeihanLi
commented
Sep 18, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Hi @eiriktsarpalis , just to mention, this also fixes the bug when trying to use a custom serializer option
sample code to reproduce
usingvarhttpClient=newHttpClient();httpClient.BaseAddress=newUri("http://localhost:5297");varstream=httpClient.GetFromJsonAsAsyncEnumerable<Job>("api/Jobs",newJsonSerializerOptions(JsonSerializerDefaults.Web));
Exception likes below:
System.InvalidOperationException: JsonSerializerOptions instance must specify a TypeInfoResolver setting before being marked as read-only.
at System.Text.Json.ThrowHelper.ThrowInvalidOperationException_JsonSerializerOptionsNoTypeInfoResolverSpecified()
at System.Text.Json.JsonSerializerOptions.MakeReadOnly()
at System.Net.Http.Json.HttpClientJsonExtensions.FromJsonStreamAsyncCore[TValue](HttpClient client, Uri requestUri, JsonSerializerOptions options, CancellationToken cancellationToken)

@build-analysisbuild-analysisBot
mentioned this pull request
Sep 18, 2023

Closed

@ghost
ghost
commented
Sep 18, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92180 to release/8.0
/cc @eiriktsarpalis@WeihanLi
Customer Impact
We received a customer reported issue that one of the newly added IAsyncEnumerable methods in the System.Net.Http.Json library is not using the correct default settings when deserializing values.
For instance, even though all other methods in the library use camelCase conversion, the impacted new methods do not.
Testing
Added unit testing covering the impacted scenario.
Risk
Low. Makes a minor change in product code making it consistent with other components in the same library (including other IAsyncEnumerable methods added in the same change).
Author:github-actions[bot]
Assignees:eiriktsarpalis
Labels:
Servicing-consider, area-System.Text.Json
Milestone:8.0.0
jeffhandley
jeffhandley
approved these changes
Sep 18, 2023
View reviewed changes
@jeffhandleyjeffhandley
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has my support for RC2, @artl93. It's a broken/imcomplete 8.0 scenario reported by a customer.
artl93
artl93
approved these changes
Sep 18, 2023
View reviewed changes
@artl93artl93
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M2 approved.
@artl93artl93
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 18, 2023
@carlossanlop
carlossanlop
merged commit e00e6aa
into
release/8.0Sep 18, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-92180-to-release/8.0

branch
September 18, 2023 23:54
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 19, 2023

Closed

@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 19, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jeffhandleyjeffhandleyjeffhandley approved these changes
@artl93artl93artl93 approved these changes
@MihaZupanMihaZupanMihaZupan approved these changes
@ericstjericstjAwaiting requested review from ericstj

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-System.Text.JsonServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@WeihanLi@jeffhandley@artl93@MihaZupan@carlossanlop@eiriktsarpalis@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs by github-actions[bot] · Pull Request #92199 · dotnet/runtime · GitHub
Skip to content
[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs - #92199
Merged
carlossanlop merged 8 commits into
release/8.0from 
backport/pr-92180-to-release/8.0
Sep 18, 2023
Merged
[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs#92199
carlossanlop merged 8 commits into
release/8.0from 
backport/pr-92180-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 17, 2023•

edited by eiriktsarpalis

Loading

Copy link


Copy Markdown

Contributor
Backport of #92180 to release/8.0
/cc @eiriktsarpalis@WeihanLi
Customer Impact
We received a customer reported issue that one of the newly added IAsyncEnumerable methods in the System.Net.Http.Json library is not using the correct default settings when deserializing values.
For instance, even though all other methods in the library use camelCase conversion, the impacted new methods do not.
Testing
Added unit testing covering the impacted scenario.
Risk
Low. Makes a minor change in product code making it consistent with other components in the same library (including other IAsyncEnumerable methods added in the same change).
@ghostghost
added
the 
area-System.Net

label
Sep 17, 2023
@ghost
ghost
commented
Sep 17, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92180 to release/8.0
/cc @eiriktsarpalis@WeihanLi
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-System.Net
Milestone:-
@eiriktsarpaliseiriktsarpalis
self-assigned this
Sep 17, 2023
@eiriktsarpaliseiriktsarpalis
added this to the 8.0.0 milestone
Sep 17, 2023
@eiriktsarpalis
eiriktsarpalis
requested review from
a team, MihaZupan and artl93September 17, 2023 23:10
@eiriktsarpaliseiriktsarpalis
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 17, 2023
@WeihanLi
WeihanLi
commented
Sep 18, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Hi @eiriktsarpalis , just to mention, this also fixes the bug when trying to use a custom serializer option
sample code to reproduce
usingvarhttpClient=newHttpClient();httpClient.BaseAddress=newUri("http://localhost:5297");varstream=httpClient.GetFromJsonAsAsyncEnumerable<Job>("api/Jobs",newJsonSerializerOptions(JsonSerializerDefaults.Web));
Exception likes below:
System.InvalidOperationException: JsonSerializerOptions instance must specify a TypeInfoResolver setting before being marked as read-only.
at System.Text.Json.ThrowHelper.ThrowInvalidOperationException_JsonSerializerOptionsNoTypeInfoResolverSpecified()
at System.Text.Json.JsonSerializerOptions.MakeReadOnly()
at System.Net.Http.Json.HttpClientJsonExtensions.FromJsonStreamAsyncCore[TValue](HttpClient client, Uri requestUri, JsonSerializerOptions options, CancellationToken cancellationToken)

@build-analysisbuild-analysisBot
mentioned this pull request
Sep 18, 2023

Closed

@ghost
ghost
commented
Sep 18, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92180 to release/8.0
/cc @eiriktsarpalis@WeihanLi
Customer Impact
We received a customer reported issue that one of the newly added IAsyncEnumerable methods in the System.Net.Http.Json library is not using the correct default settings when deserializing values.
For instance, even though all other methods in the library use camelCase conversion, the impacted new methods do not.
Testing
Added unit testing covering the impacted scenario.
Risk
Low. Makes a minor change in product code making it consistent with other components in the same library (including other IAsyncEnumerable methods added in the same change).
Author:github-actions[bot]
Assignees:eiriktsarpalis
Labels:
Servicing-consider, area-System.Text.Json
Milestone:8.0.0
jeffhandley
jeffhandley
approved these changes
Sep 18, 2023
View reviewed changes
@jeffhandleyjeffhandley
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has my support for RC2, @artl93. It's a broken/imcomplete 8.0 scenario reported by a customer.
artl93
artl93
approved these changes
Sep 18, 2023
View reviewed changes
@artl93artl93
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M2 approved.
@artl93artl93
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 18, 2023
@carlossanlop
carlossanlop
merged commit e00e6aa
into
release/8.0Sep 18, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-92180-to-release/8.0

branch
September 18, 2023 23:54
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 19, 2023

Closed

@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 19, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jeffhandleyjeffhandleyjeffhandley approved these changes
@artl93artl93artl93 approved these changes
@MihaZupanMihaZupanMihaZupan approved these changes
@ericstjericstjAwaiting requested review from ericstj

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-System.Text.JsonServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@WeihanLi@jeffhandley@artl93@MihaZupan@carlossanlop@eiriktsarpalis@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs by github-actions[bot] · Pull Request #92199 · dotnet/runtime · GitHub
Skip to content
[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs - #92199
Merged
carlossanlop merged 8 commits into
release/8.0from 
backport/pr-92180-to-release/8.0
Sep 18, 2023
Merged
[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs#92199
carlossanlop merged 8 commits into
release/8.0from 
backport/pr-92180-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 17, 2023•

edited by eiriktsarpalis

Loading

Copy link


Copy Markdown

Contributor
Backport of #92180 to release/8.0
/cc @eiriktsarpalis@WeihanLi
Customer Impact
We received a customer reported issue that one of the newly added IAsyncEnumerable methods in the System.Net.Http.Json library is not using the correct default settings when deserializing values.
For instance, even though all other methods in the library use camelCase conversion, the impacted new methods do not.
Testing
Added unit testing covering the impacted scenario.
Risk
Low. Makes a minor change in product code making it consistent with other components in the same library (including other IAsyncEnumerable methods added in the same change).
@ghostghost
added
the 
area-System.Net

label
Sep 17, 2023
@ghost
ghost
commented
Sep 17, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92180 to release/8.0
/cc @eiriktsarpalis@WeihanLi
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-System.Net
Milestone:-
@eiriktsarpaliseiriktsarpalis
self-assigned this
Sep 17, 2023
@eiriktsarpaliseiriktsarpalis
added this to the 8.0.0 milestone
Sep 17, 2023
@eiriktsarpalis
eiriktsarpalis
requested review from
a team, MihaZupan and artl93September 17, 2023 23:10
@eiriktsarpaliseiriktsarpalis
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 17, 2023
@WeihanLi
WeihanLi
commented
Sep 18, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Hi @eiriktsarpalis , just to mention, this also fixes the bug when trying to use a custom serializer option
sample code to reproduce
usingvarhttpClient=newHttpClient();httpClient.BaseAddress=newUri("http://localhost:5297");varstream=httpClient.GetFromJsonAsAsyncEnumerable<Job>("api/Jobs",newJsonSerializerOptions(JsonSerializerDefaults.Web));
Exception likes below:
System.InvalidOperationException: JsonSerializerOptions instance must specify a TypeInfoResolver setting before being marked as read-only.
at System.Text.Json.ThrowHelper.ThrowInvalidOperationException_JsonSerializerOptionsNoTypeInfoResolverSpecified()
at System.Text.Json.JsonSerializerOptions.MakeReadOnly()
at System.Net.Http.Json.HttpClientJsonExtensions.FromJsonStreamAsyncCore[TValue](HttpClient client, Uri requestUri, JsonSerializerOptions options, CancellationToken cancellationToken)

@build-analysisbuild-analysisBot
mentioned this pull request
Sep 18, 2023

Closed

@ghost
ghost
commented
Sep 18, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92180 to release/8.0
/cc @eiriktsarpalis@WeihanLi
Customer Impact
We received a customer reported issue that one of the newly added IAsyncEnumerable methods in the System.Net.Http.Json library is not using the correct default settings when deserializing values.
For instance, even though all other methods in the library use camelCase conversion, the impacted new methods do not.
Testing
Added unit testing covering the impacted scenario.
Risk
Low. Makes a minor change in product code making it consistent with other components in the same library (including other IAsyncEnumerable methods added in the same change).
Author:github-actions[bot]
Assignees:eiriktsarpalis
Labels:
Servicing-consider, area-System.Text.Json
Milestone:8.0.0
jeffhandley
jeffhandley
approved these changes
Sep 18, 2023
View reviewed changes
@jeffhandleyjeffhandley
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has my support for RC2, @artl93. It's a broken/imcomplete 8.0 scenario reported by a customer.
artl93
artl93
approved these changes
Sep 18, 2023
View reviewed changes
@artl93artl93
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M2 approved.
@artl93artl93
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 18, 2023
@carlossanlop
carlossanlop
merged commit e00e6aa
into
release/8.0Sep 18, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-92180-to-release/8.0

branch
September 18, 2023 23:54
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 19, 2023

Closed

@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 19, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jeffhandleyjeffhandleyjeffhandley approved these changes
@artl93artl93artl93 approved these changes
@MihaZupanMihaZupanMihaZupan approved these changes
@ericstjericstjAwaiting requested review from ericstj

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-System.Text.JsonServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@WeihanLi@jeffhandley@artl93@MihaZupan@carlossanlop@eiriktsarpalis@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs by github-actions[bot] · Pull Request #92199 · dotnet/runtime · GitHub
Skip to content
[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs - #92199
Merged
carlossanlop merged 8 commits into
release/8.0from 
backport/pr-92180-to-release/8.0
Sep 18, 2023
Merged
[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs#92199
carlossanlop merged 8 commits into
release/8.0from 
backport/pr-92180-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 17, 2023•

edited by eiriktsarpalis

Loading

Copy link


Copy Markdown

Contributor
Backport of #92180 to release/8.0
/cc @eiriktsarpalis@WeihanLi
Customer Impact
We received a customer reported issue that one of the newly added IAsyncEnumerable methods in the System.Net.Http.Json library is not using the correct default settings when deserializing values.
For instance, even though all other methods in the library use camelCase conversion, the impacted new methods do not.
Testing
Added unit testing covering the impacted scenario.
Risk
Low. Makes a minor change in product code making it consistent with other components in the same library (including other IAsyncEnumerable methods added in the same change).
@ghostghost
added
the 
area-System.Net

label
Sep 17, 2023
@ghost
ghost
commented
Sep 17, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92180 to release/8.0
/cc @eiriktsarpalis@WeihanLi
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-System.Net
Milestone:-
@eiriktsarpaliseiriktsarpalis
self-assigned this
Sep 17, 2023
@eiriktsarpaliseiriktsarpalis
added this to the 8.0.0 milestone
Sep 17, 2023
@eiriktsarpalis
eiriktsarpalis
requested review from
a team, MihaZupan and artl93September 17, 2023 23:10
@eiriktsarpaliseiriktsarpalis
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 17, 2023
@WeihanLi
WeihanLi
commented
Sep 18, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Hi @eiriktsarpalis , just to mention, this also fixes the bug when trying to use a custom serializer option
sample code to reproduce
usingvarhttpClient=newHttpClient();httpClient.BaseAddress=newUri("http://localhost:5297");varstream=httpClient.GetFromJsonAsAsyncEnumerable<Job>("api/Jobs",newJsonSerializerOptions(JsonSerializerDefaults.Web));
Exception likes below:
System.InvalidOperationException: JsonSerializerOptions instance must specify a TypeInfoResolver setting before being marked as read-only.
at System.Text.Json.ThrowHelper.ThrowInvalidOperationException_JsonSerializerOptionsNoTypeInfoResolverSpecified()
at System.Text.Json.JsonSerializerOptions.MakeReadOnly()
at System.Net.Http.Json.HttpClientJsonExtensions.FromJsonStreamAsyncCore[TValue](HttpClient client, Uri requestUri, JsonSerializerOptions options, CancellationToken cancellationToken)

@build-analysisbuild-analysisBot
mentioned this pull request
Sep 18, 2023

Closed

@ghost
ghost
commented
Sep 18, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92180 to release/8.0
/cc @eiriktsarpalis@WeihanLi
Customer Impact
We received a customer reported issue that one of the newly added IAsyncEnumerable methods in the System.Net.Http.Json library is not using the correct default settings when deserializing values.
For instance, even though all other methods in the library use camelCase conversion, the impacted new methods do not.
Testing
Added unit testing covering the impacted scenario.
Risk
Low. Makes a minor change in product code making it consistent with other components in the same library (including other IAsyncEnumerable methods added in the same change).
Author:github-actions[bot]
Assignees:eiriktsarpalis
Labels:
Servicing-consider, area-System.Text.Json
Milestone:8.0.0
jeffhandley
jeffhandley
approved these changes
Sep 18, 2023
View reviewed changes
@jeffhandleyjeffhandley
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has my support for RC2, @artl93. It's a broken/imcomplete 8.0 scenario reported by a customer.
artl93
artl93
approved these changes
Sep 18, 2023
View reviewed changes
@artl93artl93
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M2 approved.
@artl93artl93
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 18, 2023
@carlossanlop
carlossanlop
merged commit e00e6aa
into
release/8.0Sep 18, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-92180-to-release/8.0

branch
September 18, 2023 23:54
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 19, 2023

Closed

@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 19, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jeffhandleyjeffhandleyjeffhandley approved these changes
@artl93artl93artl93 approved these changes
@MihaZupanMihaZupanMihaZupan approved these changes
@ericstjericstjAwaiting requested review from ericstj

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-System.Text.JsonServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@WeihanLi@jeffhandley@artl93@MihaZupan@carlossanlop@eiriktsarpalis@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs by github-actions[bot] · Pull Request #92199 · dotnet/runtime · GitHub
Skip to content
[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs - #92199
Merged
carlossanlop merged 8 commits into
release/8.0from 
backport/pr-92180-to-release/8.0
Sep 18, 2023
Merged
[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs#92199
carlossanlop merged 8 commits into
release/8.0from 
backport/pr-92180-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 17, 2023•

edited by eiriktsarpalis

Loading

Copy link


Copy Markdown

Contributor
Backport of #92180 to release/8.0
/cc @eiriktsarpalis@WeihanLi
Customer Impact
We received a customer reported issue that one of the newly added IAsyncEnumerable methods in the System.Net.Http.Json library is not using the correct default settings when deserializing values.
For instance, even though all other methods in the library use camelCase conversion, the impacted new methods do not.
Testing
Added unit testing covering the impacted scenario.
Risk
Low. Makes a minor change in product code making it consistent with other components in the same library (including other IAsyncEnumerable methods added in the same change).
@ghostghost
added
the 
area-System.Net

label
Sep 17, 2023
@ghost
ghost
commented
Sep 17, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92180 to release/8.0
/cc @eiriktsarpalis@WeihanLi
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-System.Net
Milestone:-
@eiriktsarpaliseiriktsarpalis
self-assigned this
Sep 17, 2023
@eiriktsarpaliseiriktsarpalis
added this to the 8.0.0 milestone
Sep 17, 2023
@eiriktsarpalis
eiriktsarpalis
requested review from
a team, MihaZupan and artl93September 17, 2023 23:10
@eiriktsarpaliseiriktsarpalis
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 17, 2023
@WeihanLi
WeihanLi
commented
Sep 18, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Hi @eiriktsarpalis , just to mention, this also fixes the bug when trying to use a custom serializer option
sample code to reproduce
usingvarhttpClient=newHttpClient();httpClient.BaseAddress=newUri("http://localhost:5297");varstream=httpClient.GetFromJsonAsAsyncEnumerable<Job>("api/Jobs",newJsonSerializerOptions(JsonSerializerDefaults.Web));
Exception likes below:
System.InvalidOperationException: JsonSerializerOptions instance must specify a TypeInfoResolver setting before being marked as read-only.
at System.Text.Json.ThrowHelper.ThrowInvalidOperationException_JsonSerializerOptionsNoTypeInfoResolverSpecified()
at System.Text.Json.JsonSerializerOptions.MakeReadOnly()
at System.Net.Http.Json.HttpClientJsonExtensions.FromJsonStreamAsyncCore[TValue](HttpClient client, Uri requestUri, JsonSerializerOptions options, CancellationToken cancellationToken)

@build-analysisbuild-analysisBot
mentioned this pull request
Sep 18, 2023

Closed

@ghost
ghost
commented
Sep 18, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92180 to release/8.0
/cc @eiriktsarpalis@WeihanLi
Customer Impact
We received a customer reported issue that one of the newly added IAsyncEnumerable methods in the System.Net.Http.Json library is not using the correct default settings when deserializing values.
For instance, even though all other methods in the library use camelCase conversion, the impacted new methods do not.
Testing
Added unit testing covering the impacted scenario.
Risk
Low. Makes a minor change in product code making it consistent with other components in the same library (including other IAsyncEnumerable methods added in the same change).
Author:github-actions[bot]
Assignees:eiriktsarpalis
Labels:
Servicing-consider, area-System.Text.Json
Milestone:8.0.0
jeffhandley
jeffhandley
approved these changes
Sep 18, 2023
View reviewed changes
@jeffhandleyjeffhandley
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has my support for RC2, @artl93. It's a broken/imcomplete 8.0 scenario reported by a customer.
artl93
artl93
approved these changes
Sep 18, 2023
View reviewed changes
@artl93artl93
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M2 approved.
@artl93artl93
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 18, 2023
@carlossanlop
carlossanlop
merged commit e00e6aa
into
release/8.0Sep 18, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-92180-to-release/8.0

branch
September 18, 2023 23:54
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 19, 2023

Closed

@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 19, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jeffhandleyjeffhandleyjeffhandley approved these changes
@artl93artl93artl93 approved these changes
@MihaZupanMihaZupanMihaZupan approved these changes
@ericstjericstjAwaiting requested review from ericstj

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-System.Text.JsonServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@WeihanLi@jeffhandley@artl93@MihaZupan@carlossanlop@eiriktsarpalis@ericstj