Skip to content

Update Newtonsoft.Json from 13.0.1 to 13.0.3 - #92277

Merged
carlossanlop merged 3 commits into
dotnet:release/8.0from
mthalman:newtonsoft
Sep 19, 2023
Merged

Update Newtonsoft.Json from 13.0.1 to 13.0.3#92277
carlossanlop merged 3 commits into
dotnet:release/8.0from
mthalman:newtonsoft

Conversation

@mthalman

@mthalmanmthalman commented Sep 19, 2023

Copy link
Copy Markdown
Member

.NET repos currently have a mix of Newtonsoft.Json versions that we're trying to get consolidated into the latest version. This is particularly necessary for the .NET's source-build which can only reference one version of a dependency.

This was missed as part of the initial set of work to update all repos to 13.0.3.

Related to dotnet/source-build-externals#195 and dotnet/source-build#3629

@ghostghost assigned mthalmanSep 19, 2023
@ghost

ghost commented Sep 19, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

.NET repos currently have a mix of Newtonsoft.Json versions that we're trying to get consolidated into the latest version. This is particularly necessary for the .NET's source-build which can only reference one version of a dependency.

This was missed as part of the initial set of work to update all repos to 13.0.3.

Related to dotnet/source-build-externals#195 and dotnet/source-build#3629

Author:mthalman
Assignees:mthalman
Labels:

area-Infrastructure-libraries

Milestone:-

@ViktorHofer

ViktorHofer commented Sep 19, 2023

Copy link
Copy Markdown
Member

This needs to be forward ported into main as well. Btw I noticed that Arcade also needs a bump (in main).

carlossanlop
carlossanlop approved these changes Sep 19, 2023
View reviewed changes

@carlossanlopcarlossanlop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this in RC2 or can it wait? Asking because I have not snapped yet due to various blocking issues, and we could merge this and include it there.

@carlossanlopcarlossanlop added the Servicing-approved Approved for servicing release label Sep 19, 2023
@carlossanlopcarlossanlop added this to the 8.0.0 milestone Sep 19, 2023
@mthalman

mthalman commented Sep 19, 2023

Copy link
Copy Markdown
MemberAuthor

@carlossanlop - Yes, RC2 would be good

@mthalman

mthalman commented Sep 19, 2023

Copy link
Copy Markdown
MemberAuthor

Looks like there's a build issue though

@mthalman

mthalman commented Sep 19, 2023

Copy link
Copy Markdown
MemberAuthor

I need to update the source-build-externals dependency. Apparently there's no darc subscription for it.

@ViktorHofer

ViktorHofer commented Sep 19, 2023

Copy link
Copy Markdown
Member

@mthalman please create the missing subscriptions (for both 8.0 and main if one of those doesn't exist).

@mthalman

mthalman commented Sep 19, 2023

Copy link
Copy Markdown
MemberAuthor

@mthalman please create the missing subscriptions (for both 8.0 and main if one of those doesn't exist).

Done

@ViktorHofer

ViktorHofer commented Sep 19, 2023

Copy link
Copy Markdown
Member

According to CI, Newtonsoft.Json/13.0.1 is still somehow brought in.

@mthalman

mthalman commented Sep 19, 2023

Copy link
Copy Markdown
MemberAuthor

According to CI, Newtonsoft.Json/13.0.1 is still somehow brought in.

This is due to a dependency on NuGet.Packaging.6.2.4 which still references 13.0.1. I'll add a prebuilt exclusion for this. Not an issue in full source-build since the NuGet.Packaging version would get lifted to the live version in that case.

@ViktorHofer

ViktorHofer commented Sep 19, 2023

Copy link
Copy Markdown
Member

This is due to a dependency on NuGet.Packaging.6.2.4 which still references 13.0.1. I'll add a prebuilt exclusion for this. Not an issue in full source-build since the NuGet.Packaging version would get lifted to the live version in that case.

Makes sense. We could theoretically lift that dependency if we would want to by adding a direct dependency to Newtonsoft.Json but adding an exclusion sounds easier.

@mthalman

mthalman commented Sep 19, 2023

Copy link
Copy Markdown
MemberAuthor

Seems like a flaky test is blocking this.

@carlossanlopcarlossanlop mentioned this pull request Sep 19, 2023
Closed
@carlossanlop

carlossanlop commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

I opened #92295 to track the test failure. Merging now.

@carlossanlop
carlossanlop merged commit 3108db2 into dotnet:release/8.0Sep 19, 2023
@mthalman
mthalman deleted the newtonsoft branch September 19, 2023 19:00
@build-analysisbuild-analysisBot mentioned this pull request Sep 19, 2023
Closed
@mthalmanmthalman mentioned this pull request Sep 19, 2023
Merged
@radicalradical mentioned this pull request Sep 26, 2023
Closed
@radicalradical mentioned this pull request Oct 3, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Oct 19, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes
+1 more reviewer
@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mthalmanmthalman

Labels

area-Infrastructure-librariesServicing-approvedApproved for servicing release

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mthalman@ViktorHofer@carlossanlop
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Update Newtonsoft.Json from 13.0.1 to 13.0.3 by mthalman · Pull Request #92277 · dotnet/runtime · GitHub
Skip to content
Update Newtonsoft.Json from 13.0.1 to 13.0.3 - #92277
Merged
carlossanlop merged 3 commits into
dotnet:release/8.0from 
mthalman:newtonsoft
Sep 19, 2023
Merged
Update Newtonsoft.Json from 13.0.1 to 13.0.3#92277
carlossanlop merged 3 commits into
dotnet:release/8.0from 
mthalman:newtonsoft
Conversation
@mthalman
@mthalmanmthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
.NET repos currently have a mix of Newtonsoft.Json versions that we're trying to get consolidated into the latest version. This is particularly necessary for the .NET's source-build which can only reference one version of a dependency.
This was missed as part of the initial set of work to update all repos to 13.0.3.
Related to dotnet/source-build-externals#195 and dotnet/source-build#3629
@ghostghost
assigned mthalmanSep 19, 2023
@ghost
ghost
commented
Sep 19, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
.NET repos currently have a mix of Newtonsoft.Json versions that we're trying to get consolidated into the latest version. This is particularly necessary for the .NET's source-build which can only reference one version of a dependency.
This was missed as part of the initial set of work to update all repos to 13.0.3.
Related to dotnet/source-build-externals#195 and dotnet/source-build#3629
Author:mthalman
Assignees:mthalman
Labels:
area-Infrastructure-libraries
Milestone:-
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
This needs to be forward ported into main as well. Btw I noticed that Arcade also needs a bump (in main).
carlossanlop
carlossanlop
approved these changes
Sep 19, 2023
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this in RC2 or can it wait? Asking because I have not snapped yet due to various blocking issues, and we could merge this and include it there.
@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Sep 19, 2023
@carlossanlopcarlossanlop
added this to the 8.0.0 milestone
Sep 19, 2023
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop - Yes, RC2 would be good
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
Looks like there's a build issue though
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
I need to update the source-build-externals dependency. Apparently there's no darc subscription for it.
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
@mthalman please create the missing subscriptions (for both 8.0 and main if one of those doesn't exist).
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
@mthalman please create the missing subscriptions (for both 8.0 and main if one of those doesn't exist).
Done
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
According to CI, Newtonsoft.Json/13.0.1 is still somehow brought in.
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
According to CI, Newtonsoft.Json/13.0.1 is still somehow brought in.
This is due to a dependency on NuGet.Packaging.6.2.4 which still references 13.0.1. I'll add a prebuilt exclusion for this. Not an issue in full source-build since the NuGet.Packaging version would get lifted to the live version in that case.
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
This is due to a dependency on NuGet.Packaging.6.2.4 which still references 13.0.1. I'll add a prebuilt exclusion for this. Not an issue in full source-build since the NuGet.Packaging version would get lifted to the live version in that case.
Makes sense. We could theoretically lift that dependency if we would want to by adding a direct dependency to Newtonsoft.Json but adding an exclusion sounds easier.
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
Seems like a flaky test is blocking this.
@carlossanlopcarlossanlop
mentioned this pull request
Sep 19, 2023

Closed

@carlossanlop
carlossanlop
commented
Sep 19, 2023

Copy link


Copy Markdown

Contributor
I opened #92295 to track the test failure. Merging now.
@carlossanlop
carlossanlop
merged commit 3108db2
into
dotnet:release/8.0Sep 19, 2023
@mthalman
mthalman
deleted the

newtonsoft

branch
September 19, 2023 19:00
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 19, 2023

Closed

@mthalmanmthalman
mentioned this pull request
Sep 19, 2023
 Merged

@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 19, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mthalmanmthalman

Labels

area-Infrastructure-librariesServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mthalman@ViktorHofer@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update Newtonsoft.Json from 13.0.1 to 13.0.3 by mthalman · Pull Request #92277 · dotnet/runtime · GitHub
Skip to content
Update Newtonsoft.Json from 13.0.1 to 13.0.3 - #92277
Merged
carlossanlop merged 3 commits into
dotnet:release/8.0from 
mthalman:newtonsoft
Sep 19, 2023
Merged
Update Newtonsoft.Json from 13.0.1 to 13.0.3#92277
carlossanlop merged 3 commits into
dotnet:release/8.0from 
mthalman:newtonsoft
Conversation
@mthalman
@mthalmanmthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
.NET repos currently have a mix of Newtonsoft.Json versions that we're trying to get consolidated into the latest version. This is particularly necessary for the .NET's source-build which can only reference one version of a dependency.
This was missed as part of the initial set of work to update all repos to 13.0.3.
Related to dotnet/source-build-externals#195 and dotnet/source-build#3629
@ghostghost
assigned mthalmanSep 19, 2023
@ghost
ghost
commented
Sep 19, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
.NET repos currently have a mix of Newtonsoft.Json versions that we're trying to get consolidated into the latest version. This is particularly necessary for the .NET's source-build which can only reference one version of a dependency.
This was missed as part of the initial set of work to update all repos to 13.0.3.
Related to dotnet/source-build-externals#195 and dotnet/source-build#3629
Author:mthalman
Assignees:mthalman
Labels:
area-Infrastructure-libraries
Milestone:-
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
This needs to be forward ported into main as well. Btw I noticed that Arcade also needs a bump (in main).
carlossanlop
carlossanlop
approved these changes
Sep 19, 2023
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this in RC2 or can it wait? Asking because I have not snapped yet due to various blocking issues, and we could merge this and include it there.
@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Sep 19, 2023
@carlossanlopcarlossanlop
added this to the 8.0.0 milestone
Sep 19, 2023
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop - Yes, RC2 would be good
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
Looks like there's a build issue though
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
I need to update the source-build-externals dependency. Apparently there's no darc subscription for it.
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
@mthalman please create the missing subscriptions (for both 8.0 and main if one of those doesn't exist).
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
@mthalman please create the missing subscriptions (for both 8.0 and main if one of those doesn't exist).
Done
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
According to CI, Newtonsoft.Json/13.0.1 is still somehow brought in.
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
According to CI, Newtonsoft.Json/13.0.1 is still somehow brought in.
This is due to a dependency on NuGet.Packaging.6.2.4 which still references 13.0.1. I'll add a prebuilt exclusion for this. Not an issue in full source-build since the NuGet.Packaging version would get lifted to the live version in that case.
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
This is due to a dependency on NuGet.Packaging.6.2.4 which still references 13.0.1. I'll add a prebuilt exclusion for this. Not an issue in full source-build since the NuGet.Packaging version would get lifted to the live version in that case.
Makes sense. We could theoretically lift that dependency if we would want to by adding a direct dependency to Newtonsoft.Json but adding an exclusion sounds easier.
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
Seems like a flaky test is blocking this.
@carlossanlopcarlossanlop
mentioned this pull request
Sep 19, 2023

Closed

@carlossanlop
carlossanlop
commented
Sep 19, 2023

Copy link


Copy Markdown

Contributor
I opened #92295 to track the test failure. Merging now.
@carlossanlop
carlossanlop
merged commit 3108db2
into
dotnet:release/8.0Sep 19, 2023
@mthalman
mthalman
deleted the

newtonsoft

branch
September 19, 2023 19:00
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 19, 2023

Closed

@mthalmanmthalman
mentioned this pull request
Sep 19, 2023
 Merged

@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 19, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mthalmanmthalman

Labels

area-Infrastructure-librariesServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mthalman@ViktorHofer@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update Newtonsoft.Json from 13.0.1 to 13.0.3 by mthalman · Pull Request #92277 · dotnet/runtime · GitHub
Skip to content
Update Newtonsoft.Json from 13.0.1 to 13.0.3 - #92277
Merged
carlossanlop merged 3 commits into
dotnet:release/8.0from 
mthalman:newtonsoft
Sep 19, 2023
Merged
Update Newtonsoft.Json from 13.0.1 to 13.0.3#92277
carlossanlop merged 3 commits into
dotnet:release/8.0from 
mthalman:newtonsoft
Conversation
@mthalman
@mthalmanmthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
.NET repos currently have a mix of Newtonsoft.Json versions that we're trying to get consolidated into the latest version. This is particularly necessary for the .NET's source-build which can only reference one version of a dependency.
This was missed as part of the initial set of work to update all repos to 13.0.3.
Related to dotnet/source-build-externals#195 and dotnet/source-build#3629
@ghostghost
assigned mthalmanSep 19, 2023
@ghost
ghost
commented
Sep 19, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
.NET repos currently have a mix of Newtonsoft.Json versions that we're trying to get consolidated into the latest version. This is particularly necessary for the .NET's source-build which can only reference one version of a dependency.
This was missed as part of the initial set of work to update all repos to 13.0.3.
Related to dotnet/source-build-externals#195 and dotnet/source-build#3629
Author:mthalman
Assignees:mthalman
Labels:
area-Infrastructure-libraries
Milestone:-
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
This needs to be forward ported into main as well. Btw I noticed that Arcade also needs a bump (in main).
carlossanlop
carlossanlop
approved these changes
Sep 19, 2023
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this in RC2 or can it wait? Asking because I have not snapped yet due to various blocking issues, and we could merge this and include it there.
@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Sep 19, 2023
@carlossanlopcarlossanlop
added this to the 8.0.0 milestone
Sep 19, 2023
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop - Yes, RC2 would be good
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
Looks like there's a build issue though
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
I need to update the source-build-externals dependency. Apparently there's no darc subscription for it.
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
@mthalman please create the missing subscriptions (for both 8.0 and main if one of those doesn't exist).
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
@mthalman please create the missing subscriptions (for both 8.0 and main if one of those doesn't exist).
Done
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
According to CI, Newtonsoft.Json/13.0.1 is still somehow brought in.
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
According to CI, Newtonsoft.Json/13.0.1 is still somehow brought in.
This is due to a dependency on NuGet.Packaging.6.2.4 which still references 13.0.1. I'll add a prebuilt exclusion for this. Not an issue in full source-build since the NuGet.Packaging version would get lifted to the live version in that case.
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
This is due to a dependency on NuGet.Packaging.6.2.4 which still references 13.0.1. I'll add a prebuilt exclusion for this. Not an issue in full source-build since the NuGet.Packaging version would get lifted to the live version in that case.
Makes sense. We could theoretically lift that dependency if we would want to by adding a direct dependency to Newtonsoft.Json but adding an exclusion sounds easier.
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
Seems like a flaky test is blocking this.
@carlossanlopcarlossanlop
mentioned this pull request
Sep 19, 2023

Closed

@carlossanlop
carlossanlop
commented
Sep 19, 2023

Copy link


Copy Markdown

Contributor
I opened #92295 to track the test failure. Merging now.
@carlossanlop
carlossanlop
merged commit 3108db2
into
dotnet:release/8.0Sep 19, 2023
@mthalman
mthalman
deleted the

newtonsoft

branch
September 19, 2023 19:00
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 19, 2023

Closed

@mthalmanmthalman
mentioned this pull request
Sep 19, 2023
 Merged

@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 19, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mthalmanmthalman

Labels

area-Infrastructure-librariesServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mthalman@ViktorHofer@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Update Newtonsoft.Json from 13.0.1 to 13.0.3 by mthalman · Pull Request #92277 · dotnet/runtime · GitHub
Skip to content
Update Newtonsoft.Json from 13.0.1 to 13.0.3 - #92277
Merged
carlossanlop merged 3 commits into
dotnet:release/8.0from 
mthalman:newtonsoft
Sep 19, 2023
Merged
Update Newtonsoft.Json from 13.0.1 to 13.0.3#92277
carlossanlop merged 3 commits into
dotnet:release/8.0from 
mthalman:newtonsoft
Conversation
@mthalman
@mthalmanmthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
.NET repos currently have a mix of Newtonsoft.Json versions that we're trying to get consolidated into the latest version. This is particularly necessary for the .NET's source-build which can only reference one version of a dependency.
This was missed as part of the initial set of work to update all repos to 13.0.3.
Related to dotnet/source-build-externals#195 and dotnet/source-build#3629
@ghostghost
assigned mthalmanSep 19, 2023
@ghost
ghost
commented
Sep 19, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
.NET repos currently have a mix of Newtonsoft.Json versions that we're trying to get consolidated into the latest version. This is particularly necessary for the .NET's source-build which can only reference one version of a dependency.
This was missed as part of the initial set of work to update all repos to 13.0.3.
Related to dotnet/source-build-externals#195 and dotnet/source-build#3629
Author:mthalman
Assignees:mthalman
Labels:
area-Infrastructure-libraries
Milestone:-
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
This needs to be forward ported into main as well. Btw I noticed that Arcade also needs a bump (in main).
carlossanlop
carlossanlop
approved these changes
Sep 19, 2023
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this in RC2 or can it wait? Asking because I have not snapped yet due to various blocking issues, and we could merge this and include it there.
@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Sep 19, 2023
@carlossanlopcarlossanlop
added this to the 8.0.0 milestone
Sep 19, 2023
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop - Yes, RC2 would be good
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
Looks like there's a build issue though
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
I need to update the source-build-externals dependency. Apparently there's no darc subscription for it.
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
@mthalman please create the missing subscriptions (for both 8.0 and main if one of those doesn't exist).
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
@mthalman please create the missing subscriptions (for both 8.0 and main if one of those doesn't exist).
Done
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
According to CI, Newtonsoft.Json/13.0.1 is still somehow brought in.
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
According to CI, Newtonsoft.Json/13.0.1 is still somehow brought in.
This is due to a dependency on NuGet.Packaging.6.2.4 which still references 13.0.1. I'll add a prebuilt exclusion for this. Not an issue in full source-build since the NuGet.Packaging version would get lifted to the live version in that case.
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
This is due to a dependency on NuGet.Packaging.6.2.4 which still references 13.0.1. I'll add a prebuilt exclusion for this. Not an issue in full source-build since the NuGet.Packaging version would get lifted to the live version in that case.
Makes sense. We could theoretically lift that dependency if we would want to by adding a direct dependency to Newtonsoft.Json but adding an exclusion sounds easier.
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
Seems like a flaky test is blocking this.
@carlossanlopcarlossanlop
mentioned this pull request
Sep 19, 2023

Closed

@carlossanlop
carlossanlop
commented
Sep 19, 2023

Copy link


Copy Markdown

Contributor
I opened #92295 to track the test failure. Merging now.
@carlossanlop
carlossanlop
merged commit 3108db2
into
dotnet:release/8.0Sep 19, 2023
@mthalman
mthalman
deleted the

newtonsoft

branch
September 19, 2023 19:00
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 19, 2023

Closed

@mthalmanmthalman
mentioned this pull request
Sep 19, 2023
 Merged

@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 19, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mthalmanmthalman

Labels

area-Infrastructure-librariesServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mthalman@ViktorHofer@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update Newtonsoft.Json from 13.0.1 to 13.0.3 by mthalman · Pull Request #92277 · dotnet/runtime · GitHub
Skip to content
Update Newtonsoft.Json from 13.0.1 to 13.0.3 - #92277
Merged
carlossanlop merged 3 commits into
dotnet:release/8.0from 
mthalman:newtonsoft
Sep 19, 2023
Merged
Update Newtonsoft.Json from 13.0.1 to 13.0.3#92277
carlossanlop merged 3 commits into
dotnet:release/8.0from 
mthalman:newtonsoft
Conversation
@mthalman
@mthalmanmthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
.NET repos currently have a mix of Newtonsoft.Json versions that we're trying to get consolidated into the latest version. This is particularly necessary for the .NET's source-build which can only reference one version of a dependency.
This was missed as part of the initial set of work to update all repos to 13.0.3.
Related to dotnet/source-build-externals#195 and dotnet/source-build#3629
@ghostghost
assigned mthalmanSep 19, 2023
@ghost
ghost
commented
Sep 19, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
.NET repos currently have a mix of Newtonsoft.Json versions that we're trying to get consolidated into the latest version. This is particularly necessary for the .NET's source-build which can only reference one version of a dependency.
This was missed as part of the initial set of work to update all repos to 13.0.3.
Related to dotnet/source-build-externals#195 and dotnet/source-build#3629
Author:mthalman
Assignees:mthalman
Labels:
area-Infrastructure-libraries
Milestone:-
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
This needs to be forward ported into main as well. Btw I noticed that Arcade also needs a bump (in main).
carlossanlop
carlossanlop
approved these changes
Sep 19, 2023
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this in RC2 or can it wait? Asking because I have not snapped yet due to various blocking issues, and we could merge this and include it there.
@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Sep 19, 2023
@carlossanlopcarlossanlop
added this to the 8.0.0 milestone
Sep 19, 2023
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop - Yes, RC2 would be good
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
Looks like there's a build issue though
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
I need to update the source-build-externals dependency. Apparently there's no darc subscription for it.
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
@mthalman please create the missing subscriptions (for both 8.0 and main if one of those doesn't exist).
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
@mthalman please create the missing subscriptions (for both 8.0 and main if one of those doesn't exist).
Done
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
According to CI, Newtonsoft.Json/13.0.1 is still somehow brought in.
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
According to CI, Newtonsoft.Json/13.0.1 is still somehow brought in.
This is due to a dependency on NuGet.Packaging.6.2.4 which still references 13.0.1. I'll add a prebuilt exclusion for this. Not an issue in full source-build since the NuGet.Packaging version would get lifted to the live version in that case.
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
This is due to a dependency on NuGet.Packaging.6.2.4 which still references 13.0.1. I'll add a prebuilt exclusion for this. Not an issue in full source-build since the NuGet.Packaging version would get lifted to the live version in that case.
Makes sense. We could theoretically lift that dependency if we would want to by adding a direct dependency to Newtonsoft.Json but adding an exclusion sounds easier.
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
Seems like a flaky test is blocking this.
@carlossanlopcarlossanlop
mentioned this pull request
Sep 19, 2023

Closed

@carlossanlop
carlossanlop
commented
Sep 19, 2023

Copy link


Copy Markdown

Contributor
I opened #92295 to track the test failure. Merging now.
@carlossanlop
carlossanlop
merged commit 3108db2
into
dotnet:release/8.0Sep 19, 2023
@mthalman
mthalman
deleted the

newtonsoft

branch
September 19, 2023 19:00
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 19, 2023

Closed

@mthalmanmthalman
mentioned this pull request
Sep 19, 2023
 Merged

@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 19, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mthalmanmthalman

Labels

area-Infrastructure-librariesServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mthalman@ViktorHofer@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Update Newtonsoft.Json from 13.0.1 to 13.0.3 by mthalman · Pull Request #92277 · dotnet/runtime · GitHub
Skip to content
Update Newtonsoft.Json from 13.0.1 to 13.0.3 - #92277
Merged
carlossanlop merged 3 commits into
dotnet:release/8.0from 
mthalman:newtonsoft
Sep 19, 2023
Merged
Update Newtonsoft.Json from 13.0.1 to 13.0.3#92277
carlossanlop merged 3 commits into
dotnet:release/8.0from 
mthalman:newtonsoft
Conversation
@mthalman
@mthalmanmthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
.NET repos currently have a mix of Newtonsoft.Json versions that we're trying to get consolidated into the latest version. This is particularly necessary for the .NET's source-build which can only reference one version of a dependency.
This was missed as part of the initial set of work to update all repos to 13.0.3.
Related to dotnet/source-build-externals#195 and dotnet/source-build#3629
@ghostghost
assigned mthalmanSep 19, 2023
@ghost
ghost
commented
Sep 19, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
.NET repos currently have a mix of Newtonsoft.Json versions that we're trying to get consolidated into the latest version. This is particularly necessary for the .NET's source-build which can only reference one version of a dependency.
This was missed as part of the initial set of work to update all repos to 13.0.3.
Related to dotnet/source-build-externals#195 and dotnet/source-build#3629
Author:mthalman
Assignees:mthalman
Labels:
area-Infrastructure-libraries
Milestone:-
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
This needs to be forward ported into main as well. Btw I noticed that Arcade also needs a bump (in main).
carlossanlop
carlossanlop
approved these changes
Sep 19, 2023
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this in RC2 or can it wait? Asking because I have not snapped yet due to various blocking issues, and we could merge this and include it there.
@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Sep 19, 2023
@carlossanlopcarlossanlop
added this to the 8.0.0 milestone
Sep 19, 2023
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop - Yes, RC2 would be good
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
Looks like there's a build issue though
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
I need to update the source-build-externals dependency. Apparently there's no darc subscription for it.
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
@mthalman please create the missing subscriptions (for both 8.0 and main if one of those doesn't exist).
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
@mthalman please create the missing subscriptions (for both 8.0 and main if one of those doesn't exist).
Done
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
According to CI, Newtonsoft.Json/13.0.1 is still somehow brought in.
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
According to CI, Newtonsoft.Json/13.0.1 is still somehow brought in.
This is due to a dependency on NuGet.Packaging.6.2.4 which still references 13.0.1. I'll add a prebuilt exclusion for this. Not an issue in full source-build since the NuGet.Packaging version would get lifted to the live version in that case.
@ViktorHofer
ViktorHofer
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
This is due to a dependency on NuGet.Packaging.6.2.4 which still references 13.0.1. I'll add a prebuilt exclusion for this. Not an issue in full source-build since the NuGet.Packaging version would get lifted to the live version in that case.
Makes sense. We could theoretically lift that dependency if we would want to by adding a direct dependency to Newtonsoft.Json but adding an exclusion sounds easier.
@mthalman
mthalman
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
Seems like a flaky test is blocking this.
@carlossanlopcarlossanlop
mentioned this pull request
Sep 19, 2023

Closed

@carlossanlop
carlossanlop
commented
Sep 19, 2023

Copy link


Copy Markdown

Contributor
I opened #92295 to track the test failure. Merging now.
@carlossanlop
carlossanlop
merged commit 3108db2
into
dotnet:release/8.0Sep 19, 2023
@mthalman
mthalman
deleted the

newtonsoft

branch
September 19, 2023 19:00
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 19, 2023

Closed

@mthalmanmthalman
mentioned this pull request
Sep 19, 2023
 Merged

@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 19, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mthalmanmthalman

Labels

area-Infrastructure-librariesServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mthalman@ViktorHofer@carlossanlop