Uh oh!
There was an error while loading. Please reload this page.
[release/8.0-rc2] IDispatch should accept HRESULT as valuetype - #92494
Merged
Conversation
jkoritzinsky
approved these changes
Sep 22, 2023
jeffschwMSFT
approved these changes
Sep 22, 2023
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
approved. we will take for consideration in RC2
carlossanlop
commented
Sep 22, 2023
Contributor
@AaronRobinsonMSFT this is targeting release/8.0, which represents RTM. If your intention is to target RC2, please retarget the branch by editing the PR title. Make sure no spurious commits get added unexpectedly when retargeting branch. Today EOD is the deadline for merging RC2 backports. |
AaronRobinsonMSFT
changed the base branch from
release/8.0
to
release/8.0-rc2September 22, 2023 20:40
IDispatch should accept HRESULT as valuetypeIDispatch should accept HRESULT as valuetypeIDispatch should accept HRESULT as valuetypeIDispatch should accept HRESULT as valuetypeThis is a regression from .NET Framework. The current behavior has existed since IDispatch was introduced into .NET Core. Added tests for the current behavior.
AaronRobinsonMSFTforce-pushed
the
backport/pr-92447-to-release/8.0
branch
from
September 22, 2023 20:45
845d1a2 to
1507ca8CompareIDispatch should accept HRESULT as valuetypeIDispatch should accept HRESULT as valuetyperadical
removed their request for review
September 22, 2023 20:47
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #92447 to release/8.0
/cc @AaronRobinsonMSFT@elinor-fung@jkoritzinsky@JeremyKuhne@lonitra
Customer Impact
This is a regression from .NET Framework.
The current behavior has existed since
IDispatchwas introduced into .NET Core. This was discovered in WinForms during testing using CsWin32 generated COM interfaces.Testing
Added tests for the current behavior.
Risk
Minimal. This is enabling a narrow feature that has been broken since .NET Core 3.0. This code path is also limited to
IDispatch scenarios.IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.