Skip to content

[release/8.0] [wasm] Endian fix for Webcil - #92495

Merged
carlossanlop merged 3 commits into
release/8.0from
backport/pr-92274-to-release/8.0
Oct 3, 2023
Merged

[release/8.0] [wasm] Endian fix for Webcil#92495
carlossanlop merged 3 commits into
release/8.0from
backport/pr-92274-to-release/8.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Sep 22, 2023•
edited by lambdageek
Loading

Copy link
Copy Markdown
Contributor

Backport of #92274 to release/8.0

/cc @lambdageek@saitama951

Customer Impact

Customers using the browser-wasm workload on s390x and other big-endian platforms are able to produce working wasm webcil modules.

Testing

Manual testing

Risk

Low~~/Medium~~. There is additional code on non-s390x platforms in the webcil assembly, but it is all gated by an endianness check. In .NET Framework builds of the wasm builder MSBuild task there is a new dependency on the System.Memory.dll out of band assembly - so if we got the version dependencies wrong this may break the build for customers building browser-wasm projects using Visual Studio on Windows. (See #92495 (comment))

saitama951and others added 3 commits September 22, 2023 18:52
@saitama951
[wasm] Endian fix for Webcil
51278d6
'dotnet new blazorwasm' command failed on s390x and was throwing a not implemented exception
The issue was with with the WebCil writer and reader, specific endianness conversions relating to the webcil payload were not implemented for big endian machines.
We considered fixing the generic implementation, but there were only two structures in use: WebcilHeader and WebcilSectionHeader, so it was easier to handle them explicitly.
@lambdageek
Fix infinite recursion
1dbcc53
@lambdageek
rename var
aaf0ca6
@ghostghost added the area-System.Net label Sep 22, 2023
@ghost

ghost commented Sep 22, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92274 to release/8.0

/cc @lambdageek@saitama951

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

area-System.Net

Milestone:-

@lambdageeklambdageek added area-Build-mono Servicing-consider Issue for next servicing release review and removed area-System.Net labels Sep 22, 2023
@lambdageeklambdageek added this to the 8.0.0 milestone Sep 22, 2023
@lambdageeklambdageek added the arch-wasm WebAssembly architecture label Sep 22, 2023
@ghost

ghost commented Sep 22, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92274 to release/8.0

/cc @lambdageek@saitama951

Customer Impact

Customers using the browser-wasm workload on s390x and other big-endian platforms are able to produce working wasm webcil modules.

Testing

Manual testing

Risk

Low/Medium. There is additional code on non-s390x platforms in the webcil assembly, but it is all gated by an endianness check. In .NET Framework builds of the wasm builder MSBuild task there is a new dependency on the System.Memory.dll out of band assembly - so if we got the version dependencies wrong this may break the build for customers building browser-wasm projects using Visual Studio on Windows.

Author:github-actions[bot]
Assignees:-
Labels:

Servicing-consider, arch-wasm, area-Build-mono

Milestone:8.0.0

@carlossanlop

carlossanlop commented Sep 22, 2023

Copy link
Copy Markdown
Contributor

@lambdageek is it intentional to target release/8.0, or were you intending to target release/8.0-rc2?

If the latter, then please edit the PR title and choose the target branch from the dropdown. Just please make sure to confirm that the commits are the ones you want, because sometimes additional unwanted commits get added.

@carlossanlop

carlossanlop commented Sep 22, 2023

Copy link
Copy Markdown
Contributor

I don't see an email requesting Tactics approval, and we're close to EOD so this will have to go to runtime/8.0 directly (RTM).

@lambdageek

lambdageek commented Sep 25, 2023

Copy link
Copy Markdown
Member

@carlossanlop RTM is ok. I wasn't sure there was runway left for RC2.

@carlossanlop

carlossanlop commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

@lambdageek don't forget to send an email requesting Tactics approval. I can't find one with this PR's title.

@rainersigwald

rainersigwald commented Sep 29, 2023

Copy link
Copy Markdown
Member

The System.Memory reference matches the one MSBuild guarantees (and we use ourselves) in supported-for-.NET-8.0 MSBuild/VS versions (17.7+), so I think that risk here is low.

@carlossanlopcarlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 29, 2023
@carlossanlop

carlossanlop commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

Approved by Tactics but needs a code review sign-off from another area owner. @lewing@steveisok@radical? Who can volunteer as tribute?

@carlossanlop

carlossanlop commented Oct 3, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

@lambdageek@lewing@steveisok@radical can we get a sign-off please?

@carlossanlop
carlossanlop merged commit 2e50c1e into release/8.0Oct 3, 2023
@carlossanlop
carlossanlop deleted the backport/pr-92274-to-release/8.0 branch October 3, 2023 17:28
@radicalradical mentioned this pull request Oct 3, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radicalradicalradical approved these changes
@steveisoksteveisokAwaiting requested review from steveisok
@lewinglewingAwaiting requested review from lewing
@lambdageeklambdageekAwaiting requested review from lambdageek

Assignees

No one assigned

Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@carlossanlop@lambdageek@rainersigwald@radical@saitama951
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[release/8.0] [wasm] Endian fix for Webcil by github-actions[bot] · Pull Request #92495 · dotnet/runtime · GitHub
Skip to content
[release/8.0] [wasm] Endian fix for Webcil - #92495
Merged
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-92274-to-release/8.0
Oct 3, 2023
Merged
[release/8.0] [wasm] Endian fix for Webcil#92495
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-92274-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 22, 2023•

edited by lambdageek

Loading

Copy link


Copy Markdown

Contributor
Backport of #92274 to release/8.0
/cc @lambdageek@saitama951
Customer Impact
Customers using the browser-wasm workload on s390x and other big-endian platforms are able to produce working wasm webcil modules.
Testing
Manual testing
Risk
Low~~/Medium~~. There is additional code on non-s390x platforms in the webcil assembly, but it is all gated by an endianness check. In .NET Framework builds of the wasm builder MSBuild task there is a new dependency on the System.Memory.dll out of band assembly - so if we got the version dependencies wrong this may break the build for customers building browser-wasm projects using Visual Studio on Windows. (See #92495 (comment))
saitama951and others
added 3 commits
September 22, 2023 18:52
@saitama951
[wasm] Endian fix for Webcil
51278d6
'dotnet new blazorwasm' command failed on s390x and was throwing a not implemented exception
The issue was with with the WebCil writer and reader, specific endianness conversions relating to the webcil payload were not implemented for big endian machines.
We considered fixing the generic implementation, but there were only two structures in use: WebcilHeader and WebcilSectionHeader, so it was easier to handle them explicitly.
@lambdageek
Fix infinite recursion
1dbcc53
@lambdageek
rename var
aaf0ca6
@ghostghost
added
the 
area-System.Net

label
Sep 22, 2023
@ghost
ghost
commented
Sep 22, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92274 to release/8.0
/cc @lambdageek@saitama951
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-System.Net
Milestone:-
@lambdageeklambdageek
added

area-Build-mono

Servicing-consider
Issue for next servicing release review
and removed

area-System.Net

labels
Sep 22, 2023
@lambdageeklambdageek
added this to the 8.0.0 milestone
Sep 22, 2023
@lambdageeklambdageek
added
the 
arch-wasm
WebAssembly architecture
label
Sep 22, 2023
@ghost
ghost
commented
Sep 22, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92274 to release/8.0
/cc @lambdageek@saitama951
Customer Impact
Customers using the browser-wasm workload on s390x and other big-endian platforms are able to produce working wasm webcil modules.
Testing
Manual testing
Risk
Low/Medium. There is additional code on non-s390x platforms in the webcil assembly, but it is all gated by an endianness check. In .NET Framework builds of the wasm builder MSBuild task there is a new dependency on the System.Memory.dll out of band assembly - so if we got the version dependencies wrong this may break the build for customers building browser-wasm projects using Visual Studio on Windows.
Author:github-actions[bot]
Assignees:-
Labels:
Servicing-consider, arch-wasm, area-Build-mono
Milestone:8.0.0
@carlossanlop
carlossanlop
commented
Sep 22, 2023

Copy link


Copy Markdown

Contributor
@lambdageek is it intentional to target release/8.0, or were you intending to target release/8.0-rc2?
If the latter, then please edit the PR title and choose the target branch from the dropdown. Just please make sure to confirm that the commits are the ones you want, because sometimes additional unwanted commits get added.
@carlossanlop
carlossanlop
commented
Sep 22, 2023

Copy link


Copy Markdown

Contributor
I don't see an email requesting Tactics approval, and we're close to EOD so this will have to go to runtime/8.0 directly (RTM).
@lambdageek
lambdageek
commented
Sep 25, 2023

Copy link


Copy Markdown

Member
@carlossanlop RTM is ok. I wasn't sure there was runway left for RC2.
@carlossanlop
carlossanlop
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
@lambdageek don't forget to send an email requesting Tactics approval. I can't find one with this PR's title.
@rainersigwald
rainersigwald
commented
Sep 29, 2023

Copy link


Copy Markdown

Member
The System.Memory reference matches the one MSBuild guarantees (and we use ourselves) in supported-for-.NET-8.0 MSBuild/VS versions (17.7+), so I think that risk here is low.
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 29, 2023
@carlossanlop
carlossanlop
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics but needs a code review sign-off from another area owner. @lewing@steveisok@radical? Who can volunteer as tribute?
@carlossanlop
carlossanlop
commented
Oct 3, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
@lambdageek@lewing@steveisok@radical can we get a sign-off please?
@carlossanlop
carlossanlop
merged commit 2e50c1e
into
release/8.0Oct 3, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-92274-to-release/8.0

branch
October 3, 2023 17:28
@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 2, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@radicalradicalradical approved these changes
@steveisoksteveisokAwaiting requested review from steveisok
@lewinglewingAwaiting requested review from lewing
@lambdageeklambdageekAwaiting requested review from lambdageek

Assignees


No one assigned


Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@carlossanlop@lambdageek@rainersigwald@radical@saitama951

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] [wasm] Endian fix for Webcil by github-actions[bot] · Pull Request #92495 · dotnet/runtime · GitHub
Skip to content
[release/8.0] [wasm] Endian fix for Webcil - #92495
Merged
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-92274-to-release/8.0
Oct 3, 2023
Merged
[release/8.0] [wasm] Endian fix for Webcil#92495
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-92274-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 22, 2023•

edited by lambdageek

Loading

Copy link


Copy Markdown

Contributor
Backport of #92274 to release/8.0
/cc @lambdageek@saitama951
Customer Impact
Customers using the browser-wasm workload on s390x and other big-endian platforms are able to produce working wasm webcil modules.
Testing
Manual testing
Risk
Low~~/Medium~~. There is additional code on non-s390x platforms in the webcil assembly, but it is all gated by an endianness check. In .NET Framework builds of the wasm builder MSBuild task there is a new dependency on the System.Memory.dll out of band assembly - so if we got the version dependencies wrong this may break the build for customers building browser-wasm projects using Visual Studio on Windows. (See #92495 (comment))
saitama951and others
added 3 commits
September 22, 2023 18:52
@saitama951
[wasm] Endian fix for Webcil
51278d6
'dotnet new blazorwasm' command failed on s390x and was throwing a not implemented exception
The issue was with with the WebCil writer and reader, specific endianness conversions relating to the webcil payload were not implemented for big endian machines.
We considered fixing the generic implementation, but there were only two structures in use: WebcilHeader and WebcilSectionHeader, so it was easier to handle them explicitly.
@lambdageek
Fix infinite recursion
1dbcc53
@lambdageek
rename var
aaf0ca6
@ghostghost
added
the 
area-System.Net

label
Sep 22, 2023
@ghost
ghost
commented
Sep 22, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92274 to release/8.0
/cc @lambdageek@saitama951
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-System.Net
Milestone:-
@lambdageeklambdageek
added

area-Build-mono

Servicing-consider
Issue for next servicing release review
and removed

area-System.Net

labels
Sep 22, 2023
@lambdageeklambdageek
added this to the 8.0.0 milestone
Sep 22, 2023
@lambdageeklambdageek
added
the 
arch-wasm
WebAssembly architecture
label
Sep 22, 2023
@ghost
ghost
commented
Sep 22, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92274 to release/8.0
/cc @lambdageek@saitama951
Customer Impact
Customers using the browser-wasm workload on s390x and other big-endian platforms are able to produce working wasm webcil modules.
Testing
Manual testing
Risk
Low/Medium. There is additional code on non-s390x platforms in the webcil assembly, but it is all gated by an endianness check. In .NET Framework builds of the wasm builder MSBuild task there is a new dependency on the System.Memory.dll out of band assembly - so if we got the version dependencies wrong this may break the build for customers building browser-wasm projects using Visual Studio on Windows.
Author:github-actions[bot]
Assignees:-
Labels:
Servicing-consider, arch-wasm, area-Build-mono
Milestone:8.0.0
@carlossanlop
carlossanlop
commented
Sep 22, 2023

Copy link


Copy Markdown

Contributor
@lambdageek is it intentional to target release/8.0, or were you intending to target release/8.0-rc2?
If the latter, then please edit the PR title and choose the target branch from the dropdown. Just please make sure to confirm that the commits are the ones you want, because sometimes additional unwanted commits get added.
@carlossanlop
carlossanlop
commented
Sep 22, 2023

Copy link


Copy Markdown

Contributor
I don't see an email requesting Tactics approval, and we're close to EOD so this will have to go to runtime/8.0 directly (RTM).
@lambdageek
lambdageek
commented
Sep 25, 2023

Copy link


Copy Markdown

Member
@carlossanlop RTM is ok. I wasn't sure there was runway left for RC2.
@carlossanlop
carlossanlop
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
@lambdageek don't forget to send an email requesting Tactics approval. I can't find one with this PR's title.
@rainersigwald
rainersigwald
commented
Sep 29, 2023

Copy link


Copy Markdown

Member
The System.Memory reference matches the one MSBuild guarantees (and we use ourselves) in supported-for-.NET-8.0 MSBuild/VS versions (17.7+), so I think that risk here is low.
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 29, 2023
@carlossanlop
carlossanlop
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics but needs a code review sign-off from another area owner. @lewing@steveisok@radical? Who can volunteer as tribute?
@carlossanlop
carlossanlop
commented
Oct 3, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
@lambdageek@lewing@steveisok@radical can we get a sign-off please?
@carlossanlop
carlossanlop
merged commit 2e50c1e
into
release/8.0Oct 3, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-92274-to-release/8.0

branch
October 3, 2023 17:28
@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 2, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@radicalradicalradical approved these changes
@steveisoksteveisokAwaiting requested review from steveisok
@lewinglewingAwaiting requested review from lewing
@lambdageeklambdageekAwaiting requested review from lambdageek

Assignees


No one assigned


Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@carlossanlop@lambdageek@rainersigwald@radical@saitama951

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] [wasm] Endian fix for Webcil by github-actions[bot] · Pull Request #92495 · dotnet/runtime · GitHub
Skip to content
[release/8.0] [wasm] Endian fix for Webcil - #92495
Merged
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-92274-to-release/8.0
Oct 3, 2023
Merged
[release/8.0] [wasm] Endian fix for Webcil#92495
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-92274-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 22, 2023•

edited by lambdageek

Loading

Copy link


Copy Markdown

Contributor
Backport of #92274 to release/8.0
/cc @lambdageek@saitama951
Customer Impact
Customers using the browser-wasm workload on s390x and other big-endian platforms are able to produce working wasm webcil modules.
Testing
Manual testing
Risk
Low~~/Medium~~. There is additional code on non-s390x platforms in the webcil assembly, but it is all gated by an endianness check. In .NET Framework builds of the wasm builder MSBuild task there is a new dependency on the System.Memory.dll out of band assembly - so if we got the version dependencies wrong this may break the build for customers building browser-wasm projects using Visual Studio on Windows. (See #92495 (comment))
saitama951and others
added 3 commits
September 22, 2023 18:52
@saitama951
[wasm] Endian fix for Webcil
51278d6
'dotnet new blazorwasm' command failed on s390x and was throwing a not implemented exception
The issue was with with the WebCil writer and reader, specific endianness conversions relating to the webcil payload were not implemented for big endian machines.
We considered fixing the generic implementation, but there were only two structures in use: WebcilHeader and WebcilSectionHeader, so it was easier to handle them explicitly.
@lambdageek
Fix infinite recursion
1dbcc53
@lambdageek
rename var
aaf0ca6
@ghostghost
added
the 
area-System.Net

label
Sep 22, 2023
@ghost
ghost
commented
Sep 22, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92274 to release/8.0
/cc @lambdageek@saitama951
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-System.Net
Milestone:-
@lambdageeklambdageek
added

area-Build-mono

Servicing-consider
Issue for next servicing release review
and removed

area-System.Net

labels
Sep 22, 2023
@lambdageeklambdageek
added this to the 8.0.0 milestone
Sep 22, 2023
@lambdageeklambdageek
added
the 
arch-wasm
WebAssembly architecture
label
Sep 22, 2023
@ghost
ghost
commented
Sep 22, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92274 to release/8.0
/cc @lambdageek@saitama951
Customer Impact
Customers using the browser-wasm workload on s390x and other big-endian platforms are able to produce working wasm webcil modules.
Testing
Manual testing
Risk
Low/Medium. There is additional code on non-s390x platforms in the webcil assembly, but it is all gated by an endianness check. In .NET Framework builds of the wasm builder MSBuild task there is a new dependency on the System.Memory.dll out of band assembly - so if we got the version dependencies wrong this may break the build for customers building browser-wasm projects using Visual Studio on Windows.
Author:github-actions[bot]
Assignees:-
Labels:
Servicing-consider, arch-wasm, area-Build-mono
Milestone:8.0.0
@carlossanlop
carlossanlop
commented
Sep 22, 2023

Copy link


Copy Markdown

Contributor
@lambdageek is it intentional to target release/8.0, or were you intending to target release/8.0-rc2?
If the latter, then please edit the PR title and choose the target branch from the dropdown. Just please make sure to confirm that the commits are the ones you want, because sometimes additional unwanted commits get added.
@carlossanlop
carlossanlop
commented
Sep 22, 2023

Copy link


Copy Markdown

Contributor
I don't see an email requesting Tactics approval, and we're close to EOD so this will have to go to runtime/8.0 directly (RTM).
@lambdageek
lambdageek
commented
Sep 25, 2023

Copy link


Copy Markdown

Member
@carlossanlop RTM is ok. I wasn't sure there was runway left for RC2.
@carlossanlop
carlossanlop
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
@lambdageek don't forget to send an email requesting Tactics approval. I can't find one with this PR's title.
@rainersigwald
rainersigwald
commented
Sep 29, 2023

Copy link


Copy Markdown

Member
The System.Memory reference matches the one MSBuild guarantees (and we use ourselves) in supported-for-.NET-8.0 MSBuild/VS versions (17.7+), so I think that risk here is low.
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 29, 2023
@carlossanlop
carlossanlop
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics but needs a code review sign-off from another area owner. @lewing@steveisok@radical? Who can volunteer as tribute?
@carlossanlop
carlossanlop
commented
Oct 3, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
@lambdageek@lewing@steveisok@radical can we get a sign-off please?
@carlossanlop
carlossanlop
merged commit 2e50c1e
into
release/8.0Oct 3, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-92274-to-release/8.0

branch
October 3, 2023 17:28
@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 2, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@radicalradicalradical approved these changes
@steveisoksteveisokAwaiting requested review from steveisok
@lewinglewingAwaiting requested review from lewing
@lambdageeklambdageekAwaiting requested review from lambdageek

Assignees


No one assigned


Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@carlossanlop@lambdageek@rainersigwald@radical@saitama951

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[release/8.0] [wasm] Endian fix for Webcil by github-actions[bot] · Pull Request #92495 · dotnet/runtime · GitHub
Skip to content
[release/8.0] [wasm] Endian fix for Webcil - #92495
Merged
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-92274-to-release/8.0
Oct 3, 2023
Merged
[release/8.0] [wasm] Endian fix for Webcil#92495
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-92274-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 22, 2023•

edited by lambdageek

Loading

Copy link


Copy Markdown

Contributor
Backport of #92274 to release/8.0
/cc @lambdageek@saitama951
Customer Impact
Customers using the browser-wasm workload on s390x and other big-endian platforms are able to produce working wasm webcil modules.
Testing
Manual testing
Risk
Low~~/Medium~~. There is additional code on non-s390x platforms in the webcil assembly, but it is all gated by an endianness check. In .NET Framework builds of the wasm builder MSBuild task there is a new dependency on the System.Memory.dll out of band assembly - so if we got the version dependencies wrong this may break the build for customers building browser-wasm projects using Visual Studio on Windows. (See #92495 (comment))
saitama951and others
added 3 commits
September 22, 2023 18:52
@saitama951
[wasm] Endian fix for Webcil
51278d6
'dotnet new blazorwasm' command failed on s390x and was throwing a not implemented exception
The issue was with with the WebCil writer and reader, specific endianness conversions relating to the webcil payload were not implemented for big endian machines.
We considered fixing the generic implementation, but there were only two structures in use: WebcilHeader and WebcilSectionHeader, so it was easier to handle them explicitly.
@lambdageek
Fix infinite recursion
1dbcc53
@lambdageek
rename var
aaf0ca6
@ghostghost
added
the 
area-System.Net

label
Sep 22, 2023
@ghost
ghost
commented
Sep 22, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92274 to release/8.0
/cc @lambdageek@saitama951
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-System.Net
Milestone:-
@lambdageeklambdageek
added

area-Build-mono

Servicing-consider
Issue for next servicing release review
and removed

area-System.Net

labels
Sep 22, 2023
@lambdageeklambdageek
added this to the 8.0.0 milestone
Sep 22, 2023
@lambdageeklambdageek
added
the 
arch-wasm
WebAssembly architecture
label
Sep 22, 2023
@ghost
ghost
commented
Sep 22, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92274 to release/8.0
/cc @lambdageek@saitama951
Customer Impact
Customers using the browser-wasm workload on s390x and other big-endian platforms are able to produce working wasm webcil modules.
Testing
Manual testing
Risk
Low/Medium. There is additional code on non-s390x platforms in the webcil assembly, but it is all gated by an endianness check. In .NET Framework builds of the wasm builder MSBuild task there is a new dependency on the System.Memory.dll out of band assembly - so if we got the version dependencies wrong this may break the build for customers building browser-wasm projects using Visual Studio on Windows.
Author:github-actions[bot]
Assignees:-
Labels:
Servicing-consider, arch-wasm, area-Build-mono
Milestone:8.0.0
@carlossanlop
carlossanlop
commented
Sep 22, 2023

Copy link


Copy Markdown

Contributor
@lambdageek is it intentional to target release/8.0, or were you intending to target release/8.0-rc2?
If the latter, then please edit the PR title and choose the target branch from the dropdown. Just please make sure to confirm that the commits are the ones you want, because sometimes additional unwanted commits get added.
@carlossanlop
carlossanlop
commented
Sep 22, 2023

Copy link


Copy Markdown

Contributor
I don't see an email requesting Tactics approval, and we're close to EOD so this will have to go to runtime/8.0 directly (RTM).
@lambdageek
lambdageek
commented
Sep 25, 2023

Copy link


Copy Markdown

Member
@carlossanlop RTM is ok. I wasn't sure there was runway left for RC2.
@carlossanlop
carlossanlop
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
@lambdageek don't forget to send an email requesting Tactics approval. I can't find one with this PR's title.
@rainersigwald
rainersigwald
commented
Sep 29, 2023

Copy link


Copy Markdown

Member
The System.Memory reference matches the one MSBuild guarantees (and we use ourselves) in supported-for-.NET-8.0 MSBuild/VS versions (17.7+), so I think that risk here is low.
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 29, 2023
@carlossanlop
carlossanlop
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics but needs a code review sign-off from another area owner. @lewing@steveisok@radical? Who can volunteer as tribute?
@carlossanlop
carlossanlop
commented
Oct 3, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
@lambdageek@lewing@steveisok@radical can we get a sign-off please?
@carlossanlop
carlossanlop
merged commit 2e50c1e
into
release/8.0Oct 3, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-92274-to-release/8.0

branch
October 3, 2023 17:28
@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 2, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@radicalradicalradical approved these changes
@steveisoksteveisokAwaiting requested review from steveisok
@lewinglewingAwaiting requested review from lewing
@lambdageeklambdageekAwaiting requested review from lambdageek

Assignees


No one assigned


Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@carlossanlop@lambdageek@rainersigwald@radical@saitama951

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] [wasm] Endian fix for Webcil by github-actions[bot] · Pull Request #92495 · dotnet/runtime · GitHub
Skip to content
[release/8.0] [wasm] Endian fix for Webcil - #92495
Merged
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-92274-to-release/8.0
Oct 3, 2023
Merged
[release/8.0] [wasm] Endian fix for Webcil#92495
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-92274-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 22, 2023•

edited by lambdageek

Loading

Copy link


Copy Markdown

Contributor
Backport of #92274 to release/8.0
/cc @lambdageek@saitama951
Customer Impact
Customers using the browser-wasm workload on s390x and other big-endian platforms are able to produce working wasm webcil modules.
Testing
Manual testing
Risk
Low~~/Medium~~. There is additional code on non-s390x platforms in the webcil assembly, but it is all gated by an endianness check. In .NET Framework builds of the wasm builder MSBuild task there is a new dependency on the System.Memory.dll out of band assembly - so if we got the version dependencies wrong this may break the build for customers building browser-wasm projects using Visual Studio on Windows. (See #92495 (comment))
saitama951and others
added 3 commits
September 22, 2023 18:52
@saitama951
[wasm] Endian fix for Webcil
51278d6
'dotnet new blazorwasm' command failed on s390x and was throwing a not implemented exception
The issue was with with the WebCil writer and reader, specific endianness conversions relating to the webcil payload were not implemented for big endian machines.
We considered fixing the generic implementation, but there were only two structures in use: WebcilHeader and WebcilSectionHeader, so it was easier to handle them explicitly.
@lambdageek
Fix infinite recursion
1dbcc53
@lambdageek
rename var
aaf0ca6
@ghostghost
added
the 
area-System.Net

label
Sep 22, 2023
@ghost
ghost
commented
Sep 22, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92274 to release/8.0
/cc @lambdageek@saitama951
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-System.Net
Milestone:-
@lambdageeklambdageek
added

area-Build-mono

Servicing-consider
Issue for next servicing release review
and removed

area-System.Net

labels
Sep 22, 2023
@lambdageeklambdageek
added this to the 8.0.0 milestone
Sep 22, 2023
@lambdageeklambdageek
added
the 
arch-wasm
WebAssembly architecture
label
Sep 22, 2023
@ghost
ghost
commented
Sep 22, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92274 to release/8.0
/cc @lambdageek@saitama951
Customer Impact
Customers using the browser-wasm workload on s390x and other big-endian platforms are able to produce working wasm webcil modules.
Testing
Manual testing
Risk
Low/Medium. There is additional code on non-s390x platforms in the webcil assembly, but it is all gated by an endianness check. In .NET Framework builds of the wasm builder MSBuild task there is a new dependency on the System.Memory.dll out of band assembly - so if we got the version dependencies wrong this may break the build for customers building browser-wasm projects using Visual Studio on Windows.
Author:github-actions[bot]
Assignees:-
Labels:
Servicing-consider, arch-wasm, area-Build-mono
Milestone:8.0.0
@carlossanlop
carlossanlop
commented
Sep 22, 2023

Copy link


Copy Markdown

Contributor
@lambdageek is it intentional to target release/8.0, or were you intending to target release/8.0-rc2?
If the latter, then please edit the PR title and choose the target branch from the dropdown. Just please make sure to confirm that the commits are the ones you want, because sometimes additional unwanted commits get added.
@carlossanlop
carlossanlop
commented
Sep 22, 2023

Copy link


Copy Markdown

Contributor
I don't see an email requesting Tactics approval, and we're close to EOD so this will have to go to runtime/8.0 directly (RTM).
@lambdageek
lambdageek
commented
Sep 25, 2023

Copy link


Copy Markdown

Member
@carlossanlop RTM is ok. I wasn't sure there was runway left for RC2.
@carlossanlop
carlossanlop
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
@lambdageek don't forget to send an email requesting Tactics approval. I can't find one with this PR's title.
@rainersigwald
rainersigwald
commented
Sep 29, 2023

Copy link


Copy Markdown

Member
The System.Memory reference matches the one MSBuild guarantees (and we use ourselves) in supported-for-.NET-8.0 MSBuild/VS versions (17.7+), so I think that risk here is low.
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 29, 2023
@carlossanlop
carlossanlop
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics but needs a code review sign-off from another area owner. @lewing@steveisok@radical? Who can volunteer as tribute?
@carlossanlop
carlossanlop
commented
Oct 3, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
@lambdageek@lewing@steveisok@radical can we get a sign-off please?
@carlossanlop
carlossanlop
merged commit 2e50c1e
into
release/8.0Oct 3, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-92274-to-release/8.0

branch
October 3, 2023 17:28
@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 2, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@radicalradicalradical approved these changes
@steveisoksteveisokAwaiting requested review from steveisok
@lewinglewingAwaiting requested review from lewing
@lambdageeklambdageekAwaiting requested review from lambdageek

Assignees


No one assigned


Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@carlossanlop@lambdageek@rainersigwald@radical@saitama951

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[release/8.0] [wasm] Endian fix for Webcil by github-actions[bot] · Pull Request #92495 · dotnet/runtime · GitHub
Skip to content
[release/8.0] [wasm] Endian fix for Webcil - #92495
Merged
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-92274-to-release/8.0
Oct 3, 2023
Merged
[release/8.0] [wasm] Endian fix for Webcil#92495
carlossanlop merged 3 commits into
release/8.0from 
backport/pr-92274-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 22, 2023•

edited by lambdageek

Loading

Copy link


Copy Markdown

Contributor
Backport of #92274 to release/8.0
/cc @lambdageek@saitama951
Customer Impact
Customers using the browser-wasm workload on s390x and other big-endian platforms are able to produce working wasm webcil modules.
Testing
Manual testing
Risk
Low~~/Medium~~. There is additional code on non-s390x platforms in the webcil assembly, but it is all gated by an endianness check. In .NET Framework builds of the wasm builder MSBuild task there is a new dependency on the System.Memory.dll out of band assembly - so if we got the version dependencies wrong this may break the build for customers building browser-wasm projects using Visual Studio on Windows. (See #92495 (comment))
saitama951and others
added 3 commits
September 22, 2023 18:52
@saitama951
[wasm] Endian fix for Webcil
51278d6
'dotnet new blazorwasm' command failed on s390x and was throwing a not implemented exception
The issue was with with the WebCil writer and reader, specific endianness conversions relating to the webcil payload were not implemented for big endian machines.
We considered fixing the generic implementation, but there were only two structures in use: WebcilHeader and WebcilSectionHeader, so it was easier to handle them explicitly.
@lambdageek
Fix infinite recursion
1dbcc53
@lambdageek
rename var
aaf0ca6
@ghostghost
added
the 
area-System.Net

label
Sep 22, 2023
@ghost
ghost
commented
Sep 22, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92274 to release/8.0
/cc @lambdageek@saitama951
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-System.Net
Milestone:-
@lambdageeklambdageek
added

area-Build-mono

Servicing-consider
Issue for next servicing release review
and removed

area-System.Net

labels
Sep 22, 2023
@lambdageeklambdageek
added this to the 8.0.0 milestone
Sep 22, 2023
@lambdageeklambdageek
added
the 
arch-wasm
WebAssembly architecture
label
Sep 22, 2023
@ghost
ghost
commented
Sep 22, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92274 to release/8.0
/cc @lambdageek@saitama951
Customer Impact
Customers using the browser-wasm workload on s390x and other big-endian platforms are able to produce working wasm webcil modules.
Testing
Manual testing
Risk
Low/Medium. There is additional code on non-s390x platforms in the webcil assembly, but it is all gated by an endianness check. In .NET Framework builds of the wasm builder MSBuild task there is a new dependency on the System.Memory.dll out of band assembly - so if we got the version dependencies wrong this may break the build for customers building browser-wasm projects using Visual Studio on Windows.
Author:github-actions[bot]
Assignees:-
Labels:
Servicing-consider, arch-wasm, area-Build-mono
Milestone:8.0.0
@carlossanlop
carlossanlop
commented
Sep 22, 2023

Copy link


Copy Markdown

Contributor
@lambdageek is it intentional to target release/8.0, or were you intending to target release/8.0-rc2?
If the latter, then please edit the PR title and choose the target branch from the dropdown. Just please make sure to confirm that the commits are the ones you want, because sometimes additional unwanted commits get added.
@carlossanlop
carlossanlop
commented
Sep 22, 2023

Copy link


Copy Markdown

Contributor
I don't see an email requesting Tactics approval, and we're close to EOD so this will have to go to runtime/8.0 directly (RTM).
@lambdageek
lambdageek
commented
Sep 25, 2023

Copy link


Copy Markdown

Member
@carlossanlop RTM is ok. I wasn't sure there was runway left for RC2.
@carlossanlop
carlossanlop
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
@lambdageek don't forget to send an email requesting Tactics approval. I can't find one with this PR's title.
@rainersigwald
rainersigwald
commented
Sep 29, 2023

Copy link


Copy Markdown

Member
The System.Memory reference matches the one MSBuild guarantees (and we use ourselves) in supported-for-.NET-8.0 MSBuild/VS versions (17.7+), so I think that risk here is low.
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 29, 2023
@carlossanlop
carlossanlop
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics but needs a code review sign-off from another area owner. @lewing@steveisok@radical? Who can volunteer as tribute?
@carlossanlop
carlossanlop
commented
Oct 3, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
@lambdageek@lewing@steveisok@radical can we get a sign-off please?
@carlossanlop
carlossanlop
merged commit 2e50c1e
into
release/8.0Oct 3, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-92274-to-release/8.0

branch
October 3, 2023 17:28
@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 2, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@radicalradicalradical approved these changes
@steveisoksteveisokAwaiting requested review from steveisok
@lewinglewingAwaiting requested review from lewing
@lambdageeklambdageekAwaiting requested review from lambdageek

Assignees


No one assigned


Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@carlossanlop@lambdageek@rainersigwald@radical@saitama951