Skip to content

[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*#92513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 10 commits into from
Sep 27, 2023
Merged

[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* #92513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ffaa18a
Added OperIsHWIntrinsicSIMDScalar. Do not remove CAST on SIMD scalar …
TIHan Sep 21, 2023
af6d1bf
Minor cleanup
TIHan Sep 21, 2023
8d1d10c
Minor cleanup
TIHan Sep 21, 2023
807810c
Feedback
TIHan Sep 21, 2023
a7e0e93
Added test case
TIHan Sep 21, 2023
ba92e22
Update Runtime_92349.cs
TIHan Sep 21, 2023
83d2d46
Update Runtime_92349.cs
TIHan Sep 22, 2023
6f96aa5
Update Runtime_92349.cs
TIHan Sep 22, 2023
78a2165
Update Runtime_92349.cs
TIHan Sep 22, 2023
11fe3ea
JIT: Fix containment of extract intrinsics as STOREIND sources
jakobbotsch Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/coreclr/jit/lowerxarch.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6504,7 +6504,7 @@ void Lowering::ContainCheckStoreIndir(GenTreeStoreInd* node)
case NI_AVX2_ConvertToUInt32:
{
// These intrinsics are "ins reg/mem, xmm"
isContainable = varTypeIsIntegral(simdBaseType);
isContainable = varTypeIsIntegral(simdBaseType) && (genTypeSize(src) == genTypeSize(node));
break;
}

Expand DownExpand Up@@ -6568,7 +6568,8 @@ void Lowering::ContainCheckStoreIndir(GenTreeStoreInd* node)
size_t numArgs = hwintrinsic->GetOperandCount();
GenTree* lastOp = hwintrinsic->Op(numArgs);

isContainable = HWIntrinsicInfo::isImmOp(intrinsicId, lastOp) && lastOp->IsCnsIntOrI();
isContainable = HWIntrinsicInfo::isImmOp(intrinsicId, lastOp) && lastOp->IsCnsIntOrI() &&
(genTypeSize(simdBaseType) == genTypeSize(node));

if (isContainable && (intrinsicId == NI_SSE2_Extract))
{
Expand Down
29 changes: 29 additions & 0 deletions src/tests/JIT/Regression/JitBlue/Runtime_92349/Runtime_92349.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Runtime.Intrinsics.X86;
using System.Runtime.Intrinsics;
using System.Runtime.CompilerServices;
using System.Threading;
using Xunit;

public static class Runtime_92349
{
[MethodImpl(MethodImplOptions.AggressiveOptimization)]
unsafe static void Test(byte* pValue)
{
*pValue = (byte)Sse2.ConvertToInt32(Vector128.Create(-10, 0, 0, 0));
}

[Fact]
public unsafe static void EntryPoint()
{
if (Sse2.IsSupported)
{
ulong value = 0;
Test((byte*)Unsafe.AsPointer(ref value));
Assert.True(value == 246);
}
}
}
9 changes: 9 additions & 0 deletions src/tests/JIT/Regression/JitBlue/Runtime_92349/Runtime_92349.csproj
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<Optimize>True</Optimize>
<AllowUnsafeBlocks>True</AllowUnsafeBlocks>
</PropertyGroup>
<ItemGroup>
<Compile Include="$(MSBuildProjectName).cs" />
</ItemGroup>
</Project>
63 changes: 63 additions & 0 deletions src/tests/JIT/Regression/JitBlue/Runtime_92590/Runtime_92590.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Runtime.CompilerServices;
using System.Runtime.Intrinsics;
using Xunit;

public class Runtime_92590
{
[Fact]
public static void TestEntryPoint()
{
Span<byte> bytes = stackalloc byte[4];
bytes.Fill(0xff);
TestByteByte(ref bytes[0], 0, Vector256.Create((byte)1));

Assert.True(bytes.SequenceEqual(stackalloc byte[] { 0x2, 0xff, 0xff, 0xff }));

bytes.Fill(0xff);
TestByteInt(ref bytes[0], 0, Vector256.Create(1));

Assert.True(bytes.SequenceEqual(stackalloc byte[] { 0x2, 0xff, 0xff, 0xff }));

int i = int.MaxValue;
TestIntByte(ref i, 0, Vector256.Create((byte)1));

Assert.Equal(2, i);

i = int.MaxValue;
TestIntInt(ref i, 0, Vector256.Create(1));

Assert.Equal(2, i);
}

[MethodImpl(MethodImplOptions.NoInlining)]
private static void TestByteByte(ref byte b, int x, Vector256<byte> vin)
{
Vector256<byte> v = vin + vin;
Unsafe.Add(ref b, x) = v[3];
}

[MethodImpl(MethodImplOptions.NoInlining)]
private static void TestByteInt(ref byte b, int x, Vector256<int> vin)
{
Vector256<int> v = vin + vin;
Unsafe.Add(ref b, x) = (byte)v[3];
}

[MethodImpl(MethodImplOptions.NoInlining)]
private static void TestIntByte(ref int b, int x, Vector256<byte> vin)
{
Vector256<byte> v = vin + vin;
Unsafe.Add(ref b, x) = v[3];
}

[MethodImpl(MethodImplOptions.NoInlining)]
private static void TestIntInt(ref int b, int x, Vector256<int> vin)
{
Vector256<int> v = vin + vin;
Unsafe.Add(ref b, x) = v[3];
}
}
8 changes: 8 additions & 0 deletions src/tests/JIT/Regression/JitBlue/Runtime_92590/Runtime_92590.csproj
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<Optimize>True</Optimize>
</PropertyGroup>
<ItemGroup>
<Compile Include="$(MSBuildProjectName).cs" />
</ItemGroup>
</Project>
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* by github-actions[bot] · Pull Request #92513 · dotnet/runtime · GitHub
Skip to content
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*#92513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

carlossanlop
merged 10 commits into

from

Sep 27, 2023
 Merged


[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*
#92513
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
ffaa18a

Added OperIsHWIntrinsicSIMDScalar. Do not remove CAST on SIMD scalar …


TIHan Sep 21, 2023
af6d1bf

Minor cleanup


TIHan Sep 21, 2023
8d1d10c

Minor cleanup


TIHan Sep 21, 2023
807810c

Feedback


TIHan Sep 21, 2023
a7e0e93

Added test case


TIHan Sep 21, 2023
ba92e22

Update Runtime_92349.cs


TIHan Sep 21, 2023
83d2d46

Update Runtime_92349.cs


TIHan Sep 22, 2023
6f96aa5

Update Runtime_92349.cs


TIHan Sep 22, 2023
78a2165

Update Runtime_92349.cs


TIHan Sep 22, 2023
11fe3ea

JIT: Fix containment of extract intrinsics as STOREIND sources


jakobbotsch Sep 26, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 3 additions & 2 deletions
src/coreclr/jit/lowerxarch.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6504,7 +6504,7 @@ void Lowering::ContainCheckStoreIndir(GenTreeStoreInd* node)
 case NI_AVX2_ConvertToUInt32:
 {
 // These intrinsics are "ins reg/mem, xmm"
 isContainable = varTypeIsIntegral(simdBaseType);
 isContainable = varTypeIsIntegral(simdBaseType) && (genTypeSize(src) == genTypeSize(node));
 break;
 }

Expand DownExpand Up@@ -6568,7 +6568,8 @@ void Lowering::ContainCheckStoreIndir(GenTreeStoreInd* node)
 size_t numArgs = hwintrinsic->GetOperandCount();
 GenTree* lastOp = hwintrinsic->Op(numArgs);

 isContainable = HWIntrinsicInfo::isImmOp(intrinsicId, lastOp) && lastOp->IsCnsIntOrI();
 isContainable = HWIntrinsicInfo::isImmOp(intrinsicId, lastOp) && lastOp->IsCnsIntOrI() &&
 (genTypeSize(simdBaseType) == genTypeSize(node));

 if (isContainable && (intrinsicId == NI_SSE2_Extract))
 {
Expand Down

29 changes: 29 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92349/Runtime_92349.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Runtime.Intrinsics.X86;
using System.Runtime.Intrinsics;
using System.Runtime.CompilerServices;
using System.Threading;
using Xunit;

public static class Runtime_92349
{
 [MethodImpl(MethodImplOptions.AggressiveOptimization)]
 unsafe static void Test(byte* pValue)
 {
 *pValue = (byte)Sse2.ConvertToInt32(Vector128.Create(-10, 0, 0, 0));
 }

 [Fact]
 public unsafe static void EntryPoint()
 {
 if (Sse2.IsSupported)
 {
 ulong value = 0;
 Test((byte*)Unsafe.AsPointer(ref value));
 Assert.True(value == 246);
 }
 }
}

9 changes: 9 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92349/Runtime_92349.csproj

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
<Project Sdk="Microsoft.NET.Sdk">
 <PropertyGroup>
 <Optimize>True</Optimize>
 <AllowUnsafeBlocks>True</AllowUnsafeBlocks>
 </PropertyGroup>
 <ItemGroup>
 <Compile Include="$(MSBuildProjectName).cs" />
 </ItemGroup>
</Project>

63 changes: 63 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92590/Runtime_92590.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Runtime.CompilerServices;
using System.Runtime.Intrinsics;
using Xunit;

public class Runtime_92590
{
 [Fact]
 public static void TestEntryPoint()
 {
 Span<byte> bytes = stackalloc byte[4];
 bytes.Fill(0xff);
 TestByteByte(ref bytes[0], 0, Vector256.Create((byte)1));

 Assert.True(bytes.SequenceEqual(stackalloc byte[] { 0x2, 0xff, 0xff, 0xff }));

 bytes.Fill(0xff);
 TestByteInt(ref bytes[0], 0, Vector256.Create(1));

 Assert.True(bytes.SequenceEqual(stackalloc byte[] { 0x2, 0xff, 0xff, 0xff }));

 int i = int.MaxValue;
 TestIntByte(ref i, 0, Vector256.Create((byte)1));

 Assert.Equal(2, i);

 i = int.MaxValue;
 TestIntInt(ref i, 0, Vector256.Create(1));

 Assert.Equal(2, i);
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestByteByte(ref byte b, int x, Vector256<byte> vin)
 {
 Vector256<byte> v = vin + vin;
 Unsafe.Add(ref b, x) = v[3];
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestByteInt(ref byte b, int x, Vector256<int> vin)
 {
 Vector256<int> v = vin + vin;
 Unsafe.Add(ref b, x) = (byte)v[3];
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestIntByte(ref int b, int x, Vector256<byte> vin)
 {
 Vector256<byte> v = vin + vin;
 Unsafe.Add(ref b, x) = v[3];
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestIntInt(ref int b, int x, Vector256<int> vin)
 {
 Vector256<int> v = vin + vin;
 Unsafe.Add(ref b, x) = v[3];
 }
}

8 changes: 8 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92590/Runtime_92590.csproj

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
 <PropertyGroup>
 <Optimize>True</Optimize>
 </PropertyGroup>
 <ItemGroup>
 <Compile Include="$(MSBuildProjectName).cs" />
 </ItemGroup>
</Project>

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* by github-actions[bot] · Pull Request #92513 · dotnet/runtime · GitHub
Skip to content
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*#92513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

carlossanlop
merged 10 commits into

from

Sep 27, 2023
 Merged


[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*
#92513
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
ffaa18a

Added OperIsHWIntrinsicSIMDScalar. Do not remove CAST on SIMD scalar …


TIHan Sep 21, 2023
af6d1bf

Minor cleanup


TIHan Sep 21, 2023
8d1d10c

Minor cleanup


TIHan Sep 21, 2023
807810c

Feedback


TIHan Sep 21, 2023
a7e0e93

Added test case


TIHan Sep 21, 2023
ba92e22

Update Runtime_92349.cs


TIHan Sep 21, 2023
83d2d46

Update Runtime_92349.cs


TIHan Sep 22, 2023
6f96aa5

Update Runtime_92349.cs


TIHan Sep 22, 2023
78a2165

Update Runtime_92349.cs


TIHan Sep 22, 2023
11fe3ea

JIT: Fix containment of extract intrinsics as STOREIND sources


jakobbotsch Sep 26, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 3 additions & 2 deletions
src/coreclr/jit/lowerxarch.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6504,7 +6504,7 @@ void Lowering::ContainCheckStoreIndir(GenTreeStoreInd* node)
 case NI_AVX2_ConvertToUInt32:
 {
 // These intrinsics are "ins reg/mem, xmm"
 isContainable = varTypeIsIntegral(simdBaseType);
 isContainable = varTypeIsIntegral(simdBaseType) && (genTypeSize(src) == genTypeSize(node));
 break;
 }

Expand DownExpand Up@@ -6568,7 +6568,8 @@ void Lowering::ContainCheckStoreIndir(GenTreeStoreInd* node)
 size_t numArgs = hwintrinsic->GetOperandCount();
 GenTree* lastOp = hwintrinsic->Op(numArgs);

 isContainable = HWIntrinsicInfo::isImmOp(intrinsicId, lastOp) && lastOp->IsCnsIntOrI();
 isContainable = HWIntrinsicInfo::isImmOp(intrinsicId, lastOp) && lastOp->IsCnsIntOrI() &&
 (genTypeSize(simdBaseType) == genTypeSize(node));

 if (isContainable && (intrinsicId == NI_SSE2_Extract))
 {
Expand Down

29 changes: 29 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92349/Runtime_92349.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Runtime.Intrinsics.X86;
using System.Runtime.Intrinsics;
using System.Runtime.CompilerServices;
using System.Threading;
using Xunit;

public static class Runtime_92349
{
 [MethodImpl(MethodImplOptions.AggressiveOptimization)]
 unsafe static void Test(byte* pValue)
 {
 *pValue = (byte)Sse2.ConvertToInt32(Vector128.Create(-10, 0, 0, 0));
 }

 [Fact]
 public unsafe static void EntryPoint()
 {
 if (Sse2.IsSupported)
 {
 ulong value = 0;
 Test((byte*)Unsafe.AsPointer(ref value));
 Assert.True(value == 246);
 }
 }
}

9 changes: 9 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92349/Runtime_92349.csproj

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
<Project Sdk="Microsoft.NET.Sdk">
 <PropertyGroup>
 <Optimize>True</Optimize>
 <AllowUnsafeBlocks>True</AllowUnsafeBlocks>
 </PropertyGroup>
 <ItemGroup>
 <Compile Include="$(MSBuildProjectName).cs" />
 </ItemGroup>
</Project>

63 changes: 63 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92590/Runtime_92590.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Runtime.CompilerServices;
using System.Runtime.Intrinsics;
using Xunit;

public class Runtime_92590
{
 [Fact]
 public static void TestEntryPoint()
 {
 Span<byte> bytes = stackalloc byte[4];
 bytes.Fill(0xff);
 TestByteByte(ref bytes[0], 0, Vector256.Create((byte)1));

 Assert.True(bytes.SequenceEqual(stackalloc byte[] { 0x2, 0xff, 0xff, 0xff }));

 bytes.Fill(0xff);
 TestByteInt(ref bytes[0], 0, Vector256.Create(1));

 Assert.True(bytes.SequenceEqual(stackalloc byte[] { 0x2, 0xff, 0xff, 0xff }));

 int i = int.MaxValue;
 TestIntByte(ref i, 0, Vector256.Create((byte)1));

 Assert.Equal(2, i);

 i = int.MaxValue;
 TestIntInt(ref i, 0, Vector256.Create(1));

 Assert.Equal(2, i);
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestByteByte(ref byte b, int x, Vector256<byte> vin)
 {
 Vector256<byte> v = vin + vin;
 Unsafe.Add(ref b, x) = v[3];
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestByteInt(ref byte b, int x, Vector256<int> vin)
 {
 Vector256<int> v = vin + vin;
 Unsafe.Add(ref b, x) = (byte)v[3];
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestIntByte(ref int b, int x, Vector256<byte> vin)
 {
 Vector256<byte> v = vin + vin;
 Unsafe.Add(ref b, x) = v[3];
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestIntInt(ref int b, int x, Vector256<int> vin)
 {
 Vector256<int> v = vin + vin;
 Unsafe.Add(ref b, x) = v[3];
 }
}

8 changes: 8 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92590/Runtime_92590.csproj

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
 <PropertyGroup>
 <Optimize>True</Optimize>
 </PropertyGroup>
 <ItemGroup>
 <Compile Include="$(MSBuildProjectName).cs" />
 </ItemGroup>
</Project>

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* by github-actions[bot] · Pull Request #92513 · dotnet/runtime · GitHub
Skip to content
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*#92513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

carlossanlop
merged 10 commits into

from

Sep 27, 2023
 Merged


[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*
#92513
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
ffaa18a

Added OperIsHWIntrinsicSIMDScalar. Do not remove CAST on SIMD scalar …


TIHan Sep 21, 2023
af6d1bf

Minor cleanup


TIHan Sep 21, 2023
8d1d10c

Minor cleanup


TIHan Sep 21, 2023
807810c

Feedback


TIHan Sep 21, 2023
a7e0e93

Added test case


TIHan Sep 21, 2023
ba92e22

Update Runtime_92349.cs


TIHan Sep 21, 2023
83d2d46

Update Runtime_92349.cs


TIHan Sep 22, 2023
6f96aa5

Update Runtime_92349.cs


TIHan Sep 22, 2023
78a2165

Update Runtime_92349.cs


TIHan Sep 22, 2023
11fe3ea

JIT: Fix containment of extract intrinsics as STOREIND sources


jakobbotsch Sep 26, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 3 additions & 2 deletions
src/coreclr/jit/lowerxarch.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6504,7 +6504,7 @@ void Lowering::ContainCheckStoreIndir(GenTreeStoreInd* node)
 case NI_AVX2_ConvertToUInt32:
 {
 // These intrinsics are "ins reg/mem, xmm"
 isContainable = varTypeIsIntegral(simdBaseType);
 isContainable = varTypeIsIntegral(simdBaseType) && (genTypeSize(src) == genTypeSize(node));
 break;
 }

Expand DownExpand Up@@ -6568,7 +6568,8 @@ void Lowering::ContainCheckStoreIndir(GenTreeStoreInd* node)
 size_t numArgs = hwintrinsic->GetOperandCount();
 GenTree* lastOp = hwintrinsic->Op(numArgs);

 isContainable = HWIntrinsicInfo::isImmOp(intrinsicId, lastOp) && lastOp->IsCnsIntOrI();
 isContainable = HWIntrinsicInfo::isImmOp(intrinsicId, lastOp) && lastOp->IsCnsIntOrI() &&
 (genTypeSize(simdBaseType) == genTypeSize(node));

 if (isContainable && (intrinsicId == NI_SSE2_Extract))
 {
Expand Down

29 changes: 29 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92349/Runtime_92349.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Runtime.Intrinsics.X86;
using System.Runtime.Intrinsics;
using System.Runtime.CompilerServices;
using System.Threading;
using Xunit;

public static class Runtime_92349
{
 [MethodImpl(MethodImplOptions.AggressiveOptimization)]
 unsafe static void Test(byte* pValue)
 {
 *pValue = (byte)Sse2.ConvertToInt32(Vector128.Create(-10, 0, 0, 0));
 }

 [Fact]
 public unsafe static void EntryPoint()
 {
 if (Sse2.IsSupported)
 {
 ulong value = 0;
 Test((byte*)Unsafe.AsPointer(ref value));
 Assert.True(value == 246);
 }
 }
}

9 changes: 9 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92349/Runtime_92349.csproj

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
<Project Sdk="Microsoft.NET.Sdk">
 <PropertyGroup>
 <Optimize>True</Optimize>
 <AllowUnsafeBlocks>True</AllowUnsafeBlocks>
 </PropertyGroup>
 <ItemGroup>
 <Compile Include="$(MSBuildProjectName).cs" />
 </ItemGroup>
</Project>

63 changes: 63 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92590/Runtime_92590.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Runtime.CompilerServices;
using System.Runtime.Intrinsics;
using Xunit;

public class Runtime_92590
{
 [Fact]
 public static void TestEntryPoint()
 {
 Span<byte> bytes = stackalloc byte[4];
 bytes.Fill(0xff);
 TestByteByte(ref bytes[0], 0, Vector256.Create((byte)1));

 Assert.True(bytes.SequenceEqual(stackalloc byte[] { 0x2, 0xff, 0xff, 0xff }));

 bytes.Fill(0xff);
 TestByteInt(ref bytes[0], 0, Vector256.Create(1));

 Assert.True(bytes.SequenceEqual(stackalloc byte[] { 0x2, 0xff, 0xff, 0xff }));

 int i = int.MaxValue;
 TestIntByte(ref i, 0, Vector256.Create((byte)1));

 Assert.Equal(2, i);

 i = int.MaxValue;
 TestIntInt(ref i, 0, Vector256.Create(1));

 Assert.Equal(2, i);
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestByteByte(ref byte b, int x, Vector256<byte> vin)
 {
 Vector256<byte> v = vin + vin;
 Unsafe.Add(ref b, x) = v[3];
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestByteInt(ref byte b, int x, Vector256<int> vin)
 {
 Vector256<int> v = vin + vin;
 Unsafe.Add(ref b, x) = (byte)v[3];
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestIntByte(ref int b, int x, Vector256<byte> vin)
 {
 Vector256<byte> v = vin + vin;
 Unsafe.Add(ref b, x) = v[3];
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestIntInt(ref int b, int x, Vector256<int> vin)
 {
 Vector256<int> v = vin + vin;
 Unsafe.Add(ref b, x) = v[3];
 }
}

8 changes: 8 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92590/Runtime_92590.csproj

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
 <PropertyGroup>
 <Optimize>True</Optimize>
 </PropertyGroup>
 <ItemGroup>
 <Compile Include="$(MSBuildProjectName).cs" />
 </ItemGroup>
</Project>

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* by github-actions[bot] · Pull Request #92513 · dotnet/runtime · GitHub
Skip to content
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*#92513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

carlossanlop
merged 10 commits into

from

Sep 27, 2023
 Merged


[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*
#92513
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
ffaa18a

Added OperIsHWIntrinsicSIMDScalar. Do not remove CAST on SIMD scalar …


TIHan Sep 21, 2023
af6d1bf

Minor cleanup


TIHan Sep 21, 2023
8d1d10c

Minor cleanup


TIHan Sep 21, 2023
807810c

Feedback


TIHan Sep 21, 2023
a7e0e93

Added test case


TIHan Sep 21, 2023
ba92e22

Update Runtime_92349.cs


TIHan Sep 21, 2023
83d2d46

Update Runtime_92349.cs


TIHan Sep 22, 2023
6f96aa5

Update Runtime_92349.cs


TIHan Sep 22, 2023
78a2165

Update Runtime_92349.cs


TIHan Sep 22, 2023
11fe3ea

JIT: Fix containment of extract intrinsics as STOREIND sources


jakobbotsch Sep 26, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 3 additions & 2 deletions
src/coreclr/jit/lowerxarch.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6504,7 +6504,7 @@ void Lowering::ContainCheckStoreIndir(GenTreeStoreInd* node)
 case NI_AVX2_ConvertToUInt32:
 {
 // These intrinsics are "ins reg/mem, xmm"
 isContainable = varTypeIsIntegral(simdBaseType);
 isContainable = varTypeIsIntegral(simdBaseType) && (genTypeSize(src) == genTypeSize(node));
 break;
 }

Expand DownExpand Up@@ -6568,7 +6568,8 @@ void Lowering::ContainCheckStoreIndir(GenTreeStoreInd* node)
 size_t numArgs = hwintrinsic->GetOperandCount();
 GenTree* lastOp = hwintrinsic->Op(numArgs);

 isContainable = HWIntrinsicInfo::isImmOp(intrinsicId, lastOp) && lastOp->IsCnsIntOrI();
 isContainable = HWIntrinsicInfo::isImmOp(intrinsicId, lastOp) && lastOp->IsCnsIntOrI() &&
 (genTypeSize(simdBaseType) == genTypeSize(node));

 if (isContainable && (intrinsicId == NI_SSE2_Extract))
 {
Expand Down

29 changes: 29 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92349/Runtime_92349.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Runtime.Intrinsics.X86;
using System.Runtime.Intrinsics;
using System.Runtime.CompilerServices;
using System.Threading;
using Xunit;

public static class Runtime_92349
{
 [MethodImpl(MethodImplOptions.AggressiveOptimization)]
 unsafe static void Test(byte* pValue)
 {
 *pValue = (byte)Sse2.ConvertToInt32(Vector128.Create(-10, 0, 0, 0));
 }

 [Fact]
 public unsafe static void EntryPoint()
 {
 if (Sse2.IsSupported)
 {
 ulong value = 0;
 Test((byte*)Unsafe.AsPointer(ref value));
 Assert.True(value == 246);
 }
 }
}

9 changes: 9 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92349/Runtime_92349.csproj

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
<Project Sdk="Microsoft.NET.Sdk">
 <PropertyGroup>
 <Optimize>True</Optimize>
 <AllowUnsafeBlocks>True</AllowUnsafeBlocks>
 </PropertyGroup>
 <ItemGroup>
 <Compile Include="$(MSBuildProjectName).cs" />
 </ItemGroup>
</Project>

63 changes: 63 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92590/Runtime_92590.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Runtime.CompilerServices;
using System.Runtime.Intrinsics;
using Xunit;

public class Runtime_92590
{
 [Fact]
 public static void TestEntryPoint()
 {
 Span<byte> bytes = stackalloc byte[4];
 bytes.Fill(0xff);
 TestByteByte(ref bytes[0], 0, Vector256.Create((byte)1));

 Assert.True(bytes.SequenceEqual(stackalloc byte[] { 0x2, 0xff, 0xff, 0xff }));

 bytes.Fill(0xff);
 TestByteInt(ref bytes[0], 0, Vector256.Create(1));

 Assert.True(bytes.SequenceEqual(stackalloc byte[] { 0x2, 0xff, 0xff, 0xff }));

 int i = int.MaxValue;
 TestIntByte(ref i, 0, Vector256.Create((byte)1));

 Assert.Equal(2, i);

 i = int.MaxValue;
 TestIntInt(ref i, 0, Vector256.Create(1));

 Assert.Equal(2, i);
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestByteByte(ref byte b, int x, Vector256<byte> vin)
 {
 Vector256<byte> v = vin + vin;
 Unsafe.Add(ref b, x) = v[3];
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestByteInt(ref byte b, int x, Vector256<int> vin)
 {
 Vector256<int> v = vin + vin;
 Unsafe.Add(ref b, x) = (byte)v[3];
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestIntByte(ref int b, int x, Vector256<byte> vin)
 {
 Vector256<byte> v = vin + vin;
 Unsafe.Add(ref b, x) = v[3];
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestIntInt(ref int b, int x, Vector256<int> vin)
 {
 Vector256<int> v = vin + vin;
 Unsafe.Add(ref b, x) = v[3];
 }
}

8 changes: 8 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92590/Runtime_92590.csproj

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
 <PropertyGroup>
 <Optimize>True</Optimize>
 </PropertyGroup>
 <ItemGroup>
 <Compile Include="$(MSBuildProjectName).cs" />
 </ItemGroup>
</Project>

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* by github-actions[bot] · Pull Request #92513 · dotnet/runtime · GitHub
Skip to content
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*#92513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

carlossanlop
merged 10 commits into

from

Sep 27, 2023
 Merged


[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*
#92513
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
ffaa18a

Added OperIsHWIntrinsicSIMDScalar. Do not remove CAST on SIMD scalar …


TIHan Sep 21, 2023
af6d1bf

Minor cleanup


TIHan Sep 21, 2023
8d1d10c

Minor cleanup


TIHan Sep 21, 2023
807810c

Feedback


TIHan Sep 21, 2023
a7e0e93

Added test case


TIHan Sep 21, 2023
ba92e22

Update Runtime_92349.cs


TIHan Sep 21, 2023
83d2d46

Update Runtime_92349.cs


TIHan Sep 22, 2023
6f96aa5

Update Runtime_92349.cs


TIHan Sep 22, 2023
78a2165

Update Runtime_92349.cs


TIHan Sep 22, 2023
11fe3ea

JIT: Fix containment of extract intrinsics as STOREIND sources


jakobbotsch Sep 26, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 3 additions & 2 deletions
src/coreclr/jit/lowerxarch.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6504,7 +6504,7 @@ void Lowering::ContainCheckStoreIndir(GenTreeStoreInd* node)
 case NI_AVX2_ConvertToUInt32:
 {
 // These intrinsics are "ins reg/mem, xmm"
 isContainable = varTypeIsIntegral(simdBaseType);
 isContainable = varTypeIsIntegral(simdBaseType) && (genTypeSize(src) == genTypeSize(node));
 break;
 }

Expand DownExpand Up@@ -6568,7 +6568,8 @@ void Lowering::ContainCheckStoreIndir(GenTreeStoreInd* node)
 size_t numArgs = hwintrinsic->GetOperandCount();
 GenTree* lastOp = hwintrinsic->Op(numArgs);

 isContainable = HWIntrinsicInfo::isImmOp(intrinsicId, lastOp) && lastOp->IsCnsIntOrI();
 isContainable = HWIntrinsicInfo::isImmOp(intrinsicId, lastOp) && lastOp->IsCnsIntOrI() &&
 (genTypeSize(simdBaseType) == genTypeSize(node));

 if (isContainable && (intrinsicId == NI_SSE2_Extract))
 {
Expand Down

29 changes: 29 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92349/Runtime_92349.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Runtime.Intrinsics.X86;
using System.Runtime.Intrinsics;
using System.Runtime.CompilerServices;
using System.Threading;
using Xunit;

public static class Runtime_92349
{
 [MethodImpl(MethodImplOptions.AggressiveOptimization)]
 unsafe static void Test(byte* pValue)
 {
 *pValue = (byte)Sse2.ConvertToInt32(Vector128.Create(-10, 0, 0, 0));
 }

 [Fact]
 public unsafe static void EntryPoint()
 {
 if (Sse2.IsSupported)
 {
 ulong value = 0;
 Test((byte*)Unsafe.AsPointer(ref value));
 Assert.True(value == 246);
 }
 }
}

9 changes: 9 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92349/Runtime_92349.csproj

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
<Project Sdk="Microsoft.NET.Sdk">
 <PropertyGroup>
 <Optimize>True</Optimize>
 <AllowUnsafeBlocks>True</AllowUnsafeBlocks>
 </PropertyGroup>
 <ItemGroup>
 <Compile Include="$(MSBuildProjectName).cs" />
 </ItemGroup>
</Project>

63 changes: 63 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92590/Runtime_92590.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Runtime.CompilerServices;
using System.Runtime.Intrinsics;
using Xunit;

public class Runtime_92590
{
 [Fact]
 public static void TestEntryPoint()
 {
 Span<byte> bytes = stackalloc byte[4];
 bytes.Fill(0xff);
 TestByteByte(ref bytes[0], 0, Vector256.Create((byte)1));

 Assert.True(bytes.SequenceEqual(stackalloc byte[] { 0x2, 0xff, 0xff, 0xff }));

 bytes.Fill(0xff);
 TestByteInt(ref bytes[0], 0, Vector256.Create(1));

 Assert.True(bytes.SequenceEqual(stackalloc byte[] { 0x2, 0xff, 0xff, 0xff }));

 int i = int.MaxValue;
 TestIntByte(ref i, 0, Vector256.Create((byte)1));

 Assert.Equal(2, i);

 i = int.MaxValue;
 TestIntInt(ref i, 0, Vector256.Create(1));

 Assert.Equal(2, i);
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestByteByte(ref byte b, int x, Vector256<byte> vin)
 {
 Vector256<byte> v = vin + vin;
 Unsafe.Add(ref b, x) = v[3];
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestByteInt(ref byte b, int x, Vector256<int> vin)
 {
 Vector256<int> v = vin + vin;
 Unsafe.Add(ref b, x) = (byte)v[3];
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestIntByte(ref int b, int x, Vector256<byte> vin)
 {
 Vector256<byte> v = vin + vin;
 Unsafe.Add(ref b, x) = v[3];
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestIntInt(ref int b, int x, Vector256<int> vin)
 {
 Vector256<int> v = vin + vin;
 Unsafe.Add(ref b, x) = v[3];
 }
}

8 changes: 8 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92590/Runtime_92590.csproj

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
 <PropertyGroup>
 <Optimize>True</Optimize>
 </PropertyGroup>
 <ItemGroup>
 <Compile Include="$(MSBuildProjectName).cs" />
 </ItemGroup>
</Project>

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* by github-actions[bot] · Pull Request #92513 · dotnet/runtime · GitHub
Skip to content
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*#92513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

carlossanlop
merged 10 commits into

from

Sep 27, 2023
 Merged


[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*
#92513
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
ffaa18a

Added OperIsHWIntrinsicSIMDScalar. Do not remove CAST on SIMD scalar …


TIHan Sep 21, 2023
af6d1bf

Minor cleanup


TIHan Sep 21, 2023
8d1d10c

Minor cleanup


TIHan Sep 21, 2023
807810c

Feedback


TIHan Sep 21, 2023
a7e0e93

Added test case


TIHan Sep 21, 2023
ba92e22

Update Runtime_92349.cs


TIHan Sep 21, 2023
83d2d46

Update Runtime_92349.cs


TIHan Sep 22, 2023
6f96aa5

Update Runtime_92349.cs


TIHan Sep 22, 2023
78a2165

Update Runtime_92349.cs


TIHan Sep 22, 2023
11fe3ea

JIT: Fix containment of extract intrinsics as STOREIND sources


jakobbotsch Sep 26, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 3 additions & 2 deletions
src/coreclr/jit/lowerxarch.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6504,7 +6504,7 @@ void Lowering::ContainCheckStoreIndir(GenTreeStoreInd* node)
 case NI_AVX2_ConvertToUInt32:
 {
 // These intrinsics are "ins reg/mem, xmm"
 isContainable = varTypeIsIntegral(simdBaseType);
 isContainable = varTypeIsIntegral(simdBaseType) && (genTypeSize(src) == genTypeSize(node));
 break;
 }

Expand DownExpand Up@@ -6568,7 +6568,8 @@ void Lowering::ContainCheckStoreIndir(GenTreeStoreInd* node)
 size_t numArgs = hwintrinsic->GetOperandCount();
 GenTree* lastOp = hwintrinsic->Op(numArgs);

 isContainable = HWIntrinsicInfo::isImmOp(intrinsicId, lastOp) && lastOp->IsCnsIntOrI();
 isContainable = HWIntrinsicInfo::isImmOp(intrinsicId, lastOp) && lastOp->IsCnsIntOrI() &&
 (genTypeSize(simdBaseType) == genTypeSize(node));

 if (isContainable && (intrinsicId == NI_SSE2_Extract))
 {
Expand Down

29 changes: 29 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92349/Runtime_92349.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Runtime.Intrinsics.X86;
using System.Runtime.Intrinsics;
using System.Runtime.CompilerServices;
using System.Threading;
using Xunit;

public static class Runtime_92349
{
 [MethodImpl(MethodImplOptions.AggressiveOptimization)]
 unsafe static void Test(byte* pValue)
 {
 *pValue = (byte)Sse2.ConvertToInt32(Vector128.Create(-10, 0, 0, 0));
 }

 [Fact]
 public unsafe static void EntryPoint()
 {
 if (Sse2.IsSupported)
 {
 ulong value = 0;
 Test((byte*)Unsafe.AsPointer(ref value));
 Assert.True(value == 246);
 }
 }
}

9 changes: 9 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92349/Runtime_92349.csproj

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
<Project Sdk="Microsoft.NET.Sdk">
 <PropertyGroup>
 <Optimize>True</Optimize>
 <AllowUnsafeBlocks>True</AllowUnsafeBlocks>
 </PropertyGroup>
 <ItemGroup>
 <Compile Include="$(MSBuildProjectName).cs" />
 </ItemGroup>
</Project>

63 changes: 63 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92590/Runtime_92590.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Runtime.CompilerServices;
using System.Runtime.Intrinsics;
using Xunit;

public class Runtime_92590
{
 [Fact]
 public static void TestEntryPoint()
 {
 Span<byte> bytes = stackalloc byte[4];
 bytes.Fill(0xff);
 TestByteByte(ref bytes[0], 0, Vector256.Create((byte)1));

 Assert.True(bytes.SequenceEqual(stackalloc byte[] { 0x2, 0xff, 0xff, 0xff }));

 bytes.Fill(0xff);
 TestByteInt(ref bytes[0], 0, Vector256.Create(1));

 Assert.True(bytes.SequenceEqual(stackalloc byte[] { 0x2, 0xff, 0xff, 0xff }));

 int i = int.MaxValue;
 TestIntByte(ref i, 0, Vector256.Create((byte)1));

 Assert.Equal(2, i);

 i = int.MaxValue;
 TestIntInt(ref i, 0, Vector256.Create(1));

 Assert.Equal(2, i);
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestByteByte(ref byte b, int x, Vector256<byte> vin)
 {
 Vector256<byte> v = vin + vin;
 Unsafe.Add(ref b, x) = v[3];
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestByteInt(ref byte b, int x, Vector256<int> vin)
 {
 Vector256<int> v = vin + vin;
 Unsafe.Add(ref b, x) = (byte)v[3];
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestIntByte(ref int b, int x, Vector256<byte> vin)
 {
 Vector256<byte> v = vin + vin;
 Unsafe.Add(ref b, x) = v[3];
 }

 [MethodImpl(MethodImplOptions.NoInlining)]
 private static void TestIntInt(ref int b, int x, Vector256<int> vin)
 {
 Vector256<int> v = vin + vin;
 Unsafe.Add(ref b, x) = v[3];
 }
}

8 changes: 8 additions & 0 deletions
src/tests/JIT/Regression/JitBlue/Runtime_92590/Runtime_92590.csproj

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
 <PropertyGroup>
 <Optimize>True</Optimize>
 </PropertyGroup>
 <ItemGroup>
 <Compile Include="$(MSBuildProjectName).cs" />
 </ItemGroup>
</Project>