Skip to content

[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* - #92513

Merged
carlossanlop merged 10 commits into
release/8.0from
backport/pr-92396-to-release/8.0
Sep 27, 2023
Merged

[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*#92513
carlossanlop merged 10 commits into
release/8.0from
backport/pr-92396-to-release/8.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Sep 23, 2023•
edited by jakobbotsch
Loading

Copy link
Copy Markdown
Contributor

Backport of #92396 to release/8.0

/cc @TIHan

Customer Impact

The customer has a custom-built software rasterizer and is using SSE2 hw-intrinsics to improve performance. In .NET 8, they were getting incorrect results compared to .NET 7 when using the Sse2.ConvertToInt32 API.

Specifically, when storing the result of Sse2.ConvertToInt32 or vector indexing in memory, the JIT would in certain cases store either too many bytes or too few bytes when applying its containment optimization. The fix is to ensure the proper sizes and otherwise give up on containment.

.NET 7 (correct)
image

.NET 8 (incorrect)
image

This change will fix that.

Original issues: #92349, #92590

Testing

Added regression tests of the hw-intrinsics Sse2.ConvertToInt32 and Extract to ensure that this will not happen again.

Risk

Very low risk. Only two lines were changed and will not regress performance.

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 23, 2023
@ghost

ghost commented Sep 23, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92396 to release/8.0

/cc @TIHan

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@TIHan

TIHan commented Sep 23, 2023

Copy link
Copy Markdown
Contributor

cc @jeffschwMSFT@JulieLeeMSFT

This was referenced Sep 23, 2023
Closed
Open
jeffschwMSFT
jeffschwMSFT approved these changes Sep 25, 2023
View reviewed changes

@jeffschwMSFTjeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 8.0.x

@jeffschwMSFTjeffschwMSFT added the Servicing-consider Issue for next servicing release review label Sep 25, 2023
@jeffschwMSFTjeffschwMSFT added this to the 8.0.0 milestone Sep 25, 2023
@jakobbotschjakobbotsch changed the title [release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*Sep 26, 2023
@carlossanlopcarlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 27, 2023
@carlossanlop

carlossanlop commented Sep 27, 2023

Copy link
Copy Markdown
Contributor

Approved by Tactics via email.

@carlossanlop
carlossanlop merged commit 8c68206 into release/8.0Sep 27, 2023
@carlossanlop
carlossanlop deleted the backport/pr-92396-to-release/8.0 branch September 27, 2023 10:13
@radicalradical mentioned this pull request Oct 3, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeffschwMSFTjeffschwMSFTjeffschwMSFT approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIServicing-approvedApproved for servicing release

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@TIHan@carlossanlop@jeffschwMSFT@jakobbotsch
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* by github-actions[bot] · Pull Request #92513 · dotnet/runtime · GitHub
Skip to content
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* - #92513
Merged
carlossanlop merged 10 commits into
release/8.0from 
backport/pr-92396-to-release/8.0
Sep 27, 2023
Merged
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*#92513
carlossanlop merged 10 commits into
release/8.0from 
backport/pr-92396-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 23, 2023•

edited by jakobbotsch

Loading

Copy link


Copy Markdown

Contributor
Backport of #92396 to release/8.0
/cc @TIHan
Customer Impact
The customer has a custom-built software rasterizer and is using SSE2 hw-intrinsics to improve performance. In .NET 8, they were getting incorrect results compared to .NET 7 when using the Sse2.ConvertToInt32 API.
Specifically, when storing the result of Sse2.ConvertToInt32 or vector indexing in memory, the JIT would in certain cases store either too many bytes or too few bytes when applying its containment optimization. The fix is to ensure the proper sizes and otherwise give up on containment.
.NET 7 (correct)
image
.NET 8 (incorrect)
image
This change will fix that.
Original issues: #92349, #92590
Testing
Added regression tests of the hw-intrinsics Sse2.ConvertToInt32 and Extract to ensure that this will not happen again.
Risk
Very low risk. Only two lines were changed and will not regress performance.
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 23, 2023
@ghost
ghost
commented
Sep 23, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92396 to release/8.0
/cc @TIHan
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@TIHan
TIHan
commented
Sep 23, 2023

Copy link


Copy Markdown

Contributor
cc @jeffschwMSFT@JulieLeeMSFT

This was referenced Sep 23, 2023

Closed


Open

jeffschwMSFT
jeffschwMSFT
approved these changes
Sep 25, 2023
View reviewed changes
@jeffschwMSFTjeffschwMSFT
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 8.0.x
@jeffschwMSFTjeffschwMSFT
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 25, 2023
@jeffschwMSFTjeffschwMSFT
added this to the 8.0.0 milestone
Sep 25, 2023
@jakobbotschjakobbotsch
changed the title
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*Sep 26, 2023
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 27, 2023
@carlossanlop
carlossanlop
commented
Sep 27, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics via email.
@carlossanlop
carlossanlop
merged commit 8c68206
into
release/8.0Sep 27, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-92396-to-release/8.0

branch
September 27, 2023 10:13
@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 27, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jeffschwMSFTjeffschwMSFTjeffschwMSFT approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@TIHan@carlossanlop@jeffschwMSFT@jakobbotsch

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* by github-actions[bot] · Pull Request #92513 · dotnet/runtime · GitHub
Skip to content
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* - #92513
Merged
carlossanlop merged 10 commits into
release/8.0from 
backport/pr-92396-to-release/8.0
Sep 27, 2023
Merged
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*#92513
carlossanlop merged 10 commits into
release/8.0from 
backport/pr-92396-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 23, 2023•

edited by jakobbotsch

Loading

Copy link


Copy Markdown

Contributor
Backport of #92396 to release/8.0
/cc @TIHan
Customer Impact
The customer has a custom-built software rasterizer and is using SSE2 hw-intrinsics to improve performance. In .NET 8, they were getting incorrect results compared to .NET 7 when using the Sse2.ConvertToInt32 API.
Specifically, when storing the result of Sse2.ConvertToInt32 or vector indexing in memory, the JIT would in certain cases store either too many bytes or too few bytes when applying its containment optimization. The fix is to ensure the proper sizes and otherwise give up on containment.
.NET 7 (correct)
image
.NET 8 (incorrect)
image
This change will fix that.
Original issues: #92349, #92590
Testing
Added regression tests of the hw-intrinsics Sse2.ConvertToInt32 and Extract to ensure that this will not happen again.
Risk
Very low risk. Only two lines were changed and will not regress performance.
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 23, 2023
@ghost
ghost
commented
Sep 23, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92396 to release/8.0
/cc @TIHan
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@TIHan
TIHan
commented
Sep 23, 2023

Copy link


Copy Markdown

Contributor
cc @jeffschwMSFT@JulieLeeMSFT

This was referenced Sep 23, 2023

Closed


Open

jeffschwMSFT
jeffschwMSFT
approved these changes
Sep 25, 2023
View reviewed changes
@jeffschwMSFTjeffschwMSFT
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 8.0.x
@jeffschwMSFTjeffschwMSFT
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 25, 2023
@jeffschwMSFTjeffschwMSFT
added this to the 8.0.0 milestone
Sep 25, 2023
@jakobbotschjakobbotsch
changed the title
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*Sep 26, 2023
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 27, 2023
@carlossanlop
carlossanlop
commented
Sep 27, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics via email.
@carlossanlop
carlossanlop
merged commit 8c68206
into
release/8.0Sep 27, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-92396-to-release/8.0

branch
September 27, 2023 10:13
@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 27, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jeffschwMSFTjeffschwMSFTjeffschwMSFT approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@TIHan@carlossanlop@jeffschwMSFT@jakobbotsch

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* by github-actions[bot] · Pull Request #92513 · dotnet/runtime · GitHub
Skip to content
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* - #92513
Merged
carlossanlop merged 10 commits into
release/8.0from 
backport/pr-92396-to-release/8.0
Sep 27, 2023
Merged
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*#92513
carlossanlop merged 10 commits into
release/8.0from 
backport/pr-92396-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 23, 2023•

edited by jakobbotsch

Loading

Copy link


Copy Markdown

Contributor
Backport of #92396 to release/8.0
/cc @TIHan
Customer Impact
The customer has a custom-built software rasterizer and is using SSE2 hw-intrinsics to improve performance. In .NET 8, they were getting incorrect results compared to .NET 7 when using the Sse2.ConvertToInt32 API.
Specifically, when storing the result of Sse2.ConvertToInt32 or vector indexing in memory, the JIT would in certain cases store either too many bytes or too few bytes when applying its containment optimization. The fix is to ensure the proper sizes and otherwise give up on containment.
.NET 7 (correct)
image
.NET 8 (incorrect)
image
This change will fix that.
Original issues: #92349, #92590
Testing
Added regression tests of the hw-intrinsics Sse2.ConvertToInt32 and Extract to ensure that this will not happen again.
Risk
Very low risk. Only two lines were changed and will not regress performance.
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 23, 2023
@ghost
ghost
commented
Sep 23, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92396 to release/8.0
/cc @TIHan
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@TIHan
TIHan
commented
Sep 23, 2023

Copy link


Copy Markdown

Contributor
cc @jeffschwMSFT@JulieLeeMSFT

This was referenced Sep 23, 2023

Closed


Open

jeffschwMSFT
jeffschwMSFT
approved these changes
Sep 25, 2023
View reviewed changes
@jeffschwMSFTjeffschwMSFT
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 8.0.x
@jeffschwMSFTjeffschwMSFT
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 25, 2023
@jeffschwMSFTjeffschwMSFT
added this to the 8.0.0 milestone
Sep 25, 2023
@jakobbotschjakobbotsch
changed the title
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*Sep 26, 2023
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 27, 2023
@carlossanlop
carlossanlop
commented
Sep 27, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics via email.
@carlossanlop
carlossanlop
merged commit 8c68206
into
release/8.0Sep 27, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-92396-to-release/8.0

branch
September 27, 2023 10:13
@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 27, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jeffschwMSFTjeffschwMSFTjeffschwMSFT approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@TIHan@carlossanlop@jeffschwMSFT@jakobbotsch

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* by github-actions[bot] · Pull Request #92513 · dotnet/runtime · GitHub
Skip to content
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* - #92513
Merged
carlossanlop merged 10 commits into
release/8.0from 
backport/pr-92396-to-release/8.0
Sep 27, 2023
Merged
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*#92513
carlossanlop merged 10 commits into
release/8.0from 
backport/pr-92396-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 23, 2023•

edited by jakobbotsch

Loading

Copy link


Copy Markdown

Contributor
Backport of #92396 to release/8.0
/cc @TIHan
Customer Impact
The customer has a custom-built software rasterizer and is using SSE2 hw-intrinsics to improve performance. In .NET 8, they were getting incorrect results compared to .NET 7 when using the Sse2.ConvertToInt32 API.
Specifically, when storing the result of Sse2.ConvertToInt32 or vector indexing in memory, the JIT would in certain cases store either too many bytes or too few bytes when applying its containment optimization. The fix is to ensure the proper sizes and otherwise give up on containment.
.NET 7 (correct)
image
.NET 8 (incorrect)
image
This change will fix that.
Original issues: #92349, #92590
Testing
Added regression tests of the hw-intrinsics Sse2.ConvertToInt32 and Extract to ensure that this will not happen again.
Risk
Very low risk. Only two lines were changed and will not regress performance.
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 23, 2023
@ghost
ghost
commented
Sep 23, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92396 to release/8.0
/cc @TIHan
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@TIHan
TIHan
commented
Sep 23, 2023

Copy link


Copy Markdown

Contributor
cc @jeffschwMSFT@JulieLeeMSFT

This was referenced Sep 23, 2023

Closed


Open

jeffschwMSFT
jeffschwMSFT
approved these changes
Sep 25, 2023
View reviewed changes
@jeffschwMSFTjeffschwMSFT
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 8.0.x
@jeffschwMSFTjeffschwMSFT
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 25, 2023
@jeffschwMSFTjeffschwMSFT
added this to the 8.0.0 milestone
Sep 25, 2023
@jakobbotschjakobbotsch
changed the title
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*Sep 26, 2023
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 27, 2023
@carlossanlop
carlossanlop
commented
Sep 27, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics via email.
@carlossanlop
carlossanlop
merged commit 8c68206
into
release/8.0Sep 27, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-92396-to-release/8.0

branch
September 27, 2023 10:13
@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 27, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jeffschwMSFTjeffschwMSFTjeffschwMSFT approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@TIHan@carlossanlop@jeffschwMSFT@jakobbotsch

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* by github-actions[bot] · Pull Request #92513 · dotnet/runtime · GitHub
Skip to content
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* - #92513
Merged
carlossanlop merged 10 commits into
release/8.0from 
backport/pr-92396-to-release/8.0
Sep 27, 2023
Merged
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*#92513
carlossanlop merged 10 commits into
release/8.0from 
backport/pr-92396-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 23, 2023•

edited by jakobbotsch

Loading

Copy link


Copy Markdown

Contributor
Backport of #92396 to release/8.0
/cc @TIHan
Customer Impact
The customer has a custom-built software rasterizer and is using SSE2 hw-intrinsics to improve performance. In .NET 8, they were getting incorrect results compared to .NET 7 when using the Sse2.ConvertToInt32 API.
Specifically, when storing the result of Sse2.ConvertToInt32 or vector indexing in memory, the JIT would in certain cases store either too many bytes or too few bytes when applying its containment optimization. The fix is to ensure the proper sizes and otherwise give up on containment.
.NET 7 (correct)
image
.NET 8 (incorrect)
image
This change will fix that.
Original issues: #92349, #92590
Testing
Added regression tests of the hw-intrinsics Sse2.ConvertToInt32 and Extract to ensure that this will not happen again.
Risk
Very low risk. Only two lines were changed and will not regress performance.
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 23, 2023
@ghost
ghost
commented
Sep 23, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92396 to release/8.0
/cc @TIHan
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@TIHan
TIHan
commented
Sep 23, 2023

Copy link


Copy Markdown

Contributor
cc @jeffschwMSFT@JulieLeeMSFT

This was referenced Sep 23, 2023

Closed


Open

jeffschwMSFT
jeffschwMSFT
approved these changes
Sep 25, 2023
View reviewed changes
@jeffschwMSFTjeffschwMSFT
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 8.0.x
@jeffschwMSFTjeffschwMSFT
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 25, 2023
@jeffschwMSFTjeffschwMSFT
added this to the 8.0.0 milestone
Sep 25, 2023
@jakobbotschjakobbotsch
changed the title
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*Sep 26, 2023
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 27, 2023
@carlossanlop
carlossanlop
commented
Sep 27, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics via email.
@carlossanlop
carlossanlop
merged commit 8c68206
into
release/8.0Sep 27, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-92396-to-release/8.0

branch
September 27, 2023 10:13
@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 27, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jeffschwMSFTjeffschwMSFTjeffschwMSFT approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@TIHan@carlossanlop@jeffschwMSFT@jakobbotsch

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* by github-actions[bot] · Pull Request #92513 · dotnet/runtime · GitHub
Skip to content
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* - #92513
Merged
carlossanlop merged 10 commits into
release/8.0from 
backport/pr-92396-to-release/8.0
Sep 27, 2023
Merged
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*#92513
carlossanlop merged 10 commits into
release/8.0from 
backport/pr-92396-to-release/8.0
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 23, 2023•

edited by jakobbotsch

Loading

Copy link


Copy Markdown

Contributor
Backport of #92396 to release/8.0
/cc @TIHan
Customer Impact
The customer has a custom-built software rasterizer and is using SSE2 hw-intrinsics to improve performance. In .NET 8, they were getting incorrect results compared to .NET 7 when using the Sse2.ConvertToInt32 API.
Specifically, when storing the result of Sse2.ConvertToInt32 or vector indexing in memory, the JIT would in certain cases store either too many bytes or too few bytes when applying its containment optimization. The fix is to ensure the proper sizes and otherwise give up on containment.
.NET 7 (correct)
image
.NET 8 (incorrect)
image
This change will fix that.
Original issues: #92349, #92590
Testing
Added regression tests of the hw-intrinsics Sse2.ConvertToInt32 and Extract to ensure that this will not happen again.
Risk
Very low risk. Only two lines were changed and will not regress performance.
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 23, 2023
@ghost
ghost
commented
Sep 23, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #92396 to release/8.0
/cc @TIHan
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Author:github-actions[bot]
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@TIHan
TIHan
commented
Sep 23, 2023

Copy link


Copy Markdown

Contributor
cc @jeffschwMSFT@JulieLeeMSFT

This was referenced Sep 23, 2023

Closed


Open

jeffschwMSFT
jeffschwMSFT
approved these changes
Sep 25, 2023
View reviewed changes
@jeffschwMSFTjeffschwMSFT
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 8.0.x
@jeffschwMSFTjeffschwMSFT
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 25, 2023
@jeffschwMSFTjeffschwMSFT
added this to the 8.0.0 milestone
Sep 25, 2023
@jakobbotschjakobbotsch
changed the title
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract*Sep 26, 2023
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 27, 2023
@carlossanlop
carlossanlop
commented
Sep 27, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics via email.
@carlossanlop
carlossanlop
merged commit 8c68206
into
release/8.0Sep 27, 2023
@carlossanlop
carlossanlop
deleted the

backport/pr-92396-to-release/8.0

branch
September 27, 2023 10:13
@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 27, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jeffschwMSFTjeffschwMSFTjeffschwMSFT approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@TIHan@carlossanlop@jeffschwMSFT@jakobbotsch