[release/8.0][wasm] Fix regressed file sizes for blazor - #92627

Merged
carlossanlop merged 4 commits into
dotnet:release/8.0from
radical:wasm-symbols-8
Sep 27, 2023
Merged

[release/8.0][wasm] Fix regressed file sizes for blazor#92627
carlossanlop merged 4 commits into
dotnet:release/8.0from
radical:wasm-symbols-8

Conversation

@radical

@radicalradical commented Sep 26, 2023•
edited
Loading

Copy link
Copy Markdown
Member

[wasm] build: Revert to older behavior for WasmNativeStrip

The earlier change was done in 26ae097,
which changed to pass -g to the link step also. But that resulted in
increased native file sizes.

Changed sizes for the minimum blazor template - publish scenario:

---run from rc2 HEAD (KiB)With the change (KiB)% change
SOD - Minimum Blazor Template - Publish79187705-2.69
Total Uncompressed _framework42544104-3.53
Aggregate - .js540437-19.07
Aggregate - .wasm37113663-1.29
pub/wwwroot/_framework/dotnet.js35350.00
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js234131-44.02
pub/wwwroot/_framework/dotnet.native.wasm11701122-4.10
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js2162170.46

Customer impact

Improved download size for the blazor app.

Testing

Sizes confirmed with a dotnet-runtime-perf run for blazor_scenarios. Correctness verified by unit tests.

Risk

Low. This is reverting to older behavior to change the symbols being included in the output.

Details

  • [wasm] Add getters for __indirect_function_table, and wasmMemory
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect

Issue: dotnet/perf-autofiling-issues#20642

@radical
[wasm] Add getters for __indirect_function_table, and wasmMemory
5eefacf
.. so that can work even if they get renamed during minimization.
@radical
[wasm] build: Revert to older behavior for WasmNativeStrip
ae93e81
The earlier change was done in 678fd6a,
which changed to pass `-g` to the link step also. But that resulted in
increased native file sizes.
Changed sizes for the `minimum blazor template - publish` scenario:
```
| Last rc1 run | With the change
----------------------------------------------------------|----------------- |------------------
SOD - Minimum Blazor Template - Publish |8590723.000 bytes |7889806.000 bytes
Total Uncompressed _framework |4304274.000 bytes |4202273.000 bytes
pub/wwwroot/_framework/dotnet.js |35722.000 bytes |35838.000 bytes
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js |239307.000 bytes |134566.000 bytes
pub/wwwroot/_framework/dotnet.native.wasm |1174394.000 bytes |1148841.000 bytes
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js |221356.000 bytes |221712.000 bytes
```
@radical
[wasm] cleanup corresponding tests
0207d60
@radical
[wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
91379dd
@radicalradical added the arch-wasm WebAssembly architecture label Sep 26, 2023
@ghostghost added the area-Build-mono label Sep 26, 2023
@ghostghost assigned radicalSep 26, 2023
@radicalradical changed the title wasm symbols 8[release/8.0][wasm] Fix regressed file sizes for blazorSep 26, 2023
@ghost

ghost commented Sep 26, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • [wasm] Add getters for __indirect_function_table, and wasmMemory
  • [wasm] build: Revert to older behavior for WasmNativeStrip
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Author:radical
Assignees:-
Labels:

arch-wasm

Milestone:-

@radical

radical commented Sep 26, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Sep 26, 2023

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@radical
radical requested a review from marafSeptember 26, 2023 07:51
@pavelsavara

pavelsavara commented Sep 26, 2023•
edited
Loading

Copy link
Copy Markdown
Member

pub/wwwroot/_framework/dotnet.js 35722.000 bytes 35838.000 bytes

This is size change bit suspicious, because your changes should have no way how to influence that.
Most likely it means you are not comparing the same base commit. Do the other size changes have the same problem ?

Edit: oh, your table heading actually said rc1

@radical

radical commented Sep 26, 2023

Copy link
Copy Markdown
MemberAuthor

pub/wwwroot/_framework/dotnet.js 35722.000 bytes 35838.000 bytes

This is size change bit suspicious, because your changes should have no way how to influence that. Most likely it means you are not comparing the same base commit. Do the other size changes have the same problem ?

Yeah, it's not comparing exactly the same base commit, because we don't have any runs for 8.0 or 8.0-rc2 branches, so I have to compare against the last run that we have from rc1.

Essentially, the difference is that we don't pass -g to link step now.

@radical

radical commented Sep 26, 2023

Copy link
Copy Markdown
MemberAuthor

I can do a manual run on the current HEAD, and then we could compare.

@radical

radical commented Sep 26, 2023

Copy link
Copy Markdown
MemberAuthor

@pavelsavara@lewing I have updated the results.

@radicalradical added the Servicing-consider Issue for next servicing release review label Sep 26, 2023
@radical

radical commented Sep 26, 2023

Copy link
Copy Markdown
MemberAuthor

@pavelsavara good catch, I fixed the percentages now.

@radicalradical added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 27, 2023
@radical

radical commented Sep 27, 2023

Copy link
Copy Markdown
MemberAuthor

@carlossanlop this is ready for merge.

@carlossanlop
carlossanlop merged commit 0933e30 into dotnet:release/8.0Sep 27, 2023
@radical
radical deleted the wasm-symbols-8 branch September 27, 2023 03:37
@radicalradical mentioned this pull request Oct 3, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewinglewinglewing approved these changes
@pavelsavarapavelsavarapavelsavara approved these changes
@kgkgAwaiting requested review from kg
@marafmarafAwaiting requested review from maraf

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@radical@pavelsavara@lewing@carlossanlop
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[release/8.0][wasm] Fix regressed file sizes for blazor - #92627
Merged
carlossanlop merged 4 commits into
dotnet:release/8.0from 
radical:wasm-symbols-8
Sep 27, 2023
Merged
[release/8.0][wasm] Fix regressed file sizes for blazor#92627
carlossanlop merged 4 commits into
dotnet:release/8.0from 
radical:wasm-symbols-8
Conversation
@radical
@radicalradical
commented
Sep 26, 2023•

edited

Loading

Copy link


Copy Markdown

Member
[wasm] build: Revert to older behavior for WasmNativeStrip
The earlier change was done in 26ae097,

which changed to pass -g to the link step also. But that resulted in

increased native file sizes.
Changed sizes for the minimum blazor template - publish scenario:
---run from rc2 HEAD (KiB)With the change (KiB)% change
SOD - Minimum Blazor Template - Publish79187705-2.69
Total Uncompressed _framework42544104-3.53
Aggregate - .js540437-19.07
Aggregate - .wasm37113663-1.29
pub/wwwroot/_framework/dotnet.js35350.00
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js234131-44.02
pub/wwwroot/_framework/dotnet.native.wasm11701122-4.10
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js2162170.46
Customer impact
Improved download size for the blazor app.
Testing
Sizes confirmed with a dotnet-runtime-perf run for blazor_scenarios. Correctness verified by unit tests.
Risk
Low. This is reverting to older behavior to change the symbols being included in the output.
Details
  • [wasm] Add getters for __indirect_function_table, and wasmMemory
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Issue: dotnet/perf-autofiling-issues#20642
@radical
[wasm] Add getters for __indirect_function_table, and wasmMemory
5eefacf
.. so that can work even if they get renamed during minimization.
@radical
[wasm] build: Revert to older behavior for WasmNativeStrip
ae93e81
The earlier change was done in 678fd6a,
which changed to pass `-g` to the link step also. But that resulted in
increased native file sizes.
Changed sizes for the `minimum blazor template - publish` scenario:
```
| Last rc1 run | With the change
----------------------------------------------------------|----------------- |------------------
SOD - Minimum Blazor Template - Publish |8590723.000 bytes |7889806.000 bytes
Total Uncompressed _framework |4304274.000 bytes |4202273.000 bytes
pub/wwwroot/_framework/dotnet.js |35722.000 bytes |35838.000 bytes
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js |239307.000 bytes |134566.000 bytes
pub/wwwroot/_framework/dotnet.native.wasm |1174394.000 bytes |1148841.000 bytes
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js |221356.000 bytes |221712.000 bytes
```
@radical
[wasm] cleanup corresponding tests
0207d60
@radical
[wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
91379dd
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Sep 26, 2023
@ghostghost
added
the 
area-Build-mono

label
Sep 26, 2023
@ghostghost
assigned radicalSep 26, 2023
@radicalradical
changed the title
wasm symbols 8[release/8.0][wasm] Fix regressed file sizes for blazorSep 26, 2023
@ghost
ghost
commented
Sep 26, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • [wasm] Add getters for __indirect_function_table, and wasmMemory
  • [wasm] build: Revert to older behavior for WasmNativeStrip
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@radical
radical
requested a review
from marafSeptember 26, 2023 07:51
@pavelsavara
pavelsavara
commented
Sep 26, 2023•

edited

Loading

Copy link


Copy Markdown

Member
pub/wwwroot/_framework/dotnet.js 35722.000 bytes 35838.000 bytes
This is size change bit suspicious, because your changes should have no way how to influence that.

Most likely it means you are not comparing the same base commit. Do the other size changes have the same problem ?
Edit: oh, your table heading actually said rc1
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
pub/wwwroot/_framework/dotnet.js 35722.000 bytes 35838.000 bytes
This is size change bit suspicious, because your changes should have no way how to influence that. Most likely it means you are not comparing the same base commit. Do the other size changes have the same problem ?
Yeah, it's not comparing exactly the same base commit, because we don't have any runs for 8.0 or 8.0-rc2 branches, so I have to compare against the last run that we have from rc1.
Essentially, the difference is that we don't pass -g to link step now.
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
I can do a manual run on the current HEAD, and then we could compare.
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
@pavelsavara@lewing I have updated the results.
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 26, 2023
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
@pavelsavara good catch, I fixed the percentages now.
@radicalradical
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 27, 2023
@radical
radical
commented
Sep 27, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop this is ready for merge.
@carlossanlop
carlossanlop
merged commit 0933e30
into
dotnet:release/8.0Sep 27, 2023
@radical
radical
deleted the

wasm-symbols-8

branch
September 27, 2023 03:37
@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 27, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes
@pavelsavarapavelsavarapavelsavara approved these changes
@kgkgAwaiting requested review from kg
@marafmarafAwaiting requested review from maraf

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@pavelsavara@lewing@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/8.0][wasm] Fix regressed file sizes for blazor - #92627
Merged
carlossanlop merged 4 commits into
dotnet:release/8.0from 
radical:wasm-symbols-8
Sep 27, 2023
Merged
[release/8.0][wasm] Fix regressed file sizes for blazor#92627
carlossanlop merged 4 commits into
dotnet:release/8.0from 
radical:wasm-symbols-8
Conversation
@radical
@radicalradical
commented
Sep 26, 2023•

edited

Loading

Copy link


Copy Markdown

Member
[wasm] build: Revert to older behavior for WasmNativeStrip
The earlier change was done in 26ae097,

which changed to pass -g to the link step also. But that resulted in

increased native file sizes.
Changed sizes for the minimum blazor template - publish scenario:
---run from rc2 HEAD (KiB)With the change (KiB)% change
SOD - Minimum Blazor Template - Publish79187705-2.69
Total Uncompressed _framework42544104-3.53
Aggregate - .js540437-19.07
Aggregate - .wasm37113663-1.29
pub/wwwroot/_framework/dotnet.js35350.00
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js234131-44.02
pub/wwwroot/_framework/dotnet.native.wasm11701122-4.10
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js2162170.46
Customer impact
Improved download size for the blazor app.
Testing
Sizes confirmed with a dotnet-runtime-perf run for blazor_scenarios. Correctness verified by unit tests.
Risk
Low. This is reverting to older behavior to change the symbols being included in the output.
Details
  • [wasm] Add getters for __indirect_function_table, and wasmMemory
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Issue: dotnet/perf-autofiling-issues#20642
@radical
[wasm] Add getters for __indirect_function_table, and wasmMemory
5eefacf
.. so that can work even if they get renamed during minimization.
@radical
[wasm] build: Revert to older behavior for WasmNativeStrip
ae93e81
The earlier change was done in 678fd6a,
which changed to pass `-g` to the link step also. But that resulted in
increased native file sizes.
Changed sizes for the `minimum blazor template - publish` scenario:
```
| Last rc1 run | With the change
----------------------------------------------------------|----------------- |------------------
SOD - Minimum Blazor Template - Publish |8590723.000 bytes |7889806.000 bytes
Total Uncompressed _framework |4304274.000 bytes |4202273.000 bytes
pub/wwwroot/_framework/dotnet.js |35722.000 bytes |35838.000 bytes
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js |239307.000 bytes |134566.000 bytes
pub/wwwroot/_framework/dotnet.native.wasm |1174394.000 bytes |1148841.000 bytes
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js |221356.000 bytes |221712.000 bytes
```
@radical
[wasm] cleanup corresponding tests
0207d60
@radical
[wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
91379dd
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Sep 26, 2023
@ghostghost
added
the 
area-Build-mono

label
Sep 26, 2023
@ghostghost
assigned radicalSep 26, 2023
@radicalradical
changed the title
wasm symbols 8[release/8.0][wasm] Fix regressed file sizes for blazorSep 26, 2023
@ghost
ghost
commented
Sep 26, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • [wasm] Add getters for __indirect_function_table, and wasmMemory
  • [wasm] build: Revert to older behavior for WasmNativeStrip
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@radical
radical
requested a review
from marafSeptember 26, 2023 07:51
@pavelsavara
pavelsavara
commented
Sep 26, 2023•

edited

Loading

Copy link


Copy Markdown

Member
pub/wwwroot/_framework/dotnet.js 35722.000 bytes 35838.000 bytes
This is size change bit suspicious, because your changes should have no way how to influence that.

Most likely it means you are not comparing the same base commit. Do the other size changes have the same problem ?
Edit: oh, your table heading actually said rc1
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
pub/wwwroot/_framework/dotnet.js 35722.000 bytes 35838.000 bytes
This is size change bit suspicious, because your changes should have no way how to influence that. Most likely it means you are not comparing the same base commit. Do the other size changes have the same problem ?
Yeah, it's not comparing exactly the same base commit, because we don't have any runs for 8.0 or 8.0-rc2 branches, so I have to compare against the last run that we have from rc1.
Essentially, the difference is that we don't pass -g to link step now.
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
I can do a manual run on the current HEAD, and then we could compare.
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
@pavelsavara@lewing I have updated the results.
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 26, 2023
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
@pavelsavara good catch, I fixed the percentages now.
@radicalradical
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 27, 2023
@radical
radical
commented
Sep 27, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop this is ready for merge.
@carlossanlop
carlossanlop
merged commit 0933e30
into
dotnet:release/8.0Sep 27, 2023
@radical
radical
deleted the

wasm-symbols-8

branch
September 27, 2023 03:37
@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 27, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes
@pavelsavarapavelsavarapavelsavara approved these changes
@kgkgAwaiting requested review from kg
@marafmarafAwaiting requested review from maraf

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@pavelsavara@lewing@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/8.0][wasm] Fix regressed file sizes for blazor - #92627
Merged
carlossanlop merged 4 commits into
dotnet:release/8.0from 
radical:wasm-symbols-8
Sep 27, 2023
Merged
[release/8.0][wasm] Fix regressed file sizes for blazor#92627
carlossanlop merged 4 commits into
dotnet:release/8.0from 
radical:wasm-symbols-8
Conversation
@radical
@radicalradical
commented
Sep 26, 2023•

edited

Loading

Copy link


Copy Markdown

Member
[wasm] build: Revert to older behavior for WasmNativeStrip
The earlier change was done in 26ae097,

which changed to pass -g to the link step also. But that resulted in

increased native file sizes.
Changed sizes for the minimum blazor template - publish scenario:
---run from rc2 HEAD (KiB)With the change (KiB)% change
SOD - Minimum Blazor Template - Publish79187705-2.69
Total Uncompressed _framework42544104-3.53
Aggregate - .js540437-19.07
Aggregate - .wasm37113663-1.29
pub/wwwroot/_framework/dotnet.js35350.00
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js234131-44.02
pub/wwwroot/_framework/dotnet.native.wasm11701122-4.10
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js2162170.46
Customer impact
Improved download size for the blazor app.
Testing
Sizes confirmed with a dotnet-runtime-perf run for blazor_scenarios. Correctness verified by unit tests.
Risk
Low. This is reverting to older behavior to change the symbols being included in the output.
Details
  • [wasm] Add getters for __indirect_function_table, and wasmMemory
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Issue: dotnet/perf-autofiling-issues#20642
@radical
[wasm] Add getters for __indirect_function_table, and wasmMemory
5eefacf
.. so that can work even if they get renamed during minimization.
@radical
[wasm] build: Revert to older behavior for WasmNativeStrip
ae93e81
The earlier change was done in 678fd6a,
which changed to pass `-g` to the link step also. But that resulted in
increased native file sizes.
Changed sizes for the `minimum blazor template - publish` scenario:
```
| Last rc1 run | With the change
----------------------------------------------------------|----------------- |------------------
SOD - Minimum Blazor Template - Publish |8590723.000 bytes |7889806.000 bytes
Total Uncompressed _framework |4304274.000 bytes |4202273.000 bytes
pub/wwwroot/_framework/dotnet.js |35722.000 bytes |35838.000 bytes
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js |239307.000 bytes |134566.000 bytes
pub/wwwroot/_framework/dotnet.native.wasm |1174394.000 bytes |1148841.000 bytes
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js |221356.000 bytes |221712.000 bytes
```
@radical
[wasm] cleanup corresponding tests
0207d60
@radical
[wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
91379dd
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Sep 26, 2023
@ghostghost
added
the 
area-Build-mono

label
Sep 26, 2023
@ghostghost
assigned radicalSep 26, 2023
@radicalradical
changed the title
wasm symbols 8[release/8.0][wasm] Fix regressed file sizes for blazorSep 26, 2023
@ghost
ghost
commented
Sep 26, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • [wasm] Add getters for __indirect_function_table, and wasmMemory
  • [wasm] build: Revert to older behavior for WasmNativeStrip
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@radical
radical
requested a review
from marafSeptember 26, 2023 07:51
@pavelsavara
pavelsavara
commented
Sep 26, 2023•

edited

Loading

Copy link


Copy Markdown

Member
pub/wwwroot/_framework/dotnet.js 35722.000 bytes 35838.000 bytes
This is size change bit suspicious, because your changes should have no way how to influence that.

Most likely it means you are not comparing the same base commit. Do the other size changes have the same problem ?
Edit: oh, your table heading actually said rc1
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
pub/wwwroot/_framework/dotnet.js 35722.000 bytes 35838.000 bytes
This is size change bit suspicious, because your changes should have no way how to influence that. Most likely it means you are not comparing the same base commit. Do the other size changes have the same problem ?
Yeah, it's not comparing exactly the same base commit, because we don't have any runs for 8.0 or 8.0-rc2 branches, so I have to compare against the last run that we have from rc1.
Essentially, the difference is that we don't pass -g to link step now.
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
I can do a manual run on the current HEAD, and then we could compare.
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
@pavelsavara@lewing I have updated the results.
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 26, 2023
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
@pavelsavara good catch, I fixed the percentages now.
@radicalradical
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 27, 2023
@radical
radical
commented
Sep 27, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop this is ready for merge.
@carlossanlop
carlossanlop
merged commit 0933e30
into
dotnet:release/8.0Sep 27, 2023
@radical
radical
deleted the

wasm-symbols-8

branch
September 27, 2023 03:37
@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 27, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes
@pavelsavarapavelsavarapavelsavara approved these changes
@kgkgAwaiting requested review from kg
@marafmarafAwaiting requested review from maraf

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@pavelsavara@lewing@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[release/8.0][wasm] Fix regressed file sizes for blazor - #92627
Merged
carlossanlop merged 4 commits into
dotnet:release/8.0from 
radical:wasm-symbols-8
Sep 27, 2023
Merged
[release/8.0][wasm] Fix regressed file sizes for blazor#92627
carlossanlop merged 4 commits into
dotnet:release/8.0from 
radical:wasm-symbols-8
Conversation
@radical
@radicalradical
commented
Sep 26, 2023•

edited

Loading

Copy link


Copy Markdown

Member
[wasm] build: Revert to older behavior for WasmNativeStrip
The earlier change was done in 26ae097,

which changed to pass -g to the link step also. But that resulted in

increased native file sizes.
Changed sizes for the minimum blazor template - publish scenario:
---run from rc2 HEAD (KiB)With the change (KiB)% change
SOD - Minimum Blazor Template - Publish79187705-2.69
Total Uncompressed _framework42544104-3.53
Aggregate - .js540437-19.07
Aggregate - .wasm37113663-1.29
pub/wwwroot/_framework/dotnet.js35350.00
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js234131-44.02
pub/wwwroot/_framework/dotnet.native.wasm11701122-4.10
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js2162170.46
Customer impact
Improved download size for the blazor app.
Testing
Sizes confirmed with a dotnet-runtime-perf run for blazor_scenarios. Correctness verified by unit tests.
Risk
Low. This is reverting to older behavior to change the symbols being included in the output.
Details
  • [wasm] Add getters for __indirect_function_table, and wasmMemory
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Issue: dotnet/perf-autofiling-issues#20642
@radical
[wasm] Add getters for __indirect_function_table, and wasmMemory
5eefacf
.. so that can work even if they get renamed during minimization.
@radical
[wasm] build: Revert to older behavior for WasmNativeStrip
ae93e81
The earlier change was done in 678fd6a,
which changed to pass `-g` to the link step also. But that resulted in
increased native file sizes.
Changed sizes for the `minimum blazor template - publish` scenario:
```
| Last rc1 run | With the change
----------------------------------------------------------|----------------- |------------------
SOD - Minimum Blazor Template - Publish |8590723.000 bytes |7889806.000 bytes
Total Uncompressed _framework |4304274.000 bytes |4202273.000 bytes
pub/wwwroot/_framework/dotnet.js |35722.000 bytes |35838.000 bytes
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js |239307.000 bytes |134566.000 bytes
pub/wwwroot/_framework/dotnet.native.wasm |1174394.000 bytes |1148841.000 bytes
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js |221356.000 bytes |221712.000 bytes
```
@radical
[wasm] cleanup corresponding tests
0207d60
@radical
[wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
91379dd
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Sep 26, 2023
@ghostghost
added
the 
area-Build-mono

label
Sep 26, 2023
@ghostghost
assigned radicalSep 26, 2023
@radicalradical
changed the title
wasm symbols 8[release/8.0][wasm] Fix regressed file sizes for blazorSep 26, 2023
@ghost
ghost
commented
Sep 26, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • [wasm] Add getters for __indirect_function_table, and wasmMemory
  • [wasm] build: Revert to older behavior for WasmNativeStrip
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@radical
radical
requested a review
from marafSeptember 26, 2023 07:51
@pavelsavara
pavelsavara
commented
Sep 26, 2023•

edited

Loading

Copy link


Copy Markdown

Member
pub/wwwroot/_framework/dotnet.js 35722.000 bytes 35838.000 bytes
This is size change bit suspicious, because your changes should have no way how to influence that.

Most likely it means you are not comparing the same base commit. Do the other size changes have the same problem ?
Edit: oh, your table heading actually said rc1
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
pub/wwwroot/_framework/dotnet.js 35722.000 bytes 35838.000 bytes
This is size change bit suspicious, because your changes should have no way how to influence that. Most likely it means you are not comparing the same base commit. Do the other size changes have the same problem ?
Yeah, it's not comparing exactly the same base commit, because we don't have any runs for 8.0 or 8.0-rc2 branches, so I have to compare against the last run that we have from rc1.
Essentially, the difference is that we don't pass -g to link step now.
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
I can do a manual run on the current HEAD, and then we could compare.
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
@pavelsavara@lewing I have updated the results.
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 26, 2023
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
@pavelsavara good catch, I fixed the percentages now.
@radicalradical
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 27, 2023
@radical
radical
commented
Sep 27, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop this is ready for merge.
@carlossanlop
carlossanlop
merged commit 0933e30
into
dotnet:release/8.0Sep 27, 2023
@radical
radical
deleted the

wasm-symbols-8

branch
September 27, 2023 03:37
@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 27, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes
@pavelsavarapavelsavarapavelsavara approved these changes
@kgkgAwaiting requested review from kg
@marafmarafAwaiting requested review from maraf

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@pavelsavara@lewing@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/8.0][wasm] Fix regressed file sizes for blazor - #92627
Merged
carlossanlop merged 4 commits into
dotnet:release/8.0from 
radical:wasm-symbols-8
Sep 27, 2023
Merged
[release/8.0][wasm] Fix regressed file sizes for blazor#92627
carlossanlop merged 4 commits into
dotnet:release/8.0from 
radical:wasm-symbols-8
Conversation
@radical
@radicalradical
commented
Sep 26, 2023•

edited

Loading

Copy link


Copy Markdown

Member
[wasm] build: Revert to older behavior for WasmNativeStrip
The earlier change was done in 26ae097,

which changed to pass -g to the link step also. But that resulted in

increased native file sizes.
Changed sizes for the minimum blazor template - publish scenario:
---run from rc2 HEAD (KiB)With the change (KiB)% change
SOD - Minimum Blazor Template - Publish79187705-2.69
Total Uncompressed _framework42544104-3.53
Aggregate - .js540437-19.07
Aggregate - .wasm37113663-1.29
pub/wwwroot/_framework/dotnet.js35350.00
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js234131-44.02
pub/wwwroot/_framework/dotnet.native.wasm11701122-4.10
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js2162170.46
Customer impact
Improved download size for the blazor app.
Testing
Sizes confirmed with a dotnet-runtime-perf run for blazor_scenarios. Correctness verified by unit tests.
Risk
Low. This is reverting to older behavior to change the symbols being included in the output.
Details
  • [wasm] Add getters for __indirect_function_table, and wasmMemory
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Issue: dotnet/perf-autofiling-issues#20642
@radical
[wasm] Add getters for __indirect_function_table, and wasmMemory
5eefacf
.. so that can work even if they get renamed during minimization.
@radical
[wasm] build: Revert to older behavior for WasmNativeStrip
ae93e81
The earlier change was done in 678fd6a,
which changed to pass `-g` to the link step also. But that resulted in
increased native file sizes.
Changed sizes for the `minimum blazor template - publish` scenario:
```
| Last rc1 run | With the change
----------------------------------------------------------|----------------- |------------------
SOD - Minimum Blazor Template - Publish |8590723.000 bytes |7889806.000 bytes
Total Uncompressed _framework |4304274.000 bytes |4202273.000 bytes
pub/wwwroot/_framework/dotnet.js |35722.000 bytes |35838.000 bytes
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js |239307.000 bytes |134566.000 bytes
pub/wwwroot/_framework/dotnet.native.wasm |1174394.000 bytes |1148841.000 bytes
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js |221356.000 bytes |221712.000 bytes
```
@radical
[wasm] cleanup corresponding tests
0207d60
@radical
[wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
91379dd
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Sep 26, 2023
@ghostghost
added
the 
area-Build-mono

label
Sep 26, 2023
@ghostghost
assigned radicalSep 26, 2023
@radicalradical
changed the title
wasm symbols 8[release/8.0][wasm] Fix regressed file sizes for blazorSep 26, 2023
@ghost
ghost
commented
Sep 26, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • [wasm] Add getters for __indirect_function_table, and wasmMemory
  • [wasm] build: Revert to older behavior for WasmNativeStrip
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@radical
radical
requested a review
from marafSeptember 26, 2023 07:51
@pavelsavara
pavelsavara
commented
Sep 26, 2023•

edited

Loading

Copy link


Copy Markdown

Member
pub/wwwroot/_framework/dotnet.js 35722.000 bytes 35838.000 bytes
This is size change bit suspicious, because your changes should have no way how to influence that.

Most likely it means you are not comparing the same base commit. Do the other size changes have the same problem ?
Edit: oh, your table heading actually said rc1
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
pub/wwwroot/_framework/dotnet.js 35722.000 bytes 35838.000 bytes
This is size change bit suspicious, because your changes should have no way how to influence that. Most likely it means you are not comparing the same base commit. Do the other size changes have the same problem ?
Yeah, it's not comparing exactly the same base commit, because we don't have any runs for 8.0 or 8.0-rc2 branches, so I have to compare against the last run that we have from rc1.
Essentially, the difference is that we don't pass -g to link step now.
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
I can do a manual run on the current HEAD, and then we could compare.
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
@pavelsavara@lewing I have updated the results.
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 26, 2023
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
@pavelsavara good catch, I fixed the percentages now.
@radicalradical
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 27, 2023
@radical
radical
commented
Sep 27, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop this is ready for merge.
@carlossanlop
carlossanlop
merged commit 0933e30
into
dotnet:release/8.0Sep 27, 2023
@radical
radical
deleted the

wasm-symbols-8

branch
September 27, 2023 03:37
@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 27, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes
@pavelsavarapavelsavarapavelsavara approved these changes
@kgkgAwaiting requested review from kg
@marafmarafAwaiting requested review from maraf

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@pavelsavara@lewing@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/8.0][wasm] Fix regressed file sizes for blazor - #92627
Merged
carlossanlop merged 4 commits into
dotnet:release/8.0from 
radical:wasm-symbols-8
Sep 27, 2023
Merged
[release/8.0][wasm] Fix regressed file sizes for blazor#92627
carlossanlop merged 4 commits into
dotnet:release/8.0from 
radical:wasm-symbols-8
Conversation
@radical
@radicalradical
commented
Sep 26, 2023•

edited

Loading

Copy link


Copy Markdown

Member
[wasm] build: Revert to older behavior for WasmNativeStrip
The earlier change was done in 26ae097,

which changed to pass -g to the link step also. But that resulted in

increased native file sizes.
Changed sizes for the minimum blazor template - publish scenario:
---run from rc2 HEAD (KiB)With the change (KiB)% change
SOD - Minimum Blazor Template - Publish79187705-2.69
Total Uncompressed _framework42544104-3.53
Aggregate - .js540437-19.07
Aggregate - .wasm37113663-1.29
pub/wwwroot/_framework/dotnet.js35350.00
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js234131-44.02
pub/wwwroot/_framework/dotnet.native.wasm11701122-4.10
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js2162170.46
Customer impact
Improved download size for the blazor app.
Testing
Sizes confirmed with a dotnet-runtime-perf run for blazor_scenarios. Correctness verified by unit tests.
Risk
Low. This is reverting to older behavior to change the symbols being included in the output.
Details
  • [wasm] Add getters for __indirect_function_table, and wasmMemory
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Issue: dotnet/perf-autofiling-issues#20642
@radical
[wasm] Add getters for __indirect_function_table, and wasmMemory
5eefacf
.. so that can work even if they get renamed during minimization.
@radical
[wasm] build: Revert to older behavior for WasmNativeStrip
ae93e81
The earlier change was done in 678fd6a,
which changed to pass `-g` to the link step also. But that resulted in
increased native file sizes.
Changed sizes for the `minimum blazor template - publish` scenario:
```
| Last rc1 run | With the change
----------------------------------------------------------|----------------- |------------------
SOD - Minimum Blazor Template - Publish |8590723.000 bytes |7889806.000 bytes
Total Uncompressed _framework |4304274.000 bytes |4202273.000 bytes
pub/wwwroot/_framework/dotnet.js |35722.000 bytes |35838.000 bytes
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js |239307.000 bytes |134566.000 bytes
pub/wwwroot/_framework/dotnet.native.wasm |1174394.000 bytes |1148841.000 bytes
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js |221356.000 bytes |221712.000 bytes
```
@radical
[wasm] cleanup corresponding tests
0207d60
@radical
[wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
91379dd
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Sep 26, 2023
@ghostghost
added
the 
area-Build-mono

label
Sep 26, 2023
@ghostghost
assigned radicalSep 26, 2023
@radicalradical
changed the title
wasm symbols 8[release/8.0][wasm] Fix regressed file sizes for blazorSep 26, 2023
@ghost
ghost
commented
Sep 26, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • [wasm] Add getters for __indirect_function_table, and wasmMemory
  • [wasm] build: Revert to older behavior for WasmNativeStrip
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@radical
radical
requested a review
from marafSeptember 26, 2023 07:51
@pavelsavara
pavelsavara
commented
Sep 26, 2023•

edited

Loading

Copy link


Copy Markdown

Member
pub/wwwroot/_framework/dotnet.js 35722.000 bytes 35838.000 bytes
This is size change bit suspicious, because your changes should have no way how to influence that.

Most likely it means you are not comparing the same base commit. Do the other size changes have the same problem ?
Edit: oh, your table heading actually said rc1
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
pub/wwwroot/_framework/dotnet.js 35722.000 bytes 35838.000 bytes
This is size change bit suspicious, because your changes should have no way how to influence that. Most likely it means you are not comparing the same base commit. Do the other size changes have the same problem ?
Yeah, it's not comparing exactly the same base commit, because we don't have any runs for 8.0 or 8.0-rc2 branches, so I have to compare against the last run that we have from rc1.
Essentially, the difference is that we don't pass -g to link step now.
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
I can do a manual run on the current HEAD, and then we could compare.
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
@pavelsavara@lewing I have updated the results.
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 26, 2023
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
@pavelsavara good catch, I fixed the percentages now.
@radicalradical
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 27, 2023
@radical
radical
commented
Sep 27, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop this is ready for merge.
@carlossanlop
carlossanlop
merged commit 0933e30
into
dotnet:release/8.0Sep 27, 2023
@radical
radical
deleted the

wasm-symbols-8

branch
September 27, 2023 03:37
@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 27, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes
@pavelsavarapavelsavarapavelsavara approved these changes
@kgkgAwaiting requested review from kg
@marafmarafAwaiting requested review from maraf

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@pavelsavara@lewing@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[release/8.0][wasm] Fix regressed file sizes for blazor - #92627
Merged
carlossanlop merged 4 commits into
dotnet:release/8.0from 
radical:wasm-symbols-8
Sep 27, 2023
Merged
[release/8.0][wasm] Fix regressed file sizes for blazor#92627
carlossanlop merged 4 commits into
dotnet:release/8.0from 
radical:wasm-symbols-8
Conversation
@radical
@radicalradical
commented
Sep 26, 2023•

edited

Loading

Copy link


Copy Markdown

Member
[wasm] build: Revert to older behavior for WasmNativeStrip
The earlier change was done in 26ae097,

which changed to pass -g to the link step also. But that resulted in

increased native file sizes.
Changed sizes for the minimum blazor template - publish scenario:
---run from rc2 HEAD (KiB)With the change (KiB)% change
SOD - Minimum Blazor Template - Publish79187705-2.69
Total Uncompressed _framework42544104-3.53
Aggregate - .js540437-19.07
Aggregate - .wasm37113663-1.29
pub/wwwroot/_framework/dotnet.js35350.00
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js234131-44.02
pub/wwwroot/_framework/dotnet.native.wasm11701122-4.10
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js2162170.46
Customer impact
Improved download size for the blazor app.
Testing
Sizes confirmed with a dotnet-runtime-perf run for blazor_scenarios. Correctness verified by unit tests.
Risk
Low. This is reverting to older behavior to change the symbols being included in the output.
Details
  • [wasm] Add getters for __indirect_function_table, and wasmMemory
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Issue: dotnet/perf-autofiling-issues#20642
@radical
[wasm] Add getters for __indirect_function_table, and wasmMemory
5eefacf
.. so that can work even if they get renamed during minimization.
@radical
[wasm] build: Revert to older behavior for WasmNativeStrip
ae93e81
The earlier change was done in 678fd6a,
which changed to pass `-g` to the link step also. But that resulted in
increased native file sizes.
Changed sizes for the `minimum blazor template - publish` scenario:
```
| Last rc1 run | With the change
----------------------------------------------------------|----------------- |------------------
SOD - Minimum Blazor Template - Publish |8590723.000 bytes |7889806.000 bytes
Total Uncompressed _framework |4304274.000 bytes |4202273.000 bytes
pub/wwwroot/_framework/dotnet.js |35722.000 bytes |35838.000 bytes
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js |239307.000 bytes |134566.000 bytes
pub/wwwroot/_framework/dotnet.native.wasm |1174394.000 bytes |1148841.000 bytes
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js |221356.000 bytes |221712.000 bytes
```
@radical
[wasm] cleanup corresponding tests
0207d60
@radical
[wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
91379dd
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Sep 26, 2023
@ghostghost
added
the 
area-Build-mono

label
Sep 26, 2023
@ghostghost
assigned radicalSep 26, 2023
@radicalradical
changed the title
wasm symbols 8[release/8.0][wasm] Fix regressed file sizes for blazorSep 26, 2023
@ghost
ghost
commented
Sep 26, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • [wasm] Add getters for __indirect_function_table, and wasmMemory
  • [wasm] build: Revert to older behavior for WasmNativeStrip
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@radical
radical
requested a review
from marafSeptember 26, 2023 07:51
@pavelsavara
pavelsavara
commented
Sep 26, 2023•

edited

Loading

Copy link


Copy Markdown

Member
pub/wwwroot/_framework/dotnet.js 35722.000 bytes 35838.000 bytes
This is size change bit suspicious, because your changes should have no way how to influence that.

Most likely it means you are not comparing the same base commit. Do the other size changes have the same problem ?
Edit: oh, your table heading actually said rc1
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
pub/wwwroot/_framework/dotnet.js 35722.000 bytes 35838.000 bytes
This is size change bit suspicious, because your changes should have no way how to influence that. Most likely it means you are not comparing the same base commit. Do the other size changes have the same problem ?
Yeah, it's not comparing exactly the same base commit, because we don't have any runs for 8.0 or 8.0-rc2 branches, so I have to compare against the last run that we have from rc1.
Essentially, the difference is that we don't pass -g to link step now.
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
I can do a manual run on the current HEAD, and then we could compare.
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
@pavelsavara@lewing I have updated the results.
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 26, 2023
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
@pavelsavara good catch, I fixed the percentages now.
@radicalradical
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 27, 2023
@radical
radical
commented
Sep 27, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop this is ready for merge.
@carlossanlop
carlossanlop
merged commit 0933e30
into
dotnet:release/8.0Sep 27, 2023
@radical
radical
deleted the

wasm-symbols-8

branch
September 27, 2023 03:37
@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 27, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes
@pavelsavarapavelsavarapavelsavara approved these changes
@kgkgAwaiting requested review from kg
@marafmarafAwaiting requested review from maraf

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@pavelsavara@lewing@carlossanlop