[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing the - #92683

Closed
radical wants to merge 5 commits into
dotnet:release/8.0from
radical:wasm-strip-fixes-8
Closed

[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing the#92683
radical wants to merge 5 commits into
dotnet:release/8.0from
radical:wasm-strip-fixes-8

Conversation

@radical

@radicalradical commented Sep 27, 2023•
edited
Loading

Copy link
Copy Markdown
Member

.. runtime also, so it is available at that time.

Based on feedback from Katelyn Gadd.

Customer impact

Ensure that the indirect function table is available when the runtime is being initialized. This is a precautionary measure, and was not breaking any existing tests.

Testing

Unit tests.

Risk

Low.

@radical
[wasm] Define getWasmIndirectFunctionTable before intializing the
fac7b4a
.. runtime also, so it is available at that time.
@radicalradical added the arch-wasm WebAssembly architecture label Sep 27, 2023
@ghost

ghost commented Sep 27, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

.. runtime also, so it is available at that time.

Based on feedback from Katelyn Gadd.

Author:radical
Assignees:-
Labels:

arch-wasm

Milestone:-

@ghostghost assigned radicalSep 27, 2023
@radicalradical added the Servicing-consider Issue for next servicing release review label Sep 27, 2023
@radicalradical changed the title [release/8.0][wasm] Define getWasmIndirectFunctionTable before intializing the[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing theSep 27, 2023
@radical
radical marked this pull request as draft September 27, 2023 05:21
@radicalradical removed the Servicing-consider Issue for next servicing release review label Sep 27, 2023
@radical
radical marked this pull request as ready for review September 27, 2023 08:13
pavelsavara
pavelsavara previously requested changes Sep 27, 2023
View reviewed changes

@pavelsavarapavelsavara left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain the scenarios under which this is necessary ?

@ghostghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Sep 27, 2023
@build-analysisbuild-analysisBot mentioned this pull request Sep 27, 2023
Closed
@ghostghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Sep 27, 2023
@kg

kg commented Sep 27, 2023

Copy link
Copy Markdown
Contributor

Could you please explain the scenarios under which this is necessary ?

startup can engage the interpreter, which could under rare circumstances (i.e. if you set low thresholds, disable tiering) engage the jiterpreter which will need these tables

@radical

radical commented Sep 27, 2023

Copy link
Copy Markdown
MemberAuthor

Could you please explain the scenarios under which this is necessary ?

Address your suggestion in #92664 (comment) . I didn't change getMemory though, to match what we have in main.

@radical
Revert "address review feedback"
249d8b6
This reverts commit 4975dc3.
This caused library aot tests to fail with:
```
info: MONO_WASM: mono_wasm_load_runtime () failed TypeError: t.getWasmIndirectFunctionTable is not a function
info: MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function
info: at Ma (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:80285)
info: at Ul (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:174663)
info: at do_jit_call (do_jit_call (wasm://wasm/0dec238a:wasm-function[90022]:0x16bba99))
info: at mono_interp_exec_method (mono_interp_exec_method (wasm://wasm/0dec238a:wasm-function[90012]:0x16af791))
info: at interp_runtime_invoke (interp_runtime_invoke (wasm://wasm/0dec238a:wasm-function[90052]:0x16bc9da))
info: at mono_jit_runtime_invoke (mono_jit_runtime_invoke (wasm://wasm/0dec238a:wasm-function[95289]:0x17c5028))
info: at do_runtime_invoke (do_runtime_invoke (wasm://wasm/0dec238a:wasm-function[94085]:0x178e3d3))
info: at mono_runtime_invoke_checked (mono_runtime_invoke_checked (wasm://wasm/0dec238a:wasm-function[94084]:0x178e38f))
info: at mono_runtime_install_appctx_properties (mono_runtime_install_appctx_properties (wasm://wasm/0dec238a:wasm-function[91526]:0x17054e4))
info: at mono_runtime_init_checked (mono_runtime_init_checked (wasm://wasm/0dec238a:wasm-function[91521]:0x1704d4e))
info: at mini_init (mini_init (wasm://wasm/0dec238a:wasm-function[95272]:0x17c43ea))
info: at mono_jit_init_version (mono_jit_init_version (wasm://wasm/0dec238a:wasm-function[95408]:0x17ca553))
info: at mono_wasm_load_runtime (mono_wasm_load_runtime (wasm://wasm/0dec238a:wasm-function[103299]:0x1900987))
info: at Module._mono_wasm_load_runtime (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:6817:114)
info: at ccall (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:5851:22)
info: at Object.mono_wasm_load_runtime (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:5877:16)
info: at Dl (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:215804)
info: at /root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:205340
info: at /root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:206020
```
@radical

radical commented Sep 27, 2023

Copy link
Copy Markdown
MemberAuthor

@kg interestingly removing getWasmIndirectFunctionTable after the runtime is initialized, only failed the AOT tests here.

@radical

radical commented Sep 28, 2023

Copy link
Copy Markdown
MemberAuthor

Failing tests will be fixed by - #92747

@radicalradical closed this Sep 28, 2023
@radicalradical reopened this Sep 28, 2023
@carlossanlop

carlossanlop commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

@radical if this is ready, please send an email to Tactics requesting approval (unless you're waiting for @pavelsavara to approve the change first).

@carlossanlop

carlossanlop commented Oct 4, 2023

Copy link
Copy Markdown
Contributor

@radical@kg@pavelsavara the CI is green after the latest feedback was addressed. When you're ready, please send the email to Tactics requesting approval. And please get a code review sign-off from an area owner.

pavelsavara
pavelsavara approved these changes Oct 4, 2023
View reviewed changes

@pavelsavarapavelsavara left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good enough fix for Net8 (because it's low risk), but for Net9 we need better solution (because it's ugly).

@radicalradical added the Servicing-consider Issue for next servicing release review label Oct 4, 2023
@radical

radical commented Oct 13, 2023

Copy link
Copy Markdown
MemberAuthor

This was not approved for 8.

@radicalradical closed this Oct 13, 2023
@radicalradical removed the Servicing-consider Issue for next servicing release review label Oct 13, 2023
@radical
radical deleted the wasm-strip-fixes-8 branch October 13, 2023 17:02
@ghostghost locked as resolved and limited conversation to collaborators Nov 12, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pavelsavarapavelsavarapavelsavara approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@kgkgAwaiting requested review from kg

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@radical@kg@carlossanlop@pavelsavara
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing the - #92683
Closed
radical wants to merge 5 commits into
dotnet:release/8.0from 
radical:wasm-strip-fixes-8
Closed
[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing the#92683
radical wants to merge 5 commits into
dotnet:release/8.0from 
radical:wasm-strip-fixes-8
Conversation
@radical
@radicalradical
commented
Sep 27, 2023•

edited

Loading

Copy link


Copy Markdown

Member
.. runtime also, so it is available at that time.
Based on feedback from Katelyn Gadd.
Customer impact
Ensure that the indirect function table is available when the runtime is being initialized. This is a precautionary measure, and was not breaking any existing tests.
Testing
Unit tests.
Risk
Low.
@radical
[wasm] Define getWasmIndirectFunctionTable before intializing the
fac7b4a
.. runtime also, so it is available at that time.
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Sep 27, 2023
@ghost
ghost
commented
Sep 27, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
.. runtime also, so it is available at that time.
Based on feedback from Katelyn Gadd.
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@ghostghost
assigned radicalSep 27, 2023
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 27, 2023
@radicalradical
changed the title
[release/8.0][wasm] Define getWasmIndirectFunctionTable before intializing the[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing theSep 27, 2023
@radical
radical
marked this pull request as draft
September 27, 2023 05:21
@radicalradical
removed
the 
Servicing-consider
Issue for next servicing release review
label
Sep 27, 2023
@radical
radical
marked this pull request as ready for review
September 27, 2023 08:13
pavelsavara
pavelsavara
previously requested changes
Sep 27, 2023
View reviewed changes
@pavelsavarapavelsavara
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain the scenarios under which this is necessary ?
@ghostghost
added
the 
needs-author-action
An issue or pull request that requires more info or actions from the author.
label
Sep 27, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 27, 2023

Closed

@ghostghost
removed
the 
needs-author-action
An issue or pull request that requires more info or actions from the author.
label
Sep 27, 2023
@kg
kg
commented
Sep 27, 2023

Copy link


Copy Markdown

Contributor
Could you please explain the scenarios under which this is necessary ?
startup can engage the interpreter, which could under rare circumstances (i.e. if you set low thresholds, disable tiering) engage the jiterpreter which will need these tables
@radical
radical
commented
Sep 27, 2023

Copy link


Copy Markdown

MemberAuthor
Could you please explain the scenarios under which this is necessary ?
Address your suggestion in #92664 (comment) . I didn't change getMemory though, to match what we have in main.
@radical
Revert "address review feedback"
249d8b6
This reverts commit 4975dc3.
This caused library aot tests to fail with:
```
info: MONO_WASM: mono_wasm_load_runtime () failed TypeError: t.getWasmIndirectFunctionTable is not a function
info: MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function
info: at Ma (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:80285)
info: at Ul (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:174663)
info: at do_jit_call (do_jit_call (wasm://wasm/0dec238a:wasm-function[90022]:0x16bba99))
info: at mono_interp_exec_method (mono_interp_exec_method (wasm://wasm/0dec238a:wasm-function[90012]:0x16af791))
info: at interp_runtime_invoke (interp_runtime_invoke (wasm://wasm/0dec238a:wasm-function[90052]:0x16bc9da))
info: at mono_jit_runtime_invoke (mono_jit_runtime_invoke (wasm://wasm/0dec238a:wasm-function[95289]:0x17c5028))
info: at do_runtime_invoke (do_runtime_invoke (wasm://wasm/0dec238a:wasm-function[94085]:0x178e3d3))
info: at mono_runtime_invoke_checked (mono_runtime_invoke_checked (wasm://wasm/0dec238a:wasm-function[94084]:0x178e38f))
info: at mono_runtime_install_appctx_properties (mono_runtime_install_appctx_properties (wasm://wasm/0dec238a:wasm-function[91526]:0x17054e4))
info: at mono_runtime_init_checked (mono_runtime_init_checked (wasm://wasm/0dec238a:wasm-function[91521]:0x1704d4e))
info: at mini_init (mini_init (wasm://wasm/0dec238a:wasm-function[95272]:0x17c43ea))
info: at mono_jit_init_version (mono_jit_init_version (wasm://wasm/0dec238a:wasm-function[95408]:0x17ca553))
info: at mono_wasm_load_runtime (mono_wasm_load_runtime (wasm://wasm/0dec238a:wasm-function[103299]:0x1900987))
info: at Module._mono_wasm_load_runtime (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:6817:114)
info: at ccall (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:5851:22)
info: at Object.mono_wasm_load_runtime (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:5877:16)
info: at Dl (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:215804)
info: at /root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:205340
info: at /root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:206020
```
@radical
radical
commented
Sep 27, 2023

Copy link


Copy Markdown

MemberAuthor
@kg interestingly removing getWasmIndirectFunctionTable after the runtime is initialized, only failed the AOT tests here.
@radical
radical
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
Failing tests will be fixed by - #92747
@radicalradical
closed this
Sep 28, 2023
@radicalradical
reopened this
Sep 28, 2023
@carlossanlop
carlossanlop
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
@radical if this is ready, please send an email to Tactics requesting approval (unless you're waiting for @pavelsavara to approve the change first).
@carlossanlop
carlossanlop
commented
Oct 4, 2023

Copy link


Copy Markdown

Contributor
@radical@kg@pavelsavara the CI is green after the latest feedback was addressed. When you're ready, please send the email to Tactics requesting approval. And please get a code review sign-off from an area owner.
pavelsavara
pavelsavara
approved these changes
Oct 4, 2023
View reviewed changes
@pavelsavarapavelsavara
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good enough fix for Net8 (because it's low risk), but for Net9 we need better solution (because it's ugly).
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Oct 4, 2023
@radical
radical
commented
Oct 13, 2023

Copy link


Copy Markdown

MemberAuthor
This was not approved for 8.
@radicalradical
closed this
Oct 13, 2023
@radicalradical
removed
the 
Servicing-consider
Issue for next servicing release review
label
Oct 13, 2023
@radical
radical
deleted the

wasm-strip-fixes-8

branch
October 13, 2023 17:02
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 12, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@pavelsavarapavelsavarapavelsavara approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@kgkgAwaiting requested review from kg

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@kg@carlossanlop@pavelsavara

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing the - #92683
Closed
radical wants to merge 5 commits into
dotnet:release/8.0from 
radical:wasm-strip-fixes-8
Closed
[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing the#92683
radical wants to merge 5 commits into
dotnet:release/8.0from 
radical:wasm-strip-fixes-8
Conversation
@radical
@radicalradical
commented
Sep 27, 2023•

edited

Loading

Copy link


Copy Markdown

Member
.. runtime also, so it is available at that time.
Based on feedback from Katelyn Gadd.
Customer impact
Ensure that the indirect function table is available when the runtime is being initialized. This is a precautionary measure, and was not breaking any existing tests.
Testing
Unit tests.
Risk
Low.
@radical
[wasm] Define getWasmIndirectFunctionTable before intializing the
fac7b4a
.. runtime also, so it is available at that time.
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Sep 27, 2023
@ghost
ghost
commented
Sep 27, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
.. runtime also, so it is available at that time.
Based on feedback from Katelyn Gadd.
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@ghostghost
assigned radicalSep 27, 2023
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 27, 2023
@radicalradical
changed the title
[release/8.0][wasm] Define getWasmIndirectFunctionTable before intializing the[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing theSep 27, 2023
@radical
radical
marked this pull request as draft
September 27, 2023 05:21
@radicalradical
removed
the 
Servicing-consider
Issue for next servicing release review
label
Sep 27, 2023
@radical
radical
marked this pull request as ready for review
September 27, 2023 08:13
pavelsavara
pavelsavara
previously requested changes
Sep 27, 2023
View reviewed changes
@pavelsavarapavelsavara
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain the scenarios under which this is necessary ?
@ghostghost
added
the 
needs-author-action
An issue or pull request that requires more info or actions from the author.
label
Sep 27, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 27, 2023

Closed

@ghostghost
removed
the 
needs-author-action
An issue or pull request that requires more info or actions from the author.
label
Sep 27, 2023
@kg
kg
commented
Sep 27, 2023

Copy link


Copy Markdown

Contributor
Could you please explain the scenarios under which this is necessary ?
startup can engage the interpreter, which could under rare circumstances (i.e. if you set low thresholds, disable tiering) engage the jiterpreter which will need these tables
@radical
radical
commented
Sep 27, 2023

Copy link


Copy Markdown

MemberAuthor
Could you please explain the scenarios under which this is necessary ?
Address your suggestion in #92664 (comment) . I didn't change getMemory though, to match what we have in main.
@radical
Revert "address review feedback"
249d8b6
This reverts commit 4975dc3.
This caused library aot tests to fail with:
```
info: MONO_WASM: mono_wasm_load_runtime () failed TypeError: t.getWasmIndirectFunctionTable is not a function
info: MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function
info: at Ma (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:80285)
info: at Ul (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:174663)
info: at do_jit_call (do_jit_call (wasm://wasm/0dec238a:wasm-function[90022]:0x16bba99))
info: at mono_interp_exec_method (mono_interp_exec_method (wasm://wasm/0dec238a:wasm-function[90012]:0x16af791))
info: at interp_runtime_invoke (interp_runtime_invoke (wasm://wasm/0dec238a:wasm-function[90052]:0x16bc9da))
info: at mono_jit_runtime_invoke (mono_jit_runtime_invoke (wasm://wasm/0dec238a:wasm-function[95289]:0x17c5028))
info: at do_runtime_invoke (do_runtime_invoke (wasm://wasm/0dec238a:wasm-function[94085]:0x178e3d3))
info: at mono_runtime_invoke_checked (mono_runtime_invoke_checked (wasm://wasm/0dec238a:wasm-function[94084]:0x178e38f))
info: at mono_runtime_install_appctx_properties (mono_runtime_install_appctx_properties (wasm://wasm/0dec238a:wasm-function[91526]:0x17054e4))
info: at mono_runtime_init_checked (mono_runtime_init_checked (wasm://wasm/0dec238a:wasm-function[91521]:0x1704d4e))
info: at mini_init (mini_init (wasm://wasm/0dec238a:wasm-function[95272]:0x17c43ea))
info: at mono_jit_init_version (mono_jit_init_version (wasm://wasm/0dec238a:wasm-function[95408]:0x17ca553))
info: at mono_wasm_load_runtime (mono_wasm_load_runtime (wasm://wasm/0dec238a:wasm-function[103299]:0x1900987))
info: at Module._mono_wasm_load_runtime (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:6817:114)
info: at ccall (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:5851:22)
info: at Object.mono_wasm_load_runtime (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:5877:16)
info: at Dl (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:215804)
info: at /root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:205340
info: at /root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:206020
```
@radical
radical
commented
Sep 27, 2023

Copy link


Copy Markdown

MemberAuthor
@kg interestingly removing getWasmIndirectFunctionTable after the runtime is initialized, only failed the AOT tests here.
@radical
radical
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
Failing tests will be fixed by - #92747
@radicalradical
closed this
Sep 28, 2023
@radicalradical
reopened this
Sep 28, 2023
@carlossanlop
carlossanlop
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
@radical if this is ready, please send an email to Tactics requesting approval (unless you're waiting for @pavelsavara to approve the change first).
@carlossanlop
carlossanlop
commented
Oct 4, 2023

Copy link


Copy Markdown

Contributor
@radical@kg@pavelsavara the CI is green after the latest feedback was addressed. When you're ready, please send the email to Tactics requesting approval. And please get a code review sign-off from an area owner.
pavelsavara
pavelsavara
approved these changes
Oct 4, 2023
View reviewed changes
@pavelsavarapavelsavara
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good enough fix for Net8 (because it's low risk), but for Net9 we need better solution (because it's ugly).
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Oct 4, 2023
@radical
radical
commented
Oct 13, 2023

Copy link


Copy Markdown

MemberAuthor
This was not approved for 8.
@radicalradical
closed this
Oct 13, 2023
@radicalradical
removed
the 
Servicing-consider
Issue for next servicing release review
label
Oct 13, 2023
@radical
radical
deleted the

wasm-strip-fixes-8

branch
October 13, 2023 17:02
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 12, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@pavelsavarapavelsavarapavelsavara approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@kgkgAwaiting requested review from kg

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@kg@carlossanlop@pavelsavara

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing the - #92683
Closed
radical wants to merge 5 commits into
dotnet:release/8.0from 
radical:wasm-strip-fixes-8
Closed
[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing the#92683
radical wants to merge 5 commits into
dotnet:release/8.0from 
radical:wasm-strip-fixes-8
Conversation
@radical
@radicalradical
commented
Sep 27, 2023•

edited

Loading

Copy link


Copy Markdown

Member
.. runtime also, so it is available at that time.
Based on feedback from Katelyn Gadd.
Customer impact
Ensure that the indirect function table is available when the runtime is being initialized. This is a precautionary measure, and was not breaking any existing tests.
Testing
Unit tests.
Risk
Low.
@radical
[wasm] Define getWasmIndirectFunctionTable before intializing the
fac7b4a
.. runtime also, so it is available at that time.
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Sep 27, 2023
@ghost
ghost
commented
Sep 27, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
.. runtime also, so it is available at that time.
Based on feedback from Katelyn Gadd.
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@ghostghost
assigned radicalSep 27, 2023
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 27, 2023
@radicalradical
changed the title
[release/8.0][wasm] Define getWasmIndirectFunctionTable before intializing the[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing theSep 27, 2023
@radical
radical
marked this pull request as draft
September 27, 2023 05:21
@radicalradical
removed
the 
Servicing-consider
Issue for next servicing release review
label
Sep 27, 2023
@radical
radical
marked this pull request as ready for review
September 27, 2023 08:13
pavelsavara
pavelsavara
previously requested changes
Sep 27, 2023
View reviewed changes
@pavelsavarapavelsavara
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain the scenarios under which this is necessary ?
@ghostghost
added
the 
needs-author-action
An issue or pull request that requires more info or actions from the author.
label
Sep 27, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 27, 2023

Closed

@ghostghost
removed
the 
needs-author-action
An issue or pull request that requires more info or actions from the author.
label
Sep 27, 2023
@kg
kg
commented
Sep 27, 2023

Copy link


Copy Markdown

Contributor
Could you please explain the scenarios under which this is necessary ?
startup can engage the interpreter, which could under rare circumstances (i.e. if you set low thresholds, disable tiering) engage the jiterpreter which will need these tables
@radical
radical
commented
Sep 27, 2023

Copy link


Copy Markdown

MemberAuthor
Could you please explain the scenarios under which this is necessary ?
Address your suggestion in #92664 (comment) . I didn't change getMemory though, to match what we have in main.
@radical
Revert "address review feedback"
249d8b6
This reverts commit 4975dc3.
This caused library aot tests to fail with:
```
info: MONO_WASM: mono_wasm_load_runtime () failed TypeError: t.getWasmIndirectFunctionTable is not a function
info: MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function
info: at Ma (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:80285)
info: at Ul (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:174663)
info: at do_jit_call (do_jit_call (wasm://wasm/0dec238a:wasm-function[90022]:0x16bba99))
info: at mono_interp_exec_method (mono_interp_exec_method (wasm://wasm/0dec238a:wasm-function[90012]:0x16af791))
info: at interp_runtime_invoke (interp_runtime_invoke (wasm://wasm/0dec238a:wasm-function[90052]:0x16bc9da))
info: at mono_jit_runtime_invoke (mono_jit_runtime_invoke (wasm://wasm/0dec238a:wasm-function[95289]:0x17c5028))
info: at do_runtime_invoke (do_runtime_invoke (wasm://wasm/0dec238a:wasm-function[94085]:0x178e3d3))
info: at mono_runtime_invoke_checked (mono_runtime_invoke_checked (wasm://wasm/0dec238a:wasm-function[94084]:0x178e38f))
info: at mono_runtime_install_appctx_properties (mono_runtime_install_appctx_properties (wasm://wasm/0dec238a:wasm-function[91526]:0x17054e4))
info: at mono_runtime_init_checked (mono_runtime_init_checked (wasm://wasm/0dec238a:wasm-function[91521]:0x1704d4e))
info: at mini_init (mini_init (wasm://wasm/0dec238a:wasm-function[95272]:0x17c43ea))
info: at mono_jit_init_version (mono_jit_init_version (wasm://wasm/0dec238a:wasm-function[95408]:0x17ca553))
info: at mono_wasm_load_runtime (mono_wasm_load_runtime (wasm://wasm/0dec238a:wasm-function[103299]:0x1900987))
info: at Module._mono_wasm_load_runtime (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:6817:114)
info: at ccall (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:5851:22)
info: at Object.mono_wasm_load_runtime (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:5877:16)
info: at Dl (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:215804)
info: at /root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:205340
info: at /root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:206020
```
@radical
radical
commented
Sep 27, 2023

Copy link


Copy Markdown

MemberAuthor
@kg interestingly removing getWasmIndirectFunctionTable after the runtime is initialized, only failed the AOT tests here.
@radical
radical
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
Failing tests will be fixed by - #92747
@radicalradical
closed this
Sep 28, 2023
@radicalradical
reopened this
Sep 28, 2023
@carlossanlop
carlossanlop
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
@radical if this is ready, please send an email to Tactics requesting approval (unless you're waiting for @pavelsavara to approve the change first).
@carlossanlop
carlossanlop
commented
Oct 4, 2023

Copy link


Copy Markdown

Contributor
@radical@kg@pavelsavara the CI is green after the latest feedback was addressed. When you're ready, please send the email to Tactics requesting approval. And please get a code review sign-off from an area owner.
pavelsavara
pavelsavara
approved these changes
Oct 4, 2023
View reviewed changes
@pavelsavarapavelsavara
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good enough fix for Net8 (because it's low risk), but for Net9 we need better solution (because it's ugly).
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Oct 4, 2023
@radical
radical
commented
Oct 13, 2023

Copy link


Copy Markdown

MemberAuthor
This was not approved for 8.
@radicalradical
closed this
Oct 13, 2023
@radicalradical
removed
the 
Servicing-consider
Issue for next servicing release review
label
Oct 13, 2023
@radical
radical
deleted the

wasm-strip-fixes-8

branch
October 13, 2023 17:02
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 12, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@pavelsavarapavelsavarapavelsavara approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@kgkgAwaiting requested review from kg

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@kg@carlossanlop@pavelsavara

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing the - #92683
Closed
radical wants to merge 5 commits into
dotnet:release/8.0from 
radical:wasm-strip-fixes-8
Closed
[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing the#92683
radical wants to merge 5 commits into
dotnet:release/8.0from 
radical:wasm-strip-fixes-8
Conversation
@radical
@radicalradical
commented
Sep 27, 2023•

edited

Loading

Copy link


Copy Markdown

Member
.. runtime also, so it is available at that time.
Based on feedback from Katelyn Gadd.
Customer impact
Ensure that the indirect function table is available when the runtime is being initialized. This is a precautionary measure, and was not breaking any existing tests.
Testing
Unit tests.
Risk
Low.
@radical
[wasm] Define getWasmIndirectFunctionTable before intializing the
fac7b4a
.. runtime also, so it is available at that time.
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Sep 27, 2023
@ghost
ghost
commented
Sep 27, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
.. runtime also, so it is available at that time.
Based on feedback from Katelyn Gadd.
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@ghostghost
assigned radicalSep 27, 2023
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 27, 2023
@radicalradical
changed the title
[release/8.0][wasm] Define getWasmIndirectFunctionTable before intializing the[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing theSep 27, 2023
@radical
radical
marked this pull request as draft
September 27, 2023 05:21
@radicalradical
removed
the 
Servicing-consider
Issue for next servicing release review
label
Sep 27, 2023
@radical
radical
marked this pull request as ready for review
September 27, 2023 08:13
pavelsavara
pavelsavara
previously requested changes
Sep 27, 2023
View reviewed changes
@pavelsavarapavelsavara
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain the scenarios under which this is necessary ?
@ghostghost
added
the 
needs-author-action
An issue or pull request that requires more info or actions from the author.
label
Sep 27, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 27, 2023

Closed

@ghostghost
removed
the 
needs-author-action
An issue or pull request that requires more info or actions from the author.
label
Sep 27, 2023
@kg
kg
commented
Sep 27, 2023

Copy link


Copy Markdown

Contributor
Could you please explain the scenarios under which this is necessary ?
startup can engage the interpreter, which could under rare circumstances (i.e. if you set low thresholds, disable tiering) engage the jiterpreter which will need these tables
@radical
radical
commented
Sep 27, 2023

Copy link


Copy Markdown

MemberAuthor
Could you please explain the scenarios under which this is necessary ?
Address your suggestion in #92664 (comment) . I didn't change getMemory though, to match what we have in main.
@radical
Revert "address review feedback"
249d8b6
This reverts commit 4975dc3.
This caused library aot tests to fail with:
```
info: MONO_WASM: mono_wasm_load_runtime () failed TypeError: t.getWasmIndirectFunctionTable is not a function
info: MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function
info: at Ma (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:80285)
info: at Ul (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:174663)
info: at do_jit_call (do_jit_call (wasm://wasm/0dec238a:wasm-function[90022]:0x16bba99))
info: at mono_interp_exec_method (mono_interp_exec_method (wasm://wasm/0dec238a:wasm-function[90012]:0x16af791))
info: at interp_runtime_invoke (interp_runtime_invoke (wasm://wasm/0dec238a:wasm-function[90052]:0x16bc9da))
info: at mono_jit_runtime_invoke (mono_jit_runtime_invoke (wasm://wasm/0dec238a:wasm-function[95289]:0x17c5028))
info: at do_runtime_invoke (do_runtime_invoke (wasm://wasm/0dec238a:wasm-function[94085]:0x178e3d3))
info: at mono_runtime_invoke_checked (mono_runtime_invoke_checked (wasm://wasm/0dec238a:wasm-function[94084]:0x178e38f))
info: at mono_runtime_install_appctx_properties (mono_runtime_install_appctx_properties (wasm://wasm/0dec238a:wasm-function[91526]:0x17054e4))
info: at mono_runtime_init_checked (mono_runtime_init_checked (wasm://wasm/0dec238a:wasm-function[91521]:0x1704d4e))
info: at mini_init (mini_init (wasm://wasm/0dec238a:wasm-function[95272]:0x17c43ea))
info: at mono_jit_init_version (mono_jit_init_version (wasm://wasm/0dec238a:wasm-function[95408]:0x17ca553))
info: at mono_wasm_load_runtime (mono_wasm_load_runtime (wasm://wasm/0dec238a:wasm-function[103299]:0x1900987))
info: at Module._mono_wasm_load_runtime (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:6817:114)
info: at ccall (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:5851:22)
info: at Object.mono_wasm_load_runtime (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:5877:16)
info: at Dl (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:215804)
info: at /root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:205340
info: at /root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:206020
```
@radical
radical
commented
Sep 27, 2023

Copy link


Copy Markdown

MemberAuthor
@kg interestingly removing getWasmIndirectFunctionTable after the runtime is initialized, only failed the AOT tests here.
@radical
radical
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
Failing tests will be fixed by - #92747
@radicalradical
closed this
Sep 28, 2023
@radicalradical
reopened this
Sep 28, 2023
@carlossanlop
carlossanlop
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
@radical if this is ready, please send an email to Tactics requesting approval (unless you're waiting for @pavelsavara to approve the change first).
@carlossanlop
carlossanlop
commented
Oct 4, 2023

Copy link


Copy Markdown

Contributor
@radical@kg@pavelsavara the CI is green after the latest feedback was addressed. When you're ready, please send the email to Tactics requesting approval. And please get a code review sign-off from an area owner.
pavelsavara
pavelsavara
approved these changes
Oct 4, 2023
View reviewed changes
@pavelsavarapavelsavara
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good enough fix for Net8 (because it's low risk), but for Net9 we need better solution (because it's ugly).
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Oct 4, 2023
@radical
radical
commented
Oct 13, 2023

Copy link


Copy Markdown

MemberAuthor
This was not approved for 8.
@radicalradical
closed this
Oct 13, 2023
@radicalradical
removed
the 
Servicing-consider
Issue for next servicing release review
label
Oct 13, 2023
@radical
radical
deleted the

wasm-strip-fixes-8

branch
October 13, 2023 17:02
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 12, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@pavelsavarapavelsavarapavelsavara approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@kgkgAwaiting requested review from kg

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@kg@carlossanlop@pavelsavara

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing the - #92683
Closed
radical wants to merge 5 commits into
dotnet:release/8.0from 
radical:wasm-strip-fixes-8
Closed
[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing the#92683
radical wants to merge 5 commits into
dotnet:release/8.0from 
radical:wasm-strip-fixes-8
Conversation
@radical
@radicalradical
commented
Sep 27, 2023•

edited

Loading

Copy link


Copy Markdown

Member
.. runtime also, so it is available at that time.
Based on feedback from Katelyn Gadd.
Customer impact
Ensure that the indirect function table is available when the runtime is being initialized. This is a precautionary measure, and was not breaking any existing tests.
Testing
Unit tests.
Risk
Low.
@radical
[wasm] Define getWasmIndirectFunctionTable before intializing the
fac7b4a
.. runtime also, so it is available at that time.
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Sep 27, 2023
@ghost
ghost
commented
Sep 27, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
.. runtime also, so it is available at that time.
Based on feedback from Katelyn Gadd.
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@ghostghost
assigned radicalSep 27, 2023
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 27, 2023
@radicalradical
changed the title
[release/8.0][wasm] Define getWasmIndirectFunctionTable before intializing the[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing theSep 27, 2023
@radical
radical
marked this pull request as draft
September 27, 2023 05:21
@radicalradical
removed
the 
Servicing-consider
Issue for next servicing release review
label
Sep 27, 2023
@radical
radical
marked this pull request as ready for review
September 27, 2023 08:13
pavelsavara
pavelsavara
previously requested changes
Sep 27, 2023
View reviewed changes
@pavelsavarapavelsavara
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain the scenarios under which this is necessary ?
@ghostghost
added
the 
needs-author-action
An issue or pull request that requires more info or actions from the author.
label
Sep 27, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 27, 2023

Closed

@ghostghost
removed
the 
needs-author-action
An issue or pull request that requires more info or actions from the author.
label
Sep 27, 2023
@kg
kg
commented
Sep 27, 2023

Copy link


Copy Markdown

Contributor
Could you please explain the scenarios under which this is necessary ?
startup can engage the interpreter, which could under rare circumstances (i.e. if you set low thresholds, disable tiering) engage the jiterpreter which will need these tables
@radical
radical
commented
Sep 27, 2023

Copy link


Copy Markdown

MemberAuthor
Could you please explain the scenarios under which this is necessary ?
Address your suggestion in #92664 (comment) . I didn't change getMemory though, to match what we have in main.
@radical
Revert "address review feedback"
249d8b6
This reverts commit 4975dc3.
This caused library aot tests to fail with:
```
info: MONO_WASM: mono_wasm_load_runtime () failed TypeError: t.getWasmIndirectFunctionTable is not a function
info: MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function
info: at Ma (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:80285)
info: at Ul (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:174663)
info: at do_jit_call (do_jit_call (wasm://wasm/0dec238a:wasm-function[90022]:0x16bba99))
info: at mono_interp_exec_method (mono_interp_exec_method (wasm://wasm/0dec238a:wasm-function[90012]:0x16af791))
info: at interp_runtime_invoke (interp_runtime_invoke (wasm://wasm/0dec238a:wasm-function[90052]:0x16bc9da))
info: at mono_jit_runtime_invoke (mono_jit_runtime_invoke (wasm://wasm/0dec238a:wasm-function[95289]:0x17c5028))
info: at do_runtime_invoke (do_runtime_invoke (wasm://wasm/0dec238a:wasm-function[94085]:0x178e3d3))
info: at mono_runtime_invoke_checked (mono_runtime_invoke_checked (wasm://wasm/0dec238a:wasm-function[94084]:0x178e38f))
info: at mono_runtime_install_appctx_properties (mono_runtime_install_appctx_properties (wasm://wasm/0dec238a:wasm-function[91526]:0x17054e4))
info: at mono_runtime_init_checked (mono_runtime_init_checked (wasm://wasm/0dec238a:wasm-function[91521]:0x1704d4e))
info: at mini_init (mini_init (wasm://wasm/0dec238a:wasm-function[95272]:0x17c43ea))
info: at mono_jit_init_version (mono_jit_init_version (wasm://wasm/0dec238a:wasm-function[95408]:0x17ca553))
info: at mono_wasm_load_runtime (mono_wasm_load_runtime (wasm://wasm/0dec238a:wasm-function[103299]:0x1900987))
info: at Module._mono_wasm_load_runtime (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:6817:114)
info: at ccall (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:5851:22)
info: at Object.mono_wasm_load_runtime (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:5877:16)
info: at Dl (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:215804)
info: at /root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:205340
info: at /root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:206020
```
@radical
radical
commented
Sep 27, 2023

Copy link


Copy Markdown

MemberAuthor
@kg interestingly removing getWasmIndirectFunctionTable after the runtime is initialized, only failed the AOT tests here.
@radical
radical
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
Failing tests will be fixed by - #92747
@radicalradical
closed this
Sep 28, 2023
@radicalradical
reopened this
Sep 28, 2023
@carlossanlop
carlossanlop
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
@radical if this is ready, please send an email to Tactics requesting approval (unless you're waiting for @pavelsavara to approve the change first).
@carlossanlop
carlossanlop
commented
Oct 4, 2023

Copy link


Copy Markdown

Contributor
@radical@kg@pavelsavara the CI is green after the latest feedback was addressed. When you're ready, please send the email to Tactics requesting approval. And please get a code review sign-off from an area owner.
pavelsavara
pavelsavara
approved these changes
Oct 4, 2023
View reviewed changes
@pavelsavarapavelsavara
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good enough fix for Net8 (because it's low risk), but for Net9 we need better solution (because it's ugly).
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Oct 4, 2023
@radical
radical
commented
Oct 13, 2023

Copy link


Copy Markdown

MemberAuthor
This was not approved for 8.
@radicalradical
closed this
Oct 13, 2023
@radicalradical
removed
the 
Servicing-consider
Issue for next servicing release review
label
Oct 13, 2023
@radical
radical
deleted the

wasm-strip-fixes-8

branch
October 13, 2023 17:02
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 12, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@pavelsavarapavelsavarapavelsavara approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@kgkgAwaiting requested review from kg

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@kg@carlossanlop@pavelsavara

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing the - #92683
Closed
radical wants to merge 5 commits into
dotnet:release/8.0from 
radical:wasm-strip-fixes-8
Closed
[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing the#92683
radical wants to merge 5 commits into
dotnet:release/8.0from 
radical:wasm-strip-fixes-8
Conversation
@radical
@radicalradical
commented
Sep 27, 2023•

edited

Loading

Copy link


Copy Markdown

Member
.. runtime also, so it is available at that time.
Based on feedback from Katelyn Gadd.
Customer impact
Ensure that the indirect function table is available when the runtime is being initialized. This is a precautionary measure, and was not breaking any existing tests.
Testing
Unit tests.
Risk
Low.
@radical
[wasm] Define getWasmIndirectFunctionTable before intializing the
fac7b4a
.. runtime also, so it is available at that time.
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Sep 27, 2023
@ghost
ghost
commented
Sep 27, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
.. runtime also, so it is available at that time.
Based on feedback from Katelyn Gadd.
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@ghostghost
assigned radicalSep 27, 2023
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 27, 2023
@radicalradical
changed the title
[release/8.0][wasm] Define getWasmIndirectFunctionTable before intializing the[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing theSep 27, 2023
@radical
radical
marked this pull request as draft
September 27, 2023 05:21
@radicalradical
removed
the 
Servicing-consider
Issue for next servicing release review
label
Sep 27, 2023
@radical
radical
marked this pull request as ready for review
September 27, 2023 08:13
pavelsavara
pavelsavara
previously requested changes
Sep 27, 2023
View reviewed changes
@pavelsavarapavelsavara
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain the scenarios under which this is necessary ?
@ghostghost
added
the 
needs-author-action
An issue or pull request that requires more info or actions from the author.
label
Sep 27, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 27, 2023

Closed

@ghostghost
removed
the 
needs-author-action
An issue or pull request that requires more info or actions from the author.
label
Sep 27, 2023
@kg
kg
commented
Sep 27, 2023

Copy link


Copy Markdown

Contributor
Could you please explain the scenarios under which this is necessary ?
startup can engage the interpreter, which could under rare circumstances (i.e. if you set low thresholds, disable tiering) engage the jiterpreter which will need these tables
@radical
radical
commented
Sep 27, 2023

Copy link


Copy Markdown

MemberAuthor
Could you please explain the scenarios under which this is necessary ?
Address your suggestion in #92664 (comment) . I didn't change getMemory though, to match what we have in main.
@radical
Revert "address review feedback"
249d8b6
This reverts commit 4975dc3.
This caused library aot tests to fail with:
```
info: MONO_WASM: mono_wasm_load_runtime () failed TypeError: t.getWasmIndirectFunctionTable is not a function
info: MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function
info: at Ma (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:80285)
info: at Ul (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:174663)
info: at do_jit_call (do_jit_call (wasm://wasm/0dec238a:wasm-function[90022]:0x16bba99))
info: at mono_interp_exec_method (mono_interp_exec_method (wasm://wasm/0dec238a:wasm-function[90012]:0x16af791))
info: at interp_runtime_invoke (interp_runtime_invoke (wasm://wasm/0dec238a:wasm-function[90052]:0x16bc9da))
info: at mono_jit_runtime_invoke (mono_jit_runtime_invoke (wasm://wasm/0dec238a:wasm-function[95289]:0x17c5028))
info: at do_runtime_invoke (do_runtime_invoke (wasm://wasm/0dec238a:wasm-function[94085]:0x178e3d3))
info: at mono_runtime_invoke_checked (mono_runtime_invoke_checked (wasm://wasm/0dec238a:wasm-function[94084]:0x178e38f))
info: at mono_runtime_install_appctx_properties (mono_runtime_install_appctx_properties (wasm://wasm/0dec238a:wasm-function[91526]:0x17054e4))
info: at mono_runtime_init_checked (mono_runtime_init_checked (wasm://wasm/0dec238a:wasm-function[91521]:0x1704d4e))
info: at mini_init (mini_init (wasm://wasm/0dec238a:wasm-function[95272]:0x17c43ea))
info: at mono_jit_init_version (mono_jit_init_version (wasm://wasm/0dec238a:wasm-function[95408]:0x17ca553))
info: at mono_wasm_load_runtime (mono_wasm_load_runtime (wasm://wasm/0dec238a:wasm-function[103299]:0x1900987))
info: at Module._mono_wasm_load_runtime (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:6817:114)
info: at ccall (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:5851:22)
info: at Object.mono_wasm_load_runtime (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:5877:16)
info: at Dl (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:215804)
info: at /root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:205340
info: at /root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:206020
```
@radical
radical
commented
Sep 27, 2023

Copy link


Copy Markdown

MemberAuthor
@kg interestingly removing getWasmIndirectFunctionTable after the runtime is initialized, only failed the AOT tests here.
@radical
radical
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
Failing tests will be fixed by - #92747
@radicalradical
closed this
Sep 28, 2023
@radicalradical
reopened this
Sep 28, 2023
@carlossanlop
carlossanlop
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
@radical if this is ready, please send an email to Tactics requesting approval (unless you're waiting for @pavelsavara to approve the change first).
@carlossanlop
carlossanlop
commented
Oct 4, 2023

Copy link


Copy Markdown

Contributor
@radical@kg@pavelsavara the CI is green after the latest feedback was addressed. When you're ready, please send the email to Tactics requesting approval. And please get a code review sign-off from an area owner.
pavelsavara
pavelsavara
approved these changes
Oct 4, 2023
View reviewed changes
@pavelsavarapavelsavara
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good enough fix for Net8 (because it's low risk), but for Net9 we need better solution (because it's ugly).
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Oct 4, 2023
@radical
radical
commented
Oct 13, 2023

Copy link


Copy Markdown

MemberAuthor
This was not approved for 8.
@radicalradical
closed this
Oct 13, 2023
@radicalradical
removed
the 
Servicing-consider
Issue for next servicing release review
label
Oct 13, 2023
@radical
radical
deleted the

wasm-strip-fixes-8

branch
October 13, 2023 17:02
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 12, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@pavelsavarapavelsavarapavelsavara approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@kgkgAwaiting requested review from kg

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@kg@carlossanlop@pavelsavara

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing the - #92683
Closed
radical wants to merge 5 commits into
dotnet:release/8.0from 
radical:wasm-strip-fixes-8
Closed
[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing the#92683
radical wants to merge 5 commits into
dotnet:release/8.0from 
radical:wasm-strip-fixes-8
Conversation
@radical
@radicalradical
commented
Sep 27, 2023•

edited

Loading

Copy link


Copy Markdown

Member
.. runtime also, so it is available at that time.
Based on feedback from Katelyn Gadd.
Customer impact
Ensure that the indirect function table is available when the runtime is being initialized. This is a precautionary measure, and was not breaking any existing tests.
Testing
Unit tests.
Risk
Low.
@radical
[wasm] Define getWasmIndirectFunctionTable before intializing the
fac7b4a
.. runtime also, so it is available at that time.
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Sep 27, 2023
@ghost
ghost
commented
Sep 27, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
.. runtime also, so it is available at that time.
Based on feedback from Katelyn Gadd.
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@ghostghost
assigned radicalSep 27, 2023
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Sep 27, 2023
@radicalradical
changed the title
[release/8.0][wasm] Define getWasmIndirectFunctionTable before intializing the[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing theSep 27, 2023
@radical
radical
marked this pull request as draft
September 27, 2023 05:21
@radicalradical
removed
the 
Servicing-consider
Issue for next servicing release review
label
Sep 27, 2023
@radical
radical
marked this pull request as ready for review
September 27, 2023 08:13
pavelsavara
pavelsavara
previously requested changes
Sep 27, 2023
View reviewed changes
@pavelsavarapavelsavara
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain the scenarios under which this is necessary ?
@ghostghost
added
the 
needs-author-action
An issue or pull request that requires more info or actions from the author.
label
Sep 27, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 27, 2023

Closed

@ghostghost
removed
the 
needs-author-action
An issue or pull request that requires more info or actions from the author.
label
Sep 27, 2023
@kg
kg
commented
Sep 27, 2023

Copy link


Copy Markdown

Contributor
Could you please explain the scenarios under which this is necessary ?
startup can engage the interpreter, which could under rare circumstances (i.e. if you set low thresholds, disable tiering) engage the jiterpreter which will need these tables
@radical
radical
commented
Sep 27, 2023

Copy link


Copy Markdown

MemberAuthor
Could you please explain the scenarios under which this is necessary ?
Address your suggestion in #92664 (comment) . I didn't change getMemory though, to match what we have in main.
@radical
Revert "address review feedback"
249d8b6
This reverts commit 4975dc3.
This caused library aot tests to fail with:
```
info: MONO_WASM: mono_wasm_load_runtime () failed TypeError: t.getWasmIndirectFunctionTable is not a function
info: MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function
info: at Ma (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:80285)
info: at Ul (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:174663)
info: at do_jit_call (do_jit_call (wasm://wasm/0dec238a:wasm-function[90022]:0x16bba99))
info: at mono_interp_exec_method (mono_interp_exec_method (wasm://wasm/0dec238a:wasm-function[90012]:0x16af791))
info: at interp_runtime_invoke (interp_runtime_invoke (wasm://wasm/0dec238a:wasm-function[90052]:0x16bc9da))
info: at mono_jit_runtime_invoke (mono_jit_runtime_invoke (wasm://wasm/0dec238a:wasm-function[95289]:0x17c5028))
info: at do_runtime_invoke (do_runtime_invoke (wasm://wasm/0dec238a:wasm-function[94085]:0x178e3d3))
info: at mono_runtime_invoke_checked (mono_runtime_invoke_checked (wasm://wasm/0dec238a:wasm-function[94084]:0x178e38f))
info: at mono_runtime_install_appctx_properties (mono_runtime_install_appctx_properties (wasm://wasm/0dec238a:wasm-function[91526]:0x17054e4))
info: at mono_runtime_init_checked (mono_runtime_init_checked (wasm://wasm/0dec238a:wasm-function[91521]:0x1704d4e))
info: at mini_init (mini_init (wasm://wasm/0dec238a:wasm-function[95272]:0x17c43ea))
info: at mono_jit_init_version (mono_jit_init_version (wasm://wasm/0dec238a:wasm-function[95408]:0x17ca553))
info: at mono_wasm_load_runtime (mono_wasm_load_runtime (wasm://wasm/0dec238a:wasm-function[103299]:0x1900987))
info: at Module._mono_wasm_load_runtime (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:6817:114)
info: at ccall (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:5851:22)
info: at Object.mono_wasm_load_runtime (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.native.js:5877:16)
info: at Dl (/root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:215804)
info: at /root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:205340
info: at /root/helix/work/workitem/e/wasm_build/AppBundle/_framework/dotnet.runtime.js:3:206020
```
@radical
radical
commented
Sep 27, 2023

Copy link


Copy Markdown

MemberAuthor
@kg interestingly removing getWasmIndirectFunctionTable after the runtime is initialized, only failed the AOT tests here.
@radical
radical
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
Failing tests will be fixed by - #92747
@radicalradical
closed this
Sep 28, 2023
@radicalradical
reopened this
Sep 28, 2023
@carlossanlop
carlossanlop
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
@radical if this is ready, please send an email to Tactics requesting approval (unless you're waiting for @pavelsavara to approve the change first).
@carlossanlop
carlossanlop
commented
Oct 4, 2023

Copy link


Copy Markdown

Contributor
@radical@kg@pavelsavara the CI is green after the latest feedback was addressed. When you're ready, please send the email to Tactics requesting approval. And please get a code review sign-off from an area owner.
pavelsavara
pavelsavara
approved these changes
Oct 4, 2023
View reviewed changes
@pavelsavarapavelsavara
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good enough fix for Net8 (because it's low risk), but for Net9 we need better solution (because it's ugly).
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Oct 4, 2023
@radical
radical
commented
Oct 13, 2023

Copy link


Copy Markdown

MemberAuthor
This was not approved for 8.
@radicalradical
closed this
Oct 13, 2023
@radicalradical
removed
the 
Servicing-consider
Issue for next servicing release review
label
Oct 13, 2023
@radical
radical
deleted the

wasm-strip-fixes-8

branch
October 13, 2023 17:02
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 12, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@pavelsavarapavelsavarapavelsavara approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@kgkgAwaiting requested review from kg

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@kg@carlossanlop@pavelsavara