[wasm] Fix regressed file sizes for blazor - #92664

Merged
radical merged 28 commits into
dotnet:mainfrom
radical:wasm-native-strip-main
Dec 6, 2023
Merged

[wasm] Fix regressed file sizes for blazor#92664
radical merged 28 commits into
dotnet:mainfrom
radical:wasm-native-strip-main

Conversation

@radical

@radicalradical commented Sep 26, 2023•
edited
Loading

Copy link
Copy Markdown
Member

[wasm] build: Revert to older behavior for WasmNativeStrip

The earlier change was done in 26ae097,
which changed to pass -g to the link step also. But that resulted in
increased native file sizes.

  • [wasm] Add getter for __indirect_function_table
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect

Issue: Issue: dotnet/perf-autofiling-issues#20642

@radical
[wasm] Add getter for __indirect_function_table
70a900e
.. so that can work even if it gets renamed during minimization.
@radical
[wasm] build: Revert to older behavior for WasmNativeStrip
bd97094
The earlier change was done in 678fd6a,
which changed to pass `-g` to the link step also. But that resulted in
increased native file sizes.
Changed sizes for the `minimum blazor template - publish` scenario:
```
| Last rc1 run | With the change
----------------------------------------------------------|----------------- |------------------
SOD - Minimum Blazor Template - Publish |8590723.000 bytes |7889806.000 bytes
Total Uncompressed _framework |4304274.000 bytes |4202273.000 bytes
pub/wwwroot/_framework/dotnet.js |35722.000 bytes |35838.000 bytes
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js |239307.000 bytes |134566.000 bytes
pub/wwwroot/_framework/dotnet.native.wasm |1174394.000 bytes |1148841.000 bytes
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js |221356.000 bytes |221712.000 bytes
```
(cherry picked from commit ae93e81)
@radical
[wasm] cleanup corresponding tests
d84ecf9
(cherry picked from commit 0207d60)
@radical
[wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
dd5fc7c
(cherry picked from commit 91379dd)
@radicalradical added the arch-wasm WebAssembly architecture label Sep 26, 2023
@ghostghost added the area-Build-mono label Sep 26, 2023
@ghostghost assigned radicalSep 26, 2023
@ghost

ghost commented Sep 26, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • [wasm] Add getter for __indirect_function_table
  • [wasm] build: Revert to older behavior for WasmNativeStrip
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Author:radical
Assignees:-
Labels:

arch-wasm

Milestone:-

@radicalradical changed the title wasm native strip main[wasm] Fix regressed file sizes for blazorSep 26, 2023
@radical

radical commented Sep 26, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm-perf

@azure-pipelines

azure-pipelinesBot commented Sep 26, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

kg
kg reviewed Sep 27, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/types/internal.ts Outdated
kg
kg reviewed Sep 27, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/es6/dotnet.es6.pre.js
kg
kg approved these changes Sep 27, 2023
View reviewed changes
This was referenced Sep 27, 2023
Open
Closed
@radicalradical mentioned this pull request Sep 27, 2023
Closed
@radical

radical commented Sep 27, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

After the change to move getWasmIndirectFunctionTable to only be before the runtime is created, library all the tests are failing with:

fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"

log.

@kg

kg commented Sep 27, 2023

Copy link
Copy Markdown
Contributor

After the change to move getWasmIndirectFunctionTable to only be before the runtime is created, library all the tests are failing with:

fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"

log.

I guess I put it in both places because it was actually necessary, and I forgot :-)

@radical
Revert "address review feedback"
b36d205
This reverts commit 68e954d.
This caused tests to fail with:
```
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"
```
@radical
Merge remote-tracking branch 'origin/main' into wasm-native-strip-main
44d6bc3
@radical
Merge branch 'dotnet:main' into wasm-native-strip-main
85c0af8
This was referenced Nov 8, 2023
Closed
Closed
@pavelsavara

pavelsavara commented Nov 29, 2023

Copy link
Copy Markdown
Member

need help ?

@radical

radical commented Nov 29, 2023

Copy link
Copy Markdown
MemberAuthor

need help ?

Any suggestions on a fix? The alternative would be to disable the failing tests which are essentially for Debug+AOT, and Debug+relink. We could ignore debug+aot for now, but debug+relink is likely more common because we would relink if you had any native references too.

But this PR will help the sizes.

@pavelsavara

pavelsavara commented Nov 30, 2023

Copy link
Copy Markdown
Member

Any suggestions on a fix?

Still this, right ?

Wasm.Build.Tests.Blazor.SimpleRunTests.BlazorPublishRunTest(config: "Debug", aot: True) [FAIL]
[error] MONO_WASM: onRuntimeInitializedAsync() failed Error: raw cwrap mono_jiterp_placeholder_trace not found
at Ir (http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:58604)
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:214838
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:215122

@radical

radical commented Nov 30, 2023

Copy link
Copy Markdown
MemberAuthor

Any suggestions on a fix?

Still this, right ?


Wasm.Build.Tests.Blazor.SimpleRunTests.BlazorPublishRunTest(config: "Debug", aot: True) [FAIL]
[error] MONO_WASM: onRuntimeInitializedAsync() failed Error: raw cwrap mono_jiterp_placeholder_trace not found
at Ir (http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:58604)
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:214838
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:215122

Yes

@pavelsavara

pavelsavara commented Nov 30, 2023

Copy link
Copy Markdown
Member

I have this untested theory:

I think this is not about AOT, but about WasmBuildNative being triggered with some optimization level which mangles symbols.

It fails in getRawCwrap which uses un-mangled symbol names.
mono_jiterp_placeholder_trace is just coincidence, because it's the first thing requested.

We have this un-mangling logic in createWasmImportStubsFrom and replace_linker_placeholders for wasm imports. Maybe we need same thing for wasm exports ?

@pavelsavara

pavelsavara commented Nov 30, 2023

Copy link
Copy Markdown
Member

Printing full list of Module["asm"] would help to debug it.

@radical

radical commented Nov 30, 2023

Copy link
Copy Markdown
MemberAuthor

Relink/aot with an optimization level and -g . This happens only for debug config.

Dunno about the details that you mentioned.

@pavelsavarapavelsavara mentioned this pull request Dec 5, 2023
Merged
@radical

radical commented Dec 6, 2023

Copy link
Copy Markdown
MemberAuthor

#95613 seems to have fixed the failures! Thanks @kg, @pavelsavara!

@radical

radical commented Dec 6, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Dec 6, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical

radical commented Dec 6, 2023

Copy link
Copy Markdown
MemberAuthor

@microsoft-github-policy-service rerun

This was referenced Dec 6, 2023
Open
Closed
@radical

radical commented Dec 6, 2023

Copy link
Copy Markdown
MemberAuthor

Failures are known issues.

@radical

radical commented Dec 6, 2023

Copy link
Copy Markdown
MemberAuthor

@microsoft-github-policy-service rerun

@radical

radical commented Dec 6, 2023

Copy link
Copy Markdown
MemberAuthor

@dotnet-github-policy-service rerun

@radical

radical commented Dec 6, 2023

Copy link
Copy Markdown
MemberAuthor

@dotnet-policy-service rerun

@radical
radical merged commit ec31705 into dotnet:mainDec 6, 2023
@radical
radical deleted the wasm-native-strip-main branch December 6, 2023 10:37
@radekdoulik

radekdoulik commented Dec 7, 2023•
edited
Loading

Copy link
Copy Markdown
Member

great work
image

radical added a commit to radical/runtime that referenced this pull request Dec 14, 2023
@radical
[wasm/wasi] Fix size regression
b72c3ae
Blazor size regression was fixed by:
```
commit ec31705
Author: Ankit Jain <radical@gmail.com>
Date: Wed Dec 6 05:36:59 2023 -0500
[wasm] Fix regressed file sizes for blazor (dotnet#92664)
```
.. but a subsequent PR created close to that undid some of the changes:
```
commit a128c15
Author: Ankit Jain <radical@gmail.com>
Date: Mon Dec 11 15:45:58 2023 -0500
[wasm/wasi] Consolidate build targets (dotnet#95775)
```
Essentially, `-g` was being passed to the link, and compile-bc steps.
Found in dotnet/perf-autofiling-issues#25891 .
radical added a commit that referenced this pull request Dec 14, 2023
@radical
[wasm/wasi] Fix size regression (#95992)
f59ef7f
* [wasm/wasi] Fix size regression
Blazor size regression was fixed by:
```
commit ec31705
Author: Ankit Jain <radical@gmail.com>
Date: Wed Dec 6 05:36:59 2023 -0500
[wasm] Fix regressed file sizes for blazor (#92664)
```
.. but a subsequent PR created close to that undid some of the changes:
```
commit a128c15
Author: Ankit Jain <radical@gmail.com>
Date: Mon Dec 11 15:45:58 2023 -0500
[wasm/wasi] Consolidate build targets (#95775)
```
Essentially, `-g` was being passed to the link, and compile-bc steps.
Found in dotnet/perf-autofiling-issues#25891 .
* [wasm] Add flag missed in the consolidate PR
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jan 7, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewinglewinglewing left review comments
@pavelsavarapavelsavarapavelsavara approved these changes
+1 more reviewer
@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@radical@kg@pavelsavara@radekdoulik@lewing
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[wasm] Fix regressed file sizes for blazor - #92664
Merged
radical merged 28 commits into
dotnet:mainfrom 
radical:wasm-native-strip-main
Dec 6, 2023
Merged
[wasm] Fix regressed file sizes for blazor#92664
radical merged 28 commits into
dotnet:mainfrom 
radical:wasm-native-strip-main
Conversation
@radical
@radicalradical
commented
Sep 26, 2023•

edited

Loading

Copy link


Copy Markdown

Member
[wasm] build: Revert to older behavior for WasmNativeStrip
The earlier change was done in 26ae097,

which changed to pass -g to the link step also. But that resulted in

increased native file sizes.
  • [wasm] Add getter for __indirect_function_table
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Issue: Issue: dotnet/perf-autofiling-issues#20642
@radical
[wasm] Add getter for __indirect_function_table
70a900e
.. so that can work even if it gets renamed during minimization.
@radical
[wasm] build: Revert to older behavior for WasmNativeStrip
bd97094
The earlier change was done in 678fd6a,
which changed to pass `-g` to the link step also. But that resulted in
increased native file sizes.
Changed sizes for the `minimum blazor template - publish` scenario:
```
| Last rc1 run | With the change
----------------------------------------------------------|----------------- |------------------
SOD - Minimum Blazor Template - Publish |8590723.000 bytes |7889806.000 bytes
Total Uncompressed _framework |4304274.000 bytes |4202273.000 bytes
pub/wwwroot/_framework/dotnet.js |35722.000 bytes |35838.000 bytes
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js |239307.000 bytes |134566.000 bytes
pub/wwwroot/_framework/dotnet.native.wasm |1174394.000 bytes |1148841.000 bytes
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js |221356.000 bytes |221712.000 bytes
```
(cherry picked from commit ae93e81)
@radical
[wasm] cleanup corresponding tests
d84ecf9
(cherry picked from commit 0207d60)
@radical
[wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
dd5fc7c
(cherry picked from commit 91379dd)
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Sep 26, 2023
@ghostghost
added
the 
area-Build-mono

label
Sep 26, 2023
@ghostghost
assigned radicalSep 26, 2023
@ghost
ghost
commented
Sep 26, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • [wasm] Add getter for __indirect_function_table
  • [wasm] build: Revert to older behavior for WasmNativeStrip
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radicalradical
changed the title
wasm native strip main[wasm] Fix regressed file sizes for blazorSep 26, 2023
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm-perf
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Sep 27, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/types/internal.ts
Outdated

kg
kg
reviewed
Sep 27, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/es6/dotnet.es6.pre.js
kg
kg
approved these changes
Sep 27, 2023
View reviewed changes

This was referenced Sep 27, 2023

Open


Closed

@radicalradical
mentioned this pull request
Sep 27, 2023
 Closed

@radical
radical
commented
Sep 27, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
After the change to move getWasmIndirectFunctionTable to only be before the runtime is created, library all the tests are failing with:
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"

log.
@kg
kg
commented
Sep 27, 2023

Copy link


Copy Markdown

Contributor
After the change to move getWasmIndirectFunctionTable to only be before the runtime is created, library all the tests are failing with:
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"

log.
I guess I put it in both places because it was actually necessary, and I forgot :-)
@radical
Revert "address review feedback"
b36d205
This reverts commit 68e954d.
This caused tests to fail with:
```
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"
```
@radical
Merge remote-tracking branch 'origin/main' into wasm-native-strip-main
44d6bc3
@radical
Merge branch 'dotnet:main' into wasm-native-strip-main
85c0af8

This was referenced Nov 8, 2023

Closed


Closed

@pavelsavara
pavelsavara
commented
Nov 29, 2023

Copy link


Copy Markdown

Member
need help ?
@radical
radical
commented
Nov 29, 2023

Copy link


Copy Markdown

MemberAuthor
need help ?
Any suggestions on a fix? The alternative would be to disable the failing tests which are essentially for Debug+AOT, and Debug+relink. We could ignore debug+aot for now, but debug+relink is likely more common because we would relink if you had any native references too.
But this PR will help the sizes.
@pavelsavara
pavelsavara
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
Any suggestions on a fix?
Still this, right ?
Wasm.Build.Tests.Blazor.SimpleRunTests.BlazorPublishRunTest(config: "Debug", aot: True) [FAIL]
[error] MONO_WASM: onRuntimeInitializedAsync() failed Error: raw cwrap mono_jiterp_placeholder_trace not found
at Ir (http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:58604)
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:214838
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:215122

@radical
radical
commented
Nov 30, 2023

Copy link


Copy Markdown

MemberAuthor
Any suggestions on a fix?
Still this, right ?

Wasm.Build.Tests.Blazor.SimpleRunTests.BlazorPublishRunTest(config: "Debug", aot: True) [FAIL]
[error] MONO_WASM: onRuntimeInitializedAsync() failed Error: raw cwrap mono_jiterp_placeholder_trace not found
at Ir (http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:58604)
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:214838
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:215122

Yes
@pavelsavara
pavelsavara
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
I have this untested theory:
I think this is not about AOT, but about WasmBuildNative being triggered with some optimization level which mangles symbols.
It fails in getRawCwrap which uses un-mangled symbol names.
mono_jiterp_placeholder_trace is just coincidence, because it's the first thing requested.
We have this un-mangling logic in createWasmImportStubsFrom and replace_linker_placeholders for wasm imports. Maybe we need same thing for wasm exports ?
@pavelsavara
pavelsavara
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
Printing full list of Module["asm"] would help to debug it.
@radical
radical
commented
Nov 30, 2023

Copy link


Copy Markdown

MemberAuthor
Relink/aot with an optimization level and -g . This happens only for debug config.
Dunno about the details that you mentioned.
@pavelsavarapavelsavara
mentioned this pull request
Dec 5, 2023
 Merged

@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
#95613 seems to have fixed the failures! Thanks @kg, @pavelsavara!
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 6, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@microsoft-github-policy-service rerun

This was referenced Dec 6, 2023

Open


Closed

@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
Failures are known issues.
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@microsoft-github-policy-service rerun
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@dotnet-github-policy-service rerun
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@dotnet-policy-service rerun
@radical
radical
merged commit ec31705
into
dotnet:mainDec 6, 2023
@radical
radical
deleted the

wasm-native-strip-main

branch
December 6, 2023 10:37
@radekdoulik
radekdoulik
commented
Dec 7, 2023•

edited

Loading

Copy link


Copy Markdown

Member
great work
image
radical added a commit
to radical/runtime
that referenced
this pull request
Dec 14, 2023
@radical
[wasm/wasi] Fix size regression
b72c3ae
Blazor size regression was fixed by:
```
commit ec31705
Author: Ankit Jain <radical@gmail.com>
Date: Wed Dec 6 05:36:59 2023 -0500
[wasm] Fix regressed file sizes for blazor (dotnet#92664)
```
.. but a subsequent PR created close to that undid some of the changes:
```
commit a128c15
Author: Ankit Jain <radical@gmail.com>
Date: Mon Dec 11 15:45:58 2023 -0500
[wasm/wasi] Consolidate build targets (dotnet#95775)
```
Essentially, `-g` was being passed to the link, and compile-bc steps.
Found in dotnet/perf-autofiling-issues#25891 .
radical added a commit
that referenced
this pull request
Dec 14, 2023
@radical
[wasm/wasi] Fix size regression (#95992)
f59ef7f
* [wasm/wasi] Fix size regression
Blazor size regression was fixed by:
```
commit ec31705
Author: Ankit Jain <radical@gmail.com>
Date: Wed Dec 6 05:36:59 2023 -0500
[wasm] Fix regressed file sizes for blazor (#92664)
```
.. but a subsequent PR created close to that undid some of the changes:
```
commit a128c15
Author: Ankit Jain <radical@gmail.com>
Date: Mon Dec 11 15:45:58 2023 -0500
[wasm/wasi] Consolidate build targets (#95775)
```
Essentially, `-g` was being passed to the link, and compile-bc steps.
Found in dotnet/perf-autofiling-issues#25891 .
* [wasm] Add flag missed in the consolidate PR
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jan 7, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing left review comments
@pavelsavarapavelsavarapavelsavara approved these changes

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@radical@kg@pavelsavara@radekdoulik@lewing

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[wasm] Fix regressed file sizes for blazor - #92664
Merged
radical merged 28 commits into
dotnet:mainfrom 
radical:wasm-native-strip-main
Dec 6, 2023
Merged
[wasm] Fix regressed file sizes for blazor#92664
radical merged 28 commits into
dotnet:mainfrom 
radical:wasm-native-strip-main
Conversation
@radical
@radicalradical
commented
Sep 26, 2023•

edited

Loading

Copy link


Copy Markdown

Member
[wasm] build: Revert to older behavior for WasmNativeStrip
The earlier change was done in 26ae097,

which changed to pass -g to the link step also. But that resulted in

increased native file sizes.
  • [wasm] Add getter for __indirect_function_table
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Issue: Issue: dotnet/perf-autofiling-issues#20642
@radical
[wasm] Add getter for __indirect_function_table
70a900e
.. so that can work even if it gets renamed during minimization.
@radical
[wasm] build: Revert to older behavior for WasmNativeStrip
bd97094
The earlier change was done in 678fd6a,
which changed to pass `-g` to the link step also. But that resulted in
increased native file sizes.
Changed sizes for the `minimum blazor template - publish` scenario:
```
| Last rc1 run | With the change
----------------------------------------------------------|----------------- |------------------
SOD - Minimum Blazor Template - Publish |8590723.000 bytes |7889806.000 bytes
Total Uncompressed _framework |4304274.000 bytes |4202273.000 bytes
pub/wwwroot/_framework/dotnet.js |35722.000 bytes |35838.000 bytes
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js |239307.000 bytes |134566.000 bytes
pub/wwwroot/_framework/dotnet.native.wasm |1174394.000 bytes |1148841.000 bytes
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js |221356.000 bytes |221712.000 bytes
```
(cherry picked from commit ae93e81)
@radical
[wasm] cleanup corresponding tests
d84ecf9
(cherry picked from commit 0207d60)
@radical
[wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
dd5fc7c
(cherry picked from commit 91379dd)
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Sep 26, 2023
@ghostghost
added
the 
area-Build-mono

label
Sep 26, 2023
@ghostghost
assigned radicalSep 26, 2023
@ghost
ghost
commented
Sep 26, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • [wasm] Add getter for __indirect_function_table
  • [wasm] build: Revert to older behavior for WasmNativeStrip
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radicalradical
changed the title
wasm native strip main[wasm] Fix regressed file sizes for blazorSep 26, 2023
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm-perf
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Sep 27, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/types/internal.ts
Outdated

kg
kg
reviewed
Sep 27, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/es6/dotnet.es6.pre.js
kg
kg
approved these changes
Sep 27, 2023
View reviewed changes

This was referenced Sep 27, 2023

Open


Closed

@radicalradical
mentioned this pull request
Sep 27, 2023
 Closed

@radical
radical
commented
Sep 27, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
After the change to move getWasmIndirectFunctionTable to only be before the runtime is created, library all the tests are failing with:
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"

log.
@kg
kg
commented
Sep 27, 2023

Copy link


Copy Markdown

Contributor
After the change to move getWasmIndirectFunctionTable to only be before the runtime is created, library all the tests are failing with:
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"

log.
I guess I put it in both places because it was actually necessary, and I forgot :-)
@radical
Revert "address review feedback"
b36d205
This reverts commit 68e954d.
This caused tests to fail with:
```
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"
```
@radical
Merge remote-tracking branch 'origin/main' into wasm-native-strip-main
44d6bc3
@radical
Merge branch 'dotnet:main' into wasm-native-strip-main
85c0af8

This was referenced Nov 8, 2023

Closed


Closed

@pavelsavara
pavelsavara
commented
Nov 29, 2023

Copy link


Copy Markdown

Member
need help ?
@radical
radical
commented
Nov 29, 2023

Copy link


Copy Markdown

MemberAuthor
need help ?
Any suggestions on a fix? The alternative would be to disable the failing tests which are essentially for Debug+AOT, and Debug+relink. We could ignore debug+aot for now, but debug+relink is likely more common because we would relink if you had any native references too.
But this PR will help the sizes.
@pavelsavara
pavelsavara
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
Any suggestions on a fix?
Still this, right ?
Wasm.Build.Tests.Blazor.SimpleRunTests.BlazorPublishRunTest(config: "Debug", aot: True) [FAIL]
[error] MONO_WASM: onRuntimeInitializedAsync() failed Error: raw cwrap mono_jiterp_placeholder_trace not found
at Ir (http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:58604)
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:214838
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:215122

@radical
radical
commented
Nov 30, 2023

Copy link


Copy Markdown

MemberAuthor
Any suggestions on a fix?
Still this, right ?

Wasm.Build.Tests.Blazor.SimpleRunTests.BlazorPublishRunTest(config: "Debug", aot: True) [FAIL]
[error] MONO_WASM: onRuntimeInitializedAsync() failed Error: raw cwrap mono_jiterp_placeholder_trace not found
at Ir (http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:58604)
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:214838
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:215122

Yes
@pavelsavara
pavelsavara
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
I have this untested theory:
I think this is not about AOT, but about WasmBuildNative being triggered with some optimization level which mangles symbols.
It fails in getRawCwrap which uses un-mangled symbol names.
mono_jiterp_placeholder_trace is just coincidence, because it's the first thing requested.
We have this un-mangling logic in createWasmImportStubsFrom and replace_linker_placeholders for wasm imports. Maybe we need same thing for wasm exports ?
@pavelsavara
pavelsavara
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
Printing full list of Module["asm"] would help to debug it.
@radical
radical
commented
Nov 30, 2023

Copy link


Copy Markdown

MemberAuthor
Relink/aot with an optimization level and -g . This happens only for debug config.
Dunno about the details that you mentioned.
@pavelsavarapavelsavara
mentioned this pull request
Dec 5, 2023
 Merged

@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
#95613 seems to have fixed the failures! Thanks @kg, @pavelsavara!
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 6, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@microsoft-github-policy-service rerun

This was referenced Dec 6, 2023

Open


Closed

@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
Failures are known issues.
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@microsoft-github-policy-service rerun
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@dotnet-github-policy-service rerun
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@dotnet-policy-service rerun
@radical
radical
merged commit ec31705
into
dotnet:mainDec 6, 2023
@radical
radical
deleted the

wasm-native-strip-main

branch
December 6, 2023 10:37
@radekdoulik
radekdoulik
commented
Dec 7, 2023•

edited

Loading

Copy link


Copy Markdown

Member
great work
image
radical added a commit
to radical/runtime
that referenced
this pull request
Dec 14, 2023
@radical
[wasm/wasi] Fix size regression
b72c3ae
Blazor size regression was fixed by:
```
commit ec31705
Author: Ankit Jain <radical@gmail.com>
Date: Wed Dec 6 05:36:59 2023 -0500
[wasm] Fix regressed file sizes for blazor (dotnet#92664)
```
.. but a subsequent PR created close to that undid some of the changes:
```
commit a128c15
Author: Ankit Jain <radical@gmail.com>
Date: Mon Dec 11 15:45:58 2023 -0500
[wasm/wasi] Consolidate build targets (dotnet#95775)
```
Essentially, `-g` was being passed to the link, and compile-bc steps.
Found in dotnet/perf-autofiling-issues#25891 .
radical added a commit
that referenced
this pull request
Dec 14, 2023
@radical
[wasm/wasi] Fix size regression (#95992)
f59ef7f
* [wasm/wasi] Fix size regression
Blazor size regression was fixed by:
```
commit ec31705
Author: Ankit Jain <radical@gmail.com>
Date: Wed Dec 6 05:36:59 2023 -0500
[wasm] Fix regressed file sizes for blazor (#92664)
```
.. but a subsequent PR created close to that undid some of the changes:
```
commit a128c15
Author: Ankit Jain <radical@gmail.com>
Date: Mon Dec 11 15:45:58 2023 -0500
[wasm/wasi] Consolidate build targets (#95775)
```
Essentially, `-g` was being passed to the link, and compile-bc steps.
Found in dotnet/perf-autofiling-issues#25891 .
* [wasm] Add flag missed in the consolidate PR
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jan 7, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing left review comments
@pavelsavarapavelsavarapavelsavara approved these changes

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@radical@kg@pavelsavara@radekdoulik@lewing

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[wasm] Fix regressed file sizes for blazor - #92664
Merged
radical merged 28 commits into
dotnet:mainfrom 
radical:wasm-native-strip-main
Dec 6, 2023
Merged
[wasm] Fix regressed file sizes for blazor#92664
radical merged 28 commits into
dotnet:mainfrom 
radical:wasm-native-strip-main
Conversation
@radical
@radicalradical
commented
Sep 26, 2023•

edited

Loading

Copy link


Copy Markdown

Member
[wasm] build: Revert to older behavior for WasmNativeStrip
The earlier change was done in 26ae097,

which changed to pass -g to the link step also. But that resulted in

increased native file sizes.
  • [wasm] Add getter for __indirect_function_table
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Issue: Issue: dotnet/perf-autofiling-issues#20642
@radical
[wasm] Add getter for __indirect_function_table
70a900e
.. so that can work even if it gets renamed during minimization.
@radical
[wasm] build: Revert to older behavior for WasmNativeStrip
bd97094
The earlier change was done in 678fd6a,
which changed to pass `-g` to the link step also. But that resulted in
increased native file sizes.
Changed sizes for the `minimum blazor template - publish` scenario:
```
| Last rc1 run | With the change
----------------------------------------------------------|----------------- |------------------
SOD - Minimum Blazor Template - Publish |8590723.000 bytes |7889806.000 bytes
Total Uncompressed _framework |4304274.000 bytes |4202273.000 bytes
pub/wwwroot/_framework/dotnet.js |35722.000 bytes |35838.000 bytes
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js |239307.000 bytes |134566.000 bytes
pub/wwwroot/_framework/dotnet.native.wasm |1174394.000 bytes |1148841.000 bytes
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js |221356.000 bytes |221712.000 bytes
```
(cherry picked from commit ae93e81)
@radical
[wasm] cleanup corresponding tests
d84ecf9
(cherry picked from commit 0207d60)
@radical
[wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
dd5fc7c
(cherry picked from commit 91379dd)
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Sep 26, 2023
@ghostghost
added
the 
area-Build-mono

label
Sep 26, 2023
@ghostghost
assigned radicalSep 26, 2023
@ghost
ghost
commented
Sep 26, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • [wasm] Add getter for __indirect_function_table
  • [wasm] build: Revert to older behavior for WasmNativeStrip
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radicalradical
changed the title
wasm native strip main[wasm] Fix regressed file sizes for blazorSep 26, 2023
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm-perf
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Sep 27, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/types/internal.ts
Outdated

kg
kg
reviewed
Sep 27, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/es6/dotnet.es6.pre.js
kg
kg
approved these changes
Sep 27, 2023
View reviewed changes

This was referenced Sep 27, 2023

Open


Closed

@radicalradical
mentioned this pull request
Sep 27, 2023
 Closed

@radical
radical
commented
Sep 27, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
After the change to move getWasmIndirectFunctionTable to only be before the runtime is created, library all the tests are failing with:
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"

log.
@kg
kg
commented
Sep 27, 2023

Copy link


Copy Markdown

Contributor
After the change to move getWasmIndirectFunctionTable to only be before the runtime is created, library all the tests are failing with:
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"

log.
I guess I put it in both places because it was actually necessary, and I forgot :-)
@radical
Revert "address review feedback"
b36d205
This reverts commit 68e954d.
This caused tests to fail with:
```
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"
```
@radical
Merge remote-tracking branch 'origin/main' into wasm-native-strip-main
44d6bc3
@radical
Merge branch 'dotnet:main' into wasm-native-strip-main
85c0af8

This was referenced Nov 8, 2023

Closed


Closed

@pavelsavara
pavelsavara
commented
Nov 29, 2023

Copy link


Copy Markdown

Member
need help ?
@radical
radical
commented
Nov 29, 2023

Copy link


Copy Markdown

MemberAuthor
need help ?
Any suggestions on a fix? The alternative would be to disable the failing tests which are essentially for Debug+AOT, and Debug+relink. We could ignore debug+aot for now, but debug+relink is likely more common because we would relink if you had any native references too.
But this PR will help the sizes.
@pavelsavara
pavelsavara
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
Any suggestions on a fix?
Still this, right ?
Wasm.Build.Tests.Blazor.SimpleRunTests.BlazorPublishRunTest(config: "Debug", aot: True) [FAIL]
[error] MONO_WASM: onRuntimeInitializedAsync() failed Error: raw cwrap mono_jiterp_placeholder_trace not found
at Ir (http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:58604)
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:214838
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:215122

@radical
radical
commented
Nov 30, 2023

Copy link


Copy Markdown

MemberAuthor
Any suggestions on a fix?
Still this, right ?

Wasm.Build.Tests.Blazor.SimpleRunTests.BlazorPublishRunTest(config: "Debug", aot: True) [FAIL]
[error] MONO_WASM: onRuntimeInitializedAsync() failed Error: raw cwrap mono_jiterp_placeholder_trace not found
at Ir (http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:58604)
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:214838
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:215122

Yes
@pavelsavara
pavelsavara
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
I have this untested theory:
I think this is not about AOT, but about WasmBuildNative being triggered with some optimization level which mangles symbols.
It fails in getRawCwrap which uses un-mangled symbol names.
mono_jiterp_placeholder_trace is just coincidence, because it's the first thing requested.
We have this un-mangling logic in createWasmImportStubsFrom and replace_linker_placeholders for wasm imports. Maybe we need same thing for wasm exports ?
@pavelsavara
pavelsavara
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
Printing full list of Module["asm"] would help to debug it.
@radical
radical
commented
Nov 30, 2023

Copy link


Copy Markdown

MemberAuthor
Relink/aot with an optimization level and -g . This happens only for debug config.
Dunno about the details that you mentioned.
@pavelsavarapavelsavara
mentioned this pull request
Dec 5, 2023
 Merged

@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
#95613 seems to have fixed the failures! Thanks @kg, @pavelsavara!
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 6, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@microsoft-github-policy-service rerun

This was referenced Dec 6, 2023

Open


Closed

@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
Failures are known issues.
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@microsoft-github-policy-service rerun
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@dotnet-github-policy-service rerun
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@dotnet-policy-service rerun
@radical
radical
merged commit ec31705
into
dotnet:mainDec 6, 2023
@radical
radical
deleted the

wasm-native-strip-main

branch
December 6, 2023 10:37
@radekdoulik
radekdoulik
commented
Dec 7, 2023•

edited

Loading

Copy link


Copy Markdown

Member
great work
image
radical added a commit
to radical/runtime
that referenced
this pull request
Dec 14, 2023
@radical
[wasm/wasi] Fix size regression
b72c3ae
Blazor size regression was fixed by:
```
commit ec31705
Author: Ankit Jain <radical@gmail.com>
Date: Wed Dec 6 05:36:59 2023 -0500
[wasm] Fix regressed file sizes for blazor (dotnet#92664)
```
.. but a subsequent PR created close to that undid some of the changes:
```
commit a128c15
Author: Ankit Jain <radical@gmail.com>
Date: Mon Dec 11 15:45:58 2023 -0500
[wasm/wasi] Consolidate build targets (dotnet#95775)
```
Essentially, `-g` was being passed to the link, and compile-bc steps.
Found in dotnet/perf-autofiling-issues#25891 .
radical added a commit
that referenced
this pull request
Dec 14, 2023
@radical
[wasm/wasi] Fix size regression (#95992)
f59ef7f
* [wasm/wasi] Fix size regression
Blazor size regression was fixed by:
```
commit ec31705
Author: Ankit Jain <radical@gmail.com>
Date: Wed Dec 6 05:36:59 2023 -0500
[wasm] Fix regressed file sizes for blazor (#92664)
```
.. but a subsequent PR created close to that undid some of the changes:
```
commit a128c15
Author: Ankit Jain <radical@gmail.com>
Date: Mon Dec 11 15:45:58 2023 -0500
[wasm/wasi] Consolidate build targets (#95775)
```
Essentially, `-g` was being passed to the link, and compile-bc steps.
Found in dotnet/perf-autofiling-issues#25891 .
* [wasm] Add flag missed in the consolidate PR
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jan 7, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing left review comments
@pavelsavarapavelsavarapavelsavara approved these changes

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@radical@kg@pavelsavara@radekdoulik@lewing

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[wasm] Fix regressed file sizes for blazor - #92664
Merged
radical merged 28 commits into
dotnet:mainfrom 
radical:wasm-native-strip-main
Dec 6, 2023
Merged
[wasm] Fix regressed file sizes for blazor#92664
radical merged 28 commits into
dotnet:mainfrom 
radical:wasm-native-strip-main
Conversation
@radical
@radicalradical
commented
Sep 26, 2023•

edited

Loading

Copy link


Copy Markdown

Member
[wasm] build: Revert to older behavior for WasmNativeStrip
The earlier change was done in 26ae097,

which changed to pass -g to the link step also. But that resulted in

increased native file sizes.
  • [wasm] Add getter for __indirect_function_table
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Issue: Issue: dotnet/perf-autofiling-issues#20642
@radical
[wasm] Add getter for __indirect_function_table
70a900e
.. so that can work even if it gets renamed during minimization.
@radical
[wasm] build: Revert to older behavior for WasmNativeStrip
bd97094
The earlier change was done in 678fd6a,
which changed to pass `-g` to the link step also. But that resulted in
increased native file sizes.
Changed sizes for the `minimum blazor template - publish` scenario:
```
| Last rc1 run | With the change
----------------------------------------------------------|----------------- |------------------
SOD - Minimum Blazor Template - Publish |8590723.000 bytes |7889806.000 bytes
Total Uncompressed _framework |4304274.000 bytes |4202273.000 bytes
pub/wwwroot/_framework/dotnet.js |35722.000 bytes |35838.000 bytes
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js |239307.000 bytes |134566.000 bytes
pub/wwwroot/_framework/dotnet.native.wasm |1174394.000 bytes |1148841.000 bytes
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js |221356.000 bytes |221712.000 bytes
```
(cherry picked from commit ae93e81)
@radical
[wasm] cleanup corresponding tests
d84ecf9
(cherry picked from commit 0207d60)
@radical
[wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
dd5fc7c
(cherry picked from commit 91379dd)
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Sep 26, 2023
@ghostghost
added
the 
area-Build-mono

label
Sep 26, 2023
@ghostghost
assigned radicalSep 26, 2023
@ghost
ghost
commented
Sep 26, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • [wasm] Add getter for __indirect_function_table
  • [wasm] build: Revert to older behavior for WasmNativeStrip
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radicalradical
changed the title
wasm native strip main[wasm] Fix regressed file sizes for blazorSep 26, 2023
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm-perf
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Sep 27, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/types/internal.ts
Outdated

kg
kg
reviewed
Sep 27, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/es6/dotnet.es6.pre.js
kg
kg
approved these changes
Sep 27, 2023
View reviewed changes

This was referenced Sep 27, 2023

Open


Closed

@radicalradical
mentioned this pull request
Sep 27, 2023
 Closed

@radical
radical
commented
Sep 27, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
After the change to move getWasmIndirectFunctionTable to only be before the runtime is created, library all the tests are failing with:
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"

log.
@kg
kg
commented
Sep 27, 2023

Copy link


Copy Markdown

Contributor
After the change to move getWasmIndirectFunctionTable to only be before the runtime is created, library all the tests are failing with:
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"

log.
I guess I put it in both places because it was actually necessary, and I forgot :-)
@radical
Revert "address review feedback"
b36d205
This reverts commit 68e954d.
This caused tests to fail with:
```
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"
```
@radical
Merge remote-tracking branch 'origin/main' into wasm-native-strip-main
44d6bc3
@radical
Merge branch 'dotnet:main' into wasm-native-strip-main
85c0af8

This was referenced Nov 8, 2023

Closed


Closed

@pavelsavara
pavelsavara
commented
Nov 29, 2023

Copy link


Copy Markdown

Member
need help ?
@radical
radical
commented
Nov 29, 2023

Copy link


Copy Markdown

MemberAuthor
need help ?
Any suggestions on a fix? The alternative would be to disable the failing tests which are essentially for Debug+AOT, and Debug+relink. We could ignore debug+aot for now, but debug+relink is likely more common because we would relink if you had any native references too.
But this PR will help the sizes.
@pavelsavara
pavelsavara
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
Any suggestions on a fix?
Still this, right ?
Wasm.Build.Tests.Blazor.SimpleRunTests.BlazorPublishRunTest(config: "Debug", aot: True) [FAIL]
[error] MONO_WASM: onRuntimeInitializedAsync() failed Error: raw cwrap mono_jiterp_placeholder_trace not found
at Ir (http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:58604)
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:214838
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:215122

@radical
radical
commented
Nov 30, 2023

Copy link


Copy Markdown

MemberAuthor
Any suggestions on a fix?
Still this, right ?

Wasm.Build.Tests.Blazor.SimpleRunTests.BlazorPublishRunTest(config: "Debug", aot: True) [FAIL]
[error] MONO_WASM: onRuntimeInitializedAsync() failed Error: raw cwrap mono_jiterp_placeholder_trace not found
at Ir (http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:58604)
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:214838
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:215122

Yes
@pavelsavara
pavelsavara
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
I have this untested theory:
I think this is not about AOT, but about WasmBuildNative being triggered with some optimization level which mangles symbols.
It fails in getRawCwrap which uses un-mangled symbol names.
mono_jiterp_placeholder_trace is just coincidence, because it's the first thing requested.
We have this un-mangling logic in createWasmImportStubsFrom and replace_linker_placeholders for wasm imports. Maybe we need same thing for wasm exports ?
@pavelsavara
pavelsavara
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
Printing full list of Module["asm"] would help to debug it.
@radical
radical
commented
Nov 30, 2023

Copy link


Copy Markdown

MemberAuthor
Relink/aot with an optimization level and -g . This happens only for debug config.
Dunno about the details that you mentioned.
@pavelsavarapavelsavara
mentioned this pull request
Dec 5, 2023
 Merged

@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
#95613 seems to have fixed the failures! Thanks @kg, @pavelsavara!
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 6, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@microsoft-github-policy-service rerun

This was referenced Dec 6, 2023

Open


Closed

@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
Failures are known issues.
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@microsoft-github-policy-service rerun
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@dotnet-github-policy-service rerun
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@dotnet-policy-service rerun
@radical
radical
merged commit ec31705
into
dotnet:mainDec 6, 2023
@radical
radical
deleted the

wasm-native-strip-main

branch
December 6, 2023 10:37
@radekdoulik
radekdoulik
commented
Dec 7, 2023•

edited

Loading

Copy link


Copy Markdown

Member
great work
image
radical added a commit
to radical/runtime
that referenced
this pull request
Dec 14, 2023
@radical
[wasm/wasi] Fix size regression
b72c3ae
Blazor size regression was fixed by:
```
commit ec31705
Author: Ankit Jain <radical@gmail.com>
Date: Wed Dec 6 05:36:59 2023 -0500
[wasm] Fix regressed file sizes for blazor (dotnet#92664)
```
.. but a subsequent PR created close to that undid some of the changes:
```
commit a128c15
Author: Ankit Jain <radical@gmail.com>
Date: Mon Dec 11 15:45:58 2023 -0500
[wasm/wasi] Consolidate build targets (dotnet#95775)
```
Essentially, `-g` was being passed to the link, and compile-bc steps.
Found in dotnet/perf-autofiling-issues#25891 .
radical added a commit
that referenced
this pull request
Dec 14, 2023
@radical
[wasm/wasi] Fix size regression (#95992)
f59ef7f
* [wasm/wasi] Fix size regression
Blazor size regression was fixed by:
```
commit ec31705
Author: Ankit Jain <radical@gmail.com>
Date: Wed Dec 6 05:36:59 2023 -0500
[wasm] Fix regressed file sizes for blazor (#92664)
```
.. but a subsequent PR created close to that undid some of the changes:
```
commit a128c15
Author: Ankit Jain <radical@gmail.com>
Date: Mon Dec 11 15:45:58 2023 -0500
[wasm/wasi] Consolidate build targets (#95775)
```
Essentially, `-g` was being passed to the link, and compile-bc steps.
Found in dotnet/perf-autofiling-issues#25891 .
* [wasm] Add flag missed in the consolidate PR
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jan 7, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing left review comments
@pavelsavarapavelsavarapavelsavara approved these changes

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@radical@kg@pavelsavara@radekdoulik@lewing

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[wasm] Fix regressed file sizes for blazor - #92664
Merged
radical merged 28 commits into
dotnet:mainfrom 
radical:wasm-native-strip-main
Dec 6, 2023
Merged
[wasm] Fix regressed file sizes for blazor#92664
radical merged 28 commits into
dotnet:mainfrom 
radical:wasm-native-strip-main
Conversation
@radical
@radicalradical
commented
Sep 26, 2023•

edited

Loading

Copy link


Copy Markdown

Member
[wasm] build: Revert to older behavior for WasmNativeStrip
The earlier change was done in 26ae097,

which changed to pass -g to the link step also. But that resulted in

increased native file sizes.
  • [wasm] Add getter for __indirect_function_table
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Issue: Issue: dotnet/perf-autofiling-issues#20642
@radical
[wasm] Add getter for __indirect_function_table
70a900e
.. so that can work even if it gets renamed during minimization.
@radical
[wasm] build: Revert to older behavior for WasmNativeStrip
bd97094
The earlier change was done in 678fd6a,
which changed to pass `-g` to the link step also. But that resulted in
increased native file sizes.
Changed sizes for the `minimum blazor template - publish` scenario:
```
| Last rc1 run | With the change
----------------------------------------------------------|----------------- |------------------
SOD - Minimum Blazor Template - Publish |8590723.000 bytes |7889806.000 bytes
Total Uncompressed _framework |4304274.000 bytes |4202273.000 bytes
pub/wwwroot/_framework/dotnet.js |35722.000 bytes |35838.000 bytes
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js |239307.000 bytes |134566.000 bytes
pub/wwwroot/_framework/dotnet.native.wasm |1174394.000 bytes |1148841.000 bytes
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js |221356.000 bytes |221712.000 bytes
```
(cherry picked from commit ae93e81)
@radical
[wasm] cleanup corresponding tests
d84ecf9
(cherry picked from commit 0207d60)
@radical
[wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
dd5fc7c
(cherry picked from commit 91379dd)
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Sep 26, 2023
@ghostghost
added
the 
area-Build-mono

label
Sep 26, 2023
@ghostghost
assigned radicalSep 26, 2023
@ghost
ghost
commented
Sep 26, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • [wasm] Add getter for __indirect_function_table
  • [wasm] build: Revert to older behavior for WasmNativeStrip
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radicalradical
changed the title
wasm native strip main[wasm] Fix regressed file sizes for blazorSep 26, 2023
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm-perf
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Sep 27, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/types/internal.ts
Outdated

kg
kg
reviewed
Sep 27, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/es6/dotnet.es6.pre.js
kg
kg
approved these changes
Sep 27, 2023
View reviewed changes

This was referenced Sep 27, 2023

Open


Closed

@radicalradical
mentioned this pull request
Sep 27, 2023
 Closed

@radical
radical
commented
Sep 27, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
After the change to move getWasmIndirectFunctionTable to only be before the runtime is created, library all the tests are failing with:
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"

log.
@kg
kg
commented
Sep 27, 2023

Copy link


Copy Markdown

Contributor
After the change to move getWasmIndirectFunctionTable to only be before the runtime is created, library all the tests are failing with:
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"

log.
I guess I put it in both places because it was actually necessary, and I forgot :-)
@radical
Revert "address review feedback"
b36d205
This reverts commit 68e954d.
This caused tests to fail with:
```
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"
```
@radical
Merge remote-tracking branch 'origin/main' into wasm-native-strip-main
44d6bc3
@radical
Merge branch 'dotnet:main' into wasm-native-strip-main
85c0af8

This was referenced Nov 8, 2023

Closed


Closed

@pavelsavara
pavelsavara
commented
Nov 29, 2023

Copy link


Copy Markdown

Member
need help ?
@radical
radical
commented
Nov 29, 2023

Copy link


Copy Markdown

MemberAuthor
need help ?
Any suggestions on a fix? The alternative would be to disable the failing tests which are essentially for Debug+AOT, and Debug+relink. We could ignore debug+aot for now, but debug+relink is likely more common because we would relink if you had any native references too.
But this PR will help the sizes.
@pavelsavara
pavelsavara
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
Any suggestions on a fix?
Still this, right ?
Wasm.Build.Tests.Blazor.SimpleRunTests.BlazorPublishRunTest(config: "Debug", aot: True) [FAIL]
[error] MONO_WASM: onRuntimeInitializedAsync() failed Error: raw cwrap mono_jiterp_placeholder_trace not found
at Ir (http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:58604)
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:214838
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:215122

@radical
radical
commented
Nov 30, 2023

Copy link


Copy Markdown

MemberAuthor
Any suggestions on a fix?
Still this, right ?

Wasm.Build.Tests.Blazor.SimpleRunTests.BlazorPublishRunTest(config: "Debug", aot: True) [FAIL]
[error] MONO_WASM: onRuntimeInitializedAsync() failed Error: raw cwrap mono_jiterp_placeholder_trace not found
at Ir (http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:58604)
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:214838
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:215122

Yes
@pavelsavara
pavelsavara
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
I have this untested theory:
I think this is not about AOT, but about WasmBuildNative being triggered with some optimization level which mangles symbols.
It fails in getRawCwrap which uses un-mangled symbol names.
mono_jiterp_placeholder_trace is just coincidence, because it's the first thing requested.
We have this un-mangling logic in createWasmImportStubsFrom and replace_linker_placeholders for wasm imports. Maybe we need same thing for wasm exports ?
@pavelsavara
pavelsavara
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
Printing full list of Module["asm"] would help to debug it.
@radical
radical
commented
Nov 30, 2023

Copy link


Copy Markdown

MemberAuthor
Relink/aot with an optimization level and -g . This happens only for debug config.
Dunno about the details that you mentioned.
@pavelsavarapavelsavara
mentioned this pull request
Dec 5, 2023
 Merged

@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
#95613 seems to have fixed the failures! Thanks @kg, @pavelsavara!
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 6, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@microsoft-github-policy-service rerun

This was referenced Dec 6, 2023

Open


Closed

@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
Failures are known issues.
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@microsoft-github-policy-service rerun
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@dotnet-github-policy-service rerun
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@dotnet-policy-service rerun
@radical
radical
merged commit ec31705
into
dotnet:mainDec 6, 2023
@radical
radical
deleted the

wasm-native-strip-main

branch
December 6, 2023 10:37
@radekdoulik
radekdoulik
commented
Dec 7, 2023•

edited

Loading

Copy link


Copy Markdown

Member
great work
image
radical added a commit
to radical/runtime
that referenced
this pull request
Dec 14, 2023
@radical
[wasm/wasi] Fix size regression
b72c3ae
Blazor size regression was fixed by:
```
commit ec31705
Author: Ankit Jain <radical@gmail.com>
Date: Wed Dec 6 05:36:59 2023 -0500
[wasm] Fix regressed file sizes for blazor (dotnet#92664)
```
.. but a subsequent PR created close to that undid some of the changes:
```
commit a128c15
Author: Ankit Jain <radical@gmail.com>
Date: Mon Dec 11 15:45:58 2023 -0500
[wasm/wasi] Consolidate build targets (dotnet#95775)
```
Essentially, `-g` was being passed to the link, and compile-bc steps.
Found in dotnet/perf-autofiling-issues#25891 .
radical added a commit
that referenced
this pull request
Dec 14, 2023
@radical
[wasm/wasi] Fix size regression (#95992)
f59ef7f
* [wasm/wasi] Fix size regression
Blazor size regression was fixed by:
```
commit ec31705
Author: Ankit Jain <radical@gmail.com>
Date: Wed Dec 6 05:36:59 2023 -0500
[wasm] Fix regressed file sizes for blazor (#92664)
```
.. but a subsequent PR created close to that undid some of the changes:
```
commit a128c15
Author: Ankit Jain <radical@gmail.com>
Date: Mon Dec 11 15:45:58 2023 -0500
[wasm/wasi] Consolidate build targets (#95775)
```
Essentially, `-g` was being passed to the link, and compile-bc steps.
Found in dotnet/perf-autofiling-issues#25891 .
* [wasm] Add flag missed in the consolidate PR
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jan 7, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing left review comments
@pavelsavarapavelsavarapavelsavara approved these changes

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@radical@kg@pavelsavara@radekdoulik@lewing

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[wasm] Fix regressed file sizes for blazor - #92664
Merged
radical merged 28 commits into
dotnet:mainfrom 
radical:wasm-native-strip-main
Dec 6, 2023
Merged
[wasm] Fix regressed file sizes for blazor#92664
radical merged 28 commits into
dotnet:mainfrom 
radical:wasm-native-strip-main
Conversation
@radical
@radicalradical
commented
Sep 26, 2023•

edited

Loading

Copy link


Copy Markdown

Member
[wasm] build: Revert to older behavior for WasmNativeStrip
The earlier change was done in 26ae097,

which changed to pass -g to the link step also. But that resulted in

increased native file sizes.
  • [wasm] Add getter for __indirect_function_table
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Issue: Issue: dotnet/perf-autofiling-issues#20642
@radical
[wasm] Add getter for __indirect_function_table
70a900e
.. so that can work even if it gets renamed during minimization.
@radical
[wasm] build: Revert to older behavior for WasmNativeStrip
bd97094
The earlier change was done in 678fd6a,
which changed to pass `-g` to the link step also. But that resulted in
increased native file sizes.
Changed sizes for the `minimum blazor template - publish` scenario:
```
| Last rc1 run | With the change
----------------------------------------------------------|----------------- |------------------
SOD - Minimum Blazor Template - Publish |8590723.000 bytes |7889806.000 bytes
Total Uncompressed _framework |4304274.000 bytes |4202273.000 bytes
pub/wwwroot/_framework/dotnet.js |35722.000 bytes |35838.000 bytes
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js |239307.000 bytes |134566.000 bytes
pub/wwwroot/_framework/dotnet.native.wasm |1174394.000 bytes |1148841.000 bytes
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js |221356.000 bytes |221712.000 bytes
```
(cherry picked from commit ae93e81)
@radical
[wasm] cleanup corresponding tests
d84ecf9
(cherry picked from commit 0207d60)
@radical
[wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
dd5fc7c
(cherry picked from commit 91379dd)
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Sep 26, 2023
@ghostghost
added
the 
area-Build-mono

label
Sep 26, 2023
@ghostghost
assigned radicalSep 26, 2023
@ghost
ghost
commented
Sep 26, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • [wasm] Add getter for __indirect_function_table
  • [wasm] build: Revert to older behavior for WasmNativeStrip
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radicalradical
changed the title
wasm native strip main[wasm] Fix regressed file sizes for blazorSep 26, 2023
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm-perf
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Sep 27, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/types/internal.ts
Outdated

kg
kg
reviewed
Sep 27, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/es6/dotnet.es6.pre.js
kg
kg
approved these changes
Sep 27, 2023
View reviewed changes

This was referenced Sep 27, 2023

Open


Closed

@radicalradical
mentioned this pull request
Sep 27, 2023
 Closed

@radical
radical
commented
Sep 27, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
After the change to move getWasmIndirectFunctionTable to only be before the runtime is created, library all the tests are failing with:
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"

log.
@kg
kg
commented
Sep 27, 2023

Copy link


Copy Markdown

Contributor
After the change to move getWasmIndirectFunctionTable to only be before the runtime is created, library all the tests are failing with:
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"

log.
I guess I put it in both places because it was actually necessary, and I forgot :-)
@radical
Revert "address review feedback"
b36d205
This reverts commit 68e954d.
This caused tests to fail with:
```
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"
```
@radical
Merge remote-tracking branch 'origin/main' into wasm-native-strip-main
44d6bc3
@radical
Merge branch 'dotnet:main' into wasm-native-strip-main
85c0af8

This was referenced Nov 8, 2023

Closed


Closed

@pavelsavara
pavelsavara
commented
Nov 29, 2023

Copy link


Copy Markdown

Member
need help ?
@radical
radical
commented
Nov 29, 2023

Copy link


Copy Markdown

MemberAuthor
need help ?
Any suggestions on a fix? The alternative would be to disable the failing tests which are essentially for Debug+AOT, and Debug+relink. We could ignore debug+aot for now, but debug+relink is likely more common because we would relink if you had any native references too.
But this PR will help the sizes.
@pavelsavara
pavelsavara
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
Any suggestions on a fix?
Still this, right ?
Wasm.Build.Tests.Blazor.SimpleRunTests.BlazorPublishRunTest(config: "Debug", aot: True) [FAIL]
[error] MONO_WASM: onRuntimeInitializedAsync() failed Error: raw cwrap mono_jiterp_placeholder_trace not found
at Ir (http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:58604)
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:214838
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:215122

@radical
radical
commented
Nov 30, 2023

Copy link


Copy Markdown

MemberAuthor
Any suggestions on a fix?
Still this, right ?

Wasm.Build.Tests.Blazor.SimpleRunTests.BlazorPublishRunTest(config: "Debug", aot: True) [FAIL]
[error] MONO_WASM: onRuntimeInitializedAsync() failed Error: raw cwrap mono_jiterp_placeholder_trace not found
at Ir (http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:58604)
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:214838
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:215122

Yes
@pavelsavara
pavelsavara
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
I have this untested theory:
I think this is not about AOT, but about WasmBuildNative being triggered with some optimization level which mangles symbols.
It fails in getRawCwrap which uses un-mangled symbol names.
mono_jiterp_placeholder_trace is just coincidence, because it's the first thing requested.
We have this un-mangling logic in createWasmImportStubsFrom and replace_linker_placeholders for wasm imports. Maybe we need same thing for wasm exports ?
@pavelsavara
pavelsavara
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
Printing full list of Module["asm"] would help to debug it.
@radical
radical
commented
Nov 30, 2023

Copy link


Copy Markdown

MemberAuthor
Relink/aot with an optimization level and -g . This happens only for debug config.
Dunno about the details that you mentioned.
@pavelsavarapavelsavara
mentioned this pull request
Dec 5, 2023
 Merged

@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
#95613 seems to have fixed the failures! Thanks @kg, @pavelsavara!
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 6, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@microsoft-github-policy-service rerun

This was referenced Dec 6, 2023

Open


Closed

@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
Failures are known issues.
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@microsoft-github-policy-service rerun
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@dotnet-github-policy-service rerun
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@dotnet-policy-service rerun
@radical
radical
merged commit ec31705
into
dotnet:mainDec 6, 2023
@radical
radical
deleted the

wasm-native-strip-main

branch
December 6, 2023 10:37
@radekdoulik
radekdoulik
commented
Dec 7, 2023•

edited

Loading

Copy link


Copy Markdown

Member
great work
image
radical added a commit
to radical/runtime
that referenced
this pull request
Dec 14, 2023
@radical
[wasm/wasi] Fix size regression
b72c3ae
Blazor size regression was fixed by:
```
commit ec31705
Author: Ankit Jain <radical@gmail.com>
Date: Wed Dec 6 05:36:59 2023 -0500
[wasm] Fix regressed file sizes for blazor (dotnet#92664)
```
.. but a subsequent PR created close to that undid some of the changes:
```
commit a128c15
Author: Ankit Jain <radical@gmail.com>
Date: Mon Dec 11 15:45:58 2023 -0500
[wasm/wasi] Consolidate build targets (dotnet#95775)
```
Essentially, `-g` was being passed to the link, and compile-bc steps.
Found in dotnet/perf-autofiling-issues#25891 .
radical added a commit
that referenced
this pull request
Dec 14, 2023
@radical
[wasm/wasi] Fix size regression (#95992)
f59ef7f
* [wasm/wasi] Fix size regression
Blazor size regression was fixed by:
```
commit ec31705
Author: Ankit Jain <radical@gmail.com>
Date: Wed Dec 6 05:36:59 2023 -0500
[wasm] Fix regressed file sizes for blazor (#92664)
```
.. but a subsequent PR created close to that undid some of the changes:
```
commit a128c15
Author: Ankit Jain <radical@gmail.com>
Date: Mon Dec 11 15:45:58 2023 -0500
[wasm/wasi] Consolidate build targets (#95775)
```
Essentially, `-g` was being passed to the link, and compile-bc steps.
Found in dotnet/perf-autofiling-issues#25891 .
* [wasm] Add flag missed in the consolidate PR
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jan 7, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing left review comments
@pavelsavarapavelsavarapavelsavara approved these changes

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@radical@kg@pavelsavara@radekdoulik@lewing

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[wasm] Fix regressed file sizes for blazor - #92664
Merged
radical merged 28 commits into
dotnet:mainfrom 
radical:wasm-native-strip-main
Dec 6, 2023
Merged
[wasm] Fix regressed file sizes for blazor#92664
radical merged 28 commits into
dotnet:mainfrom 
radical:wasm-native-strip-main
Conversation
@radical
@radicalradical
commented
Sep 26, 2023•

edited

Loading

Copy link


Copy Markdown

Member
[wasm] build: Revert to older behavior for WasmNativeStrip
The earlier change was done in 26ae097,

which changed to pass -g to the link step also. But that resulted in

increased native file sizes.
  • [wasm] Add getter for __indirect_function_table
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Issue: Issue: dotnet/perf-autofiling-issues#20642
@radical
[wasm] Add getter for __indirect_function_table
70a900e
.. so that can work even if it gets renamed during minimization.
@radical
[wasm] build: Revert to older behavior for WasmNativeStrip
bd97094
The earlier change was done in 678fd6a,
which changed to pass `-g` to the link step also. But that resulted in
increased native file sizes.
Changed sizes for the `minimum blazor template - publish` scenario:
```
| Last rc1 run | With the change
----------------------------------------------------------|----------------- |------------------
SOD - Minimum Blazor Template - Publish |8590723.000 bytes |7889806.000 bytes
Total Uncompressed _framework |4304274.000 bytes |4202273.000 bytes
pub/wwwroot/_framework/dotnet.js |35722.000 bytes |35838.000 bytes
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js |239307.000 bytes |134566.000 bytes
pub/wwwroot/_framework/dotnet.native.wasm |1174394.000 bytes |1148841.000 bytes
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js |221356.000 bytes |221712.000 bytes
```
(cherry picked from commit ae93e81)
@radical
[wasm] cleanup corresponding tests
d84ecf9
(cherry picked from commit 0207d60)
@radical
[wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
dd5fc7c
(cherry picked from commit 91379dd)
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Sep 26, 2023
@ghostghost
added
the 
area-Build-mono

label
Sep 26, 2023
@ghostghost
assigned radicalSep 26, 2023
@ghost
ghost
commented
Sep 26, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • [wasm] Add getter for __indirect_function_table
  • [wasm] build: Revert to older behavior for WasmNativeStrip
  • [wasm] cleanup corresponding tests
  • [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radicalradical
changed the title
wasm native strip main[wasm] Fix regressed file sizes for blazorSep 26, 2023
@radical
radical
commented
Sep 26, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm-perf
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Sep 27, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/types/internal.ts
Outdated

kg
kg
reviewed
Sep 27, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/es6/dotnet.es6.pre.js
kg
kg
approved these changes
Sep 27, 2023
View reviewed changes

This was referenced Sep 27, 2023

Open


Closed

@radicalradical
mentioned this pull request
Sep 27, 2023
 Closed

@radical
radical
commented
Sep 27, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
After the change to move getWasmIndirectFunctionTable to only be before the runtime is created, library all the tests are failing with:
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"

log.
@kg
kg
commented
Sep 27, 2023

Copy link


Copy Markdown

Contributor
After the change to move getWasmIndirectFunctionTable to only be before the runtime is created, library all the tests are failing with:
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"

log.
I guess I put it in both places because it was actually necessary, and I forgot :-)
@radical
Revert "address review feedback"
b36d205
This reverts commit 68e954d.
This caused tests to fail with:
```
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"
```
@radical
Merge remote-tracking branch 'origin/main' into wasm-native-strip-main
44d6bc3
@radical
Merge branch 'dotnet:main' into wasm-native-strip-main
85c0af8

This was referenced Nov 8, 2023

Closed


Closed

@pavelsavara
pavelsavara
commented
Nov 29, 2023

Copy link


Copy Markdown

Member
need help ?
@radical
radical
commented
Nov 29, 2023

Copy link


Copy Markdown

MemberAuthor
need help ?
Any suggestions on a fix? The alternative would be to disable the failing tests which are essentially for Debug+AOT, and Debug+relink. We could ignore debug+aot for now, but debug+relink is likely more common because we would relink if you had any native references too.
But this PR will help the sizes.
@pavelsavara
pavelsavara
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
Any suggestions on a fix?
Still this, right ?
Wasm.Build.Tests.Blazor.SimpleRunTests.BlazorPublishRunTest(config: "Debug", aot: True) [FAIL]
[error] MONO_WASM: onRuntimeInitializedAsync() failed Error: raw cwrap mono_jiterp_placeholder_trace not found
at Ir (http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:58604)
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:214838
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:215122

@radical
radical
commented
Nov 30, 2023

Copy link


Copy Markdown

MemberAuthor
Any suggestions on a fix?
Still this, right ?

Wasm.Build.Tests.Blazor.SimpleRunTests.BlazorPublishRunTest(config: "Debug", aot: True) [FAIL]
[error] MONO_WASM: onRuntimeInitializedAsync() failed Error: raw cwrap mono_jiterp_placeholder_trace not found
at Ir (http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:58604)
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:214838
at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:215122

Yes
@pavelsavara
pavelsavara
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
I have this untested theory:
I think this is not about AOT, but about WasmBuildNative being triggered with some optimization level which mangles symbols.
It fails in getRawCwrap which uses un-mangled symbol names.
mono_jiterp_placeholder_trace is just coincidence, because it's the first thing requested.
We have this un-mangling logic in createWasmImportStubsFrom and replace_linker_placeholders for wasm imports. Maybe we need same thing for wasm exports ?
@pavelsavara
pavelsavara
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
Printing full list of Module["asm"] would help to debug it.
@radical
radical
commented
Nov 30, 2023

Copy link


Copy Markdown

MemberAuthor
Relink/aot with an optimization level and -g . This happens only for debug config.
Dunno about the details that you mentioned.
@pavelsavarapavelsavara
mentioned this pull request
Dec 5, 2023
 Merged

@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
#95613 seems to have fixed the failures! Thanks @kg, @pavelsavara!
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 6, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@microsoft-github-policy-service rerun

This was referenced Dec 6, 2023

Open


Closed

@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
Failures are known issues.
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@microsoft-github-policy-service rerun
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@dotnet-github-policy-service rerun
@radical
radical
commented
Dec 6, 2023

Copy link


Copy Markdown

MemberAuthor
@dotnet-policy-service rerun
@radical
radical
merged commit ec31705
into
dotnet:mainDec 6, 2023
@radical
radical
deleted the

wasm-native-strip-main

branch
December 6, 2023 10:37
@radekdoulik
radekdoulik
commented
Dec 7, 2023•

edited

Loading

Copy link


Copy Markdown

Member
great work
image
radical added a commit
to radical/runtime
that referenced
this pull request
Dec 14, 2023
@radical
[wasm/wasi] Fix size regression
b72c3ae
Blazor size regression was fixed by:
```
commit ec31705
Author: Ankit Jain <radical@gmail.com>
Date: Wed Dec 6 05:36:59 2023 -0500
[wasm] Fix regressed file sizes for blazor (dotnet#92664)
```
.. but a subsequent PR created close to that undid some of the changes:
```
commit a128c15
Author: Ankit Jain <radical@gmail.com>
Date: Mon Dec 11 15:45:58 2023 -0500
[wasm/wasi] Consolidate build targets (dotnet#95775)
```
Essentially, `-g` was being passed to the link, and compile-bc steps.
Found in dotnet/perf-autofiling-issues#25891 .
radical added a commit
that referenced
this pull request
Dec 14, 2023
@radical
[wasm/wasi] Fix size regression (#95992)
f59ef7f
* [wasm/wasi] Fix size regression
Blazor size regression was fixed by:
```
commit ec31705
Author: Ankit Jain <radical@gmail.com>
Date: Wed Dec 6 05:36:59 2023 -0500
[wasm] Fix regressed file sizes for blazor (#92664)
```
.. but a subsequent PR created close to that undid some of the changes:
```
commit a128c15
Author: Ankit Jain <radical@gmail.com>
Date: Mon Dec 11 15:45:58 2023 -0500
[wasm/wasi] Consolidate build targets (#95775)
```
Essentially, `-g` was being passed to the link, and compile-bc steps.
Found in dotnet/perf-autofiling-issues#25891 .
* [wasm] Add flag missed in the consolidate PR
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jan 7, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing left review comments
@pavelsavarapavelsavarapavelsavara approved these changes

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@radical@kg@pavelsavara@radekdoulik@lewing