Skip to content

[release/8.0][wasm] Use intended ports when running DevServer - #92906

Merged
carlossanlop merged 5 commits into
dotnet:release/8.0from
radical:wasm-app-host-fix-v8
Oct 3, 2023
Merged

[release/8.0][wasm] Use intended ports when running DevServer#92906
carlossanlop merged 5 commits into
dotnet:release/8.0from
radical:wasm-app-host-fix-v8

Conversation

@radical

@radicalradical commented Oct 2, 2023•
edited
Loading

Copy link
Copy Markdown
Member

For running a wasm-browser application DevServer is used, but it always started the webserver on port 5000, because the selected ports weren't used by the DevServer, and thus used the defaults.

...
[] Unhandled exception. System.IO.IOException: Failed to bind to address http://127.0.0.1:5000: address already in use.
...
  • Also, ignore empty ASPNETCORE_URLS='' in the environment.

Fixes#91143 .

Customer impact

Every run for a wasmbrowser template (which is still only in the wasm-experimental workload) will use a random port for the webserver, instead of a fixed 5000, as intended.

Testing

Automated testing.

Impact

Low. This affects an experimental feature.

@radicalradical added arch-wasm WebAssembly architecture area-Build-mono labels Oct 2, 2023
@radical
radical requested a review from marafOctober 2, 2023 21:24
@ghostghost assigned radicalOct 2, 2023
@ghost

ghost commented Oct 2, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

For running a wasm-browser application DevServer is used, but it always started the webserver on port 5000, because the selected ports weren't used by the DevServer, and thus used the defaults.

 Wasm.Build.Tests.TestAppScenarios.LibraryInitializerTests.LoadLibraryInitializer [STARTING]
Expected 0 exit code but got -532462766: C:\helix\work\workitem\e\dotnet-latest\dotnet.exe run -c Debug --no-build
Standard Output:
[] WasmAppHost --use-staticwebassets --runtime-config C:\helix\work\workitem\e\wbt\LibraryInitializerTests_LoadLibraryInitializer_dl4w1qgh_jty\bin\Debug\net8.0\WasmBasicTestApp.runtimeconfig.json
[] Unhandled exception. System.IO.IOException: Failed to bind to address http://127.0.0.1:5000: address already in use.
[] ---> Microsoft.AspNetCore.Connections.AddressInUseException: Only one usage of each socket address (protocol/network address/port) is normally permitted.
[] ---> System.Net.Sockets.SocketException (10048): Only one usage of each socket address (protocol/network address/port) is normally permitted.
[] at System.Net.Sockets.Socket.UpdateStatusAfterSocketErrorAndThrowException(SocketError error, Boolean disconnectOnFailure, String callerName)
[] at System.Net.Sockets.Socket.DoBind(EndPoint endPointSnapshot, SocketAddress socketAddress)
[] at System.Net.Sockets.Socket.Bind(EndPoint localEP)
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransportOptions.CreateDefaultBoundListenSocket(EndPoint endpoint)
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketConnectionListener.Bind()
[] --- End of inner exception stack trace ---
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketConnectionListener.Bind()
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransportFactory.BindAsync(EndPoint endpoint, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.TransportManager.BindAsync(EndPoint endPoint, ConnectionDelegate connectionDelegate, EndpointConfig endpointConfig, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.<>c__DisplayClass28_0`1.<<StartAsync>g__OnBind|0>d.MoveNext()
[] --- End of stack trace from previous location ---
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context, CancellationToken cancellationToken)
[] --- End of inner exception stack trace ---
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.LocalhostListenOptions.BindAsync(AddressBindContext context, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.DefaultAddressStrategy.BindAsync(AddressBindContext context, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindAsync(ListenOptions[] listenOptions, AddressBindContext context, Func`2 useHttps, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.BindAsync(CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.StartAsync[TContext](IHttpApplication`1 application, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Hosting.WebHost.StartAsync(CancellationToken cancellationToken)
[] at Microsoft.WebAssembly.AppHost.DevServer.DevServer.StartAsync(DevServerOptions options, ILogger logger, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.BrowserHost.StartWebServerAsync(BrowserArguments args, String[] urls, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.BrowserHost.RunAsync(ILoggerFactory loggerFactory, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.BrowserHost.InvokeAsync(CommonConfiguration commonArgs, ILoggerFactory loggerFactory, ILogger logger, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.WasmAppHost.Main(String[] args)
[] at Microsoft.WebAssembly.AppHost.WasmAppHost.<Main>(String[] args)
  • Also, ignore empty ASPNETCORE_URLS='' in the environment.

Fixes #88832 .

Author:radical
Assignees:-
Labels:

arch-wasm, area-Build-mono

Milestone:-

kg
kg approved these changes Oct 2, 2023
View reviewed changes
@radicalradical added the Servicing-consider Issue for next servicing release review label Oct 2, 2023
@radicalradical changed the title [releaes/8.0][wasm] Use intended ports when running DevServer[release/8.0][wasm] Use intended ports when running DevServerOct 2, 2023
@radical

radical commented Oct 3, 2023

Copy link
Copy Markdown
MemberAuthor

Test failure is relevant.

@carlossanlopcarlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 3, 2023
@carlossanlop

carlossanlop commented Oct 3, 2023

Copy link
Copy Markdown
Contributor

Approved by Tactics via email.

Test failure is relevant.

@radical ping me when the test failure is addressed so I can merge. I'll add the blocked label meanwhile.

@carlossanlopcarlossanlop added the blocked Issue/PR is blocked on something - see comments label Oct 3, 2023
@marafmaraf mentioned this pull request Oct 3, 2023
Merged
@build-analysisbuild-analysisBot mentioned this pull request Oct 3, 2023
Closed
@radicalradical removed the blocked Issue/PR is blocked on something - see comments label Oct 3, 2023
@radical

radical commented Oct 3, 2023

Copy link
Copy Markdown
MemberAuthor

@carlossanlop this is ready.

@carlossanlop
carlossanlop merged commit 0eeb6b2 into dotnet:release/8.0Oct 3, 2023
This was referenced Oct 3, 2023
Closed
Closed
Closed
@radical
radical deleted the wasm-app-host-fix-v8 branch October 6, 2023 20:11
@ghostghost locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marafmarafmaraf approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner
+1 more reviewer
@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@radical@carlossanlop@kg@maraf
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[release/8.0][wasm] Use intended ports when running `DevServer` by radical · Pull Request #92906 · dotnet/runtime · GitHub
Skip to content
[release/8.0][wasm] Use intended ports when running DevServer - #92906
Merged
carlossanlop merged 5 commits into
dotnet:release/8.0from 
radical:wasm-app-host-fix-v8
Oct 3, 2023
Merged
[release/8.0][wasm] Use intended ports when running DevServer#92906
carlossanlop merged 5 commits into
dotnet:release/8.0from 
radical:wasm-app-host-fix-v8
Conversation
@radical
@radicalradical
commented
Oct 2, 2023•

edited

Loading

Copy link


Copy Markdown

Member
For running a wasm-browser application DevServer is used, but it always started the webserver on port 5000, because the selected ports weren't used by the DevServer, and thus used the defaults.
...
[] Unhandled exception. System.IO.IOException: Failed to bind to address http://127.0.0.1:5000: address already in use.
...

  • Also, ignore empty ASPNETCORE_URLS='' in the environment.
Fixes#91143 .
Customer impact
Every run for a wasmbrowser template (which is still only in the wasm-experimental workload) will use a random port for the webserver, instead of a fixed 5000, as intended.
Testing
Automated testing.
Impact
Low. This affects an experimental feature.
@radicalradical
added

arch-wasm
WebAssembly architecture
area-Build-mono

labels
Oct 2, 2023
@radical
radical
requested a review
from marafOctober 2, 2023 21:24
@ghostghost
assigned radicalOct 2, 2023
@ghost
ghost
commented
Oct 2, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
For running a wasm-browser application DevServer is used, but it always started the webserver on port 5000, because the selected ports weren't used by the DevServer, and thus used the defaults.
 Wasm.Build.Tests.TestAppScenarios.LibraryInitializerTests.LoadLibraryInitializer [STARTING]
Expected 0 exit code but got -532462766: C:\helix\work\workitem\e\dotnet-latest\dotnet.exe run -c Debug --no-build
Standard Output:
[] WasmAppHost --use-staticwebassets --runtime-config C:\helix\work\workitem\e\wbt\LibraryInitializerTests_LoadLibraryInitializer_dl4w1qgh_jty\bin\Debug\net8.0\WasmBasicTestApp.runtimeconfig.json
[] Unhandled exception. System.IO.IOException: Failed to bind to address http://127.0.0.1:5000: address already in use.
[] ---> Microsoft.AspNetCore.Connections.AddressInUseException: Only one usage of each socket address (protocol/network address/port) is normally permitted.
[] ---> System.Net.Sockets.SocketException (10048): Only one usage of each socket address (protocol/network address/port) is normally permitted.
[] at System.Net.Sockets.Socket.UpdateStatusAfterSocketErrorAndThrowException(SocketError error, Boolean disconnectOnFailure, String callerName)
[] at System.Net.Sockets.Socket.DoBind(EndPoint endPointSnapshot, SocketAddress socketAddress)
[] at System.Net.Sockets.Socket.Bind(EndPoint localEP)
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransportOptions.CreateDefaultBoundListenSocket(EndPoint endpoint)
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketConnectionListener.Bind()
[] --- End of inner exception stack trace ---
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketConnectionListener.Bind()
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransportFactory.BindAsync(EndPoint endpoint, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.TransportManager.BindAsync(EndPoint endPoint, ConnectionDelegate connectionDelegate, EndpointConfig endpointConfig, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.<>c__DisplayClass28_0`1.<<StartAsync>g__OnBind|0>d.MoveNext()
[] --- End of stack trace from previous location ---
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context, CancellationToken cancellationToken)
[] --- End of inner exception stack trace ---
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.LocalhostListenOptions.BindAsync(AddressBindContext context, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.DefaultAddressStrategy.BindAsync(AddressBindContext context, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindAsync(ListenOptions[] listenOptions, AddressBindContext context, Func`2 useHttps, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.BindAsync(CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.StartAsync[TContext](IHttpApplication`1 application, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Hosting.WebHost.StartAsync(CancellationToken cancellationToken)
[] at Microsoft.WebAssembly.AppHost.DevServer.DevServer.StartAsync(DevServerOptions options, ILogger logger, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.BrowserHost.StartWebServerAsync(BrowserArguments args, String[] urls, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.BrowserHost.RunAsync(ILoggerFactory loggerFactory, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.BrowserHost.InvokeAsync(CommonConfiguration commonArgs, ILoggerFactory loggerFactory, ILogger logger, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.WasmAppHost.Main(String[] args)
[] at Microsoft.WebAssembly.AppHost.WasmAppHost.<Main>(String[] args)

  • Also, ignore empty ASPNETCORE_URLS='' in the environment.
Fixes #88832 .
Author:radical
Assignees:-
Labels:
arch-wasm, area-Build-mono
Milestone:-
kg
kg
approved these changes
Oct 2, 2023
View reviewed changes
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Oct 2, 2023
@radicalradical
changed the title
[releaes/8.0][wasm] Use intended ports when running DevServer[release/8.0][wasm] Use intended ports when running DevServerOct 2, 2023
@radical
radical
commented
Oct 3, 2023

Copy link


Copy Markdown

MemberAuthor
Test failure is relevant.
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Oct 3, 2023
@carlossanlop
carlossanlop
commented
Oct 3, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics via email.
Test failure is relevant.
@radical ping me when the test failure is addressed so I can merge. I'll add the blocked label meanwhile.
@carlossanlopcarlossanlop
added
the 
blocked
Issue/PR is blocked on something - see comments
label
Oct 3, 2023
@marafmaraf
mentioned this pull request
Oct 3, 2023
 Merged

@build-analysisbuild-analysisBot
mentioned this pull request
Oct 3, 2023

Closed

@radicalradical
removed
the 
blocked
Issue/PR is blocked on something - see comments
label
Oct 3, 2023
@radical
radical
commented
Oct 3, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop this is ready.
@carlossanlop
carlossanlop
merged commit 0eeb6b2
into
dotnet:release/8.0Oct 3, 2023

This was referenced Oct 3, 2023
 Closed


Closed


Closed

@radical
radical
deleted the

wasm-app-host-fix-v8

branch
October 6, 2023 20:11
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 6, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marafmarafmaraf approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@carlossanlop@kg@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0][wasm] Use intended ports when running `DevServer` by radical · Pull Request #92906 · dotnet/runtime · GitHub
Skip to content
[release/8.0][wasm] Use intended ports when running DevServer - #92906
Merged
carlossanlop merged 5 commits into
dotnet:release/8.0from 
radical:wasm-app-host-fix-v8
Oct 3, 2023
Merged
[release/8.0][wasm] Use intended ports when running DevServer#92906
carlossanlop merged 5 commits into
dotnet:release/8.0from 
radical:wasm-app-host-fix-v8
Conversation
@radical
@radicalradical
commented
Oct 2, 2023•

edited

Loading

Copy link


Copy Markdown

Member
For running a wasm-browser application DevServer is used, but it always started the webserver on port 5000, because the selected ports weren't used by the DevServer, and thus used the defaults.
...
[] Unhandled exception. System.IO.IOException: Failed to bind to address http://127.0.0.1:5000: address already in use.
...

  • Also, ignore empty ASPNETCORE_URLS='' in the environment.
Fixes#91143 .
Customer impact
Every run for a wasmbrowser template (which is still only in the wasm-experimental workload) will use a random port for the webserver, instead of a fixed 5000, as intended.
Testing
Automated testing.
Impact
Low. This affects an experimental feature.
@radicalradical
added

arch-wasm
WebAssembly architecture
area-Build-mono

labels
Oct 2, 2023
@radical
radical
requested a review
from marafOctober 2, 2023 21:24
@ghostghost
assigned radicalOct 2, 2023
@ghost
ghost
commented
Oct 2, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
For running a wasm-browser application DevServer is used, but it always started the webserver on port 5000, because the selected ports weren't used by the DevServer, and thus used the defaults.
 Wasm.Build.Tests.TestAppScenarios.LibraryInitializerTests.LoadLibraryInitializer [STARTING]
Expected 0 exit code but got -532462766: C:\helix\work\workitem\e\dotnet-latest\dotnet.exe run -c Debug --no-build
Standard Output:
[] WasmAppHost --use-staticwebassets --runtime-config C:\helix\work\workitem\e\wbt\LibraryInitializerTests_LoadLibraryInitializer_dl4w1qgh_jty\bin\Debug\net8.0\WasmBasicTestApp.runtimeconfig.json
[] Unhandled exception. System.IO.IOException: Failed to bind to address http://127.0.0.1:5000: address already in use.
[] ---> Microsoft.AspNetCore.Connections.AddressInUseException: Only one usage of each socket address (protocol/network address/port) is normally permitted.
[] ---> System.Net.Sockets.SocketException (10048): Only one usage of each socket address (protocol/network address/port) is normally permitted.
[] at System.Net.Sockets.Socket.UpdateStatusAfterSocketErrorAndThrowException(SocketError error, Boolean disconnectOnFailure, String callerName)
[] at System.Net.Sockets.Socket.DoBind(EndPoint endPointSnapshot, SocketAddress socketAddress)
[] at System.Net.Sockets.Socket.Bind(EndPoint localEP)
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransportOptions.CreateDefaultBoundListenSocket(EndPoint endpoint)
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketConnectionListener.Bind()
[] --- End of inner exception stack trace ---
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketConnectionListener.Bind()
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransportFactory.BindAsync(EndPoint endpoint, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.TransportManager.BindAsync(EndPoint endPoint, ConnectionDelegate connectionDelegate, EndpointConfig endpointConfig, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.<>c__DisplayClass28_0`1.<<StartAsync>g__OnBind|0>d.MoveNext()
[] --- End of stack trace from previous location ---
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context, CancellationToken cancellationToken)
[] --- End of inner exception stack trace ---
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.LocalhostListenOptions.BindAsync(AddressBindContext context, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.DefaultAddressStrategy.BindAsync(AddressBindContext context, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindAsync(ListenOptions[] listenOptions, AddressBindContext context, Func`2 useHttps, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.BindAsync(CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.StartAsync[TContext](IHttpApplication`1 application, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Hosting.WebHost.StartAsync(CancellationToken cancellationToken)
[] at Microsoft.WebAssembly.AppHost.DevServer.DevServer.StartAsync(DevServerOptions options, ILogger logger, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.BrowserHost.StartWebServerAsync(BrowserArguments args, String[] urls, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.BrowserHost.RunAsync(ILoggerFactory loggerFactory, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.BrowserHost.InvokeAsync(CommonConfiguration commonArgs, ILoggerFactory loggerFactory, ILogger logger, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.WasmAppHost.Main(String[] args)
[] at Microsoft.WebAssembly.AppHost.WasmAppHost.<Main>(String[] args)

  • Also, ignore empty ASPNETCORE_URLS='' in the environment.
Fixes #88832 .
Author:radical
Assignees:-
Labels:
arch-wasm, area-Build-mono
Milestone:-
kg
kg
approved these changes
Oct 2, 2023
View reviewed changes
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Oct 2, 2023
@radicalradical
changed the title
[releaes/8.0][wasm] Use intended ports when running DevServer[release/8.0][wasm] Use intended ports when running DevServerOct 2, 2023
@radical
radical
commented
Oct 3, 2023

Copy link


Copy Markdown

MemberAuthor
Test failure is relevant.
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Oct 3, 2023
@carlossanlop
carlossanlop
commented
Oct 3, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics via email.
Test failure is relevant.
@radical ping me when the test failure is addressed so I can merge. I'll add the blocked label meanwhile.
@carlossanlopcarlossanlop
added
the 
blocked
Issue/PR is blocked on something - see comments
label
Oct 3, 2023
@marafmaraf
mentioned this pull request
Oct 3, 2023
 Merged

@build-analysisbuild-analysisBot
mentioned this pull request
Oct 3, 2023

Closed

@radicalradical
removed
the 
blocked
Issue/PR is blocked on something - see comments
label
Oct 3, 2023
@radical
radical
commented
Oct 3, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop this is ready.
@carlossanlop
carlossanlop
merged commit 0eeb6b2
into
dotnet:release/8.0Oct 3, 2023

This was referenced Oct 3, 2023
 Closed


Closed


Closed

@radical
radical
deleted the

wasm-app-host-fix-v8

branch
October 6, 2023 20:11
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 6, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marafmarafmaraf approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@carlossanlop@kg@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0][wasm] Use intended ports when running `DevServer` by radical · Pull Request #92906 · dotnet/runtime · GitHub
Skip to content
[release/8.0][wasm] Use intended ports when running DevServer - #92906
Merged
carlossanlop merged 5 commits into
dotnet:release/8.0from 
radical:wasm-app-host-fix-v8
Oct 3, 2023
Merged
[release/8.0][wasm] Use intended ports when running DevServer#92906
carlossanlop merged 5 commits into
dotnet:release/8.0from 
radical:wasm-app-host-fix-v8
Conversation
@radical
@radicalradical
commented
Oct 2, 2023•

edited

Loading

Copy link


Copy Markdown

Member
For running a wasm-browser application DevServer is used, but it always started the webserver on port 5000, because the selected ports weren't used by the DevServer, and thus used the defaults.
...
[] Unhandled exception. System.IO.IOException: Failed to bind to address http://127.0.0.1:5000: address already in use.
...

  • Also, ignore empty ASPNETCORE_URLS='' in the environment.
Fixes#91143 .
Customer impact
Every run for a wasmbrowser template (which is still only in the wasm-experimental workload) will use a random port for the webserver, instead of a fixed 5000, as intended.
Testing
Automated testing.
Impact
Low. This affects an experimental feature.
@radicalradical
added

arch-wasm
WebAssembly architecture
area-Build-mono

labels
Oct 2, 2023
@radical
radical
requested a review
from marafOctober 2, 2023 21:24
@ghostghost
assigned radicalOct 2, 2023
@ghost
ghost
commented
Oct 2, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
For running a wasm-browser application DevServer is used, but it always started the webserver on port 5000, because the selected ports weren't used by the DevServer, and thus used the defaults.
 Wasm.Build.Tests.TestAppScenarios.LibraryInitializerTests.LoadLibraryInitializer [STARTING]
Expected 0 exit code but got -532462766: C:\helix\work\workitem\e\dotnet-latest\dotnet.exe run -c Debug --no-build
Standard Output:
[] WasmAppHost --use-staticwebassets --runtime-config C:\helix\work\workitem\e\wbt\LibraryInitializerTests_LoadLibraryInitializer_dl4w1qgh_jty\bin\Debug\net8.0\WasmBasicTestApp.runtimeconfig.json
[] Unhandled exception. System.IO.IOException: Failed to bind to address http://127.0.0.1:5000: address already in use.
[] ---> Microsoft.AspNetCore.Connections.AddressInUseException: Only one usage of each socket address (protocol/network address/port) is normally permitted.
[] ---> System.Net.Sockets.SocketException (10048): Only one usage of each socket address (protocol/network address/port) is normally permitted.
[] at System.Net.Sockets.Socket.UpdateStatusAfterSocketErrorAndThrowException(SocketError error, Boolean disconnectOnFailure, String callerName)
[] at System.Net.Sockets.Socket.DoBind(EndPoint endPointSnapshot, SocketAddress socketAddress)
[] at System.Net.Sockets.Socket.Bind(EndPoint localEP)
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransportOptions.CreateDefaultBoundListenSocket(EndPoint endpoint)
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketConnectionListener.Bind()
[] --- End of inner exception stack trace ---
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketConnectionListener.Bind()
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransportFactory.BindAsync(EndPoint endpoint, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.TransportManager.BindAsync(EndPoint endPoint, ConnectionDelegate connectionDelegate, EndpointConfig endpointConfig, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.<>c__DisplayClass28_0`1.<<StartAsync>g__OnBind|0>d.MoveNext()
[] --- End of stack trace from previous location ---
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context, CancellationToken cancellationToken)
[] --- End of inner exception stack trace ---
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.LocalhostListenOptions.BindAsync(AddressBindContext context, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.DefaultAddressStrategy.BindAsync(AddressBindContext context, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindAsync(ListenOptions[] listenOptions, AddressBindContext context, Func`2 useHttps, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.BindAsync(CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.StartAsync[TContext](IHttpApplication`1 application, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Hosting.WebHost.StartAsync(CancellationToken cancellationToken)
[] at Microsoft.WebAssembly.AppHost.DevServer.DevServer.StartAsync(DevServerOptions options, ILogger logger, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.BrowserHost.StartWebServerAsync(BrowserArguments args, String[] urls, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.BrowserHost.RunAsync(ILoggerFactory loggerFactory, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.BrowserHost.InvokeAsync(CommonConfiguration commonArgs, ILoggerFactory loggerFactory, ILogger logger, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.WasmAppHost.Main(String[] args)
[] at Microsoft.WebAssembly.AppHost.WasmAppHost.<Main>(String[] args)

  • Also, ignore empty ASPNETCORE_URLS='' in the environment.
Fixes #88832 .
Author:radical
Assignees:-
Labels:
arch-wasm, area-Build-mono
Milestone:-
kg
kg
approved these changes
Oct 2, 2023
View reviewed changes
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Oct 2, 2023
@radicalradical
changed the title
[releaes/8.0][wasm] Use intended ports when running DevServer[release/8.0][wasm] Use intended ports when running DevServerOct 2, 2023
@radical
radical
commented
Oct 3, 2023

Copy link


Copy Markdown

MemberAuthor
Test failure is relevant.
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Oct 3, 2023
@carlossanlop
carlossanlop
commented
Oct 3, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics via email.
Test failure is relevant.
@radical ping me when the test failure is addressed so I can merge. I'll add the blocked label meanwhile.
@carlossanlopcarlossanlop
added
the 
blocked
Issue/PR is blocked on something - see comments
label
Oct 3, 2023
@marafmaraf
mentioned this pull request
Oct 3, 2023
 Merged

@build-analysisbuild-analysisBot
mentioned this pull request
Oct 3, 2023

Closed

@radicalradical
removed
the 
blocked
Issue/PR is blocked on something - see comments
label
Oct 3, 2023
@radical
radical
commented
Oct 3, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop this is ready.
@carlossanlop
carlossanlop
merged commit 0eeb6b2
into
dotnet:release/8.0Oct 3, 2023

This was referenced Oct 3, 2023
 Closed


Closed


Closed

@radical
radical
deleted the

wasm-app-host-fix-v8

branch
October 6, 2023 20:11
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 6, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marafmarafmaraf approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@carlossanlop@kg@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[release/8.0][wasm] Use intended ports when running `DevServer` by radical · Pull Request #92906 · dotnet/runtime · GitHub
Skip to content
[release/8.0][wasm] Use intended ports when running DevServer - #92906
Merged
carlossanlop merged 5 commits into
dotnet:release/8.0from 
radical:wasm-app-host-fix-v8
Oct 3, 2023
Merged
[release/8.0][wasm] Use intended ports when running DevServer#92906
carlossanlop merged 5 commits into
dotnet:release/8.0from 
radical:wasm-app-host-fix-v8
Conversation
@radical
@radicalradical
commented
Oct 2, 2023•

edited

Loading

Copy link


Copy Markdown

Member
For running a wasm-browser application DevServer is used, but it always started the webserver on port 5000, because the selected ports weren't used by the DevServer, and thus used the defaults.
...
[] Unhandled exception. System.IO.IOException: Failed to bind to address http://127.0.0.1:5000: address already in use.
...

  • Also, ignore empty ASPNETCORE_URLS='' in the environment.
Fixes#91143 .
Customer impact
Every run for a wasmbrowser template (which is still only in the wasm-experimental workload) will use a random port for the webserver, instead of a fixed 5000, as intended.
Testing
Automated testing.
Impact
Low. This affects an experimental feature.
@radicalradical
added

arch-wasm
WebAssembly architecture
area-Build-mono

labels
Oct 2, 2023
@radical
radical
requested a review
from marafOctober 2, 2023 21:24
@ghostghost
assigned radicalOct 2, 2023
@ghost
ghost
commented
Oct 2, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
For running a wasm-browser application DevServer is used, but it always started the webserver on port 5000, because the selected ports weren't used by the DevServer, and thus used the defaults.
 Wasm.Build.Tests.TestAppScenarios.LibraryInitializerTests.LoadLibraryInitializer [STARTING]
Expected 0 exit code but got -532462766: C:\helix\work\workitem\e\dotnet-latest\dotnet.exe run -c Debug --no-build
Standard Output:
[] WasmAppHost --use-staticwebassets --runtime-config C:\helix\work\workitem\e\wbt\LibraryInitializerTests_LoadLibraryInitializer_dl4w1qgh_jty\bin\Debug\net8.0\WasmBasicTestApp.runtimeconfig.json
[] Unhandled exception. System.IO.IOException: Failed to bind to address http://127.0.0.1:5000: address already in use.
[] ---> Microsoft.AspNetCore.Connections.AddressInUseException: Only one usage of each socket address (protocol/network address/port) is normally permitted.
[] ---> System.Net.Sockets.SocketException (10048): Only one usage of each socket address (protocol/network address/port) is normally permitted.
[] at System.Net.Sockets.Socket.UpdateStatusAfterSocketErrorAndThrowException(SocketError error, Boolean disconnectOnFailure, String callerName)
[] at System.Net.Sockets.Socket.DoBind(EndPoint endPointSnapshot, SocketAddress socketAddress)
[] at System.Net.Sockets.Socket.Bind(EndPoint localEP)
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransportOptions.CreateDefaultBoundListenSocket(EndPoint endpoint)
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketConnectionListener.Bind()
[] --- End of inner exception stack trace ---
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketConnectionListener.Bind()
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransportFactory.BindAsync(EndPoint endpoint, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.TransportManager.BindAsync(EndPoint endPoint, ConnectionDelegate connectionDelegate, EndpointConfig endpointConfig, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.<>c__DisplayClass28_0`1.<<StartAsync>g__OnBind|0>d.MoveNext()
[] --- End of stack trace from previous location ---
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context, CancellationToken cancellationToken)
[] --- End of inner exception stack trace ---
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.LocalhostListenOptions.BindAsync(AddressBindContext context, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.DefaultAddressStrategy.BindAsync(AddressBindContext context, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindAsync(ListenOptions[] listenOptions, AddressBindContext context, Func`2 useHttps, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.BindAsync(CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.StartAsync[TContext](IHttpApplication`1 application, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Hosting.WebHost.StartAsync(CancellationToken cancellationToken)
[] at Microsoft.WebAssembly.AppHost.DevServer.DevServer.StartAsync(DevServerOptions options, ILogger logger, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.BrowserHost.StartWebServerAsync(BrowserArguments args, String[] urls, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.BrowserHost.RunAsync(ILoggerFactory loggerFactory, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.BrowserHost.InvokeAsync(CommonConfiguration commonArgs, ILoggerFactory loggerFactory, ILogger logger, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.WasmAppHost.Main(String[] args)
[] at Microsoft.WebAssembly.AppHost.WasmAppHost.<Main>(String[] args)

  • Also, ignore empty ASPNETCORE_URLS='' in the environment.
Fixes #88832 .
Author:radical
Assignees:-
Labels:
arch-wasm, area-Build-mono
Milestone:-
kg
kg
approved these changes
Oct 2, 2023
View reviewed changes
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Oct 2, 2023
@radicalradical
changed the title
[releaes/8.0][wasm] Use intended ports when running DevServer[release/8.0][wasm] Use intended ports when running DevServerOct 2, 2023
@radical
radical
commented
Oct 3, 2023

Copy link


Copy Markdown

MemberAuthor
Test failure is relevant.
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Oct 3, 2023
@carlossanlop
carlossanlop
commented
Oct 3, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics via email.
Test failure is relevant.
@radical ping me when the test failure is addressed so I can merge. I'll add the blocked label meanwhile.
@carlossanlopcarlossanlop
added
the 
blocked
Issue/PR is blocked on something - see comments
label
Oct 3, 2023
@marafmaraf
mentioned this pull request
Oct 3, 2023
 Merged

@build-analysisbuild-analysisBot
mentioned this pull request
Oct 3, 2023

Closed

@radicalradical
removed
the 
blocked
Issue/PR is blocked on something - see comments
label
Oct 3, 2023
@radical
radical
commented
Oct 3, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop this is ready.
@carlossanlop
carlossanlop
merged commit 0eeb6b2
into
dotnet:release/8.0Oct 3, 2023

This was referenced Oct 3, 2023
 Closed


Closed


Closed

@radical
radical
deleted the

wasm-app-host-fix-v8

branch
October 6, 2023 20:11
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 6, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marafmarafmaraf approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@carlossanlop@kg@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0][wasm] Use intended ports when running `DevServer` by radical · Pull Request #92906 · dotnet/runtime · GitHub
Skip to content
[release/8.0][wasm] Use intended ports when running DevServer - #92906
Merged
carlossanlop merged 5 commits into
dotnet:release/8.0from 
radical:wasm-app-host-fix-v8
Oct 3, 2023
Merged
[release/8.0][wasm] Use intended ports when running DevServer#92906
carlossanlop merged 5 commits into
dotnet:release/8.0from 
radical:wasm-app-host-fix-v8
Conversation
@radical
@radicalradical
commented
Oct 2, 2023•

edited

Loading

Copy link


Copy Markdown

Member
For running a wasm-browser application DevServer is used, but it always started the webserver on port 5000, because the selected ports weren't used by the DevServer, and thus used the defaults.
...
[] Unhandled exception. System.IO.IOException: Failed to bind to address http://127.0.0.1:5000: address already in use.
...

  • Also, ignore empty ASPNETCORE_URLS='' in the environment.
Fixes#91143 .
Customer impact
Every run for a wasmbrowser template (which is still only in the wasm-experimental workload) will use a random port for the webserver, instead of a fixed 5000, as intended.
Testing
Automated testing.
Impact
Low. This affects an experimental feature.
@radicalradical
added

arch-wasm
WebAssembly architecture
area-Build-mono

labels
Oct 2, 2023
@radical
radical
requested a review
from marafOctober 2, 2023 21:24
@ghostghost
assigned radicalOct 2, 2023
@ghost
ghost
commented
Oct 2, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
For running a wasm-browser application DevServer is used, but it always started the webserver on port 5000, because the selected ports weren't used by the DevServer, and thus used the defaults.
 Wasm.Build.Tests.TestAppScenarios.LibraryInitializerTests.LoadLibraryInitializer [STARTING]
Expected 0 exit code but got -532462766: C:\helix\work\workitem\e\dotnet-latest\dotnet.exe run -c Debug --no-build
Standard Output:
[] WasmAppHost --use-staticwebassets --runtime-config C:\helix\work\workitem\e\wbt\LibraryInitializerTests_LoadLibraryInitializer_dl4w1qgh_jty\bin\Debug\net8.0\WasmBasicTestApp.runtimeconfig.json
[] Unhandled exception. System.IO.IOException: Failed to bind to address http://127.0.0.1:5000: address already in use.
[] ---> Microsoft.AspNetCore.Connections.AddressInUseException: Only one usage of each socket address (protocol/network address/port) is normally permitted.
[] ---> System.Net.Sockets.SocketException (10048): Only one usage of each socket address (protocol/network address/port) is normally permitted.
[] at System.Net.Sockets.Socket.UpdateStatusAfterSocketErrorAndThrowException(SocketError error, Boolean disconnectOnFailure, String callerName)
[] at System.Net.Sockets.Socket.DoBind(EndPoint endPointSnapshot, SocketAddress socketAddress)
[] at System.Net.Sockets.Socket.Bind(EndPoint localEP)
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransportOptions.CreateDefaultBoundListenSocket(EndPoint endpoint)
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketConnectionListener.Bind()
[] --- End of inner exception stack trace ---
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketConnectionListener.Bind()
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransportFactory.BindAsync(EndPoint endpoint, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.TransportManager.BindAsync(EndPoint endPoint, ConnectionDelegate connectionDelegate, EndpointConfig endpointConfig, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.<>c__DisplayClass28_0`1.<<StartAsync>g__OnBind|0>d.MoveNext()
[] --- End of stack trace from previous location ---
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context, CancellationToken cancellationToken)
[] --- End of inner exception stack trace ---
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.LocalhostListenOptions.BindAsync(AddressBindContext context, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.DefaultAddressStrategy.BindAsync(AddressBindContext context, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindAsync(ListenOptions[] listenOptions, AddressBindContext context, Func`2 useHttps, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.BindAsync(CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.StartAsync[TContext](IHttpApplication`1 application, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Hosting.WebHost.StartAsync(CancellationToken cancellationToken)
[] at Microsoft.WebAssembly.AppHost.DevServer.DevServer.StartAsync(DevServerOptions options, ILogger logger, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.BrowserHost.StartWebServerAsync(BrowserArguments args, String[] urls, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.BrowserHost.RunAsync(ILoggerFactory loggerFactory, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.BrowserHost.InvokeAsync(CommonConfiguration commonArgs, ILoggerFactory loggerFactory, ILogger logger, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.WasmAppHost.Main(String[] args)
[] at Microsoft.WebAssembly.AppHost.WasmAppHost.<Main>(String[] args)

  • Also, ignore empty ASPNETCORE_URLS='' in the environment.
Fixes #88832 .
Author:radical
Assignees:-
Labels:
arch-wasm, area-Build-mono
Milestone:-
kg
kg
approved these changes
Oct 2, 2023
View reviewed changes
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Oct 2, 2023
@radicalradical
changed the title
[releaes/8.0][wasm] Use intended ports when running DevServer[release/8.0][wasm] Use intended ports when running DevServerOct 2, 2023
@radical
radical
commented
Oct 3, 2023

Copy link


Copy Markdown

MemberAuthor
Test failure is relevant.
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Oct 3, 2023
@carlossanlop
carlossanlop
commented
Oct 3, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics via email.
Test failure is relevant.
@radical ping me when the test failure is addressed so I can merge. I'll add the blocked label meanwhile.
@carlossanlopcarlossanlop
added
the 
blocked
Issue/PR is blocked on something - see comments
label
Oct 3, 2023
@marafmaraf
mentioned this pull request
Oct 3, 2023
 Merged

@build-analysisbuild-analysisBot
mentioned this pull request
Oct 3, 2023

Closed

@radicalradical
removed
the 
blocked
Issue/PR is blocked on something - see comments
label
Oct 3, 2023
@radical
radical
commented
Oct 3, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop this is ready.
@carlossanlop
carlossanlop
merged commit 0eeb6b2
into
dotnet:release/8.0Oct 3, 2023

This was referenced Oct 3, 2023
 Closed


Closed


Closed

@radical
radical
deleted the

wasm-app-host-fix-v8

branch
October 6, 2023 20:11
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 6, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marafmarafmaraf approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@carlossanlop@kg@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[release/8.0][wasm] Use intended ports when running `DevServer` by radical · Pull Request #92906 · dotnet/runtime · GitHub
Skip to content
[release/8.0][wasm] Use intended ports when running DevServer - #92906
Merged
carlossanlop merged 5 commits into
dotnet:release/8.0from 
radical:wasm-app-host-fix-v8
Oct 3, 2023
Merged
[release/8.0][wasm] Use intended ports when running DevServer#92906
carlossanlop merged 5 commits into
dotnet:release/8.0from 
radical:wasm-app-host-fix-v8
Conversation
@radical
@radicalradical
commented
Oct 2, 2023•

edited

Loading

Copy link


Copy Markdown

Member
For running a wasm-browser application DevServer is used, but it always started the webserver on port 5000, because the selected ports weren't used by the DevServer, and thus used the defaults.
...
[] Unhandled exception. System.IO.IOException: Failed to bind to address http://127.0.0.1:5000: address already in use.
...

  • Also, ignore empty ASPNETCORE_URLS='' in the environment.
Fixes#91143 .
Customer impact
Every run for a wasmbrowser template (which is still only in the wasm-experimental workload) will use a random port for the webserver, instead of a fixed 5000, as intended.
Testing
Automated testing.
Impact
Low. This affects an experimental feature.
@radicalradical
added

arch-wasm
WebAssembly architecture
area-Build-mono

labels
Oct 2, 2023
@radical
radical
requested a review
from marafOctober 2, 2023 21:24
@ghostghost
assigned radicalOct 2, 2023
@ghost
ghost
commented
Oct 2, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
For running a wasm-browser application DevServer is used, but it always started the webserver on port 5000, because the selected ports weren't used by the DevServer, and thus used the defaults.
 Wasm.Build.Tests.TestAppScenarios.LibraryInitializerTests.LoadLibraryInitializer [STARTING]
Expected 0 exit code but got -532462766: C:\helix\work\workitem\e\dotnet-latest\dotnet.exe run -c Debug --no-build
Standard Output:
[] WasmAppHost --use-staticwebassets --runtime-config C:\helix\work\workitem\e\wbt\LibraryInitializerTests_LoadLibraryInitializer_dl4w1qgh_jty\bin\Debug\net8.0\WasmBasicTestApp.runtimeconfig.json
[] Unhandled exception. System.IO.IOException: Failed to bind to address http://127.0.0.1:5000: address already in use.
[] ---> Microsoft.AspNetCore.Connections.AddressInUseException: Only one usage of each socket address (protocol/network address/port) is normally permitted.
[] ---> System.Net.Sockets.SocketException (10048): Only one usage of each socket address (protocol/network address/port) is normally permitted.
[] at System.Net.Sockets.Socket.UpdateStatusAfterSocketErrorAndThrowException(SocketError error, Boolean disconnectOnFailure, String callerName)
[] at System.Net.Sockets.Socket.DoBind(EndPoint endPointSnapshot, SocketAddress socketAddress)
[] at System.Net.Sockets.Socket.Bind(EndPoint localEP)
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransportOptions.CreateDefaultBoundListenSocket(EndPoint endpoint)
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketConnectionListener.Bind()
[] --- End of inner exception stack trace ---
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketConnectionListener.Bind()
[] at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransportFactory.BindAsync(EndPoint endpoint, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.TransportManager.BindAsync(EndPoint endPoint, ConnectionDelegate connectionDelegate, EndpointConfig endpointConfig, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.<>c__DisplayClass28_0`1.<<StartAsync>g__OnBind|0>d.MoveNext()
[] --- End of stack trace from previous location ---
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context, CancellationToken cancellationToken)
[] --- End of inner exception stack trace ---
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.LocalhostListenOptions.BindAsync(AddressBindContext context, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.DefaultAddressStrategy.BindAsync(AddressBindContext context, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindAsync(ListenOptions[] listenOptions, AddressBindContext context, Func`2 useHttps, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.BindAsync(CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.StartAsync[TContext](IHttpApplication`1 application, CancellationToken cancellationToken)
[] at Microsoft.AspNetCore.Hosting.WebHost.StartAsync(CancellationToken cancellationToken)
[] at Microsoft.WebAssembly.AppHost.DevServer.DevServer.StartAsync(DevServerOptions options, ILogger logger, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.BrowserHost.StartWebServerAsync(BrowserArguments args, String[] urls, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.BrowserHost.RunAsync(ILoggerFactory loggerFactory, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.BrowserHost.InvokeAsync(CommonConfiguration commonArgs, ILoggerFactory loggerFactory, ILogger logger, CancellationToken token)
[] at Microsoft.WebAssembly.AppHost.WasmAppHost.Main(String[] args)
[] at Microsoft.WebAssembly.AppHost.WasmAppHost.<Main>(String[] args)

  • Also, ignore empty ASPNETCORE_URLS='' in the environment.
Fixes #88832 .
Author:radical
Assignees:-
Labels:
arch-wasm, area-Build-mono
Milestone:-
kg
kg
approved these changes
Oct 2, 2023
View reviewed changes
@radicalradical
added
the 
Servicing-consider
Issue for next servicing release review
label
Oct 2, 2023
@radicalradical
changed the title
[releaes/8.0][wasm] Use intended ports when running DevServer[release/8.0][wasm] Use intended ports when running DevServerOct 2, 2023
@radical
radical
commented
Oct 3, 2023

Copy link


Copy Markdown

MemberAuthor
Test failure is relevant.
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Oct 3, 2023
@carlossanlop
carlossanlop
commented
Oct 3, 2023

Copy link


Copy Markdown

Contributor
Approved by Tactics via email.
Test failure is relevant.
@radical ping me when the test failure is addressed so I can merge. I'll add the blocked label meanwhile.
@carlossanlopcarlossanlop
added
the 
blocked
Issue/PR is blocked on something - see comments
label
Oct 3, 2023
@marafmaraf
mentioned this pull request
Oct 3, 2023
 Merged

@build-analysisbuild-analysisBot
mentioned this pull request
Oct 3, 2023

Closed

@radicalradical
removed
the 
blocked
Issue/PR is blocked on something - see comments
label
Oct 3, 2023
@radical
radical
commented
Oct 3, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop this is ready.
@carlossanlop
carlossanlop
merged commit 0eeb6b2
into
dotnet:release/8.0Oct 3, 2023

This was referenced Oct 3, 2023
 Closed


Closed


Closed

@radical
radical
deleted the

wasm-app-host-fix-v8

branch
October 6, 2023 20:11
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 6, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marafmarafmaraf approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@carlossanlop@kg@maraf