Report StackOverflowException on NativeAOT on Linux - #93901

Closed
jtschuster wants to merge 118 commits into
dotnet:mainfrom
jtschuster:StackOverflowLinuxNAOT
Closed

Report StackOverflowException on NativeAOT on Linux#93901
jtschuster wants to merge 118 commits into
dotnet:mainfrom
jtschuster:StackOverflowLinuxNAOT

Conversation

@jtschuster

@jtschusterjtschuster commented Oct 24, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Uses almost the same code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.

Fixes#82334

@jtschuster
Report stack overflow in linux
8260630
Use SA_ONSTACK for SIGSEGV handler
Call sigaltstack() to set the alternate stack on the main thread only
Check if faulting address is near the stack pointer, if so, report stack overflow
@jtschuster
Set up signal alternate stack on all new threads
263262c
@jtschuster
Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto StackOv…
adc342f
…erflowLinuxNAOT
@jtschuster
Add test to naot smoke tests
666d231
@ghostghost assigned jtschusterOct 24, 2023
@ghost

ghost commented Oct 24, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Uses almost the same code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.

Author:jtschuster
Assignees:jtschuster
Labels:

area-NativeAOT-coreclr

Milestone:-

@jkotas
jkotas requested a review from janvorliOctober 24, 2023 02:39
jkotas
jkotas reviewed Oct 24, 2023
View reviewed changes
Comment threadsrc/coreclr/nativeaot/Runtime/unix/HardwareExceptions.cpp Outdated
@build-analysisbuild-analysisBot mentioned this pull request Oct 24, 2023
Closed
janvorli
janvorli approved these changes Oct 24, 2023
View reviewed changes

@janvorlijanvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the nit comment

Comment threadsrc/coreclr/nativeaot/Runtime/thread.cpp Outdated
jkotas
jkotas reviewed Oct 24, 2023
View reviewed changes
Comment threadsrc/tests/nativeaot/SmokeTests/StackOverflowReporting/Program.cs Outdated
@janvorli

janvorli commented Oct 24, 2023

Copy link
Copy Markdown
Member

One thing I wonder about - don't we also want to call PalRaiseFailFastException instead of RhFailFast (like we do on Windows for stack overflow in RhpVectoredExceptionHandler)?

@jkotas

jkotas commented Oct 24, 2023

Copy link
Copy Markdown
Member

One thing I wonder about - don't we also want to call PalRaiseFailFastException instead of RhFailFast (like we do on Windows for stack overflow in RhpVectoredExceptionHandler)?

RhFailFast calls PalRaiseFailFastException with default arguments. I do not think calling PalRaiseFailFastException in this change would make any difference.

@janvorli

janvorli commented Oct 24, 2023

Copy link
Copy Markdown
Member

Ah, thank you, I've missed that.

@jtschuster

jtschuster commented Oct 24, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-nativeaot-outerloop

@azure-pipelines

azure-pipelinesBot commented Oct 24, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jtschuster

jtschuster commented Oct 25, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-nativeaot-outerloop

@azure-pipelines

azure-pipelinesBot commented Oct 25, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 27, 2023
Closed
Closed
MichalStrehovsky
MichalStrehovsky reviewed Oct 27, 2023
View reviewed changes
Comment threadsrc/tests/baseservices/exceptions/stackoverflow/stackoverflowtester.cs Outdated
Comment threadsrc/tests/Directory.Build.targets Outdated
@janvorli

janvorli commented Oct 27, 2023

Copy link
Copy Markdown
Member

@jtschuster I am not sure if merging of the tests into a single exe won't complicate the work on merging coreclr tests that @trylek works on. I wonder what the reason for this change was.

pavelsavaraand others added 11 commits November 7, 2023 11:32
@pavelsavara
[browser][MT] fix stale memory on suspended thread (dotnet#94299)
bd27e27
@pavelsavara
[browser] allow zero as debug level (dotnet#94456)
5de6ca4
@jakobbotsch
JIT: Remove dead GT_NOP code in LSRA (dotnet#94409)
85d3773
Rationalization removes all GT_NOP nodes, and we do not seem to
introduce any of these before LSRA (and especially not the typed
"passthrough" GT_NOP nodes). This code is just wrong for the passthrough
nodes, so just switch all the LSRA code to only handle potential void
NOPs.
Fixdotnet#93048
@dotnet-maestro
[main] Update dependencies from dotnet/installer (dotnet#94462)
50d4a99
Microsoft.Dotnet.Sdk.Internal
From Version 9.0.100-alpha.1.23554.1 -> To Version 9.0.100-alpha.1.23557.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@DrewScoggins
Add file handle limit setting for Alpine (dotnet#94439)
b0e1627
* Add file handle limit setting for Alpine
Alpine does not automatically increase the file handle limit to the maximum. dotnet#82719 (comment)
As a result we need to increase the limit manually, as we are seeing "Too many files" errors.
* Bump limit to hard cap
* Remove space
@MichalStrehovsky
Do not release frozen segment if we failed extending it (dotnet#94450)
021ecb8
Maybe I'm missing something, but if we try to commit more of the reserved segment and this fails, it doesn't feel right to release the whole thing. The previously committed part of the segment is still in use.
@ViktorHofer
Use live M.Bcl.AsyncInterfaces dependency (dotnet#94451)
4feec00
* Use live M.Bcl.AsyncInterfaces dependency
* Update Microsoft.Bcl.TimeProvider.csproj
@cincuranet
Add option for R2R configured runs. (dotnet#94412)
2801995
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/source-build-exter…
4d2ef11
…nals build 20231106.2 (dotnet#94463)
Microsoft.SourceBuild.Intermediate.source-build-externals
From Version 9.0.0-alpha.1.23530.1 -> To Version 9.0.0-alpha.1.23556.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@jtschuster
Merge branch 'StackOverflowLinuxNAOT' ofhttps://github.com/jtschuste…
8b6b9cd
…r/runtime into StackOverflowLinuxNAOT
@jtschuster
Use IsSingleFile and update Main signature
4aa9912
@jtschuster
jtschuster marked this pull request as draft November 7, 2023 19:12
@jtschusterjtschuster mentioned this pull request Nov 7, 2023
Merged
@jtschuster

jtschuster commented Nov 7, 2023

Copy link
Copy Markdown
MemberAuthor

I made some mistake when I pulled main back into this branch. Closing this PR and opened a new one.

@build-analysisbuild-analysisBot mentioned this pull request Nov 7, 2023
Closed
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 8, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@agockeagockeagocke left review comments
@jkotasjkotasjkotas left review comments
@MichalStrehovskyMichalStrehovskyMichalStrehovsky left review comments
@janvorlijanvorlijanvorli approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomersbomer is a code owner
@radicalradicalAwaiting requested review from radical
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner
@thaystgthaystgAwaiting requested review from thaystg
@kgkgAwaiting requested review from kg
@vargazvargazAwaiting requested review from vargaz
@lambdageeklambdageekAwaiting requested review from lambdageek
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmiloskotlarmilos is a code owner
@fanyang-monofanyang-monoAwaiting requested review from fanyang-mono
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger will be requested when the pull request is marked ready for reviewakoeplinger is a code owner
@marafmarafAwaiting requested review from marafmaraf will be requested when the pull request is marked ready for reviewmaraf is a code owner
@ilonatommyilonatommyAwaiting requested review from ilonatommyilonatommy will be requested when the pull request is marked ready for reviewilonatommy is a code owner
@steveisoksteveisokAwaiting requested review from steveisoksteveisok will be requested when the pull request is marked ready for reviewsteveisok is a code owner
@vitek-karasvitek-karasAwaiting requested review from vitek-karasvitek-karas will be requested when the pull request is marked ready for reviewvitek-karas is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@jtschusterjtschuster

Labels

area-NativeAOT-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[NativeAOT] Stackoverflow reporting on Linux

20 participants

@jtschuster@janvorli@jkotas@MichalStrehovsky@agocke@trylek@AndyAyersMS@wfurt@ViktorHofer@tannergooding@kouvel@pavelsavara@yurai007@mkhamoyan@vitek-karas@kg@ilonatommy@pentp@BruceForstall@hoyosjs
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Report StackOverflowException on NativeAOT on Linux - #93901
Closed
jtschuster wants to merge 118 commits into
dotnet:mainfrom 
jtschuster:StackOverflowLinuxNAOT
Closed
Report StackOverflowException on NativeAOT on Linux#93901
jtschuster wants to merge 118 commits into
dotnet:mainfrom 
jtschuster:StackOverflowLinuxNAOT
Conversation
@jtschuster
@jtschusterjtschuster
commented
Oct 24, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Uses almost the same code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.
Fixes#82334
@jtschuster
Report stack overflow in linux
8260630
Use SA_ONSTACK for SIGSEGV handler
Call sigaltstack() to set the alternate stack on the main thread only
Check if faulting address is near the stack pointer, if so, report stack overflow
@jtschuster
Set up signal alternate stack on all new threads
263262c
@jtschuster
Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto StackOv…
adc342f
…erflowLinuxNAOT
@jtschuster
Add test to naot smoke tests
666d231
@ghostghost
assigned jtschusterOct 24, 2023
@ghost
ghost
commented
Oct 24, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas

See info in area-owners.md if you want to be subscribed.
Issue Details
Uses almost the same code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.
Author:jtschuster
Assignees:jtschuster
Labels:
area-NativeAOT-coreclr
Milestone:-
@jkotas
jkotas
requested a review
from janvorliOctober 24, 2023 02:39
jkotas
jkotas
reviewed
Oct 24, 2023
View reviewed changes
Comment threadsrc/coreclr/nativeaot/Runtime/unix/HardwareExceptions.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Oct 24, 2023

Closed

janvorli
janvorli
approved these changes
Oct 24, 2023
View reviewed changes
@janvorlijanvorli
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the nit comment
Comment threadsrc/coreclr/nativeaot/Runtime/thread.cpp
Outdated

jkotas
jkotas
reviewed
Oct 24, 2023
View reviewed changes
Comment threadsrc/tests/nativeaot/SmokeTests/StackOverflowReporting/Program.cs
Outdated

@janvorli
janvorli
commented
Oct 24, 2023

Copy link


Copy Markdown

Member
One thing I wonder about - don't we also want to call PalRaiseFailFastException instead of RhFailFast (like we do on Windows for stack overflow in RhpVectoredExceptionHandler)?
@jkotas
jkotas
commented
Oct 24, 2023

Copy link


Copy Markdown

Member
One thing I wonder about - don't we also want to call PalRaiseFailFastException instead of RhFailFast (like we do on Windows for stack overflow in RhpVectoredExceptionHandler)?
RhFailFast calls PalRaiseFailFastException with default arguments. I do not think calling PalRaiseFailFastException in this change would make any difference.
@janvorli
janvorli
commented
Oct 24, 2023

Copy link


Copy Markdown

Member
Ah, thank you, I've missed that.
@jtschuster
jtschuster
commented
Oct 24, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-nativeaot-outerloop
@azure-pipelines
azure-pipelinesBot
commented
Oct 24, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@jtschuster
jtschuster
commented
Oct 25, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-nativeaot-outerloop
@azure-pipelines
azure-pipelinesBot
commented
Oct 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 27, 2023

Closed


Closed

MichalStrehovsky
MichalStrehovsky
reviewed
Oct 27, 2023
View reviewed changes
Comment threadsrc/tests/baseservices/exceptions/stackoverflow/stackoverflowtester.cs
Outdated

Comment threadsrc/tests/Directory.Build.targets
Outdated

@janvorli
janvorli
commented
Oct 27, 2023

Copy link


Copy Markdown

Member
@jtschuster I am not sure if merging of the tests into a single exe won't complicate the work on merging coreclr tests that @trylek works on. I wonder what the reason for this change was.
pavelsavaraand others
added 11 commits
November 7, 2023 11:32
@pavelsavara
[browser][MT] fix stale memory on suspended thread (dotnet#94299)
bd27e27
@pavelsavara
[browser] allow zero as debug level (dotnet#94456)
5de6ca4
@jakobbotsch
JIT: Remove dead GT_NOP code in LSRA (dotnet#94409)
85d3773
Rationalization removes all GT_NOP nodes, and we do not seem to
introduce any of these before LSRA (and especially not the typed
"passthrough" GT_NOP nodes). This code is just wrong for the passthrough
nodes, so just switch all the LSRA code to only handle potential void
NOPs.
Fixdotnet#93048
@dotnet-maestro
[main] Update dependencies from dotnet/installer (dotnet#94462)
50d4a99
Microsoft.Dotnet.Sdk.Internal
From Version 9.0.100-alpha.1.23554.1 -> To Version 9.0.100-alpha.1.23557.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@DrewScoggins
Add file handle limit setting for Alpine (dotnet#94439)
b0e1627
* Add file handle limit setting for Alpine
Alpine does not automatically increase the file handle limit to the maximum. dotnet#82719 (comment)
As a result we need to increase the limit manually, as we are seeing "Too many files" errors.
* Bump limit to hard cap
* Remove space
@MichalStrehovsky
Do not release frozen segment if we failed extending it (dotnet#94450)
021ecb8
Maybe I'm missing something, but if we try to commit more of the reserved segment and this fails, it doesn't feel right to release the whole thing. The previously committed part of the segment is still in use.
@ViktorHofer
Use live M.Bcl.AsyncInterfaces dependency (dotnet#94451)
4feec00
* Use live M.Bcl.AsyncInterfaces dependency
* Update Microsoft.Bcl.TimeProvider.csproj
@cincuranet
Add option for R2R configured runs. (dotnet#94412)
2801995
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/source-build-exter…
4d2ef11
…nals build 20231106.2 (dotnet#94463)
Microsoft.SourceBuild.Intermediate.source-build-externals
From Version 9.0.0-alpha.1.23530.1 -> To Version 9.0.0-alpha.1.23556.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@jtschuster
Merge branch 'StackOverflowLinuxNAOT' ofhttps://github.com/jtschuste…
8b6b9cd
…r/runtime into StackOverflowLinuxNAOT
@jtschuster
Use IsSingleFile and update Main signature
4aa9912
@jtschuster
jtschuster
marked this pull request as draft
November 7, 2023 19:12
@jtschusterjtschuster
mentioned this pull request
Nov 7, 2023
 Merged

@jtschuster
jtschuster
commented
Nov 7, 2023

Copy link


Copy Markdown

MemberAuthor
I made some mistake when I pulled main back into this branch. Closing this PR and opened a new one.
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 7, 2023

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 8, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@agockeagockeagocke left review comments
@jkotasjkotasjkotas left review comments
@MichalStrehovskyMichalStrehovskyMichalStrehovsky left review comments
@janvorlijanvorlijanvorli approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomersbomer is a code owner
@radicalradicalAwaiting requested review from radical
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner
@thaystgthaystgAwaiting requested review from thaystg
@kgkgAwaiting requested review from kg
@vargazvargazAwaiting requested review from vargaz
@lambdageeklambdageekAwaiting requested review from lambdageek
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmiloskotlarmilos is a code owner
@fanyang-monofanyang-monoAwaiting requested review from fanyang-mono
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger will be requested when the pull request is marked ready for reviewakoeplinger is a code owner
@marafmarafAwaiting requested review from marafmaraf will be requested when the pull request is marked ready for reviewmaraf is a code owner
@ilonatommyilonatommyAwaiting requested review from ilonatommyilonatommy will be requested when the pull request is marked ready for reviewilonatommy is a code owner
@steveisoksteveisokAwaiting requested review from steveisoksteveisok will be requested when the pull request is marked ready for reviewsteveisok is a code owner
@vitek-karasvitek-karasAwaiting requested review from vitek-karasvitek-karas will be requested when the pull request is marked ready for reviewvitek-karas is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@jtschusterjtschuster

Labels

area-NativeAOT-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[NativeAOT] Stackoverflow reporting on Linux


20 participants

@jtschuster@janvorli@jkotas@MichalStrehovsky@agocke@trylek@AndyAyersMS@wfurt@ViktorHofer@tannergooding@kouvel@pavelsavara@yurai007@mkhamoyan@vitek-karas@kg@ilonatommy@pentp@BruceForstall@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Report StackOverflowException on NativeAOT on Linux - #93901
Closed
jtschuster wants to merge 118 commits into
dotnet:mainfrom 
jtschuster:StackOverflowLinuxNAOT
Closed
Report StackOverflowException on NativeAOT on Linux#93901
jtschuster wants to merge 118 commits into
dotnet:mainfrom 
jtschuster:StackOverflowLinuxNAOT
Conversation
@jtschuster
@jtschusterjtschuster
commented
Oct 24, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Uses almost the same code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.
Fixes#82334
@jtschuster
Report stack overflow in linux
8260630
Use SA_ONSTACK for SIGSEGV handler
Call sigaltstack() to set the alternate stack on the main thread only
Check if faulting address is near the stack pointer, if so, report stack overflow
@jtschuster
Set up signal alternate stack on all new threads
263262c
@jtschuster
Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto StackOv…
adc342f
…erflowLinuxNAOT
@jtschuster
Add test to naot smoke tests
666d231
@ghostghost
assigned jtschusterOct 24, 2023
@ghost
ghost
commented
Oct 24, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas

See info in area-owners.md if you want to be subscribed.
Issue Details
Uses almost the same code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.
Author:jtschuster
Assignees:jtschuster
Labels:
area-NativeAOT-coreclr
Milestone:-
@jkotas
jkotas
requested a review
from janvorliOctober 24, 2023 02:39
jkotas
jkotas
reviewed
Oct 24, 2023
View reviewed changes
Comment threadsrc/coreclr/nativeaot/Runtime/unix/HardwareExceptions.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Oct 24, 2023

Closed

janvorli
janvorli
approved these changes
Oct 24, 2023
View reviewed changes
@janvorlijanvorli
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the nit comment
Comment threadsrc/coreclr/nativeaot/Runtime/thread.cpp
Outdated

jkotas
jkotas
reviewed
Oct 24, 2023
View reviewed changes
Comment threadsrc/tests/nativeaot/SmokeTests/StackOverflowReporting/Program.cs
Outdated

@janvorli
janvorli
commented
Oct 24, 2023

Copy link


Copy Markdown

Member
One thing I wonder about - don't we also want to call PalRaiseFailFastException instead of RhFailFast (like we do on Windows for stack overflow in RhpVectoredExceptionHandler)?
@jkotas
jkotas
commented
Oct 24, 2023

Copy link


Copy Markdown

Member
One thing I wonder about - don't we also want to call PalRaiseFailFastException instead of RhFailFast (like we do on Windows for stack overflow in RhpVectoredExceptionHandler)?
RhFailFast calls PalRaiseFailFastException with default arguments. I do not think calling PalRaiseFailFastException in this change would make any difference.
@janvorli
janvorli
commented
Oct 24, 2023

Copy link


Copy Markdown

Member
Ah, thank you, I've missed that.
@jtschuster
jtschuster
commented
Oct 24, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-nativeaot-outerloop
@azure-pipelines
azure-pipelinesBot
commented
Oct 24, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@jtschuster
jtschuster
commented
Oct 25, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-nativeaot-outerloop
@azure-pipelines
azure-pipelinesBot
commented
Oct 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 27, 2023

Closed


Closed

MichalStrehovsky
MichalStrehovsky
reviewed
Oct 27, 2023
View reviewed changes
Comment threadsrc/tests/baseservices/exceptions/stackoverflow/stackoverflowtester.cs
Outdated

Comment threadsrc/tests/Directory.Build.targets
Outdated

@janvorli
janvorli
commented
Oct 27, 2023

Copy link


Copy Markdown

Member
@jtschuster I am not sure if merging of the tests into a single exe won't complicate the work on merging coreclr tests that @trylek works on. I wonder what the reason for this change was.
pavelsavaraand others
added 11 commits
November 7, 2023 11:32
@pavelsavara
[browser][MT] fix stale memory on suspended thread (dotnet#94299)
bd27e27
@pavelsavara
[browser] allow zero as debug level (dotnet#94456)
5de6ca4
@jakobbotsch
JIT: Remove dead GT_NOP code in LSRA (dotnet#94409)
85d3773
Rationalization removes all GT_NOP nodes, and we do not seem to
introduce any of these before LSRA (and especially not the typed
"passthrough" GT_NOP nodes). This code is just wrong for the passthrough
nodes, so just switch all the LSRA code to only handle potential void
NOPs.
Fixdotnet#93048
@dotnet-maestro
[main] Update dependencies from dotnet/installer (dotnet#94462)
50d4a99
Microsoft.Dotnet.Sdk.Internal
From Version 9.0.100-alpha.1.23554.1 -> To Version 9.0.100-alpha.1.23557.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@DrewScoggins
Add file handle limit setting for Alpine (dotnet#94439)
b0e1627
* Add file handle limit setting for Alpine
Alpine does not automatically increase the file handle limit to the maximum. dotnet#82719 (comment)
As a result we need to increase the limit manually, as we are seeing "Too many files" errors.
* Bump limit to hard cap
* Remove space
@MichalStrehovsky
Do not release frozen segment if we failed extending it (dotnet#94450)
021ecb8
Maybe I'm missing something, but if we try to commit more of the reserved segment and this fails, it doesn't feel right to release the whole thing. The previously committed part of the segment is still in use.
@ViktorHofer
Use live M.Bcl.AsyncInterfaces dependency (dotnet#94451)
4feec00
* Use live M.Bcl.AsyncInterfaces dependency
* Update Microsoft.Bcl.TimeProvider.csproj
@cincuranet
Add option for R2R configured runs. (dotnet#94412)
2801995
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/source-build-exter…
4d2ef11
…nals build 20231106.2 (dotnet#94463)
Microsoft.SourceBuild.Intermediate.source-build-externals
From Version 9.0.0-alpha.1.23530.1 -> To Version 9.0.0-alpha.1.23556.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@jtschuster
Merge branch 'StackOverflowLinuxNAOT' ofhttps://github.com/jtschuste…
8b6b9cd
…r/runtime into StackOverflowLinuxNAOT
@jtschuster
Use IsSingleFile and update Main signature
4aa9912
@jtschuster
jtschuster
marked this pull request as draft
November 7, 2023 19:12
@jtschusterjtschuster
mentioned this pull request
Nov 7, 2023
 Merged

@jtschuster
jtschuster
commented
Nov 7, 2023

Copy link


Copy Markdown

MemberAuthor
I made some mistake when I pulled main back into this branch. Closing this PR and opened a new one.
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 7, 2023

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 8, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@agockeagockeagocke left review comments
@jkotasjkotasjkotas left review comments
@MichalStrehovskyMichalStrehovskyMichalStrehovsky left review comments
@janvorlijanvorlijanvorli approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomersbomer is a code owner
@radicalradicalAwaiting requested review from radical
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner
@thaystgthaystgAwaiting requested review from thaystg
@kgkgAwaiting requested review from kg
@vargazvargazAwaiting requested review from vargaz
@lambdageeklambdageekAwaiting requested review from lambdageek
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmiloskotlarmilos is a code owner
@fanyang-monofanyang-monoAwaiting requested review from fanyang-mono
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger will be requested when the pull request is marked ready for reviewakoeplinger is a code owner
@marafmarafAwaiting requested review from marafmaraf will be requested when the pull request is marked ready for reviewmaraf is a code owner
@ilonatommyilonatommyAwaiting requested review from ilonatommyilonatommy will be requested when the pull request is marked ready for reviewilonatommy is a code owner
@steveisoksteveisokAwaiting requested review from steveisoksteveisok will be requested when the pull request is marked ready for reviewsteveisok is a code owner
@vitek-karasvitek-karasAwaiting requested review from vitek-karasvitek-karas will be requested when the pull request is marked ready for reviewvitek-karas is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@jtschusterjtschuster

Labels

area-NativeAOT-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[NativeAOT] Stackoverflow reporting on Linux


20 participants

@jtschuster@janvorli@jkotas@MichalStrehovsky@agocke@trylek@AndyAyersMS@wfurt@ViktorHofer@tannergooding@kouvel@pavelsavara@yurai007@mkhamoyan@vitek-karas@kg@ilonatommy@pentp@BruceForstall@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Report StackOverflowException on NativeAOT on Linux - #93901
Closed
jtschuster wants to merge 118 commits into
dotnet:mainfrom 
jtschuster:StackOverflowLinuxNAOT
Closed
Report StackOverflowException on NativeAOT on Linux#93901
jtschuster wants to merge 118 commits into
dotnet:mainfrom 
jtschuster:StackOverflowLinuxNAOT
Conversation
@jtschuster
@jtschusterjtschuster
commented
Oct 24, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Uses almost the same code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.
Fixes#82334
@jtschuster
Report stack overflow in linux
8260630
Use SA_ONSTACK for SIGSEGV handler
Call sigaltstack() to set the alternate stack on the main thread only
Check if faulting address is near the stack pointer, if so, report stack overflow
@jtschuster
Set up signal alternate stack on all new threads
263262c
@jtschuster
Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto StackOv…
adc342f
…erflowLinuxNAOT
@jtschuster
Add test to naot smoke tests
666d231
@ghostghost
assigned jtschusterOct 24, 2023
@ghost
ghost
commented
Oct 24, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas

See info in area-owners.md if you want to be subscribed.
Issue Details
Uses almost the same code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.
Author:jtschuster
Assignees:jtschuster
Labels:
area-NativeAOT-coreclr
Milestone:-
@jkotas
jkotas
requested a review
from janvorliOctober 24, 2023 02:39
jkotas
jkotas
reviewed
Oct 24, 2023
View reviewed changes
Comment threadsrc/coreclr/nativeaot/Runtime/unix/HardwareExceptions.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Oct 24, 2023

Closed

janvorli
janvorli
approved these changes
Oct 24, 2023
View reviewed changes
@janvorlijanvorli
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the nit comment
Comment threadsrc/coreclr/nativeaot/Runtime/thread.cpp
Outdated

jkotas
jkotas
reviewed
Oct 24, 2023
View reviewed changes
Comment threadsrc/tests/nativeaot/SmokeTests/StackOverflowReporting/Program.cs
Outdated

@janvorli
janvorli
commented
Oct 24, 2023

Copy link


Copy Markdown

Member
One thing I wonder about - don't we also want to call PalRaiseFailFastException instead of RhFailFast (like we do on Windows for stack overflow in RhpVectoredExceptionHandler)?
@jkotas
jkotas
commented
Oct 24, 2023

Copy link


Copy Markdown

Member
One thing I wonder about - don't we also want to call PalRaiseFailFastException instead of RhFailFast (like we do on Windows for stack overflow in RhpVectoredExceptionHandler)?
RhFailFast calls PalRaiseFailFastException with default arguments. I do not think calling PalRaiseFailFastException in this change would make any difference.
@janvorli
janvorli
commented
Oct 24, 2023

Copy link


Copy Markdown

Member
Ah, thank you, I've missed that.
@jtschuster
jtschuster
commented
Oct 24, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-nativeaot-outerloop
@azure-pipelines
azure-pipelinesBot
commented
Oct 24, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@jtschuster
jtschuster
commented
Oct 25, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-nativeaot-outerloop
@azure-pipelines
azure-pipelinesBot
commented
Oct 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 27, 2023

Closed


Closed

MichalStrehovsky
MichalStrehovsky
reviewed
Oct 27, 2023
View reviewed changes
Comment threadsrc/tests/baseservices/exceptions/stackoverflow/stackoverflowtester.cs
Outdated

Comment threadsrc/tests/Directory.Build.targets
Outdated

@janvorli
janvorli
commented
Oct 27, 2023

Copy link


Copy Markdown

Member
@jtschuster I am not sure if merging of the tests into a single exe won't complicate the work on merging coreclr tests that @trylek works on. I wonder what the reason for this change was.
pavelsavaraand others
added 11 commits
November 7, 2023 11:32
@pavelsavara
[browser][MT] fix stale memory on suspended thread (dotnet#94299)
bd27e27
@pavelsavara
[browser] allow zero as debug level (dotnet#94456)
5de6ca4
@jakobbotsch
JIT: Remove dead GT_NOP code in LSRA (dotnet#94409)
85d3773
Rationalization removes all GT_NOP nodes, and we do not seem to
introduce any of these before LSRA (and especially not the typed
"passthrough" GT_NOP nodes). This code is just wrong for the passthrough
nodes, so just switch all the LSRA code to only handle potential void
NOPs.
Fixdotnet#93048
@dotnet-maestro
[main] Update dependencies from dotnet/installer (dotnet#94462)
50d4a99
Microsoft.Dotnet.Sdk.Internal
From Version 9.0.100-alpha.1.23554.1 -> To Version 9.0.100-alpha.1.23557.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@DrewScoggins
Add file handle limit setting for Alpine (dotnet#94439)
b0e1627
* Add file handle limit setting for Alpine
Alpine does not automatically increase the file handle limit to the maximum. dotnet#82719 (comment)
As a result we need to increase the limit manually, as we are seeing "Too many files" errors.
* Bump limit to hard cap
* Remove space
@MichalStrehovsky
Do not release frozen segment if we failed extending it (dotnet#94450)
021ecb8
Maybe I'm missing something, but if we try to commit more of the reserved segment and this fails, it doesn't feel right to release the whole thing. The previously committed part of the segment is still in use.
@ViktorHofer
Use live M.Bcl.AsyncInterfaces dependency (dotnet#94451)
4feec00
* Use live M.Bcl.AsyncInterfaces dependency
* Update Microsoft.Bcl.TimeProvider.csproj
@cincuranet
Add option for R2R configured runs. (dotnet#94412)
2801995
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/source-build-exter…
4d2ef11
…nals build 20231106.2 (dotnet#94463)
Microsoft.SourceBuild.Intermediate.source-build-externals
From Version 9.0.0-alpha.1.23530.1 -> To Version 9.0.0-alpha.1.23556.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@jtschuster
Merge branch 'StackOverflowLinuxNAOT' ofhttps://github.com/jtschuste…
8b6b9cd
…r/runtime into StackOverflowLinuxNAOT
@jtschuster
Use IsSingleFile and update Main signature
4aa9912
@jtschuster
jtschuster
marked this pull request as draft
November 7, 2023 19:12
@jtschusterjtschuster
mentioned this pull request
Nov 7, 2023
 Merged

@jtschuster
jtschuster
commented
Nov 7, 2023

Copy link


Copy Markdown

MemberAuthor
I made some mistake when I pulled main back into this branch. Closing this PR and opened a new one.
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 7, 2023

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 8, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@agockeagockeagocke left review comments
@jkotasjkotasjkotas left review comments
@MichalStrehovskyMichalStrehovskyMichalStrehovsky left review comments
@janvorlijanvorlijanvorli approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomersbomer is a code owner
@radicalradicalAwaiting requested review from radical
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner
@thaystgthaystgAwaiting requested review from thaystg
@kgkgAwaiting requested review from kg
@vargazvargazAwaiting requested review from vargaz
@lambdageeklambdageekAwaiting requested review from lambdageek
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmiloskotlarmilos is a code owner
@fanyang-monofanyang-monoAwaiting requested review from fanyang-mono
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger will be requested when the pull request is marked ready for reviewakoeplinger is a code owner
@marafmarafAwaiting requested review from marafmaraf will be requested when the pull request is marked ready for reviewmaraf is a code owner
@ilonatommyilonatommyAwaiting requested review from ilonatommyilonatommy will be requested when the pull request is marked ready for reviewilonatommy is a code owner
@steveisoksteveisokAwaiting requested review from steveisoksteveisok will be requested when the pull request is marked ready for reviewsteveisok is a code owner
@vitek-karasvitek-karasAwaiting requested review from vitek-karasvitek-karas will be requested when the pull request is marked ready for reviewvitek-karas is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@jtschusterjtschuster

Labels

area-NativeAOT-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[NativeAOT] Stackoverflow reporting on Linux


20 participants

@jtschuster@janvorli@jkotas@MichalStrehovsky@agocke@trylek@AndyAyersMS@wfurt@ViktorHofer@tannergooding@kouvel@pavelsavara@yurai007@mkhamoyan@vitek-karas@kg@ilonatommy@pentp@BruceForstall@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Report StackOverflowException on NativeAOT on Linux - #93901
Closed
jtschuster wants to merge 118 commits into
dotnet:mainfrom 
jtschuster:StackOverflowLinuxNAOT
Closed
Report StackOverflowException on NativeAOT on Linux#93901
jtschuster wants to merge 118 commits into
dotnet:mainfrom 
jtschuster:StackOverflowLinuxNAOT
Conversation
@jtschuster
@jtschusterjtschuster
commented
Oct 24, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Uses almost the same code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.
Fixes#82334
@jtschuster
Report stack overflow in linux
8260630
Use SA_ONSTACK for SIGSEGV handler
Call sigaltstack() to set the alternate stack on the main thread only
Check if faulting address is near the stack pointer, if so, report stack overflow
@jtschuster
Set up signal alternate stack on all new threads
263262c
@jtschuster
Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto StackOv…
adc342f
…erflowLinuxNAOT
@jtschuster
Add test to naot smoke tests
666d231
@ghostghost
assigned jtschusterOct 24, 2023
@ghost
ghost
commented
Oct 24, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas

See info in area-owners.md if you want to be subscribed.
Issue Details
Uses almost the same code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.
Author:jtschuster
Assignees:jtschuster
Labels:
area-NativeAOT-coreclr
Milestone:-
@jkotas
jkotas
requested a review
from janvorliOctober 24, 2023 02:39
jkotas
jkotas
reviewed
Oct 24, 2023
View reviewed changes
Comment threadsrc/coreclr/nativeaot/Runtime/unix/HardwareExceptions.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Oct 24, 2023

Closed

janvorli
janvorli
approved these changes
Oct 24, 2023
View reviewed changes
@janvorlijanvorli
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the nit comment
Comment threadsrc/coreclr/nativeaot/Runtime/thread.cpp
Outdated

jkotas
jkotas
reviewed
Oct 24, 2023
View reviewed changes
Comment threadsrc/tests/nativeaot/SmokeTests/StackOverflowReporting/Program.cs
Outdated

@janvorli
janvorli
commented
Oct 24, 2023

Copy link


Copy Markdown

Member
One thing I wonder about - don't we also want to call PalRaiseFailFastException instead of RhFailFast (like we do on Windows for stack overflow in RhpVectoredExceptionHandler)?
@jkotas
jkotas
commented
Oct 24, 2023

Copy link


Copy Markdown

Member
One thing I wonder about - don't we also want to call PalRaiseFailFastException instead of RhFailFast (like we do on Windows for stack overflow in RhpVectoredExceptionHandler)?
RhFailFast calls PalRaiseFailFastException with default arguments. I do not think calling PalRaiseFailFastException in this change would make any difference.
@janvorli
janvorli
commented
Oct 24, 2023

Copy link


Copy Markdown

Member
Ah, thank you, I've missed that.
@jtschuster
jtschuster
commented
Oct 24, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-nativeaot-outerloop
@azure-pipelines
azure-pipelinesBot
commented
Oct 24, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@jtschuster
jtschuster
commented
Oct 25, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-nativeaot-outerloop
@azure-pipelines
azure-pipelinesBot
commented
Oct 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 27, 2023

Closed


Closed

MichalStrehovsky
MichalStrehovsky
reviewed
Oct 27, 2023
View reviewed changes
Comment threadsrc/tests/baseservices/exceptions/stackoverflow/stackoverflowtester.cs
Outdated

Comment threadsrc/tests/Directory.Build.targets
Outdated

@janvorli
janvorli
commented
Oct 27, 2023

Copy link


Copy Markdown

Member
@jtschuster I am not sure if merging of the tests into a single exe won't complicate the work on merging coreclr tests that @trylek works on. I wonder what the reason for this change was.
pavelsavaraand others
added 11 commits
November 7, 2023 11:32
@pavelsavara
[browser][MT] fix stale memory on suspended thread (dotnet#94299)
bd27e27
@pavelsavara
[browser] allow zero as debug level (dotnet#94456)
5de6ca4
@jakobbotsch
JIT: Remove dead GT_NOP code in LSRA (dotnet#94409)
85d3773
Rationalization removes all GT_NOP nodes, and we do not seem to
introduce any of these before LSRA (and especially not the typed
"passthrough" GT_NOP nodes). This code is just wrong for the passthrough
nodes, so just switch all the LSRA code to only handle potential void
NOPs.
Fixdotnet#93048
@dotnet-maestro
[main] Update dependencies from dotnet/installer (dotnet#94462)
50d4a99
Microsoft.Dotnet.Sdk.Internal
From Version 9.0.100-alpha.1.23554.1 -> To Version 9.0.100-alpha.1.23557.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@DrewScoggins
Add file handle limit setting for Alpine (dotnet#94439)
b0e1627
* Add file handle limit setting for Alpine
Alpine does not automatically increase the file handle limit to the maximum. dotnet#82719 (comment)
As a result we need to increase the limit manually, as we are seeing "Too many files" errors.
* Bump limit to hard cap
* Remove space
@MichalStrehovsky
Do not release frozen segment if we failed extending it (dotnet#94450)
021ecb8
Maybe I'm missing something, but if we try to commit more of the reserved segment and this fails, it doesn't feel right to release the whole thing. The previously committed part of the segment is still in use.
@ViktorHofer
Use live M.Bcl.AsyncInterfaces dependency (dotnet#94451)
4feec00
* Use live M.Bcl.AsyncInterfaces dependency
* Update Microsoft.Bcl.TimeProvider.csproj
@cincuranet
Add option for R2R configured runs. (dotnet#94412)
2801995
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/source-build-exter…
4d2ef11
…nals build 20231106.2 (dotnet#94463)
Microsoft.SourceBuild.Intermediate.source-build-externals
From Version 9.0.0-alpha.1.23530.1 -> To Version 9.0.0-alpha.1.23556.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@jtschuster
Merge branch 'StackOverflowLinuxNAOT' ofhttps://github.com/jtschuste…
8b6b9cd
…r/runtime into StackOverflowLinuxNAOT
@jtschuster
Use IsSingleFile and update Main signature
4aa9912
@jtschuster
jtschuster
marked this pull request as draft
November 7, 2023 19:12
@jtschusterjtschuster
mentioned this pull request
Nov 7, 2023
 Merged

@jtschuster
jtschuster
commented
Nov 7, 2023

Copy link


Copy Markdown

MemberAuthor
I made some mistake when I pulled main back into this branch. Closing this PR and opened a new one.
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 7, 2023

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 8, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@agockeagockeagocke left review comments
@jkotasjkotasjkotas left review comments
@MichalStrehovskyMichalStrehovskyMichalStrehovsky left review comments
@janvorlijanvorlijanvorli approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomersbomer is a code owner
@radicalradicalAwaiting requested review from radical
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner
@thaystgthaystgAwaiting requested review from thaystg
@kgkgAwaiting requested review from kg
@vargazvargazAwaiting requested review from vargaz
@lambdageeklambdageekAwaiting requested review from lambdageek
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmiloskotlarmilos is a code owner
@fanyang-monofanyang-monoAwaiting requested review from fanyang-mono
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger will be requested when the pull request is marked ready for reviewakoeplinger is a code owner
@marafmarafAwaiting requested review from marafmaraf will be requested when the pull request is marked ready for reviewmaraf is a code owner
@ilonatommyilonatommyAwaiting requested review from ilonatommyilonatommy will be requested when the pull request is marked ready for reviewilonatommy is a code owner
@steveisoksteveisokAwaiting requested review from steveisoksteveisok will be requested when the pull request is marked ready for reviewsteveisok is a code owner
@vitek-karasvitek-karasAwaiting requested review from vitek-karasvitek-karas will be requested when the pull request is marked ready for reviewvitek-karas is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@jtschusterjtschuster

Labels

area-NativeAOT-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[NativeAOT] Stackoverflow reporting on Linux


20 participants

@jtschuster@janvorli@jkotas@MichalStrehovsky@agocke@trylek@AndyAyersMS@wfurt@ViktorHofer@tannergooding@kouvel@pavelsavara@yurai007@mkhamoyan@vitek-karas@kg@ilonatommy@pentp@BruceForstall@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Report StackOverflowException on NativeAOT on Linux - #93901
Closed
jtschuster wants to merge 118 commits into
dotnet:mainfrom 
jtschuster:StackOverflowLinuxNAOT
Closed
Report StackOverflowException on NativeAOT on Linux#93901
jtschuster wants to merge 118 commits into
dotnet:mainfrom 
jtschuster:StackOverflowLinuxNAOT
Conversation
@jtschuster
@jtschusterjtschuster
commented
Oct 24, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Uses almost the same code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.
Fixes#82334
@jtschuster
Report stack overflow in linux
8260630
Use SA_ONSTACK for SIGSEGV handler
Call sigaltstack() to set the alternate stack on the main thread only
Check if faulting address is near the stack pointer, if so, report stack overflow
@jtschuster
Set up signal alternate stack on all new threads
263262c
@jtschuster
Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto StackOv…
adc342f
…erflowLinuxNAOT
@jtschuster
Add test to naot smoke tests
666d231
@ghostghost
assigned jtschusterOct 24, 2023
@ghost
ghost
commented
Oct 24, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas

See info in area-owners.md if you want to be subscribed.
Issue Details
Uses almost the same code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.
Author:jtschuster
Assignees:jtschuster
Labels:
area-NativeAOT-coreclr
Milestone:-
@jkotas
jkotas
requested a review
from janvorliOctober 24, 2023 02:39
jkotas
jkotas
reviewed
Oct 24, 2023
View reviewed changes
Comment threadsrc/coreclr/nativeaot/Runtime/unix/HardwareExceptions.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Oct 24, 2023

Closed

janvorli
janvorli
approved these changes
Oct 24, 2023
View reviewed changes
@janvorlijanvorli
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the nit comment
Comment threadsrc/coreclr/nativeaot/Runtime/thread.cpp
Outdated

jkotas
jkotas
reviewed
Oct 24, 2023
View reviewed changes
Comment threadsrc/tests/nativeaot/SmokeTests/StackOverflowReporting/Program.cs
Outdated

@janvorli
janvorli
commented
Oct 24, 2023

Copy link


Copy Markdown

Member
One thing I wonder about - don't we also want to call PalRaiseFailFastException instead of RhFailFast (like we do on Windows for stack overflow in RhpVectoredExceptionHandler)?
@jkotas
jkotas
commented
Oct 24, 2023

Copy link


Copy Markdown

Member
One thing I wonder about - don't we also want to call PalRaiseFailFastException instead of RhFailFast (like we do on Windows for stack overflow in RhpVectoredExceptionHandler)?
RhFailFast calls PalRaiseFailFastException with default arguments. I do not think calling PalRaiseFailFastException in this change would make any difference.
@janvorli
janvorli
commented
Oct 24, 2023

Copy link


Copy Markdown

Member
Ah, thank you, I've missed that.
@jtschuster
jtschuster
commented
Oct 24, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-nativeaot-outerloop
@azure-pipelines
azure-pipelinesBot
commented
Oct 24, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@jtschuster
jtschuster
commented
Oct 25, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-nativeaot-outerloop
@azure-pipelines
azure-pipelinesBot
commented
Oct 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 27, 2023

Closed


Closed

MichalStrehovsky
MichalStrehovsky
reviewed
Oct 27, 2023
View reviewed changes
Comment threadsrc/tests/baseservices/exceptions/stackoverflow/stackoverflowtester.cs
Outdated

Comment threadsrc/tests/Directory.Build.targets
Outdated

@janvorli
janvorli
commented
Oct 27, 2023

Copy link


Copy Markdown

Member
@jtschuster I am not sure if merging of the tests into a single exe won't complicate the work on merging coreclr tests that @trylek works on. I wonder what the reason for this change was.
pavelsavaraand others
added 11 commits
November 7, 2023 11:32
@pavelsavara
[browser][MT] fix stale memory on suspended thread (dotnet#94299)
bd27e27
@pavelsavara
[browser] allow zero as debug level (dotnet#94456)
5de6ca4
@jakobbotsch
JIT: Remove dead GT_NOP code in LSRA (dotnet#94409)
85d3773
Rationalization removes all GT_NOP nodes, and we do not seem to
introduce any of these before LSRA (and especially not the typed
"passthrough" GT_NOP nodes). This code is just wrong for the passthrough
nodes, so just switch all the LSRA code to only handle potential void
NOPs.
Fixdotnet#93048
@dotnet-maestro
[main] Update dependencies from dotnet/installer (dotnet#94462)
50d4a99
Microsoft.Dotnet.Sdk.Internal
From Version 9.0.100-alpha.1.23554.1 -> To Version 9.0.100-alpha.1.23557.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@DrewScoggins
Add file handle limit setting for Alpine (dotnet#94439)
b0e1627
* Add file handle limit setting for Alpine
Alpine does not automatically increase the file handle limit to the maximum. dotnet#82719 (comment)
As a result we need to increase the limit manually, as we are seeing "Too many files" errors.
* Bump limit to hard cap
* Remove space
@MichalStrehovsky
Do not release frozen segment if we failed extending it (dotnet#94450)
021ecb8
Maybe I'm missing something, but if we try to commit more of the reserved segment and this fails, it doesn't feel right to release the whole thing. The previously committed part of the segment is still in use.
@ViktorHofer
Use live M.Bcl.AsyncInterfaces dependency (dotnet#94451)
4feec00
* Use live M.Bcl.AsyncInterfaces dependency
* Update Microsoft.Bcl.TimeProvider.csproj
@cincuranet
Add option for R2R configured runs. (dotnet#94412)
2801995
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/source-build-exter…
4d2ef11
…nals build 20231106.2 (dotnet#94463)
Microsoft.SourceBuild.Intermediate.source-build-externals
From Version 9.0.0-alpha.1.23530.1 -> To Version 9.0.0-alpha.1.23556.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@jtschuster
Merge branch 'StackOverflowLinuxNAOT' ofhttps://github.com/jtschuste…
8b6b9cd
…r/runtime into StackOverflowLinuxNAOT
@jtschuster
Use IsSingleFile and update Main signature
4aa9912
@jtschuster
jtschuster
marked this pull request as draft
November 7, 2023 19:12
@jtschusterjtschuster
mentioned this pull request
Nov 7, 2023
 Merged

@jtschuster
jtschuster
commented
Nov 7, 2023

Copy link


Copy Markdown

MemberAuthor
I made some mistake when I pulled main back into this branch. Closing this PR and opened a new one.
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 7, 2023

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 8, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@agockeagockeagocke left review comments
@jkotasjkotasjkotas left review comments
@MichalStrehovskyMichalStrehovskyMichalStrehovsky left review comments
@janvorlijanvorlijanvorli approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomersbomer is a code owner
@radicalradicalAwaiting requested review from radical
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner
@thaystgthaystgAwaiting requested review from thaystg
@kgkgAwaiting requested review from kg
@vargazvargazAwaiting requested review from vargaz
@lambdageeklambdageekAwaiting requested review from lambdageek
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmiloskotlarmilos is a code owner
@fanyang-monofanyang-monoAwaiting requested review from fanyang-mono
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger will be requested when the pull request is marked ready for reviewakoeplinger is a code owner
@marafmarafAwaiting requested review from marafmaraf will be requested when the pull request is marked ready for reviewmaraf is a code owner
@ilonatommyilonatommyAwaiting requested review from ilonatommyilonatommy will be requested when the pull request is marked ready for reviewilonatommy is a code owner
@steveisoksteveisokAwaiting requested review from steveisoksteveisok will be requested when the pull request is marked ready for reviewsteveisok is a code owner
@vitek-karasvitek-karasAwaiting requested review from vitek-karasvitek-karas will be requested when the pull request is marked ready for reviewvitek-karas is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@jtschusterjtschuster

Labels

area-NativeAOT-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[NativeAOT] Stackoverflow reporting on Linux


20 participants

@jtschuster@janvorli@jkotas@MichalStrehovsky@agocke@trylek@AndyAyersMS@wfurt@ViktorHofer@tannergooding@kouvel@pavelsavara@yurai007@mkhamoyan@vitek-karas@kg@ilonatommy@pentp@BruceForstall@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Report StackOverflowException on NativeAOT on Linux - #93901
Closed
jtschuster wants to merge 118 commits into
dotnet:mainfrom 
jtschuster:StackOverflowLinuxNAOT
Closed
Report StackOverflowException on NativeAOT on Linux#93901
jtschuster wants to merge 118 commits into
dotnet:mainfrom 
jtschuster:StackOverflowLinuxNAOT
Conversation
@jtschuster
@jtschusterjtschuster
commented
Oct 24, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Uses almost the same code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.
Fixes#82334
@jtschuster
Report stack overflow in linux
8260630
Use SA_ONSTACK for SIGSEGV handler
Call sigaltstack() to set the alternate stack on the main thread only
Check if faulting address is near the stack pointer, if so, report stack overflow
@jtschuster
Set up signal alternate stack on all new threads
263262c
@jtschuster
Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto StackOv…
adc342f
…erflowLinuxNAOT
@jtschuster
Add test to naot smoke tests
666d231
@ghostghost
assigned jtschusterOct 24, 2023
@ghost
ghost
commented
Oct 24, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas

See info in area-owners.md if you want to be subscribed.
Issue Details
Uses almost the same code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.
Author:jtschuster
Assignees:jtschuster
Labels:
area-NativeAOT-coreclr
Milestone:-
@jkotas
jkotas
requested a review
from janvorliOctober 24, 2023 02:39
jkotas
jkotas
reviewed
Oct 24, 2023
View reviewed changes
Comment threadsrc/coreclr/nativeaot/Runtime/unix/HardwareExceptions.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Oct 24, 2023

Closed

janvorli
janvorli
approved these changes
Oct 24, 2023
View reviewed changes
@janvorlijanvorli
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the nit comment
Comment threadsrc/coreclr/nativeaot/Runtime/thread.cpp
Outdated

jkotas
jkotas
reviewed
Oct 24, 2023
View reviewed changes
Comment threadsrc/tests/nativeaot/SmokeTests/StackOverflowReporting/Program.cs
Outdated

@janvorli
janvorli
commented
Oct 24, 2023

Copy link


Copy Markdown

Member
One thing I wonder about - don't we also want to call PalRaiseFailFastException instead of RhFailFast (like we do on Windows for stack overflow in RhpVectoredExceptionHandler)?
@jkotas
jkotas
commented
Oct 24, 2023

Copy link


Copy Markdown

Member
One thing I wonder about - don't we also want to call PalRaiseFailFastException instead of RhFailFast (like we do on Windows for stack overflow in RhpVectoredExceptionHandler)?
RhFailFast calls PalRaiseFailFastException with default arguments. I do not think calling PalRaiseFailFastException in this change would make any difference.
@janvorli
janvorli
commented
Oct 24, 2023

Copy link


Copy Markdown

Member
Ah, thank you, I've missed that.
@jtschuster
jtschuster
commented
Oct 24, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-nativeaot-outerloop
@azure-pipelines
azure-pipelinesBot
commented
Oct 24, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@jtschuster
jtschuster
commented
Oct 25, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-nativeaot-outerloop
@azure-pipelines
azure-pipelinesBot
commented
Oct 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 27, 2023

Closed


Closed

MichalStrehovsky
MichalStrehovsky
reviewed
Oct 27, 2023
View reviewed changes
Comment threadsrc/tests/baseservices/exceptions/stackoverflow/stackoverflowtester.cs
Outdated

Comment threadsrc/tests/Directory.Build.targets
Outdated

@janvorli
janvorli
commented
Oct 27, 2023

Copy link


Copy Markdown

Member
@jtschuster I am not sure if merging of the tests into a single exe won't complicate the work on merging coreclr tests that @trylek works on. I wonder what the reason for this change was.
pavelsavaraand others
added 11 commits
November 7, 2023 11:32
@pavelsavara
[browser][MT] fix stale memory on suspended thread (dotnet#94299)
bd27e27
@pavelsavara
[browser] allow zero as debug level (dotnet#94456)
5de6ca4
@jakobbotsch
JIT: Remove dead GT_NOP code in LSRA (dotnet#94409)
85d3773
Rationalization removes all GT_NOP nodes, and we do not seem to
introduce any of these before LSRA (and especially not the typed
"passthrough" GT_NOP nodes). This code is just wrong for the passthrough
nodes, so just switch all the LSRA code to only handle potential void
NOPs.
Fixdotnet#93048
@dotnet-maestro
[main] Update dependencies from dotnet/installer (dotnet#94462)
50d4a99
Microsoft.Dotnet.Sdk.Internal
From Version 9.0.100-alpha.1.23554.1 -> To Version 9.0.100-alpha.1.23557.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@DrewScoggins
Add file handle limit setting for Alpine (dotnet#94439)
b0e1627
* Add file handle limit setting for Alpine
Alpine does not automatically increase the file handle limit to the maximum. dotnet#82719 (comment)
As a result we need to increase the limit manually, as we are seeing "Too many files" errors.
* Bump limit to hard cap
* Remove space
@MichalStrehovsky
Do not release frozen segment if we failed extending it (dotnet#94450)
021ecb8
Maybe I'm missing something, but if we try to commit more of the reserved segment and this fails, it doesn't feel right to release the whole thing. The previously committed part of the segment is still in use.
@ViktorHofer
Use live M.Bcl.AsyncInterfaces dependency (dotnet#94451)
4feec00
* Use live M.Bcl.AsyncInterfaces dependency
* Update Microsoft.Bcl.TimeProvider.csproj
@cincuranet
Add option for R2R configured runs. (dotnet#94412)
2801995
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/source-build-exter…
4d2ef11
…nals build 20231106.2 (dotnet#94463)
Microsoft.SourceBuild.Intermediate.source-build-externals
From Version 9.0.0-alpha.1.23530.1 -> To Version 9.0.0-alpha.1.23556.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@jtschuster
Merge branch 'StackOverflowLinuxNAOT' ofhttps://github.com/jtschuste…
8b6b9cd
…r/runtime into StackOverflowLinuxNAOT
@jtschuster
Use IsSingleFile and update Main signature
4aa9912
@jtschuster
jtschuster
marked this pull request as draft
November 7, 2023 19:12
@jtschusterjtschuster
mentioned this pull request
Nov 7, 2023
 Merged

@jtschuster
jtschuster
commented
Nov 7, 2023

Copy link


Copy Markdown

MemberAuthor
I made some mistake when I pulled main back into this branch. Closing this PR and opened a new one.
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 7, 2023

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 8, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@agockeagockeagocke left review comments
@jkotasjkotasjkotas left review comments
@MichalStrehovskyMichalStrehovskyMichalStrehovsky left review comments
@janvorlijanvorlijanvorli approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomersbomer is a code owner
@radicalradicalAwaiting requested review from radical
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner
@thaystgthaystgAwaiting requested review from thaystg
@kgkgAwaiting requested review from kg
@vargazvargazAwaiting requested review from vargaz
@lambdageeklambdageekAwaiting requested review from lambdageek
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmiloskotlarmilos is a code owner
@fanyang-monofanyang-monoAwaiting requested review from fanyang-mono
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger will be requested when the pull request is marked ready for reviewakoeplinger is a code owner
@marafmarafAwaiting requested review from marafmaraf will be requested when the pull request is marked ready for reviewmaraf is a code owner
@ilonatommyilonatommyAwaiting requested review from ilonatommyilonatommy will be requested when the pull request is marked ready for reviewilonatommy is a code owner
@steveisoksteveisokAwaiting requested review from steveisoksteveisok will be requested when the pull request is marked ready for reviewsteveisok is a code owner
@vitek-karasvitek-karasAwaiting requested review from vitek-karasvitek-karas will be requested when the pull request is marked ready for reviewvitek-karas is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@jtschusterjtschuster

Labels

area-NativeAOT-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[NativeAOT] Stackoverflow reporting on Linux


20 participants

@jtschuster@janvorli@jkotas@MichalStrehovsky@agocke@trylek@AndyAyersMS@wfurt@ViktorHofer@tannergooding@kouvel@pavelsavara@yurai007@mkhamoyan@vitek-karas@kg@ilonatommy@pentp@BruceForstall@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Report StackOverflowException on NativeAOT on Linux - #93901
Closed
jtschuster wants to merge 118 commits into
dotnet:mainfrom 
jtschuster:StackOverflowLinuxNAOT
Closed
Report StackOverflowException on NativeAOT on Linux#93901
jtschuster wants to merge 118 commits into
dotnet:mainfrom 
jtschuster:StackOverflowLinuxNAOT
Conversation
@jtschuster
@jtschusterjtschuster
commented
Oct 24, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Uses almost the same code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.
Fixes#82334
@jtschuster
Report stack overflow in linux
8260630
Use SA_ONSTACK for SIGSEGV handler
Call sigaltstack() to set the alternate stack on the main thread only
Check if faulting address is near the stack pointer, if so, report stack overflow
@jtschuster
Set up signal alternate stack on all new threads
263262c
@jtschuster
Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto StackOv…
adc342f
…erflowLinuxNAOT
@jtschuster
Add test to naot smoke tests
666d231
@ghostghost
assigned jtschusterOct 24, 2023
@ghost
ghost
commented
Oct 24, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas

See info in area-owners.md if you want to be subscribed.
Issue Details
Uses almost the same code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.
Author:jtschuster
Assignees:jtschuster
Labels:
area-NativeAOT-coreclr
Milestone:-
@jkotas
jkotas
requested a review
from janvorliOctober 24, 2023 02:39
jkotas
jkotas
reviewed
Oct 24, 2023
View reviewed changes
Comment threadsrc/coreclr/nativeaot/Runtime/unix/HardwareExceptions.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Oct 24, 2023

Closed

janvorli
janvorli
approved these changes
Oct 24, 2023
View reviewed changes
@janvorlijanvorli
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the nit comment
Comment threadsrc/coreclr/nativeaot/Runtime/thread.cpp
Outdated

jkotas
jkotas
reviewed
Oct 24, 2023
View reviewed changes
Comment threadsrc/tests/nativeaot/SmokeTests/StackOverflowReporting/Program.cs
Outdated

@janvorli
janvorli
commented
Oct 24, 2023

Copy link


Copy Markdown

Member
One thing I wonder about - don't we also want to call PalRaiseFailFastException instead of RhFailFast (like we do on Windows for stack overflow in RhpVectoredExceptionHandler)?
@jkotas
jkotas
commented
Oct 24, 2023

Copy link


Copy Markdown

Member
One thing I wonder about - don't we also want to call PalRaiseFailFastException instead of RhFailFast (like we do on Windows for stack overflow in RhpVectoredExceptionHandler)?
RhFailFast calls PalRaiseFailFastException with default arguments. I do not think calling PalRaiseFailFastException in this change would make any difference.
@janvorli
janvorli
commented
Oct 24, 2023

Copy link


Copy Markdown

Member
Ah, thank you, I've missed that.
@jtschuster
jtschuster
commented
Oct 24, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-nativeaot-outerloop
@azure-pipelines
azure-pipelinesBot
commented
Oct 24, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@jtschuster
jtschuster
commented
Oct 25, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-nativeaot-outerloop
@azure-pipelines
azure-pipelinesBot
commented
Oct 25, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 27, 2023

Closed


Closed

MichalStrehovsky
MichalStrehovsky
reviewed
Oct 27, 2023
View reviewed changes
Comment threadsrc/tests/baseservices/exceptions/stackoverflow/stackoverflowtester.cs
Outdated

Comment threadsrc/tests/Directory.Build.targets
Outdated

@janvorli
janvorli
commented
Oct 27, 2023

Copy link


Copy Markdown

Member
@jtschuster I am not sure if merging of the tests into a single exe won't complicate the work on merging coreclr tests that @trylek works on. I wonder what the reason for this change was.
pavelsavaraand others
added 11 commits
November 7, 2023 11:32
@pavelsavara
[browser][MT] fix stale memory on suspended thread (dotnet#94299)
bd27e27
@pavelsavara
[browser] allow zero as debug level (dotnet#94456)
5de6ca4
@jakobbotsch
JIT: Remove dead GT_NOP code in LSRA (dotnet#94409)
85d3773
Rationalization removes all GT_NOP nodes, and we do not seem to
introduce any of these before LSRA (and especially not the typed
"passthrough" GT_NOP nodes). This code is just wrong for the passthrough
nodes, so just switch all the LSRA code to only handle potential void
NOPs.
Fixdotnet#93048
@dotnet-maestro
[main] Update dependencies from dotnet/installer (dotnet#94462)
50d4a99
Microsoft.Dotnet.Sdk.Internal
From Version 9.0.100-alpha.1.23554.1 -> To Version 9.0.100-alpha.1.23557.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@DrewScoggins
Add file handle limit setting for Alpine (dotnet#94439)
b0e1627
* Add file handle limit setting for Alpine
Alpine does not automatically increase the file handle limit to the maximum. dotnet#82719 (comment)
As a result we need to increase the limit manually, as we are seeing "Too many files" errors.
* Bump limit to hard cap
* Remove space
@MichalStrehovsky
Do not release frozen segment if we failed extending it (dotnet#94450)
021ecb8
Maybe I'm missing something, but if we try to commit more of the reserved segment and this fails, it doesn't feel right to release the whole thing. The previously committed part of the segment is still in use.
@ViktorHofer
Use live M.Bcl.AsyncInterfaces dependency (dotnet#94451)
4feec00
* Use live M.Bcl.AsyncInterfaces dependency
* Update Microsoft.Bcl.TimeProvider.csproj
@cincuranet
Add option for R2R configured runs. (dotnet#94412)
2801995
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/source-build-exter…
4d2ef11
…nals build 20231106.2 (dotnet#94463)
Microsoft.SourceBuild.Intermediate.source-build-externals
From Version 9.0.0-alpha.1.23530.1 -> To Version 9.0.0-alpha.1.23556.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@jtschuster
Merge branch 'StackOverflowLinuxNAOT' ofhttps://github.com/jtschuste…
8b6b9cd
…r/runtime into StackOverflowLinuxNAOT
@jtschuster
Use IsSingleFile and update Main signature
4aa9912
@jtschuster
jtschuster
marked this pull request as draft
November 7, 2023 19:12
@jtschusterjtschuster
mentioned this pull request
Nov 7, 2023
 Merged

@jtschuster
jtschuster
commented
Nov 7, 2023

Copy link


Copy Markdown

MemberAuthor
I made some mistake when I pulled main back into this branch. Closing this PR and opened a new one.
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 7, 2023

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 8, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@agockeagockeagocke left review comments
@jkotasjkotasjkotas left review comments
@MichalStrehovskyMichalStrehovskyMichalStrehovsky left review comments
@janvorlijanvorlijanvorli approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomersbomer is a code owner
@radicalradicalAwaiting requested review from radical
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner
@thaystgthaystgAwaiting requested review from thaystg
@kgkgAwaiting requested review from kg
@vargazvargazAwaiting requested review from vargaz
@lambdageeklambdageekAwaiting requested review from lambdageek
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmiloskotlarmilos is a code owner
@fanyang-monofanyang-monoAwaiting requested review from fanyang-mono
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger will be requested when the pull request is marked ready for reviewakoeplinger is a code owner
@marafmarafAwaiting requested review from marafmaraf will be requested when the pull request is marked ready for reviewmaraf is a code owner
@ilonatommyilonatommyAwaiting requested review from ilonatommyilonatommy will be requested when the pull request is marked ready for reviewilonatommy is a code owner
@steveisoksteveisokAwaiting requested review from steveisoksteveisok will be requested when the pull request is marked ready for reviewsteveisok is a code owner
@vitek-karasvitek-karasAwaiting requested review from vitek-karasvitek-karas will be requested when the pull request is marked ready for reviewvitek-karas is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@jtschusterjtschuster

Labels

area-NativeAOT-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[NativeAOT] Stackoverflow reporting on Linux


20 participants

@jtschuster@janvorli@jkotas@MichalStrehovsky@agocke@trylek@AndyAyersMS@wfurt@ViktorHofer@tannergooding@kouvel@pavelsavara@yurai007@mkhamoyan@vitek-karas@kg@ilonatommy@pentp@BruceForstall@hoyosjs