Report StackOverflowException on NativeAOT on Linux by jtschuster · Pull Request #94485 · dotnet/runtime

jtschuster · 2023-11-07T19:23:17Z

Moved #93901 here. Pulling main messed up something, so just going to make a new PR.

Uses similar code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.

Fixes#82334

Updates the baseservices/exceptions/stackoverflow test to be one project and run on NativeAOT.

Use SA_ONSTACK for SIGSEGV handler Call sigaltstack() to set the alternate stack on the main thread only Check if faulting address is near the stack pointer, if so, report stack overflow

…erflowLinuxNAOT

…exceptions

…ester.cs Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

…cted failures and remove messages about failing to find createdump

…erflowLinuxNAOT

Co-authored-by: Jan Vorlicek <jan.vorlicek@volny.cz>

…r/runtime into StackOverflowLinuxNAOT

ghost · 2023-11-07T19:24:53Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Moved #93901 here. Pulling main messed up something, so just going to make a new PR.

Uses similar code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.

Fixes #82334

Updates the baseservices/exceptions/stackoverflow test to be one project and run on NativeAOT.

Author:	jtschuster
Assignees:	jtschuster
Labels:	`area-NativeAOT-coreclr`, `needs-area-label`
Milestone:	-

janvorli

LGTM, thank you!

jtschuster · 2023-11-09T18:30:59Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2023-11-09T18:31:14Z

Azure Pipelines successfully started running 1 pipeline(s).

jtschuster · 2023-11-10T22:54:51Z

@MichalStrehovsky Can you take a look and sign off when you get a chance?

This reverts commit 261668f.

…#95415) This reverts commit 261668f. We're hitting seg faults instead of null reference exceptions in tests after this change. Reverting to make sure this caused the issue, and then investigate.

…otnet#94485)" (dotnet#95415)" This reverts commit 5429833.

jtschuster · 2023-11-07T19:23:17Z

Moved #93901 here. Pulling main messed up something, so just going to make a new PR.

Uses similar code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.

Fixes#82334

Updates the baseservices/exceptions/stackoverflow test to be one project and run on NativeAOT.

Use SA_ONSTACK for SIGSEGV handler Call sigaltstack() to set the alternate stack on the main thread only Check if faulting address is near the stack pointer, if so, report stack overflow

…erflowLinuxNAOT

…exceptions

…ester.cs Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

…cted failures and remove messages about failing to find createdump

…erflowLinuxNAOT

Co-authored-by: Jan Vorlicek <jan.vorlicek@volny.cz>

…r/runtime into StackOverflowLinuxNAOT

ghost · 2023-11-07T19:24:53Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Moved #93901 here. Pulling main messed up something, so just going to make a new PR.

Uses similar code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.

Fixes #82334

Updates the baseservices/exceptions/stackoverflow test to be one project and run on NativeAOT.

Author:	jtschuster
Assignees:	jtschuster
Labels:	`area-NativeAOT-coreclr`, `needs-area-label`
Milestone:	-

janvorli

LGTM, thank you!

jtschuster · 2023-11-09T18:30:59Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2023-11-09T18:31:14Z

Azure Pipelines successfully started running 1 pipeline(s).

jtschuster · 2023-11-10T22:54:51Z

@MichalStrehovsky Can you take a look and sign off when you get a chance?

This reverts commit 261668f.

…#95415) This reverts commit 261668f. We're hitting seg faults instead of null reference exceptions in tests after this change. Reverting to make sure this caused the issue, and then investigate.

…otnet#94485)" (dotnet#95415)" This reverts commit 5429833.

jtschuster · 2023-11-07T19:23:17Z

Moved #93901 here. Pulling main messed up something, so just going to make a new PR.

Uses similar code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.

Fixes#82334

Updates the baseservices/exceptions/stackoverflow test to be one project and run on NativeAOT.

Use SA_ONSTACK for SIGSEGV handler Call sigaltstack() to set the alternate stack on the main thread only Check if faulting address is near the stack pointer, if so, report stack overflow

…erflowLinuxNAOT

…exceptions

…ester.cs Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

…cted failures and remove messages about failing to find createdump

…erflowLinuxNAOT

Co-authored-by: Jan Vorlicek <jan.vorlicek@volny.cz>

…r/runtime into StackOverflowLinuxNAOT

ghost · 2023-11-07T19:24:53Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Moved #93901 here. Pulling main messed up something, so just going to make a new PR.

Uses similar code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.

Fixes #82334

Updates the baseservices/exceptions/stackoverflow test to be one project and run on NativeAOT.

Author:	jtschuster
Assignees:	jtschuster
Labels:	`area-NativeAOT-coreclr`, `needs-area-label`
Milestone:	-

janvorli

LGTM, thank you!

jtschuster · 2023-11-09T18:30:59Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2023-11-09T18:31:14Z

Azure Pipelines successfully started running 1 pipeline(s).

jtschuster · 2023-11-10T22:54:51Z

@MichalStrehovsky Can you take a look and sign off when you get a chance?

This reverts commit 261668f.

…#95415) This reverts commit 261668f. We're hitting seg faults instead of null reference exceptions in tests after this change. Reverting to make sure this caused the issue, and then investigate.

…otnet#94485)" (dotnet#95415)" This reverts commit 5429833.

jtschuster · 2023-11-07T19:23:17Z

Moved #93901 here. Pulling main messed up something, so just going to make a new PR.

Uses similar code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.

Fixes#82334

Updates the baseservices/exceptions/stackoverflow test to be one project and run on NativeAOT.

Use SA_ONSTACK for SIGSEGV handler Call sigaltstack() to set the alternate stack on the main thread only Check if faulting address is near the stack pointer, if so, report stack overflow

…erflowLinuxNAOT

…exceptions

…ester.cs Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

…cted failures and remove messages about failing to find createdump

…erflowLinuxNAOT

Co-authored-by: Jan Vorlicek <jan.vorlicek@volny.cz>

…r/runtime into StackOverflowLinuxNAOT

ghost · 2023-11-07T19:24:53Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Moved #93901 here. Pulling main messed up something, so just going to make a new PR.

Uses similar code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.

Fixes #82334

Updates the baseservices/exceptions/stackoverflow test to be one project and run on NativeAOT.

Author:	jtschuster
Assignees:	jtschuster
Labels:	`area-NativeAOT-coreclr`, `needs-area-label`
Milestone:	-

janvorli

LGTM, thank you!

jtschuster · 2023-11-09T18:30:59Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2023-11-09T18:31:14Z

Azure Pipelines successfully started running 1 pipeline(s).

jtschuster · 2023-11-10T22:54:51Z

@MichalStrehovsky Can you take a look and sign off when you get a chance?

This reverts commit 261668f.

…#95415) This reverts commit 261668f. We're hitting seg faults instead of null reference exceptions in tests after this change. Reverting to make sure this caused the issue, and then investigate.

…otnet#94485)" (dotnet#95415)" This reverts commit 5429833.

jtschuster · 2023-11-07T19:23:17Z

Moved #93901 here. Pulling main messed up something, so just going to make a new PR.

Uses similar code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.

Fixes#82334

Updates the baseservices/exceptions/stackoverflow test to be one project and run on NativeAOT.

Use SA_ONSTACK for SIGSEGV handler Call sigaltstack() to set the alternate stack on the main thread only Check if faulting address is near the stack pointer, if so, report stack overflow

…erflowLinuxNAOT

…exceptions

…ester.cs Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

…cted failures and remove messages about failing to find createdump

…erflowLinuxNAOT

Co-authored-by: Jan Vorlicek <jan.vorlicek@volny.cz>

…r/runtime into StackOverflowLinuxNAOT

ghost · 2023-11-07T19:24:53Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Moved #93901 here. Pulling main messed up something, so just going to make a new PR.

Uses similar code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.

Fixes #82334

Updates the baseservices/exceptions/stackoverflow test to be one project and run on NativeAOT.

Author:	jtschuster
Assignees:	jtschuster
Labels:	`area-NativeAOT-coreclr`, `needs-area-label`
Milestone:	-

janvorli

LGTM, thank you!

jtschuster · 2023-11-09T18:30:59Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2023-11-09T18:31:14Z

Azure Pipelines successfully started running 1 pipeline(s).

jtschuster · 2023-11-10T22:54:51Z

@MichalStrehovsky Can you take a look and sign off when you get a chance?

This reverts commit 261668f.

…#95415) This reverts commit 261668f. We're hitting seg faults instead of null reference exceptions in tests after this change. Reverting to make sure this caused the issue, and then investigate.

…otnet#94485)" (dotnet#95415)" This reverts commit 5429833.

jtschuster · 2023-11-07T19:23:17Z

Moved #93901 here. Pulling main messed up something, so just going to make a new PR.

Uses similar code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.

Fixes#82334

Updates the baseservices/exceptions/stackoverflow test to be one project and run on NativeAOT.

Use SA_ONSTACK for SIGSEGV handler Call sigaltstack() to set the alternate stack on the main thread only Check if faulting address is near the stack pointer, if so, report stack overflow

…erflowLinuxNAOT

…exceptions

…ester.cs Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

…cted failures and remove messages about failing to find createdump

…erflowLinuxNAOT

Co-authored-by: Jan Vorlicek <jan.vorlicek@volny.cz>

…r/runtime into StackOverflowLinuxNAOT

ghost · 2023-11-07T19:24:53Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Moved #93901 here. Pulling main messed up something, so just going to make a new PR.

Uses similar code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.

Fixes #82334

Updates the baseservices/exceptions/stackoverflow test to be one project and run on NativeAOT.

Author:	jtschuster
Assignees:	jtschuster
Labels:	`area-NativeAOT-coreclr`, `needs-area-label`
Milestone:	-

janvorli

LGTM, thank you!

jtschuster · 2023-11-09T18:30:59Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2023-11-09T18:31:14Z

Azure Pipelines successfully started running 1 pipeline(s).

jtschuster · 2023-11-10T22:54:51Z

@MichalStrehovsky Can you take a look and sign off when you get a chance?

This reverts commit 261668f.

…#95415) This reverts commit 261668f. We're hitting seg faults instead of null reference exceptions in tests after this change. Reverting to make sure this caused the issue, and then investigate.

…otnet#94485)" (dotnet#95415)" This reverts commit 5429833.

jtschuster · 2023-11-07T19:23:17Z

Moved #93901 here. Pulling main messed up something, so just going to make a new PR.

Uses similar code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.

Fixes#82334

Updates the baseservices/exceptions/stackoverflow test to be one project and run on NativeAOT.

Use SA_ONSTACK for SIGSEGV handler Call sigaltstack() to set the alternate stack on the main thread only Check if faulting address is near the stack pointer, if so, report stack overflow

…erflowLinuxNAOT

…exceptions

…ester.cs Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

…cted failures and remove messages about failing to find createdump

…erflowLinuxNAOT

Co-authored-by: Jan Vorlicek <jan.vorlicek@volny.cz>

…r/runtime into StackOverflowLinuxNAOT

ghost · 2023-11-07T19:24:53Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Moved #93901 here. Pulling main messed up something, so just going to make a new PR.

Uses similar code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.

Fixes #82334

Updates the baseservices/exceptions/stackoverflow test to be one project and run on NativeAOT.

Author:	jtschuster
Assignees:	jtschuster
Labels:	`area-NativeAOT-coreclr`, `needs-area-label`
Milestone:	-

janvorli

LGTM, thank you!

jtschuster · 2023-11-09T18:30:59Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2023-11-09T18:31:14Z

Azure Pipelines successfully started running 1 pipeline(s).

jtschuster · 2023-11-10T22:54:51Z

@MichalStrehovsky Can you take a look and sign off when you get a chance?

This reverts commit 261668f.

…#95415) This reverts commit 261668f. We're hitting seg faults instead of null reference exceptions in tests after this change. Reverting to make sure this caused the issue, and then investigate.

…otnet#94485)" (dotnet#95415)" This reverts commit 5429833.

jtschuster · 2023-11-07T19:23:17Z

Moved #93901 here. Pulling main messed up something, so just going to make a new PR.

Uses similar code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.

Fixes#82334

Updates the baseservices/exceptions/stackoverflow test to be one project and run on NativeAOT.

Use SA_ONSTACK for SIGSEGV handler Call sigaltstack() to set the alternate stack on the main thread only Check if faulting address is near the stack pointer, if so, report stack overflow

…erflowLinuxNAOT

…exceptions

…ester.cs Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

…cted failures and remove messages about failing to find createdump

…erflowLinuxNAOT

Co-authored-by: Jan Vorlicek <jan.vorlicek@volny.cz>

…r/runtime into StackOverflowLinuxNAOT

ghost · 2023-11-07T19:24:53Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Moved #93901 here. Pulling main messed up something, so just going to make a new PR.

Uses similar code as CoreCLR to allocate an alternate stack for handling SIGSEGV, and properly reports a StackOverflowException.

Fixes #82334

Updates the baseservices/exceptions/stackoverflow test to be one project and run on NativeAOT.

Author:	jtschuster
Assignees:	jtschuster
Labels:	`area-NativeAOT-coreclr`, `needs-area-label`
Milestone:	-

janvorli

LGTM, thank you!

jtschuster · 2023-11-09T18:30:59Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2023-11-09T18:31:14Z

Azure Pipelines successfully started running 1 pipeline(s).

jtschuster · 2023-11-10T22:54:51Z

@MichalStrehovsky Can you take a look and sign off when you get a chance?

This reverts commit 261668f.

…#95415) This reverts commit 261668f. We're hitting seg faults instead of null reference exceptions in tests after this change. Reverting to make sure this caused the issue, and then investigate.

…otnet#94485)" (dotnet#95415)" This reverts commit 5429833.

jtschusterand others added 22 commits October 19, 2023 19:49

Report stack overflow in linux
8260630
Use SA_ONSTACK for SIGSEGV handler Call sigaltstack() to set the alternate stack on the main thread only Check if faulting address is near the stack pointer, if so, report stack overflow

Set up signal alternate stack on all new threads
263262c

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto StackOv…
adc342f
…erflowLinuxNAOT

Add test to naot smoke tests
666d231

Only allocate sigaltstack in Thread::Construct
c44e631

Remove other getpagesize calls and guard sigaltstack when using mach …
1976a38
…exceptions

Use CLR stackoverflow test for NAOT, don't use sigaltstack on tvos
fa0511c

Cast to size_t before comparison
3f58039

Uncomment code and fix for NAOT
bda88cb

Merge stackoverflow tests into one assembly
aa7354a

Update src/tests/baseservices/exceptions/stackoverflow/stackoverflowt…
ceff368
…ester.cs Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

Revert msbuild change that's no longer needed
3e0b99a

Fix namespace changes
7a4e6dc

Set DOTNET_DbgEnableMiniDump=0 on subprocesses to avoid dumps on expe…
07c98d1
…cted failures and remove messages about failing to find createdump

Missed semicolon
eb59bb7

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto StackOv…
4a27f1e
…erflowLinuxNAOT

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto StackOv…
966d861
…erflowLinuxNAOT

Convert generated xunit runner test to work with NAOT
daf9cec

Don't use xunit generator for stackoverflowtester
257b2df

Update src/coreclr/nativeaot/Runtime/thread.h
f8dfd67
Co-authored-by: Jan Vorlicek <jan.vorlicek@volny.cz>

Merge branch 'StackOverflowLinuxNAOT' ofhttps://github.com/jtschuste…
8b6b9cd
…r/runtime into StackOverflowLinuxNAOT

Use IsSingleFile and update Main signature
4aa9912

jtschuster requested a review from MichalStrehovsky as a code owner November 7, 2023 19:23

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 7, 2023

ghost assigned jtschuster Nov 7, 2023

jtschuster added area-NativeAOT-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 7, 2023

This was referenced Nov 7, 2023
Timeout in System.Net.Quic.Functional.Tests #86019
Closed
CI error: System.Net.Quic.QuicException: The connection timed out from inactivity #91757
Closed

janvorli approved these changes Nov 9, 2023
View reviewed changes

This was referenced Nov 9, 2023
[Test Failure] System.Net.Security.Tests.CertificateValidationClientServer.CertificateValidationClientServer_EndToEnd_Ok on Windows AoT #88832
Closed
LibraryImportGenerator unit test segfault illegal memory access #89054
Closed

MichalStrehovsky approved these changes Nov 13, 2023
View reviewed changes

jtschuster merged commit 261668f into dotnet:mainNov 13, 2023

jkotas mentioned this pull request Nov 16, 2023
SIGSEGV in System.Numerics.Vectors #94856
Closed

jtschuster mentioned this pull request Nov 29, 2023
[outerloop] [NativeAOT] Segmentation fault in System.Runtime.InteropServices.Tests #95414
Closed

jtschuster added a commit that referenced this pull request Nov 29, 2023
Revert "Report StackOverflowException on NativeAOT on Linux (#94485)"
63592fb
This reverts commit 261668f.

jtschuster mentioned this pull request Nov 29, 2023
Revert "Report StackOverflowException on NativeAOT on Linux" #95415
Merged

jtschuster added a commit to jtschuster/runtime that referenced this pull request Dec 8, 2023
Revert "Revert "Report StackOverflowException on NativeAOT on Linux (d…
abf29a6
…otnet#94485)" (dotnet#95415)" This reverts commit 5429833.

github-actionsBot locked and limited conversation to collaborators Dec 14, 2023