[wasm] Suppress export name minification - #95613

Merged
kg merged 1 commit into
dotnet:mainfrom
kg:suppress-export-renaming
Dec 6, 2023
Merged

[wasm] Suppress export name minification#95613
kg merged 1 commit into
dotnet:mainfrom
kg:suppress-export-renaming

Conversation

@kg

@kgkg commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

@kgkg added the arch-wasm WebAssembly architecture label Dec 4, 2023
@ghost

ghost commented Dec 4, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Possible fix for #94939.
See emscripten-core/emscripten#20762

Author:kg
Assignees:-
Labels:

arch-wasm

Milestone:-

@ghostghost added the area-Build-mono label Dec 4, 2023
@ghostghost assigned kgDec 4, 2023
@radical

radical commented Dec 5, 2023

Copy link
Copy Markdown
Member

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Dec 5, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Dec 5, 2023
Open
Closed
@pavelsavara

pavelsavara commented Dec 5, 2023

Copy link
Copy Markdown
Member

It seems to me that this could also fix #92664 (comment)

@kg could you please elaborate about the alternative solution "Rather than export those functions, could you add them to the table at compile time" mentioned in the emscripten discussion ?

We need the raw exports for the jiterp trace .wasm, right ? I don't understand how that would be possible without export from dotnet.wasm

@pavelsavara

pavelsavara commented Dec 5, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Probably unrelated

Log

WasiApp.Native.targets(303,5): error : Failed to compile C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.bc -> C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.o [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>C:\Windows\System32\chcp.com 65001 1>nul [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>setlocal [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>set errorlevel=dummy [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>set errorlevel= [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>C:\helix\work\correlation\build\\wasi-sdk\\bin\clang.exe "@C:\helix\work\correlation\build\microsoft.netcore.app.runtime.wasi-wasm\runtimes\wasi-wasm\native\src\wasi-default.rsp" "@C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\wasi-compile-bc.rsp" -c -o "C:\Users\ContainerAdministrator\AppData\Local\Temp\tmpvcc01g.tmp" "C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.bc" [ProxyProjectForAOTOnHelix.proj]
clang version 16.0.0 [ProxyProjectForAOTOnHelix.proj]
Target: wasm32-unknown-wasi [ProxyProjectForAOTOnHelix.proj]
Thread model: posix [ProxyProjectForAOTOnHelix.proj]
InstalledDir: C:/helix/work/correlation/build//wasi-sdk//bin [ProxyProjectForAOTOnHelix.proj]
(in-process) [ProxyProjectForAOTOnHelix.proj]
"C:/helix/work/correlation/build/wasi-sdk/bin/clang.exe" -cc1 -triple wasm32-unknown-wasi -emit-obj -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name aot-instances.dll.bc -mrelocation-model static -mframe-pointer=none -ffp-contract=on -fno-rounding-math -mconstructor-aliases -target-cpu generic -fvisibility=hidden -mllvm -treat-scalable-fixed-error-as-warning -debug-info-kind=constructor -dwarf-version=4 -debugger-tuning=gdb -v -fcoverage-compilation-dir=C:/helix/work/workitem/e/publish -resource-dir C:/helix/work/correlation/build/wasi-sdk/lib/clang/16 -Oz -fdebug-compilation-dir=C:/helix/work/workitem/e/publish -ferror-limit 19 -fgnuc-version=4.2.1 -vectorize-slp -o "C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\tmpvcc01g.tmp" -x ir "C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\aot-instances.dll.bc" [ProxyProjectForAOTOnHelix.proj]
clang -cc1 version 16.0.0 based upon LLVM 16.0.0 default target wasm32-wasi [ProxyProjectForAOTOnHelix.proj]
LLVM ERROR: out of memory [ProxyProjectForAOTOnHelix.proj]
Allocation failed [ProxyProjectForAOTOnHelix.proj]
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script. [ProxyProjectForAOTOnHelix.proj]
Stack dump: [ProxyProjectForAOTOnHelix.proj]
0.	Program arguments: C:\\helix\\work\\correlation\\build\\\\wasi-sdk\\\\bin\\clang.exe @C:\\helix\\work\\correlation\\build\\microsoft.netcore.app.runtime.wasi-wasm\\runtimes\\wasi-wasm\\native\\src\\wasi-default.rsp @C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\wasi-compile-bc.rsp -c -o C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\tmpvcc01g.tmp C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\aot-instances.dll.bc [ProxyProjectForAOTOnHelix.proj]
1.	Code generation [ProxyProjectForAOTOnHelix.proj]
Exception Code: 0xC000001D [ProxyProjectForAOTOnHelix.proj]
0x008DFB73 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x7292C902 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x008C23A1 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D3FD3C <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D3FFBC <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D40133 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x0079E5CF <unknown module> [ProxyProjectForAOTOnHelix.proj]
clang: error: clang frontend command failed due to signal (use -v to see invocation) [ProxyProjectForAOTOnHelix.proj]
clang version 16.0.0 [ProxyProjectForAOTOnHelix.proj]
Target: wasm32-unknown-wasi [ProxyProjectForAOTOnHelix.proj]
Thread model: posix [ProxyProjectForAOTOnHelix.proj]
InstalledDir: C:/helix/work/correlation/build//wasi-sdk//bin [ProxyProjectForAOTOnHelix.proj]
clang: note: diagnostic msg: Error generating preprocessed source(s) - no preprocessable inputs. [took 91.69s] [ProxyProjectForAOTOnHelix.proj]

@kg

kg commented Dec 5, 2023

Copy link
Copy Markdown
ContributorAuthor

It seems to me that this could also fix #92664 (comment)

@kg could you please elaborate about the alternative solution "Rather than export those functions, could you add them to the table at compile time" mentioned in the emscripten discussion ?

We need the raw exports for the jiterp trace .wasm, right ? I don't understand how that would be possible without export from dotnet.wasm

It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this

@pavelsavara

pavelsavara commented Dec 5, 2023

Copy link
Copy Markdown
Member

It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this

So you get back pointer, but in the trace import, you need the index into the export table, no ?

@kg

kg commented Dec 5, 2023

Copy link
Copy Markdown
ContributorAuthor

It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this

So you get back pointer, but in the trace import, you need the index into the export table, no ?

The function pointer is an index

@radical

radical commented Dec 5, 2023

Copy link
Copy Markdown
Member

Probably unrelated

Log

LLVM ERROR: out of memory

lewing
lewing approved these changes Dec 6, 2023
View reviewed changes

@lewinglewing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be worth capturing the potential alternate work in an issue here but this fixes known issues directly.

@kg

kg commented Dec 6, 2023

Copy link
Copy Markdown
ContributorAuthor

Red is #89409, and we have confirmation from a user that this fixes the issue for them, so merging

@kg
kg merged commit 69d5d3f into dotnet:mainDec 6, 2023
@radicalradical mentioned this pull request Dec 6, 2023
Merged
@pavelsavara

pavelsavara commented Dec 6, 2023

Copy link
Copy Markdown
Member

are we going to backport it to Net8 ?

@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jan 6, 2024
@maraf

maraf commented May 13, 2024

Copy link
Copy Markdown
Member

/backport to release/8.0-staging

@github-actionsgithub-actionsBot unlocked this conversation May 13, 2024
@github-actions

github-actionsBot commented May 13, 2024

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/9063189552

@github-actions

github-actionsBot commented May 13, 2024

Copy link
Copy Markdown
Contributor

@maraf backporting to release/8.0-staging failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Suppress export name minification
Using index info to reconstruct a base tree...
M	src/mono/wasm/build/WasmApp.Native.targets
M	src/mono/wasm/wasm.proj
Falling back to patching base and 3-way merge...
Auto-merging src/mono/wasm/wasm.proj
Auto-merging src/mono/wasm/build/WasmApp.Native.targets
CONFLICT (content): Merge conflict in src/mono/wasm/build/WasmApp.Native.targets
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Suppress export name minification
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions

github-actionsBot commented May 13, 2024

Copy link
Copy Markdown
Contributor

@maraf an error occurred while backporting to release/8.0-staging, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

@github-actionsgithub-actionsBot locked as resolved and limited conversation to collaborators May 13, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewinglewinglewing approved these changes
@pavelsavarapavelsavarapavelsavara approved these changes
@radicalradicalAwaiting requested review from radical

Assignees

@kgkg

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kg@radical@pavelsavara@maraf@lewing
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[wasm] Suppress export name minification - #95613
Merged
kg merged 1 commit into
dotnet:mainfrom 
kg:suppress-export-renaming
Dec 6, 2023
Merged
[wasm] Suppress export name minification#95613
kg merged 1 commit into
dotnet:mainfrom 
kg:suppress-export-renaming
Conversation
@kg
@kgkg
commented
Dec 4, 2023

Copy link


Copy Markdown

Contributor
@kgkg
added
the 
arch-wasm
WebAssembly architecture
label
Dec 4, 2023
@ghost
ghost
commented
Dec 4, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
Possible fix for #94939.

See emscripten-core/emscripten#20762
Author:kg
Assignees:-
Labels:
arch-wasm
Milestone:-
@ghostghost
added
the 
area-Build-mono

label
Dec 4, 2023
@ghostghost
assigned kgDec 4, 2023
@radical
radical
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 5, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Dec 5, 2023

Open


Closed

@pavelsavara
pavelsavara
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
It seems to me that this could also fix #92664 (comment)
@kg could you please elaborate about the alternative solution "Rather than export those functions, could you add them to the table at compile time" mentioned in the emscripten discussion ?
We need the raw exports for the jiterp trace .wasm, right ? I don't understand how that would be possible without export from dotnet.wasm
@pavelsavara
pavelsavara
commented
Dec 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Probably unrelated
Log
WasiApp.Native.targets(303,5): error : Failed to compile C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.bc -> C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.o [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>C:\Windows\System32\chcp.com 65001 1>nul [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>setlocal [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>set errorlevel=dummy [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>set errorlevel= [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>C:\helix\work\correlation\build\\wasi-sdk\\bin\clang.exe "@C:\helix\work\correlation\build\microsoft.netcore.app.runtime.wasi-wasm\runtimes\wasi-wasm\native\src\wasi-default.rsp" "@C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\wasi-compile-bc.rsp" -c -o "C:\Users\ContainerAdministrator\AppData\Local\Temp\tmpvcc01g.tmp" "C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.bc" [ProxyProjectForAOTOnHelix.proj]
clang version 16.0.0 [ProxyProjectForAOTOnHelix.proj]
Target: wasm32-unknown-wasi [ProxyProjectForAOTOnHelix.proj]
Thread model: posix [ProxyProjectForAOTOnHelix.proj]
InstalledDir: C:/helix/work/correlation/build//wasi-sdk//bin [ProxyProjectForAOTOnHelix.proj]
(in-process) [ProxyProjectForAOTOnHelix.proj]
"C:/helix/work/correlation/build/wasi-sdk/bin/clang.exe" -cc1 -triple wasm32-unknown-wasi -emit-obj -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name aot-instances.dll.bc -mrelocation-model static -mframe-pointer=none -ffp-contract=on -fno-rounding-math -mconstructor-aliases -target-cpu generic -fvisibility=hidden -mllvm -treat-scalable-fixed-error-as-warning -debug-info-kind=constructor -dwarf-version=4 -debugger-tuning=gdb -v -fcoverage-compilation-dir=C:/helix/work/workitem/e/publish -resource-dir C:/helix/work/correlation/build/wasi-sdk/lib/clang/16 -Oz -fdebug-compilation-dir=C:/helix/work/workitem/e/publish -ferror-limit 19 -fgnuc-version=4.2.1 -vectorize-slp -o "C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\tmpvcc01g.tmp" -x ir "C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\aot-instances.dll.bc" [ProxyProjectForAOTOnHelix.proj]
clang -cc1 version 16.0.0 based upon LLVM 16.0.0 default target wasm32-wasi [ProxyProjectForAOTOnHelix.proj]
LLVM ERROR: out of memory [ProxyProjectForAOTOnHelix.proj]
Allocation failed [ProxyProjectForAOTOnHelix.proj]
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script. [ProxyProjectForAOTOnHelix.proj]
Stack dump: [ProxyProjectForAOTOnHelix.proj]
0.	Program arguments: C:\\helix\\work\\correlation\\build\\\\wasi-sdk\\\\bin\\clang.exe @C:\\helix\\work\\correlation\\build\\microsoft.netcore.app.runtime.wasi-wasm\\runtimes\\wasi-wasm\\native\\src\\wasi-default.rsp @C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\wasi-compile-bc.rsp -c -o C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\tmpvcc01g.tmp C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\aot-instances.dll.bc [ProxyProjectForAOTOnHelix.proj]
1.	Code generation [ProxyProjectForAOTOnHelix.proj]
Exception Code: 0xC000001D [ProxyProjectForAOTOnHelix.proj]
0x008DFB73 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x7292C902 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x008C23A1 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D3FD3C <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D3FFBC <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D40133 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x0079E5CF <unknown module> [ProxyProjectForAOTOnHelix.proj]
clang: error: clang frontend command failed due to signal (use -v to see invocation) [ProxyProjectForAOTOnHelix.proj]
clang version 16.0.0 [ProxyProjectForAOTOnHelix.proj]
Target: wasm32-unknown-wasi [ProxyProjectForAOTOnHelix.proj]
Thread model: posix [ProxyProjectForAOTOnHelix.proj]
InstalledDir: C:/helix/work/correlation/build//wasi-sdk//bin [ProxyProjectForAOTOnHelix.proj]
clang: note: diagnostic msg: Error generating preprocessed source(s) - no preprocessable inputs. [took 91.69s] [ProxyProjectForAOTOnHelix.proj]

@kg
kg
commented
Dec 5, 2023

Copy link


Copy Markdown

ContributorAuthor
It seems to me that this could also fix #92664 (comment)
@kg could you please elaborate about the alternative solution "Rather than export those functions, could you add them to the table at compile time" mentioned in the emscripten discussion ?
We need the raw exports for the jiterp trace .wasm, right ? I don't understand how that would be possible without export from dotnet.wasm
It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this
@pavelsavara
pavelsavara
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this
So you get back pointer, but in the trace import, you need the index into the export table, no ?
@kg
kg
commented
Dec 5, 2023

Copy link


Copy Markdown

ContributorAuthor
It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this
So you get back pointer, but in the trace import, you need the index into the export table, no ?
The function pointer is an index
@radical
radical
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
Probably unrelated
Log
LLVM ERROR: out of memory
lewing
lewing
approved these changes
Dec 6, 2023
View reviewed changes
@lewinglewing
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be worth capturing the potential alternate work in an issue here but this fixes known issues directly.
@kg
kg
commented
Dec 6, 2023

Copy link


Copy Markdown

ContributorAuthor
Red is #89409, and we have confirmation from a user that this fixes the issue for them, so merging
@kg
kg
merged commit 69d5d3f
into
dotnet:mainDec 6, 2023
@radicalradical
mentioned this pull request
Dec 6, 2023
 Merged

@pavelsavara
pavelsavara
commented
Dec 6, 2023

Copy link


Copy Markdown

Member
are we going to backport it to Net8 ?
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jan 6, 2024
@maraf
maraf
commented
May 13, 2024

Copy link


Copy Markdown

Member
/backport to release/8.0-staging
@github-actionsgithub-actionsBot
unlocked this conversation
May 13, 2024
@github-actions
github-actionsBot
commented
May 13, 2024

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/9063189552
@github-actions
github-actionsBot
commented
May 13, 2024

Copy link


Copy Markdown

Contributor
@maraf backporting to release/8.0-staging failed, the patch most likely resulted in conflicts:
$ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Suppress export name minification
Using index info to reconstruct a base tree...
M	src/mono/wasm/build/WasmApp.Native.targets
M	src/mono/wasm/wasm.proj
Falling back to patching base and 3-way merge...
Auto-merging src/mono/wasm/wasm.proj
Auto-merging src/mono/wasm/build/WasmApp.Native.targets
CONFLICT (content): Merge conflict in src/mono/wasm/build/WasmApp.Native.targets
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Suppress export name minification
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128
Please backport manually!
@github-actions
github-actionsBot
commented
May 13, 2024

Copy link


Copy Markdown

Contributor
@maraf an error occurred while backporting to release/8.0-staging, please check the run log for details!
Error: git am failed, most likely due to a merge conflict.
@github-actionsgithub-actionsBot
locked as resolved and limited conversation to collaborators
May 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes
@pavelsavarapavelsavarapavelsavara approved these changes
@radicalradicalAwaiting requested review from radical

Assignees

@kgkg

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@kg@radical@pavelsavara@maraf@lewing

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[wasm] Suppress export name minification - #95613
Merged
kg merged 1 commit into
dotnet:mainfrom 
kg:suppress-export-renaming
Dec 6, 2023
Merged
[wasm] Suppress export name minification#95613
kg merged 1 commit into
dotnet:mainfrom 
kg:suppress-export-renaming
Conversation
@kg
@kgkg
commented
Dec 4, 2023

Copy link


Copy Markdown

Contributor
@kgkg
added
the 
arch-wasm
WebAssembly architecture
label
Dec 4, 2023
@ghost
ghost
commented
Dec 4, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
Possible fix for #94939.

See emscripten-core/emscripten#20762
Author:kg
Assignees:-
Labels:
arch-wasm
Milestone:-
@ghostghost
added
the 
area-Build-mono

label
Dec 4, 2023
@ghostghost
assigned kgDec 4, 2023
@radical
radical
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 5, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Dec 5, 2023

Open


Closed

@pavelsavara
pavelsavara
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
It seems to me that this could also fix #92664 (comment)
@kg could you please elaborate about the alternative solution "Rather than export those functions, could you add them to the table at compile time" mentioned in the emscripten discussion ?
We need the raw exports for the jiterp trace .wasm, right ? I don't understand how that would be possible without export from dotnet.wasm
@pavelsavara
pavelsavara
commented
Dec 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Probably unrelated
Log
WasiApp.Native.targets(303,5): error : Failed to compile C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.bc -> C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.o [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>C:\Windows\System32\chcp.com 65001 1>nul [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>setlocal [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>set errorlevel=dummy [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>set errorlevel= [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>C:\helix\work\correlation\build\\wasi-sdk\\bin\clang.exe "@C:\helix\work\correlation\build\microsoft.netcore.app.runtime.wasi-wasm\runtimes\wasi-wasm\native\src\wasi-default.rsp" "@C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\wasi-compile-bc.rsp" -c -o "C:\Users\ContainerAdministrator\AppData\Local\Temp\tmpvcc01g.tmp" "C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.bc" [ProxyProjectForAOTOnHelix.proj]
clang version 16.0.0 [ProxyProjectForAOTOnHelix.proj]
Target: wasm32-unknown-wasi [ProxyProjectForAOTOnHelix.proj]
Thread model: posix [ProxyProjectForAOTOnHelix.proj]
InstalledDir: C:/helix/work/correlation/build//wasi-sdk//bin [ProxyProjectForAOTOnHelix.proj]
(in-process) [ProxyProjectForAOTOnHelix.proj]
"C:/helix/work/correlation/build/wasi-sdk/bin/clang.exe" -cc1 -triple wasm32-unknown-wasi -emit-obj -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name aot-instances.dll.bc -mrelocation-model static -mframe-pointer=none -ffp-contract=on -fno-rounding-math -mconstructor-aliases -target-cpu generic -fvisibility=hidden -mllvm -treat-scalable-fixed-error-as-warning -debug-info-kind=constructor -dwarf-version=4 -debugger-tuning=gdb -v -fcoverage-compilation-dir=C:/helix/work/workitem/e/publish -resource-dir C:/helix/work/correlation/build/wasi-sdk/lib/clang/16 -Oz -fdebug-compilation-dir=C:/helix/work/workitem/e/publish -ferror-limit 19 -fgnuc-version=4.2.1 -vectorize-slp -o "C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\tmpvcc01g.tmp" -x ir "C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\aot-instances.dll.bc" [ProxyProjectForAOTOnHelix.proj]
clang -cc1 version 16.0.0 based upon LLVM 16.0.0 default target wasm32-wasi [ProxyProjectForAOTOnHelix.proj]
LLVM ERROR: out of memory [ProxyProjectForAOTOnHelix.proj]
Allocation failed [ProxyProjectForAOTOnHelix.proj]
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script. [ProxyProjectForAOTOnHelix.proj]
Stack dump: [ProxyProjectForAOTOnHelix.proj]
0.	Program arguments: C:\\helix\\work\\correlation\\build\\\\wasi-sdk\\\\bin\\clang.exe @C:\\helix\\work\\correlation\\build\\microsoft.netcore.app.runtime.wasi-wasm\\runtimes\\wasi-wasm\\native\\src\\wasi-default.rsp @C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\wasi-compile-bc.rsp -c -o C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\tmpvcc01g.tmp C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\aot-instances.dll.bc [ProxyProjectForAOTOnHelix.proj]
1.	Code generation [ProxyProjectForAOTOnHelix.proj]
Exception Code: 0xC000001D [ProxyProjectForAOTOnHelix.proj]
0x008DFB73 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x7292C902 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x008C23A1 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D3FD3C <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D3FFBC <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D40133 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x0079E5CF <unknown module> [ProxyProjectForAOTOnHelix.proj]
clang: error: clang frontend command failed due to signal (use -v to see invocation) [ProxyProjectForAOTOnHelix.proj]
clang version 16.0.0 [ProxyProjectForAOTOnHelix.proj]
Target: wasm32-unknown-wasi [ProxyProjectForAOTOnHelix.proj]
Thread model: posix [ProxyProjectForAOTOnHelix.proj]
InstalledDir: C:/helix/work/correlation/build//wasi-sdk//bin [ProxyProjectForAOTOnHelix.proj]
clang: note: diagnostic msg: Error generating preprocessed source(s) - no preprocessable inputs. [took 91.69s] [ProxyProjectForAOTOnHelix.proj]

@kg
kg
commented
Dec 5, 2023

Copy link


Copy Markdown

ContributorAuthor
It seems to me that this could also fix #92664 (comment)
@kg could you please elaborate about the alternative solution "Rather than export those functions, could you add them to the table at compile time" mentioned in the emscripten discussion ?
We need the raw exports for the jiterp trace .wasm, right ? I don't understand how that would be possible without export from dotnet.wasm
It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this
@pavelsavara
pavelsavara
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this
So you get back pointer, but in the trace import, you need the index into the export table, no ?
@kg
kg
commented
Dec 5, 2023

Copy link


Copy Markdown

ContributorAuthor
It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this
So you get back pointer, but in the trace import, you need the index into the export table, no ?
The function pointer is an index
@radical
radical
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
Probably unrelated
Log
LLVM ERROR: out of memory
lewing
lewing
approved these changes
Dec 6, 2023
View reviewed changes
@lewinglewing
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be worth capturing the potential alternate work in an issue here but this fixes known issues directly.
@kg
kg
commented
Dec 6, 2023

Copy link


Copy Markdown

ContributorAuthor
Red is #89409, and we have confirmation from a user that this fixes the issue for them, so merging
@kg
kg
merged commit 69d5d3f
into
dotnet:mainDec 6, 2023
@radicalradical
mentioned this pull request
Dec 6, 2023
 Merged

@pavelsavara
pavelsavara
commented
Dec 6, 2023

Copy link


Copy Markdown

Member
are we going to backport it to Net8 ?
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jan 6, 2024
@maraf
maraf
commented
May 13, 2024

Copy link


Copy Markdown

Member
/backport to release/8.0-staging
@github-actionsgithub-actionsBot
unlocked this conversation
May 13, 2024
@github-actions
github-actionsBot
commented
May 13, 2024

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/9063189552
@github-actions
github-actionsBot
commented
May 13, 2024

Copy link


Copy Markdown

Contributor
@maraf backporting to release/8.0-staging failed, the patch most likely resulted in conflicts:
$ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Suppress export name minification
Using index info to reconstruct a base tree...
M	src/mono/wasm/build/WasmApp.Native.targets
M	src/mono/wasm/wasm.proj
Falling back to patching base and 3-way merge...
Auto-merging src/mono/wasm/wasm.proj
Auto-merging src/mono/wasm/build/WasmApp.Native.targets
CONFLICT (content): Merge conflict in src/mono/wasm/build/WasmApp.Native.targets
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Suppress export name minification
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128
Please backport manually!
@github-actions
github-actionsBot
commented
May 13, 2024

Copy link


Copy Markdown

Contributor
@maraf an error occurred while backporting to release/8.0-staging, please check the run log for details!
Error: git am failed, most likely due to a merge conflict.
@github-actionsgithub-actionsBot
locked as resolved and limited conversation to collaborators
May 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes
@pavelsavarapavelsavarapavelsavara approved these changes
@radicalradicalAwaiting requested review from radical

Assignees

@kgkg

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@kg@radical@pavelsavara@maraf@lewing

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[wasm] Suppress export name minification - #95613
Merged
kg merged 1 commit into
dotnet:mainfrom 
kg:suppress-export-renaming
Dec 6, 2023
Merged
[wasm] Suppress export name minification#95613
kg merged 1 commit into
dotnet:mainfrom 
kg:suppress-export-renaming
Conversation
@kg
@kgkg
commented
Dec 4, 2023

Copy link


Copy Markdown

Contributor
@kgkg
added
the 
arch-wasm
WebAssembly architecture
label
Dec 4, 2023
@ghost
ghost
commented
Dec 4, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
Possible fix for #94939.

See emscripten-core/emscripten#20762
Author:kg
Assignees:-
Labels:
arch-wasm
Milestone:-
@ghostghost
added
the 
area-Build-mono

label
Dec 4, 2023
@ghostghost
assigned kgDec 4, 2023
@radical
radical
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 5, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Dec 5, 2023

Open


Closed

@pavelsavara
pavelsavara
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
It seems to me that this could also fix #92664 (comment)
@kg could you please elaborate about the alternative solution "Rather than export those functions, could you add them to the table at compile time" mentioned in the emscripten discussion ?
We need the raw exports for the jiterp trace .wasm, right ? I don't understand how that would be possible without export from dotnet.wasm
@pavelsavara
pavelsavara
commented
Dec 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Probably unrelated
Log
WasiApp.Native.targets(303,5): error : Failed to compile C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.bc -> C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.o [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>C:\Windows\System32\chcp.com 65001 1>nul [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>setlocal [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>set errorlevel=dummy [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>set errorlevel= [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>C:\helix\work\correlation\build\\wasi-sdk\\bin\clang.exe "@C:\helix\work\correlation\build\microsoft.netcore.app.runtime.wasi-wasm\runtimes\wasi-wasm\native\src\wasi-default.rsp" "@C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\wasi-compile-bc.rsp" -c -o "C:\Users\ContainerAdministrator\AppData\Local\Temp\tmpvcc01g.tmp" "C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.bc" [ProxyProjectForAOTOnHelix.proj]
clang version 16.0.0 [ProxyProjectForAOTOnHelix.proj]
Target: wasm32-unknown-wasi [ProxyProjectForAOTOnHelix.proj]
Thread model: posix [ProxyProjectForAOTOnHelix.proj]
InstalledDir: C:/helix/work/correlation/build//wasi-sdk//bin [ProxyProjectForAOTOnHelix.proj]
(in-process) [ProxyProjectForAOTOnHelix.proj]
"C:/helix/work/correlation/build/wasi-sdk/bin/clang.exe" -cc1 -triple wasm32-unknown-wasi -emit-obj -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name aot-instances.dll.bc -mrelocation-model static -mframe-pointer=none -ffp-contract=on -fno-rounding-math -mconstructor-aliases -target-cpu generic -fvisibility=hidden -mllvm -treat-scalable-fixed-error-as-warning -debug-info-kind=constructor -dwarf-version=4 -debugger-tuning=gdb -v -fcoverage-compilation-dir=C:/helix/work/workitem/e/publish -resource-dir C:/helix/work/correlation/build/wasi-sdk/lib/clang/16 -Oz -fdebug-compilation-dir=C:/helix/work/workitem/e/publish -ferror-limit 19 -fgnuc-version=4.2.1 -vectorize-slp -o "C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\tmpvcc01g.tmp" -x ir "C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\aot-instances.dll.bc" [ProxyProjectForAOTOnHelix.proj]
clang -cc1 version 16.0.0 based upon LLVM 16.0.0 default target wasm32-wasi [ProxyProjectForAOTOnHelix.proj]
LLVM ERROR: out of memory [ProxyProjectForAOTOnHelix.proj]
Allocation failed [ProxyProjectForAOTOnHelix.proj]
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script. [ProxyProjectForAOTOnHelix.proj]
Stack dump: [ProxyProjectForAOTOnHelix.proj]
0.	Program arguments: C:\\helix\\work\\correlation\\build\\\\wasi-sdk\\\\bin\\clang.exe @C:\\helix\\work\\correlation\\build\\microsoft.netcore.app.runtime.wasi-wasm\\runtimes\\wasi-wasm\\native\\src\\wasi-default.rsp @C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\wasi-compile-bc.rsp -c -o C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\tmpvcc01g.tmp C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\aot-instances.dll.bc [ProxyProjectForAOTOnHelix.proj]
1.	Code generation [ProxyProjectForAOTOnHelix.proj]
Exception Code: 0xC000001D [ProxyProjectForAOTOnHelix.proj]
0x008DFB73 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x7292C902 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x008C23A1 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D3FD3C <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D3FFBC <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D40133 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x0079E5CF <unknown module> [ProxyProjectForAOTOnHelix.proj]
clang: error: clang frontend command failed due to signal (use -v to see invocation) [ProxyProjectForAOTOnHelix.proj]
clang version 16.0.0 [ProxyProjectForAOTOnHelix.proj]
Target: wasm32-unknown-wasi [ProxyProjectForAOTOnHelix.proj]
Thread model: posix [ProxyProjectForAOTOnHelix.proj]
InstalledDir: C:/helix/work/correlation/build//wasi-sdk//bin [ProxyProjectForAOTOnHelix.proj]
clang: note: diagnostic msg: Error generating preprocessed source(s) - no preprocessable inputs. [took 91.69s] [ProxyProjectForAOTOnHelix.proj]

@kg
kg
commented
Dec 5, 2023

Copy link


Copy Markdown

ContributorAuthor
It seems to me that this could also fix #92664 (comment)
@kg could you please elaborate about the alternative solution "Rather than export those functions, could you add them to the table at compile time" mentioned in the emscripten discussion ?
We need the raw exports for the jiterp trace .wasm, right ? I don't understand how that would be possible without export from dotnet.wasm
It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this
@pavelsavara
pavelsavara
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this
So you get back pointer, but in the trace import, you need the index into the export table, no ?
@kg
kg
commented
Dec 5, 2023

Copy link


Copy Markdown

ContributorAuthor
It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this
So you get back pointer, but in the trace import, you need the index into the export table, no ?
The function pointer is an index
@radical
radical
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
Probably unrelated
Log
LLVM ERROR: out of memory
lewing
lewing
approved these changes
Dec 6, 2023
View reviewed changes
@lewinglewing
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be worth capturing the potential alternate work in an issue here but this fixes known issues directly.
@kg
kg
commented
Dec 6, 2023

Copy link


Copy Markdown

ContributorAuthor
Red is #89409, and we have confirmation from a user that this fixes the issue for them, so merging
@kg
kg
merged commit 69d5d3f
into
dotnet:mainDec 6, 2023
@radicalradical
mentioned this pull request
Dec 6, 2023
 Merged

@pavelsavara
pavelsavara
commented
Dec 6, 2023

Copy link


Copy Markdown

Member
are we going to backport it to Net8 ?
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jan 6, 2024
@maraf
maraf
commented
May 13, 2024

Copy link


Copy Markdown

Member
/backport to release/8.0-staging
@github-actionsgithub-actionsBot
unlocked this conversation
May 13, 2024
@github-actions
github-actionsBot
commented
May 13, 2024

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/9063189552
@github-actions
github-actionsBot
commented
May 13, 2024

Copy link


Copy Markdown

Contributor
@maraf backporting to release/8.0-staging failed, the patch most likely resulted in conflicts:
$ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Suppress export name minification
Using index info to reconstruct a base tree...
M	src/mono/wasm/build/WasmApp.Native.targets
M	src/mono/wasm/wasm.proj
Falling back to patching base and 3-way merge...
Auto-merging src/mono/wasm/wasm.proj
Auto-merging src/mono/wasm/build/WasmApp.Native.targets
CONFLICT (content): Merge conflict in src/mono/wasm/build/WasmApp.Native.targets
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Suppress export name minification
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128
Please backport manually!
@github-actions
github-actionsBot
commented
May 13, 2024

Copy link


Copy Markdown

Contributor
@maraf an error occurred while backporting to release/8.0-staging, please check the run log for details!
Error: git am failed, most likely due to a merge conflict.
@github-actionsgithub-actionsBot
locked as resolved and limited conversation to collaborators
May 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes
@pavelsavarapavelsavarapavelsavara approved these changes
@radicalradicalAwaiting requested review from radical

Assignees

@kgkg

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@kg@radical@pavelsavara@maraf@lewing

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[wasm] Suppress export name minification - #95613
Merged
kg merged 1 commit into
dotnet:mainfrom 
kg:suppress-export-renaming
Dec 6, 2023
Merged
[wasm] Suppress export name minification#95613
kg merged 1 commit into
dotnet:mainfrom 
kg:suppress-export-renaming
Conversation
@kg
@kgkg
commented
Dec 4, 2023

Copy link


Copy Markdown

Contributor
@kgkg
added
the 
arch-wasm
WebAssembly architecture
label
Dec 4, 2023
@ghost
ghost
commented
Dec 4, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
Possible fix for #94939.

See emscripten-core/emscripten#20762
Author:kg
Assignees:-
Labels:
arch-wasm
Milestone:-
@ghostghost
added
the 
area-Build-mono

label
Dec 4, 2023
@ghostghost
assigned kgDec 4, 2023
@radical
radical
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 5, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Dec 5, 2023

Open


Closed

@pavelsavara
pavelsavara
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
It seems to me that this could also fix #92664 (comment)
@kg could you please elaborate about the alternative solution "Rather than export those functions, could you add them to the table at compile time" mentioned in the emscripten discussion ?
We need the raw exports for the jiterp trace .wasm, right ? I don't understand how that would be possible without export from dotnet.wasm
@pavelsavara
pavelsavara
commented
Dec 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Probably unrelated
Log
WasiApp.Native.targets(303,5): error : Failed to compile C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.bc -> C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.o [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>C:\Windows\System32\chcp.com 65001 1>nul [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>setlocal [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>set errorlevel=dummy [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>set errorlevel= [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>C:\helix\work\correlation\build\\wasi-sdk\\bin\clang.exe "@C:\helix\work\correlation\build\microsoft.netcore.app.runtime.wasi-wasm\runtimes\wasi-wasm\native\src\wasi-default.rsp" "@C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\wasi-compile-bc.rsp" -c -o "C:\Users\ContainerAdministrator\AppData\Local\Temp\tmpvcc01g.tmp" "C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.bc" [ProxyProjectForAOTOnHelix.proj]
clang version 16.0.0 [ProxyProjectForAOTOnHelix.proj]
Target: wasm32-unknown-wasi [ProxyProjectForAOTOnHelix.proj]
Thread model: posix [ProxyProjectForAOTOnHelix.proj]
InstalledDir: C:/helix/work/correlation/build//wasi-sdk//bin [ProxyProjectForAOTOnHelix.proj]
(in-process) [ProxyProjectForAOTOnHelix.proj]
"C:/helix/work/correlation/build/wasi-sdk/bin/clang.exe" -cc1 -triple wasm32-unknown-wasi -emit-obj -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name aot-instances.dll.bc -mrelocation-model static -mframe-pointer=none -ffp-contract=on -fno-rounding-math -mconstructor-aliases -target-cpu generic -fvisibility=hidden -mllvm -treat-scalable-fixed-error-as-warning -debug-info-kind=constructor -dwarf-version=4 -debugger-tuning=gdb -v -fcoverage-compilation-dir=C:/helix/work/workitem/e/publish -resource-dir C:/helix/work/correlation/build/wasi-sdk/lib/clang/16 -Oz -fdebug-compilation-dir=C:/helix/work/workitem/e/publish -ferror-limit 19 -fgnuc-version=4.2.1 -vectorize-slp -o "C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\tmpvcc01g.tmp" -x ir "C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\aot-instances.dll.bc" [ProxyProjectForAOTOnHelix.proj]
clang -cc1 version 16.0.0 based upon LLVM 16.0.0 default target wasm32-wasi [ProxyProjectForAOTOnHelix.proj]
LLVM ERROR: out of memory [ProxyProjectForAOTOnHelix.proj]
Allocation failed [ProxyProjectForAOTOnHelix.proj]
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script. [ProxyProjectForAOTOnHelix.proj]
Stack dump: [ProxyProjectForAOTOnHelix.proj]
0.	Program arguments: C:\\helix\\work\\correlation\\build\\\\wasi-sdk\\\\bin\\clang.exe @C:\\helix\\work\\correlation\\build\\microsoft.netcore.app.runtime.wasi-wasm\\runtimes\\wasi-wasm\\native\\src\\wasi-default.rsp @C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\wasi-compile-bc.rsp -c -o C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\tmpvcc01g.tmp C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\aot-instances.dll.bc [ProxyProjectForAOTOnHelix.proj]
1.	Code generation [ProxyProjectForAOTOnHelix.proj]
Exception Code: 0xC000001D [ProxyProjectForAOTOnHelix.proj]
0x008DFB73 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x7292C902 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x008C23A1 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D3FD3C <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D3FFBC <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D40133 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x0079E5CF <unknown module> [ProxyProjectForAOTOnHelix.proj]
clang: error: clang frontend command failed due to signal (use -v to see invocation) [ProxyProjectForAOTOnHelix.proj]
clang version 16.0.0 [ProxyProjectForAOTOnHelix.proj]
Target: wasm32-unknown-wasi [ProxyProjectForAOTOnHelix.proj]
Thread model: posix [ProxyProjectForAOTOnHelix.proj]
InstalledDir: C:/helix/work/correlation/build//wasi-sdk//bin [ProxyProjectForAOTOnHelix.proj]
clang: note: diagnostic msg: Error generating preprocessed source(s) - no preprocessable inputs. [took 91.69s] [ProxyProjectForAOTOnHelix.proj]

@kg
kg
commented
Dec 5, 2023

Copy link


Copy Markdown

ContributorAuthor
It seems to me that this could also fix #92664 (comment)
@kg could you please elaborate about the alternative solution "Rather than export those functions, could you add them to the table at compile time" mentioned in the emscripten discussion ?
We need the raw exports for the jiterp trace .wasm, right ? I don't understand how that would be possible without export from dotnet.wasm
It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this
@pavelsavara
pavelsavara
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this
So you get back pointer, but in the trace import, you need the index into the export table, no ?
@kg
kg
commented
Dec 5, 2023

Copy link


Copy Markdown

ContributorAuthor
It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this
So you get back pointer, but in the trace import, you need the index into the export table, no ?
The function pointer is an index
@radical
radical
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
Probably unrelated
Log
LLVM ERROR: out of memory
lewing
lewing
approved these changes
Dec 6, 2023
View reviewed changes
@lewinglewing
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be worth capturing the potential alternate work in an issue here but this fixes known issues directly.
@kg
kg
commented
Dec 6, 2023

Copy link


Copy Markdown

ContributorAuthor
Red is #89409, and we have confirmation from a user that this fixes the issue for them, so merging
@kg
kg
merged commit 69d5d3f
into
dotnet:mainDec 6, 2023
@radicalradical
mentioned this pull request
Dec 6, 2023
 Merged

@pavelsavara
pavelsavara
commented
Dec 6, 2023

Copy link


Copy Markdown

Member
are we going to backport it to Net8 ?
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jan 6, 2024
@maraf
maraf
commented
May 13, 2024

Copy link


Copy Markdown

Member
/backport to release/8.0-staging
@github-actionsgithub-actionsBot
unlocked this conversation
May 13, 2024
@github-actions
github-actionsBot
commented
May 13, 2024

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/9063189552
@github-actions
github-actionsBot
commented
May 13, 2024

Copy link


Copy Markdown

Contributor
@maraf backporting to release/8.0-staging failed, the patch most likely resulted in conflicts:
$ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Suppress export name minification
Using index info to reconstruct a base tree...
M	src/mono/wasm/build/WasmApp.Native.targets
M	src/mono/wasm/wasm.proj
Falling back to patching base and 3-way merge...
Auto-merging src/mono/wasm/wasm.proj
Auto-merging src/mono/wasm/build/WasmApp.Native.targets
CONFLICT (content): Merge conflict in src/mono/wasm/build/WasmApp.Native.targets
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Suppress export name minification
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128
Please backport manually!
@github-actions
github-actionsBot
commented
May 13, 2024

Copy link


Copy Markdown

Contributor
@maraf an error occurred while backporting to release/8.0-staging, please check the run log for details!
Error: git am failed, most likely due to a merge conflict.
@github-actionsgithub-actionsBot
locked as resolved and limited conversation to collaborators
May 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes
@pavelsavarapavelsavarapavelsavara approved these changes
@radicalradicalAwaiting requested review from radical

Assignees

@kgkg

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@kg@radical@pavelsavara@maraf@lewing

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[wasm] Suppress export name minification - #95613
Merged
kg merged 1 commit into
dotnet:mainfrom 
kg:suppress-export-renaming
Dec 6, 2023
Merged
[wasm] Suppress export name minification#95613
kg merged 1 commit into
dotnet:mainfrom 
kg:suppress-export-renaming
Conversation
@kg
@kgkg
commented
Dec 4, 2023

Copy link


Copy Markdown

Contributor
@kgkg
added
the 
arch-wasm
WebAssembly architecture
label
Dec 4, 2023
@ghost
ghost
commented
Dec 4, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
Possible fix for #94939.

See emscripten-core/emscripten#20762
Author:kg
Assignees:-
Labels:
arch-wasm
Milestone:-
@ghostghost
added
the 
area-Build-mono

label
Dec 4, 2023
@ghostghost
assigned kgDec 4, 2023
@radical
radical
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 5, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Dec 5, 2023

Open


Closed

@pavelsavara
pavelsavara
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
It seems to me that this could also fix #92664 (comment)
@kg could you please elaborate about the alternative solution "Rather than export those functions, could you add them to the table at compile time" mentioned in the emscripten discussion ?
We need the raw exports for the jiterp trace .wasm, right ? I don't understand how that would be possible without export from dotnet.wasm
@pavelsavara
pavelsavara
commented
Dec 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Probably unrelated
Log
WasiApp.Native.targets(303,5): error : Failed to compile C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.bc -> C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.o [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>C:\Windows\System32\chcp.com 65001 1>nul [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>setlocal [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>set errorlevel=dummy [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>set errorlevel= [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>C:\helix\work\correlation\build\\wasi-sdk\\bin\clang.exe "@C:\helix\work\correlation\build\microsoft.netcore.app.runtime.wasi-wasm\runtimes\wasi-wasm\native\src\wasi-default.rsp" "@C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\wasi-compile-bc.rsp" -c -o "C:\Users\ContainerAdministrator\AppData\Local\Temp\tmpvcc01g.tmp" "C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.bc" [ProxyProjectForAOTOnHelix.proj]
clang version 16.0.0 [ProxyProjectForAOTOnHelix.proj]
Target: wasm32-unknown-wasi [ProxyProjectForAOTOnHelix.proj]
Thread model: posix [ProxyProjectForAOTOnHelix.proj]
InstalledDir: C:/helix/work/correlation/build//wasi-sdk//bin [ProxyProjectForAOTOnHelix.proj]
(in-process) [ProxyProjectForAOTOnHelix.proj]
"C:/helix/work/correlation/build/wasi-sdk/bin/clang.exe" -cc1 -triple wasm32-unknown-wasi -emit-obj -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name aot-instances.dll.bc -mrelocation-model static -mframe-pointer=none -ffp-contract=on -fno-rounding-math -mconstructor-aliases -target-cpu generic -fvisibility=hidden -mllvm -treat-scalable-fixed-error-as-warning -debug-info-kind=constructor -dwarf-version=4 -debugger-tuning=gdb -v -fcoverage-compilation-dir=C:/helix/work/workitem/e/publish -resource-dir C:/helix/work/correlation/build/wasi-sdk/lib/clang/16 -Oz -fdebug-compilation-dir=C:/helix/work/workitem/e/publish -ferror-limit 19 -fgnuc-version=4.2.1 -vectorize-slp -o "C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\tmpvcc01g.tmp" -x ir "C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\aot-instances.dll.bc" [ProxyProjectForAOTOnHelix.proj]
clang -cc1 version 16.0.0 based upon LLVM 16.0.0 default target wasm32-wasi [ProxyProjectForAOTOnHelix.proj]
LLVM ERROR: out of memory [ProxyProjectForAOTOnHelix.proj]
Allocation failed [ProxyProjectForAOTOnHelix.proj]
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script. [ProxyProjectForAOTOnHelix.proj]
Stack dump: [ProxyProjectForAOTOnHelix.proj]
0.	Program arguments: C:\\helix\\work\\correlation\\build\\\\wasi-sdk\\\\bin\\clang.exe @C:\\helix\\work\\correlation\\build\\microsoft.netcore.app.runtime.wasi-wasm\\runtimes\\wasi-wasm\\native\\src\\wasi-default.rsp @C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\wasi-compile-bc.rsp -c -o C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\tmpvcc01g.tmp C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\aot-instances.dll.bc [ProxyProjectForAOTOnHelix.proj]
1.	Code generation [ProxyProjectForAOTOnHelix.proj]
Exception Code: 0xC000001D [ProxyProjectForAOTOnHelix.proj]
0x008DFB73 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x7292C902 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x008C23A1 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D3FD3C <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D3FFBC <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D40133 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x0079E5CF <unknown module> [ProxyProjectForAOTOnHelix.proj]
clang: error: clang frontend command failed due to signal (use -v to see invocation) [ProxyProjectForAOTOnHelix.proj]
clang version 16.0.0 [ProxyProjectForAOTOnHelix.proj]
Target: wasm32-unknown-wasi [ProxyProjectForAOTOnHelix.proj]
Thread model: posix [ProxyProjectForAOTOnHelix.proj]
InstalledDir: C:/helix/work/correlation/build//wasi-sdk//bin [ProxyProjectForAOTOnHelix.proj]
clang: note: diagnostic msg: Error generating preprocessed source(s) - no preprocessable inputs. [took 91.69s] [ProxyProjectForAOTOnHelix.proj]

@kg
kg
commented
Dec 5, 2023

Copy link


Copy Markdown

ContributorAuthor
It seems to me that this could also fix #92664 (comment)
@kg could you please elaborate about the alternative solution "Rather than export those functions, could you add them to the table at compile time" mentioned in the emscripten discussion ?
We need the raw exports for the jiterp trace .wasm, right ? I don't understand how that would be possible without export from dotnet.wasm
It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this
@pavelsavara
pavelsavara
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this
So you get back pointer, but in the trace import, you need the index into the export table, no ?
@kg
kg
commented
Dec 5, 2023

Copy link


Copy Markdown

ContributorAuthor
It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this
So you get back pointer, but in the trace import, you need the index into the export table, no ?
The function pointer is an index
@radical
radical
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
Probably unrelated
Log
LLVM ERROR: out of memory
lewing
lewing
approved these changes
Dec 6, 2023
View reviewed changes
@lewinglewing
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be worth capturing the potential alternate work in an issue here but this fixes known issues directly.
@kg
kg
commented
Dec 6, 2023

Copy link


Copy Markdown

ContributorAuthor
Red is #89409, and we have confirmation from a user that this fixes the issue for them, so merging
@kg
kg
merged commit 69d5d3f
into
dotnet:mainDec 6, 2023
@radicalradical
mentioned this pull request
Dec 6, 2023
 Merged

@pavelsavara
pavelsavara
commented
Dec 6, 2023

Copy link


Copy Markdown

Member
are we going to backport it to Net8 ?
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jan 6, 2024
@maraf
maraf
commented
May 13, 2024

Copy link


Copy Markdown

Member
/backport to release/8.0-staging
@github-actionsgithub-actionsBot
unlocked this conversation
May 13, 2024
@github-actions
github-actionsBot
commented
May 13, 2024

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/9063189552
@github-actions
github-actionsBot
commented
May 13, 2024

Copy link


Copy Markdown

Contributor
@maraf backporting to release/8.0-staging failed, the patch most likely resulted in conflicts:
$ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Suppress export name minification
Using index info to reconstruct a base tree...
M	src/mono/wasm/build/WasmApp.Native.targets
M	src/mono/wasm/wasm.proj
Falling back to patching base and 3-way merge...
Auto-merging src/mono/wasm/wasm.proj
Auto-merging src/mono/wasm/build/WasmApp.Native.targets
CONFLICT (content): Merge conflict in src/mono/wasm/build/WasmApp.Native.targets
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Suppress export name minification
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128
Please backport manually!
@github-actions
github-actionsBot
commented
May 13, 2024

Copy link


Copy Markdown

Contributor
@maraf an error occurred while backporting to release/8.0-staging, please check the run log for details!
Error: git am failed, most likely due to a merge conflict.
@github-actionsgithub-actionsBot
locked as resolved and limited conversation to collaborators
May 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes
@pavelsavarapavelsavarapavelsavara approved these changes
@radicalradicalAwaiting requested review from radical

Assignees

@kgkg

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@kg@radical@pavelsavara@maraf@lewing

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[wasm] Suppress export name minification - #95613
Merged
kg merged 1 commit into
dotnet:mainfrom 
kg:suppress-export-renaming
Dec 6, 2023
Merged
[wasm] Suppress export name minification#95613
kg merged 1 commit into
dotnet:mainfrom 
kg:suppress-export-renaming
Conversation
@kg
@kgkg
commented
Dec 4, 2023

Copy link


Copy Markdown

Contributor
@kgkg
added
the 
arch-wasm
WebAssembly architecture
label
Dec 4, 2023
@ghost
ghost
commented
Dec 4, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
Possible fix for #94939.

See emscripten-core/emscripten#20762
Author:kg
Assignees:-
Labels:
arch-wasm
Milestone:-
@ghostghost
added
the 
area-Build-mono

label
Dec 4, 2023
@ghostghost
assigned kgDec 4, 2023
@radical
radical
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 5, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Dec 5, 2023

Open


Closed

@pavelsavara
pavelsavara
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
It seems to me that this could also fix #92664 (comment)
@kg could you please elaborate about the alternative solution "Rather than export those functions, could you add them to the table at compile time" mentioned in the emscripten discussion ?
We need the raw exports for the jiterp trace .wasm, right ? I don't understand how that would be possible without export from dotnet.wasm
@pavelsavara
pavelsavara
commented
Dec 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Probably unrelated
Log
WasiApp.Native.targets(303,5): error : Failed to compile C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.bc -> C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.o [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>C:\Windows\System32\chcp.com 65001 1>nul [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>setlocal [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>set errorlevel=dummy [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>set errorlevel= [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>C:\helix\work\correlation\build\\wasi-sdk\\bin\clang.exe "@C:\helix\work\correlation\build\microsoft.netcore.app.runtime.wasi-wasm\runtimes\wasi-wasm\native\src\wasi-default.rsp" "@C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\wasi-compile-bc.rsp" -c -o "C:\Users\ContainerAdministrator\AppData\Local\Temp\tmpvcc01g.tmp" "C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.bc" [ProxyProjectForAOTOnHelix.proj]
clang version 16.0.0 [ProxyProjectForAOTOnHelix.proj]
Target: wasm32-unknown-wasi [ProxyProjectForAOTOnHelix.proj]
Thread model: posix [ProxyProjectForAOTOnHelix.proj]
InstalledDir: C:/helix/work/correlation/build//wasi-sdk//bin [ProxyProjectForAOTOnHelix.proj]
(in-process) [ProxyProjectForAOTOnHelix.proj]
"C:/helix/work/correlation/build/wasi-sdk/bin/clang.exe" -cc1 -triple wasm32-unknown-wasi -emit-obj -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name aot-instances.dll.bc -mrelocation-model static -mframe-pointer=none -ffp-contract=on -fno-rounding-math -mconstructor-aliases -target-cpu generic -fvisibility=hidden -mllvm -treat-scalable-fixed-error-as-warning -debug-info-kind=constructor -dwarf-version=4 -debugger-tuning=gdb -v -fcoverage-compilation-dir=C:/helix/work/workitem/e/publish -resource-dir C:/helix/work/correlation/build/wasi-sdk/lib/clang/16 -Oz -fdebug-compilation-dir=C:/helix/work/workitem/e/publish -ferror-limit 19 -fgnuc-version=4.2.1 -vectorize-slp -o "C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\tmpvcc01g.tmp" -x ir "C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\aot-instances.dll.bc" [ProxyProjectForAOTOnHelix.proj]
clang -cc1 version 16.0.0 based upon LLVM 16.0.0 default target wasm32-wasi [ProxyProjectForAOTOnHelix.proj]
LLVM ERROR: out of memory [ProxyProjectForAOTOnHelix.proj]
Allocation failed [ProxyProjectForAOTOnHelix.proj]
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script. [ProxyProjectForAOTOnHelix.proj]
Stack dump: [ProxyProjectForAOTOnHelix.proj]
0.	Program arguments: C:\\helix\\work\\correlation\\build\\\\wasi-sdk\\\\bin\\clang.exe @C:\\helix\\work\\correlation\\build\\microsoft.netcore.app.runtime.wasi-wasm\\runtimes\\wasi-wasm\\native\\src\\wasi-default.rsp @C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\wasi-compile-bc.rsp -c -o C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\tmpvcc01g.tmp C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\aot-instances.dll.bc [ProxyProjectForAOTOnHelix.proj]
1.	Code generation [ProxyProjectForAOTOnHelix.proj]
Exception Code: 0xC000001D [ProxyProjectForAOTOnHelix.proj]
0x008DFB73 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x7292C902 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x008C23A1 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D3FD3C <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D3FFBC <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D40133 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x0079E5CF <unknown module> [ProxyProjectForAOTOnHelix.proj]
clang: error: clang frontend command failed due to signal (use -v to see invocation) [ProxyProjectForAOTOnHelix.proj]
clang version 16.0.0 [ProxyProjectForAOTOnHelix.proj]
Target: wasm32-unknown-wasi [ProxyProjectForAOTOnHelix.proj]
Thread model: posix [ProxyProjectForAOTOnHelix.proj]
InstalledDir: C:/helix/work/correlation/build//wasi-sdk//bin [ProxyProjectForAOTOnHelix.proj]
clang: note: diagnostic msg: Error generating preprocessed source(s) - no preprocessable inputs. [took 91.69s] [ProxyProjectForAOTOnHelix.proj]

@kg
kg
commented
Dec 5, 2023

Copy link


Copy Markdown

ContributorAuthor
It seems to me that this could also fix #92664 (comment)
@kg could you please elaborate about the alternative solution "Rather than export those functions, could you add them to the table at compile time" mentioned in the emscripten discussion ?
We need the raw exports for the jiterp trace .wasm, right ? I don't understand how that would be possible without export from dotnet.wasm
It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this
@pavelsavara
pavelsavara
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this
So you get back pointer, but in the trace import, you need the index into the export table, no ?
@kg
kg
commented
Dec 5, 2023

Copy link


Copy Markdown

ContributorAuthor
It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this
So you get back pointer, but in the trace import, you need the index into the export table, no ?
The function pointer is an index
@radical
radical
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
Probably unrelated
Log
LLVM ERROR: out of memory
lewing
lewing
approved these changes
Dec 6, 2023
View reviewed changes
@lewinglewing
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be worth capturing the potential alternate work in an issue here but this fixes known issues directly.
@kg
kg
commented
Dec 6, 2023

Copy link


Copy Markdown

ContributorAuthor
Red is #89409, and we have confirmation from a user that this fixes the issue for them, so merging
@kg
kg
merged commit 69d5d3f
into
dotnet:mainDec 6, 2023
@radicalradical
mentioned this pull request
Dec 6, 2023
 Merged

@pavelsavara
pavelsavara
commented
Dec 6, 2023

Copy link


Copy Markdown

Member
are we going to backport it to Net8 ?
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jan 6, 2024
@maraf
maraf
commented
May 13, 2024

Copy link


Copy Markdown

Member
/backport to release/8.0-staging
@github-actionsgithub-actionsBot
unlocked this conversation
May 13, 2024
@github-actions
github-actionsBot
commented
May 13, 2024

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/9063189552
@github-actions
github-actionsBot
commented
May 13, 2024

Copy link


Copy Markdown

Contributor
@maraf backporting to release/8.0-staging failed, the patch most likely resulted in conflicts:
$ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Suppress export name minification
Using index info to reconstruct a base tree...
M	src/mono/wasm/build/WasmApp.Native.targets
M	src/mono/wasm/wasm.proj
Falling back to patching base and 3-way merge...
Auto-merging src/mono/wasm/wasm.proj
Auto-merging src/mono/wasm/build/WasmApp.Native.targets
CONFLICT (content): Merge conflict in src/mono/wasm/build/WasmApp.Native.targets
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Suppress export name minification
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128
Please backport manually!
@github-actions
github-actionsBot
commented
May 13, 2024

Copy link


Copy Markdown

Contributor
@maraf an error occurred while backporting to release/8.0-staging, please check the run log for details!
Error: git am failed, most likely due to a merge conflict.
@github-actionsgithub-actionsBot
locked as resolved and limited conversation to collaborators
May 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes
@pavelsavarapavelsavarapavelsavara approved these changes
@radicalradicalAwaiting requested review from radical

Assignees

@kgkg

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@kg@radical@pavelsavara@maraf@lewing

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[wasm] Suppress export name minification - #95613
Merged
kg merged 1 commit into
dotnet:mainfrom 
kg:suppress-export-renaming
Dec 6, 2023
Merged
[wasm] Suppress export name minification#95613
kg merged 1 commit into
dotnet:mainfrom 
kg:suppress-export-renaming
Conversation
@kg
@kgkg
commented
Dec 4, 2023

Copy link


Copy Markdown

Contributor
@kgkg
added
the 
arch-wasm
WebAssembly architecture
label
Dec 4, 2023
@ghost
ghost
commented
Dec 4, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
Possible fix for #94939.

See emscripten-core/emscripten#20762
Author:kg
Assignees:-
Labels:
arch-wasm
Milestone:-
@ghostghost
added
the 
area-Build-mono

label
Dec 4, 2023
@ghostghost
assigned kgDec 4, 2023
@radical
radical
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 5, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Dec 5, 2023

Open


Closed

@pavelsavara
pavelsavara
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
It seems to me that this could also fix #92664 (comment)
@kg could you please elaborate about the alternative solution "Rather than export those functions, could you add them to the table at compile time" mentioned in the emscripten discussion ?
We need the raw exports for the jiterp trace .wasm, right ? I don't understand how that would be possible without export from dotnet.wasm
@pavelsavara
pavelsavara
commented
Dec 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Probably unrelated
Log
WasiApp.Native.targets(303,5): error : Failed to compile C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.bc -> C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.o [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>C:\Windows\System32\chcp.com 65001 1>nul [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>setlocal [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>set errorlevel=dummy [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>set errorlevel= [ProxyProjectForAOTOnHelix.proj]
C:\helix\work\workitem\e\publish>C:\helix\work\correlation\build\\wasi-sdk\\bin\clang.exe "@C:\helix\work\correlation\build\microsoft.netcore.app.runtime.wasi-wasm\runtimes\wasi-wasm\native\src\wasi-default.rsp" "@C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\wasi-compile-bc.rsp" -c -o "C:\Users\ContainerAdministrator\AppData\Local\Temp\tmpvcc01g.tmp" "C:\helix\work\workitem\e\wasm_build\obj\wasm\for-build\aot-instances.dll.bc" [ProxyProjectForAOTOnHelix.proj]
clang version 16.0.0 [ProxyProjectForAOTOnHelix.proj]
Target: wasm32-unknown-wasi [ProxyProjectForAOTOnHelix.proj]
Thread model: posix [ProxyProjectForAOTOnHelix.proj]
InstalledDir: C:/helix/work/correlation/build//wasi-sdk//bin [ProxyProjectForAOTOnHelix.proj]
(in-process) [ProxyProjectForAOTOnHelix.proj]
"C:/helix/work/correlation/build/wasi-sdk/bin/clang.exe" -cc1 -triple wasm32-unknown-wasi -emit-obj -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name aot-instances.dll.bc -mrelocation-model static -mframe-pointer=none -ffp-contract=on -fno-rounding-math -mconstructor-aliases -target-cpu generic -fvisibility=hidden -mllvm -treat-scalable-fixed-error-as-warning -debug-info-kind=constructor -dwarf-version=4 -debugger-tuning=gdb -v -fcoverage-compilation-dir=C:/helix/work/workitem/e/publish -resource-dir C:/helix/work/correlation/build/wasi-sdk/lib/clang/16 -Oz -fdebug-compilation-dir=C:/helix/work/workitem/e/publish -ferror-limit 19 -fgnuc-version=4.2.1 -vectorize-slp -o "C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\tmpvcc01g.tmp" -x ir "C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\aot-instances.dll.bc" [ProxyProjectForAOTOnHelix.proj]
clang -cc1 version 16.0.0 based upon LLVM 16.0.0 default target wasm32-wasi [ProxyProjectForAOTOnHelix.proj]
LLVM ERROR: out of memory [ProxyProjectForAOTOnHelix.proj]
Allocation failed [ProxyProjectForAOTOnHelix.proj]
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script. [ProxyProjectForAOTOnHelix.proj]
Stack dump: [ProxyProjectForAOTOnHelix.proj]
0.	Program arguments: C:\\helix\\work\\correlation\\build\\\\wasi-sdk\\\\bin\\clang.exe @C:\\helix\\work\\correlation\\build\\microsoft.netcore.app.runtime.wasi-wasm\\runtimes\\wasi-wasm\\native\\src\\wasi-default.rsp @C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\wasi-compile-bc.rsp -c -o C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\tmpvcc01g.tmp C:\\helix\\work\\workitem\\e\\wasm_build\\obj\\wasm\\for-build\\aot-instances.dll.bc [ProxyProjectForAOTOnHelix.proj]
1.	Code generation [ProxyProjectForAOTOnHelix.proj]
Exception Code: 0xC000001D [ProxyProjectForAOTOnHelix.proj]
0x008DFB73 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x7292C902 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x008C23A1 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D3FD3C <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D3FFBC <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x00D40133 <unknown module> [ProxyProjectForAOTOnHelix.proj]
0x0079E5CF <unknown module> [ProxyProjectForAOTOnHelix.proj]
clang: error: clang frontend command failed due to signal (use -v to see invocation) [ProxyProjectForAOTOnHelix.proj]
clang version 16.0.0 [ProxyProjectForAOTOnHelix.proj]
Target: wasm32-unknown-wasi [ProxyProjectForAOTOnHelix.proj]
Thread model: posix [ProxyProjectForAOTOnHelix.proj]
InstalledDir: C:/helix/work/correlation/build//wasi-sdk//bin [ProxyProjectForAOTOnHelix.proj]
clang: note: diagnostic msg: Error generating preprocessed source(s) - no preprocessable inputs. [took 91.69s] [ProxyProjectForAOTOnHelix.proj]

@kg
kg
commented
Dec 5, 2023

Copy link


Copy Markdown

ContributorAuthor
It seems to me that this could also fix #92664 (comment)
@kg could you please elaborate about the alternative solution "Rather than export those functions, could you add them to the table at compile time" mentioned in the emscripten discussion ?
We need the raw exports for the jiterp trace .wasm, right ? I don't understand how that would be possible without export from dotnet.wasm
It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this
@pavelsavara
pavelsavara
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this
So you get back pointer, but in the trace import, you need the index into the export table, no ?
@kg
kg
commented
Dec 5, 2023

Copy link


Copy Markdown

ContributorAuthor
It would be a single exported function that contains a massive switch statement that returns references to all of the exports, so they end up having pre-reserved slots in the function pointer table. It's kind of a pain to build this
So you get back pointer, but in the trace import, you need the index into the export table, no ?
The function pointer is an index
@radical
radical
commented
Dec 5, 2023

Copy link


Copy Markdown

Member
Probably unrelated
Log
LLVM ERROR: out of memory
lewing
lewing
approved these changes
Dec 6, 2023
View reviewed changes
@lewinglewing
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be worth capturing the potential alternate work in an issue here but this fixes known issues directly.
@kg
kg
commented
Dec 6, 2023

Copy link


Copy Markdown

ContributorAuthor
Red is #89409, and we have confirmation from a user that this fixes the issue for them, so merging
@kg
kg
merged commit 69d5d3f
into
dotnet:mainDec 6, 2023
@radicalradical
mentioned this pull request
Dec 6, 2023
 Merged

@pavelsavara
pavelsavara
commented
Dec 6, 2023

Copy link


Copy Markdown

Member
are we going to backport it to Net8 ?
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jan 6, 2024
@maraf
maraf
commented
May 13, 2024

Copy link


Copy Markdown

Member
/backport to release/8.0-staging
@github-actionsgithub-actionsBot
unlocked this conversation
May 13, 2024
@github-actions
github-actionsBot
commented
May 13, 2024

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/9063189552
@github-actions
github-actionsBot
commented
May 13, 2024

Copy link


Copy Markdown

Contributor
@maraf backporting to release/8.0-staging failed, the patch most likely resulted in conflicts:
$ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Suppress export name minification
Using index info to reconstruct a base tree...
M	src/mono/wasm/build/WasmApp.Native.targets
M	src/mono/wasm/wasm.proj
Falling back to patching base and 3-way merge...
Auto-merging src/mono/wasm/wasm.proj
Auto-merging src/mono/wasm/build/WasmApp.Native.targets
CONFLICT (content): Merge conflict in src/mono/wasm/build/WasmApp.Native.targets
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Suppress export name minification
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128
Please backport manually!
@github-actions
github-actionsBot
commented
May 13, 2024

Copy link


Copy Markdown

Contributor
@maraf an error occurred while backporting to release/8.0-staging, please check the run log for details!
Error: git am failed, most likely due to a merge conflict.
@github-actionsgithub-actionsBot
locked as resolved and limited conversation to collaborators
May 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes
@pavelsavarapavelsavarapavelsavara approved these changes
@radicalradicalAwaiting requested review from radical

Assignees

@kgkg

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@kg@radical@pavelsavara@maraf@lewing