[browser] introduce JSProxyContext - #95959

Merged
pavelsavara merged 26 commits into
dotnet:mainfrom
pavelsavara:browser_proxy_context
Dec 20, 2023
Merged

[browser] introduce JSProxyContext#95959
pavelsavara merged 26 commits into
dotnet:mainfrom
pavelsavara:browser_proxy_context

Conversation

@pavelsavara

@pavelsavarapavelsavara commented Dec 13, 2023•
edited
Loading

Copy link
Copy Markdown
Member
  • introduce JSProxyContext which collects all proxies and handles relevant to particular WebWorker/UI thread
  • introduce thread local JSProxyContext.OperationStack to know the context of the current operation.
    • most of the time, this matches the current thread
    • sometimes, we pass JSObject instance to JSImport. Such instance already has thread affinity
    • we will use JSProxyContext.CaptureContextFromParameter to capture the target thread to call into.
    • The dispatch to it is next PR.
  • move all handle related code into JSProxyContext
  • use target JSProxyContext instance as a lock around operations with handles.
  • introduced JSObject.ProxyContext also for non-MT build. It simplifies the #if FEATURE_WASM_THREADS hell.
  • make CancelablePromise more async
  • drop IsThreadCaptured it was bit misleading
  • new mono_wasm_invoke_method_raw which doesn't require existing JSProxyContext, for early calls.
  • new push_operation, pop_operation to be called before JSExport calls
  • renamed install_synchronization_context -> install_main_synchronization_context

@pavelsavarapavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Dec 13, 2023
@pavelsavarapavelsavara added this to the 9.0.0 milestone Dec 13, 2023
@pavelsavarapavelsavara self-assigned this Dec 13, 2023
@ghost

ghost commented Dec 13, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • introduce JSProxyContext which collects all proxies and handles relevant to particular WebWorker/UI thread
  • introduce thread local JSProxyContext.CapturedInstance to know the context of the current operation.
    • most of the time, this matches the current thread
    • sometimes, we pass JSObject instance to JSImport. Such instance already has thread affinity and we will use it to capture the target thread to call into.
  • move all handle related code into JSProxyContext
  • use target JSProxyContext instance as a lock around operations with handles.
  • introduced JSObject.ProxyContext also for non-MT build. It simplifies the #if FEATURE_WASM_THREADS hell.
  • make CancelablePromise more async
  • drop IsThreadCaptured it was bit misleading
  • new mono_wasm_invoke_method_raw which doesn't require existing JSProxyContext, for early calls.
  • new capture_proxy_context to be called before JSExport call
  • renamed install_synchronization_context -> install_main_synchronization_context
Author:pavelsavara
Assignees:pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser

Milestone:9.0.0

@pavelsavarapavelsavara mentioned this pull request Dec 13, 2023
Merged
@pavelsavara

pavelsavara commented Dec 13, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Dec 13, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
pavelsavara marked this pull request as ready for review December 13, 2023 16:43
kg
kg reviewed Dec 13, 2023
View reviewed changes
Comment thread...ries/System.Runtime.InteropServices.JavaScript/System.Runtime.InteropServices.JavaScript.sln Outdated
kg
kg reviewed Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs Outdated
kg
kg reviewed Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs Outdated
kg
kg reviewed Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs Outdated
kg
kg reviewed Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs Outdated
kg
kg reviewed Dec 13, 2023
View reviewed changes
Comment thread...nteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSFunctionBinding.cs Outdated
kg
kg reviewed Dec 13, 2023
View reviewed changes
Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSMarshalerArgument.cs Outdated
kg
kg reviewed Dec 13, 2023
View reviewed changes
Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSObject.References.cs Outdated
@pavelsavara

pavelsavara commented Dec 17, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Dec 17, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

maraf
maraf approved these changes Dec 18, 2023
View reviewed changes
Comment thread...m.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSHost.cs Outdated
Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSMarshalerArgument.cs Outdated
Comment thread...e.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSProxyContext.cs Outdated
@pavelsavara
remove complexity of PendingOperation maintanance
f56baa1
 - new JSMarshalerArgumentImpl.ContextHandle field
- all calls from JS side will set JSMarshalerArgumentImpl.ContextHandle with current thread context
- via set_arg_proxy_context
- all calls to JS where runtime calls stackalloc JSMarshalerArgument will set JSMarshalerArgumentImpl.ContextHandle with Context of promise or function affinity
- it will use InitializeWithContext, JSImportNoCapture
- these are Task and Function callbacks to JS
- JSMarshalerArgument.ToManaged always uses new JSMarshalerArgument.ToManagedContext
- JSMarshalerArgument.ToManagedContext always uses JSMarshalerArgumentImpl.ContextHandle, no magic
- JSMarshalerArgument.ToJS always uses new JSMarshalerArgument.ToJSContext
- JSMarshalerArgument.ToJSContext during JSImport uses JSProxyContext.CurrentOperationContext otherwise JSMarshalerArgumentImpl.ContextHandle
@pavelsavara

pavelsavara commented Dec 18, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Dec 18, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara

pavelsavara commented Dec 18, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Dec 18, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

kg
kg reviewed Dec 18, 2023
View reviewed changes
Comment thread...pt/src/System/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Exception.cs Outdated
kg
kg reviewed Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/managed-exports.ts
kg
kg reviewed Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/marshal.ts
kg
kg reviewed Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/marshal.ts Outdated
kg
kg approved these changes Dec 18, 2023
View reviewed changes
@pavelsavara
feedback
9b8e3ad
cancellation thread safe
Active issue dotnet#96173
@pavelsavara

pavelsavara commented Dec 19, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Dec 19, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara

pavelsavara commented Dec 19, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Filed new issues
#96173
#96190
#96191

@pavelsavara

pavelsavara commented Dec 19, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Dec 19, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
pavelsavara merged commit 8bd23f0 into dotnet:mainDec 20, 2023
@pavelsavara
pavelsavara deleted the browser_proxy_context branch December 20, 2023 07:57
This was referenced Jan 3, 2024
Closed
Open
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jan 19, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marafmarafmaraf approved these changes
@lambdageeklambdageekAwaiting requested review from lambdageek
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar
+1 more reviewer
@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptos-browserBrowser variant of arch-wasm

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelsavara@kg@maraf
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[browser] introduce JSProxyContext - #95959
Merged
pavelsavara merged 26 commits into
dotnet:mainfrom 
pavelsavara:browser_proxy_context
Dec 20, 2023
Merged
[browser] introduce JSProxyContext#95959
pavelsavara merged 26 commits into
dotnet:mainfrom 
pavelsavara:browser_proxy_context
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Dec 13, 2023•

edited

Loading

Copy link


Copy Markdown

Member
  • introduce JSProxyContext which collects all proxies and handles relevant to particular WebWorker/UI thread
  • introduce thread local JSProxyContext.OperationStack to know the context of the current operation.

    • most of the time, this matches the current thread
    • sometimes, we pass JSObject instance to JSImport. Such instance already has thread affinity
    • we will use JSProxyContext.CaptureContextFromParameter to capture the target thread to call into.
    • The dispatch to it is next PR.
  • move all handle related code into JSProxyContext
  • use target JSProxyContext instance as a lock around operations with handles.
  • introduced JSObject.ProxyContext also for non-MT build. It simplifies the #if FEATURE_WASM_THREADS hell.
  • make CancelablePromise more async
  • drop IsThreadCaptured it was bit misleading
  • new mono_wasm_invoke_method_raw which doesn't require existing JSProxyContext, for early calls.
  • new push_operation, pop_operation to be called before JSExport calls
  • renamed install_synchronization_context -> install_main_synchronization_context
@pavelsavarapavelsavara
added

arch-wasm
WebAssembly architecture
area-System.Runtime.InteropServices.JavaScript

os-browser
Browser variant of arch-wasm
labels
Dec 13, 2023
@pavelsavarapavelsavara
added this to the 9.0.0 milestone
Dec 13, 2023
@pavelsavarapavelsavara
self-assigned this
Dec 13, 2023
@ghost
ghost
commented
Dec 13, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • introduce JSProxyContext which collects all proxies and handles relevant to particular WebWorker/UI thread
  • introduce thread local JSProxyContext.CapturedInstance to know the context of the current operation.

    • most of the time, this matches the current thread
    • sometimes, we pass JSObject instance to JSImport. Such instance already has thread affinity and we will use it to capture the target thread to call into.
  • move all handle related code into JSProxyContext
  • use target JSProxyContext instance as a lock around operations with handles.
  • introduced JSObject.ProxyContext also for non-MT build. It simplifies the #if FEATURE_WASM_THREADS hell.
  • make CancelablePromise more async
  • drop IsThreadCaptured it was bit misleading
  • new mono_wasm_invoke_method_raw which doesn't require existing JSProxyContext, for early calls.
  • new capture_proxy_context to be called before JSExport call
  • renamed install_synchronization_context -> install_main_synchronization_context
Author:pavelsavara
Assignees:pavelsavara
Labels:
arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone:9.0.0
@pavelsavarapavelsavara
mentioned this pull request
Dec 13, 2023
 Merged

@pavelsavara
pavelsavara
commented
Dec 13, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 13, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
marked this pull request as ready for review
December 13, 2023 16:43
kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...ries/System.Runtime.InteropServices.JavaScript/System.Runtime.InteropServices.JavaScript.sln
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...nteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSFunctionBinding.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSMarshalerArgument.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSObject.References.cs
Outdated

@pavelsavara
pavelsavara
commented
Dec 17, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 17, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
maraf
maraf
approved these changes
Dec 18, 2023
View reviewed changes
Comment thread...m.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSHost.cs
Outdated

Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSMarshalerArgument.cs
Outdated

Comment thread...e.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSProxyContext.cs
Outdated

@pavelsavara
remove complexity of PendingOperation maintanance
f56baa1
 - new JSMarshalerArgumentImpl.ContextHandle field
- all calls from JS side will set JSMarshalerArgumentImpl.ContextHandle with current thread context
- via set_arg_proxy_context
- all calls to JS where runtime calls stackalloc JSMarshalerArgument will set JSMarshalerArgumentImpl.ContextHandle with Context of promise or function affinity
- it will use InitializeWithContext, JSImportNoCapture
- these are Task and Function callbacks to JS
- JSMarshalerArgument.ToManaged always uses new JSMarshalerArgument.ToManagedContext
- JSMarshalerArgument.ToManagedContext always uses JSMarshalerArgumentImpl.ContextHandle, no magic
- JSMarshalerArgument.ToJS always uses new JSMarshalerArgument.ToJSContext
- JSMarshalerArgument.ToJSContext during JSImport uses JSProxyContext.CurrentOperationContext otherwise JSMarshalerArgumentImpl.ContextHandle
@pavelsavara
pavelsavara
commented
Dec 18, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 18, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
commented
Dec 18, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 18, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment thread...pt/src/System/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Exception.cs
Outdated

kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/managed-exports.ts
kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/marshal.ts
kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/marshal.ts
Outdated

kg
kg
approved these changes
Dec 18, 2023
View reviewed changes
@pavelsavara
feedback
9b8e3ad
cancellation thread safe
Active issue dotnet#96173
@pavelsavara
pavelsavara
commented
Dec 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 19, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
commented
Dec 19, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Filed new issues
#96173
#96190
#96191
@pavelsavara
pavelsavara
commented
Dec 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 19, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
merged commit 8bd23f0
into
dotnet:mainDec 20, 2023
@pavelsavara
pavelsavara
deleted the

browser_proxy_context

branch
December 20, 2023 07:57

This was referenced Jan 3, 2024

Closed


Open

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jan 19, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marafmarafmaraf approved these changes
@lambdageeklambdageekAwaiting requested review from lambdageek
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptos-browserBrowser variant of arch-wasm

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelsavara@kg@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[browser] introduce JSProxyContext - #95959
Merged
pavelsavara merged 26 commits into
dotnet:mainfrom 
pavelsavara:browser_proxy_context
Dec 20, 2023
Merged
[browser] introduce JSProxyContext#95959
pavelsavara merged 26 commits into
dotnet:mainfrom 
pavelsavara:browser_proxy_context
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Dec 13, 2023•

edited

Loading

Copy link


Copy Markdown

Member
  • introduce JSProxyContext which collects all proxies and handles relevant to particular WebWorker/UI thread
  • introduce thread local JSProxyContext.OperationStack to know the context of the current operation.

    • most of the time, this matches the current thread
    • sometimes, we pass JSObject instance to JSImport. Such instance already has thread affinity
    • we will use JSProxyContext.CaptureContextFromParameter to capture the target thread to call into.
    • The dispatch to it is next PR.
  • move all handle related code into JSProxyContext
  • use target JSProxyContext instance as a lock around operations with handles.
  • introduced JSObject.ProxyContext also for non-MT build. It simplifies the #if FEATURE_WASM_THREADS hell.
  • make CancelablePromise more async
  • drop IsThreadCaptured it was bit misleading
  • new mono_wasm_invoke_method_raw which doesn't require existing JSProxyContext, for early calls.
  • new push_operation, pop_operation to be called before JSExport calls
  • renamed install_synchronization_context -> install_main_synchronization_context
@pavelsavarapavelsavara
added

arch-wasm
WebAssembly architecture
area-System.Runtime.InteropServices.JavaScript

os-browser
Browser variant of arch-wasm
labels
Dec 13, 2023
@pavelsavarapavelsavara
added this to the 9.0.0 milestone
Dec 13, 2023
@pavelsavarapavelsavara
self-assigned this
Dec 13, 2023
@ghost
ghost
commented
Dec 13, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • introduce JSProxyContext which collects all proxies and handles relevant to particular WebWorker/UI thread
  • introduce thread local JSProxyContext.CapturedInstance to know the context of the current operation.

    • most of the time, this matches the current thread
    • sometimes, we pass JSObject instance to JSImport. Such instance already has thread affinity and we will use it to capture the target thread to call into.
  • move all handle related code into JSProxyContext
  • use target JSProxyContext instance as a lock around operations with handles.
  • introduced JSObject.ProxyContext also for non-MT build. It simplifies the #if FEATURE_WASM_THREADS hell.
  • make CancelablePromise more async
  • drop IsThreadCaptured it was bit misleading
  • new mono_wasm_invoke_method_raw which doesn't require existing JSProxyContext, for early calls.
  • new capture_proxy_context to be called before JSExport call
  • renamed install_synchronization_context -> install_main_synchronization_context
Author:pavelsavara
Assignees:pavelsavara
Labels:
arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone:9.0.0
@pavelsavarapavelsavara
mentioned this pull request
Dec 13, 2023
 Merged

@pavelsavara
pavelsavara
commented
Dec 13, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 13, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
marked this pull request as ready for review
December 13, 2023 16:43
kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...ries/System.Runtime.InteropServices.JavaScript/System.Runtime.InteropServices.JavaScript.sln
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...nteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSFunctionBinding.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSMarshalerArgument.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSObject.References.cs
Outdated

@pavelsavara
pavelsavara
commented
Dec 17, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 17, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
maraf
maraf
approved these changes
Dec 18, 2023
View reviewed changes
Comment thread...m.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSHost.cs
Outdated

Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSMarshalerArgument.cs
Outdated

Comment thread...e.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSProxyContext.cs
Outdated

@pavelsavara
remove complexity of PendingOperation maintanance
f56baa1
 - new JSMarshalerArgumentImpl.ContextHandle field
- all calls from JS side will set JSMarshalerArgumentImpl.ContextHandle with current thread context
- via set_arg_proxy_context
- all calls to JS where runtime calls stackalloc JSMarshalerArgument will set JSMarshalerArgumentImpl.ContextHandle with Context of promise or function affinity
- it will use InitializeWithContext, JSImportNoCapture
- these are Task and Function callbacks to JS
- JSMarshalerArgument.ToManaged always uses new JSMarshalerArgument.ToManagedContext
- JSMarshalerArgument.ToManagedContext always uses JSMarshalerArgumentImpl.ContextHandle, no magic
- JSMarshalerArgument.ToJS always uses new JSMarshalerArgument.ToJSContext
- JSMarshalerArgument.ToJSContext during JSImport uses JSProxyContext.CurrentOperationContext otherwise JSMarshalerArgumentImpl.ContextHandle
@pavelsavara
pavelsavara
commented
Dec 18, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 18, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
commented
Dec 18, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 18, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment thread...pt/src/System/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Exception.cs
Outdated

kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/managed-exports.ts
kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/marshal.ts
kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/marshal.ts
Outdated

kg
kg
approved these changes
Dec 18, 2023
View reviewed changes
@pavelsavara
feedback
9b8e3ad
cancellation thread safe
Active issue dotnet#96173
@pavelsavara
pavelsavara
commented
Dec 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 19, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
commented
Dec 19, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Filed new issues
#96173
#96190
#96191
@pavelsavara
pavelsavara
commented
Dec 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 19, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
merged commit 8bd23f0
into
dotnet:mainDec 20, 2023
@pavelsavara
pavelsavara
deleted the

browser_proxy_context

branch
December 20, 2023 07:57

This was referenced Jan 3, 2024

Closed


Open

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jan 19, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marafmarafmaraf approved these changes
@lambdageeklambdageekAwaiting requested review from lambdageek
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptos-browserBrowser variant of arch-wasm

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelsavara@kg@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[browser] introduce JSProxyContext - #95959
Merged
pavelsavara merged 26 commits into
dotnet:mainfrom 
pavelsavara:browser_proxy_context
Dec 20, 2023
Merged
[browser] introduce JSProxyContext#95959
pavelsavara merged 26 commits into
dotnet:mainfrom 
pavelsavara:browser_proxy_context
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Dec 13, 2023•

edited

Loading

Copy link


Copy Markdown

Member
  • introduce JSProxyContext which collects all proxies and handles relevant to particular WebWorker/UI thread
  • introduce thread local JSProxyContext.OperationStack to know the context of the current operation.

    • most of the time, this matches the current thread
    • sometimes, we pass JSObject instance to JSImport. Such instance already has thread affinity
    • we will use JSProxyContext.CaptureContextFromParameter to capture the target thread to call into.
    • The dispatch to it is next PR.
  • move all handle related code into JSProxyContext
  • use target JSProxyContext instance as a lock around operations with handles.
  • introduced JSObject.ProxyContext also for non-MT build. It simplifies the #if FEATURE_WASM_THREADS hell.
  • make CancelablePromise more async
  • drop IsThreadCaptured it was bit misleading
  • new mono_wasm_invoke_method_raw which doesn't require existing JSProxyContext, for early calls.
  • new push_operation, pop_operation to be called before JSExport calls
  • renamed install_synchronization_context -> install_main_synchronization_context
@pavelsavarapavelsavara
added

arch-wasm
WebAssembly architecture
area-System.Runtime.InteropServices.JavaScript

os-browser
Browser variant of arch-wasm
labels
Dec 13, 2023
@pavelsavarapavelsavara
added this to the 9.0.0 milestone
Dec 13, 2023
@pavelsavarapavelsavara
self-assigned this
Dec 13, 2023
@ghost
ghost
commented
Dec 13, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • introduce JSProxyContext which collects all proxies and handles relevant to particular WebWorker/UI thread
  • introduce thread local JSProxyContext.CapturedInstance to know the context of the current operation.

    • most of the time, this matches the current thread
    • sometimes, we pass JSObject instance to JSImport. Such instance already has thread affinity and we will use it to capture the target thread to call into.
  • move all handle related code into JSProxyContext
  • use target JSProxyContext instance as a lock around operations with handles.
  • introduced JSObject.ProxyContext also for non-MT build. It simplifies the #if FEATURE_WASM_THREADS hell.
  • make CancelablePromise more async
  • drop IsThreadCaptured it was bit misleading
  • new mono_wasm_invoke_method_raw which doesn't require existing JSProxyContext, for early calls.
  • new capture_proxy_context to be called before JSExport call
  • renamed install_synchronization_context -> install_main_synchronization_context
Author:pavelsavara
Assignees:pavelsavara
Labels:
arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone:9.0.0
@pavelsavarapavelsavara
mentioned this pull request
Dec 13, 2023
 Merged

@pavelsavara
pavelsavara
commented
Dec 13, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 13, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
marked this pull request as ready for review
December 13, 2023 16:43
kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...ries/System.Runtime.InteropServices.JavaScript/System.Runtime.InteropServices.JavaScript.sln
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...nteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSFunctionBinding.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSMarshalerArgument.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSObject.References.cs
Outdated

@pavelsavara
pavelsavara
commented
Dec 17, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 17, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
maraf
maraf
approved these changes
Dec 18, 2023
View reviewed changes
Comment thread...m.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSHost.cs
Outdated

Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSMarshalerArgument.cs
Outdated

Comment thread...e.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSProxyContext.cs
Outdated

@pavelsavara
remove complexity of PendingOperation maintanance
f56baa1
 - new JSMarshalerArgumentImpl.ContextHandle field
- all calls from JS side will set JSMarshalerArgumentImpl.ContextHandle with current thread context
- via set_arg_proxy_context
- all calls to JS where runtime calls stackalloc JSMarshalerArgument will set JSMarshalerArgumentImpl.ContextHandle with Context of promise or function affinity
- it will use InitializeWithContext, JSImportNoCapture
- these are Task and Function callbacks to JS
- JSMarshalerArgument.ToManaged always uses new JSMarshalerArgument.ToManagedContext
- JSMarshalerArgument.ToManagedContext always uses JSMarshalerArgumentImpl.ContextHandle, no magic
- JSMarshalerArgument.ToJS always uses new JSMarshalerArgument.ToJSContext
- JSMarshalerArgument.ToJSContext during JSImport uses JSProxyContext.CurrentOperationContext otherwise JSMarshalerArgumentImpl.ContextHandle
@pavelsavara
pavelsavara
commented
Dec 18, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 18, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
commented
Dec 18, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 18, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment thread...pt/src/System/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Exception.cs
Outdated

kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/managed-exports.ts
kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/marshal.ts
kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/marshal.ts
Outdated

kg
kg
approved these changes
Dec 18, 2023
View reviewed changes
@pavelsavara
feedback
9b8e3ad
cancellation thread safe
Active issue dotnet#96173
@pavelsavara
pavelsavara
commented
Dec 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 19, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
commented
Dec 19, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Filed new issues
#96173
#96190
#96191
@pavelsavara
pavelsavara
commented
Dec 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 19, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
merged commit 8bd23f0
into
dotnet:mainDec 20, 2023
@pavelsavara
pavelsavara
deleted the

browser_proxy_context

branch
December 20, 2023 07:57

This was referenced Jan 3, 2024

Closed


Open

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jan 19, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marafmarafmaraf approved these changes
@lambdageeklambdageekAwaiting requested review from lambdageek
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptos-browserBrowser variant of arch-wasm

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelsavara@kg@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[browser] introduce JSProxyContext - #95959
Merged
pavelsavara merged 26 commits into
dotnet:mainfrom 
pavelsavara:browser_proxy_context
Dec 20, 2023
Merged
[browser] introduce JSProxyContext#95959
pavelsavara merged 26 commits into
dotnet:mainfrom 
pavelsavara:browser_proxy_context
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Dec 13, 2023•

edited

Loading

Copy link


Copy Markdown

Member
  • introduce JSProxyContext which collects all proxies and handles relevant to particular WebWorker/UI thread
  • introduce thread local JSProxyContext.OperationStack to know the context of the current operation.

    • most of the time, this matches the current thread
    • sometimes, we pass JSObject instance to JSImport. Such instance already has thread affinity
    • we will use JSProxyContext.CaptureContextFromParameter to capture the target thread to call into.
    • The dispatch to it is next PR.
  • move all handle related code into JSProxyContext
  • use target JSProxyContext instance as a lock around operations with handles.
  • introduced JSObject.ProxyContext also for non-MT build. It simplifies the #if FEATURE_WASM_THREADS hell.
  • make CancelablePromise more async
  • drop IsThreadCaptured it was bit misleading
  • new mono_wasm_invoke_method_raw which doesn't require existing JSProxyContext, for early calls.
  • new push_operation, pop_operation to be called before JSExport calls
  • renamed install_synchronization_context -> install_main_synchronization_context
@pavelsavarapavelsavara
added

arch-wasm
WebAssembly architecture
area-System.Runtime.InteropServices.JavaScript

os-browser
Browser variant of arch-wasm
labels
Dec 13, 2023
@pavelsavarapavelsavara
added this to the 9.0.0 milestone
Dec 13, 2023
@pavelsavarapavelsavara
self-assigned this
Dec 13, 2023
@ghost
ghost
commented
Dec 13, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • introduce JSProxyContext which collects all proxies and handles relevant to particular WebWorker/UI thread
  • introduce thread local JSProxyContext.CapturedInstance to know the context of the current operation.

    • most of the time, this matches the current thread
    • sometimes, we pass JSObject instance to JSImport. Such instance already has thread affinity and we will use it to capture the target thread to call into.
  • move all handle related code into JSProxyContext
  • use target JSProxyContext instance as a lock around operations with handles.
  • introduced JSObject.ProxyContext also for non-MT build. It simplifies the #if FEATURE_WASM_THREADS hell.
  • make CancelablePromise more async
  • drop IsThreadCaptured it was bit misleading
  • new mono_wasm_invoke_method_raw which doesn't require existing JSProxyContext, for early calls.
  • new capture_proxy_context to be called before JSExport call
  • renamed install_synchronization_context -> install_main_synchronization_context
Author:pavelsavara
Assignees:pavelsavara
Labels:
arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone:9.0.0
@pavelsavarapavelsavara
mentioned this pull request
Dec 13, 2023
 Merged

@pavelsavara
pavelsavara
commented
Dec 13, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 13, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
marked this pull request as ready for review
December 13, 2023 16:43
kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...ries/System.Runtime.InteropServices.JavaScript/System.Runtime.InteropServices.JavaScript.sln
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...nteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSFunctionBinding.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSMarshalerArgument.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSObject.References.cs
Outdated

@pavelsavara
pavelsavara
commented
Dec 17, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 17, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
maraf
maraf
approved these changes
Dec 18, 2023
View reviewed changes
Comment thread...m.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSHost.cs
Outdated

Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSMarshalerArgument.cs
Outdated

Comment thread...e.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSProxyContext.cs
Outdated

@pavelsavara
remove complexity of PendingOperation maintanance
f56baa1
 - new JSMarshalerArgumentImpl.ContextHandle field
- all calls from JS side will set JSMarshalerArgumentImpl.ContextHandle with current thread context
- via set_arg_proxy_context
- all calls to JS where runtime calls stackalloc JSMarshalerArgument will set JSMarshalerArgumentImpl.ContextHandle with Context of promise or function affinity
- it will use InitializeWithContext, JSImportNoCapture
- these are Task and Function callbacks to JS
- JSMarshalerArgument.ToManaged always uses new JSMarshalerArgument.ToManagedContext
- JSMarshalerArgument.ToManagedContext always uses JSMarshalerArgumentImpl.ContextHandle, no magic
- JSMarshalerArgument.ToJS always uses new JSMarshalerArgument.ToJSContext
- JSMarshalerArgument.ToJSContext during JSImport uses JSProxyContext.CurrentOperationContext otherwise JSMarshalerArgumentImpl.ContextHandle
@pavelsavara
pavelsavara
commented
Dec 18, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 18, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
commented
Dec 18, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 18, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment thread...pt/src/System/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Exception.cs
Outdated

kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/managed-exports.ts
kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/marshal.ts
kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/marshal.ts
Outdated

kg
kg
approved these changes
Dec 18, 2023
View reviewed changes
@pavelsavara
feedback
9b8e3ad
cancellation thread safe
Active issue dotnet#96173
@pavelsavara
pavelsavara
commented
Dec 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 19, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
commented
Dec 19, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Filed new issues
#96173
#96190
#96191
@pavelsavara
pavelsavara
commented
Dec 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 19, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
merged commit 8bd23f0
into
dotnet:mainDec 20, 2023
@pavelsavara
pavelsavara
deleted the

browser_proxy_context

branch
December 20, 2023 07:57

This was referenced Jan 3, 2024

Closed


Open

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jan 19, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marafmarafmaraf approved these changes
@lambdageeklambdageekAwaiting requested review from lambdageek
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptos-browserBrowser variant of arch-wasm

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelsavara@kg@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[browser] introduce JSProxyContext - #95959
Merged
pavelsavara merged 26 commits into
dotnet:mainfrom 
pavelsavara:browser_proxy_context
Dec 20, 2023
Merged
[browser] introduce JSProxyContext#95959
pavelsavara merged 26 commits into
dotnet:mainfrom 
pavelsavara:browser_proxy_context
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Dec 13, 2023•

edited

Loading

Copy link


Copy Markdown

Member
  • introduce JSProxyContext which collects all proxies and handles relevant to particular WebWorker/UI thread
  • introduce thread local JSProxyContext.OperationStack to know the context of the current operation.

    • most of the time, this matches the current thread
    • sometimes, we pass JSObject instance to JSImport. Such instance already has thread affinity
    • we will use JSProxyContext.CaptureContextFromParameter to capture the target thread to call into.
    • The dispatch to it is next PR.
  • move all handle related code into JSProxyContext
  • use target JSProxyContext instance as a lock around operations with handles.
  • introduced JSObject.ProxyContext also for non-MT build. It simplifies the #if FEATURE_WASM_THREADS hell.
  • make CancelablePromise more async
  • drop IsThreadCaptured it was bit misleading
  • new mono_wasm_invoke_method_raw which doesn't require existing JSProxyContext, for early calls.
  • new push_operation, pop_operation to be called before JSExport calls
  • renamed install_synchronization_context -> install_main_synchronization_context
@pavelsavarapavelsavara
added

arch-wasm
WebAssembly architecture
area-System.Runtime.InteropServices.JavaScript

os-browser
Browser variant of arch-wasm
labels
Dec 13, 2023
@pavelsavarapavelsavara
added this to the 9.0.0 milestone
Dec 13, 2023
@pavelsavarapavelsavara
self-assigned this
Dec 13, 2023
@ghost
ghost
commented
Dec 13, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • introduce JSProxyContext which collects all proxies and handles relevant to particular WebWorker/UI thread
  • introduce thread local JSProxyContext.CapturedInstance to know the context of the current operation.

    • most of the time, this matches the current thread
    • sometimes, we pass JSObject instance to JSImport. Such instance already has thread affinity and we will use it to capture the target thread to call into.
  • move all handle related code into JSProxyContext
  • use target JSProxyContext instance as a lock around operations with handles.
  • introduced JSObject.ProxyContext also for non-MT build. It simplifies the #if FEATURE_WASM_THREADS hell.
  • make CancelablePromise more async
  • drop IsThreadCaptured it was bit misleading
  • new mono_wasm_invoke_method_raw which doesn't require existing JSProxyContext, for early calls.
  • new capture_proxy_context to be called before JSExport call
  • renamed install_synchronization_context -> install_main_synchronization_context
Author:pavelsavara
Assignees:pavelsavara
Labels:
arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone:9.0.0
@pavelsavarapavelsavara
mentioned this pull request
Dec 13, 2023
 Merged

@pavelsavara
pavelsavara
commented
Dec 13, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 13, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
marked this pull request as ready for review
December 13, 2023 16:43
kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...ries/System.Runtime.InteropServices.JavaScript/System.Runtime.InteropServices.JavaScript.sln
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...nteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSFunctionBinding.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSMarshalerArgument.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSObject.References.cs
Outdated

@pavelsavara
pavelsavara
commented
Dec 17, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 17, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
maraf
maraf
approved these changes
Dec 18, 2023
View reviewed changes
Comment thread...m.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSHost.cs
Outdated

Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSMarshalerArgument.cs
Outdated

Comment thread...e.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSProxyContext.cs
Outdated

@pavelsavara
remove complexity of PendingOperation maintanance
f56baa1
 - new JSMarshalerArgumentImpl.ContextHandle field
- all calls from JS side will set JSMarshalerArgumentImpl.ContextHandle with current thread context
- via set_arg_proxy_context
- all calls to JS where runtime calls stackalloc JSMarshalerArgument will set JSMarshalerArgumentImpl.ContextHandle with Context of promise or function affinity
- it will use InitializeWithContext, JSImportNoCapture
- these are Task and Function callbacks to JS
- JSMarshalerArgument.ToManaged always uses new JSMarshalerArgument.ToManagedContext
- JSMarshalerArgument.ToManagedContext always uses JSMarshalerArgumentImpl.ContextHandle, no magic
- JSMarshalerArgument.ToJS always uses new JSMarshalerArgument.ToJSContext
- JSMarshalerArgument.ToJSContext during JSImport uses JSProxyContext.CurrentOperationContext otherwise JSMarshalerArgumentImpl.ContextHandle
@pavelsavara
pavelsavara
commented
Dec 18, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 18, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
commented
Dec 18, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 18, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment thread...pt/src/System/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Exception.cs
Outdated

kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/managed-exports.ts
kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/marshal.ts
kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/marshal.ts
Outdated

kg
kg
approved these changes
Dec 18, 2023
View reviewed changes
@pavelsavara
feedback
9b8e3ad
cancellation thread safe
Active issue dotnet#96173
@pavelsavara
pavelsavara
commented
Dec 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 19, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
commented
Dec 19, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Filed new issues
#96173
#96190
#96191
@pavelsavara
pavelsavara
commented
Dec 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 19, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
merged commit 8bd23f0
into
dotnet:mainDec 20, 2023
@pavelsavara
pavelsavara
deleted the

browser_proxy_context

branch
December 20, 2023 07:57

This was referenced Jan 3, 2024

Closed


Open

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jan 19, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marafmarafmaraf approved these changes
@lambdageeklambdageekAwaiting requested review from lambdageek
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptos-browserBrowser variant of arch-wasm

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelsavara@kg@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[browser] introduce JSProxyContext - #95959
Merged
pavelsavara merged 26 commits into
dotnet:mainfrom 
pavelsavara:browser_proxy_context
Dec 20, 2023
Merged
[browser] introduce JSProxyContext#95959
pavelsavara merged 26 commits into
dotnet:mainfrom 
pavelsavara:browser_proxy_context
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Dec 13, 2023•

edited

Loading

Copy link


Copy Markdown

Member
  • introduce JSProxyContext which collects all proxies and handles relevant to particular WebWorker/UI thread
  • introduce thread local JSProxyContext.OperationStack to know the context of the current operation.

    • most of the time, this matches the current thread
    • sometimes, we pass JSObject instance to JSImport. Such instance already has thread affinity
    • we will use JSProxyContext.CaptureContextFromParameter to capture the target thread to call into.
    • The dispatch to it is next PR.
  • move all handle related code into JSProxyContext
  • use target JSProxyContext instance as a lock around operations with handles.
  • introduced JSObject.ProxyContext also for non-MT build. It simplifies the #if FEATURE_WASM_THREADS hell.
  • make CancelablePromise more async
  • drop IsThreadCaptured it was bit misleading
  • new mono_wasm_invoke_method_raw which doesn't require existing JSProxyContext, for early calls.
  • new push_operation, pop_operation to be called before JSExport calls
  • renamed install_synchronization_context -> install_main_synchronization_context
@pavelsavarapavelsavara
added

arch-wasm
WebAssembly architecture
area-System.Runtime.InteropServices.JavaScript

os-browser
Browser variant of arch-wasm
labels
Dec 13, 2023
@pavelsavarapavelsavara
added this to the 9.0.0 milestone
Dec 13, 2023
@pavelsavarapavelsavara
self-assigned this
Dec 13, 2023
@ghost
ghost
commented
Dec 13, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • introduce JSProxyContext which collects all proxies and handles relevant to particular WebWorker/UI thread
  • introduce thread local JSProxyContext.CapturedInstance to know the context of the current operation.

    • most of the time, this matches the current thread
    • sometimes, we pass JSObject instance to JSImport. Such instance already has thread affinity and we will use it to capture the target thread to call into.
  • move all handle related code into JSProxyContext
  • use target JSProxyContext instance as a lock around operations with handles.
  • introduced JSObject.ProxyContext also for non-MT build. It simplifies the #if FEATURE_WASM_THREADS hell.
  • make CancelablePromise more async
  • drop IsThreadCaptured it was bit misleading
  • new mono_wasm_invoke_method_raw which doesn't require existing JSProxyContext, for early calls.
  • new capture_proxy_context to be called before JSExport call
  • renamed install_synchronization_context -> install_main_synchronization_context
Author:pavelsavara
Assignees:pavelsavara
Labels:
arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone:9.0.0
@pavelsavarapavelsavara
mentioned this pull request
Dec 13, 2023
 Merged

@pavelsavara
pavelsavara
commented
Dec 13, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 13, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
marked this pull request as ready for review
December 13, 2023 16:43
kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...ries/System.Runtime.InteropServices.JavaScript/System.Runtime.InteropServices.JavaScript.sln
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...nteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSFunctionBinding.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSMarshalerArgument.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSObject.References.cs
Outdated

@pavelsavara
pavelsavara
commented
Dec 17, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 17, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
maraf
maraf
approved these changes
Dec 18, 2023
View reviewed changes
Comment thread...m.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSHost.cs
Outdated

Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSMarshalerArgument.cs
Outdated

Comment thread...e.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSProxyContext.cs
Outdated

@pavelsavara
remove complexity of PendingOperation maintanance
f56baa1
 - new JSMarshalerArgumentImpl.ContextHandle field
- all calls from JS side will set JSMarshalerArgumentImpl.ContextHandle with current thread context
- via set_arg_proxy_context
- all calls to JS where runtime calls stackalloc JSMarshalerArgument will set JSMarshalerArgumentImpl.ContextHandle with Context of promise or function affinity
- it will use InitializeWithContext, JSImportNoCapture
- these are Task and Function callbacks to JS
- JSMarshalerArgument.ToManaged always uses new JSMarshalerArgument.ToManagedContext
- JSMarshalerArgument.ToManagedContext always uses JSMarshalerArgumentImpl.ContextHandle, no magic
- JSMarshalerArgument.ToJS always uses new JSMarshalerArgument.ToJSContext
- JSMarshalerArgument.ToJSContext during JSImport uses JSProxyContext.CurrentOperationContext otherwise JSMarshalerArgumentImpl.ContextHandle
@pavelsavara
pavelsavara
commented
Dec 18, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 18, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
commented
Dec 18, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 18, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment thread...pt/src/System/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Exception.cs
Outdated

kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/managed-exports.ts
kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/marshal.ts
kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/marshal.ts
Outdated

kg
kg
approved these changes
Dec 18, 2023
View reviewed changes
@pavelsavara
feedback
9b8e3ad
cancellation thread safe
Active issue dotnet#96173
@pavelsavara
pavelsavara
commented
Dec 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 19, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
commented
Dec 19, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Filed new issues
#96173
#96190
#96191
@pavelsavara
pavelsavara
commented
Dec 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 19, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
merged commit 8bd23f0
into
dotnet:mainDec 20, 2023
@pavelsavara
pavelsavara
deleted the

browser_proxy_context

branch
December 20, 2023 07:57

This was referenced Jan 3, 2024

Closed


Open

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jan 19, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marafmarafmaraf approved these changes
@lambdageeklambdageekAwaiting requested review from lambdageek
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptos-browserBrowser variant of arch-wasm

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelsavara@kg@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[browser] introduce JSProxyContext - #95959
Merged
pavelsavara merged 26 commits into
dotnet:mainfrom 
pavelsavara:browser_proxy_context
Dec 20, 2023
Merged
[browser] introduce JSProxyContext#95959
pavelsavara merged 26 commits into
dotnet:mainfrom 
pavelsavara:browser_proxy_context
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Dec 13, 2023•

edited

Loading

Copy link


Copy Markdown

Member
  • introduce JSProxyContext which collects all proxies and handles relevant to particular WebWorker/UI thread
  • introduce thread local JSProxyContext.OperationStack to know the context of the current operation.

    • most of the time, this matches the current thread
    • sometimes, we pass JSObject instance to JSImport. Such instance already has thread affinity
    • we will use JSProxyContext.CaptureContextFromParameter to capture the target thread to call into.
    • The dispatch to it is next PR.
  • move all handle related code into JSProxyContext
  • use target JSProxyContext instance as a lock around operations with handles.
  • introduced JSObject.ProxyContext also for non-MT build. It simplifies the #if FEATURE_WASM_THREADS hell.
  • make CancelablePromise more async
  • drop IsThreadCaptured it was bit misleading
  • new mono_wasm_invoke_method_raw which doesn't require existing JSProxyContext, for early calls.
  • new push_operation, pop_operation to be called before JSExport calls
  • renamed install_synchronization_context -> install_main_synchronization_context
@pavelsavarapavelsavara
added

arch-wasm
WebAssembly architecture
area-System.Runtime.InteropServices.JavaScript

os-browser
Browser variant of arch-wasm
labels
Dec 13, 2023
@pavelsavarapavelsavara
added this to the 9.0.0 milestone
Dec 13, 2023
@pavelsavarapavelsavara
self-assigned this
Dec 13, 2023
@ghost
ghost
commented
Dec 13, 2023

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • introduce JSProxyContext which collects all proxies and handles relevant to particular WebWorker/UI thread
  • introduce thread local JSProxyContext.CapturedInstance to know the context of the current operation.

    • most of the time, this matches the current thread
    • sometimes, we pass JSObject instance to JSImport. Such instance already has thread affinity and we will use it to capture the target thread to call into.
  • move all handle related code into JSProxyContext
  • use target JSProxyContext instance as a lock around operations with handles.
  • introduced JSObject.ProxyContext also for non-MT build. It simplifies the #if FEATURE_WASM_THREADS hell.
  • make CancelablePromise more async
  • drop IsThreadCaptured it was bit misleading
  • new mono_wasm_invoke_method_raw which doesn't require existing JSProxyContext, for early calls.
  • new capture_proxy_context to be called before JSExport call
  • renamed install_synchronization_context -> install_main_synchronization_context
Author:pavelsavara
Assignees:pavelsavara
Labels:
arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone:9.0.0
@pavelsavarapavelsavara
mentioned this pull request
Dec 13, 2023
 Merged

@pavelsavara
pavelsavara
commented
Dec 13, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 13, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
marked this pull request as ready for review
December 13, 2023 16:43
kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...ries/System.Runtime.InteropServices.JavaScript/System.Runtime.InteropServices.JavaScript.sln
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...nteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSFunctionBinding.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSMarshalerArgument.cs
Outdated

kg
kg
reviewed
Dec 13, 2023
View reviewed changes
Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSObject.References.cs
Outdated

@pavelsavara
pavelsavara
commented
Dec 17, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 17, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
maraf
maraf
approved these changes
Dec 18, 2023
View reviewed changes
Comment thread...m.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSHost.cs
Outdated

Comment thread...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSMarshalerArgument.cs
Outdated

Comment thread...e.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSProxyContext.cs
Outdated

@pavelsavara
remove complexity of PendingOperation maintanance
f56baa1
 - new JSMarshalerArgumentImpl.ContextHandle field
- all calls from JS side will set JSMarshalerArgumentImpl.ContextHandle with current thread context
- via set_arg_proxy_context
- all calls to JS where runtime calls stackalloc JSMarshalerArgument will set JSMarshalerArgumentImpl.ContextHandle with Context of promise or function affinity
- it will use InitializeWithContext, JSImportNoCapture
- these are Task and Function callbacks to JS
- JSMarshalerArgument.ToManaged always uses new JSMarshalerArgument.ToManagedContext
- JSMarshalerArgument.ToManagedContext always uses JSMarshalerArgumentImpl.ContextHandle, no magic
- JSMarshalerArgument.ToJS always uses new JSMarshalerArgument.ToJSContext
- JSMarshalerArgument.ToJSContext during JSImport uses JSProxyContext.CurrentOperationContext otherwise JSMarshalerArgumentImpl.ContextHandle
@pavelsavara
pavelsavara
commented
Dec 18, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 18, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
commented
Dec 18, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 18, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment thread...pt/src/System/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Exception.cs
Outdated

kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/managed-exports.ts
kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/marshal.ts
kg
kg
reviewed
Dec 18, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/marshal.ts
Outdated

kg
kg
approved these changes
Dec 18, 2023
View reviewed changes
@pavelsavara
feedback
9b8e3ad
cancellation thread safe
Active issue dotnet#96173
@pavelsavara
pavelsavara
commented
Dec 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 19, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
commented
Dec 19, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Filed new issues
#96173
#96190
#96191
@pavelsavara
pavelsavara
commented
Dec 19, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Dec 19, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@pavelsavara
pavelsavara
merged commit 8bd23f0
into
dotnet:mainDec 20, 2023
@pavelsavara
pavelsavara
deleted the

browser_proxy_context

branch
December 20, 2023 07:57

This was referenced Jan 3, 2024

Closed


Open

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jan 19, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marafmarafmaraf approved these changes
@lambdageeklambdageekAwaiting requested review from lambdageek
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar

+1 more reviewer

@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptos-browserBrowser variant of arch-wasm

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelsavara@kg@maraf