feat: add PUT, HEAD, DELETE, and PATCH HTTP methods - #6
Open
soyuka wants to merge 2 commits into
Open
Conversation
This was referenced Feb 23, 2026
soyuka
commented
Feb 23, 2026
CollaboratorAuthor
Stack: 1/6 → |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds the missing HTTP method wrappers to SolidClient: - put(): creates/overwrites resources, with optional container Link header - head(): retrieves resource metadata headers - delete(): removes resources - patch(): updates resources via SPARQL Update or N3 Patch Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
soyukaforce-pushed
the
feat/http-methods
branch
from
February 23, 2026 21:08
25ef70a to
d63fe47Comparedunglas
approved these changes
Mar 19, 2026
There was a problem hiding this comment.
Pull request overview
This PR extends the core SolidClient HTTP surface area by adding first-class support for additional HTTP verbs commonly used in Solid/LDP interactions, while also applying minor code-style fixes (explicit nullable types and fully-qualified \sprintf).
Changes:
- Add
put(),head(),delete(), andpatch()toSolidClient(withpatch()defaulting toapplication/sparql-update). - Add PHPUnit coverage for the new methods using Symfony’s
MockHttpClient/MockResponse. - Apply CS Fixer-driven signature/style updates (explicit
?Typenullability,\sprintf).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/SolidClientTest.php | Adds unit tests covering PUT/HEAD/DELETE/PATCH behavior and headers/body defaults. |
| src/SolidClientFactory.php | Makes the optional OidcClient argument explicitly nullable (?OidcClient). |
| src/SolidClient.php | Implements the new HTTP verb methods and updates a few signatures/sprintf calls. |
| src/Bundle/Form/SolidLoginType.php | Makes the validation callback closure static (no $this capture). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
put(),head(),delete(), andpatch()methods toSolidClientput()supports optional LDP BasicContainer Link header for container creationpatch()defaults toapplication/sparql-update, also supportstext/n3for N3 Patch\sprintf)Stack
1/8 — This PR →
mainTest plan
🤖 Generated with Claude Code