feat: add ResourceMetadata value object from HEAD - #7
Open
soyuka wants to merge 3 commits into
Open
Conversation
This was referenced Feb 23, 2026
soyuka
commented
Feb 23, 2026
CollaboratorAuthor
Stack: 2/6 — builds on #6 |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds the missing HTTP method wrappers to SolidClient: - put(): creates/overwrites resources, with optional container Link header - head(): retrieves resource metadata headers - delete(): removes resources - patch(): updates resources via SPARQL Update or N3 Patch Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
soyukaforce-pushed
the
feat/resource-metadata
branch
from
February 23, 2026 21:08
e7898c8 to
625edd5CompareParses HEAD response headers into a structured ResourceMetadata object with content type, length, last modified, LDP type, WAC-Allow permissions, and ACL URL from Link headers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
soyukaforce-pushed
the
feat/resource-metadata
branch
from
February 24, 2026 09:14
625edd5 to
34512cfCompareThere was a problem hiding this comment.
Pull request overview
Adds a ResourceMetadata value object that can be derived from HEAD response headers, and exposes a SolidClient::getResourceMetadata() convenience method to fetch and parse that metadata.
Changes:
- Introduces
ResourceMetadatawith parsing forContent-Type,Content-Length,Last-Modified,Link(LDP type + ACL), andWAC-Allow. - Adds
SolidClient::getResourceMetadata()(HEAD + header parsing) and related HTTP method helpers used by the client API. - Updates Composer requirements (PHP and Symfony versions) and adds unit tests for parsing behavior.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/ResourceMetadata.php | New value object and header parsing logic for resource metadata. |
src/SolidClient.php | Adds getResourceMetadata() convenience method (and related HTTP helpers in this diff). |
tests/ResourceMetadataTest.php | Unit tests for metadata parsing from normalized headers. |
tests/SolidClientTest.php | Adds unit tests around SolidClient request construction for multiple HTTP methods. |
composer.json | Bumps PHP/Symfony constraints and adds symfony/web-link dependency. |
src/SolidClientFactory.php | Minor signature update to explicit nullable parameter type. |
src/Bundle/Form/SolidLoginType.php | Makes the validation callback static (no capture). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| public static function isContainerType(string $type): bool | ||
| { | ||
| return 'http://www.w3.org/ns/ldp#BasicContainer' === $type | ||
| || 'http://www.w3.org/ns/ldp#Container' === $type; |
Comment on lines
+51
to
+53
| $contentLength = isset($responseHeaders['content-length'][0]) | ||
| ? (int) $responseHeaders['content-length'][0] | ||
| : null; |
Comment on lines
+99
to
+104
| public function getResourceMetadata(string $url, array $options = []): ResourceMetadata | ||
| { | ||
| $response = $this->head($url, $options); | ||
| return ResourceMetadata::fromResponseHeaders($response->getHeaders(false)); | ||
| } |
Comment on lines
21
to
+52
| @@ -32,22 +33,22 @@ | |||
| "web-token/jwt-signature-algorithm-rsa": "^3.0" | |||
| }, | |||
| "require-dev": { | |||
| "symfony/form": "^6.0", | |||
| "symfony/framework-bundle": "^6.0", | |||
| "symfony/http-foundation": "^6.0", | |||
| "symfony/validator": "^6.0", | |||
| "symfony/dependency-injection": "^6.0", | |||
| "symfony/routing": "^6.0", | |||
| "symfony/security-bundle": "^6.0", | |||
| "symfony/twig-bundle": "^6.0", | |||
| "symfony/debug-bundle": "^6.0", | |||
| "symfony/web-profiler-bundle": "^6.0", | |||
| "symfony/console": "^6.0", | |||
| "symfony/stopwatch": "^6.0", | |||
| "symfony/phpunit-bridge": "^6.0", | |||
| "symfony/browser-kit": "^6.0", | |||
| "symfony/css-selector": "^6.0", | |||
| "symfony/security-core": "^6.0", | |||
| "vimeo/psalm": "^5.12" | |||
| "symfony/form": "^7.4", | |||
| "symfony/framework-bundle": "^7.4", | |||
| "symfony/http-foundation": "^7.4", | |||
| "symfony/validator": "^7.4", | |||
| "symfony/dependency-injection": "^7.4", | |||
| "symfony/routing": "^7.4", | |||
| "symfony/security-bundle": "^7.4", | |||
| "symfony/twig-bundle": "^7.4", | |||
| "symfony/debug-bundle": "^7.4", | |||
| "symfony/web-profiler-bundle": "^7.4", | |||
| "symfony/console": "^7.4", | |||
| "symfony/stopwatch": "^7.4", | |||
| "symfony/phpunit-bridge": "^7.4", | |||
| "symfony/browser-kit": "^7.4", | |||
| "symfony/css-selector": "^7.4", | |||
| "symfony/security-core": "^7.4", | |||
| "vimeo/psalm": "^5.12 || ^6.0" | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResourceMetadatavalue object parsed from HEAD response headersgetResourceMetadata()convenience method toSolidClientisContainer()helper checks LDP typeStack
2/8 — builds on #6 (
feat/http-methods)Test plan
🤖 Generated with Claude Code