Skip to content

feat: prebuild minidump - #42

Merged
nornagon merged 6 commits into
electron:masterfrom
aminya:prebuild
Feb 1, 2021
Merged

feat: prebuild minidump#42
nornagon merged 6 commits into
electron:masterfrom
aminya:prebuild

Conversation

@aminya

@aminyaaminya commented Feb 1, 2021

Copy link
Copy Markdown
Contributor

This makes it possible to include the binaries in the npm package.

Description

The build script makes a bin folder that includes the binaries. These binaries are used by the main file.

bin
|_linux-x64
|_dump_syms
|_minidump_dump
|_minidump_stackwalk
|_darwin-x64
|_dump_syms
|_minidump_dump
|_minidump_stackwalk

I assumed that the release process is done after manually by downloading the artifacts from the last GitHub action run. I can add an automatic release action if you prefer this to be done by the semantic-release bot.

Issues

Fixes#41

Verification

A successful CI run:
https://github.com/aminya/node-minidump/actions/runs/528963738

The artifacts:
https://github.com/aminya/node-minidump/suites/1945608672/artifacts/38471951

@aminyaaminya changed the title Prebuild minidumpfeat: prebuild minidumpFeb 1, 2021
@aminya
aminyaforce-pushed the prebuild branch 2 times, most recently from 0dd75f1 to f16a255CompareFebruary 1, 2021 20:25
@aminya
aminya marked this pull request as ready for review February 1, 2021 21:01
@aminya

Copy link
Copy Markdown
ContributorAuthor

@nornagon Could you review this?

@ckerr
ckerr requested a review from a teamFebruary 1, 2021 21:06
Comment threadpackage.json
@nornagon
nornagon merged commit e0821aa into electron:masterFeb 1, 2021
aminya referenced this pull request Apr 9, 2021
@nornagon

Copy link
Copy Markdown
Collaborator

Hey there, while publishing this I noticed that the Linux binaries are quite large, around 15 MB. I think this is because they are unstripped. Running strip on the binaries reduces the size to about 1.5 MB.

Can we find a way to strip the linux binaries to reduce the download size? The breakpad source is itself already quite large.

@aminya

Copy link
Copy Markdown
ContributorAuthor

Hey there, while publishing this I noticed that the Linux binaries are quite large, around 15 MB. I think this is because they are unstripped. Running strip on the binaries reduces the size to about 1.5 MB.

Can we find a way to strip the linux binaries to reduce the download size? The breakpad source is itself already quite large.

We can do it for all the binaries. Here is the code:
https://www.github.com/prebuild/prebuild/tree/master/strip.js

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prebuild node-minidump

3 participants

@aminya@nornagon@ckerr