fix: chmod binaries before publishing

[aminya]

The permissions might be lost when uploaded and downloaded again. This ensures they are executables before publishing.

The reason: https://github.com/actions/upload-artifact#permission-loss

[aminya]

@nornagon This is a follow up to #42

[nornagon]

Have you observed a failure that this fixes? As far as I can tell, the executables should have the correct permissions after being built, copyFileSync preserves permissions, and npm packages are tarballs, which preserve permissions, so this shouldn't be necessary.

[aminya]

In the Atom CI, there is an EACCES issue which I think is fixed by this.

https://github.visualstudio.com/Atom/_build/results?buildId=97695&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=274baec0-c438-5f9e-e2fa-e6a84e183e1e&l=34

I am running a new CI on the new version of my fork which includes this PR:
atom/atom#21916

[nornagon]

Ah, I see, the permission is lost between Github Actions and npm publish.

[aminya]

The issue is not fixed yet.

atom/atom#21916

https://github.visualstudio.com/Atom/_build/results?buildId=97705&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=274baec0-c438-5f9e-e2fa-e6a84e183e1e&l=34

I am on Windows (I publish from Windows). Not sure if that is relevant.

[aminya]

@nornagon Could you merge this, pack the package and test it in a dummy folder? Because I am on Windows, I can't easily verify if the permissions change on Linux binaries.

[nornagon]

@aminya publishing should happen automatically, you can test it yourself after that I believe!

[aminya]

It's about an hour and nothing has been published. Are you sure that the publishing is automatic?

[nornagon]

Ah, it looks like indeed this repo isn't set up for that. My apologies, most in the Electron organization are.

On closer inspection though, it seems this PR will have no effect, because the published packages do not contain anything in bin/: https://unpkg.com/browse/minidump@0.19.0/

[EDIT]: ah I see, we've updated the build instructions since then. Sorry, it's been a minute and I'm operating at new-dad brain levels 😅

[aminya]

Yes, I made this PR as a follow-up to #42 which was never published too.

Would you please register a new version manually? It will fix #46.