Uh oh!
There was an error while loading. Please reload this page.
Add Projections for LiveComponent and JSON View Controllers - #80
Conversation
mhanberg
commented
May 9, 2023
zolrath
commented
May 9, 2023
Sounds good! I've never made tests for a neovim plugin but if you have examples of tests for other projections I can definitely add them as needed for the PR! |
mhanberg
commented
May 9, 2023
I'm sort of in the same boat, as the existing tests are more or less basic unit tests of lua code, whereas the tests i'd like to write for this actually make neovim do stuff. |
mhanberg
commented
May 13, 2023
Some test fixtures were just merged into main, so if you rebase you should be able to utilize them to write some tests |
5d07ace to
5afed24Compare
Okay great! Do you have an example of how you're running the current tests? Not quite sure how that's being orchestrated and it doesn't seem documented yet! From what I can tell it's likely something akin to:
but it would be nice to be sure! Seems like I'd need to independently have Plenary installed in my vim config for that? |
mhanberg
commented
May 18, 2023
There is a script in bin called test-local. And yes plenary has to be in your config, but I believe the plug-in needs it so you should already have it. |
mhanberg
commented
Jun 7, 2023
9c0d99d to
8757d9fCompare8757d9f to
e28589eCompare
From what I can tell the JSON view controller can be fairly light and doesn't have the same level of structure as the HTML view controller, but I've added it as well as a Live Component projection!