Uh oh!
There was an error while loading. Please reload this page.
Fix umbrella app detection - #88
Merged
Merged
Conversation
mhanberg
reviewed
May 9, 2023
Uh oh!
There was an error while loading. Please reload this page.
mhanberg
approved these changes
May 13, 2023
mhanberg
left a comment
Collaborator
There was a problem hiding this comment.
This looks good! I'll merge if you're done making changes, just let me know.
ContributorAuthor
There was a problem hiding this comment.
Thanks! I've just rebased with main, so it should be good to merge 👍
mhanberg
commented
May 13, 2023
Collaborator
Can you rebase on main actually? |
- adds tests for `elixir.utils.root_dir`
mhanberg
enabled auto-merge (squash)
May 13, 2023 16:57
mhanberg
disabled auto-merge
May 13, 2023 16:57
mhanberg
enabled auto-merge (squash)
May 13, 2023 16:57
mhanberg
commented
May 13, 2023
Collaborator
Thanks again! 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes umbrella path detection. Currently,
maybe_umbrella_pathis always the same aschild_or_root_pathbecause of howvim.fs.findworks.So this change kind of restores the logic that existed before removing lspconfig dep
Suggestion
It also removes the logic that detects if the umbrella path contains the dir
apps. This was because this path could be set to another name inmix. exswith:apps_path,and maybe it is redundant checking for this when we found themix. exsin a parent dir. But this is a suggestion, and I may be missing something.