WRN-18582: Migrate to webpack5 by MikyungKim · Pull Request #90 · enactjs/dev-utils

MikyungKim · 2022-03-21T02:09:57Z

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

Checklist

I have read and understand the contribution guide
A CHANGELOG entry is included
At least one test case is included for this feature or bug fix
Documentation was added or is not needed
This is an API breaking change

Issue Resolved / Feature Added

Migrated to webpack5

Resolution

Updated APIs of plugins
Added #66
Added ILIB_ADDITIONAL_RESOURCES_PATH as defined constants to resolve process is undefined

Additional Considerations

Verbose plugin needs to be fixed in WRN-19252
Warning related to Compliation.assets needs to be fixed in WRN-19249

Links

WRN-18582

Comments

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

hong6316 · 2022-03-21T07:03:17Z

 const templates = require('./templates');
 const vdomServer = require('./vdom-server-render');

+const preRenderPluginHooksMap = new WeakMap();


Should this name be preRender...? or can be changed to prerender...?

hong6316 · 2022-03-21T07:53:51Z

 	return {head, prerender};
 }

+// Injects assets into html


Those 3 functions(injectAssetsIntoHtml, minifyHtml, postProcessHtml) are copies of html-webpack-plugin`s.
Is it impossible that use htmlPluginData.plugin?

They are now moved to private functions. I can't reach the postProcessHtml function so I had to move these to here.

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

hong6316 · 2022-03-22T07:03:23Z

to @MikyungKim ,
could you answer the below questions?

commands/pack.js
new option --ilib-additional-path added, is it for wp5?
config/webpack.config.js
new ILibPlugin parameter ilibAdditionalResourcesPath added, is it for wp5?
while enact pack,
.ttf files in dist/node_modules/@ enact are double-coloned(ex: Sandstone_Icons..ttf)
I think we need to check this
enact serve not work
enact pack --verbose not work(verbose log not printed)

MikyungKim · 2022-03-22T07:12:06Z

to @MikyungKim , could you answer the below questions?
commands/pack.js
new option --ilib-additional-path added, is it for wp5?
config/webpack.config.js
new ILibPlugin parameter ilibAdditionalResourcesPath added, is it for wp5?

Yes. It's related to the process is undefined issue. enact i18n had process.env access from Loader and glue, so we need to embed the environment variable into the plugin. The enact fix is enactjs/enact#3034.

while enact pack,
.ttf files in dist/node_modules/@ enact are double-coloned(ex: Sandstone_Icons..ttf)
I think we need to check this

🤔 I'm not sure. let's check.

enact serve not work

I tested and it's working. Let me check with you.

enact pack --verbose not work(verbose log not printed)

It'll be handled in the other ticket as I mentioned in the ticket.

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

hong6316

LGTM

* WRN-18582: Migrate to webpack5 (#90) * WRN-18582: webpack5 initial commit Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRN-18582: Migrated isomorphic and snapshot plugin Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update verbose plugin Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix travis errors Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update dependencies Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix based on review Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update shrinkwrap Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRN-12124: Remove deprecated babel-eslint module (#87) * use @babel/eslint-parser * remove babel-preset-react-app * remove @babel/eslint-parser * Revert "remove @babel/eslint-parser" This reverts commit 98ec872. * Revert "remove babel-preset-react-app" This reverts commit 70a93e2. * Revert "use @babel/eslint-parser" This reverts commit 5c15b55. * babel-eslint -> @babel/eslint-parser * add CHANGELOG.md * Update package.json Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * update npm-shrinkwrap.json * removed unused dependency Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update eslint-config-prettier Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * WRN-19252: Fix VerboseLogPlugin is not working (#91) * WRN-19252: Use ProgressPlugin from originated place Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * pinned webpack version Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRN-12748: Update eslint 8 related modules (#88) * update eslint 8 * Update package.json * Update package.json Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * WRN-19694: Support for React18 (#92) * update react version Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update dependencies Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRN-19694: Add react18 support Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRN-20218: Fix eanct pack --framework and --externals options (#93) * WRN-20218: Fix enact pack --framework Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix context Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix lint Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix local node_modules files and files ends with .js module id Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRN-20481: Fixed miss made module id and miss referenced library (#94) Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * Fix prerendering regex Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update dependencies Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com>

MikyungKim added 4 commits March 11, 2022 18:05

WRN-18582: webpack5 initial commit
597ae1b
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

WRN-18582: Migrated isomorphic and snapshot plugin
b612f1a
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

update verbose plugin
fd575e3
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

fix travis errors
25f4cf7
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

hong6316 mentioned this pull request Mar 21, 2022
WRN-16762: Apply changes from CreactReactApp 5.0 #89
Closed

MikyungKim added 2 commits March 21, 2022 15:12

update dependencies
35f7cc2
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

fix
f6818f6
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

hong6316 reviewed Mar 21, 2022
View reviewed changes

fix based on review
0dd65d8
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

update shrinkwrap
472713d
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

hong6316 approved these changes Mar 23, 2022
View reviewed changes

MikyungKim mentioned this pull request Mar 23, 2022
PLAT-78282: mksnapshot from webruntime fails to run when host and tar… #66
Closed

hong6316 merged commit 9a5cd1e into feature/webpack5Mar 23, 2022

hong6316 deleted the feature/WRN-18582 branch March 23, 2022 00:21

Navigation Menu

Uh oh!

WRN-18582: Migrate to webpack5 - #90

WRN-18582: Migrate to webpack5#90
hong6316 merged 8 commits into
feature/webpack5from
feature/WRN-18582

MikyungKim commented Mar 21, 2022•
edited
Loading

Uh oh!

hong6316Mar 21, 2022

Uh oh!

MikyungKimMar 21, 2022

Uh oh!

hong6316Mar 21, 2022

Uh oh!

MikyungKimMar 21, 2022•
edited
Loading

Uh oh!

hong6316 commented Mar 22, 2022•
edited by MikyungKim
Loading

Uh oh!

MikyungKim commented Mar 22, 2022•
edited
Loading

Uh oh!

hong6316 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

MikyungKim commented Mar 21, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Issue Resolved / Feature Added

Resolution

Additional Considerations

Links

Comments

Uh oh!

hong6316Mar 21, 2022

Choose a reason for hiding this comment

Uh oh!

MikyungKimMar 21, 2022

Choose a reason for hiding this comment

Uh oh!

hong6316Mar 21, 2022

Choose a reason for hiding this comment

Uh oh!

MikyungKimMar 21, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hong6316 commented Mar 22, 2022• edited by MikyungKim Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MikyungKim commented Mar 22, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hong6316 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MikyungKim commented Mar 21, 2022•
edited
Loading

MikyungKimMar 21, 2022•
edited
Loading

hong6316 commented Mar 22, 2022•
edited by MikyungKim
Loading

MikyungKim commented Mar 22, 2022•
edited
Loading