Uh oh!
There was an error while loading. Please reload this page.
WRN-19252: Fix VerboseLogPlugin is not working - #91
Merged
Conversation
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
hong6316
approved these changes
Mar 31, 2022
hong6316
left a comment
Contributor
There was a problem hiding this comment.
LGTM
I checked pinning webpack 5.64.4 too.
hong6316 added a commit
that referenced
this pull request
Apr 11, 2022
* WRN-18582: Migrate to webpack5 (#90) * WRN-18582: webpack5 initial commit Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRN-18582: Migrated isomorphic and snapshot plugin Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update verbose plugin Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix travis errors Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update dependencies Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix based on review Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update shrinkwrap Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRN-12124: Remove deprecated babel-eslint module (#87) * use @babel/eslint-parser * remove babel-preset-react-app * remove @babel/eslint-parser * Revert "remove @babel/eslint-parser" This reverts commit 98ec872. * Revert "remove babel-preset-react-app" This reverts commit 70a93e2. * Revert "use @babel/eslint-parser" This reverts commit 5c15b55. * babel-eslint -> @babel/eslint-parser * add CHANGELOG.md * Update package.json Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * update npm-shrinkwrap.json * removed unused dependency Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update eslint-config-prettier Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * WRN-19252: Fix VerboseLogPlugin is not working (#91) * WRN-19252: Use ProgressPlugin from originated place Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * pinned webpack version Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRN-12748: Update eslint 8 related modules (#88) * update eslint 8 * Update package.json * Update package.json Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * WRN-19694: Support for React18 (#92) * update react version Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update dependencies Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRN-19694: Add react18 support Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRN-20218: Fix eanct pack --framework and --externals options (#93) * WRN-20218: Fix enact pack --framework Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix context Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix lint Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix local node_modules files and files ends with .js module id Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRN-20481: Fixed miss made module id and miss referenced library (#94) Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * Fix prerendering regex Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update dependencies Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we'd like to fix enact pack --verbose is not working.
webpack's ProgressPlugin is changed to check if
compileris an instance ofCompiler.Currently, dev-utils and cli have different webpack modules so ProgressPlugin created from dev-utils cannot work correctly.
To remedy this, I've changed to create PrgressPlugin from cli's webpack module.
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)