Skip to content

Support eg. AsyncByteStream(content=b'...') - #127

Merged
lovelydinosaur merged 3 commits into
masterfrom
support-simple-content-on-byte-streams
Aug 2, 2020
Merged

Support eg. AsyncByteStream(content=b'...')#127
lovelydinosaur merged 3 commits into
masterfrom
support-simple-content-on-byte-streams

Conversation

@lovelydinosaur

@lovelydinosaurlovelydinosaur commented Aug 2, 2020

Copy link
Copy Markdown
Contributor

Nicer base class implementations for AsyncByteStream and SyncByteStream.

Allows for eg AsyncByteStream(content=b'...') usages.

Closes#125

@florimondmancaflorimondmanca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! 👍

@florimondmanca

Copy link
Copy Markdown
Contributor

Any docs changes required here too…?

@lovelydinosaur

Copy link
Copy Markdown
ContributorAuthor

@florimondmanca - Nope, should all be picked up by our autodocs. We've not got great documentation around using the interface, but addressing that more fully is something for a different day! :)

@lovelydinosaur
lovelydinosaur merged commit 23e3cbe into masterAug 2, 2020
@lovelydinosaur
lovelydinosaur deleted the support-simple-content-on-byte-streams branch August 2, 2020 11:39
@lovelydinosaurlovelydinosaur mentioned this pull request Aug 3, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Add content=b"" to base stream implementations.

2 participants

@lovelydinosaur@florimondmanca