Uh oh!
There was an error while loading. Please reload this page.
Use named keyword arguments on httpcore streams - #1121
Closed
lovelydinosaur wants to merge 3 commits into
Closed
Conversation
Merged
lovelydinosaur
commented
Aug 5, 2020
ContributorAuthor
Closing in favour of switching to the concrete ByteStream implementations hopefully coming in encode/httpcore#133 Resolved this side in #1126 eg see https://github.com/encode/httpx/pull/1126/files#diff-0746bb9fa941d952b3980a91e14f9d7dR79 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use explicitly named keyword arguments rather than unnamed args, in order to allow us to issue an
httpcore0.10 release that includes encode/httpcore#127, without breaking anything inhttpx.A later follow up can use
content=...to tidy things up here.