Skip to content

Implement socks5 proxy support using socksio - #188

Closed
cdeler wants to merge 7 commits into
encode:masterfrom
cdeler:implement-socks-proxy-using-socksio
Closed

Implement socks5 proxy support using socksio#188
cdeler wants to merge 7 commits into
encode:masterfrom
cdeler:implement-socks-proxy-using-socksio

Conversation

@cdeler

@cdelercdeler commented Sep 17, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

The final draft PR for https://github.com/encode/httpx/issues/203 (I closed previous). It's based on #51, I added @yeraydiazdiaz to co-authored-by

What I did:

  1. added pproxy as a dev. dependency to have a local socks proxy server
  2. added AsyncSOCKSConnection and SyncSOCKSConnection. For now it handles only socks5-without-auth connections

@cdeler
cdeler marked this pull request as draft September 17, 2020 18:04
@cdelercdeler changed the title Implement socks proxy using socksioWIP Implement socks proxy using socksioSep 17, 2020
florimondmanca
florimondmanca reviewed Sep 17, 2020
View reviewed changes

@florimondmancaflorimondmanca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start! Curious if CI passes with this setup 👀

Comment threadhttpcore/_async/connection.py Outdated
@cdeler
cdelerforce-pushed the implement-socks-proxy-using-socksio branch 3 times, most recently from ca5a733 to ca73293CompareSeptember 18, 2020 15:16
@cdeler

cdeler commented Sep 18, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Well, I mostly implemented socks5 proxy support. Now I want to think up what to do with socks4

May be it's better to do it in another PR..?

@cdeler
cdeler marked this pull request as ready for review September 18, 2020 15:24
@cdelercdeler changed the title WIP Implement socks proxy using socksioImplement socks5 proxy support using socksioSep 18, 2020
@cdeler
cdeler requested a review from a teamSeptember 18, 2020 15:34
@cdeler
cdeler marked this pull request as draft September 21, 2020 11:45
@cdeler

cdeler commented Sep 21, 2020

Copy link
Copy Markdown
ContributorAuthor

Converted back to draft until socks4 proxy support has been added (then we can split the PR into chunks)

@cdeler
cdelerforce-pushed the implement-socks-proxy-using-socksio branch from 9b7ea7b to f6da5c4CompareSeptember 24, 2020 14:23
This was referenced Sep 25, 2020
Closed
Merged
@cdeler
cdelerforce-pushed the implement-socks-proxy-using-socksio branch from f6da5c4 to 4618f88CompareOctober 2, 2020 18:52
@cdeler

cdeler commented Oct 2, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I reworked this draft PR according to the @tomchristie 's comment: link

So that right now (A)syncSocksProxy is the wrapper over the (A)syncConnectionPool

The next step I want to do is to merge #199 (it's a PR about migrating http proxy suite from mitmproxy to pproxy)

PS for now this draft is only about socks5 proxy

@lovelydinosaur

lovelydinosaur commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

Now supported in 0.14.5 - https://www.encode.io/httpcore/proxies/#socks-proxy-support

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@florimondmancaflorimondmancaAwaiting requested review from florimondmanca

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cdeler@lovelydinosaur@florimondmanca