Skip to content

Added pproxy test fixture, which allows to test requesting through socks proxy - #196

Closed
cdeler wants to merge 1 commit into
encode:masterfrom
cdeler:add-pproxy-test-fixture
Closed

Added pproxy test fixture, which allows to test requesting through socks proxy#196
cdeler wants to merge 1 commit into
encode:masterfrom
cdeler:add-pproxy-test-fixture

Conversation

@cdeler

@cdelercdeler commented Sep 25, 2020

Copy link
Copy Markdown
Contributor

As a part of https://github.com/encode/httpx/issues/203 (draft pr is #188) I'd like to introduce the "socks" test fixture.

Using pproxy it starts a subprocess with socks4 and socks5 (with auth and without auth) proxies on localhost.

Also the PR contains some new types, required in the fixture

There is a problem: this server doesn't support socks4a proxy (may be it's not so important)

@cdeler
cdeler requested review from a team and lovelydinosaurSeptember 25, 2020 13:05
@cdeler
cdelerforce-pushed the add-pproxy-test-fixture branch from c9a2f01 to 4035450CompareSeptember 28, 2020 14:40
@lovelydinosaur

Copy link
Copy Markdown
Contributor

I don't think this is quite what I was expecting here.
A more minimal first step would be adding some pproxy tests cases for our existing regular HTTP/HTTPS proxy support.

@cdeler

cdeler commented Sep 28, 2020

Copy link
Copy Markdown
ContributorAuthor

@tomchristie

You are talking about proxy_server fixture, which is used by test_http_proxy and test_proxy_https_requests? (if so, I'm doing that)

@pytest.fixture()
defproxy_server(example_org_cert_path: str) ->typing.Iterator[URL]:

@cdeler

Copy link
Copy Markdown
ContributorAuthor

Closing this PR, replacing it by #199

@cdelercdeler closed this Sep 28, 2020
@cdeler
cdeler deleted the add-pproxy-test-fixture branch September 28, 2020 18:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@cdeler@lovelydinosaur