Skip to content

Use Hypercorn for UDS tests - #233

Merged
florimondmanca merged 1 commit into
masterfrom
fm/hypercorn-uds
Nov 8, 2020
Merged

Use Hypercorn for UDS tests#233
florimondmanca merged 1 commit into
masterfrom
fm/hypercorn-uds

Conversation

@florimondmanca

Copy link
Copy Markdown
Contributor

Follow-up to #205

Use hypercorn for UDS tests. Had to refactor HypercornServer a bit to remove the host/port options, and use bind in all cases.

We can't ditch uvicorn entirely because hypercorn is 3.7+ only, so we only install and use uvicorn on 3.6.

The great part here is that we now use the Server interface across all tests.

@florimondmancaflorimondmanca changed the title Use Hypercorn for UDSUse Hypercorn for UDS testsNov 7, 2020
@florimondmanca

Copy link
Copy Markdown
ContributorAuthor

We've got a flake.

 > assert backend.pop_open_tcp_stream_intervals() == [ pytest.approx(0, abs=1e-3), # Retry immediately. pytest.approx(0.5, rel=0.1), # First backoff. pytest.approx(1.0, rel=0.1), # Second (increased) backoff. ]E assert [0.0010938644...1297950744629] == [0 ± 1.0e-03,...1.0 ± 1.0e-01]E At index 0 diff: 0.0010938644409179688 != 0 ± 1.0e-03E Use -v to get the full diff

@florimondmancaflorimondmanca mentioned this pull request Nov 7, 2020
@florimondmanca
florimondmanca requested a review from a teamNovember 7, 2020 13:30

@JayH5JayH5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@florimondmanca
florimondmanca merged commit 3ed845c into masterNov 8, 2020
@florimondmanca
florimondmanca deleted the fm/hypercorn-uds branch November 8, 2020 22:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants

@florimondmanca@JayH5