Skip to content

Fix flaky retries test - #234

Merged
florimondmanca merged 2 commits into
masterfrom
fm/retry-test-flake
Nov 8, 2020
Merged

Fix flaky retries test#234
florimondmanca merged 2 commits into
masterfrom
fm/retry-test-flake

Conversation

@florimondmanca

@florimondmancaflorimondmanca commented Nov 7, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Prompted by #233 (comment)

It's probably due to Hypercorn (#205), that may be a tiny bit slower, and so this is most likely affecting master too.

@florimondmanca
florimondmanca requested a review from a teamNovember 7, 2020 13:29
JayH5
JayH5 approved these changes Nov 8, 2020
View reviewed changes

@JayH5JayH5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering what about Hypercorn may be making this slightly slower 🤔

@florimondmanca

florimondmanca commented Nov 8, 2020

Copy link
Copy Markdown
ContributorAuthor

Okay well, actually master is still looking good now. I'm thinking it might have been a temporary slow-down of GitHub Actions' machines, or something… But still, we can merge this so we avoid any new failures in the future.

@florimondmanca
florimondmanca merged commit db81ed0 into masterNov 8, 2020
@florimondmanca
florimondmanca deleted the fm/retry-test-flake branch November 8, 2020 22:35
@florimondmancaflorimondmanca changed the title Fix flaky testFix flaky retries testNov 8, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@JayH5JayH5JayH5 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

refactor

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@florimondmanca@JayH5