Skip to content

Fix erronous pool timeout case - #681

Closed
lovelydinosaur wants to merge 3 commits into
masterfrom
fix-erronous-pool-timeout-case
Closed

Fix erronous pool timeout case#681
lovelydinosaur wants to merge 3 commits into
masterfrom
fix-erronous-pool-timeout-case

Conversation

@lovelydinosaur

Copy link
Copy Markdown
Contributor

Refs #550.

Fixes an issue where a pool timeout can occur, even though a request has an assigned connection.

It's not clear to me if this is a complete resolution, or if something more substantial (see #653) is actually required.
But either way around I think this resolves an edge case for pool timeout: 0 cases.

Needs a test case.

@lovelydinosaurlovelydinosaur mentioned this pull request May 10, 2023
@nihilSup

Copy link
Copy Markdown

@tomchristie can you use two tests from #653? test_pool_under_load and test_pool_timeout_connection_cleanup to be more specific. Maybe I could add them myself but I don't know how

@lovelydinosaur
lovelydinosaur marked this pull request as ready for review May 17, 2023 13:18
@lovelydinosaurlovelydinosaur mentioned this pull request May 17, 2023
3 tasks
@lovelydinosaur

Copy link
Copy Markdown
ContributorAuthor

I've revised this in #688.
Added failing test cases first in the first commit, then resolved them in the second.

@lovelydinosaur
lovelydinosaur deleted the fix-erronous-pool-timeout-case branch May 17, 2023 13:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@lovelydinosaur@nihilSup