Skip to content

Fix pool timeout edge-case. - #688

Merged
lovelydinosaur merged 3 commits into
masterfrom
fix-connection-pool-timeout-zero-behaviour
May 17, 2023
Merged

Fix pool timeout edge-case.#688
lovelydinosaur merged 3 commits into
masterfrom
fix-connection-pool-timeout-zero-behaviour

Conversation

@lovelydinosaur

@lovelydinosaurlovelydinosaur commented May 17, 2023

Copy link
Copy Markdown
Contributor

Second attempt at #681, with tests.

  • Add tests.
  • Fix implementation.
  • Update CHANGELOG.

Refs #550 (Possible that it resolves it, unclear?)

@lovelydinosaurlovelydinosaur changed the title Add tests for pool timeout zeroAdd tests for pool timeout zero.May 17, 2023
@lovelydinosaurlovelydinosaur added the bug Something isn't working label May 17, 2023
@lovelydinosaurlovelydinosaur changed the title Add tests for pool timeout zero.Fix pool timeout edge-case.May 17, 2023
@lovelydinosaur

Copy link
Copy Markdown
ContributorAuthor

Right, we might as well also get this into the upcoming 0.17.1 release.

@lovelydinosaur
lovelydinosaur requested a review from a teamMay 17, 2023 13:51
@lovelydinosaurlovelydinosaur mentioned this pull request May 17, 2023
@lovelydinosaur
lovelydinosaur merged commit c353ce2 into masterMay 17, 2023
@lovelydinosaur
lovelydinosaur deleted the fix-connection-pool-timeout-zero-behaviour branch May 17, 2023 15:11
bdraco added a commit to home-assistant/core that referenced this pull request Jun 13, 2023
changelog: encode/httpcore@0.17.0...0.17.2encode/httpcore#688 is likely the cause of some onvif issues
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't working

Development

Successfully merging this pull request may close these issues.

4 participants

@lovelydinosaur@Pliner@zanieb@michaeloliverx