Skip to content

Update to httpcore 0.10 - #1126

Merged
lovelydinosaur merged 9 commits into
masterfrom
update-to-httpcore-0.10
Aug 7, 2020
Merged

Update to httpcore 0.10#1126
lovelydinosaur merged 9 commits into
masterfrom
update-to-httpcore-0.10

Conversation

@lovelydinosaur

@lovelydinosaurlovelydinosaur commented Aug 3, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Add UnsupportedProtocol, LocalProtocolError, RemoteProtocolError, remove InvalidURL.
  • Use timeout: Mapping[str, Optional[float] instead of timeout: Dict[str, Optional[float].
  • Remove enforce_http_url and defer all scheme checking to the transport layer.
  • Use httpcore.PlainByteStream/httpcore.IteratorByteStream.
  • Use max_keepalive_connections not max_keepalive

(Also, builds on #1125)

Once httpcore 0.10 is released, we should update the httpcore version pin in this PR, ensure this all passes, and get it pulled in.

@lovelydinosaurlovelydinosaur added this to the v0.14 milestone Aug 3, 2020
StephenBrown2
StephenBrown2 reviewed Aug 3, 2020
View reviewed changes
Comment threadhttpx/_exceptions.py Outdated
lovelydinosaurand others added 2 commits August 5, 2020 12:40
@lovelydinosaurlovelydinosaur mentioned this pull request Aug 5, 2020
Closed
@florimondmancaflorimondmanca mentioned this pull request Aug 5, 2020
Merged
This was referenced Aug 6, 2020
Merged
Merged
@lovelydinosaur
lovelydinosaur merged commit 876e722 into masterAug 7, 2020
@lovelydinosaur
lovelydinosaur deleted the update-to-httpcore-0.10 branch August 7, 2020 13:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@StephenBrown2StephenBrown2StephenBrown2 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

v0.14

Development

Successfully merging this pull request may close these issues.

2 participants

@lovelydinosaur@StephenBrown2